Re: [Intel-wired-lan] [PATCH v2 RESEND] i40e: add an error code check in i40e_vsi_setup

2023-11-07 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Su Hui > Sent: Monday, October 23, 2023 6:50 AM > To: Brandeburg, Jesse ; Nguyen, Anthony L > > Cc: Su Hui ; net...@vger.kernel.org; > kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org; > eduma...@google.com; intel-w

Re: [Intel-wired-lan] [PATCH iwl-next v2 1/3] i40e: Move i40e_is_aq_api_ver_ge helper

2023-11-07 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Ivan > Vecera > Sent: Tuesday, October 24, 2023 1:42 PM > To: net...@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org; Brandeburg, Jesse > ; linux-ker...@vger.kernel.org; Eric Dumazet > ; Nguyen, Anthony L ; > dacam...@red

Re: [Intel-wired-lan] [PATCH iwl-next v2 3/3] i40e: Use helpers to check running FW and AQ API versions

2023-11-07 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Ivan > Vecera > Sent: Tuesday, October 24, 2023 1:42 PM > To: net...@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org; Brandeburg, Jesse > ; linux-ker...@vger.kernel.org; Eric Dumazet > ; Nguyen, Anthony L ; > dacam...@red

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Remove queue tracking fields from i40e_adminq_ring

2023-11-07 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Ivan > Vecera > Sent: Thursday, October 26, 2023 2:09 PM > To: net...@vger.kernel.org > Cc: Drewek, Wojciech ; > intel-wired-...@lists.osuosl.org; Brandeburg, Jesse > ; linux-ker...@vger.kernel.org; Eric Dumazet > ; Nguyen, Anth

Re: [Intel-wired-lan] [PATCH iwl-next 1/1] ice: Block PF reinit if attached to bond

2023-11-07 Thread Jesse Brandeburg
On 11/7/2023 2:40 PM, Sachin Bahadur wrote: > PF interface part of LAG should not allow driver reinit via devlink. The > Bond config will be lost due to driver reinit. ice_devlink_reload_down is > called before PF driver reinit. If PF is attached to bond, > ice_devlink_reload_down returns error. >

[Intel-wired-lan] [PATCH iwl-net] iavf: validate tx_coalesce_usecs even if rx_coalesce_usecs is zero

2023-11-07 Thread Jacob Keller
In __iavf_set_coalesce, the driver checks both ec->rx_coalesce_usecs and ec->tx_coalesce_usecs for validity. It does this via a chain if if/else-if blocks. If every single branch of the series of if statements exited, this would be fine. However, the rx_coalesce_usecs is checked against zero to pri

[Intel-wired-lan] [PATCH iwl-next 1/1] ice: Block PF reinit if attached to bond

2023-11-07 Thread Sachin Bahadur
PF interface part of LAG should not allow driver reinit via devlink. The Bond config will be lost due to driver reinit. ice_devlink_reload_down is called before PF driver reinit. If PF is attached to bond, ice_devlink_reload_down returns error. Reviewed-by: Jacob Keller Signed-off-by: Sachin Baha

Re: [Intel-wired-lan] [PATCH iwl-next 00/10] ice: fix timestamping in reset process

2023-11-07 Thread Tony Nguyen
On 10/25/2023 5:13 AM, Karol Kolacinski wrote: PTP reset process has multiple places where timestamping can end up in an incorrect state. This series introduces a proper state machine for PTP and refactors a large part of the code to ensure that timestamping does not break. This series has qui

[Intel-wired-lan] [PATCH iwl-net v3] ice: fix DDP package download for packages without signature segment

2023-11-07 Thread Paul Greenwalt
From: Dan Nowlin Commit 3cbdb0343022 ("ice: Add support for E830 DDP package segment") incorrectly removed support for package download for packages without a signature segment. These packages include the signature buffer inline in the configurations buffers, and not in a signature segment. Fix

[Intel-wired-lan] [PATCH iwl-net] ice: Fix VF Reset paths when interface in a failed over aggregate

2023-11-07 Thread Dave Ertman
There is an error when an interface has the following conditions: - PF is in an aggregate (bond) - PF has VFs created on it - bond is in a state where it is failed-over to the secondary interface - A VF reset is issued on one or more of those VFs The issue is generated by the originating PF trying

[Intel-wired-lan] [PATCH iwl-net] ice: Restore fix disabling RX VLAN filtering

2023-11-07 Thread Marcin Szycik
Fix setting dis_rx_filtering depending on whether port vlan is being turned on or off. This was originally fixed in commit c793f8ea15e3 ("ice: Fix disabling Rx VLAN filtering with port VLAN enabled"), but while refactoring ice_vf_vsi_init_vlan_ops(), the fix has been lost. Restore the fix along wit