> On Mon, 1 Aug 2011 21:51:40 +0800, Wu Fengguang
> wrote:
>
> > 1) intel_write_eld() is not called at all
> >It seems we need to call intel_write_eld() in other places besides
> >inside ->mode_set(). Is ->detect() the right place to do so? In
> >
On Fri, Aug 05, 2011 at 02:03:41AM +0800, Keith Packard wrote:
> On Thu, 4 Aug 2011 17:40:24 +0800, Wu Fengguang
> wrote:
>
> > Right. I actually have this chunk. dmesg shows that in intel_hdmi_detect(),
> >
> > the drm_encoder object is there, however encoder-&g
ill find invalid ELD data and
hence rightfully abort, even when it sees the ELD_valid indicator.
Thanks to Zhenyu and Bossart for a lot of valuable help and testing.
CC: Zhao Yakui
CC: Wang Zhenyu
CC: Jeremy Bush
CC: Christopher White
CC: "Bossart, Pierre-louis"
Signed-off-by: Ben Skeg
Keith: this version completes the IvyBridge support :)
Bossart: hotplug is working fine now, with some minor issues:
- on G45, monitor hot removal is not handled at all in
i915_driver_irq_handler(). I'll leave it as a future TODO.
- on IvyBridge, _repeated_ plug/unplug will trigger
[ 1183.6
Jeremy Bush
CC: Christopher White
CC: "Bossart, Pierre-louis"
Signed-off-by: Ben Skeggs
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/drm_edid.c | 171 +
drivers/gpu/drm/i915/i915_drv.h |2
drivers/gpu/drm/i915/i915_reg.h | 25 +++
nd happily accept both Fengguang and Wu :)
> Am Sonntag, den 04.09.2011, 05:15 +0800 schrieb Wu Fengguang:
> > Changes from v4: remove a debug call to dump_stack().
> > Thanks to Bossart for catching this!
>
> His first name is Pierre-Louis. I do not know how you address people a
On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote:
> On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang
> wrote:
> > Changes from v4: remove a debug call to dump_stack().
> > Thanks to Bossart for catching this!
> > ---
> >
> > Add ELD support fo
On Sun, Sep 04, 2011 at 06:57:23PM +0800, James Cloos wrote:
> >>>>> "WF" == Wu Fengguang writes:
>
> WF> ... If only the stereo playback capability is reported, the user
> WF> won't be able to start 8-channel playback; if the 8-channel ELD is
ggs
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/drm_edid.c | 171 +++
include/drm/drm_edid.h |9 +
2 files changed, 180 insertions(+)
--- linux-next.orig/include/drm/drm_crtc.h 2011-09-04 09:42:19.0
+0800
+++ linux-next/include/drm/drm_c
Jeremy Bush
CC: Christopher White
CC: Pierre-Louis Bossart
CC: Paul Menzel
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/i915_drv.h |2
drivers/gpu/drm/i915/i915_reg.h | 25
drivers/gpu/drm/i915/intel_display.c | 131 -
drivers/gpu/drm/
I'd like to do more cleanups:
> + int aud_cntl_st;
> + int aud_cntrl_st2;
s/aud_cntrl_st2/aud_cntl_st2/
> + if (IS_IVYBRIDGE(connector->dev)) {
> + hdmiw_hdmiedid = GEN7_HDMIW_HDMIEDID_A;
> + aud_cntl_st = GEN7_AUD_CNTRL_ST_A;
> + aud_cntrl_st2 = G
CC: Wang Zhenyu
CC: Jeremy Bush
CC: Christopher White
CC: Paul Menzel
CC: Pierre-Louis Bossart
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/i915_drv.h |2
drivers/gpu/drm/i915/i915_reg.h | 25
drivers/gpu/drm/i915/intel_display.c | 131 +++
On Mon, Sep 05, 2011 at 07:04:50PM +0800, Chris Wilson wrote:
> On Mon, 5 Sep 2011 09:14:00 +0800, Wu Fengguang
> wrote:
> > On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote:
> > > On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang
> > > wrote:
> >
Hi Christopher,
Sorry I'm just back from traveling..
On Fri, Oct 28, 2011 at 03:54:23AM +0800, Christopher White wrote:
> There appears to be some issues with the patch? I'm on SandyBridge and
> using the HD3000's HDMI.
>
> I've now tried manually merging the EL
Hi Christopher,
> The log does confirm that the drm_edid_to_eld function is running, and
> that we're not far from a solution:
> [ 21.061417] [drm:drm_edid_to_eld], ELD monitor TX-SR607
> [ 21.061421] [drm:drm_edid_to_eld], ELD size 13, SAD count 8
It looks all sane to this point.
> As for
Hi Sander,
> On Tue, Nov 1, 2011 at 8:45 PM, Wu Fengguang wrote:
> > Hi Christopher,
> >
> >> The log does confirm that the drm_edid_to_eld function is running, and
> >> that we're not far from a solution:
> >> [ 21.061417] [drm:drm_edid_t
SandyBridge should be using the same register addresses as IvyBridge.
btw, rename the register names accordingly.
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/i915_reg.h |6 +++---
drivers/gpu/drm/i915/intel_display.c | 10 +-
2 files changed, 8 insertions(+), 8
1 at 03:57:23AM +0800, Christopher White wrote:
> There appears to be some issues with the patch? I'm on SandyBridge and
> using the HD3000's HDMI.
>
> I've now tried manually merging the ELD patch (both files Wu Fengguang
> submitted) and compiling Kernel 3.0.4. I&#x
Hi Takashi,
I enumerated all the DELL DisplayPort monitors in our lab and find
only two of them being able to produce audible DisplayPort audio...
- DELL 2408WFP
- DELL 2709W
- DELL 3008WFP
no CEA extension found
- DELL U2410
ELD reports OK but cannot hear DP sound
monit
Here are the EDID for the DELL monitors, grabbed by command
cp /sys/class/drm/card0-DP-3/edid .
Thanks,
Fengguang
On Wed, Nov 09, 2011 at 03:20:53PM +0800, Wu Fengguang wrote:
> Hi Takashi,
>
> I enumerated all the DELL DisplayPort monitors in our lab and find
> only two o
n logic
Date: Wed Nov 02 17:16:39 CST 2011
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09
10:35:35.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c
Christopher,
Did you enabled CONFIG_SND_DEBUG and CONFIG_SND_DEBUG_VERBOSE in
kconfig? I've been looking for the error messages related to zeroed
ELD but never managed to find any in your dmesg.
Some analyzes of your dmesg:
- all drm_edid_to_eld() invocations reads valid EDID data:
[2.56000
Christopher,
> The dump tool did not work with that environment variable either.
> However, it occurred to me that intel_audio_dump may be too outdated in
> my distro. It was built on 2010-04-01, v1.0.2+git20100324. If I look at
> http://cgit.freedesktop.org/xorg/app/intel-gpu-tools/ I can see tha
Christopher,
On Thu, Nov 10, 2011 at 12:10:42PM +0800, Christopher White wrote:
> On 11/10/11 4:27 AM, Wu Fengguang wrote:
> > Christopher,
> >
> > Did you enabled CONFIG_SND_DEBUG and CONFIG_SND_DEBUG_VERBOSE in
> > kconfig? I've been looking for the error messag
Wow I reproduced the bug and got a very interesting dmesg:
gfx =>[ 4561.287980] [drm:intel_write_eld], ELD on
[CONNECTOR:12:HDMI-A-2], [ENCODER:11:TMDS-11]
gfx =>[ 4561.291730] [drm:ironlake_write_eld], ELD on pipe B
gfx =>[ 4561.293804] [drm:ironlake_write_eld], Audio dir
On Thu, Nov 10, 2011 at 03:33:50PM +0800, Wu Fengguang wrote:
> Wow I reproduced the bug and got a very interesting dmesg:
>
> gfx =>[ 4561.287980] [drm:intel_write_eld], ELD on
> [CONNECTOR:12:HDMI-A-2], [ENCODER:11:TMDS-11]
> gfx =>[ 4561.291730] [drm:iro
On Thu, Nov 10, 2011 at 03:55:22PM +0800, Wu Fengguang wrote:
> On Thu, Nov 10, 2011 at 03:33:50PM +0800, Wu Fengguang wrote:
> > Wow I reproduced the bug and got a very interesting dmesg:
> >
> > gfx =>[ 4561.287980] [drm:intel_write_eld], ELD on
> > [CONNE
On Thu, Nov 10, 2011 at 07:50:11PM +0800, Christopher White wrote:
> On 11/10/11 12:22 PM, Takashi Iwai wrote:
> > At Thu, 10 Nov 2011 12:00:53 +0100,
> > Christopher White wrote:
> >> On 11/10/11 9:55 AM, Christopher White wrote:
> >>> On 11/10/11 8:55 AM, Wu
On Thu, Nov 10, 2011 at 09:01:24PM +0800, Christopher White wrote:
> On 11/10/11 1:56 PM, Wu Fengguang wrote:
> > On Thu, Nov 10, 2011 at 07:50:11PM +0800, Christopher White wrote:
> >> On 11/10/11 12:22 PM, Takashi Iwai wrote:
> >>> At Thu, 10 Nov 2011 12:00:53
> > Got the delay - it's 72.986623-72.747632 = 239ms.
> >
> > [ 72.739944] HDMI hot plug event: Codec=3 Pin=6
> > Presence_Detect=1 ELD_Valid=0
> > [ 72.742541] HDMI status: Codec=3 Pin=6 Presence_Detect=1
> > ELD_Valid=0
> > [ 72.745082] HDMI hot plug event: Code
> > > > So maybe the hardware is in some state that is unable to provide the
> > > > real ELD content?
> > > That's my guess as well. I think the hardware may still be doing some
> > > form of data negotiation with the HDMI display device at that stage, and
> > > doesn't have the copy of the EDID
On Thu, Nov 10, 2011 at 09:51:50PM +0800, Wu Fengguang wrote:
> > > > > So maybe the hardware is in some state that is unable to provide the
> > > > > real ELD content?
> > > > That's my guess as well. I think the hardware may still be doing some
On Thu, Nov 10, 2011 at 09:47:46PM +0800, Wu Fengguang wrote:
> > > Got the delay - it's 72.986623-72.747632 = 239ms.
> > >
> > > [ 72.739944] HDMI hot plug event: Codec=3 Pin=6
> > > Presence_Detect=1 ELD_Valid=0
> > > [ 72.
On Thu, Nov 10, 2011 at 10:28:19PM +0800, Takashi Iwai wrote:
> At Thu, 10 Nov 2011 21:51:50 +0800,
> Wu Fengguang wrote:
> >
> > > > > > So maybe the hardware is in some state that is unable to provide the
> > > > > > real ELD content?
> > &
On Fri, Nov 11, 2011 at 03:40:37PM +0800, Takashi Iwai wrote:
> At Fri, 11 Nov 2011 10:29:25 +0800,
> Wu Fengguang wrote:
> >
> > On Thu, Nov 10, 2011 at 10:28:19PM +0800, Takashi Iwai wrote:
> > > At Thu, 10 Nov 2011 21:51:50 +0800,
> > > Wu Fengguang wrote:
&
t;
> So looks currently nobody cares for hot removal, you need to set that by
> yourself somewhere.
Zhenyu, according to your comments, here is the patch, tested OK on
HDMI :) DP not tested yet.
This notifies the audio driver of the HDMI/DP monitor hot removal
event.
- clear SDVO_AU
On Fri, Nov 11, 2011 at 04:49:57PM +0800, Takashi Iwai wrote:
> At Fri, 11 Nov 2011 16:22:41 +0800,
> Wu Fengguang wrote:
> >
> > On Fri, Nov 11, 2011 at 03:40:37PM +0800, Takashi Iwai wrote:
> > > At Fri, 11 Nov 2011 10:29:25 +0800,
> > > Wu Fengguang wrote:
&
e printks' significantly.
>
> Well, this reminds me of another question -- do we need these printks
> unconditionally?
Maybe not. How about the attached patch to remove them all?
> > And it feels not good that accessing ELD may be blocked for some time..
>
> Understood.
>
On Fri, Nov 11, 2011 at 07:23:05PM +0800, Takashi Iwai wrote:
> At Fri, 11 Nov 2011 19:12:57 +0800,
> Wu Fengguang wrote:
> >
> > (snip)
> > > > > One note that we don't rely on PD bit because not all (non-Intel)
> > > > > hardware report it c
(snip)
> > > > > And I'm not sure whether HDMI audio is played
> > > > > while DPMS is off. I haven't tested it.
> > > >
> > > > It will go silence on DPMS. I noticed this while doing long term HDMI
> > > > audio playback tests. This should better be fixed in future on the
> > > > graphics side.
A bunch of cleanups, fixes and new fields to intel_audio_dump, tested OK on
G45, Ironlake and IvyBridge.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
11:00:39.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 11:01
Convert "Â" (Hex 00ad) to "-" (Hex 2d), the former leads to ugly outputs
in some situations.
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c | 70 ++---
1 file changed, 35 insertions(+), 35 deletions(-)
--- intel-
The raw channel count is not user friendly and may be misleading.
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09
16:21:43.0 +0800
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09
10:35:34.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-09 10:35:35.0
- no need to show the 1-bit AUD_OUT_DIG_CNVT_* as hex value
- show the Connection_select_Control_* bits as hex values
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
--- intel-gpu-tools.orig/tools
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09
10:35:35.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-09 10:35:35.0
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09
10:35:34.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-09 10:35:34.0
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c | 47 +
1 file changed, 27 insertions(+), 20 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:19:06.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c
The original test mistakenly calls dump_cpt() for Ironlake,
due to HAS_PCH_SPLIT := IS_GEN5 || IS_GEN6 || IS_GEN7.
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c |8
1 file changed, 8 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:47.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:48.0
+0800
@@ -455,6
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c |2 ++
1 file changed, 2 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:48.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:48.0
+0800
@@ -725,6 +725,7
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:50.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:51.0
+0800
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c |4
1 file changed, 4 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:50.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:50.0
+0800
@@ -567,6
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:46.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:47.0
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c | 27 ++-
1 file changed, 22 insertions(+), 5 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:39.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c | 47 +
1 file changed, 47 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
11:11:41.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 11:11
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c | 18 ++
1 file changed, 18 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:49.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:50.0
+0800
Signed-off-by: Wu Fengguang
---
tools/intel_audio_dump.c | 30 ++
1 file changed, 30 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:40.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52
On Mon, Nov 14, 2011 at 10:05:05AM +0800, Zhenyu Wang wrote:
> On 2011.11.11 16:50:41 +0800, Wu Fengguang wrote:
> > > > > I still think you should do those in hot_plug(), to call detect() for
> > > > > current
> > > > > status, write eld a
On Mon, Nov 14, 2011 at 05:45:12PM +0800, Takashi Iwai wrote:
> At Sat, 12 Nov 2011 10:27:26 +0800,
> Wu Fengguang wrote:
> >
> > (snip)
> > > > > > > And I'm not sure whether HDMI audio is played
> > > > > > > while DPMS is off.
memset(eld) clears eld->proc_entry which will leak the struct
snd_info_entry when unloading the module.
Fix it by
- remove memset(eld)
- set eld->eld_valid to true _after_ all eld fields have been filled
- don't access the other eld fields when (eld->eld_valid == false)
Sig
-off-by: Wu Fengguang
---
sound/pci/hda/hda_local.h |2 +
sound/pci/hda/patch_hdmi.c | 49 ++-
2 files changed, 44 insertions(+), 7 deletions(-)
--- linux.orig/sound/pci/hda/hda_local.h2011-11-15 21:29:53.0
+0800
+++ linux/sound/pci/hda
On Tue, Nov 15, 2011 at 10:35:41PM +0800, Takashi Iwai wrote:
> At Tue, 15 Nov 2011 22:31:55 +0800,
> Wu Fengguang wrote:
> >
> > memset(eld) clears eld->proc_entry which will leak the struct
> > snd_info_entry when unloading the module.
> >
> > Fix it by
On Tue, Nov 15, 2011 at 10:45:15PM +0800, Takashi Iwai wrote:
> At Tue, 15 Nov 2011 22:41:16 +0800,
> Wu Fengguang wrote:
> >
> > On Tue, Nov 15, 2011 at 10:35:41PM +0800, Takashi Iwai wrote:
> > > At Tue, 15 Nov 2011 22:31:55 +0800,
> > > Wu Fengguang wrote:
> - if (eld_valid)
> + if (eld_valid) {
> if (!snd_hdmi_get_eld(eld, codec, pin_nid))
> snd_hdmi_show_eld(eld);
> + else {
Oops, forgot testing @retry here! Updated patch follows.
> + queue_delayed_work(codec->bus->workq,
-off-by: Wu Fengguang
---
sound/pci/hda/hda_local.h |2 +
sound/pci/hda/patch_hdmi.c | 49 ++-
2 files changed, 44 insertions(+), 7 deletions(-)
--- linux.orig/sound/pci/hda/hda_local.h2011-11-15 21:29:53.0
+0800
+++ linux/sound/pci/hda
On Wed, Nov 16, 2011 at 01:10:37AM +0800, Takashi Iwai wrote:
> At Wed, 16 Nov 2011 00:57:08 +0800,
> Wu Fengguang wrote:
> > +static void hda_eld_work(struct work_struct *work)
> > +{
> > + struct hdmi_eld *eld = container_of(
> > +
On Wed, Nov 16, 2011 at 02:25:00AM +0800, Stephen Warren wrote:
> Wu Fengguang wrote at Tuesday, November 15, 2011 7:33 AM:
> > The Intel HDMI chips (ironlake at least) are found to have ~250ms delay
> > between the ELD_Valid=1 hotplug event is send and the ELD buffer becomes
> &
Keith,
Here are 3 fixes on HDMI/ELD audio.
The third one adds a ->hot_remove hook to drm_connector_funcs. Please review.
[PATCH 1/3] drm/i915: fix ELD writing for SandyBridge
[PATCH 2/3] drm/i915: dont trigger hotplug events on unchanged ELD
[PATCH 3/3] drm/i915: hot removal notification to HDMI
The ELD may or may not change when switching the video mode.
If unchanged, don't trigger hot plug events to HDMI audio driver.
This avoids disturbing the user with repeated printks.
Reported-by: Nick Bowler
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/intel_display.c |
SandyBridge should be using the same register addresses as IvyBridge.
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/i915_reg.h |6 +++---
drivers/gpu/drm/i915/intel_display.c | 10 +-
2 files changed, 8 insertions(+), 8 deletions(-)
--- linux.orig/drivers/gpu/drm/i915
On monitor hot removal:
1) clear SDVO_AUDIO_ENABLE or DP_AUDIO_OUTPUT_ENABLE
2) clear ELD Valid bit
So that the audio driver will receive hot plug events and take action to
refresh its device state and ELD contents.
cc: Wang Zhenyu
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm
Sorry forgot to remove this left over chunk...
Note that I've not yet got the hardware to test the DisplayPort part
of this patch, but should be able to do so this week.
> --- linux.orig/drivers/gpu/drm/i915/intel_drv.h 2011-11-16
> 20:54:27.0 +0800
> +++ linux/drivers/gpu/drm/i915
On monitor hot removal:
1) clear SDVO_AUDIO_ENABLE or DP_AUDIO_OUTPUT_ENABLE
2) clear ELD Valid bit
So that the audio driver will receive hot plug events and take action to
refresh its device state and ELD contents.
cc: Wang Zhenyu
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm
On Wed, Nov 16, 2011 at 11:51:28PM +0800, Stephen Warren wrote:
> Wu Fengguang wrote at Tuesday, November 15, 2011 7:48 PM:
> > On Wed, Nov 16, 2011 at 02:25:00AM +0800, Stephen Warren wrote:
> > > Wu Fengguang wrote at Tuesday, November 15, 2011 7:33 AM:
> > > > The
> > > Below is the dmesg representing a video mode set.
> > >
> > > ELD writes from the graphics driver
> > >
> > > [ 424.254958] [drm:intel_write_eld], ELD on [CONNECTOR:12:HDMI-A-2],
> > > [ENCODER:11:TMDS-11]
> > > [ 424.257670] [drm:ironlake_write_eld], ELD on pipe B
> > > [ 424.259833] [
However when in X, ->mode_set won't be called at all. Only
->get_modes and ->detect are called...
Thanks,
Fengguang
On Wed, Nov 16, 2011 at 09:35:48PM +0800, Wu Fengguang wrote:
> Sorry forgot to remove this left over chunk...
>
> Note that I've not yet got the h
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote:
> On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang
> wrote:
>
> > However when in X, ->mode_set won't be called at all. Only
> > ->get_modes and ->detect are called...
>
> The desktop softw
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote:
> On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang
> wrote:
>
> > However when in X, ->mode_set won't be called at all. Only
> > ->get_modes and ->detect are called...
>
> The desktop softw
DIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
- X
->detect
drm_edid_to_eld
->hotplug
intel_write_eld
set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
On hot remove, the call sequence is
->hotplug
clear SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
DIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
- X
->detect
drm_edid_to_eld
->hotplug
intel_write_eld
set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
On hot remove, the call sequence is
->hotplug
clear SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
On Mon, Nov 21, 2011 at 04:47:38PM +0800, Takashi Iwai wrote:
> At Mon, 21 Nov 2011 09:58:09 +0800,
> Wu Fengguang wrote:
> >
> > On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote:
> > > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang
> > > wro
On Tue, Nov 22, 2011 at 12:55:43AM +0800, Keith Packard wrote:
> On Mon, 21 Nov 2011 14:37:49 +0800, Wu Fengguang
> wrote:
> > On monitor hot plug/unplug, update ELD and set/clear SDVO_AUDIO_ENABLE
> > or DP_AUDIO_OUTPUT_ENABLE accordingly. So that the audio driver will
&g
te_eld
set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
- X
->detect
drm_edid_to_eld
->hotplug
intel_write_eld
set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
On hot remove, the call sequence is
->hotplug
clear SDVO_AUDI
On Wed, Nov 23, 2011 at 02:25:14AM +0800, Keith Packard wrote:
> On Tue, 22 Nov 2011 15:40:55 +0800, Wu Fengguang
> wrote:
>
> > So the v3 patch will behave equally well on KMS console, gnome desktop
> > and bare X. Shall we just use it, or go back and use the original
&
On Thu, Nov 24, 2011 at 03:26:49AM +0800, Keith Packard wrote:
> On Wed, 23 Nov 2011 16:29:58 +0800, Wu Fengguang
> wrote:
>
> > What I need is a hot plug hook that knows whether the monitor is
> > plugged or removed, which is only possible if the hook is called
> >
SandyBridge should be using the same register addresses as IvyBridge.
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/intel_display.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux.orig/drivers/gpu/drm/i915/intel_display.c 2011-11-24
08:09:41.0 +0800
The ELD may or may not change when switching the video mode.
If unchanged, don't trigger hot plug events to HDMI audio driver.
This avoids disturbing the user with repeated printks.
Reported-by: Nick Bowler
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/intel_display.c |
Keith,
The 4 patches are well tested and integrates the review comments.
The only missing part is hot plug notification for DP -- most DP monitors in
the market don't support DP audio well. So I cannot test this for now.
Thanks,
Fengguang
___
Intel-gf
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/intel_dp.c |4 +++-
drivers/gpu/drm/i915/intel_hdmi.c |8 ++--
2 files changed, 9 insertions(+), 3 deletions(-)
--- linux.orig/drivers/gpu/drm/i915/intel_hdmi.c2011-11-24
17:11:38.0 +0800
+++ linux/drivers/gpu
ggested-by: Keith Packard
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/i915_reg.h | 22 +++---
drivers/gpu/drm/i915/intel_display.c | 22 +++---
2 files changed, 22 insertions(+), 22 deletions(-)
--- linux.orig/drivers/gpu/drm/i915/i915_reg.h 201
> The only missing part is hot plug notification for DP -- most DP monitors in
> the market don't support DP audio well. So I cannot test this for now.
btw, we'd like to buy a Philips 221P3LPYEB that _seems_ to have DP
audio support. I'd appreciate if any one can help confirm.
Thanks,
Fengguang
_
SandyBridge should be using the same register addresses as IvyBridge.
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/intel_display.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Sorry, this moves some necessary changes from patch 2/4 to here.
--- linux.orig/drivers
ggested-by: Keith Packard
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/i915_reg.h | 22 +++---
drivers/gpu/drm/i915/intel_display.c | 22 +++---
2 files changed, 22 insertions(+), 22 deletions(-)
--- linux.orig/drivers/gpu/drm/i915/i915_reg.h 201
set to "Normal".
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/intel_dp.c |1 +
1 file changed, 1 insertion(+)
This works both on KMS console and gnome desktop.
Hot plug/unplug and DPMS on/off are all tested OK.
--- linux.orig/drivers/gpu/drm/i915/intel_dp.c 2011-1
Keith,
The complete set of fixes for passing HDMI/DP ELD to audio driver.
[PATCH 1/5] drm/i915: fix ELD writing for SandyBridge
[PATCH 2/5] drm/i915: rename audio ELD registers
[PATCH 3/5] drm/i915: dont trigger hotplug events on unchanged ELD
[PATCH 4/5] drm/i915: HDMI hot remove notificatio
ggested-by: Keith Packard
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/i915_reg.h | 22 +++---
drivers/gpu/drm/i915/intel_display.c | 22 +++---
2 files changed, 22 insertions(+), 22 deletions(-)
--- linux.orig/drivers/gpu/drm/i915/i915_reg.h 201
The ELD may or may not change when switching the video mode.
If unchanged, don't trigger hot plug events to HDMI audio driver.
This avoids disturbing the user with repeated printks.
Reported-by: Nick Bowler
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/intel_display.c |
Signed-off-by: Wu Fengguang
---
drivers/gpu/drm/i915/intel_dp.c |4 +++-
drivers/gpu/drm/i915/intel_hdmi.c |8 ++--
2 files changed, 9 insertions(+), 3 deletions(-)
--- linux.orig/drivers/gpu/drm/i915/intel_hdmi.c2011-11-24
17:11:38.0 +0800
+++ linux/drivers/gpu
1 - 100 of 126 matches
Mail list logo
