On 12/17/14 11:03 AM, Paulo Zanoni wrote:
2014-12-10 21:53 GMT-02:00 Todd Previte:
Adds a function to check the status of a Displayport connector. This function
simplifies the Displayport compliance testing interface in debugfs by providing
a single method for determining the status of a
ector is active before performing the write
operations. The commit message for the monster patch where these are
implemented has been updated to reflect this change as well.
-T
On 2/18/15 10:08 AM, Todd Previte wrote:
On 12/17/14 11:03 AM, Paulo Zanoni wrote:
2014-12-10 21:53 GMT-02:00
compliance_exit tag
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 38 +++---
1 file changed, 27 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index e69cdad..2d83f13 100644
--- a
neous comment
- Added responses to review feedback into the patch notes
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915
case
- Remove obsolete comment regarding SST mode operation
- Removed an erroneous line of code that snuck in during rebasing
Signed-off-by: Todd Previte
Conflicts:
drivers/gpu/drm/i915/intel_dp.c
---
drivers/gpu/drm/i915/intel_dp.c | 16 ++--
1 file changed, 6 insertions(+), 10
e == Displayport and b) status == active. This is
to eliminate patches 14 and 15 from V2, which become unnecessary
in light of this change.
- Fixed checkpatch.pl errors
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/i915_debugfs.c | 471
drivers/gp
est function
- Removed test_active flag from handler
- Added failsafe check on the compliance test active flag
at the end of the test handler
- Fixed checkpatch.pl issues
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 89 -
1 file changed,
the config parameters
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/i915_debugfs.c | 69 -
drivers/gpu/drm/i915/intel_drv.h| 1 +
2 files changed, 69 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu
r check to match other functions
- Updated the dp_parse_test_ctl function to use the new enums
instead of #defines
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/i915_debugfs.c | 105
1 file changed, 105 insertions(+)
diff --git a/drivers/gp
the sink
- Removed FAUX test case since it's deprecated now
- Removed the compliance flag assignment in handle_test_request
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 67 +---
drivers/gpu/drm/i915/intel_drv.h | 4 +++
2 files cha
These are the kernel-side patches to enable Displayport compliance testing for
the i915 driver. They establish a framework and operational parameters for
compliance testing operations on the i915 driver. Structure is in place such
that more tests can be added in the near future. Combined with th
.
V2:
- Changed udelay() to usleep_range()
V3:
- Removed extraneous check for timeout
- Updated comment to reflect this change
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915
Just some formatting issues that need to be cleaned up. Otherwise the
definitions look correct according to the eDP 1.4 spec.
-T
On 2/19/15 12:46 AM, Sonika Jindal wrote:
Adding dpcd macros related to edp1.4 and link rates
v2: Added DP_SUPPORTED_LINK_RATES macros
Signed-off-by: Sonika Jindal
On 2/20/2015 1:25 AM, Jani Nikula wrote:
On Thu, 19 Feb 2015, Todd Previte wrote:
Just some formatting issues that need to be cleaned up. Otherwise the
definitions look correct according to the eDP 1.4 spec.
Actually the formatting seems to be in line with the rest of that
particular file
DID functions
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 52 +
1 file changed, 52 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 5d7b7f3..32f0fc5 100644
--- a/drivers/gpu/drm/i
Hi Mika,
On 2/26/2015 2:26 AM, Mika Kahola wrote:
In a case when DP link has been once trained we can reuse
the existing link training parameters i.e. voltage swing
and pre-emphasis levels from cache when there is a need to
restart link training. In a case of eDP we initially try
to train the li
Hi Rodrigo,
This patch looks good.
Reviewed-by: Todd Previte
-T
-Original Message-
From: Rodrigo Vivi [mailto:rodrigo.v...@gmail.com]
Sent: Tuesday, September 16, 2014 4:18 PM
To: intel-gfx@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org; Rodrigo Vivi; Todd Previte; Daniel
Hi Rodrigo,
Looks good. Only thing that needs to be removed is that extra blank line
between the last part of the function and the return statement. Otherwise...
Reviewed-by: Todd Previte
-Original Message-
From: Rodrigo Vivi [mailto:rodrigo.v...@intel.com]
Sent: Monday, September 29
...@lists.freedesktop.org
Signed-off-by: Todd Previte
---
drivers/gpu/drm/drm_dp_helper.c | 2 ++
include/drm/drm_dp_helper.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 08e33b8..8353051 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/i915_debugfs.c | 389
drivers/gpu/drm/i915/intel_dp.c | 13 +-
2 files changed, 397 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_debugfs.c
led,
resulting in a faied test.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index f7d4119..952dfa3 100644
--
The kernel side is responsible for the acknowledgement of the test requests and
setup of the required parameters. It also handles the necessary AUX
transactions
for reading the EDID and DPCD as well as writing response codes or checksums as
necessary. Performing these operations in userspace wo
-off-by: Todd Previte
---
drivers/gpu/drm/i915/i915_debugfs.c | 124 +++-
drivers/gpu/drm/i915/intel_dp.c | 34 ++
drivers/gpu/drm/i915/intel_drv.h| 4 ++
3 files changed, 161 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915
Add the skeleton framework for supporting automation for Displayport compliance
testing. This patch adds the necessary framework for the source device to
appropriately
respond to test automation requests from a sink device.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 82
Adds provisions in intel_dp_compute_config() to accommodate compliance testing.
Mostly
this invovles circumventing the automatic link configuration paramters and
allowing
the compliance code to set those parameters as required by the tests.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915
The hot plug function for DP appears to have been broken somewhere along the
way. Without
this function being operational, hot plug events are not correctly received for
compliance
testing. This patch implements the necessary functionality to resolve that
issue.
Signed-off-by: Todd Previte
interface to use these new parameters instead
of storing them in an intermediate structure. Values are stored on a
per-connector basis in the intel_dp struct.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/i915_debugfs.c | 35 +--
drivers/gpu/drm/i915/intel_drv.h
-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 85 +++--
1 file changed, 81 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 717cb5d..b7bdb5f 100644
--- a/drivers/gpu/drm/i915
() function after vlv_wait_port_ready() and only when the PHYs
are ready
helps ensure reliable operation of the Displayport link.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_display.c | 8 ++--
drivers/gpu/drm/i915/intel_dp.c | 10 --
drivers/gpu/drm/i915
successful link training. This patch
updates
the link training functions and where/how they're used to be more intelligent
about
failures and to stop trying to train the link when it's a lost cause.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_ddi.c | 25 ++--
drive
On 10/10/14 1:04 AM, Jani Nikula wrote:
On Thu, 09 Oct 2014, Todd Previte wrote:
Reorder the function calls in chv/vlv_pre_enable_dp() such that link training
is not initiated
before the PHYs come up out of reset. Also check the status of
vlv_wait_port_ready() and
only attempt to train if
On 10/9/14 8:38 PM, Dave Airlie wrote:
On 10 October 2014 01:49, Chris Wilson wrote:
On Thu, Oct 09, 2014 at 08:38:10AM -0700, Todd Previte wrote:
The hot plug function for DP appears to have been broken somewhere along the
way. Without
this function being operational, hot plug events are
igating the actual root cause might be worthwhile.
Reviewed-by: Todd Previte
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 10/17/2014 1:43 AM, Ville Syrjälä wrote:
On Thu, Oct 16, 2014 at 12:38:55PM -0700, Todd Previte wrote:
On 10/16/2014 10:46 AM, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä
Turning vdd on/off can generate a long hpd pulse on eDP ports. In order
to handle hpd we would need to
On 10/17/2014 1:43 AM, Jani Nikula wrote:
On Thu, 16 Oct 2014, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä
Sometimes we seem to get utter garbage from DPCD reads. The resulting
buffer is filled with the same byte, and the operation completed without
errors. My HP ZR24w monitor se
On 10/17/2014 2:06 AM, Ville Syrjälä wrote:
On Thu, Oct 16, 2014 at 12:39:29PM -0700, Todd Previte wrote:
On 10/16/2014 10:46 AM, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä
Sometimes we seem to get utter garbage from DPCD reads. The resulting
buffer is filled with the same
On 10/17/2014 1:59 AM, Ville Syrjälä wrote:
On Fri, Oct 17, 2014 at 11:43:21AM +0300, Jani Nikula wrote:
On Thu, 16 Oct 2014, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä
Sometimes we seem to get utter garbage from DPCD reads. The resulting
buffer is filled with the same byte, an
().
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_display.c | 8 ++--
drivers/gpu/drm/i915/intel_dp.c | 16
drivers/gpu/drm/i915/intel_drv.h | 2 +-
3 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b
V2 changes:
- Moved the intel_dp_enable_port() call out of intel_dp_enable() and placed it
before the calls to intel_dp_enable() and vlv_wait_port_ready()
- Cleaned up a spacing issues with the code indents
- Amended the commit message to be under 80 characters per line and expanded
on the des
On 10/16/2014 11:27 AM, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä
There's no point in checking if the data lanes came out of reset after
link training. If the data lanes aren't ready link training will fail
anyway.
Suggested-by: Todd Previte
Cc: Todd Previte
Sig
On 10/21/2014 7:41 AM, Daniel Vetter wrote:
On Fri, Oct 17, 2014 at 11:41:12AM -0700, Todd Previte wrote:
V2 changes:-+
- Moved the intel_dp_enable_port() call out of intel_dp_enable() and placed it
before the calls to intel_dp_enable() and vlv_wait_port_ready()
- Cleaned up a spacing
On 10/21/2014 7:45 AM, Daniel Vetter wrote:
On Thu, Oct 09, 2014 at 09:39:01AM -0700, Todd Previte wrote:
Link training for Displayport can fail in many ways and at multiple different
points
during the training process. Previously, errors were logged but no additional
action
was taken based
On 10/22/2014 7:22 AM, Jani Nikula wrote:
On Thu, 09 Oct 2014, Todd Previte wrote:
Link training for Displayport can fail in many ways and at multiple different
points
during the training process. Previously, errors were logged but no additional
action
was taken based on them. Consequently
has 0
errors, 0 warnings, so that should be good to go. Excess comments have
also been removed. If I missed anything though, please let me know.
2014-10-09 12:38 GMT-03:00 Todd Previte :
Add the skeleton framework for supporting automation for Displayport compliance
testing. This patch add
specifically.
Signed-off-by: Todd Previte
---
drivers/gpu/drm/i915/intel_dp.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 952dfa3..a7acc61 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm
201 - 245 of 245 matches
Mail list logo
