Re: [Intel-gfx] [PATCH v3 04/27] drm: Don't test for IRQ support in VBLANK ioctls

2021-06-24 Thread Thierry Reding
On Thu, Jun 24, 2021 at 11:07:57AM +0200, Thomas Zimmermann wrote: > Hi > > Am 24.06.21 um 10:51 schrieb Jani Nikula: > > On Thu, 24 Jun 2021, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 24.06.21 um 10:06 schrieb Jani Nikula: > > > > On Thu, 24 Jun 2021, Thomas Zimmermann wrote: > > > > >

Re: [Intel-gfx] [PATCH v3 21/27] drm/tegra: Don't set struct drm_device.irq_enabled

2021-06-24 Thread Thierry Reding
Acked-by: Daniel Vetter > --- > drivers/gpu/drm/tegra/drm.c | 7 --- > 1 file changed, 7 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 02/20] drm/tegra: Don't register DP AUX channels before connectors

2021-03-28 Thread Thierry Reding
entially allow userspace to use > the AUX channel before we've associated it with it's DRM connector. > > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/tegra/dpaux.c | 11 ++----- > 1 file changed, 6 insertions(+), 5 delet

Re: [Intel-gfx] [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-03-29 Thread Thierry Reding
cannot rely on drm_dp_aux->drm_dev to always be > non-NULL until drm_dp_aux_register() has been called. We make sure to point > this out in the documentation for struct drm_dp_aux. > > Signed-off-by: Lyude Paul > --- [...] > drivers/gpu/drm/tegra/dpaux.c

Re: [Intel-gfx] [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-06 Thread Thierry Reding
On Tue, Apr 06, 2021 at 09:30:36AM +0200, Uwe Kleine-König wrote: > Given that lowlevel drivers usually cannot implement exactly what a > consumer requests with pwm_apply_state() there is some rounding involved. > > pwm_get_state() traditionally returned the setting that was requested most > recen

Re: [Intel-gfx] [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-09 Thread Thierry Reding
On Tue, Apr 06, 2021 at 03:43:56PM +0200, Uwe Kleine-König wrote: > Hello Thierry, > > On Tue, Apr 06, 2021 at 01:16:31PM +0200, Thierry Reding wrote: > > On Tue, Apr 06, 2021 at 09:30:36AM +0200, Uwe Kleine-König wrote: > > > Given that lowlevel drivers usually cannot

Re: [Intel-gfx] [PATCH 10/12] drm/tegra: Don't set allow_fb_modifiers explicitly

2021-04-13 Thread Thierry Reding
to allow userspace to rely on this. Again don't backport > further than where Paul's patch got added. > > Cc: sta...@vger.kernel.org # v5.1 + > Cc: Pekka Paalanen > Signed-off-by: Daniel Vetter > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-te...@vger.k

Re: [Intel-gfx] [PATCH 03/30] drm/tegra: Don't register DP AUX channels before connectors

2021-04-14 Thread Thierry Reding
On Fri, Feb 19, 2021 at 04:52:59PM -0500, Lyude Paul wrote: > As pointed out by the documentation for drm_dp_aux_register(), > drm_dp_aux_init() should be used in situations where the AUX channel for a > display driver can potentially be registered before it's respective DRM > driver. This is the c

Re: [Intel-gfx] [PATCH v3 03/20] drm/dp: Move i2c init to drm_dp_aux_init, add __must_check and fini

2021-04-23 Thread Thierry Reding
On Thu, Apr 22, 2021 at 01:18:09PM -0400, Lyude Paul wrote: > On Tue, 2021-04-20 at 02:16 +0300, Ville Syrjälä wrote: > > > > The init vs. register split is intentional. Registering the thing > > and allowing userspace access to it before the rest of the driver > > is ready isn't particularly grea

Re: [Intel-gfx] [PATCH v3 03/20] drm/dp: Move i2c init to drm_dp_aux_init, add __must_check and fini

2021-04-23 Thread Thierry Reding
On Thu, Apr 22, 2021 at 06:33:44PM -0400, Lyude Paul wrote: > OK - talked with Ville a bit on this and did some of my own research, I > actually think that moving i2c to drm_dp_aux_init() is the right decision for > the time being. The reasoning behind this being that as shown by my previous > work

Re: [Intel-gfx] [PATCH v3 03/20] drm/dp: Move i2c init to drm_dp_aux_init, add __must_check and fini

2021-04-23 Thread Thierry Reding
On Fri, Apr 23, 2021 at 12:11:06AM -0400, Lyude Paul wrote: > On Thu, 2021-04-22 at 18:33 -0400, Lyude Paul wrote: > > OK - talked with Ville a bit on this and did some of my own research, I > > actually think that moving i2c to drm_dp_aux_init() is the right decision > > for > > the time being. Th

Re: [Intel-gfx] [PATCH 22/26] drm/qxl: Use drm_fb_helper_fill_info

2019-01-25 Thread Thierry Reding
On Thu, Jan 24, 2019 at 05:58:27PM +0100, Daniel Vetter wrote: > Another driver that didn't set fbinfo->fix.id before. > > Signed-off-by: Daniel Vetter > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-te...@vger.kernel.org > --- > drivers/gpu/drm/tegra/fb

Re: [Intel-gfx] [PATCH 26/26] drm/: Don't set FBINFO_(FLAG_)DEFAULT

2019-01-25 Thread Thierry Reding
c: Ben Skeggs > Cc: Sandy Huang > Cc: "Heiko Stübner" > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: Hans de Goede > Cc: Greg Kroah-Hartman > Cc: Daniel Vetter > Cc: Bartlomiej Zolnierkiewicz > Cc: Alexander Kapshuk > Cc: linux-arm

Re: [Intel-gfx] [PATCH 14/17] drm/tegra: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-04 Thread Thierry Reding
Lankhorst > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-te...@vger.kernel.org > --- > drivers/gpu/drm/tegra/dc.c | 30 +++--- > 1 file changed, 11 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/

Re: [Intel-gfx] [PATCH 7/7] drm: Split out drm_probe_helper.h

2018-12-10 Thread Thierry Reding
ont.c | 2 +- > drivers/gpu/drm/xen/xen_drm_front_conn.c | 2 +- > drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +- > drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- > drivers/gpu/drm/zte/zx_drm_drv.c |

Re: [Intel-gfx] [Nouveau] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-09-10 Thread Thierry Reding
On Sat, Sep 07, 2019 at 09:58:46PM -0400, Ilia Mirkin wrote: > On Wed, Aug 21, 2019 at 7:55 AM Thierry Reding > wrote: > > > > On Wed, Aug 21, 2019 at 04:33:58PM +1000, Ben Skeggs wrote: > > > On Wed, 14 Aug 2019 at 20:14, Gerd Hoffmann wrote: > > > > >

Re: [Intel-gfx] [PATCH] video/hdmi: Fix AVI bar unpack

2019-09-20 Thread Thierry Reding
rg > Cc: Martin Bugge > Cc: Hans Verkuil > Cc: Thierry Reding > Cc: Mauro Carvalho Chehab > Fixes: 2c676f378edb ("[media] hdmi: added unpack and logging functions for > InfoFrames") > Signed-off-by: Ville Syrjälä > --- > drivers/video/hdmi.c | 8 &g

Re: [Intel-gfx] [PATCH v2 00/21] drm/dp: Various helper improvements and cleanups

2019-09-23 Thread Thierry Reding
On Mon, Sep 23, 2019 at 04:52:50PM +0300, Jani Nikula wrote: > On Fri, 20 Sep 2019, Thierry Reding wrote: > > On Mon, Sep 02, 2019 at 01:31:00PM +0200, Thierry Reding wrote: > >> From: Thierry Reding > >> > >> Hi, > >> > >> this series

Re: [Intel-gfx] [PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info

2019-03-26 Thread Thierry Reding
On Tue, Mar 26, 2019 at 02:20:05PM +0100, Daniel Vetter wrote: > Another driver that didn't set fbinfo->fix.id before. > > v2: Fix subject and rebase > > Acked-by: Thierry Reding > Signed-off-by: Daniel Vetter > Cc: Thierry Reding > Cc: Jonathan Hunter &

Re: [Intel-gfx] [PATCH 09/59] drm/prime: Align gem_prime_export with obj_funcs.export

2019-06-17 Thread Thierry Reding
> Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Zhenyu Wang > Cc: Zhi Wang > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tomi Valkeinen > Cc: Alex Deucher > Cc: "Christia

Re: [Intel-gfx] drm connectors, tegra, and the web they weave (was Re: [PATCH 58/59] drm/todo: Add new debugfs todo)

2019-06-20 Thread Thierry Reding
On Tue, Jun 18, 2019 at 11:46:56PM +0200, Daniel Vetter wrote: > On Tue, Jun 18, 2019 at 08:01:13PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 18, 2019 at 07:32:20PM +0200, Daniel Vetter wrote: > > > On Tue, Jun 18, 2019 at 5:25 PM Greg Kroah-Hartman > > > wrote: > > > > On Tue, Jun 18, 2019

Re: [Intel-gfx] drm connectors, tegra, and the web they weave (was Re: [PATCH 58/59] drm/todo: Add new debugfs todo)

2019-06-20 Thread Thierry Reding
On Tue, Jun 18, 2019 at 05:19:38PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 14, 2019 at 10:36:14PM +0200, Daniel Vetter wrote: > > Greg is busy already, but maybe he won't do everything ... > > > > Cc: Greg Kroah-Hartman > > Signed-off-by: Daniel Vetter > > --- > > Documentation/gpu/todo.

Re: [Intel-gfx] drm connectors, tegra, and the web they weave (was Re: [PATCH 58/59] drm/todo: Add new debugfs todo)

2019-06-20 Thread Thierry Reding
On Tue, Jun 18, 2019 at 07:32:20PM +0200, Daniel Vetter wrote: > On Tue, Jun 18, 2019 at 5:25 PM Greg Kroah-Hartman > wrote: > > On Tue, Jun 18, 2019 at 05:19:38PM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Jun 14, 2019 at 10:36:14PM +0200, Daniel Vetter wrote: > > > > Greg is busy already, bu

Re: [Intel-gfx] drm connectors, tegra, and the web they weave (was Re: [PATCH 58/59] drm/todo: Add new debugfs todo)

2019-06-20 Thread Thierry Reding
On Tue, Jun 18, 2019 at 04:37:16PM +0100, Jon Hunter wrote: > > On 18/06/2019 16:19, Greg Kroah-Hartman wrote: > > On Fri, Jun 14, 2019 at 10:36:14PM +0200, Daniel Vetter wrote: > >> Greg is busy already, but maybe he won't do everything ... > >> > >> Cc: Greg Kroah-Hartman > >> Signed-off-by: Da

Re: [Intel-gfx] [PATCH 3/5] drm/panel: Add attach/detach callbacks

2019-06-21 Thread Thierry Reding
On Tue, Jun 11, 2019 at 05:25:47PM -0700, dbasehore . wrote: > On Tue, Jun 11, 2019 at 1:57 AM Daniel Vetter wrote: > > > > On Mon, Jun 10, 2019 at 09:03:48PM -0700, Derek Basehore wrote: > > > This adds the attach/detach callbacks. These are for setting up > > > internal state for the connector/p

Re: [Intel-gfx] [PATCH] drm/panel: make drm_panel.h self-contained

2019-06-27 Thread Thierry Reding
er from integer without a cast > [-Werror=int-conversion] > return ERR_PTR(-ENODEV); > ^~~~ > > Fixes: 5fa8e4a22182 ("drm/panel: Make of_drm_find_panel() return an ERR_PTR() > instead of NULL") > Cc: Boris Brezillon > Cc: Thierry Reding > Signed

Re: [Intel-gfx] [PATCH v2 00/21] drm/dp: Various helper improvements and cleanups

2019-10-02 Thread Thierry Reding
On Mon, Sep 23, 2019 at 04:52:02PM +0200, Thierry Reding wrote: > On Mon, Sep 23, 2019 at 04:52:50PM +0300, Jani Nikula wrote: > > On Fri, 20 Sep 2019, Thierry Reding wrote: > > > On Mon, Sep 02, 2019 at 01:31:00PM +0200, Thierry Reding wrote: > > >> From: Thi

Re: [Intel-gfx] [PATCH 01/15] drm/tegra: Map cmdbuf once for reloc processing

2019-11-25 Thread Thierry Reding
addr game anyway, there's no real kmap going on > > on arm it seems. > > > > Plus this seems to be the only real in-tree user of dma_buf_kmap, and > > I'd like to get rid of that. > > > > Signed-off-by: Daniel Vetter > > Cc: Thierry Reding > &g

Re: [Intel-gfx] [PATCH 01/15] drm/tegra: Map cmdbuf once for reloc processing

2019-11-25 Thread Thierry Reding
n-tree user of dma_buf_kmap, and > I'd like to get rid of that. > > Signed-off-by: Daniel Vetter > Cc: Thierry Reding > Cc: linux-te...@vger.kernel.org > --- > drivers/gpu/host1x/job.c | 21 +++-- > 1 file changed, 7 insertions(+), 14 deletions(-)

Re: [Intel-gfx] [PATCH 02/15] drm/tegra: Delete host1x_bo_ops->k(un)map

2019-11-25 Thread Thierry Reding
tm, which uses kmap for vmap for added confusion. > mmap seems entirely for userspace mappings set up through mmap(2) > syscall. > > Signed-off-by: Daniel Vetter > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-te...@vger.kernel.org > --- > drivers/gpu/drm/tegra/g

Re: [Intel-gfx] [PATCH 08/15] drm/tegra: Remove dma_buf->k(un)map

2019-11-25 Thread Thierry Reding
On Mon, Nov 18, 2019 at 11:35:29AM +0100, Daniel Vetter wrote: > No in-tree users left. > > Signed-off-by: Daniel Vetter > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-te...@vger.kernel.org > --- > drivers/gpu/drm/tegra/gem.c | 12 > 1 file cha

Re: [Intel-gfx] [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-24 Thread Thierry Reding
On Wed, Oct 23, 2019 at 05:00:41PM -0700, Manasi Navare wrote: > Adaptive Sync is a VESA feature so add a DRM core helper to parse > the EDID's detailed descritors to obtain the adaptive sync monitor range. > Store this info as part fo drm_display_info so it can be used > across all drivers. > This

Re: [Intel-gfx] [PATCH 2/2] drm/todo: Add entry to remove load/unload hooks

2019-10-24 Thread Thierry Reding
le changed, 17 insertions(+) Reminds me that I need to still do that for Tegra: Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/property: Enforce more lifetime rules

2019-10-24 Thread Thierry Reding
On Wed, Oct 23, 2019 at 04:49:52PM +0200, Daniel Vetter wrote: > Properties can't be attached after registering, userspace would get > confused (no one bothers to reprobe really). > > - Add kerneldoc > - Enforce this with some checks. This needs a somewhat ugly check > since connectors can be ad

Re: [Intel-gfx] [PATCH 1/2] drm/property: Enforce more lifetime rules

2019-10-24 Thread Thierry Reding
On Thu, Oct 24, 2019 at 12:40:55PM +0200, Thierry Reding wrote: > On Wed, Oct 23, 2019 at 04:49:52PM +0200, Daniel Vetter wrote: > > Properties can't be attached after registering, userspace would get > > confused (no one bothers to reprobe really). > > > > - Add k

Re: [Intel-gfx] [PATCH] drm: Add support for integrated privacy screens

2019-10-24 Thread Thierry Reding
On Tue, Oct 22, 2019 at 05:12:06PM -0700, Rajat Jain wrote: > Certain laptops now come with panels that have integrated privacy > screens on them. This patch adds support for such panels by adding > a privacy-screen property to the drm_connector for the panel, that > the userspace can then use to c

Re: [Intel-gfx] [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-24 Thread Thierry Reding
On Thu, Oct 24, 2019 at 02:34:00PM +0300, Ville Syrjälä wrote: > On Thu, Oct 24, 2019 at 12:31:06PM +0200, Thierry Reding wrote: > > On Wed, Oct 23, 2019 at 05:00:41PM -0700, Manasi Navare wrote: > > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > &g

Re: [Intel-gfx] [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-24 Thread Thierry Reding
On Thu, Oct 24, 2019 at 05:20:32PM +0300, Ville Syrjälä wrote: > On Thu, Oct 24, 2019 at 03:54:41PM +0200, Thierry Reding wrote: > > On Thu, Oct 24, 2019 at 02:34:00PM +0300, Ville Syrjälä wrote: > > > On Thu, Oct 24, 2019 at 12:31:06PM +0200, Thierry Reding wrote: > > >

Re: [Intel-gfx] [PATCH] drm: Add support for integrated privacy screens

2019-10-25 Thread Thierry Reding
On Thu, Oct 24, 2019 at 01:45:16PM -0700, Rajat Jain wrote: > Hi, > > Thanks for your review and comments. Please see inline below. > > On Thu, Oct 24, 2019 at 4:20 AM Thierry Reding > wrote: > > > > On Tue, Oct 22, 2019 at 05:12:06PM -0700, Rajat Jain wrote:

[Intel-gfx] [RESEND PATCH] drm/dp: Increase link status size

2019-10-29 Thread Thierry Reding
From: Thierry Reding The current link status contains bytes 0x202 through 0x207, but we also want to make sure to include the DP_ADJUST_REQUEST_POST_CURSOR2 (0x20c) so that the post-cursor adjustment can be queried during link training. Reported-by: coverity-bot Addresses-Coverity-ID: 1487366

Re: [Intel-gfx] [PATCH] drm/dp: Increase link status size

2019-10-29 Thread Thierry Reding
On Tue, Oct 29, 2019 at 03:32:41PM +0200, Jani Nikula wrote: > On Tue, 29 Oct 2019, Thierry Reding wrote: > > From: Thierry Reding > > > > The current link status contains bytes 0x202 through 0x207, but we also > > want to make sure to include the DP_ADJUST_REQUEST_

Re: [Intel-gfx] [PATCH v2 1/5] drm/dsi: clean up DSI data type definitions

2019-11-04 Thread Thierry Reding
ification, but given that it's not really ordered in any sane way in the first place (or perhaps I'm too stupid to see the logic) I don't really mind about the order. Took me a while to find the specification. You might want to mention

Re: [Intel-gfx] [PATCH v2 2/5] drm/dsi: add missing DSI data types

2019-11-04 Thread Thierry Reding
> MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20= 0x0c, > MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24= 0x1c, Actually, it looks like the ordering is by lowest-significant nibble first, then by highest-significant nibble, so maybe there's some logic to this after a

Re: [Intel-gfx] [PATCH v2 3/5] drm/dsi: add missing DSI DCS commands

2019-11-04 Thread Thierry Reding
On Mon, Oct 28, 2019 at 05:00:45PM +0200, Jani Nikula wrote: > Update from the DCS specification. > > Cc: Vandita Kulkarni > Signed-off-by: Jani Nikula > --- > include/video/mipi_display.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/include/video/mipi_display.h b/inclu

Re: [Intel-gfx] [PATCH v2 3/5] drm/dsi: add missing DSI DCS commands

2019-11-05 Thread Thierry Reding
= 0x5E,/* MIPI DCS 1.3 */ > MIPI_DCS_GET_CABC_MIN_BRIGHTNESS = 0x5F,/* MIPI DCS 1.3 */ > MIPI_DCS_READ_DDB_START = 0xA1, > + MIPI_DCS_READ_PPS_START = 0xA2, > MIPI_DCS_READ_DDB_CONTINUE = 0xA8, > + MIPI_DCS_READ_PPS_CONTI

Re: [Intel-gfx] [PATCH v2 4/5] drm/dsi: rename MIPI_DCS_SET_PARTIAL_AREA to MIPI_DCS_SET_PARTIAL_ROWS

2019-11-05 Thread Thierry Reding
avid Lechner > Cc: Vandita Kulkarni > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/tiny/st7586.c | 2 +- > include/video/mipi_display.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thierry Reding sign

Re: [Intel-gfx] [PATCH v2 5/5] drm/dsi: add helpers for DSI compression mode and PPS packets

2019-11-05 Thread Thierry Reding
t; include/drm/drm_mipi_dsi.h | 4 +++ > 2 files changed, 55 insertions(+) Looks good: Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-08-13 Thread Thierry Reding
On Mon, Aug 05, 2019 at 04:01:10PM +0200, Gerd Hoffmann wrote: > Drop vma_node from ttm_buffer_object, use the gem struct > (base.vma_node) instead. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- > drivers/gpu/drm/qxl/q

Re: [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-08-14 Thread Thierry Reding
tion steps, so that when necessary the GEM object can be initialized in between. I think that's slightly more flexible and easier to understand than a boolean flag. Thierry From a1130a6affcb7c00133e89f3e498cb6757f5bb51 Mon Sep 17 00:00:00 2001 From: Thierry Reding Date: Wed, 14 Aug 2019 11:00:48 +0200 Subject: [PATCH] drm/nou

Re: [Intel-gfx] [Nouveau] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-08-21 Thread Thierry Reding
On Wed, Aug 21, 2019 at 04:33:58PM +1000, Ben Skeggs wrote: > On Wed, 14 Aug 2019 at 20:14, Gerd Hoffmann wrote: > > > > Hi, > > > > > > Changing the order doesn't look hard. Patch attached (untested, have no > > > > test hardware). But maybe I missed some detail ... > > > > > > I came up with

Re: [Intel-gfx] [PATCH] drm/atomic-helper: reset vblank on crtc reset

2020-05-27 Thread Thierry Reding
Sam Ravnborg > Cc: Boris Brezillon > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Ludovic Desroches > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > Cc: Thierry Reding > Cc: Jonathan H

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-07-27 Thread Thierry Reding
On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: > Hi All, > > Here is v5 of my patch series converting the i915 driver's code for > controlling the panel's backlight with an external PWM controller to > use the atomic PWM API. See below for the changelog. > > This series consists o

Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-07-30 Thread Thierry Reding
On Wed, Jul 29, 2020 at 11:32:28AM +0200, Hans de Goede wrote: > cHi, > > On 7/29/20 10:23 AM, Andy Shevchenko wrote: > > On Mon, Jul 27, 2020 at 09:41:20AM +0200, Thierry Reding wrote: > > > On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: > > > &

Re: [Intel-gfx] [PATCH v8 04/17] pwm: lpss: Add range limit check for the base_unit register value

2020-08-31 Thread Thierry Reding
hevchenko > Signed-off-by: Hans de Goede > --- > Changes in v5: > - Use clamp_val(... instead of clam_t(unsigned long long, ... > > Changes in v3: > - Change upper limit of clamp to (base_unit_range - 1) > - Add Fixes tag > --- > drivers/pwm/pwm-lpss.c |

Re: [Intel-gfx] [PATCH v8 03/17] pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()

2020-08-31 Thread Thierry Reding
> --- > Changes in v3: > - Add Fixes tag > - Add Reviewed-by: Andy Shevchenko tag > --- > drivers/pwm/pwm-lpss.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH v8 05/17] pwm: lpss: Add pwm_lpss_prepare_enable() helper

2020-08-31 Thread Thierry Reding
> Signed-off-by: Hans de Goede > --- > drivers/pwm/pwm-lpss.c | 45 ------ > 1 file changed, 26 insertions(+), 19 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature ___

Re: [Intel-gfx] [PATCH v8 06/17] pwm: lpss: Use pwm_lpss_restore() when restoring state on resume

2020-08-31 Thread Thierry Reding
On Sun, Aug 30, 2020 at 02:57:42PM +0200, Hans de Goede wrote: > Before this commit a suspend + resume of the LPSS PWM controller > would result in the controller being reset to its defaults of > output-freq = clock/256, duty-cycle=100%, until someone changes > to the output-freq and/or duty-cycle

Re: [Intel-gfx] [PATCH v8 08/17] pwm: crc: Fix period / duty_cycle times being off by a factor of 256

2020-08-31 Thread Thierry Reding
gt; > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > Changes in v3: > - Use NSEC_PER_USEC instead of adding a new (non-sensical) NSEC_PER_MHZ define > --- > drivers/pwm/pwm-crc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Ack

Re: [Intel-gfx] [PATCH v8 07/17] pwm: lpss: Always update state and set update bit

2020-08-31 Thread Thierry Reding
On Sun, Aug 30, 2020 at 02:57:43PM +0200, Hans de Goede wrote: > This commit removes a check where we would skip writing the ctrl register > and then setting the update bit in case the ctrl register already contains > the correct values. > > In a perfect world skipping the update should be fine in

Re: [Intel-gfx] [PATCH v8 08/17] pwm: crc: Fix period / duty_cycle times being off by a factor of 256

2020-08-31 Thread Thierry Reding
gt; > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > Changes in v3: > - Use NSEC_PER_USEC instead of adding a new (non-sensical) NSEC_PER_MHZ define > --- > drivers/pwm/pwm-crc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Ack

Re: [Intel-gfx] [PATCH v8 09/17] pwm: crc: Fix off-by-one error in the clock-divider calculations

2020-08-31 Thread Thierry Reding
t; - Introduce crc_pwm_calc_clk_div() here instead of later in the patch-set > to reduce the amount of churn in the patch-set a bit > --- > drivers/pwm/pwm-crc.c | 17 ++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) Acked-by: Thierry Reding signature.asc Descri

Re: [Intel-gfx] [PATCH v8 10/17] pwm: crc: Fix period changes not having any effect

2020-08-31 Thread Thierry Reding
he CRC PWM output to drive their backlight. Before the PWM would > always run with the output frequency configured by the BIOS at boot, now > the period time specified by the i915 driver will actually be honored. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- &g

Re: [Intel-gfx] [PATCH v8 11/17] pwm: crc: Enable/disable PWM output on enable/disable

2020-08-31 Thread Thierry Reding
tri-stating the output from the commit message, > we don't have a datasheet so this was just an unfounded guess > --- > drivers/pwm/pwm-crc.c | 4 > 1 file changed, 4 insertions(+) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH v8 13/17] pwm: crc: Implement get_state() method

2020-08-31 Thread Thierry Reding
nges in v3: > - Add Andy's Reviewed-by tag > - Remove extra whitespace to align some code after assignments (requested by > Uwe Kleine-König) > --- > drivers/pwm/pwm-crc.c | 31 +++++++ > 1 file changed, 31 i

Re: [Intel-gfx] [PATCH v8 12/17] pwm: crc: Implement apply() method to support the new atomic PWM API

2020-08-31 Thread Thierry Reding
ged, 54 insertions(+), 35 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v8 06/17] pwm: lpss: Use pwm_lpss_restore() when restoring state on resume

2020-08-31 Thread Thierry Reding
On Mon, Aug 31, 2020 at 01:46:28PM +0200, Hans de Goede wrote: > Hi, > > On 8/31/20 1:10 PM, Thierry Reding wrote: > > On Sun, Aug 30, 2020 at 02:57:42PM +0200, Hans de Goede wrote: > > > Before this commit a suspend + resume of the LPSS PWM controller > > > wou

Re: [Intel-gfx] [PATCH v8 07/17] pwm: lpss: Always update state and set update bit

2020-08-31 Thread Thierry Reding
On Mon, Aug 31, 2020 at 01:26:46PM +0200, Hans de Goede wrote: > Hi, > > On 8/31/20 1:13 PM, Thierry Reding wrote: > > On Sun, Aug 30, 2020 at 02:57:43PM +0200, Hans de Goede wrote: > > > This commit removes a check where we would skip writing the ctrl register > >

Re: [Intel-gfx] [PATCH v9 06/17] pwm: lpss: Make pwm_lpss_apply() not rely on existing hardware state

2020-09-03 Thread Thierry Reding
ragile. > > *) Seen on the Acer One 10 S1003, Lenovo Ideapad Miix 310 and 320 models > and various Medion models. > > Signed-off-by: Hans de Goede > --- > drivers/pwm/pwm-lpss.c | 21 + > 1 file changed, 9 insertions(+), 12 deletions(-) Other than the t

Re: [Intel-gfx] [PATCH v9 07/17] pwm: lpss: Remove suspend/resume handlers

2020-09-03 Thread Thierry Reding
drivers/pwm/pwm-lpss-platform.c | 1 - > drivers/pwm/pwm-lpss.c | 24 > drivers/pwm/pwm-lpss.h | 3 --- > 3 files changed, 28 deletions(-) Nice! Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [Intel-gfx] [PATCH v2 14/21] drm/tegra: Introduce GEM object functions

2020-09-17 Thread Thierry Reding
omas Zimmermann > --- > drivers/gpu/drm/tegra/drm.c | 4 > drivers/gpu/drm/tegra/gem.c | 8 > 2 files changed, 8 insertions(+), 4 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Inte

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

2018-04-26 Thread Thierry Reding
cases of drm_dev_unref() with drm_dev_put and remove > the function itself. > > Coccinelle was used for mass-patching. > > Signed-off-by: Vaishali Thakkar Yes, please. Acked-by: Thierry Reding signature.asc Description: PGP signature ___

Re: [Intel-gfx] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Thierry Reding
gt; Cc: Rodrigo Vivi > Cc: Philipp Zabel > Cc: CK Hu > Cc: Matthias Brugger > Cc: Rob Clark > Cc: Ben Skeggs > Cc: Tomi Valkeinen > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: Sandy Huang > Cc: "Heiko Stübner" > Cc: Thierry Reding > Cc: Jon

Re: [Intel-gfx] [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

2018-11-20 Thread Thierry Reding
ungmin Park > Cc: Russell King > Cc: CK Hu > Cc: Philipp Zabel > Cc: Rob Clark > Cc: Ben Skeggs > Cc: Tomi Valkeinen > Cc: Sandy Huang > Cc: "Heiko Stübner" > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Cc: Thierry Reding > Cc: Eric Anholt

Re: [Intel-gfx] [PATCH] drm: Document code of conduct

2017-04-11 Thread Thierry Reding
; https://cgit.freedesktop.org/wayland/wayland/commit/?id=0eefe99fe0683ae409b665a8b18cc7eb648c6c0c > > Cc: Daniel Stone > Cc: Keith Packard > Cc: tfh...@err.no > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/introduction.rst | 1

[Intel-gfx] [PATCH v2 2/9] drm/fb-helper: Reshuffle code for subsequent patches

2016-06-07 Thread Thierry Reding
From: Thierry Reding An unlocked version of the drm_fb_helper_add_one_connector() function will be added in a subsequent patch. Reshuffle the code separately to make the diff more readable later on. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_fb_helper.c | 60

[Intel-gfx] [PATCH v2 7/9] drm/atmel-hlcdc: Remove custom FB helper deferred setup

2016-06-07 Thread Thierry Reding
From: Thierry Reding The FB helper core now supports deferred setup, so the driver's custom implementation can be removed. Signed-off-by: Thierry Reding --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-)

[Intel-gfx] [PATCH v2 0/9] drm/fb-helper: Deferred setup support

2016-06-07 Thread Thierry Reding
From: Thierry Reding This set of patches adds support for deferring FB helper setup, which is useful to obtain a sane configuration even when no outputs are available during probe. One example is HDMI, where fbdev will currently fallback to a 1024x786 resolution if no monitor is connected, and

[Intel-gfx] [PATCH v2 6/9] drm/fb-helper: Support deferred setup

2016-06-07 Thread Thierry Reding
From: Thierry Reding FB helper code falls back to a 1024x768 mode if no outputs are connected or don't report back any modes upon initialization. This can be annoying because outputs that are added to FB helper later on can't be used with FB helper if they don't support a matc

[Intel-gfx] [PATCH v2 3/9] drm/fb-helper: Improve code readability

2016-06-07 Thread Thierry Reding
From: Thierry Reding Add a couple of temporary variables and use shorter names for existing variables in drm_fb_helper_add_one_connector() for better readability. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_fb_helper.c | 26 -- 1 file changed, 16 insertions

[Intel-gfx] [PATCH v2 8/9] drm/exynos: Remove custom FB helper deferred setup

2016-06-07 Thread Thierry Reding
From: Thierry Reding The FB helper core now supports deferred setup, so the driver's custom implementation can be removed. Signed-off-by: Thierry Reding --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 8 ++-- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 -- 2 files changed, 6 inser

[Intel-gfx] [PATCH v2 5/9] drm/fb-helper: Add top-level lock

2016-06-07 Thread Thierry Reding
From: Thierry Reding Introduce a new top-level lock for the FB helper code. This will allow better locking granularity and avoid the need to abuse modeset locking for this purpose instead. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_fb_helper.c | 27

[Intel-gfx] [PATCH v2 1/9] drm/fb-helper: Cleanup checkpatch warnings

2016-06-07 Thread Thierry Reding
From: Thierry Reding Fix up a couple of checkpatch warnings, such as whitespace or coding style issues. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_fb_helper.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 9/9] drm/hisilicon: Remove custom FB helper deferred setup

2016-06-07 Thread Thierry Reding
From: Thierry Reding The FB helper core now supports deferred setup, so the driver's custom implementation can be removed. Signed-off-by: Thierry Reding --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-)

[Intel-gfx] [PATCH v2 4/9] drm/fb-helper: Push down modeset lock into FB helpers

2016-06-07 Thread Thierry Reding
From: Thierry Reding Move the modeset locking from drivers into FB helpers. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_fb_helper.c| 59 +- drivers/gpu/drm/i915/intel_dp_mst.c| 4 --- drivers/gpu/drm/radeon/radeon_dp_mst.c | 7 3

Re: [Intel-gfx] [PATCH 15/29] drm/tegra: Use drm_gem_object_unreference_unlocked

2015-11-23 Thread Thierry Reding
locked doesn't exist as kbuild spotted. > > Cc: Thierry Reding > Acked-by: Thierry Reding > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/tegra/drm.c | 4 +--- > drivers/gpu/drm/tegra/gem.c | 6 +- > 2 files changed, 2 insertions(+), 8 deletions(-) Appl

Re: [Intel-gfx] [PATCH 14/29] drm/tegra: don't take dev->struct_mutex in mmap offset ioctl

2015-11-23 Thread Thierry Reding
ed > variant (since the drm core still cares). > > v2: Finally get rid of the copypasta from another commit in this > commit message. And convert to _unlocked like we need to (Patrik). > > Cc: Patrik Jakobsson > Cc: Thierry Reding > Acked-by: Thierry Reding > Reviewe

Re: [Intel-gfx] [PATCH 07/29] drm/tegra: Use unlocked gem unreferencing

2015-11-23 Thread Thierry Reding
d1a8cfc6c71663 > Author: Daniel Vetter > Date: Thu Oct 15 09:36:25 2015 +0200 > > drm/gem: Check locking in drm_gem_object_unreference > > Cc: Thierry Reding > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/tegra/drm.c | 10 +- > 1 file chan

Re: [Intel-gfx] [PATCH 2/9] drm/tegra: Assign conn_state->connector when allocating connector state.

2015-11-24 Thread Thierry Reding
On Tue, Nov 24, 2015 at 10:34:29AM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/tegra/dsi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Acked-by: Thierry Reding signature.asc Description: P

Re: [Intel-gfx] [PATCH 2/9] drm/tegra: Assign conn_state->connector when allocating connector state.

2015-11-24 Thread Thierry Reding
On Tue, Nov 24, 2015 at 11:37:47AM +0100, Daniel Vetter wrote: > On Tue, Nov 24, 2015 at 10:34:29AM +0100, Maarten Lankhorst wrote: > > Signed-off-by: Maarten Lankhorst > > --- > > drivers/gpu/drm/tegra/dsi.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drive

Re: [Intel-gfx] [PATCH 2/3] drm/atomic: Add __drm_atomic_helper_connector_reset.

2015-12-07 Thread Thierry Reding
On Tue, Nov 24, 2015 at 02:35:33PM +0100, Maarten Lankhorst wrote: > This is useful for drivers that subclass connector_state, like tegra. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_atomic_helper.c | 30 ++ > include/drm/drm_atomic_helper.h |

Re: [Intel-gfx] [PATCH 2/3] drm/atomic: Add __drm_atomic_helper_connector_reset.

2015-12-07 Thread Thierry Reding
On Tue, Nov 24, 2015 at 02:35:33PM +0100, Maarten Lankhorst wrote: > This is useful for drivers that subclass connector_state, like tegra. One more nit: s/tegra/Tegra/ Thierry signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-g

Re: [Intel-gfx] [PATCH 3/3] drm/tegra: Use __drm_atomic_helper_reset_connector for subclassing connector state.

2015-12-07 Thread Thierry Reding
On Tue, Nov 24, 2015 at 02:35:34PM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/tegra/dsi.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c > index f0a138ef68

Re: [Intel-gfx] [PATCH 5/9] drm/atomic: add connector mask to drm_crtc_state.

2015-12-07 Thread Thierry Reding
On Tue, Nov 24, 2015 at 10:34:32AM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/drm_atomic.c | 11 +++ > include/drm/drm_crtc.h | 3 +++ > 2 files changed, 14 insertions(+) I think this could use a proper commit message. As it is, it's

Re: [Intel-gfx] [PATCH 8/9] drm/atomic: Remove drm_atomic_connectors_for_crtc.

2015-12-07 Thread Thierry Reding
if (!crtc_state->connector_mask) { Similarly I think it would be more natural to say: if (crtc->state->connector_mask == 0) here. Anyway, this is mostly about personal taste, and the change looks correct to me (after checking twice that I got the double negation righ

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Update connector_mask during readout.

2015-12-07 Thread Thierry Reding
On Tue, Nov 24, 2015 at 10:34:33AM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_display.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: P

Re: [Intel-gfx] [PATCH 01/28] drm: Polish fbdev helper struct docs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:42AM +0100, Daniel Vetter wrote: > Mostly this is just adding extensive docs for the callbacks, but also > a few other additions. > > v2: Use FIXME comments to annotate helper hooks that should be > replaced. > > Signed-off-by: Daniel Vetter > --- > include/drm/drm

Re: [Intel-gfx] [PATCH 03/28] drm: Reorganize helper vtables and their docs

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:44AM +0100, Daniel Vetter wrote: [...] > diff --git a/drivers/gpu/drm/drm_crtc_helper.c > b/drivers/gpu/drm/drm_crtc_helper.c > index 10d0989db273..077e48d3cac2 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -62,6 +62,1

Re: [Intel-gfx] [PATCH 02/28] drm: Move LEAVE/ENTER_ATOMIC_MODESET to fbdev helpers

2015-12-07 Thread Thierry Reding
7 insertions(+), 4 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 04/28] drm: Make helper vtable pointers type-safe

2015-12-07 Thread Thierry Reding
is only trouble since gcc can't warn you if you > mix them up. Let's fix that and make them typesafe. > > Signed-off-by: Daniel Vetter > --- > include/drm/drm_crtc.h | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) Very good: Re

Re: [Intel-gfx] [PATCH 05/28] drm: Merge helper docbook into kerneldoc comments

2015-12-07 Thread Thierry Reding
On Fri, Dec 04, 2015 at 09:45:46AM +0100, Daniel Vetter wrote: [...] > diff --git a/drivers/gpu/drm/drm_crtc_helper.c > b/drivers/gpu/drm/drm_crtc_helper.c > index 077e48d3cac2..c4fbcf8e6664 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -51,6 +51,1

  1   2   3   4   5   >