Re: [Intel-gfx] [PATCH] drm/i915: Fix garbage pixels on top of LVDS on IVY laptop

2012-12-07 Thread Takashi Iwai
At Fri, 7 Dec 2012 18:04:06 +0100, Daniel Vetter wrote: > > On Fri, Dec 7, 2012 at 5:28 PM, Takashi Iwai wrote: > > At Fri, 7 Dec 2012 16:47:05 +0100, > > Daniel Vetter wrote: > >> > >> On Fri, Dec 7, 2012 at 2:17 PM, Takashi Iwai wrote: > >>

Re: [Intel-gfx] [PATCH] drm/i915: Fix garbage pixels on top of LVDS on IVY laptop

2012-12-10 Thread Takashi Iwai
At Fri, 7 Dec 2012 19:07:32 +0100, Daniel Vetter wrote: > > On Fri, Dec 7, 2012 at 7:05 PM, Daniel Vetter wrote: > >> I tried to move the w/a to enable code, but also didn't help. > >> > >> So... your guess appears really feasible. > >> Then this is a side-effect of the new modeset code by optimi

Re: [Intel-gfx] [PATCH] drm/i915: Fix garbage pixels on top of LVDS on IVY laptop

2012-12-10 Thread Takashi Iwai
At Sat, 8 Dec 2012 13:01:29 +0100, Daniel Vetter wrote: > > On Fri, Dec 07, 2012 at 07:07:32PM +0100, Daniel Vetter wrote: > > On Fri, Dec 7, 2012 at 7:05 PM, Daniel Vetter > > wrote: > > >> I tried to move the w/a to enable code, but also didn't help. > > >> > > >> So... your guess appears real

Re: [Intel-gfx] [PATCH] drm/i915: Fix garbage pixels on top of LVDS on IVY laptop

2012-12-10 Thread Takashi Iwai
At Mon, 10 Dec 2012 11:30:23 +0100, Daniel Vetter wrote: > > On Mon, Dec 10, 2012 at 11:19 AM, Takashi Iwai wrote: > >> Also please retest with latest drm-intel-nightly and the following patch: > >> > >> https://patchwork.kernel.org/patch/1852411/ &g

[Intel-gfx] [PATCH v2] drm/i915: Fix shifted screen on top of LVDS on IVY laptop

2012-12-11 Thread Takashi Iwai
when go and back from S3. (S4 resume still shows the same problem.) This patch revives the minimum part the commit above dropped. For fixing this regression, only the setup of CHICKEN2 bit in cpt_init_clock_gating() is needed. Signed-off-by: Takashi Iwai --- v1->v2: subject changed, more comme

Re: [Intel-gfx] [PATCH 1/2] fb: Rework locking to fix lock ordering on takeover

2013-01-23 Thread Takashi Iwai
At Wed, 23 Jan 2013 17:25:08 +0100, Daniel Vetter wrote: > > From: Alan Cox > > Adjust the console layer to allow a take over call where the caller already > holds the locks. Make the fb layer lock in order. > > This s partly a band aid, the fb layer is terminally confused about the > locking r

Re: [Intel-gfx] the monitors with working Displayport audio

2011-11-08 Thread Takashi Iwai
At Wed, 9 Nov 2011 15:20:53 +0800, Wu Fengguang wrote: > > Hi Takashi, > > I enumerated all the DELL DisplayPort monitors in our lab and find > only two of them being able to produce audible DisplayPort audio... Thanks for testing! > - DELL 2408WFP > - DELL 2709W > - DELL 3008WFP > no C

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Thu, 10 Nov 2011 12:00:53 +0100, Christopher White wrote: > > On 11/10/11 9:55 AM, Christopher White wrote: > > On 11/10/11 8:55 AM, Wu Fengguang wrote: > >> On Thu, Nov 10, 2011 at 03:33:50PM +0800, Wu Fengguang wrote: > >>> Wow I reproduced the bug and got a very interesting dmesg: > >>> > >>

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Thu, 10 Nov 2011 12:50:11 +0100, Christopher White wrote: > > On 11/10/11 12:22 PM, Takashi Iwai wrote: > > At Thu, 10 Nov 2011 12:00:53 +0100, > > Christopher White wrote: > >> On 11/10/11 9:55 AM, Christopher White wrote: > >>> On 11/10/11 8:55 AM, Wu

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Thu, 10 Nov 2011 13:39:00 +0100, Christopher White wrote: > > On 11/10/11 12:53 PM, Takashi Iwai wrote: > > At Thu, 10 Nov 2011 12:50:11 +0100, > > Christopher White wrote: > >> On 11/10/11 12:22 PM, Takashi Iwai wrote: > >>> At Thu, 10 Nov 2011 12:00:

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Thu, 10 Nov 2011 21:17:53 +0800, Wu Fengguang wrote: > > On Thu, Nov 10, 2011 at 09:01:24PM +0800, Christopher White wrote: > > On 11/10/11 1:56 PM, Wu Fengguang wrote: > > > On Thu, Nov 10, 2011 at 07:50:11PM +0800, Christopher White wrote: > > >> On 11/1

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Thu, 10 Nov 2011 21:51:50 +0800, Wu Fengguang wrote: > > > > > > So maybe the hardware is in some state that is unable to provide the > > > > > real ELD content? > > > > That's my guess as well. I think the hardware may still be doing some > > > > form of data negotiation with the HDMI display

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Fri, 11 Nov 2011 10:29:25 +0800, Wu Fengguang wrote: > > On Thu, Nov 10, 2011 at 10:28:19PM +0800, Takashi Iwai wrote: > > At Thu, 10 Nov 2011 21:51:50 +0800, > > Wu Fengguang wrote: > > > > > > > > > > So maybe the hardware is in some st

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-11 Thread Takashi Iwai
At Fri, 11 Nov 2011 16:22:41 +0800, Wu Fengguang wrote: > > On Fri, Nov 11, 2011 at 03:40:37PM +0800, Takashi Iwai wrote: > > At Fri, 11 Nov 2011 10:29:25 +0800, > > Wu Fengguang wrote: > > > > > > On Thu, Nov 10, 2011 at 10:28:19PM +0800, Takashi Iwai wrote:

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-11 Thread Takashi Iwai
At Fri, 11 Nov 2011 17:24:21 +0800, Wu Fengguang wrote: > > On Fri, Nov 11, 2011 at 04:49:57PM +0800, Takashi Iwai wrote: > > At Fri, 11 Nov 2011 16:22:41 +0800, > > Wu Fengguang wrote: > > > > > > On Fri, Nov 11, 2011 at 03:40:37PM +0800, Takashi Iwai wrote:

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-11 Thread Takashi Iwai
At Fri, 11 Nov 2011 19:12:57 +0800, Wu Fengguang wrote: > > (snip) > > > > One note that we don't rely on PD bit because not all (non-Intel) > > > > hardware report it correctly. > > > > > > Oops. Do you imply ELDV is reliable on all platforms? ;-) > > > > Oh hell, no :) > > The driver tries to

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-14 Thread Takashi Iwai
At Sat, 12 Nov 2011 10:27:26 +0800, Wu Fengguang wrote: > > (snip) > > > > > > And I'm not sure whether HDMI audio is played > > > > > > while DPMS is off. I haven't tested it. > > > > > > > > > > It will go silence on DPMS. I noticed this while doing long term HDMI > > > > > audio playback test

Re: [Intel-gfx] [PATCH 1/2] hda - fix ELD memory leak

2011-11-15 Thread Takashi Iwai
At Tue, 15 Nov 2011 22:31:55 +0800, Wu Fengguang wrote: > > memset(eld) clears eld->proc_entry which will leak the struct > snd_info_entry when unloading the module. > > Fix it by > - remove memset(eld) > - set eld->eld_valid to true _after_ all eld fields have been filled > - don't access the ot

Re: [Intel-gfx] [PATCH 1/2] hda - fix ELD memory leak

2011-11-15 Thread Takashi Iwai
At Tue, 15 Nov 2011 22:41:16 +0800, Wu Fengguang wrote: > > On Tue, Nov 15, 2011 at 10:35:41PM +0800, Takashi Iwai wrote: > > At Tue, 15 Nov 2011 22:31:55 +0800, > > Wu Fengguang wrote: > > > > > > memset(eld) clears eld->proc_entry which will leak the str

Re: [Intel-gfx] [PATCH 2/2 v2] hda - delayed ELD repoll

2011-11-15 Thread Takashi Iwai
At Wed, 16 Nov 2011 00:57:08 +0800, Wu Fengguang wrote: > +static void hda_eld_work(struct work_struct *work) > +{ > + struct hdmi_eld *eld = container_of( > + container_of(work, struct delayed_work, work), > + struct hdmi_eld, work); Ugh

Re: [Intel-gfx] [PATCH v4] drivers: i915: Default backlight PWM frequency

2011-11-15 Thread Takashi Iwai
At Fri, 11 Nov 2011 14:12:58 -0800, Simon Que wrote: > > If the firmware did not initialize the backlight PWM registers, set up a > default PWM frequency of 200 Hz. This is determined using the following > formula: > > freq = refclk / (128 * pwm_max) > > The PWM register allows the max PWM va

Re: [Intel-gfx] [PATCH] i915: Fix bug where screen brightness is not restored

2011-11-15 Thread Takashi Iwai
At Tue, 15 Nov 2011 11:58:38 -0800, Kamal Mostafa wrote: > > [1 ] > [1.1 ] > On Mon, 2011-11-14 at 18:42 -0800, Alex Davis wrote: > > From: Alex Davis > > > > This patch fixes an issue where the screen would remain dark when > > > > a key was pressed when the laptop lid was reopened or after t

Re: [Intel-gfx] [PATCH] i915: Fix bug where screen brightness is not restored

2011-11-16 Thread Takashi Iwai
At Tue, 15 Nov 2011 13:54:44 -0800, Kamal Mostafa wrote: > > On Tue, 2011-11-15 at 21:28 +0100, Takashi Iwai wrote: > > My rough guess is the inconsistency of property taken during the > > backlight disabled. How about the patch below (untested!) in addition >

[Intel-gfx] [PATCH] drm/i915: Fix inconsistent backlight level during disabled

2011-11-16 Thread Takashi Iwai
instead, so that it won't be influenced by the backlight-enable state. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=41926 BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/872652 Tested-by: Kamal Mostafa Cc: Alex Davis Cc: Signed-off-by: Takashi Iwai --- drivers/gp

Re: [Intel-gfx] [alsa-devel] [PATCH 2/2] hda - delayed ELD repoll

2011-11-16 Thread Takashi Iwai
At Wed, 16 Nov 2011 07:51:28 -0800, Stephen Warren wrote: > > > > 250mS almost sounds like it's setting ELDV in the audio HW, > > > then going and reading the EDID, then writing the EDID to the audio HW; > > > perhaps the graphics driver is accidentally setting PRESENT+ELDV when it's > > > meant t

Re: [Intel-gfx] [alsa-devel] [PATCH 2/2] hda - delayed ELD repoll

2011-11-16 Thread Takashi Iwai
At Wed, 16 Nov 2011 08:12:04 -0800, Stephen Warren wrote: > > Takashi Iwai wrote at Wednesday, November 16, 2011 8:58 AM: > > At Wed, 16 Nov 2011 07:51:28 -0800, Stephen Warren wrote: > ... > > > > [ 424.263258] HDMI hot plug event: Codec=3 Pin=6 Presence_De

[Intel-gfx] [PATCH] drm/i915: Fix invalid backpanel values for GEN3 or older chips

2011-11-16 Thread Takashi Iwai
off suddenly. This patch changes the bit-0 check by replacing with the condition of gen < 4 (pineview is included in this condition, too). Reported-and-tested-by: Daniel Mack Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_panel.c |8 +++- 1 files changed, 3 inserti

Re: [Intel-gfx] [PATCH] drm/i915: Fix invalid backpanel values for GEN3 or older chips

2011-11-17 Thread Takashi Iwai
At Wed, 16 Nov 2011 22:15:41 -0800, Keith Packard wrote: > > On Wed, 16 Nov 2011 18:14:55 +0100, Takashi Iwai wrote: > > > While refactoring of backlight control code in commit [a95735569: > > drm/i915: Refactor panel backlight controls], the handling of the bit > &g

Re: [Intel-gfx] [PATCH] drm/i915: Fix invalid backpanel values for GEN3 or older chips

2011-11-19 Thread Takashi Iwai
At Fri, 18 Nov 2011 11:25:48 -0800, Keith Packard wrote: > > On Thu, 17 Nov 2011 17:33:50 +0100, Takashi Iwai wrote: > > > If it's only with 915GM, we'll just need to change IS_PINEVEW() to > > IS_PINEVIEW() || IS_I915GM(). This might be a safer option at this

Re: [Intel-gfx] [PATCH] drm/i915: Fix invalid backpanel values for GEN3 or older chips

2011-11-20 Thread Takashi Iwai
At Sat, 19 Nov 2011 10:34:12 -0800, Keith Packard wrote: > > [1 ] > On Sat, 19 Nov 2011 11:05:05 +0100, Takashi Iwai wrote: > > > Maybe it'd be better to mention that actually setting bit-0 caused a > > blank screen on some machines. > > Was that caused by

Re: [Intel-gfx] [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-21 Thread Takashi Iwai
At Mon, 21 Nov 2011 09:58:09 +0800, Wu Fengguang wrote: > > On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote: > > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang > > wrote: > > > > > However when in X, ->mode_set won't be called at all. Only > > > ->get_modes and ->detect are cal

Re: [Intel-gfx] [PATCH 0/5] Intel HDMI ELD fixes v2

2011-12-09 Thread Takashi Iwai
ers/gpu/drm/i915/intel_display.c | 75 +++-- > drivers/gpu/drm/i915/intel_dp.c |1 > drivers/gpu/drm/i915/intel_hdmi.c|8 ++ > 4 files changed, 76 insertions(+), 30 deletions(-) Thanks. Feel free to add my ack to all these. Acked-by: Takashi Iwai Takashi _

[Intel-gfx] [PATCH] drm/i915: Don't write DSPSURF for old chips

2012-02-27 Thread Takashi Iwai
It seems that writing DSPSURF in intel_flush_display_plane() causes the blank screen on some old laptops like Dell D630 with 965GM. Since this operation is needed only for ILK+, make it conditional. Cc: [v3.1+] Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_display.c |3 ++- 1

Re: [Intel-gfx] [PATCH] drm/i915: Don't write DSPSURF for old chips

2012-02-27 Thread Takashi Iwai
At Mon, 27 Feb 2012 12:17:57 +, Chris Wilson wrote: > > On Mon, 27 Feb 2012 12:39:24 +0100, Takashi Iwai wrote: > > It seems that writing DSPSURF in intel_flush_display_plane() causes > > the blank screen on some old laptops like Dell D630 with 965GM. > > Since this

Re: [Intel-gfx] [PATCH] drm/i915: Don't write DSPSURF for old chips

2012-02-27 Thread Takashi Iwai
At Mon, 27 Feb 2012 14:08:28 +0100, Takashi Iwai wrote: > > At Mon, 27 Feb 2012 12:17:57 +, > Chris Wilson wrote: > > > > On Mon, 27 Feb 2012 12:39:24 +0100, Takashi Iwai wrote: > > > It seems that writing DSPSURF in intel_flush_display_plane() causes >

Re: [Intel-gfx] [PATCH] drm/i915: Don't write DSPSURF for old chips

2012-02-29 Thread Takashi Iwai
At Wed, 29 Feb 2012 23:54:46 +, Chris Wilson wrote: > > On Tue, 28 Feb 2012 07:43:55 +0100, Takashi Iwai wrote: > > At Mon, 27 Feb 2012 14:08:28 +0100, > > Takashi Iwai wrote: > > > > > > At Mon, 27 Feb 2012 12:17:57 +, > > > Chris Wilson w

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-14 Thread Takashi Iwai
At Wed, 14 Mar 2012 10:45:06 -0400, Adam Jackson wrote: > > [1 ] > [1.1 ] > On Wed, 2012-03-14 at 13:37 +0100, Helge Bahmann wrote: > > Hi everyone, > > > > Booting a Thinkpad T420 with the lid closed results and opening it > > subsequently results in an > > unusable picture on the panel (and

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-15 Thread Takashi Iwai
At Wed, 14 Mar 2012 14:09:19 -0400, Adam Jackson wrote: > > On Wed, 2012-03-14 at 17:44 +0100, Takashi Iwai wrote: > > At Wed, 14 Mar 2012 10:45:06 -0400, > > Adam Jackson wrote: > > > There may or may not be a bit for this in the VBT in the BIOS. But the > >

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-15 Thread Takashi Iwai
At Thu, 15 Mar 2012 13:25:08 +, Chris Wilson wrote: > > On Thu, 15 Mar 2012 14:15:54 +0100, Takashi Iwai wrote: > > +static bool is_dual_link_lvds(struct drm_i915_private *dev_priv) > > +{ > > + /* BIOS should set the proper LVDS register value at boot, but &

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-15 Thread Takashi Iwai
At Thu, 15 Mar 2012 14:30:35 +0100, Takashi Iwai wrote: > > At Thu, 15 Mar 2012 13:25:08 +, > Chris Wilson wrote: > > > > On Thu, 15 Mar 2012 14:15:54 +0100, Takashi Iwai wrote: > > > +static bool is_dual_link_lvds(struct drm_i915_private *dev_priv) > >

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-16 Thread Takashi Iwai
At Fri, 16 Mar 2012 15:55:52 -0400, Adam Jackson wrote: > > On 3/15/12 10:42 AM, Takashi Iwai wrote: > > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > b/drivers/gpu/drm/i915/intel_display.c > > index f851db7..314af26 100644 > > --- a/drivers/gpu/d

[Intel-gfx] [PATCH 0/2 v4] drm/i915: LVDS channel mode fixes

2012-03-16 Thread Takashi Iwai
Hi, this is the revised patch for fixing the wrong LVDS channel mode, e.g. when booted while the lid is closed. Also, a new module option to override the LVDS channel mode is added in the second patch. v1->v2: Fix the register for gen<=4 v2->v3: Check the resolution of the entry to be sure v3->v

[Intel-gfx] [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too

2012-03-16 Thread Takashi Iwai
igned-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/intel_bios.c| 26 ++ drivers/gpu/drm/i915/intel_display.c | 26 -- 3 files changed, 47 insertions(+), 6 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH 2/2] drm/i915: Add lvds_channel module option

2012-03-16 Thread Takashi Iwai
Add a new module optoin lvds_channel to specify the LVDS channel mode explicitly instead of probing the LVDS register value set by BIOS. This will be helpful when VBT is broken or incompatible with the current code. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.c |6

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too

2012-03-17 Thread Takashi Iwai
At Fri, 16 Mar 2012 16:18:03 -0700, Keith Packard wrote: > > <#part sign=pgpmime> > On Fri, 16 Mar 2012 22:41:12 +0100, Takashi Iwai wrote: > > > +/* read the initial LVDS register value for the given panel mode */ > > +static unsigned int get_lvds_reg_va

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add lvds_channel module option

2012-03-17 Thread Takashi Iwai
At Fri, 16 Mar 2012 22:51:22 -0300, Eugeni Dodonov wrote: > > [1 ] > On Fri, Mar 16, 2012 at 18:41, Takashi Iwai wrote: > > > Add a new module optoin lvds_channel to specify the LVDS channel mode > > explicitly instead of probing the LVDS register value set by BIOS.

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-18 Thread Takashi Iwai
At Sun, 18 Mar 2012 18:50:31 +0100, Daniel Vetter wrote: > > On Fri, Mar 16, 2012 at 09:29:24PM +0100, Takashi Iwai wrote: > > At Fri, 16 Mar 2012 15:55:52 -0400, > > Adam Jackson wrote: > > > > > > On 3/15/12 10:42 AM, Takashi Iwai wrote: > > &g

Re: [Intel-gfx] Thinkpad T420 and single/dual channel lvds

2012-03-18 Thread Takashi Iwai
At Sun, 18 Mar 2012 19:01:21 +0100, Andreas Heider wrote: > > Am 18.03.2012 um 18:50 schrieb Daniel Vetter: > > On Fri, Mar 16, 2012 at 09:29:24PM +0100, Takashi Iwai wrote: > >> At Fri, 16 Mar 2012 15:55:52 -0400, > >> Adam Jackson wrote: > >>> >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too

2012-03-18 Thread Takashi Iwai
At Sat, 17 Mar 2012 12:01:17 -0700, Keith Packard wrote: > > <#part sign=pgpmime> > On Sat, 17 Mar 2012 08:59:56 +0100, Takashi Iwai wrote: > > > Well, the LVDS reg data isn't in lvds_dvo_timing but in lvds_fp_timing, > > thus you need to look at a diffe

[Intel-gfx] [PATCH 0/2 v5] drm/i915: LVDS channel mode fixes

2012-03-19 Thread Takashi Iwai
Hi, this is the revised series of patches for fixing the wrong LVDS channel mode on some laptops in a certan situation such as boot with the closed lid. v1->v2: Fix the register for gen<=4 v2->v3: Check the resolution of the entry to be sure v3->v4: Optimize the register reference; add a module o

[Intel-gfx] [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too

2012-03-19 Thread Takashi Iwai
igned-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/intel_bios.c| 36 ++ drivers/gpu/drm/i915/intel_display.c | 26 ++-- 3 files changed, 57 insertions(+), 6 deletions(-) diff --git a/driver

[Intel-gfx] [PATCH 2/2] drm/i915: Add lvds_channel module option

2012-03-19 Thread Takashi Iwai
Add a new module optoin lvds_channel to specify the LVDS channel mode explicitly instead of probing the LVDS register value set by BIOS. This will be helpful when VBT is broken or incompatible with the current code. Reviewed-by: Eugeni Dodonov Signed-off-by: Takashi Iwai --- drivers/gpu/drm

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too

2012-03-20 Thread Takashi Iwai
At Tue, 20 Mar 2012 11:01:22 +0100, Daniel Vetter wrote: > > On Mon, Mar 19, 2012 at 12:07:36PM +0100, Takashi Iwai wrote: > > Currently i915 driver checks [PCH_]LVDS register bits to decide > > whether to set up the dual-link or the single-link mode. This relies > >

[Intel-gfx] [PATCH 0/2 v6] drm/i915: LVDS channel mode fixes

2012-03-20 Thread Takashi Iwai
Hi, this is yet another respin of the previous LVDS channel mode fix patches. v1->v2: Fix the register for gen<=4 v2->v3: Check the resolution of the entry to be sure v3->v4: Optimize the register reference; add a module option v4->v5: Check whether the data points within lvds_fp_data block pro

[Intel-gfx] [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too

2012-03-20 Thread Takashi Iwai
igned-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.h |2 ++ drivers/gpu/drm/i915/intel_bios.c| 36 ++ drivers/gpu/drm/i915/intel_display.c | 30 ++-- 3 files changed, 62 insertions(+), 6 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH 2/2] drm/i915: Add lvds_channel module option

2012-03-20 Thread Takashi Iwai
Dodonov Reviewed-by: Adam Jackson Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.c |6 ++ drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/intel_display.c |4 3 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.c b

Re: [Intel-gfx] [Linux v4.0-rc5] Warnings in drm_framebuffer_reference() and drm_atomic_check_only()

2015-03-25 Thread Takashi Iwai
At Mon, 23 Mar 2015 09:25:06 +0100, Daniel Vetter wrote: > > On Mon, Mar 23, 2015 at 07:25:27AM +0100, Sedat Dilek wrote: > > Hi, > > > > I did my weekly update of the Linux RC (here: v4.0-rc5) and fell over > > some warning in the drm area. > > > > Please have a look... > > Just to confirm: Bo

Re: [Intel-gfx] [Linux v4.0-rc5] Warnings in drm_framebuffer_reference() and drm_atomic_check_only()

2015-03-25 Thread Takashi Iwai
At Wed, 25 Mar 2015 14:26:50 +0100, Daniel Vetter wrote: > > On Tue, Mar 24, 2015 at 07:09:03PM +0100, Sedat Dilek wrote: > > On Mon, Mar 23, 2015 at 9:25 AM, Daniel Vetter wrote: > > > On Mon, Mar 23, 2015 at 07:25:27AM +0100, Sedat Dilek wrote: > > >> Hi, > > >> > > >> I did my weekly update of

Re: [Intel-gfx] [git pull] drm fixes

2015-03-25 Thread Takashi Iwai
At Wed, 25 Mar 2015 15:00:08 +0100, Daniel Vetter wrote: > > On Wed, Mar 25, 2015 at 09:11:17AM -0400, Josh Boyer wrote: > > On Wed, Mar 25, 2015 at 4:54 AM, Daniel Vetter wrote: > > >> >> commit f55548b5af87ebfc586ca75748947f1c1b1a4a52 > > >> >> Author: Damien Lespiau > > >> >> Date: Thu Feb

Re: [Intel-gfx] [Linux v4.0-rc5] Warnings in drm_framebuffer_reference() and drm_atomic_check_only()

2015-03-27 Thread Takashi Iwai
At Fri, 27 Mar 2015 12:01:33 +0100, Sedat Dilek wrote: > > On Wed, Mar 25, 2015 at 3:34 PM, Takashi Iwai wrote: > > At Wed, 25 Mar 2015 14:26:50 +0100, > > Daniel Vetter wrote: > >> > >> On Tue, Mar 24, 2015 at 07:09:03PM +0100, Sedat Dilek wrote: > >&

Re: [Intel-gfx] [PATCH 15/19] drm/i915: HSW cdclk support

2015-04-09 Thread Takashi Iwai
king was > > > > aa2fee4286e43b4784982b17669b02cc99c1ae55. > > > > > I rerun the bisecting and this time the result was > > > > commit 0a599838737a2527c35e4d94f794aefe59df1781 > > Merge: 2d846c7 a59d719 > > Author: Takashi Iwai > > Date:

[Intel-gfx] X hang with quirk VT switches

2014-12-03 Thread Takashi Iwai
Hi, while checking the reported bug about VT switch hang on openSUSE 13.2, I also could reproduce a similar issue as reported: namely, X hangs when repeatedly switching VT quickly. For example, running the following on KDE results in the stall of X. % for i in $(seq 1 100); do chvt 1; ch

Re: [Intel-gfx] X hang with quirk VT switches

2014-12-03 Thread Takashi Iwai
At Wed, 3 Dec 2014 18:31:45 +, Chris Wilson wrote: > > On Wed, Dec 03, 2014 at 03:45:35PM +0100, Takashi Iwai wrote: > > Hi, > > > > while checking the reported bug about VT switch hang on openSUSE 13.2, > > I also could reproduce a similar issue as repo

Re: [Intel-gfx] X hang with quirk VT switches

2014-12-04 Thread Takashi Iwai
At Wed, 3 Dec 2014 18:31:45 +, Chris Wilson wrote: > > On Wed, Dec 03, 2014 at 03:45:35PM +0100, Takashi Iwai wrote: > > Hi, > > > > while checking the reported bug about VT switch hang on openSUSE 13.2, > > I also could reproduce a similar issue as repo

Re: [Intel-gfx] X hang with quirk VT switches

2014-12-04 Thread Takashi Iwai
At Thu, 4 Dec 2014 11:21:47 +, Chris Wilson wrote: > > On Thu, Dec 04, 2014 at 11:53:05AM +0100, Takashi Iwai wrote: > > At Wed, 3 Dec 2014 18:31:45 +, > > Chris Wilson wrote: > > > > > > On Wed, Dec 03, 2014 at 03:45:35PM +0100, Takashi Iwai wrote

Re: [Intel-gfx] [PATCH] drm: Make drm_read() more robust against multithreaded races

2014-12-05 Thread Takashi Iwai
nlock around the list walking and event copying, and importantly > reorder the error handling to avoid the issues above. > > Cc: Takashi Iwai Reviewed-by: Takashi Iwai Takashi > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/drm_fops.c | 90 > +++

Re: [Intel-gfx] [PATCH v2 4/5] ALSA: hda: add component support

2014-12-09 Thread Takashi Iwai
At Tue, 9 Dec 2014 11:19:34 +0100, Daniel Vetter wrote: > > On Tue, Dec 09, 2014 at 11:41:18AM +0200, Imre Deak wrote: > > Register a component master to be used to interface with the i915 > > driver. This is meant to replace the current interface which is based on > > module symbol lookups. > >

Re: [Intel-gfx] [PATCH 0/5] sanitize hda/i915 interface using the component fw

2014-12-09 Thread Takashi Iwai
At Tue, 09 Dec 2014 18:56:07 +0200, Imre Deak wrote: > > On Tue, 2014-12-09 at 11:03 +0100, Daniel Vetter wrote: > > On Tue, Dec 09, 2014 at 10:59:54AM +0200, Imre Deak wrote: > > > On Mon, 2014-12-08 at 21:14 +0100, Daniel Vetter wrote: > > > > On Mon, Dec 08, 2014 at 06:42:04PM +0200, Imre Deak

[Intel-gfx] [PATCH] drm/i915, HD-audio: Don't continue probing when nomodeset is given

2014-06-13 Thread Takashi Iwai
[3.15] Signed-off-by: Takashi Iwai --- The bug actually exists since 3.11, but this commit will be applicable only to recent kernels due to ALSA and i915 code changes, that's why marked with [3.15] for stable. drivers/gpu/drm/i915/intel_pm.c | 14 -- include/drm/i915_powerwell

Re: [Intel-gfx] [PATCH] drm/i915, HD-audio: Don't continue probing when nomodeset is given

2014-06-13 Thread Takashi Iwai
At Fri, 13 Jun 2014 18:07:06 +0200, Daniel Vetter wrote: > > On Fri, Jun 13, 2014 at 05:56:02PM +0200, Takashi Iwai wrote: > > When a machine is booted with nomodeset option, i915 driver skips the > > whole initialization. Meanwhile, HD-audio tries to bind wth i915 just >

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: provide interface for audio driver to query cdclk

2014-07-03 Thread Takashi Iwai
At Fri, 4 Jul 2014 10:00:37 +0800, mengdong@intel.com wrote: > > From: Jani Nikula > > For Haswell and Broadwell, if the display power well has been disabled, > the display audio controller divider values EM4 M VALUE and EM5 N VALUE > will have been lost. The CDCLK frequency is required for

Re: [Intel-gfx] [PATCH 3/4] snd: add support for displayport multi-stream to hda codec.

2015-06-19 Thread Takashi Iwai
At Fri, 19 Jun 2015 20:33:39 +1000, Dave Airlie wrote: > > On 19 June 2015 at 19:54, Lin, Mengdong wrote: > > Hi Takashi/Dave, > > > > Shall we move or cc this discussion on audio driver side to ALSA ML? > > Oops I thought I had cc'ed these patches to alsa-devel as well when I sent > them. > >

Re: [Intel-gfx] [PATCH 3/4] snd: add support for displayport multi-stream to hda codec.

2015-06-22 Thread Takashi Iwai
At Mon, 22 Jun 2015 14:54:29 +0200, Daniel Vetter wrote: > > On Fri, Jun 19, 2015 at 01:15:57PM +0200, Takashi Iwai wrote: > > At Fri, 19 Jun 2015 20:33:39 +1000, > > Dave Airlie wrote: > > > > > > On 19 June 2015 at 19:54, Lin, Mengdong wrote: > > >

Re: [Intel-gfx] [PATCH 3/4] snd: add support for displayport multi-stream to hda codec.

2015-06-22 Thread Takashi Iwai
At Mon, 22 Jun 2015 15:21:16 +, Kaskinen, Tanu wrote: > > On Mon, 2015-06-22 at 14:29 +0100, Liam Girdwood wrote: > > On Mon, 2015-06-22 at 15:23 +0200, Takashi Iwai wrote: > > > At Mon, 22 Jun 2015 14:54:29 +0200, > > > Daniel Vetter wrote: > > > >

Re: [Intel-gfx] [PATCH 3/4] snd: add support for displayport multi-stream to hda codec.

2015-06-23 Thread Takashi Iwai
At Tue, 23 Jun 2015 07:51:22 +, Kaskinen, Tanu wrote: > > (Added pulseaudio-discuss to CC.) > > On Mon, 2015-06-22 at 17:44 +0200, Takashi Iwai wrote: > > At Mon, 22 Jun 2015 15:21:16 +, > > Kaskinen, Tanu wrote: > > > > > > On Mon, 2015

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

2015-08-20 Thread Takashi Iwai
On Wed, 19 Aug 2015 10:48:58 +0200, David Henningsson wrote: > > Whenever there is an event from the i915 driver, wake the codec > and recheck plug/unplug + ELD status. > > This fixes the issue with lost unsol events in power save mode, > the codec and controller can now sleep in D3 and still kno

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

2015-08-20 Thread Takashi Iwai
On Thu, 20 Aug 2015 11:41:42 +0200, David Henningsson wrote: > > > > On 2015-08-20 11:28, Takashi Iwai wrote: > > On Wed, 19 Aug 2015 10:48:58 +0200, > > David Henningsson wrote: > >> > >> Whenever there is an event from the i915 driver, wake the codec

Re: [Intel-gfx] [PATCH v5 2/4] drm/i915: implement sync_audio_rate callback

2015-08-24 Thread Takashi Iwai
On Mon, 24 Aug 2015 14:53:19 +0200, Ville Syrjälä wrote: > > On Mon, Aug 24, 2015 at 02:38:14AM +, Yang, Libin wrote: > > > -Original Message- > > > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > > > Sent: Friday, August 21, 2015 11:14 PM > > > To: Yang, Libin > > > Cc: a

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

2015-09-02 Thread Takashi Iwai
On Wed, 02 Sep 2015 10:00:44 +0200, Daniel Vetter wrote: > > On Fri, Aug 28, 2015 at 04:10:36PM +0300, Jani Nikula wrote: > > On Thu, 20 Aug 2015, Takashi Iwai wrote: > > > On Thu, 20 Aug 2015 11:41:42 +0200, > > > David Henningsson wrote: > > >>

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on pin/ELD notify events

2015-09-02 Thread Takashi Iwai
On Wed, 02 Sep 2015 10:32:34 +0200, Daniel Vetter wrote: > > On Wed, Sep 02, 2015 at 10:03:55AM +0200, Takashi Iwai wrote: > > On Wed, 02 Sep 2015 10:00:44 +0200, > > Daniel Vetter wrote: > > > > > > On Fri, Aug 28, 2015 at 04:10:36PM +0300, Jani Nikul

Re: [Intel-gfx] [PATCH 0/4 v5] i915 to call hda driver on HDMI plug/unplug

2015-09-02 Thread Takashi Iwai
On Wed, 02 Sep 2015 13:45:03 +0200, Daniel Vetter wrote: > > On Fri, Aug 28, 2015 at 08:14:48PM +0300, Jani Nikula wrote: > > On Fri, 28 Aug 2015, David Henningsson > > wrote: > > > Hopefully last version? :-) > > > > > > * Added commit text about duplicate events (patch 4/4) > > > * Added loc

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset

2015-09-02 Thread Takashi Iwai
On Wed, 02 Sep 2015 11:02:42 +0200, Jani Nikula wrote: > > >> Nitpick. I'd prefer some sharing with the similar blocks from the > >> earlier patch. Also a debug message on n == 0 would be nice; you > >> probably didn't notice your audio_config_get_rate() wasn't working > >> right > >> because this

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset

2015-09-02 Thread Takashi Iwai
On Wed, 02 Sep 2015 15:44:34 +0200, Jani Nikula wrote: > > On Wed, 02 Sep 2015, Takashi Iwai wrote: > > On Wed, 02 Sep 2015 11:02:42 +0200, > > Jani Nikula wrote: > >> > >> >> Nitpick. I'd prefer some sharing with the similar blocks from the > &

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset

2015-09-02 Thread Takashi Iwai
On Wed, 02 Sep 2015 17:22:01 +0200, Daniel Vetter wrote: > > On Wed, Sep 02, 2015 at 03:46:40PM +0200, Takashi Iwai wrote: > > On Wed, 02 Sep 2015 15:44:34 +0200, > > Jani Nikula wrote: > > > > > > On Wed, 02 Sep 2015, Takashi Iwai wrote: > > > >

Re: [Intel-gfx] [PATCH 0/4 v5] i915 to call hda driver on HDMI plug/unplug

2015-09-03 Thread Takashi Iwai
On Thu, 03 Sep 2015 09:52:00 +0200, David Henningsson wrote: > > > > On 2015-08-28 19:02, David Henningsson wrote: > > Hopefully last version? :-) > > > > * Added commit text about duplicate events (patch 4/4) > > * Added locks in bind/unbind on i915 side (patch 2/4) > > * Fixed docbook co

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset

2015-09-03 Thread Takashi Iwai
On Fri, 04 Sep 2015 03:56:26 +0200, Yang, Libin wrote: > > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Wednesday, September 02, 2015 11:36 PM > > To: Daniel Vetter > > Cc: Jani Nikula; Yang, Libin; alsa-

Re: [Intel-gfx] [PATCH] drm/i915: Improve kernel-doc for i915_audio_component struct

2015-09-04 Thread Takashi Iwai
On Fri, 04 Sep 2015 12:33:45 +0200, David Henningsson wrote: > > > > On 2015-09-04 10:03, Daniel Vetter wrote: > > Also please use the new inline style for struct members. > > I tried that, but I couldn't get it to work. This was with Takashi's > for-next tree, do I need to apply some docbook

[Intel-gfx] [PATCH] drm/i915: Fix CSR MMIO address check

2015-09-09 Thread Takashi Iwai
Wlogical-op] Fixes: eb805623d8b1 ('drm/i915/skl: Add support to load SKL CSR firmware.') Cc: # v4.2 Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/dr

Re: [Intel-gfx] [PATCH] drm/i915: add kerneldoc for i915_audio_component

2015-09-09 Thread Takashi Iwai
On Wed, 09 Sep 2015 17:09:52 +0200, Daniel Vetter wrote: > > On Wed, Sep 09, 2015 at 01:45:47AM +, Yang, Libin wrote: > > Hi Daniel, > > > > As Takashi has already accepted the first 3 patches for > > sync_audio_rate() and the patches are not merged > > into -nightly branch. If I make a kern

Re: [Intel-gfx] [PATCH] drm/i915: set proper N/CTS in modeset

2015-09-23 Thread Takashi Iwai
On Wed, 16 Sep 2015 15:03:15 +0200, Jani Nikula wrote: > > > diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h > > index e6d35d7..89dc7d6 100644 > > --- a/include/drm/i915_component.h > > +++ b/include/drm/i915_component.h > > @@ -24,8 +24,18 @@ > > #ifndef _I915_COMPONENT_

Re: [Intel-gfx] [PATCH v2] drm/i915: set proper N/CTS in modeset

2015-09-25 Thread Takashi Iwai
On Fri, 25 Sep 2015 10:01:48 +0200, Jani Nikula wrote: > > On Fri, 25 Sep 2015, libin.y...@intel.com wrote: > > From: Libin Yang > > > > When modeset occurs and the TMDS frequency is set to some > > speical values, the N/CTS need to be set manually if audio > > is playing. > > > > Signed-off-by:

[Intel-gfx] [PATCH] drm/i915: Add missing const to audio_rate_need_prog()

2015-09-30 Thread Takashi Iwai
The lack of const leads to a compile warning after merging i915 upstream tree: drivers/gpu/drm/i915/intel_audio.c:147:13: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *' Reported-by: kbuild test robot Signed-

Re: [Intel-gfx] [PATCH] drm/i915: Add missing const to audio_rate_need_prog()

2015-09-30 Thread Takashi Iwai
On Wed, 30 Sep 2015 14:31:31 +0200, Daniel Vetter wrote: > > On Wed, Sep 30, 2015 at 09:45:03AM +0200, Takashi Iwai wrote: > > The lack of const leads to a compile warning after merging i915 > > upstream tree: > >drivers/gpu/drm/i915/intel_audio.c:147:13

Re: [Intel-gfx] [PATCH-V3 1/2] drm/i915/audio: add codec wakeup override enabled/disable callback

2015-04-30 Thread Takashi Iwai
At Wed, 29 Apr 2015 17:49:25 +0800, han...@intel.com wrote: > > From: "Lu, Han" > > Add support for enabling codec wakeup override signal to allow > re-enumeration of the controller on SKL after resume from low power state. > > v3 by Jani: Simplify to only support toggling the appropriate chick

Re: [Intel-gfx] [PATCH-V3 1/2] drm/i915/audio: add codec wakeup override enabled/disable callback

2015-05-04 Thread Takashi Iwai
gt; > BR, > Jani. > > > [1] http://mid.gmane.org/87fv7i9bgu@intel.com > > > > > > > BR, > > Han Lu > > > >> -Original Message- > >> From: Takashi Iwai [mailto:ti...@suse.de] > >> Sent: Thursday, April 30, 201

Re: [Intel-gfx] [alsa-devel] DP MST audio support

2015-05-18 Thread Takashi Iwai
At Thu, 14 May 2015 09:10:33 +1000, Dave Airlie wrote: > > On 12 May 2015 at 13:27, Dave Airlie wrote: > > On 12 May 2015 at 11:50, Dave Airlie wrote: > >> Hi, > >> > >> So I have a branch that makes no sound, > >> http://cgit.freedesktop.org/~airlied/linux/log/?h=dp-mst-audio > >> > >> and I'm

Re: [Intel-gfx] [PATCH 0/5] sanitize hda/i915 interface using the component fw

2015-01-05 Thread Takashi Iwai
At Mon, 05 Jan 2015 17:29:34 +0200, Imre Deak wrote: > > Hi Mengdong, Takashi, > > On Tue, 2014-12-09 at 18:33 +0100, Takashi Iwai wrote: > > At Tue, 09 Dec 2014 18:56:07 +0200, > > Imre Deak wrote: > > > > > > On Tue, 2014-12-09 at 11:03 +0100, Daniel

Re: [Intel-gfx] [PATCH 0/5] sanitize hda/i915 interface using the component fw

2015-01-06 Thread Takashi Iwai
At Mon, 05 Jan 2015 19:25:09 +0200, Imre Deak wrote: > > On Mon, 2015-01-05 at 16:35 +0100, Takashi Iwai wrote: > > At Mon, 05 Jan 2015 17:29:34 +0200, > > Imre Deak wrote: > > > > > > Hi Mengdong, Takashi, > > > > > > On Tue, 2014-12-09

Re: [Intel-gfx] [PATCH 0/5] sanitize hda/i915 interface using the component fw

2015-01-08 Thread Takashi Iwai
At Wed, 07 Jan 2015 21:49:46 +0200, Imre Deak wrote: > > On Tue, 2015-01-06 at 11:25 +0100, Takashi Iwai wrote: > > At Mon, 05 Jan 2015 19:25:09 +0200, > > Imre Deak wrote: > > > > > > On Mon, 2015-01-05 at 16:35 +0100, Takashi Iwai wrote: > > > >

Re: [Intel-gfx] [PATCH v4 0/6] sanitize hda/i915 interface using the component fw

2015-01-09 Thread Takashi Iwai
At Fri, 9 Jan 2015 10:18:45 +0100, Daniel Vetter wrote: > > On Thu, Jan 08, 2015 at 05:54:12PM +0200, Imre Deak wrote: > > This is v4 of [1] addressing the review comments from Takashi and Jani. > > > > [1] > > http://lists.freedesktop.org/archives/intel-gfx/2014-December/056992.html > > > > Imr

<    1   2   3   4   5   6   7   >