jones)
CC: Samuel Ortiz
Cc: Linus Walleij
Cc: Alexandre Courbot
Cc: Thierry Reding
Signed-off-by: Shobhit Kumar
---
drivers/pwm/Kconfig | 7 +++
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-crc.c | 171 ++
3 files changed, 179 insertions
: Thierry Reding
Acked-by: Lee Jones
Signed-off-by: Shobhit Kumar
---
drivers/mfd/intel_soc_pmic_core.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/mfd/intel_soc_pmic_core.c
b/drivers/mfd/intel_soc_pmic_core.c
index f3d918e..a00ddd9 100644
--- a/drivers/mfd
On 04/29/2015 07:54 PM, Lee Jones wrote:
> On Wed, 29 Apr 2015, Shobhit Kumar wrote:
>
>> On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup
>> entry for the same to be used by the consumer (Intel GFX)
>>
>> v2: Remove the lookup table on dr
On Wed, May 6, 2015 at 1:10 PM, Paul Bolle wrote:
> On Tue, 2015-05-05 at 15:08 +0530, Shobhit Kumar wrote:
>> The Crystalcove PMIC controls PWM signals and this driver exports that
>> capability as a PWM chip driver. This is platform device implementtaion
>> of the driver
On Wed, May 6, 2015 at 5:44 PM, Thierry Reding wrote:
> On Tue, May 05, 2015 at 03:08:36PM +0530, Shobhit Kumar wrote:
>> The Crystalcove PMIC controls PWM signals and this driver exports that
>
> You say signal_s_ here, but you only expose a single PWM device. Does
> the PMIC r
On Thu, May 7, 2015 at 12:49 PM, Shobhit Kumar wrote:
> On Wed, May 6, 2015 at 5:44 PM, Thierry Reding
> wrote:
>> On Tue, May 05, 2015 at 03:08:36PM +0530, Shobhit Kumar wrote:
>>> The Crystalcove PMIC controls PWM signals and this driver exports that
>>
>> You
-
https://bugs.freedesktop.org/show_bug.cgi?id=85977
Requesting your comments to converge on best way of implementing this.
Regards
Shobhit
Shobhit Kumar (4):
drm/i915: Define a common data structure for Panel Info
drm/i915: Add a drm_panel over INTEL_SOC_PMIC
drm/i915/Kconfig: By default
This driver just add PANEL_ENABLE/DISABLE control using drm_panel
framework.
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/intel_drv.h| 3 +
drivers/gpu/drm/i915/intel_panel_pmic.c | 157
3 files
As of now this includes only PPS and BLC delays. New things can be added
as and when needed
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/intel_drv.h | 11 +++
drivers/gpu/drm/i915/intel_dsi.h | 7 +--
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 10
This will be needed for enabling drm_panel driver over pmic
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index 4e39ab3..3210dbb 100644
--- a/drivers/gpu/drm/i915
This initialize the drm_panel based on PMIC driver and uses drm_panel_*
for controlling the panel enable/disable states
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/intel_dsi.c | 20
drivers/gpu/drm/i915/intel_dsi.h | 6 ++
drivers/gpu/drm
This allows for proper PPS during enable/disable of BYT-T platforms
where these signals are routed through PMIC. Needs DRM_PANEL to be
selected by default as well
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/Kconfig | 1 +
drivers/gpu/drm/i915/intel_dsi.c | 16
This driver provides support for the "crystal_cove_panel" cell device.
On BYT-T pmic has to be used to enable/disable panel.
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/panel/Kconfig | 7 ++
drivers/gpu/drm/panel/Makefile| 1 +
drivers/gpu/drm/p
For scenarios where OF is not available, we can use panel identification by
name.
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/drm_panel.c | 18 ++
include/drm/drm_panel.h | 3 +++
2 files changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu
Shobhit Kumar (4):
drm: Add support to find drm_panel by name
mfd: Add a new cell device for panel controlled by crystal cove pmic
drm/panel: Add new panel driver based on crystal cove pmic
drm/i915: Enable DSI panel enable/disable based on PMIC
drivers/gpu/drm/drm_panel.c
On BYT-T configuration, panel enable/disable signals are routed through
PMIC. Add a cell device for the same.
Signed-off-by: Shobhit Kumar
---
drivers/mfd/intel_soc_pmic_crc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd
On BYT-T configuration, panel enable/disable signals are routed through
PMIC. Add a cell device for the same.
Signed-off-by: Shobhit Kumar
---
drivers/mfd/intel_soc_pmic_crc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd
control is pending. For now I am doing Backlight Enable/Disable also
during panel/enable as this will at least save power.
Regards
Shobhit
Shobhit Kumar (4):
drm: Add support to find drm_panel by name
mfd: Add a new cell device for panel controlled by crystal cove pmic
drm/i915: Add new panel
For scenarios where OF is not available, we can use panel identification by
name.
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/drm_panel.c | 18 ++
include/drm/drm_panel.h | 3 +++
2 files changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu
e not needed as of now
- Correct backlight off delay
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/Kconfig | 12 ++
drivers/gpu/drm/i915/Makefile | 3 +
drivers/gpu/drm/i915/intel-panel-crystalcove.c | 159 +
3 fil
This allows for proper PPS during enable/disable of BYT-T platforms
where these signals are routed through PMIC. Needs DRM_PANEL to be
selected by default as well
v2: Adapt to panel find function name change in drm_panel
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/Kconfig
10:58:51 2014 +0530
drm/i915: Dual link needs Shutdown and Turn on packet for both ports
to add more flexibility in using dpi_send_cmd() for just one port as
necessary. No functional changes.
Signed-off-by: Jani Nikula
Better this way.
Reviewed-By: Shobhit Kumar
---
drivers/gpu/drm
On 01/16/2015 05:57 PM, Jani Nikula wrote:
wait_for_dsi_fifo_empty can be static in intel_dsi.c. No functional
changes.
Signed-off-by: Jani Nikula
Reviewed-By: Shobhit Kumar
---
drivers/gpu/drm/i915/intel_dsi.c | 16
drivers/gpu/drm/i915/intel_dsi_cmd.c | 16
On 01/16/2015 05:57 PM, Jani Nikula wrote:
This seems like the right thing to do. This also gets rid of a call to
intel_dsi_pipe_to_port() which we want to remove eventually.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deleti
On 01/16/2015 05:57 PM, Jani Nikula wrote:
Add port parameter to wait_for_dsi_fifo_empty, and call it for each dsi
port.
We can now remove the transitional intel_dsi_pipe_to_port() function.
Signed-off-by: Jani Nikula
Reviewed-By: Shobhit Kumar
---
drivers/gpu/drm/i915/intel_dsi.c
the needed target
resolution. In case target resolution is same as native, nothing gets
changed, else mode_fixup function adjusts the mode accordingly keeping
timing as same and enabling scalar. Might not be useful in general, but
did find a use internally.
Either way
Reviewed-By: Shobhit
On 01/16/2015 05:57 PM, Jani Nikula wrote:
Const is good for you. No functional changes.
Signed-off-by: Jani Nikula
Reviewed-By: Shobhit Kumar
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers
On 01/16/2015 05:57 PM, Jani Nikula wrote:
This series ports our DSI code over to the drm_panel and
mipi_dsi_host/mipi_dsi_device. There are some rough edges towards the
end of the series, see commit message for patch 8 for details.
Patches 1-6 are prep work, fairly independent
While I continu
(intel_dsi, TURN_ON, DPI_LP_MODE_EN, port);
Reviewed-By: Shobhit Kumar
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 01/22/2015 06:58 PM, Jani Nikula wrote:
On Thu, 22 Jan 2015, Shobhit Kumar wrote:
On 01/16/2015 05:57 PM, Jani Nikula wrote:
This series ports our DSI code over to the drm_panel and
mipi_dsi_host/mipi_dsi_device. There are some rough edges towards the
end of the series, see commit message
On 01/22/2015 06:53 PM, Jani Nikula wrote:
On Thu, 22 Jan 2015, Shobhit Kumar wrote:
On 01/16/2015 05:57 PM, Jani Nikula wrote:
Remove all the trivial and/or dummy callbacks from intel dsi device
ops. Merge send_otp_cmds into panel_reset as they're called back to
back.
This will be he
On 01/16/2015 05:57 PM, Jani Nikula wrote:
Replace intel_dsi_device and intel_dsi_dev_ops with drm_panel and
drm_panel_funcs. They are adequate for what we have now, and if we end
up needing more than this we should improve drm_panel. This will keep us
better aligned with the drm core infrastruct
eviewed-By: Shobhit Kumar
---
drivers/gpu/drm/i915/Kconfig | 1 +
drivers/gpu/drm/i915/intel_dsi.c | 162 -
drivers/gpu/drm/i915/intel_dsi.h | 18
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 3 -
4 files changed, 180
OTP or enabling, so this patch won't get exercised. With that said-
Reviewed-By: Shobhit Kumar
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 52 +++---
1 file changed, 34 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt
On 01/16/2015 05:57 PM, Jani Nikula wrote:
All of these are replaced by the drm core mipi dsi functions.
Signed-off-by: Jani Nikula
Reviewed-By: Shobhit Kumar
---
drivers/gpu/drm/i915/intel_dsi_cmd.c | 259 ---
drivers/gpu/drm/i915/intel_dsi_cmd.h | 72
On 01/16/2015 05:57 PM, Jani Nikula wrote:
No functional changes.
Signed-off-by: Jani Nikula
Reviewed-By: Shobhit Kumar
---
drivers/gpu/drm/i915/intel_dsi.c | 39 ++--
drivers/gpu/drm/i915/intel_dsi_cmd.c | 34
On 01/16/2015 05:57 PM, Jani Nikula wrote:
The removed functions can be resurrected in intel_dsi.c as need arises.
Signed-off-by: Jani Nikula
Reviewed-By: Shobhit Kumar
---
drivers/gpu/drm/i915/Makefile | 1 -
drivers/gpu/drm/i915/intel_dsi.c | 1 -
drivers
On 01/23/2015 07:43 AM, Shobhit Kumar wrote:
On 01/22/2015 06:58 PM, Jani Nikula wrote:
On Thu, 22 Jan 2015, Shobhit Kumar wrote:
On 01/16/2015 05:57 PM, Jani Nikula wrote:
This series ports our DSI code over to the drm_panel and
mipi_dsi_host/mipi_dsi_device. There are some rough edges
On 01/23/2015 08:52 PM, Daniel Vetter wrote:
On Fri, Jan 23, 2015 at 03:14:41PM +0530, Shobhit Kumar wrote:
On 01/22/2015 06:53 PM, Jani Nikula wrote:
On Thu, 22 Jan 2015, Shobhit Kumar wrote:
There had been a instance where we had to drive different resolution
(lower) than the native one
On 01/23/2015 09:01 PM, Daniel Vetter wrote:
On Fri, Jan 23, 2015 at 04:27:46PM +0530, Shobhit Kumar wrote:
On 01/16/2015 05:57 PM, Jani Nikula wrote:
@@ -881,13 +889,23 @@ void intel_dsi_init(struct drm_device *dev)
drm_connector_register(connector);
- fixed_mode = dsi
On BYT-T configuration, panel enable/disable signals are routed through
PMIC. Add a cell device for the same.
Signed-off-by: Shobhit Kumar
---
drivers/mfd/intel_soc_pmic_crc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd
For scenarios where OF is not available, we can use panel identification by
name.
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/drm_panel.c | 18 ++
include/drm/drm_panel.h | 3 +++
2 files changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu
e not needed as of now
- Correct backlight off delay
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/Kconfig | 12 ++
drivers/gpu/drm/i915/Makefile | 3 +
drivers/gpu/drm/i915/intel-panel-crystalcove.c | 159 +
3 fil
control is pending. For now I am doing Backlight Enable/Disable also
during panel/enable as this will at least save power.
Regards
Shobhit
Shobhit Kumar (4):
drm: Add support to find drm_panel by name
mfd: Add a new cell device for panel controlled by crystal cove pmic
drm/i915: Add new panel
This allows for proper PPS during enable/disable of BYT-T platforms
where these signals are routed through PMIC. Needs DRM_PANEL to be
selected by default as well
v2: Adapt to panel find function name change in drm_panel
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/Kconfig
On 01/27/2015 06:43 PM, Chris Wilson wrote:
On Tue, Jan 27, 2015 at 02:09:21PM +0100, Daniel Vetter wrote:
On Tue, Jan 27, 2015 at 02:11:18PM +0530, Shobhit Kumar wrote:
On 01/23/2015 08:52 PM, Daniel Vetter wrote:
On Fri, Jan 23, 2015 at 03:14:41PM +0530, Shobhit Kumar wrote:
On 01/22/2015
-By: Shobhit Kumar
---
drivers/gpu/drm/i915/Kconfig | 1 +
drivers/gpu/drm/i915/intel_dsi.c | 68 +++
drivers/gpu/drm/i915/intel_dsi.h | 27 +
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 180 ++---
4 files changed,
On 01/27/2015 03:01 PM, Shobhit Kumar wrote:
> For scenarios where OF is not available, we can use panel identification by
> name.
Any body had a look at this ?
Regards
Shobhit
>
> Signed-off-by: Shobhit Kumar
> ---
> drivers/gpu/drm/drm_panel.c | 18 +++
This isuue got introduced in -
commit 24ee0e64909bf7f1953d87d3e1e29d93eafcad73
Author: Gaurav K Singh
Date: Fri Dec 5 14:24:21 2014 +0530
drm/i915: Update the DSI enable path to support dual
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/intel_dsi.c | 2 +-
1 file changed, 1
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/03/2015 06:35 PM, Thierry Reding wrote:
> On Wed, Jan 21, 2015 at 04:48:11PM +0530, Shobhit Kumar wrote:
>> On BYT-T configuration, panel enable/disable signals are routed
>> through PMIC. Add a cell device for the same.
>&
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/03/2015 06:46 PM, Thierry Reding wrote:
> On Wed, Jan 21, 2015 at 04:48:12PM +0530, Shobhit Kumar wrote:
>> This driver provides support for the "crystal_cove_panel" cell
>> device. On BYT-T pmic has to be used to enable
For scenarios where OF is not available, we can use panel identification by
name.
v2: Use const char *name instead of name[NAME_MAX] (Thierry)
CC: Thierry Reding
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/drm_panel.c | 18 ++
include/drm/drm_panel.h | 3 +++
2 files
base value from PORT_C and program for PORT_A. Mostly in case of dual
link all other bit values should be same, but logically we should read from
PORT_A. So hardcode to read initial value from PORT_A as well.
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/intel_dsi.c | 5 ++---
1 file
not getting programmed correctly with PCI_DEVFN(2, 0).
It turned out that this did not follow the recommendation and expected 0
in this field.
In general the recommendation is to use SB_DevFn as PCI_DEVFN(0, 0) for
all devices except target PCI devices.
Signed-off-by: Shobhit Kumar
---
drivers/gpu
On 02/06/2015 02:20 PM, Jani Nikula wrote:
> On Thu, 05 Feb 2015, Ville Syrjälä wrote:
>> On Thu, Feb 05, 2015 at 05:10:56PM +0530, Shobhit Kumar wrote:
>>> As per the specififcation, the SB_DevFn is the PCI_DEVFN of the target
>>> device and not the source. So PC
On 02/06/2015 01:11 AM, shuang...@intel.com wrote:
> Tested-By: PRC QA PRTS (Patch Regression Test System Contact:
> shuang...@intel.com)
> Task id: 5718
> -Summary-
> Platform Delta drm-intel-nightly
On 02/05/2015 10:44 PM, Ville Syrjälä wrote:
> On Thu, Feb 05, 2015 at 05:10:56PM +0530, Shobhit Kumar wrote:
>> As per the specififcation, the SB_DevFn is the PCI_DEVFN of the target
>> device and not the source. So PCI_DEVFN(2,0) is not correct. Further the
>> port I
framework for panel enable
and disbale and use PWM frameowrk for backlight control. These patches are only
for panel and backlight enable/disable signals as GPOI. PWM based backlight
control is WIP
Regards
Shobhit
Shobhit Kumar (2):
gpio/crystalcove: Export Panel and backlight en/disable signals
The CRC (Crystal Cove) PMIC, controls the panel enable and disable
signals for BYT for dsi panels. This is indicated in the VBT fields. Use
that to initialize and use GPIO based control for these signals.
Cc: Linus Walleij
Cc: Alexandre Courbot
Cc: Thierry Reding
Signed-off-by: Shobhit Kumar
Signed-off-by: Shobhit Kumar
---
drivers/gpio/gpio-crystalcove.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c
index 3d9e08f..9e94dc64 100644
--- a/drivers/gpio/gpio-crystalcove.c
+++ b/drivers/gpio/gpio
n 26, 2015 at 02:32:03PM +0530, Shobhit Kumar wrote:
>> > > Hi,
>> > > Next update of the series reviewed at
>> > > https://lkml.org/lkml/2015/6/22/155
>> > >
>> > > Major changes are few review comments from Varka and Ville being
>>
On Fri, Jul 10, 2015 at 6:36 PM, Shobhit Kumar wrote:
> On Mon, Jun 29, 2015 at 3:48 AM, Paul Gortmaker
> wrote:
>> [Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm
>> control] On 26/06/2015 (Fri 20:47) Ville Syrjälä wrote:
>>
>>> On Fri,
dbbb75bc50db11c367dd
Author: Shobhit Kumar
Date: Fri Jun 26 14:32:05 2015 +0530
mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
signal
On some Intel SoC platforms, the panel enable/disable signals
are controlled by CRC PMIC. Add those cont
On Wednesday 24 September 2014 02:31 PM, Daniel Vetter wrote:
On Wed, Sep 24, 2014 at 02:16:49PM +0530, Gaurav K Singh wrote:
Hi,
These set of patches build on top of the existing DSI Video mode support to
enable dual link MIPI panels with high resolutions. These patches have been
tested on a 25
On Wednesday 24 September 2014 03:02 PM, Jani Nikula wrote:
On Wed, 24 Sep 2014, Gaurav K Singh wrote:
Signed-off-by: Gaurav K Singh
Signed-off-by: Shobhit Kumar
---
drivers/gpu/drm/i915/intel_dsi_cmd.c | 35 ++
1 file changed, 23 insertions(+), 12
On Thursday 25 September 2014 07:09 PM, Jani Nikula wrote:
On Thu, 25 Sep 2014, Shobhit Kumar wrote:
On Wednesday 24 September 2014 03:02 PM, Jani Nikula wrote:
On Wed, 24 Sep 2014, Gaurav K Singh wrote:
+ do {
Please never use a do-while when a regular for loop will do.
Hmm, ok
201 - 266 of 266 matches
Mail list logo
