[Intel-gfx] [PATCH] drm/i915: Avoid divide by zero

2019-01-22 Thread Mika Kahola
Avoid divide by zero warning on static analysis. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_pm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 8b63afa3a221..6a8e8b3f44c2 100644

[Intel-gfx] [PATCH v6 04/10] drm: Helper to read max bits per component

2016-07-06 Thread Mika Kahola
Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 42

[Intel-gfx] [PATCH v6 01/10] drm: Add missing DP downstream port types

2016-07-06 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 4d85cf2..6e8b92e

[Intel-gfx] [PATCH v6 02/10] drm: Drop VGA from bpc definitions

2016-07-06 Thread Mika Kahola
Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/i

[Intel-gfx] [PATCH v6 09/10] drm/i915: Update bits per component for display info

2016-07-06 Thread Mika Kahola
DisplayPort branch device may define max supported bits per component. Update display info based on this value if bpc is defined. v2: cleanup to match the drm_dp_helper.c patches introduced earlier in this series Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 9

[Intel-gfx] [PATCH v6 05/10] drm: Read DP branch device id

2016-07-06 Thread Mika Kahola
Read DisplayPort branch device id string. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 95d624a

[Intel-gfx] [PATCH v6 07/10] drm: Read DP branch device SW revision

2016-07-06 Thread Mika Kahola
SW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x50A. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 21 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 23 insertions(+) diff --git a

[Intel-gfx] [PATCH v6 00/10] drm/i915: DP branch devices

2016-07-06 Thread Mika Kahola
pixel rate computation moved to drm (Daniel) v4: Use of drm_dp_helper routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) v6: Rebase and i915_debugfs cleanup Mika Kahola (10): drm: Add missing DP downstream port types drm: Drop VGA fro

[Intel-gfx] [PATCH v6 03/10] drm: Helper to read max clock rate

2016-07-06 Thread Mika Kahola
) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 091053e..0d4117c 100644 --- a

[Intel-gfx] [PATCH v6 08/10] drm/i915: Check pixel rate for DP to VGA dongle

2016-07-06 Thread Mika Kahola
lle) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index ffa43ec..76a654e 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/

[Intel-gfx] [PATCH v6 10/10] drm/i915: Add DP branch device info on debugfs

2016-07-06 Thread Mika Kahola
Read DisplayPort branch device info from through debugfs interface. v2: use drm_dp_helper routines to collect data v3: cleanup to match the drm_dp_helper.c patches introduced earlier in this series v4: move DP branch device info to function 'intel_dp_branch_device_info()' Signed-of

[Intel-gfx] [PATCH v6 06/10] drm: Read DP branch device HW revision

2016-07-06 Thread Mika Kahola
HW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x509. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 21 + include/drm/drm_dp_helper.h | 7 +++ 2 files changed, 28 insertions(+) diff --git a

Re: [Intel-gfx] [PATCH v6 06/10] drm: Read DP branch device HW revision

2016-08-02 Thread Mika Kahola
On Tue, 2016-07-12 at 15:54 +0200, Daniel Vetter wrote: > On Wed, Jul 06, 2016 at 02:04:50PM +0300, Mika Kahola wrote: > > HW revision is mandatory field for DisplayPort branch > > devices. This is defined in DPCD register field 0x509. > > > > Signed-off-by: Mika Kahol

Re: [Intel-gfx] [PATCH v6 08/10] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-02 Thread Mika Kahola
On Tue, 2016-07-12 at 15:50 +0200, Daniel Vetter wrote: > On Wed, Jul 06, 2016 at 02:04:52PM +0300, Mika Kahola wrote: > > Filter out a mode that exceeds the max pixel rate setting > > for DP to VGA dongle. This is defined in DPCD register 0x81 > > if detailed cap info i.e.

Re: [Intel-gfx] [PATCH v6 09/10] drm/i915: Update bits per component for display info

2016-08-02 Thread Mika Kahola
On Tue, 2016-07-12 at 15:51 +0200, Daniel Vetter wrote: > On Wed, Jul 06, 2016 at 02:04:53PM +0300, Mika Kahola wrote: > > DisplayPort branch device may define max supported bits per > > component. Update display info based on this value if bpc > > is defined. > > &

[Intel-gfx] [PATCH] drm/i915: Wait one vblank before sending hotplug event to userspace

2018-12-04 Thread Mika Kahola
a racy condition when retraining the DisplayPort link. My proposal is to wait for one additional vblank event before we send out a hotplug event to userspace for reprobing. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108835 Cc: Manasi Navare Signed-off-by: Mika Kahola --- drivers/g

[Intel-gfx] [PATCH] drm/i915/icl: Add missing device ID

2019-06-17 Thread Mika Kahola
We are missing PCI device ID for SKU ICLLP U GT 1.5F (0x8A54) as per BSPec. BSpec: 19092 Signed-off-by: Mika Kahola --- include/drm/i915_pciids.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 6d60ea68c171

[Intel-gfx] [PATCH] drm/i915/display: Implement Wa_14015648006

2022-05-04 Thread Mika Kahola
Add 4th pipe to extend TGL Wa_16013835468 to support DG2 platform. BSpec: 54077 Cc: Jouni Högander Cc: José Roberto de Souza Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_psr.c | 7 +-- drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 6 insertions

[Intel-gfx] [PATCH] drm/i915/display/dg2: Introduce CD clock squashing table

2021-11-17 Thread Mika Kahola
-squasher based table, Set .divider=2 for consistency, Pack intel_cdclk_vals a bit nicer] v5: Fix error in waveform value (Swati) v6 (Lucas): Rebase on upstream v7 (MattR): Drop 40.8, 81.6, and 122.4 MHz frequencies to reflect new bspec update. Signed-off-by: Mika Kahola

[Intel-gfx] [PATCH] drm/i915/display/dg2: Read CD clock from squasher table

2021-11-17 Thread Mika Kahola
clock frequency based on waveform bit pattern (Ville) [v4: vsyrjala: Actually do a proper blind readout from the hardware] [v5: vsyrjala: Use has_cdclk_squasher()] Signed-off-by: Mika Kahola Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 17 - 1 file

[Intel-gfx] [PATCH] drm/i915/display/dg2: Sanitize CD clock

2021-11-17 Thread Mika Kahola
Introduce has_cdclk_squasher()] Signed-off-by: Mika Kahola Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdc

[Intel-gfx] [PATCH] drm/i915/display/dg2: Set CD clock squashing registers

2021-11-17 Thread Mika Kahola
if-else structure (Ville) [v4: vsyrjala: Fix spaces vs. tabs] [v5: vsyrjala: Fix cd2x divider calculation (Uma), Add warn to waveform lookup (Uma), Handle bypass freq in waveform lookup, Generalize waveform handling in bxt_set_cdclk()] Signed-off-by: Mika

[Intel-gfx] [PATCH 0/4] drm/i915/display/dg2: Add CD clock squashing

2021-11-18 Thread Mika Kahola
Add support for CD clock squashing feature. Signed-off-by: Mika Kahola Signed-off-by: Ville Syrjälä Mika Kahola (4): drm/i915/display/dg2: Introduce CD clock squashing table drm/i915/display/dg2: Read CD clock from squasher table drm/i915/display/dg2: Sanitize CD clock drm/i915/display

[Intel-gfx] [PATCH 1/4] drm/i915/display/dg2: Introduce CD clock squashing table

2021-11-18 Thread Mika Kahola
-squasher based table, Set .divider=2 for consistency, Pack intel_cdclk_vals a bit nicer] v5: Fix error in waveform value (Swati) v6 (Lucas): Rebase on upstream v7 (MattR): Drop 40.8, 81.6, and 122.4 MHz frequencies to reflect new bspec update. Signed-off-by: Mika Kahola

[Intel-gfx] [PATCH 3/4] drm/i915/display/dg2: Sanitize CD clock

2021-11-18 Thread Mika Kahola
Introduce has_cdclk_squasher()] Signed-off-by: Mika Kahola Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdc

[Intel-gfx] [PATCH 4/4] drm/i915/display/dg2: Set CD clock squashing registers

2021-11-18 Thread Mika Kahola
if-else structure (Ville) [v4: vsyrjala: Fix spaces vs. tabs] [v5: vsyrjala: Fix cd2x divider calculation (Uma), Add warn to waveform lookup (Uma), Handle bypass freq in waveform lookup, Generalize waveform handling in bxt_set_cdclk()] Signed-off-by: Mika

[Intel-gfx] [PATCH 2/4] drm/i915/display/dg2: Read CD clock from squasher table

2021-11-18 Thread Mika Kahola
clock frequency based on waveform bit pattern (Ville) [v4: vsyrjala: Actually do a proper blind readout from the hardware] [v5: vsyrjala: Use has_cdclk_squasher()] Signed-off-by: Mika Kahola Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 17 - 1 file

[Intel-gfx] [PATCH v2 0/5] Add support for CD clock squashing feature.

2021-11-19 Thread Mika Kahola
Add support for CD clock squashing feature. v2: Reorder patches (Jani) Add Ville's "Allow cdclk squasher to be reconfigured live" to the series Signed-off-by: Mika Kahola Signed-off-by: Ville Syrjälä Mika Kahola (4): drm/i915/display/dg2: Introduce CD clock squash

[Intel-gfx] [PATCH v2 1/5] drm/i915/display/dg2: Introduce CD clock squashing table

2021-11-19 Thread Mika Kahola
-squasher based table, Set .divider=2 for consistency, Pack intel_cdclk_vals a bit nicer] v5: Fix error in waveform value (Swati) v6 (Lucas): Rebase on upstream v7 (MattR): Drop 40.8, 81.6, and 122.4 MHz frequencies to reflect new bspec update. Signed-off-by: Mika Kahola

[Intel-gfx] [PATCH v2 2/5] drm/i915/display/dg2: Sanitize CD clock

2021-11-19 Thread Mika Kahola
Introduce has_cdclk_squasher()] Signed-off-by: Mika Kahola Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdc

[Intel-gfx] [PATCH v2 3/5] drm/i915/display/dg2: Set CD clock squashing registers

2021-11-19 Thread Mika Kahola
if-else structure (Ville) [v4: vsyrjala: Fix spaces vs. tabs] [v5: vsyrjala: Fix cd2x divider calculation (Uma), Add warn to waveform lookup (Uma), Handle bypass freq in waveform lookup, Generalize waveform handling in bxt_set_cdclk()] Signed-off-by: Mika

[Intel-gfx] [PATCH v2 4/5] drm/i915/display/dg2: Read CD clock from squasher table

2021-11-19 Thread Mika Kahola
clock frequency based on waveform bit pattern (Ville) [v4: vsyrjala: Actually do a proper blind readout from the hardware] [v5: vsyrjala: Use has_cdclk_squasher()] Signed-off-by: Mika Kahola Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 17 - 1 file

[Intel-gfx] [PATCH v2 5/5] drm/i915: Allow cdclk squasher to be reconfigured live

2021-11-19 Thread Mika Kahola
From: Ville Syrjälä Supposedly we should be able to change the cdclk squasher waveform even when many pipes are active. Make it so. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 40 -- 1 file changed, 37 insertions(+), 3 deletions(-) diff --

[Intel-gfx] [PATCH] drm/i915/mtl: Extend PSR support

2022-09-07 Thread Mika Kahola
From: José Roberto de Souza Meteorlake and display 14 platform don't have any PSR differences when comparing to Alderlake-P display, so it was only necessary to extend some checks to properly program hardware. BSpec: 55229, 49196 Cc: Mika Kahola Signed-off-by: José Roberto de Souza S

[Intel-gfx] [PATCH] drm/i915/display: Read DP link status with DRM helper function

2019-12-13 Thread Mika Kahola
The patch proposes that we read DP link status with DRM helper function instead of intel specific one. Functionally there are no changes. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_dp.c | 13 + drivers/gpu/drm/i915/display/intel_dp.h

[Intel-gfx] [PATCH] drm/i915/tgl: Lower cdclk for sub 4k resolutions

2019-08-20 Thread Mika Kahola
In order to achieve improved power savings we can tune down CD clock frequency for sub 4k resolutions. The maximum CD clock frequency for sub 4k resolutions is set to 172.8 MHz. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_cdclk.c | 26 +- drivers/gpu

[Intel-gfx] [PATCH] drm/i915: Generalize definition for crtc mask

2017-12-05 Thread Mika Kahola
crtc_mask is defined explicitly defined for a certain number of pipes per platform. Let's generalize this in a way that crtc_mask dependens only on the number of pipes defined in device info. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_crt.c | 9 ++--- drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm/i915: Generalize definition for crtc mask

2017-12-05 Thread Mika Kahola
On Tue, 2017-12-05 at 15:59 +0200, Ville Syrjälä wrote: > On Tue, Dec 05, 2017 at 12:15:39PM +0200, Mika Kahola wrote: > > > > crtc_mask is defined explicitly defined for a certain number of > > pipes per > > platform. Let's generalize this in a way that crtc_ma

[Intel-gfx] [PATCH i-g-t] tools: Cannonlake port clock programming

2017-12-07 Thread Mika Kahola
, the reference with double precision and i915 implementation with fixed point precision. In case of a difference in computation the difference on dividers is printed out to the screen. Signed-off-by: Mika Kahola --- tools/Makefile.sources| 1 + tools/cnl_compute_wrpll.c

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Add CCS capability for sprites

2017-12-11 Thread Mika Kahola
t;= 9) { > - intel_plane->can_scale = true; > - state->scaler_id = -1; > - > - intel_plane->update_plane = skl_update_plane; > - intel_plane->disable_plane = skl_disable_plane; >   > - plane_formats = skl_plane_form

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Add CCS capability for sprites

2017-12-11 Thread Mika Kahola
On Mon, 2017-12-11 at 12:00 +, Daniel Stone wrote: > Hi Mika, > > On 11 December 2017 at 11:11, Mika Kahola > wrote: > > > > On Thu, 2017-08-24 at 22:10 +0300, ville.syrj...@linux.intel.com > > wrote: > > > > > > Allow sprites to scan

[Intel-gfx] [PATCH v2] drm/i915: Generalize definition for crtc mask

2017-12-13 Thread Mika Kahola
t DDI (Ville) Fix DP-MST crtc mask to be dependent only on pipe (Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_crt.c| 4 ++-- drivers/gpu/drm/i915/intel_ddi.c| 6 +- drivers/gpu/drm/i915/intel_dp.c | 6 +++--- drivers/gpu/drm/i915/intel_dp_mst.c | 2 +- dr

Re: [Intel-gfx] [PATCH i-g-t] test/kms_plane_lowres: Fix display_commit_mode() so it returns the crc

2017-12-13 Thread Mika Kahola
t CRC > v3: Don't do memory allocations, it's hard. (Maarten) > v4: Use igt_pipe_crc_collect_crc() instead, cleans up crc handling a > lot. > > Cc: Mika Kahola > Cc: Maarten Lankhorst With typo s/couses/causes/ fixed this is Reviewed-by: Mika Kahola > S

[Intel-gfx] [PATCH] drm/i915: Check for fused or unused pipes

2017-12-14 Thread Mika Kahola
In case of fused or unused pipes, return early with a warning when reading information for encoder. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103206 Reported-by: Thomas Gleixner Signed-off-by: Jani Nikula Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_audio.c | 2

Re: [Intel-gfx] [PATCH] drm/i915: Check for fused or unused pipes

2017-12-15 Thread Mika Kahola
On Fri, 2017-12-15 at 11:27 +0200, Jani Nikula wrote: > On Fri, 15 Dec 2017, Dhinakaran Pandiyan om> wrote: > > > > On Friday, December 15, 2017 9:59:02 AM PST Mika Kahola wrote: > > > > > > In case of fused or unused pipes, return early with a warning >

Re: [Intel-gfx] Warning in i915/intel_audio.c

2017-12-15 Thread Mika Kahola
c2 01 39 d1 7f e0 31 c0 c3 83 78 70 0b 74 f9 > 31  > c0 85 d2 74 cb eb f1 48 c7 c6 d0 c0 df 96 48 c7 c7 57 dd db 96 e8 9c > 2d  > bf ff <0f> ff 31 c0 c3 0f 1f 80 00 00 00 00 41 57 4d 89 c7 41 56 49 > 89 > [0.390679] ---[ end trace 9a14f34c58dc94ff ]--- > > &g

[Intel-gfx] [PATCH v2] drm/i915: Check for fused or unused pipes

2017-12-15 Thread Mika Kahola
p.org/show_bug.cgi?id=103206 Reported-by: Thomas Gleixner Signed-off-by: Jani Nikula Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index f1

Re: [Intel-gfx] Warning in i915/intel_audio.c

2017-12-15 Thread Mika Kahola
On Fri, 2017-12-15 at 19:20 +0530, Jaswinder Singh Rajput wrote: > On Fri, 2017-12-15 at 14:44 +0200, Mika Kahola wrote: > > > > Hi, > > > > This is a known issue. Could you try out this patch to see if that > > would fix this issue for you? > > >

[Intel-gfx] [PATCH v2] drm/i915: Check for fused or unused pipes

2017-12-18 Thread Mika Kahola
p.org/show_bug.cgi?id=103206 Reported-by: Thomas Gleixner Tested-by: Jaswinder Singh Rajput Suggested-by: Jani Nikula Reviewed-by: Jani Nikula Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH v2] drm/i915: Generalize definition for crtc mask

2017-12-19 Thread Mika Kahola
On Mon, 2017-12-18 at 16:05 -0800, Rodrigo Vivi wrote: > On Wed, Dec 13, 2017 at 09:25:16AM +0000, Mika Kahola wrote: > > > > crtc_mask is defined explicitly defined for a certain number of > > pipes per > > platform. Let's generalize this in a way that crtc_ma

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/kms_cursor_legacy: Perform lazy cleanup between tests

2017-12-22 Thread Mika Kahola
igt_pipe_crc_free(pipe_crc); >  } >   >  static void flip_vs_cursor_busy_crc(igt_display_t *display, bool > atomic) > @@ -1245,7 +1190,6 @@ static void > flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic) >   struct igt_fb fb_info[2], cursor_fb; >   unsigned

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Rework the 2x-*-vs-cursor-* tests.

2017-12-22 Thread Mika Kahola
e > time, fall back to queueing both in a single commit, in which case > we can say nothing about the vblank counter. > > There is a small race between flip_done and hw_done, so make > flip_nonblocking retry for a second when encountering -EBUSY. > Reviewed-by: M

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/kms_cursor_legacy: Perform lazy cleanup between tests

2017-12-22 Thread Mika Kahola
t harmful if it failed. > Reviewed-by: Mika Kahola > Signed-off-by: Maarten Lankhorst > --- >  tests/kms_cursor_legacy.c | 88 +++ > >  1 file changed, 12 insertions(+), 76 deletions(-) > > diff --git a/tests/kms_curso

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Add CCS capability for sprites

2017-12-27 Thread Mika Kahola
; on CNL. > > Cc: Ben Widawsky > Cc: Jason Ekstrand > Cc: Daniel Stone Reviewed-by: Mika Kahola > Signed-off-by: Ville Syrjälä > --- >  drivers/gpu/drm/i915/intel_display.c | 25 -- >  drivers/gpu/drm/i915/intel_drv.h |  2 ++ >  drivers/gpu/dr

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Remove the pipe/plane ID checks from skl_check_ccs_aux_surface()

2017-12-27 Thread Mika Kahola
KBL/BXT anyway. > > Cc: Ben Widawsky > Cc: Jason Ekstrand > Cc: Daniel Stone Reviewed-by: Mika Kahola > Signed-off-by: Ville Syrjälä > --- >  drivers/gpu/drm/i915/intel_display.c | 8 >  1 file changed, 8 deletions(-) > > diff --git a/drivers/

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Mika Kahola
state->base.rotation); >   > @@ -1105,6 +1114,12 @@ intel_check_sprite_plane(struct intel_plane > *plane, >   src->x2 = (src_x + src_w) << 16; >   src->y1 = src_y << 16; >   src->y2 = (s

[Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-18 Thread Mika Kahola
#x27;s move the intel_wait_for_vblank() as the last routine that we do in an iteration loop in intel_dp_sink_crc(). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103166 Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/

Re: [Intel-gfx] [PATCH v4 6/6] drm/i915: Add skl_check_nv12_surface for NV12

2018-04-18 Thread Mika Kahola
ltiplier of 4 > > v3: Moving all the src coords handling code for NV12 > to skl_check_nv12_surface The patch looks good to me. Reviewed-by: Mika Kahola > > Signed-off-by: Maarten Lankhorst > Signed-off-by: Vidya Srinivas > --- &g

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-19 Thread Mika Kahola
on't know if it was intentional. I'll try to find out why it was needed. > > > > > > -Original Message----- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On > > Behalf > > Of Mika Kahola > > Sent: Wednesday, April 18, 2018 10:57 AM > > To:

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-19 Thread Mika Kahola
On Thu, 2018-04-19 at 17:09 +0300, Jani Nikula wrote: > On Wed, 18 Apr 2018, Mika Kahola wrote: > > > > When reading out CRC's we  wait for a vblank on > > intel_dp_sink_crc_start() > > function. When we start reading out CRC's in intel_dp_sink_crc() &g

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-20 Thread Mika Kahola
On Fri, 2018-04-20 at 11:22 +0300, Jani Nikula wrote: > On Fri, 20 Apr 2018, Mika Kahola wrote: > > > > On Thu, 2018-04-19 at 17:09 +0300, Jani Nikula wrote: > > > > > > On Wed, 18 Apr 2018, Mika Kahola wrote: > > > > > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-24 Thread Mika Kahola
On Fri, 2018-04-20 at 13:56 -0700, Dhinakaran Pandiyan wrote: > On Fri, 2018-04-20 at 11:15 -0700, Rodrigo Vivi wrote: > > > > On Thu, Apr 19, 2018 at 10:03:05AM +0300, Mika Kahola wrote: > > > > > > On Thu, 2018-04-19 at 09:11 +0300, Lofstedt, Marta wrote: &g

Re: [Intel-gfx] [PATCH 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-24 Thread Mika Kahola
eturn ret; >  } >   > diff --git a/drivers/gpu/drm/i915/intel_drv.h > b/drivers/gpu/drm/i915/intel_drv.h > index 44ed248f1fe9..cacee94749e2 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -1644,8 +1644,7 @@ void intel_dp_sink_dpms(struct intel_dp > *intel_dp, int mode); >  void intel_dp_encoder_reset(struct drm_encoder *encoder); >  void intel_dp_encoder_suspend(struct intel_encoder *intel_encoder); >  void intel_dp_encoder_destroy(struct drm_encoder *encoder); > -int intel_dp_sink_crc(struct intel_dp *intel_dp, > -   struct intel_crtc_state *crtc_state, u8 *crc); > +int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc); >  bool intel_dp_compute_config(struct intel_encoder *encoder, >    struct intel_crtc_state *pipe_config, >    struct drm_connector_state > *conn_state); -- Mika Kahola - Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v7 1/5] drm: Read DP branch device HW revision

2016-08-08 Thread Mika Kahola
HW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x509. v2: move drm_dp_ds_revision structure to be part of drm_dp_link structure (Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 27

[Intel-gfx] [PATCH v7 0/5] drm/i915: DP branch devices

2016-08-08 Thread Mika Kahola
routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) v6: Rebase and i915_debugfs cleanup v7: Structure cleanups and initial step to move DP debugging info to drm_dp_helpers Mika Kahola (5): drm: Read DP branch device HW revision drm: Read DP

[Intel-gfx] [PATCH v7 2/5] drm: Read DP branch device SW revision

2016-08-08 Thread Mika Kahola
SW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x50A. v2: move drm_dp_ds_revision structure to be part of drm_dp_link structure (Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 27

[Intel-gfx] [PATCH v7 3/5] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-08 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c in

[Intel-gfx] [PATCH v7 5/5] drm: Add DP branch device info on debugfs

2016-08-08 Thread Mika Kahola
al step to move debugging info from intel_dp. to drm_dp_helper.c (Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 80 + drivers/gpu/drm/i915/i915_debugfs.c | 2 + include/drm/drm_dp_helper.h | 2 + 3 files changed, 84

[Intel-gfx] [PATCH v7 4/5] drm: Update bits per component for display info

2016-08-08 Thread Mika Kahola
ction (Daniel) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 24 drivers/gpu/drm/i915/intel_dp.c | 3 +++ include/drm/drm_dp_helper.h | 4 3 files changed, 31 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gp

[Intel-gfx] [PATCH] drm/i915: Cleanup DisplayPort AUX channel initialization

2016-08-10 Thread Mika Kahola
Let's remove reference to "struct intel_connector *connector" from intel_dp_aux_init() function as it is no longer required. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH v7 1/5] drm: Read DP branch device HW revision

2016-08-11 Thread Mika Kahola
On Thu, 2016-08-11 at 10:10 +0300, Ville Syrjälä wrote: > On Mon, Aug 08, 2016 at 04:00:26PM +0300, Mika Kahola wrote: > > HW revision is mandatory field for DisplayPort branch > > devices. This is defined in DPCD register field 0x509. > > But what do we want to do with

Re: [Intel-gfx] [PATCH v7 3/5] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-11 Thread Mika Kahola
On Thu, 2016-08-11 at 10:18 +0300, Ville Syrjälä wrote: > On Mon, Aug 08, 2016 at 04:00:28PM +0300, Mika Kahola wrote: > > Filter out a mode that exceeds the max pixel rate setting > > for DP to VGA dongle. This is defined in DPCD register 0x81 > > if detailed cap info i.e.

Re: [Intel-gfx] [PATCH v7 3/5] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-11 Thread Mika Kahola
On Thu, 2016-08-11 at 12:56 +0200, Daniel Vetter wrote: > On Thu, Aug 11, 2016 at 01:51:42PM +0300, Ville Syrjälä wrote: > > On Thu, Aug 11, 2016 at 12:43:39PM +0300, Mika Kahola wrote: > > > On Thu, 2016-08-11 at 10:18 +0300, Ville Syrjälä wrote: > > > > On Mon, Au

[Intel-gfx] [PATCH v8 01/12] drm: Add missing DP downstream port types

2016-08-17 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

[Intel-gfx] [PATCH v8 00/12] drm/i915: DP branch devices

2016-08-17 Thread Mika Kahola
routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) v6: Rebase and i915_debugfs cleanup v7: Structure cleanups and initial step to move DP debugging info to drm_dp_helpers v8: Cleanups and TMDS clock frequency check for HDMI adapter Mika Kahola

[Intel-gfx] [PATCH v8 02/12] drm: Drop VGA from bpc definitions

2016-08-17 Thread Mika Kahola
Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/i

[Intel-gfx] [PATCH v8 03/12] drm: Helper to read max clock rate

2016-08-17 Thread Mika Kahola
) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 031c4d3

[Intel-gfx] [PATCH v8 04/12] drm: Helper to read max bits per component

2016-08-17 Thread Mika Kahola
Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm

[Intel-gfx] [PATCH v8 05/12] drm: Read DP branch device id

2016-08-17 Thread Mika Kahola
Read DisplayPort branch device id string. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm

[Intel-gfx] [PATCH v8 07/12] drm/i915: Read DP branch device HW revision

2016-08-17 Thread Mika Kahola
(Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 21 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3dab3bf..9aebdf6 100644 --- a/drivers

[Intel-gfx] [PATCH v8 06/12] drm/i915: Cleanup DisplayPort AUX channel initialization

2016-08-17 Thread Mika Kahola
Let's remove reference to "struct intel_connector *connector" in intel_dp_aux_init() function as it is no longer required. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v8 09/12] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-17 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/driv

[Intel-gfx] [PATCH v8 09/12] Check pixel rate for DP to VGA dongle

2016-08-17 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/driv

[Intel-gfx] [PATCH v8 08/12] drm/i915: Read DP branch device SW revision

2016-08-17 Thread Mika Kahola
(Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 20 include/drm/drm_dp_helper.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 9aebdf6..91ffb79 100644 --- a/drivers

[Intel-gfx] [PATCH v8 11/12] drm: Add DP branch device info on debugfs

2016-08-17 Thread Mika Kahola
al step to move debugging info from intel_dp. to drm_dp_helper.c (Daniel) v6: read hw and sw revision without using specific drm_dp_helper routines Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 81 + drivers/gpu/drm/i915/i915_debu

[Intel-gfx] [PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

2016-08-17 Thread Mika Kahola
Respect max TMDS clock frequency from DPCD for active DP to HDMI adapters. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_drv.h | 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 27 +++ 2 files changed, 30 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v8 10/12] drm/i915: Update bits per component for display info

2016-08-17 Thread Mika Kahola
ction (Daniel) v4: remove updating bpc for display info as it may be overridden when parsing EDID. Instead, check bpc for DP branch device during compute_config Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 17 - 1 file changed, 16 insertions(+), 1 del

[Intel-gfx] [PATCH v8 06/12] drm/i915: Cleanup DisplayPort AUX channel initialization

2016-08-17 Thread Mika Kahola
Let's remove reference to "struct intel_connector *connector" in intel_dp_aux_init() function as it is no longer required. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v8 09/12] Check pixel rate for DP to VGA dongle

2016-08-17 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/driv

[Intel-gfx] [PATCH v8 04/12] drm: Helper to read max bits per component

2016-08-17 Thread Mika Kahola
Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm

[Intel-gfx] [PATCH v8 05/12] drm: Read DP branch device id

2016-08-17 Thread Mika Kahola
Read DisplayPort branch device id string. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm

[Intel-gfx] [PATCH v8 00/12] drm/i915: DP branch devices

2016-08-17 Thread Mika Kahola
routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) v6: Rebase and i915_debugfs cleanup v7: Structure cleanups and initial step to move DP debugging info to drm_dp_helpers v8: Cleanups and TMDS clock frequency check for HDMI adapter Mika Kahola

[Intel-gfx] [PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

2016-08-17 Thread Mika Kahola
Respect max TMDS clock frequency from DPCD for active DP to HDMI adapters. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_drv.h | 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 27 +++ 2 files changed, 30 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v8 03/12] drm: Helper to read max clock rate

2016-08-17 Thread Mika Kahola
) Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 031c4d3

[Intel-gfx] [PATCH v8 01/12] drm: Add missing DP downstream port types

2016-08-17 Thread Mika Kahola
Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

[Intel-gfx] [PATCH v8 08/12] drm/i915: Read DP branch device SW revision

2016-08-17 Thread Mika Kahola
(Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 20 include/drm/drm_dp_helper.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 9aebdf6..91ffb79 100644 --- a/drivers

[Intel-gfx] [PATCH v8 07/12] drm/i915: Read DP branch device HW revision

2016-08-17 Thread Mika Kahola
(Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 21 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3dab3bf..9aebdf6 100644 --- a/drivers

[Intel-gfx] [PATCH v8 02/12] drm: Drop VGA from bpc definitions

2016-08-17 Thread Mika Kahola
Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Reviewed-by: Jim Bride Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/i

[Intel-gfx] [PATCH v8 11/12] drm: Add DP branch device info on debugfs

2016-08-17 Thread Mika Kahola
al step to move debugging info from intel_dp. to drm_dp_helper.c (Daniel) v6: read hw and sw revision without using specific drm_dp_helper routines Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 81 + drivers/gpu/drm/i915/i915_debu

[Intel-gfx] [PATCH v8 09/12] drm/i915: Check pixel rate for DP to VGA dongle

2016-08-17 Thread Mika Kahola
lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/driv

  1   2   3   4   5   6   7   8   9   10   >