Hi,
On Mon, Jan 21, 2019 at 9:01 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> The code managing the dbuf slices is borked and needs some
> real work to fix. In the meantime let's just stop using the
> second slice.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_pm.
Hi,
On Mon, Jan 21, 2019 at 9:01 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> The code managing the dbuf slices is borked and needs some
> real work to fix. In the meantime let's just stop using the
> second slice.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_pm.c
Hi,
On Fri, Jan 25, 2019 at 8:38 PM Imre Deak wrote:
>
> On Tue, Jan 22, 2019 at 02:49:13PM +0530, Mahesh Kumar wrote:
> > Hi,
> >
> >
> > On Mon, Jan 21, 2019 at 9:01 PM Ville Syrjala
> > wrote:
> > >
> > > From: Ville Syrjälä
> > &
Hi,
On Fri, Jan 25, 2019 at 8:58 PM Ville Syrjälä
wrote:
>
> On Tue, Jan 22, 2019 at 02:58:46PM +0530, Mahesh Kumar wrote:
> > Hi,
> >
> > On Mon, Jan 21, 2019 at 9:01 PM Ville Syrjala
> > wrote:
> > >
> > > From: Ville Syrjälä
> > >
&g
LGTM...
Reviewed-by: Mahesh Kumar
On Wed, Jan 30, 2019 at 9:21 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> The code managing the dbuf slices is borked and needs some
> real work to fix. In the meantime let's just stop using the
> second slice.
>
Patches in this series were originally part of series:
https://patchwork.freedesktop.org/series/36993/
Reposting it here after rebase
use kernel types u8/u16 etc instead of uint8_t
Changes:
- Rebase the series
Mahesh Kumar (3):
drm/i915/icl: track dbuf slice-2 status
drm/i915/icl: Enable
This patch adds support to start tracking status of DBUF slices.
This is foundation to introduce support for enabling/disabling second
DBUF slice dynamically for ICL.
Changes Since V1:
- use kernel type u8 over uint8_t
Signed-off-by: Mahesh Kumar
Reviewed-by: James Ausmus
---
drivers/gpu/drm
e V3:
- Rebase
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_pm.c | 26 +++---
2 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
i
ges since V5:
- Rebase
Signed-off-by: Mahesh Kumar
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/intel_display.c| 10 +
drivers/gpu/drm/i915/intel_drv.h| 6 +++
drivers/gpu/drm/i915/intel_pm.c | 57 +++--
drivers/gpu/drm/i915/
ned-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index b85229e153c4..533e6886 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
earlier implementation of "DDB writing" was using this flag before
wait_for_vblank if we need to expand the DDB & it overlap with other
pipe's DDB.
In that case, I observed on corner case requiring a cd-clock change,
intel_update_watermarks was waiting for vblank, when it was called from
haswel
Hi,
In this series, I'm not equalizing watermarks among planes of all
CRTC's, these patches equalizing it only among Planes of single CRTC
from DDB pool allocated for that CRTC, which doesn't require wait_for_vblank
So it'll not affect the FPS.
On Wednesday 31 August 2016 07:08 PM, Maarten Lan
Hi,
On Wednesday 31 August 2016 07:17 PM, Zanoni, Paulo R wrote:
Em Ter, 2016-08-30 às 19:32 +, Zanoni, Paulo R escreveu:
Hi
Em Seg, 2016-08-29 às 18:05 +0530, Kumar, Mahesh escreveu:
This patch enables Transition WM for SKL+ platforms.
Transition WM are used if IPC is enabled, to decide
Hi Ander,
Thanks for review
On Wednesday 12 April 2017 02:47 PM, Ander Conselvan De Oliveira wrote:
On Tue, 2017-02-28 at 17:01 +0530, Mahesh Kumar wrote:
DDB minimum requirement may also exceed the allocated DDB for CRTC.
Instead of directly deducting from alloc_size, check against
fixed_16_16
variable and round_up the result to uint32_t.
These wrappers will be used by later patches in the series.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/i915_drv.h | 43 +
1 file changed, 43 insertions(+)
diff --git a/drivers/
el2 which requires 168 blocks
Mahesh Kumar (11):
drm/i915: fix naming of fixed_16_16 wrapper.
drm/i915: Add more wrapper for fixed_point_16_16 operations
drm/i915: Use fixed_16_16 wrapper for division operation
drm/i915/skl+: calculate pixel_rate & relative_data_rate in fixed
poin
Fail the flip if no FB is present but plane_state is set as visible.
Above is not a valid combination so instead of continue fail the flip.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915
nding-off the result
and give unt32_t output to cleanup mix use of fixed_16_16_t & uint32_t
variables.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/i915_drv.h | 6 ++
drivers/gpu/drm/i915/intel_pm.c | 6 +++---
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/driver
Don't use fixed_16_16 structure members directly, instead use wrapper to
perform fixed_16_16 division operation.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/driver
on function for timetime_us calculation (Paulo)
- rebase on drm-tip
Signed-off-by: "Mahesh Kumar"
---
drivers/gpu/drm/i915/i915_drv.h | 7 +++
drivers/gpu/drm/i915/intel_pm.c | 42 -
2 files changed, 40 insertions(+), 9 deletions(-)
dif
nges since v4:
- Rebase on drm-tip
- Added separate function to enable WM levels
Changes since v4:
- Fix a crash identified in skl-6770HQ system
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 253
1 file changed, 152 insertions(+), 101
e series.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 66b542ba47ad..6414701ef09e 100644
--- a/dri
levels in skl_compute_wm_level function instead
of "skl_build_pipe_wm" function.
This restructuring will help later patch for new DDB allocation
algorithm to do only algo related changes.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 89 +
= Pipe Ratio / Pipe down scale amount
}
Pipe maximum pixel rate = CDCLK frequency * Pipe Ratio
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_display.c | 3 ++
drivers/gpu/drm/i915/intel_drv.h | 2 +
drivers/gpu/drm/i915/intel_pm.c | 87
allocation bogus & may lead
to screen corruption or system hang.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 2a4e9d89
We are already doing memset of ddb structure at the begining of
skl_allocate_pipe_ddb
function, No need to again do a memset.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b
Hi,
On Monday 08 May 2017 05:18 PM, Lankhorst, Maarten wrote:
Mahesh Kumar schreef op ma 08-05-2017 om 17:18 [+0530]:
Fail the flip if no FB is present but plane_state is set as visible.
Above is not a valid combination so instead of continue fail the
flip.
Why is this patch necessary
alloc_size a negative value. Which
will make subsequent calculations for plane ddb allocation bogus & may
lead to screen corruption or system hang.
Changes from V1:
- Improve commit message as per Ander's comment
- Remove extra parentheses (Ander)
Signed-off-by: Mahesh Kumar
---
driver
alloc_size a negative value. Which
will make subsequent calculations for plane ddb allocation bogus & may
lead to screen corruption or system hang.
Changes from V1:
- Improve commit message as per Ander's comment
- Remove extra parentheses (Ander)
Signed-off-by: Mahesh Kumar
---
driver
Hi,
Thanks for review.
On Wednesday 10 May 2017 06:52 PM, Maarten Lankhorst wrote:
Op 08-05-17 om 13:49 schreef Mahesh Kumar:
A display resolution is only supported if it meets all the restrictions
below for Maximum Pipe Pixel Rate.
The display resolution must fit within the maximum pixel
stion
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_display.c | 3 ++
drivers/gpu/drm/i915/intel_drv.h | 2 +
drivers/gpu/drm/i915/intel_pm.c | 88
3 files changed, 93 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/dr
On Thursday 11 May 2017 03:18 PM, Maarten Lankhorst wrote:
Op 11-05-17 om 10:36 schreef Mahesh Kumar:
Hi,
Thanks for review.
On Wednesday 10 May 2017 06:52 PM, Maarten Lankhorst wrote:
Op 08-05-17 om 13:49 schreef Mahesh Kumar:
A display resolution is only supported if it meets all the
stion
Changes since V3:
- Change failure return from ERANGE to EINVAL
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_display.c | 3 ++
drivers/gpu/drm/i915/intel_drv.h | 2 +
drivers/gpu/drm/i915/intel_pm.c | 88
3 files changed, 93 inser
Hi Matt,
Thanks for review,
On Friday 12 May 2017 05:51 AM, Matt Roper wrote:
On Mon, May 08, 2017 at 05:18:51PM +0530, Mahesh Kumar wrote:
This series implements new DDB allocation algorithm to solve the cases,
where we have sufficient DDB available to enable multiple planes, But
due to the
Hi,
On Friday 12 May 2017 05:52 AM, Matt Roper wrote:
On Mon, May 08, 2017 at 05:18:53PM +0530, Mahesh Kumar wrote:
This patch adds few wrapper to perform fixed_point_16_16 operations
mul_u32_fixed_16_16_round_up : Multiplies u32 and fixed_16_16_t
variables
On Friday 12 May 2017 05:53 AM, Matt Roper wrote:
On Mon, May 08, 2017 at 05:18:58PM +0530, Mahesh Kumar wrote:
DDB minimum requirement may exceed the allocated DDB for CRTC/Pipe. This
patch make changes to fail the flip if minimum requirement for pipe
exceeds the total ddb allocated to the
Hi,
On Friday 12 May 2017 05:53 AM, Matt Roper wrote:
On Mon, May 08, 2017 at 05:18:59PM +0530, Mahesh Kumar wrote:
This patch cleanup/reorganises the watermark calculation functions.
This patch also make use of already available macro
"drm_atomic_crtc_state_for_each_plane_state&quo
Hi,
On Saturday 13 May 2017 03:54 AM, Matt Roper wrote:
On Mon, May 08, 2017 at 05:19:01PM +0530, Mahesh Kumar wrote:
This patch implements new DDB allocation algorithm as per HW team
recommendation. This algo takecare of scenario where we allocate less DDB
for the planes with lower relative
drm/i915/skl: New ddb allocation algorithm
drm/i915/skl+: consider max supported plane pixel rate while scaling
Mahesh Kumar (1):
drm/i915/skl+: Perform wm level calculations in separate function
drivers/gpu/drm/i915/i915_drv.h | 56 +++-
drivers/gpu/drm/i915/intel_display.c | 3 +
troduce the new wrapper to do rounding-off the result
and give unt32_t output to cleanup mix use of fixed_16_16_t & uint32_t
variables.
Signed-off-by: Mahesh Kumar
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/i915_drv.h | 6 ++
drivers/gpu/drm/i915/intel_pm.c | 6 +++---
2 files ch
.
These wrappers will be used by later patches in the series.
Changes from V1:
- Rename wrapper as per Matt's comment
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/i915_drv.h | 43 +
1 file changed, 43 insertions(+)
diff --git a/driver
From: "Kumar, Mahesh"
Fail the flip if no FB is present but plane_state is set as visible.
Above is not a valid combination so instead of continue fail the flip.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
From: "Kumar, Mahesh"
We are already doing memset of ddb structure at the begining of
skl_allocate_pipe_ddb
function, No need to again do a memset.
Signed-off-by: Mahesh Kumar
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/intel_pm.c | 4 +---
1 file changed, 1 insertion(+), 3
From: "Kumar, Mahesh"
Don't use fixed_16_16 structure members directly, instead use wrapper to
perform fixed_16_16 division operation.
Signed-off-by: Mahesh Kumar
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
_16_t variables in
later patch in the series.
Changes from V1:
- Rebase based on wrapper name change
- Remove unnecessary comment
Signed-off-by: Mahesh Kumar
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/intel_pm.c | 38 +++---
1 file changed, 19 insertion
viously it succeeded but making alloc_size a negative value. Which
will make subsequent calculations for plane ddb allocation bogus & may
lead to screen corruption or system hang.
Changes from V1:
- Improve commit message as per Ander's comment
- Remove extra parentheses (Ander)
Si
s restructuring will help later patch for new DDB allocation
algorithm to do only algo related changes.
Changes from V1:
- split the patch in two parts as per Matt's comment
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 53 +++--
1 fi
in later patch in series.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 48 -
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index c24a4e1bcb8b..0f1d9f672e8
omments
- Few other ULT fixes
Changes since v4:
- Rebase on drm-tip
- Added separate function to enable WM levels
Changes since v5:
- Fix a crash identified in skl-6770HQ system
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 253
Maarten)
Changes since v3:
- Use common function for timetime_us calculation (Paulo)
- rebase on drm-tip
Changes since v4:
- Use consistent name for fixed_point operation
Signed-off-by: "Mahesh Kumar"
---
drivers/gpu/drm/i915/i915_drv.h | 7 +++
d
per as per Maarten's suggestion
Changes since V3:
- Change failure return from ERANGE to EINVAL
Changes since V3:
- Rebase based on previous patch changes
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_display.c | 3 ++
drivers/gpu/drm/i915/intel_drv.h | 2 +
drive
From: Vandita Kulkarni
Use intel_port_is_tc and intel_port_is_combophy
functions to replace the individual port checks
from port C to F and port A to B respectively.
Signed-off-by: Vandita Kulkarni
Signed-off-by: Mahesh Kumar
Cc: Lucas De Marchi
Cc: Madhav Chauhan
---
drivers/gpu/drm/i915
From: Vandita Kulkarni
This patch adds helper function for identifying
whether the given PLL is combo PHY PLL or not.
This helper function is used inside various ICL
functions to make them scalable.
Signed-off-by: Vandita Kulkarni
Signed-off-by: Mahesh Kumar
Cc: Madhav Chauhan
Cc: Lucas De
This series refactor code and register definitions for combophy
port registers. And also creates helper functions to identify
combophy/tc ports.
Lucas De Marchi (1):
drm/i915/icl: Introduce new macros to get combophy registers
Mahesh Kumar (4):
drm/i915/icl: create function to identify
From: Vandita Kulkarni
Use the existing port-to-id helper function, to refactor
hence making it scalable.
Signed-off-by: Vandita Kulkarni
Signed-off-by: Mahesh Kumar
Cc: Lucas De Marchi
Cc: Madhav Chauhan
---
drivers/gpu/drm/i915/intel_display.c | 8 +---
drivers/gpu/drm/i915
Instead of directly comparing HPD pins use intel_port_is_combophy/tc
helper functions to distinguish between combophy/TC ports.
Signed-off-by: Mahesh Kumar
Cc: Manasi Navare
---
drivers/gpu/drm/i915/intel_dp.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a
DDI/TC clock-off bits are not equally distanced. TC1-3 bits are
from offset 12 & TC4 is at offset 21.
Create a function to choose correct clk-off bit.
Signed-off-by: Mahesh Kumar
Signed-off-by: Vandita Kulkarni
Cc: Lucas De Marchi
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu
This patch creates a function/wrapper to check if port is combophy port
instead of explicitly comparing ports.
Signed-off-by: Mahesh Kumar
Cc: Madhav Chauhan
Cc: Manasi Navare
---
drivers/gpu/drm/i915/intel_ddi.c | 15 ---
drivers/gpu/drm/i915/intel_display.c | 11
This patch combines CNL/ICL specific port/combophy macros together
at one location. This is prework for patches later in series where
new macros to find port/combophy register will be introduced.
Signed-off-by: Mahesh Kumar
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/i915_reg.h
And inside each PORT_TX_[AUX|GRP|LN] we add `dw * 4`.
Based on original patch by Mahesh Kumar .
Signed-off-by: Lucas De Marchi
Signed-off-by: Mahesh Kumar
Cc: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_reg.h | 154 ++--
1 file changed, 54 insertions(+), 100
This patch creates a function/wrapper to check if port is combophy port
instead of explicitly comparing ports.
Changes since V1:
- keep all intel_port_is_* helper together (Lucas)
Signed-off-by: Mahesh Kumar
Cc: Madhav Chauhan
Cc: Manasi Navare
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm
tion on that platforms, hence valid_dimm was
> always false and thus we always tried to apply the w/a.
> Furthermore the w/a pushed the level 0 latency above the
> level 1 latency, which doesn't really make sense.
>
> Cc: Mahesh Kumar
> Cc: Maarten Lankhorst
> Fixes: 86b5
On Thu, Oct 11, 2018 at 2:19 AM Mahesh Kumar wrote:
>
> Hi,
>
> On Wed, Oct 10, 2018 at 11:25 PM Ville Syrjala
> wrote:
> >
> > From: Ville Syrjälä
> >
> > The 16Gb DIMM w/a is not applicable to BXT or GLK. Limit it to
> > the appropriate platfo
LGTM..
Reviewed-by: Mahesh Kumar
-Mahesh
On Tue, Oct 23, 2018 at 11:52 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> The 16Gb DIMM w/a is not applicable to BXT or GLK. Limit it to
> the appropriate platforms.
>
> This was especially harsh on GLK since we don't e
tant pointer to an array of
source list and crc-core does the verification
Cc: dri-de...@lists.freedesktop.org
Mahesh Kumar (10):
drm: crc: Introduce verify_crc_source callback
drm: crc: Introduce pre_crc_read function
drm: crc: Introduce get_crc_sources callback
drm/rockchip/crc: Implement
This patch adds a new callback function "verify_crc_source" which will
be used during setting the crc source in control node and while opening
data node for crc reading. This will help in avoiding setting of wrong
string for source.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freed
This patch implements a callback function "pre_crc_read" which will
be called before crc read. In this function driver can implement and
preparation work required for successfully reading CRC data.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drive
This patch implements verify_crc_source callback function introduced
earlier in this series.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915/intel_drv.h | 3 +
drivers/gpu/drm/i915/intel_pipe_crc.c
This patch implements get_crc_sources callback, which returns list of
all the valid crc sources supported by driver in current platform.
Changes since V1:
- Return array of crc sources
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/i915/intel_display.c
This patch implements "verify_crc_source" callback function for
AMD drm driver.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4
drivers/g
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680.
Don't wait for first CRC during crtc_crc_open. It avoids one frame wait
during open. If application want to wait after read call, it can use
poll/read blocking read() call.
Suggested-by: Ville Syrjälä
Signed-off-by: Mahesh Kuma
.
Changes Since V1: (Daniel)
- return const pointer to an array of crc sources list
- do validation of sources in CRC-core
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/drm_debugfs_crc.c | 20 +++-
include/drm/drm_crtc.h
This patch implements "verify_crc_source" callback function for
rcar drm driver.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 40 ++
1 file changed, 40 insertions(+)
diff --git a/drive
This patch implements "verify_crc_source" callback function for
rockchip drm driver.
Changes since V1:
- simplify the verification (Jani N)
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 20
1 fi
.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 4 +-
drivers/gpu/drm/drm_debugfs_crc.c | 52 +-
drivers/gpu/drm/i915
cient and WM level-0 was getting
disabled, resulting in blank screen. Now we use old DDB allocation logic
only for cursor plane.
Changes:
- add reason for revert in commit msg (Maarten)
- Fix checkpatch checks
Testcase: igt/kms_plane_multiple
Signed-off-by: Mahesh Kumar
Cc: Rodrigo
.
Changes Since V1: (Daniel)
- return const pointer to an array of crc sources list
- do validation of sources in CRC-core
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/drm_debugfs_crc.c | 20 +++-
include/drm/
This patch implements verify_crc_source callback function introduced
earlier in this series.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915/intel_drv.h | 3 +
drivers
This patch adds a new callback function "verify_crc_source" which will
be used during setting the crc source in control node and while opening
data node for crc reading. This will help in avoiding setting of wrong
string for source.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freed
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680.
Don't wait for first CRC during crtc_crc_open. It avoids one frame wait
during open. If application want to wait after read call, it can use
poll/read blocking read() call.
Suggested-by: Ville Syrjälä
Signed-off-by: Mahesh Kuma
This patch implements "verify_crc_source" callback function for
rcar drm driver.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 40 ++
1 file changed, 40
.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 4 +-
drivers/gpu/drm/drm_debugfs_crc.c | 52
This patch implements a callback function "pre_crc_read" which will
be called before crc read. In this function driver can implement and
preparation work required for successfully reading CRC data.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
---
drive
tant pointer to an array of
source list and crc-core does the verification
Changes rev3:
- reorg patches to push non r-b patches to the last
- add r-b tag
Cc: dri-de...@lists.freedesktop.org
Mahesh Kumar (10):
drm: crc: Introduce verify_crc_source callback
drm: crc: Introduce get_crc_sources
This patch implements "verify_crc_source" callback function for
rockchip drm driver.
Changes since V1:
- simplify the verification (Jani N)
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/rockchip/rockchip_drm_
This patch implements "verify_crc_source" callback function for
AMD drm driver.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
drivers/gpu/drm/amd/display/amdgpu_dm/a
This patch implements get_crc_sources callback, which returns list of
all the valid crc sources supported by driver in current platform.
Changes since V1:
- Return array of crc sources
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst
---
drivers
Now crc-core framework verifies the source string passed by the user.
So setting bad-source will fail. Expect file write to fail in bad-source
subtest of kms_pipe_crc_basic.
Signed-off-by: Mahesh Kumar
---
tests/kms_pipe_crc_basic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
ng-crc-pipe-X
ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence
In nonblocking crc tests we'll get lesser crc's due to skipping crc
AMD/Rockchip/rcar code path is not validated and need inputs
Mahesh Kumar (10):
drm: crc: Introduce verify_crc_source callback
drm: crc: Introdu
This patch implements "verify_crc_source" callback function for
rockchip drm driver.
Changes since V1:
- simplify the verification (Jani N)
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst
Acked-by: Heiko Stuebner
---
drivers/gpu/dr
This patch adds a new callback function "verify_crc_source" which will
be used during setting the crc source in control node. This will help
in avoiding setting of wrong string for source.
Changes since V1:
- do not yet verify_crc_source during open.
Signed-off-by: Mahesh Kumar
the number of source in the list.
Changes Since V1: (Daniel)
- return const pointer to an array of crc sources list
- do validation of sources in CRC-core
Changes Since V2:
- update commit message
- update callback documentation
- print one source name per line
Signed-off-by: Mahesh Kumar
This patch implements "verify_crc_source" callback function for
rcar drm driver.
Changes Since V1:
- avoid duplication of code
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Cc: Laurent Pinchart
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/rcar-du/rcar_du_c
This patch implements "verify_crc_source" callback function for
AMD drm driver.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst
Acked-by: Leo Li
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
drivers/gpu/drm/a
This patch implements get_crc_sources callback, which returns list of
all the valid crc sources supported by driver in current platform.
Changes since V1:
- Return array of crc sources
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst
---
drivers
This patch implements verify_crc_source callback function introduced
earlier in this series.
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915/intel_drv.h | 3 +
drivers
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680.
Don't wait for first CRC during crtc_crc_open. It avoids one frame wait
during open. If application want to wait after read call, it can use
poll/read blocking read() call.
Suggested-by: Ville Syrjälä
Signed-off-by: Mahesh Kuma
.
Changes since V1:
- refactor code to use single spin lock
Signed-off-by: Mahesh Kumar
Cc: dri-de...@lists.freedesktop.org
Cc: Laurent Pinchart
Reviewed-by: Maarten Lankhorst
Acked-by: Leo Li
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +-
.../gpu/drm/amd/display/amdgpu_dm
This patch implements get_crc_sources callback, which returns list of
all the crc sources supported by driver in current platform.
Signed-off-by: Mahesh Kumar
Cc: Laurent Pinchart
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 11 ++
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +
drivers/gpu
ng-crc-pipe-X
ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence
In nonblocking crc tests we'll get lesser crc's due to skipping crc
AMD/Rockchip/rcar code path is not validated and need inputs
Cc: dri-de...@lists.freedesktop.org
Mahesh Kumar (10):
drm: crc: Introduce verify_crc
1 - 100 of 439 matches
Mail list logo
