Instead of directly comparing HPD pins use intel_port_is_combophy/tc
helper functions to distinguish between combophy/TC ports.

Signed-off-by: Mahesh Kumar <mahesh1.ku...@intel.com>
Cc: Manasi Navare <manasi.d.nav...@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 15a981ef5966..f6b9be81ea18 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4965,19 +4965,14 @@ static bool icl_digital_port_connected(struct 
intel_encoder *encoder)
        struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
        struct intel_digital_port *dig_port = enc_to_dig_port(&encoder->base);
 
-       switch (encoder->hpd_pin) {
-       case HPD_PORT_A:
-       case HPD_PORT_B:
+       if (intel_port_is_combophy(dev_priv, encoder->port))
                return icl_combo_port_connected(dev_priv, dig_port);
-       case HPD_PORT_C:
-       case HPD_PORT_D:
-       case HPD_PORT_E:
-       case HPD_PORT_F:
+       else if (intel_port_is_tc(dev_priv, encoder->port))
                return icl_tc_port_connected(dev_priv, dig_port);
-       default:
+       else
                MISSING_CASE(encoder->hpd_pin);
-               return false;
-       }
+
+       return false;
 }
 
 /*
-- 
2.16.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to