Why is this useful if only root can use it?
Kristian
On Wed, Jul 20, 2016 at 12:39 PM, Chris Wilson wrote:
> When performing driver testing, one factor we want to test is how we
> handle a foreign fence that is never signaled. We can wait on that fence
> indefinitely, in which case the driver ap
On Thu, Feb 27, 2020 at 7:38 PM Dave Airlie wrote:
>
> On Fri, 28 Feb 2020 at 07:27, Daniel Vetter wrote:
> >
> > Hi all,
> >
> > You might have read the short take in the X.org board meeting minutes
> > already, here's the long version.
> >
> > The good news: gitlab.fd.o has become very popular
nd easy to read as suggested.
> v13: Adding reviewed by tag from Shashank Sharma
> Addressed review comments from Juha-Pekka Heikkila
> "NV12 not to be supported by SKL"
> v14: Addressed review comments from Ville
> Added skl_planar_formats to include NV12
> and a check skl_p
_plane_has_planar function to check for
> NV12 support on plane. Added NV12 format to
> skl_mod_supported. These were review comments
> from Kristian Høgsberg
> v14: Added reviewed by from Juha-Pekka Heikkila
> v15: Rebased the series
> v16: Added all tiling support under mod supported
> for N
On Thu, Apr 19, 2018 at 3:34 AM Vidya Srinivas
wrote:
> Enabling NV12 support:
> - Framebuffer creation
> - Primary and Sprite plane support
> Patch series depend on Enable display workaround 827 patch
> mentioned below submitted by Maarten
How are we looking on being able to land these last NV1
On Wed, May 30, 2018 at 10:00 AM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> intel_plane funcs can be cosnt. Make it so.
s/cosnt/const
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dr
Self-relocs don't make any sense for softpinned objects and can
>> indicate a programming errors, thus are forbidden. Softpinned objects
>> are marked by asterisk in debug dumps.
>>
>> Cc: Thomas Daniel
>> Cc: Kristian Høgsberg
>> Cc: Zou Nanhai
>> Cc:
ce and eliminates the need of relocations. It can also be used to
>> > > >> mirror addresses between GPU and CPU (shared virtual memory).
>> > > >> Calls to drm_intel_bo_emit_reloc are still required to build the list
>> > > >> of
>> >
ects at exec time, but no entries in relocs are
>> >> created. Self-relocs don't make any sense for softpinned objects and can
>> >> indicate a programming errors, thus are forbidden. Softpinned objects
>> >> are marked by asterisk in debug dumps.
Kristian Høgsberg writes:
> "Song, Ruiling" writes:
>
>>> -Original Message-
>>> From: hoegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of
>>> Kristian H?gsberg
>>> Sent: Monday, December 14, 2015 1:34 PM
>>>
d be a driver bug, and not trigger-able by userspace. On this note, the
> function name could probably benefit from a change, but whatever.
>
> NOTE: I manually retyped this from a test machine. So I haven't even compiled
> this exact patch.
>
> Cc: Chris Wilson
> Cc: Kris
On Tue, Oct 13, 2015 at 6:22 AM, Chris Wilson wrote:
> Pinning a userptr onto the hardware raises interesting questions about
> the lifetime of such a surface as the framebuffer extends that life
> beyond the client's address space. That is the hardware will need to
> keep scanning out from the ba
On Fri, Oct 23, 2015 at 2:28 AM, Chris Wilson wrote:
> On Fri, Oct 23, 2015 at 10:04:24AM +0200, Daniel Vetter wrote:
>> On Thu, Oct 22, 2015 at 04:23:09PM -0700, Kristian Høgsberg wrote:
>> > On Tue, Oct 13, 2015 at 6:22 AM, Chris Wilson
>> > wrote:
>> > &
On Tue, Oct 6, 2015 at 3:53 AM, Chris Wilson wrote:
> Userspace can pass in an offset that it presumes the object is located
> at. The kernel will then do its utmost to fit the object into that
> location. The assumption is that userspace is handling its own object
> locations (for example along w
On Thu, Nov 5, 2015 at 4:56 PM, Ben Widawsky
wrote:
> This prevents the simulator from barfing when it sees commands from another
> ring. I've been using this locally for a very long time.
Yea, that looks good, thanks Ben.
Reviewed-by: Kristian Høgsberg
> Cc: Kristian Høgsberg
On Fri, Nov 6, 2015 at 5:38 AM, Chris Wilson wrote:
> On Thu, Nov 05, 2015 at 10:17:56AM -0800, Jesse Barnes wrote:
>> On 11/05/2015 09:51 AM, Kristian Høgsberg wrote:
>> > On Tue, Oct 6, 2015 at 3:53 AM, Chris Wilson
>> > wrote:
>> >> Userspace can pass i
hout the redundant 'const' it gets:
>
> Reviewed-by: Dave Gordon
>
Fixes the crash I was seeing with relocs in a userptr bo.
Reviewed-by: Kristian Høgsberg
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, Aug 28, 2017 at 3:17 PM, Daniel Vetter wrote:
> On Mon, Aug 28, 2017 at 04:22:16PM +0530, Vidya Srinivas wrote:
>> This patch series is adding NV12 support for Broxton display after
>> rebasing on latest drm-intel-nightly. Initial series of the patches
>> can be found here:
>> https://list
On Fri, Sep 1, 2017 at 6:46 AM, Ville Syrjälä
wrote:
> On Thu, Aug 31, 2017 at 05:05:01PM -0700, Rodrigo Vivi wrote:
>> Hi Ville,
>>
>> On Wed, Aug 30, 2017 at 10:09 AM, Ville Syrjälä
>> wrote:
>> > On Wed, Aug 30, 2017 at 11:31:16AM +0300, Jani Nikula wrote:
>> >> On Mon, 28 Aug 2017, Ville Syrj
On Tue, Feb 13, 2018 at 8:59 PM Vidya Srinivas
wrote:
> This patch series is adding NV12 support for Broxton display after
rebasing on
> latest drm-tip.
> Initial series of the patches can be found here:
> https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.html
I still don't see su
On Wed, Sep 6, 2017 at 1:17 PM, Matt Roper wrote:
> On Wed, Sep 06, 2017 at 12:12:10PM -0700, Rodrigo Vivi wrote:
>> On Wed, Sep 06, 2017 at 09:36:27AM -0700, Matt Roper wrote:
>> > On Mon, Aug 28, 2017 at 04:22:20PM +0530, Vidya Srinivas wrote:
>> > > From: Chandra Konduru
>> > >
>> > > This pat
On Wed, Sep 6, 2017 at 3:02 PM, Matt Roper wrote:
> On Wed, Sep 06, 2017 at 02:49:07PM -0700, Kristian Høgsberg wrote:
>> On Wed, Sep 6, 2017 at 1:17 PM, Matt Roper wrote:
>> > On Wed, Sep 06, 2017 at 12:12:10PM -0700, Rodrigo Vivi wrote:
>> >> On Wed, Sep 06,
On Thu, Feb 1, 2018 at 9:53 AM Chris Wilson
wrote:
> Quoting Andy Lutomirski (2018-02-01 17:40:22)
> > *However*, I do see one unfortunate side effect of turning on PSR. It
> > seems that, when I move my cursor a little bit after a few seconds of
> > doing nothing, there seems to be a little bit
On Fri, Nov 22, 2013 at 05:17:37PM +0100, Daniel Vetter wrote:
> On Fri, Nov 22, 2013 at 12:01 PM, Keith Packard wrote:
> > Daniel Vetter writes:
> >
> >> Hm, where do we have the canonical source for all these fourcc codes? I'm
> >> asking since we have our own copy in the kernel as drm_fourcc.h
On Mon, Feb 18, 2013 at 10:03 AM, Daniel Vetter wrote:
> On Fri, Feb 15, 2013 at 01:23:08PM -0800, Jesse Barnes wrote:
>> A few more fixes from Daniel.
>
> So one thing that crossed my mind which we should at least quickly
> discuss: How is userspace supposed to notice the resume? On a lot of
> de
On Fri, Oct 5, 2012 at 9:36 AM, Imre Deak wrote:
> Needed by the upcoming DRM raw monotonic timestamp support.
I just had a quick look at driver/input/evdev.c, since evdev devices
did a similar change recently to allow evdev timestamp from the
monotonic clock. They're using a different time API:
On Fri, Nov 2, 2012 at 9:29 AM, Chris Wilson wrote:
> On Thu, 1 Nov 2012 20:06:03 +0200, ville.syrj...@linux.intel.com wrote:
>> From: Ville Syrjälä
>>
>> As per Chris Wilson's suggestion make
>> i915_gem_execbuffer_wait_for_flips() go away.
>>
>> This was used to stall the GPU ring while there
2010/7/5 Maxim Levitsky :
> On Mon, 2010-07-05 at 13:08 +0300, Maxim Levitsky wrote:
>> 2010/7/5 Michel Dänzer :
>> > On Don, 2010-07-01 at 10:32 -0700, Ian Romanick wrote:
>> >> -BEGIN PGP SIGNED MESSAGE-
>> >> Hash: SHA1
>> >>
>> >> Note: I'm sending this reply to mesa-...@lists.freedeskt
On Wed, Jul 28, 2010 at 4:42 AM, Chris Wilson wrote:
> On Tue, 27 Jul 2010 09:34:01 -0700, Jesse Barnes
> wrote:
>> and glproto is missing a dep on GL:
>>
>> In file included from i810.h:60:0,
>> from i810_accel.c:41:
>> /usr/include/GL/glxint.h:36:19: fatal error: GL/gl.h: N
https://bugs.freedesktop.org/show_bug.cgi?id=28438
Signed-off-by: Kristian Høgsberg
---
src/intel_driver.c | 33 -
1 files changed, 24 insertions(+), 9 deletions(-)
diff --git a/src/intel_driver.c b/src/intel_driver.c
index 7761ccf..d09c432 100644
--- a/src/intel_driver.c
+++
On Fri, Jul 30, 2010 at 2:29 AM, Chris Wilson wrote:
> On Thu, 29 Jul 2010 18:34:19 -0400, Kristian Høgsberg
> wrote:
>> There are a few cases where the server will flush client output buffers
>> but our block handler only catches the most common (before going into
>> s
Signed-off-by: Kristian Høgsberg
---
> ==2989== Invalid write of size 4
> ==2989==at 0x48CE6E5: DrawableGone (glxext.c:169)
> ==2989==by 0x809F401: FreeResource (resource.c:601)
> ==2989==by 0x80845CE: ProcDestroyWindow (dispatch.c:733)
> ==2989==by 0x80
Signed-off-by: Kristian Høgsberg
---
Chris Wilson points out that we were still accessing c->next after free.
Here's an updated version that fixes that.
Kristian
glx/glxext.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/glx/glxext.c b/glx/glxext
) callback for. We
treat that as an unbind, which triggers the context destruction. As
Jon mentions, that may not be the right thing to do, but in the scope
of this patch, we're just delaying the destroy until we're done
touching the context.
Kristian
> On Sep 23, 2010, at 06:04,
2010/9/23 Kristian Høgsberg :
> 2010/9/23 Jeremy Huddleston :
>> That seems off to me. This is doing more than changing the c->next
>> dereference. You're now freeing it where you weren't before.
>>
>> Previously, you freed it inside:
>> if
On Thu, Oct 21, 2010 at 1:49 PM, Chia-I Wu wrote:
> On Fri, Oct 22, 2010 at 12:18 AM, Jesse Barnes
> wrote:
>> On Thu, 21 Oct 2010 17:55:13 +0800
>> Chia-I Wu wrote:
>>
>>> Hi list,
>>>
>>> According to the doc for page_flip, intel_crtc_page_flip should
>>>
>>> ... block all rendering to the
On Wed, Dec 1, 2010 at 11:54 AM, Julien Cristau wrote:
> On Wed, Dec 1, 2010 at 17:10:42 +0200, Alexander Shishkin wrote:
>
>> For headers that get exported to userland and make use of u32 style
>> type names, it is advised to include linux/types.h.
>>
>> This fixes 5 headers_check warnings.
>>
>
I implemented this just a few days ago:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=e5169e9615e8391ea369415b356168717b8f7be0
It's a new use flags instead of a new format, because, well, it's not
a new pixel format, but a restriction on how the buffers should be
allocated.
Kristian
On Tue,
on it yet.
Kristian
Kristian Høgsberg (16):
intel: Use gen number instead of PCI ID in decoder
intel: Use the PCI ID map for determining chipset gen
intel: IS_9XX is just gen >= 3
intel: Remove unused IS_915 macro
intel: Replace intel_screen::gen with the chipset struct
intel: Add a
---
src/mesa/drivers/dri/intel/intel_batchbuffer.c |2 +-
src/mesa/drivers/dri/intel/intel_chipset.h |3 --
src/mesa/drivers/dri/intel/intel_decode.c | 42
src/mesa/drivers/dri/intel/intel_decode.h |2 +-
4 files changed, 23 insertions(+), 26 de
---
src/mesa/drivers/dri/i915/Makefile|2 +-
src/mesa/drivers/dri/i965/Makefile|2 +-
src/mesa/drivers/dri/intel/intel_screen.c | 96 +++--
3 files changed, 80 insertions(+), 20 deletions(-)
diff --git a/src/mesa/drivers/dri/i915/Makefile
b/src/m
---
src/mesa/drivers/dri/intel/intel_chipset.h |4
src/mesa/drivers/dri/intel/intel_context.c |2 +-
src/mesa/drivers/dri/intel/intel_screen.c | 10 --
3 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_chipset.h
b/src/mesa/dri
---
src/mesa/drivers/dri/intel/intel_chipset.h |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_chipset.h
b/src/mesa/drivers/dri/intel/intel_chipset.h
index 6c82e4d..5d4aaab 100644
--- a/src/mesa/drivers/dri/intel/intel_chipset.h
+++ b/s
---
src/mesa/drivers/dri/intel/intel_context.c |2 +-
src/mesa/drivers/dri/intel/intel_screen.c | 14 +-
src/mesa/drivers/dri/intel/intel_screen.h |6 +-
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_context.c
b/src/m
---
src/mesa/drivers/dri/intel/intel_chipset.h | 14 --
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_chipset.h
b/src/mesa/drivers/dri/intel/intel_chipset.h
index 66f14fd..37239fc 100644
--- a/src/mesa/drivers/dri/intel/intel_chipse
---
src/mesa/drivers/dri/intel/intel_chipset.h |7 ---
src/mesa/drivers/dri/intel/intel_context.c |8 +++-
src/mesa/drivers/dri/intel/intel_screen.c |2 +-
src/mesa/drivers/dri/intel/intel_screen.h |1 +
4 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/src/
---
src/mesa/drivers/dri/intel/intel_chipset.h |6 --
src/mesa/drivers/dri/intel/intel_context.c |2 +-
2 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_chipset.h
b/src/mesa/drivers/dri/intel/intel_chipset.h
index 37239fc..ca386b5 100644
---
src/mesa/drivers/dri/intel/intel_chipset.h |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_chipset.h
b/src/mesa/drivers/dri/intel/intel_chipset.h
index ca386b5..3e11f64 100644
--- a/src/mesa/drivers/dri/intel/intel_chipset.h
+++
---
src/mesa/drivers/dri/intel/intel_chipset.h | 10 --
src/mesa/drivers/dri/intel/intel_context.c |6 +++---
2 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_chipset.h
b/src/mesa/drivers/dri/intel/intel_chipset.h
index 3e11f64..979cd0
---
src/mesa/drivers/dri/i965/brw_context.c | 53 -
src/mesa/drivers/dri/intel/intel_screen.c | 46 +
src/mesa/drivers/dri/intel/intel_screen.h |7
3 files changed, 53 insertions(+), 53 deletions(-)
diff --git a/src/mesa/drivers/d
---
src/mesa/drivers/dri/intel/intel_chipset.h | 16
1 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_chipset.h
b/src/mesa/drivers/dri/intel/intel_chipset.h
index 979cd0b..e8bb3fe 100644
--- a/src/mesa/drivers/dri/intel/intel_chip
---
src/mesa/drivers/dri/intel/intel_chipset.h |9 -
src/mesa/drivers/dri/intel/intel_context.c |2 +-
src/mesa/drivers/dri/intel/intel_screen.c |1 +
src/mesa/drivers/dri/intel/intel_screen.h |2 +-
4 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/src/mesa
---
include/pci_ids/i915_pci_ids.h|4 ++--
src/mesa/drivers/dri/i915/i830_texstate.c |3 +--
src/mesa/drivers/dri/intel/intel_screen.c |4
src/mesa/drivers/dri/intel/intel_screen.h |2 +-
4 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/include/pci_id
---
include/pci_ids/i915_pci_ids.h | 30
include/pci_ids/i965_pci_ids.h | 54 +++---
include/pci_ids/pci_id_driver_map.h|4 +-
src/mesa/drivers/dri/intel/intel_context.c | 117 ++--
src/mesa/drivers/dri/intel/intel_s
---
src/mesa/drivers/dri/i915/i830_texstate.c |1 -
src/mesa/drivers/dri/i965/brw_defines.h |2 -
src/mesa/drivers/dri/intel/intel_chipset.h| 83 -
src/mesa/drivers/dri/intel/intel_context.c|1 -
src/mesa/drivers/dri/intel/intel_decode.c
2011/6/8 Kenneth Graunke :
> On 06/07/2011 12:34 PM, Kristian Høgsberg wrote:
>>
>> Hi,
>>
>> Here's a handful of patches that try to replace most of our chipset
>> feature checking with data in a new struct intel_chipset. It uses the
>> new PCI ID l
On Tue, Jun 30, 2015 at 7:13 AM, Thomas Daniel wrote:
> From: Chris Wilson
>
> Userspace can pass in an offset that it presumes the object is located
> at. The kernel will then do its utmost to fit the object into that
> location. The assumption is that userspace is handling its own object
> loca
The I915_EXEC_NO_RELOC flag lets us tell the kernel that the offset we
provide in the validate list entry is what we've used in all relocations
to the bo in question. If the bo hasn't moved, the kernel can skip
relocations completely.
Signed-off-by: Kristian Høgsberg
. This allows the kernel to look up the bo for
a reloc in constant time.
Signed-off-by: Kristian Høgsberg
---
intel/intel_bufmgr_gem.c | 33 +++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
index
On Fri, Jan 16, 2015 at 8:23 PM, Daniel Vetter wrote:
> On Fri, Jan 16, 2015 at 05:46:00PM -0800, Kristian Høgsberg wrote:
>> The I915_EXEC_NO_RELOC flag lets us tell the kernel that the offset we
>> provide in the validate list entry is what we've used in all relocations
>
On Sat, Jan 17, 2015 at 1:49 AM, Chris Wilson wrote:
> On Sat, Jan 17, 2015 at 05:23:59AM +0100, Daniel Vetter wrote:
>> On Fri, Jan 16, 2015 at 05:46:00PM -0800, Kristian Høgsberg wrote:
>> > The I915_EXEC_NO_RELOC flag lets us tell the kernel that the offset we
>> > p
On Tue, Jan 20, 2015 at 12:42 AM, Daniel Vetter wrote:
> On Mon, Jan 19, 2015 at 09:45:35PM -0800, Kristian Høgsberg wrote:
>> On Fri, Jan 16, 2015 at 8:23 PM, Daniel Vetter wrote:
>> > On Fri, Jan 16, 2015 at 05:46:00PM -0800, Kristian Høgsberg wrote:
>> >> The I
On Tue, Jan 20, 2015 at 1:46 PM, Chris Wilson wrote:
> On Tue, Jan 20, 2015 at 12:53:35PM -0800, Kristian Høgsberg wrote:
>> On Tue, Jan 20, 2015 at 12:42 AM, Daniel Vetter wrote:
>> > My idea for all this would have been to create a per-thread execbuf
>> > relocatio
The kernel doesn't actually wait indefinately when passed a negative,
timeout, it returns immediately. Document this and suggest using INT64_MAX
for indefinite waits.
Signed-off-by: Kristian Høgsberg
---
We first check if the object is already idle and return 0 if so. Then
we hit
On Sat, Aug 1, 2015 at 2:06 AM, Chris Wilson wrote:
> On Fri, Jul 31, 2015 at 10:53:26AM -0700, k...@bitplanet.net wrote:
>> From: Kristian Høgsberg Kristensen
>>
>> We now have a separate tool for this in intel-gpu-tools and we don't
>> need to clutter up libdrm
On Fri, Aug 7, 2015 at 2:45 AM, Michel Thierry wrote:
> Gen8+ supports 48-bit virtual addresses, but some objects must always be
> allocated inside the 32-bit address range.
>
> In specific, any resource used with flat/heapless (0x-0xf000)
> General State Heap or Intruction State Heap
On Mon, Aug 10, 2015 at 2:21 AM, Michel Thierry
wrote:
> Hi,
>
> Thanks for the comments,
>
> On 8/7/2015 11:46 PM, Kristian Høgsberg wrote:
>>
>> On Fri, Aug 7, 2015 at 2:45 AM, Michel Thierry
>> wrote:
>>>
>>> Gen8+ supports 48-bit
67 matches
Mail list logo
