Re: [Intel-gfx] [RFC 2/2] drm/i915: Render decompression support for Gen9

2016-01-11 Thread Konduru, Chandra
> -Original Message- > From: Daniel Stone [mailto:dan...@fooishbar.org] > Sent: Wednesday, December 23, 2015 1:37 AM > To: Kannan, Vandana > Cc: intel-gfx; Konduru, Chandra; Murthy, Arun R > Subject: Re: [Intel-gfx] [RFC 2/2] drm/i915: Render decompression support

Re: [Intel-gfx] [PATCH 12/21] drm/i915: Ensure colorkey and scaling aren't enabled at same time

2015-03-17 Thread Konduru, Chandra
> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Tuesday, March 17, 2015 8:13 AM > To: Daniel Vetter > Cc: Konduru, Chandra; Conselvan De Oliveira, Ander; intel- > g...@lists.freedesktop.org; Vetter, Daniel > Subject: Re: [Intel-g

Re: [Intel-gfx] [PATCH 01/21] drm/i915: Adding drm helper function drm_plane_from_index().

2015-03-17 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Tuesday, March 17, 2015 7:05 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Conselvan De Oliveira, Ander; Vetter, > Daniel > Subject: Re:

Re: [Intel-gfx] [PATCH 13/21] drm/i915: Preserve scaler state when clearing crtc_state

2015-03-17 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Tuesday, March 17, 2015 7:17 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Conselvan De Oliveira, Ander; Vetter, > Daniel > Subject: Re:

Re: [Intel-gfx] [PATCH 14/21] drm/i915: use current scaler state during readout_hw_state.

2015-03-17 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Tuesday, March 17, 2015 7:20 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Conselvan De Oliveira, Ander; Vetter, > Daniel > Subject: Re:

Re: [Intel-gfx] [PATCH 19/21] drm/i915: Enable skylake panel fitting using skylake shared scalers

2015-03-17 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Tuesday, March 17, 2015 7:22 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Conselvan De Oliveira, Ander; Vetter, > Daniel > Subject: Re:

Re: [Intel-gfx] [PATCH 00/21] skylake display scalers

2015-03-17 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Tuesday, March 17, 2015 7:33 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Conselvan De Oliveira, Ander; Vetter, > Daniel > Subject: Re:

Re: [Intel-gfx] [PATCH 04/21] drm/i915: skylake scaler structure definitions

2015-03-17 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, March 17, 2015 9:13 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 04/21] drm/i915: skylake scaler structure definit

Re: [Intel-gfx] [PATCH 07/21] drm/i915: Helper function to update skylake scaling ratio.

2015-03-17 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, March 17, 2015 9:35 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 07/21] drm/i915: Helper function to update sk

Re: [Intel-gfx] [PATCH v2 00/19] Remove depencies on staged config for atomic transition

2015-03-18 Thread Konduru, Chandra
> -Original Message- > From: Conselvan De Oliveira, Ander > Sent: Friday, March 13, 2015 2:49 AM > To: intel-gfx@lists.freedesktop.org > Cc: Konduru, Chandra; Conselvan De Oliveira, Ander > Subject: [PATCH v2 00/19] Remove depencies on staged config for atomic > tran

Re: [Intel-gfx] [PATCH v4] drm/i915: Allocate a drm_atomic_state for the legacy modeset code

2015-03-18 Thread Konduru, Chandra
> -Original Message- > From: Conselvan De Oliveira, Ander > Sent: Wednesday, March 18, 2015 12:57 AM > To: intel-gfx@lists.freedesktop.org > Cc: Konduru, Chandra; Conselvan De Oliveira, Ander > Subject: [PATCH v4] drm/i915: Allocate a drm_atomic_state for the leg

Re: [Intel-gfx] [PATCH 08/19] drm/i915: Don't use encoder->new_crtc in intel_modeset_pipe_config()

2015-03-18 Thread Konduru, Chandra
> -Original Message- > From: Conselvan De Oliveira, Ander > Sent: Friday, March 13, 2015 2:49 AM > To: intel-gfx@lists.freedesktop.org > Cc: Konduru, Chandra; Conselvan De Oliveira, Ander > Subject: [PATCH 08/19] drm/i915: Don't use encoder->new_crtc in &

Re: [Intel-gfx] [PATCH 08/21] drm/i915: Add helper function to update scaler_users in crtc_state

2015-03-19 Thread Konduru, Chandra
> -Original Message- > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > Daniel Vetter > Sent: Wednesday, March 18, 2015 1:16 AM > To: Konduru, Chandra > Cc: intel-gfx; Conselvan De Oliveira, Ander; Vetter, Daniel > Subject: Re: [Intel-g

Re: [Intel-gfx] [PATCH 17/19] drm/i915: Convert intel_pipe_will_have_type() to using atomic state

2015-03-19 Thread Konduru, Chandra
> -Original Message- > From: Conselvan De Oliveira, Ander > Sent: Friday, March 13, 2015 2:49 AM > To: intel-gfx@lists.freedesktop.org > Cc: Konduru, Chandra; Conselvan De Oliveira, Ander > Subject: [PATCH 17/19] drm/i915: Convert intel_pipe_will_have_type() to us

Re: [Intel-gfx] [PATCH 19/19] drm/i915: Remove usage of encoder->new_crtc from clock computations

2015-03-19 Thread Konduru, Chandra
> -Original Message- > From: Conselvan De Oliveira, Ander > Sent: Friday, March 13, 2015 2:49 AM > To: intel-gfx@lists.freedesktop.org > Cc: Konduru, Chandra; Conselvan De Oliveira, Ander > Subject: [PATCH 19/19] drm/i915: Remove usage of encoder->new_crtc from

Re: [Intel-gfx] [PATCH 05/19] drm/i915: Update dummy connector atomic state with current config

2015-03-19 Thread Konduru, Chandra
> -Original Message- > From: Conselvan De Oliveira, Ander > Sent: Friday, March 13, 2015 2:49 AM > To: intel-gfx@lists.freedesktop.org > Cc: Konduru, Chandra; Conselvan De Oliveira, Ander > Subject: [PATCH 05/19] drm/i915: Update dummy connector atomic state wit

Re: [Intel-gfx] [PATCH 16/19] drm/i915: Check lane sharing between pipes B & C using atomic state

2015-03-19 Thread Konduru, Chandra
> -Original Message- > From: Conselvan De Oliveira, Ander > Sent: Friday, March 13, 2015 2:49 AM > To: intel-gfx@lists.freedesktop.org > Cc: Konduru, Chandra; Conselvan De Oliveira, Ander > Subject: [PATCH 16/19] drm/i915: Check lane sharing between pipes B &

Re: [Intel-gfx] [PATCH 03/19] drm/i915: Allocate a drm_atomic_state for the legacy modeset code

2015-03-19 Thread Konduru, Chandra
> -Original Message- > From: Conselvan De Oliveira, Ander > Sent: Friday, March 13, 2015 2:49 AM > To: intel-gfx@lists.freedesktop.org > Cc: Konduru, Chandra; Conselvan De Oliveira, Ander > Subject: [PATCH 03/19] drm/i915: Allocate a drm_atomic_state for the leg

Re: [Intel-gfx] [PATCH 04/19] drm/i915: Allocate a crtc_state also when the crtc is being disabled

2015-03-19 Thread Konduru, Chandra
> -Original Message- > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > Sent: Thursday, March 19, 2015 12:52 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 04/19] drm/i915: Allocate a crtc_state also when the

Re: [Intel-gfx] [PATCH 17/19] drm/i915: Convert intel_pipe_will_have_type() to using atomic state

2015-03-22 Thread Konduru, Chandra
> -Original Message- > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > Sent: Thursday, March 19, 2015 11:28 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 17/19] drm/i915: Convert intel_pipe_will_have_type() to &g

Re: [Intel-gfx] [PATCH 16/19] drm/i915: Check lane sharing between pipes B & C using atomic state

2015-03-22 Thread Konduru, Chandra
> -Original Message- > From: Conselvan De Oliveira, Ander > Sent: Thursday, March 19, 2015 11:46 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 16/19] drm/i915: Check lane sharing between pipes B & C > using atomic state &

Re: [Intel-gfx] [PATCH 03/19] drm/i915: Allocate a drm_atomic_state for the legacy modeset code

2015-03-22 Thread Konduru, Chandra
> -Original Message- > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > Sent: Friday, March 20, 2015 12:00 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 03/19] drm/i915: Allocate a drm_atomic_state for the >

Re: [Intel-gfx] [PATCH 04/19] drm/i915: Allocate a crtc_state also when the crtc is being disabled

2015-03-22 Thread Konduru, Chandra
> -Original Message- > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > Sent: Friday, March 20, 2015 1:41 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Roper, Matthew D > Subject: Re: [PATCH 04/19] drm/i915: Allocate a crtc_state

Re: [Intel-gfx] [PATCH 01/21 v2] drm/i915: Adding drm helper function drm_plane_from_index().

2015-03-23 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Monday, March 23, 2015 2:33 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Conselvan De Oliveira, Ander; Vetter, > Daniel > Subject: Re:

Re: [Intel-gfx] [PATCH 16/19] drm/i915: Check lane sharing between pipes B & C using atomic state

2015-03-23 Thread Konduru, Chandra
> -Original Message- > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > Sent: Monday, March 23, 2015 12:34 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 16/19] drm/i915: Check lane sharing between pipes B &

Re: [Intel-gfx] [PATCH v2] i-g-t: Adding test case to test background color.

2015-03-24 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Monday, March 02, 2015 9:54 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v2] i-g-t: Adding test case

Re: [Intel-gfx] [PATCH 04/21 v2] drm/i915: skylake scaler structure definitions

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, March 24, 2015 10:14 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 04/21 v2] drm/i915: skylake scaler structure de

Re: [Intel-gfx] [PATCH 05/21 v2] drm/i915: Initialize skylake scalers

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, March 24, 2015 10:14 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 05/21 v2] drm/i915: Initialize skylake scaler

Re: [Intel-gfx] [PATCH 16/21 v2] drm/i915: Ensure setting up scalers into staged crtc_state

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Wednesday, March 25, 2015 10:22 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 16/21 v2] drm/i915: Ensure setting u

Re: [Intel-gfx] [PATCH 12/21 v2] drm/i915: Ensure colorkey and scaling aren't enabled at same time

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Wednesday, March 25, 2015 10:22 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 12/21 v2] drm/i915: Ensure colorkey and scalin

Re: [Intel-gfx] [PATCH 07/21 v2] drm/i915: Helper function to update skylake scaling ratio.

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, March 24, 2015 10:14 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 07/21 v2] drm/i915: Helper function to update sk

Re: [Intel-gfx] [PATCH 08/21 v2] drm/i915: Add helper function to update scaler_users in crtc_state

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, March 24, 2015 10:15 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 08/21 v2] drm/i915: Add helper function to upd

Re: [Intel-gfx] [PATCH 09/21 v2] drm/i915: Add atomic function to setup scalers scalers for a crtc.

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, March 24, 2015 10:15 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 09/21 v2] drm/i915: Add atomic function to se

Re: [Intel-gfx] [PATCH 10/21 v2] drm/i915: Helper function to detach a scaler from a plane or crtc

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, March 24, 2015 10:16 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 10/21 v2] drm/i915: Helper function to detach

Re: [Intel-gfx] [PATCH 10/21 v2] drm/i915: Helper function to detach a scaler from a plane or crtc

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Wednesday, March 25, 2015 2:14 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 10/21 v2] drm/i915: Helper function to detach

Re: [Intel-gfx] [PATCH 21/21 v2] drm/i915: Enable skylake sprite plane scaling using shared scalers

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Wednesday, March 25, 2015 2:30 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 21/21 v2] drm/i915: Enable skylake sprite

Re: [Intel-gfx] [PATCH 08/21 v2] drm/i915: Add helper function to update scaler_users in crtc_state

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Wednesday, March 25, 2015 1:59 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 08/21 v2] drm/i915: Add helper function to upd

Re: [Intel-gfx] [PATCH 10/21 v2] drm/i915: Helper function to detach a scaler from a plane or crtc

2015-03-30 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Friday, March 27, 2015 5:22 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 10/21 v2] drm/i915: Helper function to detach

Re: [Intel-gfx] [PATCH 20/20] drm/i915: Enable skylake sprite plane scaling using shared scalers

2015-04-02 Thread Konduru, Chandra
7:45 AM > To: He, Shuang; Gao, Ethan; intel-gfx@lists.freedesktop.org; Konduru, Chandra > Subject: RE: [Intel-gfx] [PATCH 20/20] drm/i915: Enable skylake sprite plane > scaling using shared scalers > > Tested-By: PRC QA PRTS (Patch Regression Test System Contac

Re: [Intel-gfx] [PATCH 10/20] drm/i915: Add atomic function to setup scalers scalers for a crtc.

2015-04-05 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Thursday, April 02, 2015 4:05 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 10/20] drm/i915: Add atomic function to setup sc

Re: [Intel-gfx] [PATCH 13/20] drm/i915: use current scaler state during readout_hw_state.

2015-04-05 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Thursday, April 02, 2015 4:05 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 13/20] drm/i915: use current scaler state duri

Re: [Intel-gfx] [PATCH 06/20] drm/i915: Convert primary plane 16.16 values to regular ints

2015-04-07 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Tuesday, April 07, 2015 1:44 AM > To: Roper, Matthew D > Cc: Konduru, Chandra; Vetter, Daniel; intel-gfx@lists.freedesktop.org; > Conselvan De Oliveira, A

Re: [Intel-gfx] [PATCH] drm/i915: reset drm state backpointer in crtc_state

2015-04-07 Thread Konduru, Chandra
> -Original Message- > From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > Sent: Tuesday, April 07, 2015 2:02 AM > To: Konduru, Chandra; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: reset drm state backpointer in > crtc_state >

Re: [Intel-gfx] [PATCH 06/20] drm/i915: Convert primary plane 16.16 values to regular ints

2015-04-07 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, April 07, 2015 11:46 AM > To: Konduru, Chandra > Cc: Daniel Vetter; Vetter, Daniel; intel-gfx@lists.freedesktop.org; Conselvan > De > Oliveira, Ander > Subject: Re: [Intel-gfx] [PATCH 06/20] drm/i91

[Intel-gfx] crtc_state in check_primary_plane

2015-04-07 Thread Konduru, Chandra
Hi, I have added code to get crtc_state in intel_check_primary_plane(). And using crtc_clock member crtc_state->base.adjusted_mode.crtc_clock. What I observed is, in below stack trace, valid allocation of crtc_state is there, but seems crtc_state is zeroed out or atleast crtc_clock is 0. Is it e

Re: [Intel-gfx] crtc_state in check_primary_plane

2015-04-08 Thread Konduru, Chandra
> -Original Message- > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > Sent: Wednesday, April 08, 2015 12:06 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel > Subject: Re: [Intel-gfx] crtc_state in check_primary_plane &g

Re: [Intel-gfx] [PATCH] drm/i915: reset drm state backpointer in crtc_state

2015-04-08 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Wednesday, April 08, 2015 1:20 AM > To: Konduru, Chandra > Cc: Jani Nikula; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i91

Re: [Intel-gfx] [PATCH 13/14] drm/i915: skylake primary plane scaling using shared scalers

2015-04-13 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Monday, April 13, 2015 11:13 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Conselvan De Oliveira, Ander; Vetter, > Daniel > Subject: Re:

Re: [Intel-gfx] [PATCH 08/24] drm/i915: Do not add planes from intel_atomic_setup_scalers.

2015-06-05 Thread Konduru, Chandra
> >> @@ -396,6 +377,24 @@ int intel_atomic_setup_scalers(struct > drm_device > > *dev, > >>} > >>} > >> > >> + /* plane not part of mask must leave hq mode? */ > >> + if (num_scalers_need > 1 && scaler_state->scalers[0].in_use && > >

Re: [Intel-gfx] [PATCH 08/24] drm/i915: Do not add planes from intel_atomic_setup_scalers.

2015-06-08 Thread Konduru, Chandra
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Friday, June 05, 2015 11:39 PM > To: Konduru, Chandra; Roper, Matthew D > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 08/24] drm/i915: Do n

[Intel-gfx] CRTC fixup failed

2015-06-11 Thread Konduru, Chandra
When running some kms tests (e.g., kms_plane) immediately after i915 load, getting below error: Jun 11 12:03:39 cmkondur-skl kernel: [ 423.098254] [drm:intel_modeset_pipe_config] CRTC fixup failed I am using drm-intel-nightly as of last Friday: commit d4f412886ec9694658ab17092c3f70569a0405f9 Au

Re: [Intel-gfx] CRTC fixup failed

2015-06-11 Thread Konduru, Chandra
Actually, observed that modprobe i915 itself is reporting CRTC fixup failed and completing with no active planes but with active pipe. This looks like issue reported in: https://bugs.freedesktop.org/show_bug.cgi?id=90861 From: Konduru, Chandra Sent: Thursday, June 11, 2015 12:11 PM To: intel

Re: [Intel-gfx] [PATCH] drm/i915/skl: Assume no scaling is available when things are not as expected

2015-06-15 Thread Konduru, Chandra
> > > > Cdclk < crtc_clock is not allowed and suggests a different problem > > elsewhere. > > > > It is more robust and safe to assume no scaling is possible in this case. > > > > Signed-off-by: Tvrtko Ursulin > > Cc: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/intel_display.c | 2 +- > > 1

Re: [Intel-gfx] [PATCH v6 2/8] drm/i915: Use cached cdclk value

2015-06-15 Thread Konduru, Chandra
> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Damien Lespiau > Sent: Monday, June 15, 2015 6:15 AM > To: Daniel Vetter > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v6 2/8] drm/i915: Use cached cdclk value

Re: [Intel-gfx] [PATCH 2/2] drm/i915: In DBUF/WM calcs for 90/270, swap w & h

2015-06-29 Thread Konduru, Chandra
> This patch swaps src width and height for dbuf/wm calculations > when rotation is 90/270 as per hw requirements. > > Signed-off-by: Chandra Konduru Do we have an igt which provokes underruns and hence can test this automatically? Very tall/narrow buffers should do it I think. -Daniel Yes. Righ

Re: [Intel-gfx] [PATCH 08/15] drm/i915: Add NV12 as supported format for primary plane

2015-08-26 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Wednesday, August 26, 2015 1:40 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Syrjala, Ville > Subject: Re: [Intel-gfx] [PAT

Re: [Intel-gfx] [PATCH 14/15] drm/i915: skl nv12 workarounds

2015-08-26 Thread Konduru, Chandra
> > -static char intel_get_stepping(struct drm_device *dev) > > +char intel_get_stepping(struct drm_device *dev) > > I guess we should have a new home for this now that it's used outside of > intel_csr.c Plus kerneldoc, as usual. Will add kerneldoc header and respun, but where do you want to move

Re: [Intel-gfx] [PATCH i-g-t 2/2] Adding kms_nv12 to test display NV12 feature

2015-08-26 Thread Konduru, Chandra
> > +static void test_nv12_invalid_fb_params(data_t *d) > > +{ > > + igt_display_t *display = &d->display; > > + igt_output_t *output; > > + enum pipe pipe; > > + int valid_tests = 0; > > + > > + igt_require(d->display.has_universal_planes); > > + igt_require(d->num_scalers); > > + > >

Re: [Intel-gfx] 4.1->4.2 regression : intel_display.c:12324 check_crtc_state warning

2015-09-02 Thread Konduru, Chandra
t; From: Toralf Förster [mailto:toralf.foers...@gmx.de] > Sent: Wednesday, September 02, 2015 1:18 PM > To: Konduru, Chandra; Roper, Matthew D; daniel.vet...@ffwll.ch > Cc: intel-gfx > Subject: 4.1->4.2 regression : intel_display.c:12324 check_crtc_state warning > > The following co

Re: [Intel-gfx] [PATCH 14/15] drm/i915: skl nv12 workarounds

2015-09-03 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Wednesday, September 02, 2015 1:02 AM > To: Konduru, Chandra > Cc: Daniel Vetter; intel-gfx@lists.freedesktop.org; Vetter, Daniel; Syrjala, > Ville > Su

Re: [Intel-gfx] [PATCH i-g-t 2/2] Adding kms_nv12 to test display NV12 feature

2015-09-03 Thread Konduru, Chandra
> > > > + > > > > + /* redo AddFB */ > > > > + memset(&f, 0, sizeof(f)); > > > > + > > > > + f.width = d->fb1_nv12.width; > > > > + f.height = d->fb1_nv12.height; > > > > + f.pixel_format = d->fb1_nv12.drm_format; > > > > +

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Add NV12 to primary plane programming.

2015-09-04 Thread Konduru, Chandra
> > + > > + if (fb->pixel_format == DRM_FORMAT_NV12) { > > + int height_in_mem = (fb->offsets[1]/fb->pitches[0]); > > + /* > > +* If UV starts from middle of a page, then UV start > should > > +* be programmed to

Re: [Intel-gfx] [PATCH 14/15] drm/i915: skl nv12 workarounds

2015-09-04 Thread Konduru, Chandra
> > + > > + if (((IS_SKYLAKE(dev) && intel_get_stepping(dev) == 'C') || > > + (IS_BROXTON(dev) && intel_get_stepping(dev) == 'A')) && > > + fb->pixel_format == DRM_FORMAT_NV12) { > > + I915_WRITE(CHICKEN_PIPESL(pipe), > > + I915_READ

Re: [Intel-gfx] [PATCH 15/15] drm/i915: Add 90/270 rotation for NV12 format.

2015-09-04 Thread Konduru, Chandra
> > /* Adjust (macro)pixel boundary */ > > if (fb && intel_format_is_yuv(fb->pixel_format)) { > > - to_intel_plane_state(plane_state)->src.x1 &= ~0x1; > > - to_intel_plane_state(plane_state)->src.x2 &= ~0x1; > > + if (intel_rotation_90_or_270(plane_stat

Re: [Intel-gfx] [PATCH 14/15] drm/i915: skl nv12 workarounds

2015-09-04 Thread Konduru, Chandra
> > > On Thu, Aug 27, 2015 at 01:44:06AM +, Konduru, Chandra wrote: > > > > > > -static char intel_get_stepping(struct drm_device *dev) > > > > > > +char intel_get_stepping(struct drm_device *dev) > > > > > > > > >

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Add NV12 to primary plane programming.

2015-09-08 Thread Konduru, Chandra
> > > > + if (fb->pixel_format == DRM_FORMAT_NV12) { > > > > + int height_in_mem = > > > > (fb->offsets[1]/fb->pitches[0]); > > > > + /* > > > > +* If UV starts from middle of a page, then UV > > > > start > > > sho

Re: [Intel-gfx] [PATCH 14/15] drm/i915: skl nv12 workarounds

2015-09-08 Thread Konduru, Chandra
> > > > +static void skl_wa_clkgate(struct drm_i915_private *dev_priv, > > > > + int pipe, int enable) > > > > +{ > > > > + if (pipe == PIPE_A || pipe == PIPE_B) { > > > > + if (enable) > > > > + I915_WRITE(CLKGATE_DIS_PSL(pipe), > > > > +

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Add NV12 to primary plane programming.

2015-09-09 Thread Konduru, Chandra
> > > > > > + /* For tile-Yf, uv-subplane tile width is 2x of > > > > > > Y- > subplane > > > > > */ > > > > > > + aux_stride = fb->modifier[0] == > > > > > I915_FORMAT_MOD_Yf_TILED ? > > > > > > + stride / 2 : stride; > > > > > > > > >

Re: [Intel-gfx] [PATCH 14/15] drm/i915: skl nv12 workarounds

2015-09-09 Thread Konduru, Chandra
> > > > > > + > > > > > > + /* workaround for NV12 */ > > > > > > + skl_wa_clkgate(dev_priv, pipe, 1); > > > > > > > > > > I wonder what's the cost of having this > > > > > a) always enabled > > > > > b) enabled when the pipe is enabled > > > > > c) enabled only when NV12 is used > > > > > ? >

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Add NV12 to primary plane programming.

2015-09-09 Thread Konduru, Chandra
> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Wednesday, September 09, 2015 11:06 AM > To: Konduru, Chandra > Cc: Syrjala, Ville; intel-gfx@lists.freedesktop.org; Vetter, Daniel > Subject: Re: [Intel-gfx] [PATCH 11/15] drm

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Add NV12 to primary plane programming.

2015-09-09 Thread Konduru, Chandra
> > > > > > > > > > + /* For tile-Yf, uv-subplane tile width > > > > > > > > > > is > 2x of Y- > > > > > subplane > > > > > > > > > */ > > > > > > > > > > + aux_stride = fb->modifier[0] == > > > > > > > > > I915_FORMAT_MOD_Yf_TILED ? > > > > > > > > > > +

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Add NV12 to primary plane programming.

2015-09-09 Thread Konduru, Chandra
> Looking at what was said, I think we covered most open items > reasonably well, so fire away. I'll start going through the > updated patches tomorrow. > Updates patches: http://lists.freedesktop.org/archives/intel-gfx/2015-September/075235.html ___ In

Re: [Intel-gfx] [PATCH 04/15] drm/i915: Stage scaler request for NV12 as src format

2015-09-10 Thread Konduru, Chandra
> > +static bool skl_need_scaling(int src_w, int src_h, int dst_w, int dst_h, > > + unsigned int rotation, uint32_t pixel_format) > > +{ > > + /* need a scaler when sizes doesn't match */ > > + if (src_w != dst_w || src_h != dst_h) > > + return true; > > + > > + /* in case of 90/2

Re: [Intel-gfx] [PATCH 09/15] drm/i915: Add NV12 support to intel_framebuffer_init

2015-09-10 Thread Konduru, Chandra
> > + if (obj->tiling_mode == I915_TILING_X && > > + !(mode_cmd->flags & DRM_MODE_FB_MODIFIERS)) { > > Your editor still seems to mess up the indentation in these cases. Can > you try to fix that? If condition isn't fitting in a single line, so continued in next line l

Re: [Intel-gfx] [PATCH 09/15] drm/i915: Add NV12 support to intel_framebuffer_init

2015-09-10 Thread Konduru, Chandra
> > > > + if (obj->tiling_mode == I915_TILING_X && > > > > + !(mode_cmd->flags & DRM_MODE_FB_MODIFIERS)) { > > > > > > Your editor still seems to mess up the indentation in these cases. Can > > > you try to fix that? > > > > If condition isn't fitting in a single

Re: [Intel-gfx] [PATCH 09/15] drm/i915: Add NV12 support to intel_framebuffer_init

2015-09-10 Thread Konduru, Chandra
> > > + if (mode_cmd->modifier[1] == I915_FORMAT_MOD_Y_TILED > && > > > + ((mode_cmd->offsets[1] / mode_cmd->pitches[1]) % > 4)) { > > > + DRM_DEBUG("tile-Y uv offset 0x%x isn't 4-line > aligned\n", > > > + mode_cmd->offsets[1]); > > >

Re: [Intel-gfx] [PATCH 07/15] drm/i915: Add NV12 as supported format for primary plane

2015-09-10 Thread Konduru, Chandra
> > +/* Primary plane formats for gen >= 9 with NV12 */ > > +static const uint32_t skl_primary_formats_with_nv12[] = { > > + DRM_FORMAT_C8, > > + DRM_FORMAT_RGB565, > > + DRM_FORMAT_XRGB, > > + DRM_FORMAT_XBGR, > > + DRM_FORMAT_ARGB, > > + DRM_FORMAT_ABGR, > > + DRM_FO

Re: [Intel-gfx] [PATCH 07/15] drm/i915: Add NV12 as supported format for primary plane

2015-09-10 Thread Konduru, Chandra
> > > > +/* Primary plane formats for gen >= 9 with NV12 */ > > > > +static const uint32_t skl_primary_formats_with_nv12[] = { > > > > + DRM_FORMAT_C8, > > > > + DRM_FORMAT_RGB565, > > > > + DRM_FORMAT_XRGB, > > > > + DRM_FORMAT_XBGR, > > > > + DRM_FORMAT_ARGB8

Re: [Intel-gfx] [PATCH 07/15] drm/i915: Add NV12 as supported format for primary plane

2015-09-15 Thread Konduru, Chandra
> > On Thu, Sep 10, 2015 at 09:06:23PM +, Konduru, Chandra wrote: > > > > > +/* Primary plane formats for gen >= 9 with NV12 */ > > > > > +static const uint32_t skl_primary_formats_with_nv12[] = { > > > > >

Re: [Intel-gfx] [PATCH 09/15] drm/i915: Add NV12 support to intel_framebuffer_init

2015-09-15 Thread Konduru, Chandra
> > > > > > + if (obj->tiling_mode == I915_TILING_X && > > > > > > + !(mode_cmd->flags & > DRM_MODE_FB_MODIFIERS)) { > > > > > > > > > > Your editor still seems to mess up the indentation in these cases. Can > > > > > you try to fix that? > > > > > > > > If condition isn

Re: [Intel-gfx] [PATCH 09/15] drm/i915: Add NV12 support to intel_framebuffer_init

2015-09-21 Thread Konduru, Chandra
> > > > + if (mode_cmd->modifier[1] == I915_FORMAT_MOD_Y_TILED > > && > > > > + ((mode_cmd->offsets[1] / mode_cmd->pitches[1]) % > > 4)) { > > > > + DRM_DEBUG("tile-Y uv offset 0x%x isn't 4-line > > aligned\n", > > > > +

Re: [Intel-gfx] [PATCH 09/15] drm/i915: Add NV12 support to intel_framebuffer_init

2015-09-30 Thread Konduru, Chandra
> > @@ -14241,6 +14241,7 @@ static int intel_framebuffer_init(struct > drm_device *dev, > > { > > unsigned int aligned_height; > > int ret; > > + int i; > > u32 pitch_limit, stride_alignment; > > > > WARN_ON(!mutex_is_locked(&dev->struct_mutex)); > > @@ -14255,7 +14256,8 @@ stati

Re: [Intel-gfx] [PATCH 09/15] drm/i915: Add NV12 support to intel_framebuffer_init

2015-10-01 Thread Konduru, Chandra
> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Thursday, October 01, 2015 4:41 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Syrjala, Ville > Subject: Re: [Intel-gfx] [PATCH 09/15] drm/i915: A

Re: [Intel-gfx] [PATCH v3] i-g-t: Adding test case to test background color.

2015-04-14 Thread Konduru, Chandra
> -Original Message- > From: Thomas Wood [mailto:thomas.w...@intel.com] > Sent: Tuesday, April 14, 2015 10:02 AM > To: Konduru, Chandra > Cc: Intel Graphics Development > Subject: Re: [Intel-gfx] [PATCH v3] i-g-t: Adding test case to test background > color. >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Switch to full atomic helpers for plane updates/disable, take two

2015-04-14 Thread Konduru, Chandra
> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Matt Roper > Sent: Thursday, April 09, 2015 11:04 AM > To: Daniel Vetter > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915: Switch to full atomic help

Re: [Intel-gfx] [PATCH 13/14] drm/i915: skylake primary plane scaling using shared scalers

2015-04-15 Thread Konduru, Chandra
triggered by 90/270. -Chandra > -Original Message- > From: Konduru, Chandra > Sent: Wednesday, April 15, 2015 3:15 PM > To: intel-gfx@lists.freedesktop.org > Cc: Konduru, Chandra; Jindal, Sonika; Roper, Matthew D; Vetter, Daniel; > Conselvan De Oliveira, Ander > Subje

Re: [Intel-gfx] [PATCH] drm/i915/skl: Bypass debug message if scalers are not requested

2015-04-24 Thread Konduru, Chandra
> -Original Message- > From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] > Sent: Friday, April 24, 2015 9:08 AM > To: Intel-gfx@lists.freedesktop.org > Cc: Ursulin, Tvrtko; Konduru, Chandra > Subject: [PATCH] drm/i915/skl: Bypass debug message if scalers a

Re: [Intel-gfx] [PATCH] drm/i915/skl: Bypass debug message if scalers are not requested

2015-04-24 Thread Konduru, Chandra
> -Original Message- > From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] > Sent: Friday, April 24, 2015 9:34 AM > To: Konduru, Chandra; Intel-gfx@lists.freedesktop.org > Cc: Ursulin, Tvrtko > Subject: Re: [PATCH] drm/i915/skl: Bypass debug message

Re: [Intel-gfx] [PATCH] drm/i915/skl: Bypass debug message if scalers are not requested

2015-04-24 Thread Konduru, Chandra
> -Original Message- > From: Konduru, Chandra > Sent: Friday, April 24, 2015 10:53 AM > To: 'Tvrtko Ursulin'; Intel-gfx@lists.freedesktop.org > Cc: Ursulin, Tvrtko > Subject: RE: [PATCH] drm/i915/skl: Bypass debug message if scalers are not > requested >

Re: [Intel-gfx] [PATCH 13/14] drm/i915: skylake primary plane scaling using shared scalers

2015-04-26 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Thursday, April 23, 2015 1:20 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: R

Re: [Intel-gfx] [PATCH v9] drm/i915/skl: Add support for SKL background color

2015-04-27 Thread Konduru, Chandra
> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Monday, April 27, 2015 8:28 AM > On Fri, Feb 20, 2015 at 04:11:33PM -0800, Chandra Konduru wrote: > > This patch adds support for Skylake display pipe background color. > > + Background color in 16bp

Re: [Intel-gfx] [PATCH 13/14] drm/i915: skylake primary plane scaling using shared scalers

2015-04-29 Thread Konduru, Chandra
> -Original Message- > From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > Sent: Wednesday, April 29, 2015 5:13 AM > To: Konduru, Chandra; intel-gfx@lists.freedesktop.org; Roper, Matthew D > Cc: Vetter, Daniel; Conselvan De Oliveira, Ander > Subject: Re: [Intel-gfx]

Re: [Intel-gfx] [PATCH] drm/i915: Adding dbuf support for skl nv12 format.

2015-05-04 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Monday, May 04, 2015 8:01 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Syrjala, Ville > Subject: Re: [Intel-gfx] [PATCH] drm

Re: [Intel-gfx] [PATCH i-g-t 4/4] kms_plane_scaling: Find the image regardless how the test is run

2015-05-05 Thread Konduru, Chandra
> -Original Message- > From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] > Sent: Tuesday, May 05, 2015 2:53 AM > To: Intel-gfx@lists.freedesktop.org > Cc: Ursulin, Tvrtko; Konduru, Chandra; Wood, Thomas > Subject: [PATCH i-g-t 4/4] kms_plane_scaling: Find th

Re: [Intel-gfx] [PATCH i-g-t 4/4] kms_plane_scaling: Find the image regardless how the test is run

2015-05-06 Thread Konduru, Chandra
> -Original Message- > From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] > Sent: Wednesday, May 06, 2015 2:29 AM > To: Konduru, Chandra; Intel-gfx@lists.freedesktop.org > Cc: Ursulin, Tvrtko; Wood, Thomas > Subject: Re: [PATCH i-g-t 4/4] kms_plane_scali

Re: [Intel-gfx] [PATCH i-g-t 3/4] igt_kms: Do not reset plane position on assigning a fb

2015-05-06 Thread Konduru, Chandra
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c index b5ba273..0665d70 100644 > --- a/lib/igt_kms.c > +++ b/lib/igt_kms.c > @@ -1765,9 +1765,7 @@ void igt_plane_set_fb(igt_plane_t *plane, struct > igt_fb *fb) > plane->fb = fb; > /* hack to keep tests working that don't call igt_plane_set_

Re: [Intel-gfx] [PATCH v2 i-g-t 1/4] igt_kms: Avoid NULL ptr deref when commiting disabled planes

2015-05-06 Thread Konduru, Chandra
> -Original Message- > From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] > Sent: Tuesday, May 05, 2015 2:53 AM > To: Intel-gfx@lists.freedesktop.org > Cc: Ursulin, Tvrtko; Konduru, Chandra; Wood, Thomas > Subject: [PATCH v2 i-g-t 1/4] igt_kms: Avoid N

Re: [Intel-gfx] [PATCH i-g-t 2/4] igt_kms: Merge condition in igt_plane_set_fb

2015-05-06 Thread Konduru, Chandra
> @@ -1765,14 +1765,6 @@ void igt_plane_set_fb(igt_plane_t *plane, struct > igt_fb *fb) > plane->fb = fb; > /* hack to keep tests working that don't call igt_plane_set_size() */ > if (fb) { > - plane->crtc_w = fb->width; > - plane->crtc_h = fb->height; >

Re: [Intel-gfx] [i915]] *ERROR* mismatch in scaler_state.scaler_id

2015-05-06 Thread Konduru, Chandra
..@vger.kernel.org; Konduru, Chandra > Subject: Re: [i915]] *ERROR* mismatch in scaler_state.scaler_id > > Adding Chandra, who's implemented skl scaler code. > -Daniel > > On Sat, May 02, 2015 at 10:05:42AM +0900, Sergey Senozhatsky wrote: > > Hi, > > > > linux

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Update compute_baseline_bpp for NV12.

2015-05-07 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Wednesday, May 06, 2015 11:59 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Syrjala, Ville > Subject: Re: [Intel-gfx] [PAT

  1   2   >