intel_ddi_init(dev_priv, PORT_E);
> -
> - if (IS_CNL_WITH_PORT_F(dev_priv))
> - intel_ddi_init(dev_priv, PORT_F);
> + intel_ddi_init(dev_priv, PORT_E);
Whoops, not PORT_E, but I guess you noticed. :)
> } else if (HAS_DDI(dev_priv)) {
> u32 found;
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
hile it
> isn't let's keep it consistent everywhere
I agree with this.
Reviewed-by: Jani Nikula
>
> Signed-off-by: Lucas De Marchi
> Reviewed-by: Anusha Srivatsa
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 38 +++-
> 1 file changed, 13 inse
;
> +static bool skip_broken_vbt(struct drm_i915_private *i915, enum port port)
The idea of the patch seems good to me, but I'll nitpick on the naming.
I suggest calling this positively is_port_valid() or something like
that.
With that,
Reviewed-by: Jani Nikula
&g
On Tue, 27 Apr 2021, Rodrigo Vivi wrote:
> On Tue, Apr 27, 2021 at 02:45:20PM +0300, Jani Nikula wrote:
>> Add separate intel_dp_hdcp.h to go with intel_dp_hdcp.c, and rename the
>> init function intel_dp_hdcp_init() to follow naming where function
>> prefix matches the fil
+ /** Engine for which command streamer cycles is queried. */
> + struct i915_engine_class_instance engine;
> +
> + /** Must be zero. */
> + __u32 flags;
> +
> + /**
> + * Command streamer cycles as read from the command streamer
> + * register at 0x358 off
On Tue, 27 Apr 2021, Ville Syrjälä wrote:
> On Tue, Apr 27, 2021 at 03:03:15PM +0300, Jani Nikula wrote:
>> The definitions are in the crtc and dpll files; move the declarations to
>> the corresponding headers.
>>
>> Signed-off-by: Jani Nikula
>
> Reviewed-by:
v1 after the RFC [1]. Use intel_backlight first, fall back to unique
names for subsequent backlight devices.
BR,
Jani.
[1] http://lore.kernel.org/r/20210407090812.3602-1-jani.nik...@intel.com
Cc: Ville Syrjälä
Jani Nikula (2):
drm/i915/backlight: clean up backlight device register
drm
Add connector and backlight device name to logging, and propagate error
code from backlight_device_register() instead of flattening to
-ENODEV. Storing the name in an allocated buffer is unnecessary here,
but makes follow-up work on names much cleaner.
Cc: Ville Syrjälä
Signed-off-by: Jani
https://gitlab.freedesktop.org/drm/intel/-/issues/2794
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_panel.c | 23 ++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c
b/drivers/gpu/drm/i915/display/intel_panel.c
On Wed, 07 Apr 2021, Ville Syrjälä wrote:
> On Wed, Apr 07, 2021 at 12:08:12PM +0300, Jani Nikula wrote:
>> Change the backlight device names from intel_backlight to
>> card%d-%s-backlight format, for example card0-eDP-1-backlight, to make
>> them unique. Otherwise, registeri
On Wed, 28 Apr 2021, Ville Syrjälä wrote:
> On Wed, Apr 28, 2021 at 01:14:29PM +0300, Jani Nikula wrote:
>> Registering multiple backlight devices with intel_backlight name will
>> obviously fail, regardless of whether they're two connectors in the same
>> drm device or
order. Fortunately just
> pulling intel_de.h out from intel_display_types.h seems to have been
> sufficient to make it build.
This is something I've been meaning to fix independently. Thanks.
Reviewed-by: Jani Nikula
>
> This little cocci script did most of the work for me:
> @find@
Do I still have to file a bug report or
> will this patch eventually find its way upstream?
That's in Linus' upstream now, but not in any release yet.
Imre, Ville, should we ask for a Cc: stable?
BR,
Jani.
>
> Thanks
> Mario
>
> On Mon, 2021-04-26 at 17:47 +030
longer as
>>the field will be moved into the struct's legacy section. Add a fix
>>for the rsp commit.
>
> Commit message match the patch.
>
> Reviewed-by: Michael J. Ruhl
> M
>
>>v2:
>> * fix an error in the commit description (Michael)
>>
>&g
> gvt-next-fixes-2021-04-29
>
> - Fix possible divide error in vgpu display rate calculation (Colin)
>
>
> Colin Xu (1):
> drm/i915/gvt: Prevent divided by zero when calculating refresh rate
>
> drivers/gpu/drm/i915/g
On Thu, 29 Apr 2021, Ville Syrjälä wrote:
> On Thu, Apr 29, 2021 at 11:11:25AM +0300, Jani Nikula wrote:
>> On Thu, 29 Apr 2021, Ville Syrjala wrote:
>> > From: Ville Syrjälä
>> >
>> > We lost the i915_reg_rw tracepoint for a lot of display registers
>&g
patch, with a benign looking subject, and none of
the i915 maintainers in Cc. Not cool.
BR,
Jani.
> ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, &i915->drm,
> -&intel_dp->aux, 16, 3, conn_base_id);
> +
t; radeon_dp_mst_init(struct radeon_connector *radeon_connector)
>> {
>> struct drm_device *dev = radeon_connector->base.dev;
>> + int max_link_rate;
>>
>> if (!radeon_connector->ddc_bus->has_aux)
>> return 0;
te calculation
Colin Xu (1):
drm/i915/gvt: Prevent divided by zero when calculating refresh rate
Jani Nikula (1):
Merge tag 'gvt-next-fixes-2021-04-29' of
https://github.com/intel/gvt-linux into drm-intel-next-fixes
drivers/gpu/drm/i915/gvt/handl
On Fri, 30 Apr 2021, Jani Nikula wrote:
> On Thu, 29 Apr 2021, Lyude Paul wrote:
>> JFYI Jani and Ben: I will be pushing this patch to drm-misc-next sometime
>> today if there's no objections
>
> Thanks for the heads-up, I think this breaks i915. See my review
> com
On Mon, 03 May 2021, Jani Nikula wrote:
> On Fri, 30 Apr 2021, Jani Nikula wrote:
>> On Thu, 29 Apr 2021, Lyude Paul wrote:
>>> JFYI Jani and Ben: I will be pushing this patch to drm-misc-next sometime
>>> today if there's no objections
>>
>> Thank
CC all the maintainers.
The drivers we have are monsters, and it can be tricky to get the
details right. All the more important to get the Cc's right; then at
least you can blame us afterwards. ;)
Thanks for reacting quickly, though.
BR,
Jani.
--
Jani Nikula,
;link rate DPCD code' with 'link rate in kHz' when used with
> drm_dp_mst_topology_mgr_init()
> - Add/remove related DPCD code conversion from/to kHz where applicable
>
> Signed-off-by: Nikola Cornij
LGTM,
Acked-by: Jani Nikula
for merging via drm-misc-next where
2] & DP_PCON_SOURCE_CTL_MODE) ||
> + if (!(intel_dp->downstream_ports[2] & DP_PCON_SOURCE_CTL_MODE) ||
> !intel_dp_is_hdmi_2_1_sink(intel_dp) ||
> intel_dp->frl.is_trained)
> return;
--
Jani Nikula, Intel Open Source Graphics Center
dcoded name must be used
> unless the DRM layer exposes a macro for converting a DRM driver name
> to its associated fbdev driver name.
>
> Signed-off-by: Janusz Krzysztofik
LGTM, Daniel?
Reviewed-by: Jani Nikula
$ dim fixes 7a0f9ef9703d
Fixes: 7a0f9ef9703d ("drm/i915: Use drm_fb_
(dev_priv, LCPLL_CTL,
> + LCPLL_CD_SOURCE_FCLK, 0);
These are one of those cases where I wonder about that
if (val != old)
intel_uncore_write(uncore, reg, val);
check in intel_uncore_rmw().
I guess it's fine, but I get that uneasy feeling.
R
On Fri, 30 Apr 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> A few easy cleanups to the cdclk code.
On the series,
Reviewed-by: Jani Nikula
>
> Ville Syrjälä (5):
> drm/i915: Extract some helpers to compute cdclk register values
> drm/i915: Use intel_
"intel_de.h"
> |
> #include "display/intel_de.h"
> )
>
> @depends on find && !has_include@
> @@
> + #include "intel_de.h"
> #include "intel_display_types.h"
>
> @depends on find && !has_include@
> @@
> + #include &qu
*/
> css_header = (struct intel_css_header *)fw->data;
> - r = parse_csr_fw_css(csr, css_header, fw->size);
> + r = parse_csr_fw_css(dev_priv, css_header, fw->size);
> if (!r)
> return;
>
> @@ -615,7 +617,7 @@ static void parse_csr_fw(struct drm_i915_private
> *dev_priv,
>
> /* Extract Package Header information */
> package_header = (struct intel_package_header *)&fw->data[readcount];
> - r = parse_csr_fw_package(csr, package_header, si, fw->size - readcount);
> + r = parse_csr_fw_package(dev_priv, package_header, si, fw->size -
> readcount);
> if (!r)
> return;
>
> @@ -623,7 +625,7 @@ static void parse_csr_fw(struct drm_i915_private
> *dev_priv,
>
> /* Extract dmc_header information */
> dmc_header = (struct intel_dmc_header_base *)&fw->data[readcount];
> - parse_csr_fw_dmc(csr, dmc_header, fw->size - readcount);
> + parse_csr_fw_dmc(dev_priv, dmc_header, fw->size - readcount);
> }
>
> static void intel_csr_runtime_pm_get(struct drm_i915_private *dev_priv)
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> void (*read_luts)(struct intel_crtc_state *crtc_state);
> };
>
> -struct intel_csr {
> - struct work_struct work;
> - const char *fw_path;
> - u32 required_version;
> - u32 max_fw_size; /* bytes */
> - u32 *dmc_pay
m/i915/display/intel_display_power.c| 16 ++--
> drivers/gpu/drm/i915/i915_drv.h | 18 +---
> drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
> 6 files changed, 92 insertions(+), 75 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
Found these forgotten in a branch...
Jani Nikula (2):
drm/i915/audio: simplify, don't mask out in all branches
drm/i915/audio: fix indentation, remove extra braces
drivers/gpu/drm/i915/display/intel_audio.c | 27 --
1 file changed, 10 insertions(+), 17 dele
Lift the masking outside of the if branches. No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_audio.c | 23 --
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_audio.c
b/drivers/gpu/drm
Cleanup the code. No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_audio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_audio.c
b/drivers/gpu/drm/i915/display/intel_audio.c
index 60083431228c
On Tue, 04 May 2021, Ville Syrjälä wrote:
> On Tue, May 04, 2021 at 11:14:01AM +0300, Jani Nikula wrote:
>> Cleanup the code. No functional changes.
>>
>> Signed-off-by: Jani Nikula
>
> for the series
> Reviewed-by: Ville Syrjälä
Thanks, pushed.
BR,
Jani.
--
On Tue, 04 May 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Replace the open coded drm_mode_is_420_only() with the real thing.
>
> No functional changes.
>
> Cc: Werner Sembach
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> dr
t; multiple platforms.
One of the most wanted refactoring series I've seen in a while!
I haven't reviewed it, but I've glanced through it all. Almost started
nitpicking about some function naming early on, but realized they were
made static later in the series. Overall looked lik
Minimal change to nuke the static buf.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_debugfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_debugfs.c
index c77326a7d058..95813e21ae02
On Mon, 07 Jan 2019, Aditya Swarup wrote:
> On Mon, Dec 31, 2018 at 11:03:22AM +0200, Jani Nikula wrote:
>> On Fri, 14 Dec 2018, Aditya Swarup wrote:
>> > CNL macros for register groups CNL_PORT_TX_DW2_* / CNL_PORT_TX_DW5_* are
>> > configured incorrectly wrt defini
drmP.h is deprecated and no longer needed.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gvt/dmabuf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/dmabuf.c
b/drivers/gpu/drm/i915/gvt/dmabuf.c
index 51ed99a37803..2eb681175fae 100644
--- a/drivers/gpu/drm
Needs just a few additional includes here and there.
Cc: Sam Ravnborg
Cc: Daniel Vetter
Cc: Laurent Pinchart
Acked-by: Daniel Vetter
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/dvo.h | 1 -
drivers/gpu/drm/i915/i915_drv.c| 1 -
drivers/gpu/drm/i915
On Mon, 07 Jan 2019, Chris Wilson wrote:
> Quoting Jani Nikula (2019-01-07 14:51:49)
>> Minimal change to nuke the static buf.
>>
>> Signed-off-by: Jani Nikula
>
> I'm sure there's a grander plan,
Thanks for the review, pushed before you realize there migh
vebox
0360 l O .rodata0028 sub_op_mfx_vc
03c0 l O .rodata0020 sub_op_3d_media
0400 l O .rodata0010 sub_op_2d
0430 l O .rodata0010 sub_op_mi
Signed-off-by:
It doesn't need to be changed, make it const. The string literals should
anyway be referred to as const data.
The following gets moved to rodata section:
0080 l O .rodata1c00 cmd_info
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gvt/cmd_parser.c
bug.cgi?id=108840
> [fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
> [fdo#109225]: https://bugs.freedesktop.org/show_bug.cgi?id=109225
> [fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241
> [fdo#109244]: https://bugs.freedesktop.org/show_bug.
---
> Zhenyu Wang (1):
> drm/i915/gvt: Fix workload request allocation before request add
>
> drivers/gpu/drm/i915/gvt/scheduler.c | 64
> +++-
> drivers/gpu/drm/i915/gvt/scheduler.h | 1 +
>
On Thu, 27 Dec 2018, Jani Nikula wrote:
> DRM_DEBUG() was intended to be used by the drm core code only, but we
> weren't careful. Today, the driver usage of DRM_DEBUG() trumps drm core
> usage about 10:1. It's easier to swith the core over to a new
> DRM_DEBUG_CORE() macro
all engines
Jani Nikula (1):
Merge tag 'gvt-fixes-2019-01-09' of https://github.com/intel/gvt-linux
into drm-intel-fixes
José Roberto de Souza (2):
drm/i915: Disable PSR in Apple panels
drm: Fix documentation generation for DP_DPCD_QUIRK_NO_PSR
Zhenyu Wang (1):
ly by port/pipe/transcoder.->(dw, port)
>
> Cc: Clint Taylor
> Cc: Imre Deak
> Cc: Jani Nikula
> Signed-off-by: Aditya Swarup
Pushed to dinq with the appropriate Fixes: tag added, thanks for the
patch.
> ---
> There are still inconsistencies in some macro definitions. The
;> ___
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
always show? I normally would send a patch myself but since I'm not
> familiar with this code, I'd rather not shoot in the dark :) especially
> since it's for a trivial logging statement.
Fixed by fed85691b408 ("drm/i915: Fix the static code analysis warning
in debugfs
I
> expect.
>
> v3: Rebase on top of atomic bochs.
>
> Cc: Sam Ravnborg
> Cc: Jani Nikula
> Cc: Laurent Pinchart
> Acked-by: Rodrigo Vivi (v2)
> Acked-by: Benjamin Gaignard (v2)
> Signed-off-by: Daniel Vetter
> Cc: linux-arm-ker...@lists.infradead.org
> Cc:
rivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
> index d7a414ce2774..bd5536f0ec92 100644
> --- a/drivers/gpu/drm/i915/intel_tv.c
> +++ b/drivers/gpu/drm/i915/intel_tv.c
> @@ -869,7 +869,7 @@ intel_tv_get_config(struct intel_encoder *encoder,
> pipe_config->b
ater.
After most of these have landed, I intend to drop PREFER_KERNEL_TYPES
from the checkpatch ignore list, and enforce.
BR,
Jani.
Jani Nikula (17):
drm/i915: small isolated c99 types to kernel types switch
drm/i915/crt: switch to kernel types
drm/i915/sdvo: switch to kernel types
drm
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_crt.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gp
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_sdvo.c | 78 +++
1 file changed, 39 insertions(+), 39 deletions(-)
diff --git a/d
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Minor checkpatch fixes sprinkled on top of the changed lines.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_gem.c| 14 +++---
drivers/gp
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_lspcon.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gp
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_debugfs.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gp
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Minor checkpatch fixes sprinkled on top of the changed lines.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_csr.c | 68
1 fi
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_ddi.c | 52
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/d
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Minor checkpatch/whitespace fixes sprinkled on top of the changed lines.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dpll_m
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_irq.c | 82 -
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/d
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 104 +--
1 file changed, 52 insertions(+), 52 deletions(-)
diff --git a/d
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_sprite.c | 60 ++---
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/d
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Minor checkpatch fixes sprinkled on top of the changed lines.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_pm.c | 213
1 fi
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_color.c | 40 +++---
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/d
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_cdclk.c | 40 +++---
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/d
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Minor checkpatch fixes sprinkled on top of the changed lines.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_drv.h | 94
1 fi
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Minor checkpatch/whitespace fixes sprinkled on top of the changed lines.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dp.c
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 158
1 file changed, 79 insertions(+), 79 deletions(-)
diff --git a/d
On Wed, 16 Jan 2019, Ville Syrjälä wrote:
> On Wed, Jan 16, 2019 at 11:15:18AM +0200, Jani Nikula wrote:
>> Hi all -
>>
>> I haven't cared all that much about using C99 fixed size types (uint32_t
>> etc.) in the driver in addition to kernel types, as long as onl
| 30 ++++++
> drivers/gpu/drm/i915/gvt/mpt.h | 2 +-
> 4 files changed, 29 insertions(+), 6 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
es (2019-01-17 11:49:51 +0200)
drm/i915/gvt fixes for v5.0-rc3
Colin Xu (1):
drm/i915/gvt: Allow F_CMD_ACCESS on mmio 0x21f0
Hang Yuan (1):
drm/i915/gvt: free VFIO region spac
nt, I noticed a clash with regmap.h
REG_FIELD() and, since it all looked pretty verbose anyway, decided to
see if local _BIT(), _MASK(), and _FIELD() would stick.
BR,
Jani.
[1] http://mid.mail-archive.com/cover.1538582156.git.jani.nikula@intel.com
Jani Nikula (4):
drm/i915/dp: remove PANEL_POWER_OFF
It's superfluous.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_reg.h | 1 -
drivers/gpu/drm/i915/intel_dp.c | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 9a1340cfda6c..93cbd05
fits the mask (when the
value is a constant expression).
v2:
- add build-time checks with BUILD_BUG_ON_ZERO()
- rename to just _FIELD() due to regmap.h REG_FIELD() clash
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Michal Wajdeczko
Cc: Mika Kuoppala
Signed-off-by: Jani Nikula
---
drivers/gpu
verbose than simply shifting in place, but it
does provide masking to ensure we don't overflow the mask, something we
usually don't bother with currently.
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Michal Wajdeczko
Cc: Mika Kuoppala
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/
-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_reg.h | 83 -
1 file changed, 50 insertions(+), 33 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 93cbd057c07a..b6cc06b42c1a 100644
--- a/drivers/gpu/drm/i915
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Acked-by: Chris Wilson
Acked-by: Tvrtko Ursulin
Reviewed-by: Ville Syrjälä
Reviewed-by: José Roberto de Souza
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/int
o de Souza
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_pm.c | 213
1 file changed, 105 insertions(+), 108 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 7613ae72df3d..8b63afa3a221 100644
--- a/drivers/gp
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Acked-by: Chris Wilson
Acked-by: Tvrtko Ursulin
Reviewed-by: Ville Syrjälä
Reviewed-by: José Roberto de Souza
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
v2: rebase
Acked-by: Chris Wilson
Acked-by: Tvrtko Ursulin
Reviewed-by: Ville Syrjälä
Reviewed-by: José Roberto de Souza
Signed-off-by: Jani Nikula
---
drivers/gp
-by: Ville Syrjälä
Reviewed-by: José Roberto de Souza
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_csr.c | 68
1 file changed, 34 insertions(+), 34 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_c
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Acked-by: Chris Wilson
Acked-by: Tvrtko Ursulin
Reviewed-by: Ville Syrjälä
Reviewed-by: José Roberto de Souza
Signed-off-by: Jani Nikula
---
drivers/gp
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Reviewed-by: Chris Wilson
Acked-by: Tvrtko Ursulin
Reviewed-by: Ville Syrjälä
Reviewed-by: José Roberto de Souza
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/
o de Souza
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_drv.h | 94
1 file changed, 46 insertions(+), 48 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index e5a436c33307..33b733d37706 100644
--- a/drivers/gp
On Thu, 17 Jan 2019, Mika Kuoppala wrote:
> Jani Nikula writes:
>
>> It's superfluous.
>
> One could argue that it has a minor documentative purpose.
> But there is comment for that.
>
> Reviewed-by: Mika Kuoppala
Thanks, pushed this one.
BR,
Jani.
&g
On Fri, 18 Jan 2019, Jani Nikula wrote:
> Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
>
> sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
>
> v2: rebase
>
> Acked-by: Chris Wilson
> Acked-by: Tvrtko Ursulin
> Reviewed-by: Ville Sy
Mixed C99 and kernel types use is getting ugly. Prefer kernel types.
sed -i 's/\buint\(8\|16\|32\|64\)_t\b/u\1/g'
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gvt/cmd_parser.c | 14 +++---
drivers/gpu/drm/i915/gvt/handlers.c | 6 +++---
drivers/gpu/drm/i915/g
We have a wrapper for a reason.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_dp_helper.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 26835d174939..4def0bface85 100644
--- a/drivers/gpu
makes it slightly easier for the uninitiated to figure out which
platforms actually have what.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 37 ++--
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
Now that intel_lvds_init() is only called for platforms that might have
LVDS, move the remaining checks to intel_setup_outputs(), again similar
to other outputs, and remove the overlapping checks.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 6 --
drivers/gpu/drm
r the uninitiated to figure out which
platforms actually have what.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_disp
Clarify that the name is specific to PCH platforms.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 6960004fdc94
have what.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 4207ee0b83ce..6960004fdc94 100644
--- a/drivers/gpu/drm/i915
makes it slightly easier for the uninitiated to figure out which
platforms actually have what.
v2: keep gen >= 9 check in intel_ddi_crt_present() (Ville)
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 34
1 file chan
The VBT int_crt_support can't be trusted on earlier platforms, and is
always set to true in intel_bios.c for pre-DDI and pre-VLV platforms. We
can simplify the output setup by unconditionally calling
intel_crt_init() for these platforms.
Suggested-by: Ville Syrjälä
Signed-off-by: Jani N
have what.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index db0f15242ccf..8e89f04ddd9c 100644
On Mon, 21 Jan 2019, Ville Syrjälä wrote:
> On Mon, Jan 21, 2019 at 04:21:32PM +0200, Jani Nikula wrote:
>> Now that intel_lvds_init() is only called for platforms that might have
>> LVDS, move the remaining checks to intel_setup_outputs(), again similar
>> to other ou
1001 - 1100 of 17407 matches
Mail list logo
