On Tue, 08 Dec 2020, Thomas Zimmermann wrote:
> ping for a review of the i915 patches
What did you have in mind regarding merging the series? Should we just
pick the patches up?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
In
On Tue, 08 Dec 2020, "Navare, Manasi" wrote:
> On Tue, Dec 08, 2020 at 02:33:54PM +0200, Jani Nikula wrote:
>> The VBT fields match the DPCD data, so use the same helper.
>>
>> Cc: Manasi Navare
>> Cc: Vandita Kulkarni
>> Signed-off-by: Jani Nikula
On Thu, 10 Dec 2020, Ville Syrjälä wrote:
> On Thu, Dec 10, 2020 at 02:17:50PM +1000, Dave Airlie wrote:
>> From: Dave Airlie
>>
>> This file is a monster, let's start simple, the cursor plane code
>> seems pretty standalone, and splits out easily enough.
>>
>> Signed-off-by: Dave Airlie
>> --
PM_REQ_DBG_0 _MMIO(0x45284)
> +#define PM_REQ_DBG_1 _MMIO(0x45288)
> +#define PM_RSP_DBG_0 _MMIO(0x4528C)
> +#define PM_RSP_DBG_1 _MMIO(0x45290)
> +
> #define GEN6_MBCTL _MMIO(0x0907c)
> #define GEN6_MBCTL_ENABLE_BOOT_FETCH (1 << 4)
> #define GEN6_MBCTL_CTX_FETCH_NEEDED(1 << 3)
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#66: FILE: drivers/gpu/drm/i915/i915_reg.h:375:
> +#define PM_REQ_DBG_1 ^I^I_MMIO(0x45288)$
>
> -:67: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
> #67: FILE: drivers/gpu/drm/i915/i915_reg.h:376:
> +#define PM_RSP_DBG_0 ^I^I_MMIO(0x4528C)$
>
> -:68: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
> #68: FILE: drivers/gpu/drm/i915/i915_reg.h:377:
> +#define PM_RSP_DBG_1 ^I^I_MMIO(0x45290)$
>
> total: 15 errors, 19 warnings, 4 checks, 47 lines checked
>
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
of(ctx->id));
> +
> + mutex_init(&ctx->mutex);
> +}
> +
> +/**
> + * intel_pxp_ctx_fini - To finish the pxp context.
> + * @ctx: pointer to ctx structure.
> + */
> +void intel_pxp_ctx_fini(struct pxp_context *ctx)
> +{
> + ctx->id = 0;
> +}
> diff --g
ic inline void intel_pxp_uninit(struct intel_pxp *pxp)
> {
> }
> +
> +static inline int intel_pxp_reg_read(struct intel_pxp *pxp, u32 offset, u32
> *regval)
> +{
> + return 0;
> +}
> #endif
>
> #endif /* __INTEL_PXP_PM_H__ */
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ubart
Do we need the author lines? I'd prefer phasing them all out, because
it'll be stale almost immediately after merging. Also, it's just 40
lines of definitions.
BR,
Jani.
> + */
> +
> +#ifndef _I915_PXP_TEE_INTERFACE_H_
> +#define _I915_PXP_TEE_INTERFACE_H_
> +
> +#include
> +#include
> +
> +/**
> + * struct i915_pxp_component_ops - ops for PXP services.
> + * @owner: Module providing the ops
> + * @send: sends data to PXP
> + * @receive: receives data from PXP
> + */
> +struct i915_pxp_component_ops {
> + /**
> + * @owner: owner of the module provding the ops
> + */
> + struct module *owner;
> +
> + int (*send)(struct device *dev, const void *message, size_t size);
> + int (*receive)(struct device *dev, void *buffer, size_t size);
> +};
> +
> +/**
> + * struct i915_pxp_component_master - Used for communication between i915
> + * and TEE drivers for the PXP services
> + * @tee_dev: device that provide the PXP service from TEE Bus.
> + * @pxp_ops: Ops implemented by TEE driver, used by i915 driver.
> + */
> +struct i915_pxp_comp_master {
> + struct device *tee_dev;
> + const struct i915_pxp_component_ops *ops;
> +
> + /* To protect the above members. */
> + struct mutex mutex;
> +};
> +
> +#endif /* _I915_TEE_PXP_INTERFACE_H_ */
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
gine_pm_get)
> + intel_engine_pm_put(ce->engine);
> +
> + return err;
> +}
> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_cmd.h
> b/drivers/gpu/drm/i915/pxp/intel_pxp_cmd.h
> new file mode 100644
> index ..d04463962421
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_cmd.h
> @@ -0,0 +1,18 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright(c) 2020, Intel Corporation. All rights reserved.
> + */
> +
> +#ifndef __INTEL_PXP_CMD_H__
> +#define __INTEL_PXP_CMD_H__
> +
> +#include "gt/intel_gt_buffer_pool.h"
> +#include "intel_pxp.h"
> +
> +struct i915_vma *intel_pxp_cmd_get_batch(struct intel_pxp *pxp,
> + struct intel_context *ce,
> + struct intel_gt_buffer_pool_node *pool,
> + u32 *cmd_buf, int cmd_size_in_dw);
> +
> +int intel_pxp_cmd_submit(struct intel_pxp *pxp, u32 *cmd, int
> cmd_size_in_dw);
> +#endif /* __INTEL_PXP_SM_H__ */
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
gt; +
> +static inline int i915_pxp_teardown_required_callback(struct intel_pxp *pxp)
> +{
> + return 0;
> +}
> +
> +static inline int i915_pxp_global_terminate_complete_callback(struct
> intel_pxp *pxp)
> +{
> + return 0;
> +}
> +
&
On Thu, 10 Dec 2020, Ville Syrjälä wrote:
> On Thu, Dec 10, 2020 at 08:25:49PM +0100, Thomas Gleixner wrote:
>> Nothing uses the result and nothing should ever use it in driver code.
>>
>> Signed-off-by: Thomas Gleixner
>> Cc: Jani Nikula
>> Cc: Joonas Lah
ch is a lot and
> postprocessing can easily deal with the occasional wraparound.
I'll let Tvrtko and Chris review the substance here, but assuming they
don't object,
Acked-by: Jani Nikula
for merging via whichever tree makes most sense.
>
> Signed-off-by: Thomas Gleixner
> C
mailing list
>> dri-de...@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
= false;
> - with_pps_lock(intel_dp, wakeref)
> - is_enabled = ilk_get_pp_control(intel_dp) & EDP_BLC_ENABLE;
> + wakeref = pch_pps_lock(intel_dp);
> + is_enabled = ilk_get_pp_control(intel_dp) & EDP_BLC_ENABLE;
> + pch_pps_unlock(intel_dp, wakeref);
> +
> if (is_enabled == enable)
> return;
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
anges during runtime. So, let's simplify things by just caching
> this value in intel_panel.backlight, and re-writing it as-needed.
This isn't a full review, just something I spotted so far. Please see
inline.
BR,
Jani.
>
> Signed-off-by: Lyude Paul
> Cc: Jani Nikula
. Again, not a full review yet, just a
few notes below.
>
> Signed-off-by: Lyude Paul
> Cc: Jani Nikula
> Cc: Dave Airlie
> Cc: greg.depo...@gmail.com
> ---
> drivers/gpu/drm/drm_dp_helper.c | 332 ++
> .../drm/i915/display/inte
On Fri, 11 Dec 2020, Gwan-gyeong Mun wrote:
> It is a preliminary work for supporting multiple EDP PSR and
> DP PanelReplay. And it refactors singleton PSR to Multi Transcoder
> supportable PSR.
> And this moves and renames the i915_psr structure of drm_i915_private's to
> intel_dp's intel_psr str
'S_IRUGO' to using of octal
>> permissions '0444'
>> v5: Addressed JJani Nikula's review comments
>> - Remove checking of Gen12 for i915_psr_status.
>> - Add check of HAS_PSR()
>> - Remove meaningless check routine.
>>
>> Sig
On Fri, 11 Dec 2020, Dave Airlie wrote:
> From: Dave Airlie
>
> There may be more crtc code that can be pulled out, but this
> is a good start.
>
> RFC: maybe call the new file something different
I checked this is just code movement. I did clean up intel_crtc.h
locally a bit though. (I'll proba
On Fri, 11 Dec 2020, Dave Airlie wrote:
> From: Dave Airlie
>
> This file is a monster, let's start simple, the cursor plane code
> seems pretty standalone, and splits out easily enough.
I cleaned up intel_cursor.h a bit locally, but the code movement checks
out.
BR,
Jani.
>
> Reviewed-by: Vil
On Fri, 11 Dec 2020, Dave Airlie wrote:
> From: Dave Airlie
>
> This pulls a large chunk of the pll calculation code out of
> intel_display.c to a new file.
>
> One function makse sense to be an inline, otherwise this
> is pretty much a straight copy cover. also all the
> remaining hooks for g45
On Fri, 11 Dec 2020, Dave Airlie wrote:
> From: Dave Airlie
>
> This just refactors out the fdi code to a separate file.
LGTM, save for another header fix that I made locally. ;)
See CONFIG_DRM_I915_WERROR=y for what we do in CI to keep stuff clean.
BR,
Jani.
>
> Signed-off-by: Dave Airlie
>
intel_de_posting_read(dev_priv, DP_TP_CTL(PORT_E));
> +
> + intel_wait_ddi_buf_idle(dev_priv, PORT_E);
> +
> + /* Reset FDI_RX_MISC pwrdn lanes */
> + temp = intel_de_read(dev_priv, FDI_RX_MISC(PIPE_A));
> +
This is Dave's intel_display.c refactoring series [1] with some minor
issues addressed, to get CI results among other things.
I've reviewed and fixed any remaining minor issues I spotted in patches
1-8. I'm aware there may be things to improve, but I think this is
overall forward progress and clea
From: Dave Airlie
This function is going to be used in a later change, so clean it
up first before moving it.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 78 +--
.../drm/i915/display
From: Dave Airlie
This will be used for some refactoring in other files, so move it
first.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 6 --
drivers/gpu/drm/i915/display/intel_display_types.h
From: Dave Airlie
There is no need for a comma use here.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display
From: Dave Airlie
This file is a monster, let's start simple, the cursor plane code
seems pretty standalone, and splits out easily enough.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_cursor.h a bit.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
From: Dave Airlie
There may be more crtc code that can be pulled out, but this
is a good start.
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_crtc.h a bit.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile| 1 +
drivers/gpu/drm/i915/display/intel_crtc.c
Airlie
[Jani: cleaned up intel_dpll.h a bit, de-duped intel_panel_use_ssc().]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile |1 +
drivers/gpu/drm/i915/display/intel_display.c | 1402 +
drivers/gpu/drm/i915/display/intel_display.h |3
From: Dave Airlie
This just refactors out the fdi code to a separate file.
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_fdi.h a bit.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/intel_display.c | 685
From: Dave Airlie
Daniel asked for this, but it's a bit messy and I'm not sure
how best to clean it up yet.
Signed-off-by: Dave Airlie
[Jani: also moved fdi buf trans to intel_fdi.c.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_crt.c | 1 +
drivers/gp
From: Dave Airlie
Daniel suggested this should move here.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_crtc.c | 230
drivers/gpu/drm/i915/display/intel_sprite.c | 228 ---
2 files changed, 230 insertions
From: Dave Airlie
This just cleans these up a bit.
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_gen9_plane.c | 4 ++--
drivers/gpu/drm/i915/display/intel_sprite.c | 7 +++
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a
On Wed, 16 Dec 2020, Ville Syrjälä wrote:
> On Wed, Dec 16, 2020 at 12:03:37PM +0200, Jani Nikula wrote:
>> On Fri, 11 Dec 2020, Dave Airlie wrote:
>> > From: Dave Airlie
>> >
>> > There may be more crtc code that can be pulled out, but this
>> > i
>
>>Fixes: ("drm/i915/tgl: Fix stepping WA matching")
>>Cc: José Roberto de Souza
>>Cc: Matt Roper
>>Cc: Lucas De Marchi
>>Cc: Jani Nikula
>>Cc: Ville Syrjälä
>>Signed-off-by: Aditya Swarup
>>Reviewed-by: Lucas De Marchi
>>---
&
On Fri, 18 Dec 2020, Jani Nikula wrote:
> On Thu, 17 Dec 2020, Lucas De Marchi wrote:
>> Both patches applied. Thanks!
>>
>> Jani, maybe now you can rebase your patch to get rid of the extern ?
>
> Yes, thanks for the irq so I can stop polling. ;)
Huh, why were th
+-
drivers/gpu/drm/i915/i915_drv.h| 12 ++--
drivers/gpu/drm/i915/i915_irq.c| 27 ++
drivers/gpu/drm/i915/i915_perf.c | 2 +-
4 files changed, 23 insertions(+), 20 deletions(-)
--
Jani Nikula, Intel Ope
On Fri, 18 Dec 2020, Lucas De Marchi wrote:
> On Fri, Dec 18, 2020 at 01:13:49PM +0200, Jani Nikula wrote:
>>On Fri, 18 Dec 2020, Jani Nikula wrote:
>>> On Thu, 17 Dec 2020, Lucas De Marchi wrote:
>>>> Both patches applied. Thanks!
>>>>
>>>>
_
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
From: Dave Airlie
This function is going to be used in a later change, so clean it
up first before moving it.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 78 +--
.../drm/i915/display
From: Dave Airlie
This will be used for some refactoring in other files, so move it
first.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 6 --
drivers/gpu/drm/i915/display/intel_display_types.h
From: Dave Airlie
There is no need for a comma use here.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display
From: Dave Airlie
This file is a monster, let's start simple, the cursor plane code
seems pretty standalone, and splits out easily enough.
Reviewed-by: Ville Syrjälä
Signed-off-by: Dave Airlie
[Jani: cleaned up intel_cursor.h a bit.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm
From: Dave Airlie
Ville suggested this as a good idea, let's move this before moving
the crtc code.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/i915/Makefile| 3 +-
drivers/gpu/drm/i915/display/i9xx_plane.c| 704 +++
drivers/
From: Dave Airlie
Ville suggested this as a good idea, let's move this before moving
the crtc code.
Signed-off-by: Dave Airlie
Reviewed-by: Ville Syrjälä
[Jani: fixed i915xx_plane.h standalone build.]
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile
figured it out, and thanks for letting us know!
> By the way, an EDID emulator is a small USB-stick-sized device that sits
> in between computer and monitor and acts like a monitor when the actual
> monitor is off.
Ah, thanks for the info.
BR,
Ja
l planes code no long moves any scaler code.
>
> Some more ppl moving code, and a piece of forgotten i9xx plane moved.
>
> Dave.
>
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedeskt
e to a separate file.
BR,
Jani.
Jani Nikula (13):
drm/i915/pps: abstract panel power sequencer from intel_dp.c
drm/i915/pps: rename pps_{,un}lock -> intel_pps_{,un}lock
drm/i915/pps: rename intel_edp_backlight_* to intel_pps_backlight_*
drm/i915/pps: rename intel_edp_panel_* to int
Start following the usual naming pattern for functions.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 20 ++--
drivers/gpu/drm/i915/display/intel_pps.c | 21 +++--
drivers/gpu/drm/i915/display/intel_pps.h | 8
3 files changed
Follow the usual naming pattern for functions.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 6 +++---
drivers/gpu/drm/i915/display/intel_pps.c | 10 +-
drivers/gpu/drm/i915/display/intel_pps.h | 6 +++---
3 files changed, 11 insertions(+), 11 deletions
Follow the usual naming pattern for functions. We don't need to repeat
"panel" here.
Follow the usual naming pattern for functions.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_ddi.c | 8
drivers/gpu/drm/i915/display/intel_dp.c | 10 +-
Add a locked version of intel_pps_vdd_off_sync_unlocked() that does
everything the callers expect it to.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 31 +++-
drivers/gpu/drm/i915/display/intel_pps.c | 17 -
drivers/gpu/drm/i915
Add a new init call to be called only once, unlike some of the other
various init calls. This lets us hide more functions within intel_pps.c.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 9 +
drivers/gpu/drm/i915/display/intel_pps.c | 17
Follow the usual naming pattern for functions.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
drivers/gpu/drm/i915/display/intel_pps.c | 2 +-
drivers/gpu/drm/i915/display/intel_pps.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
Follow the usual naming pattern for functions. "reset all" because it
iterates over all DP encoders.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_power.c | 4 ++--
drivers/gpu/drm/i915/display/intel_pps.c | 5 ++---
drivers/gpu/drm/i915/display/i
Prefer keeping the unlocked variants hidden if possible.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 7 +--
drivers/gpu/drm/i915/display/intel_pps.c | 13 -
drivers/gpu/drm/i915/display/intel_pps.h | 3 +--
3 files changed, 14 insertions(+), 9
Add a "reinit" call to hide some more pps functions, and clean up the
callers. A minor functional change is not holding the pps lock across
the whole operation in intel_dp_encoder_reset, but instead doing it in
two steps.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/
This function is a bit of an outlier, but try to change to a name that
is more in line with the rest of the intel_pps functions.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
drivers/gpu/drm/i915/display/intel_pps.c | 4 ++--
drivers/gpu/drm/i915/display
Split out the DP aux functionality to a new intel_dp_aux.[ch]. This is a
surprisingly clean cut.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 676 +--
drivers/gpu/drm/i915/display/intel_dp_aux.c
In a long overdue refactoring, split out all panel sequencer code from
intel_dp.c to new intel_pps.[ch].
The first part is mostly just code movement as-is, without cleanups.
We need to add a vlv_get_dpll() helper to get at the vlv/chv dpll from
pps code.
Signed-off-by: Jani Nikula
---
drivers
Follow the usual naming pattern for functions, both for the prefix and
the _unlocked suffix for functions that expect the lock to be held when
calling.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 +++
drivers/gpu/drm/i915/display/intel_pps.c | 26
s/gpu/drm/i915/display/intel_hdmi.c | 233 +++
> drivers/gpu/drm/i915/display/intel_hdmi.h | 7 +
> include/drm/drm_connector.h | 49 ++
> include/drm/drm_dp_helper.h | 218 +++
> include/drm/drm_edid.h| 30 +
> 11 files changed, 1652 insertions(+), 19 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> +
> +
>
> -:155: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
> #155: FILE: drivers/gpu/drm/i915/display/intel_dp.c:4251:
> + bits_per_pixel = intel_dp_pcon_dsc_enc_bpp(intel_dp, crtc_state,
> + num_slices, slice_width);
>
> tota
+++
drivers/gpu/drm/i915/display/intel_hdmi.h | 7 +
include/drm/drm_connector.h| 49 ++
include/drm/drm_dp_helper.h| 218
include/drm/drm_edid.h | 30 ++
11 files changed, 1650 insertions(+), 19
irt(dev_priv);
> break;
> }
> }
> @@ -246,8 +254,14 @@ void intel_detect_pch(struct drm_i915_private *dev_priv)
> dev_priv->pch_id = 0;
> }
>
> - if (!pch)
> - drm_dbg_kms(&dev_priv->drm, "No PCH found.\n"
On Wed, 23 Dec 2020, "Sharma, Swati2" wrote:
> On 23-Dec-20 12:24 PM, Shankar, Uma wrote:
>>
>>
>>> -Original Message-
>>> From: Nautiyal, Ankit K
>>> Sent: Wednesday, December 23, 2020 11:27 AM
>>> To: Jani
o this one belongs in topic/dp-hdmi-2.1-pcon branch.
Purely based on the context this is the right thing to do, so:
Reviewed-by: Jani Nikula
Ankit, please test the patch in case it uncovers some other
issues. It'll impact the RGB to YCbCr conversion.
BR,
Jani.
>
> Fixes: 522508
| 2 +-
> drivers/gpu/drm/i915/i915_params.c | 2 +-
> include/drm/drm_dp_helper.h | 21 +-
> 12 files changed, 655 insertions(+), 359 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
};
>
> -static const struct intel_panel_bl_funcs vlv_funcs = {
> +static const struct intel_panel_bl_funcs vlv_pwm_funcs = {
> .setup = vlv_setup_backlight,
> .enable = vlv_enable_backlight,
> .disable = vlv_disable_backlight,
> @@ -2077,7 +2102,7 @@ static const str
ntel_dp_aux_init_backlight_funcs(struct intel_connector
> *intel_connector)
> +int intel_dp_aux_init_backlight_funcs(struct intel_connector *connector)
> {
> - struct intel_panel *panel = &intel_connector->panel;
> - struct intel_dp *intel_dp = enc_to_intel_dp(inte
break;
> + case INTEL_DP_AUX_BACKLIGHT_ON:
> + if (i915->vbt.backlight.type !=
> INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE)
> + try_intel_interface = true;
This could use an explanation - why not try the intel interfac
On Mon, 28 Dec 2020, "Gupta, Anshuman" wrote:
>> -Original Message-
>> From: Intel-gfx On Behalf Of Jani
>> Nikula
>> Sent: Tuesday, December 22, 2020 8:20 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Nikula, Jani
>> Subject: [I
>> gvt-next-fixes-2020-12-25
>>
>> - Avoid one useless inline (Jani)
>> - make gvt header self-contained, fix CONFIG_DRM_I915_WERROR (Jani)
>>
>>
>> Jani Nikula (9):
>> drm/i915/gvt: avoid useless use of inline
1-rc2 on TGL DSI? Should we pick this up
for fixes?
BR,
Jani.
[1]
https://intel-gfx-ci.01.org/tree/drm-intel-fixes/CI_DIF_538/fi-tgl-dsi/igt@gem_exec_susp...@basic-s0.html
>
> Cc: Vandita Kulkarni
> Cc: Jani Nikula
> Signed-off-by: Imre Deak
> ---
> drivers/gpu/drm/i915/d
ertions(+), 29 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
28)
>
> +#define PM_REQ_DBG_0 _MMIO(0x45284)
> +#define PM_REQ_DBG_1 _MMIO(0x45288)
> +#define PM_RSP_DBG_0 _MMIO(0x4528C)
> +#define PM_RSP_DBG_1 _MMIO(0x45290)
> +#define MASK_RSP_0 (0x << 16)
> +#define MASK_RSP_1
P)
> diff --git a/drivers/gpu/drm/i915/intel_pch.c
> b/drivers/gpu/drm/i915/intel_pch.c
> index f31c0dabd0cc..c1bc2d032360 100644
> --- a/drivers/gpu/drm/i915/intel_pch.c
> +++ b/drivers/gpu/drm/i915/intel_pch.c
> @@ -121,7 +121,8 @@ intel_pch_type(const struct d
by vlv and chv display power domain.
>
> This will avoids the unnecessary noise of unrelated power wells
> in pps_{lock,unlock}.
>
> Cc: Jani Nikula
> Cc: Imre Deak
> Signed-off-by: Anshuman Gupta
Imre convinced me yesterday on irc that this should work.
Reviewed-by: Jani Nikula
On Tue, 29 Dec 2020, Anshuman Gupta wrote:
> On 2020-12-22 at 20:19:49 +0530, Jani Nikula wrote:
>> Follow the usual naming pattern for functions.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>> drive
d to be a high level modeset init function, and basically
anything doing direct register access here is at a completely wrong
abstraction layer. Please fix.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing
i-2.1-pcon branch has been merged to
drm-next and backmerged to drm-intel-next. So drm-intel-next is where
the fixes should now land.
BR,
Jani.
>
>
> Thanks & Regards,
>
> Ankit
>
>
> On 12/23/2020 4:21 PM, Jani Nikula wrote:
>> On Wed, 23 Dec 2020, Chris Wilson
On Thu, 07 Jan 2021, Daniel Vetter wrote:
> On Wed, Dec 23, 2020 at 10:14:58AM +0200, Jani Nikula wrote:
>>
>> Hi Maarten, Maxime, and Thomas -
>>
>> Here's the DP-HDMI2.1 PCON support topic pull consisting of the series
>> [1]. The series is split roughly
WM value to PCH override register */
> - lpt_set_backlight(connector->base.state,
> panel->backlight.level);
> + lpt_set_backlight(connector->base.state, val);
> intel_de_write(dev_priv, BLC_PWM_PCH_CTL1,
> pch_ctl1 | BLM_PCH_OVERRIDE_ENABLE);
>
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
keover on LPT, v3.")
Cc: Maarten Lankhorst
Cc: Ville Syrjälä
Cc: Lyude Paul
Cc: # v5.1+
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_panel.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c
On Fri, 08 Jan 2021, Imre Deak wrote:
> On Fri, Jan 08, 2021 at 11:38:04AM +0200, Jani Nikula wrote:
>> On Thu, 07 Jan 2021, Anshuman Gupta wrote:
>> > We need a power_domain wakeref in pps_{lock,unlock} to prevent
>> > a race while resetting pps state in
This is v2 of [1], with comments from Anshuman addressed, and a few additional
patches at the end.
BR,
Jani.
[1] https://patchwork.freedesktop.org/series/85167/
Jani Nikula (17):
drm/i915/pps: abstract panel power sequencer from intel_dp.c
drm/i915/pps: rename pps_{,un}lock -> intel_p
.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile |1 +
drivers/gpu/drm/i915/display/intel_ddi.c |1 +
.../drm/i915/display/intel_display_power.c|2 +-
drivers/gpu/drm/i915/display/intel_dp.c | 1436 +
drivers/gpu/drm/i915/display
Start following the usual naming pattern for functions. No functional
changes.
Reviewed-by: Anshuman Gupta
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 20 ++--
drivers/gpu/drm/i915/display/intel_pps.c | 21 +++--
drivers/gpu/drm
Follow the usual naming pattern for functions. No functional changes.
Reviewed-by: Anshuman Gupta
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 6 +++---
drivers/gpu/drm/i915/display/intel_pps.c | 10 +-
drivers/gpu/drm/i915/display/intel_pps.h | 6
On Mon, 04 Jan 2021, Jani Nikula wrote:
> On Mon, 28 Dec 2020, "Gupta, Anshuman" wrote:
>>> -Original Message-
>>> From: Intel-gfx On Behalf Of Jani
>>> Nikula
>>> Sent: Tuesday, December 22, 2020 8:20 PM
>>> To: intel-gfx@lists
Follow the usual naming pattern for functions. We don't need to repeat
"panel" here. No functional changes.
v2: Fix comment (Anshuman)
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_ddi.c | 8
drivers/gpu/drm/i915/display/intel_dp.c | 10 +---
Follow the usual naming pattern for functions, both for the prefix and
the _unlocked suffix for functions that expect the lock to be held when
calling. No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 +++
drivers/gpu/drm/i915
Add a locked version of intel_pps_vdd_off_sync_unlocked() that does
everything the callers expect it to. No functional changes.
v2: Fix typo (Anshuman)
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 31 +++-
drivers/gpu/drm/i915/display
Add a new init call to be called only once, unlike some of the other
various init calls. This lets us hide more functions within
intel_pps.c. No functional changes.
Reviewed-by: Anshuman Gupta
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 9 +
drivers/gpu
or clarity
Reviewed-by: Anshuman Gupta
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 20 +---
drivers/gpu/drm/i915/display/intel_pps.c | 21 +++--
drivers/gpu/drm/i915/display/intel_pps.h | 3 +--
3 files changed, 25 insertions(+), 19
Follow the usual naming pattern for functions. No functional changes.
Reviewed-by: Anshuman Gupta
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
drivers/gpu/drm/i915/display/intel_pps.c | 2 +-
drivers/gpu/drm/i915/display/intel_pps.h | 2 +-
3 files changed, 3
Follow the usual naming pattern for functions. "reset all" because it
iterates over all DP encoders. No functional changes.
Reviewed-by: Anshuman Gupta
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_power.c | 4 ++--
drivers/gpu/drm/i915/display/i
Prefer keeping the unlocked variants hidden if possible. No functional
changes.
Reviewed-by: Anshuman Gupta
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 7 +--
drivers/gpu/drm/i915/display/intel_pps.c | 13 -
drivers/gpu/drm/i915/display
This function is a bit of an outlier, but try to change to a name that
is more in line with the rest of the intel_pps functions. No functional
changes.
Reviewed-by: Anshuman Gupta
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
drivers/gpu/drm/i915/display
1 - 100 of 17405 matches
Mail list logo
