On Thu, 16 Jul 2020, Matt Roper <matthew.d.ro...@intel.com> wrote:
> @@ -17903,6 +17904,13 @@ int intel_modeset_init(struct drm_i915_private *i915)
>       if (i915->max_cdclk_freq == 0)
>               intel_update_max_cdclk(i915);
>  
> +     /*
> +      * If the platform has HTI, we need to find out whether it has reserved
> +      * any display resources before we create our display outputs.
> +      */
> +     if (INTEL_INFO(i915)->display.has_hti)
> +             i915->hti_state = intel_de_read(i915, HDPORT_STATE);
> +

Just stumbled upon this in code.

This is supposed to be a high level modeset init function, and basically
anything doing direct register access here is at a completely wrong
abstraction layer. Please fix.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to