Re: [Intel-gfx] [PATCH 04/11] drm/i915: Support for GuC interrupts

2016-06-30 Thread Goel, Akash
On 6/28/2016 7:14 PM, Tvrtko Ursulin wrote: On 28/06/16 12:12, Goel, Akash wrote: On 6/28/2016 3:33 PM, Tvrtko Ursulin wrote: On 27/06/16 13:16, akash.g...@intel.com wrote: From: Sagar Arun Kamble There are certain types of interrupts which Host can recieve from GuC. GuC ukernel sends

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Support for GuC interrupts

2016-07-01 Thread Goel, Akash
On 7/1/2016 2:17 PM, Tvrtko Ursulin wrote: On 01/07/16 07:16, Goel, Akash wrote: [snip] +/* Process all the GuC to Host events in bottom half */ +gen6_disable_pm_irq(dev_priv, +GEN9_GUC_TO_HOST_INT_EVENT); Why it is important to disable the

Re: [Intel-gfx] [PATCH 05/14] drm/i915: Handle log buffer flush interrupt event from GuC

2016-07-03 Thread Goel, Akash
On 7/3/2016 2:45 PM, Chris Wilson wrote: On Sun, Jul 03, 2016 at 12:21:22AM +0530, akash.g...@intel.com wrote: +static void guc_read_update_log_buffer(struct drm_device *dev, bool capture_all) +{ + struct drm_i915_private *dev_priv = dev->dev_private; + struct intel_guc *guc = &de

Re: [Intel-gfx] [PATCH 05/14] drm/i915: Handle log buffer flush interrupt event from GuC

2016-07-03 Thread Goel, Akash
On 7/3/2016 5:51 PM, Goel, Akash wrote: On 7/3/2016 2:45 PM, Chris Wilson wrote: On Sun, Jul 03, 2016 at 12:21:22AM +0530, akash.g...@intel.com wrote: +static void guc_read_update_log_buffer(struct drm_device *dev, bool capture_all) +{ +struct drm_i915_private *dev_priv = dev

Re: [Intel-gfx] [PATCH 13/14] drm/i915: Add stats for GuC log buffer flush interrupts

2016-07-03 Thread Goel, Akash
On 7/3/2016 3:14 PM, Chris Wilson wrote: On Sun, Jul 03, 2016 at 12:21:30AM +0530, akash.g...@intel.com wrote: From: Akash Goel GuC firmware sends an interrupt to flush the log buffer when it becomes half full. GuC firmware also tracks how many times the buffer overflowed. It would be useful

Re: [Intel-gfx] [PATCH 03/14] drm/i915: Add low level set of routines for programming PM IER/IIR/IMR register set

2016-07-03 Thread Goel, Akash
On 7/3/2016 3:08 PM, Chris Wilson wrote: On Sun, Jul 03, 2016 at 12:21:20AM +0530, akash.g...@intel.com wrote: From: Akash Goel So far PM IER/IIR/IMR registers were being used only for Turbo related interrupts. But interrupts coming from GuC also use the same set. As a precursor to supportin

Re: [Intel-gfx] [PATCH 01/17] drm/i915: Decouple GuC log setup from verbosity parameter

2016-07-11 Thread Goel, Akash
On 7/11/2016 3:07 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble b/drivers/gpu/drm/i915/i915_guc_submission.c index 2112e02..8a9a0cb 100644 --- a/drivers/gpu/drm/i915/i915_guc_submission.c +++ b/drivers/gpu/drm/i915/i915_guc_submission.c @@

Re: [Intel-gfx] [PATCH 01/17] drm/i915: Decouple GuC log setup from verbosity parameter

2016-07-11 Thread Goel, Akash
On 7/11/2016 5:20 PM, Tvrtko Ursulin wrote: On 11/07/16 12:41, Goel, Akash wrote: On 7/11/2016 3:07 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble b/drivers/gpu/drm/i915/i915_guc_submission.c index 2112e02..8a9a0cb 100644 --- a/drivers

Re: [Intel-gfx] [PATCH 05/17] drm/i915: Support for GuC interrupts

2016-07-11 Thread Goel, Akash
On 7/11/2016 4:00 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble There are certain types of interrupts which Host can recieve from GuC. GuC ukernel sends an interrupt to Host for certain events, like for example retrieve/consume the logs gen

Re: [Intel-gfx] [PATCH 05/17] drm/i915: Support for GuC interrupts

2016-07-11 Thread Goel, Akash
On 7/11/2016 6:53 PM, Tvrtko Ursulin wrote: On 11/07/16 14:15, Goel, Akash wrote: On 7/11/2016 4:00 PM, Tvrtko Ursulin wrote: +static void gen9_guc_irq_handler(struct drm_i915_private *dev_priv, u32 gt_iir) +{ +if (gt_iir & GEN9_GUC_TO_HOST_INT_EVENT) { +spin_lock(&

Re: [Intel-gfx] [PATCH 05/17] drm/i915: Support for GuC interrupts

2016-07-11 Thread Goel, Akash
On 7/11/2016 7:13 PM, Tvrtko Ursulin wrote: On 11/07/16 14:38, Goel, Akash wrote: On 7/11/2016 6:53 PM, Tvrtko Ursulin wrote: On 11/07/16 14:15, Goel, Akash wrote: On 7/11/2016 4:00 PM, Tvrtko Ursulin wrote: +static void gen9_guc_irq_handler(struct drm_i915_private *dev_priv, u32

Re: [Intel-gfx] [PATCH 15/17] drm/i915: Increase GuC log buffer size to reduce flush interrupts

2016-07-15 Thread Goel, Akash
On 7/15/2016 5:27 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel In cases where GuC generate logs at a very high rate, correspondingly the rate of flush interrupts is also very high. So far total 8 pages were allocated for storing both ISR & DPC lo

Re: [Intel-gfx] [PATCH 10/17] drm/i915: New module param to control the size of buffer used for storing GuC firmware logs

2016-07-15 Thread Goel, Akash
On 7/15/2016 4:45 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel On recieving the log buffer flush interrupt from GuC firmware, Driver stores the snapshot of the log buffer in a local buffer, from which Userspace can pull the logs. By default Drive

Re: [Intel-gfx] [PATCH 13/17] drm/i915: New lock to serialize the Host2GuC actions

2016-07-15 Thread Goel, Akash
On 7/15/2016 5:10 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel With the addition of new Host2GuC actions related to GuC logging, there is a need of a lock to serialize them, as they can execute concurrently with each other and also with other exi

Re: [Intel-gfx] [PATCH 14/17] drm/i915: Add stats for GuC log buffer flush interrupts

2016-07-15 Thread Goel, Akash
On 7/15/2016 5:21 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel GuC firmware sends an interrupt to flush the log buffer when it becomes half full. GuC firmware also tracks how many times the buffer overflowed. It would be useful to maintain a stat

Re: [Intel-gfx] [PATCH 15/17] drm/i915: Increase GuC log buffer size to reduce flush interrupts

2016-07-15 Thread Goel, Akash
On 7/15/2016 8:37 PM, Tvrtko Ursulin wrote: On 15/07/16 15:42, Goel, Akash wrote: On 7/15/2016 5:27 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel In cases where GuC generate logs at a very high rate, correspondingly the rate of flush

Re: [Intel-gfx] [PATCH 11/17] drm/i915: Support to create write combined type vmaps

2016-07-15 Thread Goel, Akash
On 7/15/2016 5:01 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Chris Wilson vmaps has a provision for controlling the page protection bits, with which we can use to control the mapping type, e.g. WB, WC, UC or even WT. To allow the caller to choose their ma

Re: [Intel-gfx] [PATCH 13/17] drm/i915: New lock to serialize the Host2GuC actions

2016-07-18 Thread Goel, Akash
On 7/18/2016 3:42 PM, Tvrtko Ursulin wrote: On 15/07/16 16:51, Goel, Akash wrote: On 7/15/2016 5:10 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel With the addition of new Host2GuC actions related to GuC logging, there is a need of a lock to

Re: [Intel-gfx] [PATCH 14/17] drm/i915: Add stats for GuC log buffer flush interrupts

2016-07-18 Thread Goel, Akash
On 7/18/2016 3:46 PM, Tvrtko Ursulin wrote: On 15/07/16 16:58, Goel, Akash wrote: On 7/15/2016 5:21 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel GuC firmware sends an interrupt to flush the log buffer when it becomes half full. GuC firmware

Re: [Intel-gfx] [PATCH 13/17] drm/i915: New lock to serialize the Host2GuC actions

2016-07-18 Thread Goel, Akash
On 7/18/2016 4:48 PM, Tvrtko Ursulin wrote: On 18/07/16 11:46, Goel, Akash wrote: On 7/18/2016 3:42 PM, Tvrtko Ursulin wrote: On 15/07/16 16:51, Goel, Akash wrote: On 7/15/2016 5:10 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel With the

Re: [Intel-gfx] [PATCH 14/17] drm/i915: Add stats for GuC log buffer flush interrupts

2016-07-18 Thread Goel, Akash
On 7/18/2016 5:03 PM, Tvrtko Ursulin wrote: On 18/07/16 11:59, Goel, Akash wrote: On 7/18/2016 3:46 PM, Tvrtko Ursulin wrote: On 15/07/16 16:58, Goel, Akash wrote: On 7/15/2016 5:21 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel GuC firmware

Re: [Intel-gfx] [PATCH 10/17] drm/i915: New module param to control the size of buffer used for storing GuC firmware logs

2016-07-18 Thread Goel, Akash
On 7/18/2016 3:36 PM, Tvrtko Ursulin wrote: On 15/07/16 16:36, Goel, Akash wrote: On 7/15/2016 4:45 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel On recieving the log buffer flush interrupt from GuC firmware, Driver stores the snapshot of the

Re: [Intel-gfx] [PATCH 15/17] drm/i915: Increase GuC log buffer size to reduce flush interrupts

2016-07-18 Thread Goel, Akash
On 7/18/2016 3:24 PM, Tvrtko Ursulin wrote: On 15/07/16 17:20, Goel, Akash wrote: On 7/15/2016 8:37 PM, Tvrtko Ursulin wrote: On 15/07/16 15:42, Goel, Akash wrote: On 7/15/2016 5:27 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel In cases

Re: [Intel-gfx] [PATCH 10/17] drm/i915: New module param to control the size of buffer used for storing GuC firmware logs

2016-07-18 Thread Goel, Akash
On 7/18/2016 6:36 PM, Tvrtko Ursulin wrote: On 18/07/16 13:19, Goel, Akash wrote: On 7/18/2016 3:36 PM, Tvrtko Ursulin wrote: On 15/07/16 16:36, Goel, Akash wrote: On 7/15/2016 4:45 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel On recieving

Re: [Intel-gfx] [PATCH 06/17] drm/i915: Handle log buffer flush interrupt event from GuC

2016-07-19 Thread Goel, Akash
On 7/19/2016 4:28 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble GuC ukernel sends an interrupt to Host to flush the log buffer and expects Host to correspondingly update the read pointer information in the state structure, once it has consu

Re: [Intel-gfx] [PATCH 07/17] drm/i915: Add a relay backed debugfs interface for capturing GuC logs

2016-07-19 Thread Goel, Akash
On 7/19/2016 5:01 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel Added a new debugfs interface '/sys/kernel/debug/dri/guc_log' for the User to capture GuC firmware logs. Availed relay framework to implement the interface, where Driver will have to

Re: [Intel-gfx] [PATCH 08/17] drm/i915: Forcefully flush GuC log buffer on reset

2016-07-19 Thread Goel, Akash
On 7/19/2016 4:51 PM, Chris Wilson wrote: On Tue, Jul 19, 2016 at 12:12:20PM +0100, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble If GuC logs are being captured, there should be a force log buffer flush action sent to GuC before proceeding wit

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-19 Thread Goel, Akash
On 7/19/2016 4:54 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble This patch provides debugfs interface i915_guc_output_control for on the fly enabling/disabling of logging in GuC firmware and controlling the verbosity level of logs. The valu

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Goel, Akash
On 7/20/2016 2:38 PM, Tvrtko Ursulin wrote: On 20/07/16 05:42, Goel, Akash wrote: On 7/19/2016 4:54 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble This patch provides debugfs interface i915_guc_output_control for on the fly enabling

Re: [Intel-gfx] [PATCH 08/17] drm/i915: Forcefully flush GuC log buffer on reset

2016-07-20 Thread Goel, Akash
On 7/20/2016 2:42 PM, Chris Wilson wrote: On Wed, Jul 20, 2016 at 09:51:45AM +0530, Goel, Akash wrote: On 7/19/2016 4:51 PM, Chris Wilson wrote: On Tue, Jul 19, 2016 at 12:12:20PM +0100, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble If

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Goel, Akash
On 7/20/2016 3:17 PM, Tvrtko Ursulin wrote: On 20/07/16 10:32, Goel, Akash wrote: On 7/20/2016 2:38 PM, Tvrtko Ursulin wrote: On 20/07/16 05:42, Goel, Akash wrote: On 7/19/2016 4:54 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Goel, Akash
On 7/20/2016 4:10 PM, Tvrtko Ursulin wrote: On 20/07/16 11:12, Goel, Akash wrote: On 7/20/2016 3:17 PM, Tvrtko Ursulin wrote: +ret = -EINVAL; +goto end; +} + +intel_runtime_pm_get(dev_priv); +ret = i915_guc_log_control(dev, val); +intel_runtime_pm_put

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Goel, Akash
On 7/20/2016 5:20 PM, Tvrtko Ursulin wrote: On 20/07/16 12:29, Goel, Akash wrote: On 7/20/2016 4:10 PM, Tvrtko Ursulin wrote: On 20/07/16 11:12, Goel, Akash wrote: On 7/20/2016 3:17 PM, Tvrtko Ursulin wrote: +DEFINE_SIMPLE_ATTRIBUTE(i915_guc_log_control_fops, +NULL

Re: [Intel-gfx] [PATCH 17/17] drm/i915: Use rt priority kthread to do GuC log buffer sampling

2016-07-20 Thread Goel, Akash
On 7/21/2016 1:04 AM, Chris Wilson wrote: On Sun, Jul 10, 2016 at 07:11:24PM +0530, akash.g...@intel.com wrote: @@ -1707,8 +1692,8 @@ static void gen9_guc_irq_handler(struct drm_i915_private *dev_priv, u32 gt_iir) I915_READ(SOFT_SCRATCH(15)) & ~msg);

Re: [Intel-gfx] [PATCH 17/17] drm/i915: Use rt priority kthread to do GuC log buffer sampling

2016-07-20 Thread Goel, Akash
On 7/21/2016 11:13 AM, Chris Wilson wrote: On Thu, Jul 21, 2016 at 09:11:42AM +0530, Goel, Akash wrote: On 7/21/2016 1:04 AM, Chris Wilson wrote: In the end, just the silly locking and placement of complete_all() is dangerous. reinit_completion() lacks the barrier to be used like this

Re: [Intel-gfx] [PATCH 06/20] drm/i915: Handle log buffer flush interrupt event from GuC

2016-08-11 Thread Goel, Akash
On 8/12/2016 11:58 AM, Chris Wilson wrote: On Fri, Aug 12, 2016 at 11:55:09AM +0530, akash.g...@intel.com wrote: diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 0fcd1c0..fc2da32 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_dr

Re: [Intel-gfx] [PATCH 06/20] drm/i915: Handle log buffer flush interrupt event from GuC

2016-08-12 Thread Goel, Akash
On 8/12/2016 12:21 PM, Chris Wilson wrote: On Fri, Aug 12, 2016 at 12:14:28PM +0530, Goel, Akash wrote: On 8/12/2016 11:58 AM, Chris Wilson wrote: On Fri, Aug 12, 2016 at 11:55:09AM +0530, akash.g...@intel.com wrote: diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 14/20] drm/i915: Forcefully flush GuC log buffer on reset

2016-08-12 Thread Goel, Akash
On 8/12/2016 12:03 PM, Chris Wilson wrote: On Fri, Aug 12, 2016 at 11:55:17AM +0530, akash.g...@intel.com wrote: From: Sagar Arun Kamble Before capturing the GuC logs as a part of error state, there should be a force log buffer flush action sent to GuC before proceeding with GPU reset and re

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Support for GuC interrupts

2016-08-12 Thread Goel, Akash
On 8/12/2016 5:24 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Sagar Arun Kamble There are certain types of interrupts which Host can recieve from GuC. GuC ukernel sends an interrupt to Host for certain events, like for example retrieve/consume the logs gen

Re: [Intel-gfx] [PATCH 06/20] drm/i915: Handle log buffer flush interrupt event from GuC

2016-08-12 Thread Goel, Akash
On 8/12/2016 6:47 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Sagar Arun Kamble GuC ukernel sends an interrupt to Host to flush the log buffer and expects Host to correspondingly update the read pointer information in the state structure, once it has consu

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Support for GuC interrupts

2016-08-12 Thread Goel, Akash
On 8/12/2016 7:01 PM, Tvrtko Ursulin wrote: On 12/08/16 14:10, Goel, Akash wrote: On 8/12/2016 5:24 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Sagar Arun Kamble There are certain types of interrupts which Host can recieve from GuC. GuC ukernel sends

Re: [Intel-gfx] [PATCH 11/20] drm/i915: Optimization to reduce the sampling time of GuC log buffer

2016-08-12 Thread Goel, Akash
On 8/12/2016 8:12 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Akash Goel GuC firmware sends an interrupt to flush the log buffer when it becomes half full, so Driver doesn't really need to sample the complete buffer and can just copy only the newly written

Re: [Intel-gfx] [PATCH 10/20] drm/i915: Add stats for GuC log buffer flush interrupts

2016-08-12 Thread Goel, Akash
On 8/12/2016 7:56 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Akash Goel GuC firmware sends an interrupt to flush the log buffer when it becomes half full. GuC firmware also tracks how many times the buffer overflowed. It would be useful to maintain a stat

Re: [Intel-gfx] [PATCH 09/20] drm/i915: New lock to serialize the Host2GuC actions

2016-08-12 Thread Goel, Akash
On 8/12/2016 7:25 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Akash Goel With the addition of new Host2GuC actions related to GuC logging, there is a need of a lock to serialize them, as they can execute concurrently with each other and also with other exi

Re: [Intel-gfx] [PATCH 16/20] drm/i915: Support to create write combined type vmaps

2016-08-12 Thread Goel, Akash
On 8/12/2016 4:19 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Chris Wilson vmaps has a provision for controlling the page protection bits, with which we can use to control the mapping type, e.g. WB, WC, UC or even WT. To allow the caller to choose their ma

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Support for GuC interrupts

2016-08-12 Thread Goel, Akash
On 8/12/2016 8:35 PM, Tvrtko Ursulin wrote: On 12/08/16 15:31, Goel, Akash wrote: On 8/12/2016 7:01 PM, Tvrtko Ursulin wrote: +static void gen9_guc2host_events_work(struct work_struct *work) +{ +struct drm_i915_private *dev_priv = +container_of(work, struct drm_i915_private

Re: [Intel-gfx] [PATCH 13/20] drm/i915: Augment i915 error state to include the dump of GuC log buffer

2016-08-12 Thread Goel, Akash
On 8/12/2016 9:02 PM, Chris Wilson wrote: On Fri, Aug 12, 2016 at 04:20:03PM +0100, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Akash Goel Added the dump of GuC log buffer to i915 error state, as the contents of GuC log buffer would also be useful to determin

Re: [Intel-gfx] [PATCH 13/20] drm/i915: Augment i915 error state to include the dump of GuC log buffer

2016-08-12 Thread Goel, Akash
On 8/12/2016 9:22 PM, Chris Wilson wrote: On Fri, Aug 12, 2016 at 09:16:03PM +0530, Goel, Akash wrote: On 8/12/2016 9:02 PM, Chris Wilson wrote: There's (or will be) a function to dump the error object in a uniform manner. This patch is obsolete. There is a print_error_obj() function

Re: [Intel-gfx] [PATCH 08/20] drm/i915: Add a relay backed debugfs interface for capturing GuC logs

2016-08-12 Thread Goel, Akash
On 8/12/2016 7:23 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Akash Goel Added a new debugfs interface '/sys/kernel/debug/dri/guc_log' for the User to capture GuC firmware logs. Availed relay framework to implement the interface, where Driver will have to

Re: [Intel-gfx] [PATCH 06/20] drm/i915: Handle log buffer flush interrupt event from GuC

2016-08-12 Thread Goel, Akash
On 8/12/2016 7:37 PM, Tvrtko Ursulin wrote: On 12/08/16 14:45, Goel, Akash wrote: On 8/12/2016 6:47 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Sagar Arun Kamble GuC ukernel sends an interrupt to Host to flush the log buffer and expects Host to

Re: [Intel-gfx] [PATCH 20/20] drm/i915: Early creation of relay channel for capturing boot time logs

2016-08-12 Thread Goel, Akash
On 8/12/2016 9:52 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Akash Goel As per the current i915 Driver load sequence, debugfs registration is done at the end and so the relay channel debugfs file is also created after that but the GuC firmware is loaded m

Re: [Intel-gfx] [PATCH 16/20] drm/i915: Support to create write combined type vmaps

2016-08-12 Thread Goel, Akash
On 8/12/2016 8:46 PM, Chris Wilson wrote: On Fri, Aug 12, 2016 at 08:43:58PM +0530, Goel, Akash wrote: On 8/12/2016 4:19 PM, Tvrtko Ursulin wrote: Unreleated and unmentioned change to no guard page. Best to remove IMHO. Can keep the RB in that case. Though its not called out, sorry for

Re: [Intel-gfx] [PATCH 15/20] drm/i915: Debugfs support for GuC logging control

2016-08-12 Thread Goel, Akash
On 8/12/2016 9:27 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Sagar Arun Kamble This patch provides debugfs interface i915_guc_output_control for on the fly enabling/disabling of logging in GuC firmware and controlling the verbosity level of logs. The valu

Re: [Intel-gfx] [PATCH 20/20] drm/i915: Early creation of relay channel for capturing boot time logs

2016-08-15 Thread Goel, Akash
On 8/15/2016 2:50 PM, Tvrtko Ursulin wrote: On 12/08/16 17:31, Goel, Akash wrote: On 8/12/2016 9:52 PM, Tvrtko Ursulin wrote: On 12/08/16 07:25, akash.g...@intel.com wrote: From: Akash Goel As per the current i915 Driver load sequence, debugfs registration is done at the end and so the

Re: [Intel-gfx] [PATCH 06/18] drm/i915: Handle log buffer flush interrupt event from GuC

2016-08-15 Thread Goel, Akash
On 8/15/2016 8:50 PM, Tvrtko Ursulin wrote: On 15/08/16 15:49, akash.g...@intel.com wrote: From: Sagar Arun Kamble GuC ukernel sends an interrupt to Host to flush the log buffer and expects Host to correspondingly update the read pointer information in the state structure, once it has cons

Re: [Intel-gfx] [PATCH 08/18] drm/i915: Add a relay backed debugfs interface for capturing GuC logs

2016-08-15 Thread Goel, Akash
On 8/15/2016 8:59 PM, Tvrtko Ursulin wrote: On 15/08/16 15:49, akash.g...@intel.com wrote: From: Akash Goel Added a new debugfs interface '/sys/kernel/debug/dri/guc_log' for the User to capture GuC firmware logs. Availed relay framework to implement the interface, where Driver will have to

Re: [Intel-gfx] [PATCH 11/18] drm/i915: Optimization to reduce the sampling time of GuC log buffer

2016-08-15 Thread Goel, Akash
On 8/15/2016 9:06 PM, Tvrtko Ursulin wrote: On 15/08/16 15:49, akash.g...@intel.com wrote: From: Akash Goel GuC firmware sends an interrupt to flush the log buffer when it becomes half full, so Driver doesn't really need to sample the complete buffer and can just copy only the newly written

Re: [Intel-gfx] [PATCH 08/18] drm/i915: Add a relay backed debugfs interface for capturing GuC logs

2016-08-15 Thread Goel, Akash
On 8/15/2016 9:42 PM, Chris Wilson wrote: On Mon, Aug 15, 2016 at 05:09:45PM +0100, Chris Wilson wrote: On Mon, Aug 15, 2016 at 08:19:49PM +0530, akash.g...@intel.com wrote: +void i915_guc_register(struct drm_i915_private *dev_priv) +{ + if (!i915.enable_guc_submission) +

Re: [Intel-gfx] [PATCH 06/18] drm/i915: Handle log buffer flush interrupt event from GuC

2016-08-15 Thread Goel, Akash
On 8/15/2016 9:36 PM, Chris Wilson wrote: On Mon, Aug 15, 2016 at 08:19:47PM +0530, akash.g...@intel.com wrote: +static void guc_read_update_log_buffer(struct intel_guc *guc) +{ + struct guc_log_buffer_state *log_buffer_state, *log_buffer_snapshot_state; + struct guc_log_buffer_st

Re: [Intel-gfx] [PATCH 14/18] drm/i915: Forcefully flush GuC log buffer on reset

2016-08-15 Thread Goel, Akash
On 8/15/2016 9:18 PM, Tvrtko Ursulin wrote: On 15/08/16 15:49, akash.g...@intel.com wrote: From: Sagar Arun Kamble Before capturing the GuC logs as a part of error state, there should be a force log buffer flush action sent to GuC before proceeding with GPU reset and re-initializing GUC. Th

Re: [Intel-gfx] [PATCH 06/18] drm/i915: Handle log buffer flush interrupt event from GuC

2016-08-15 Thread Goel, Akash
On 8/15/2016 10:26 PM, Chris Wilson wrote: On Mon, Aug 15, 2016 at 10:16:56PM +0530, Goel, Akash wrote: On 8/15/2016 9:36 PM, Chris Wilson wrote: On Mon, Aug 15, 2016 at 08:19:47PM +0530, akash.g...@intel.com wrote: +static void guc_read_update_log_buffer(struct intel_guc *guc

Re: [Intel-gfx] [PATCH 14/18] drm/i915: Forcefully flush GuC log buffer on reset

2016-08-16 Thread Goel, Akash
On 8/16/2016 2:55 PM, Tvrtko Ursulin wrote: On 16/08/16 06:25, Goel, Akash wrote: On 8/15/2016 9:18 PM, Tvrtko Ursulin wrote: On 15/08/16 15:49, akash.g...@intel.com wrote: From: Sagar Arun Kamble Before capturing the GuC logs as a part of error state, there should be a force log buffer

Re: [Intel-gfx] [PATCH 14/18] drm/i915: Forcefully flush GuC log buffer on reset

2016-08-16 Thread Goel, Akash
On 8/16/2016 4:57 PM, Tvrtko Ursulin wrote: On 15/08/16 15:49, akash.g...@intel.com wrote: From: Sagar Arun Kamble Before capturing the GuC logs as a part of error state, there should be a force log buffer flush action sent to GuC before proceeding with GPU reset and re-initializing GUC. Th

Re: [Intel-gfx] [PATCH 06/19] drm/i915: Handle log buffer flush interrupt event from GuC

2016-08-17 Thread Goel, Akash
On 8/17/2016 4:37 PM, Tvrtko Ursulin wrote: On 17/08/16 11:14, akash.g...@intel.com wrote: From: Sagar Arun Kamble GuC ukernel sends an interrupt to Host to flush the log buffer and expects Host to correspondingly update the read pointer information in the state structure, once it has consu

Re: [Intel-gfx] [PATCH 19/19] drm/i915: Sync against the GuC log buffer flush work item on system suspend

2016-08-17 Thread Goel, Akash
On 8/17/2016 5:11 PM, Chris Wilson wrote: On Wed, Aug 17, 2016 at 12:27:30PM +0100, Tvrtko Ursulin wrote: On 17/08/16 11:14, akash.g...@intel.com wrote: From: Akash Goel The GuC log buffer flush work item does a register access to send the ack to GuC and this work item, if not synced befor

Re: [Intel-gfx] [PATCH 19/19] drm/i915: Sync against the GuC log buffer flush work item on system suspend

2016-08-17 Thread Goel, Akash
On 8/17/2016 6:41 PM, Imre Deak wrote: On ke, 2016-08-17 at 18:15 +0530, Goel, Akash wrote: On 8/17/2016 5:11 PM, Chris Wilson wrote: On Wed, Aug 17, 2016 at 12:27:30PM +0100, Tvrtko Ursulin wrote: On 17/08/16 11:14, akash.g...@intel.com wrote: From: Akash Goel The GuC log buffer flush

Re: [Intel-gfx] [PATCH 19/19] drm/i915: Sync against the GuC log buffer flush work item on system suspend

2016-08-17 Thread Goel, Akash
On 8/17/2016 9:07 PM, Goel, Akash wrote: On 8/17/2016 6:41 PM, Imre Deak wrote: On ke, 2016-08-17 at 18:15 +0530, Goel, Akash wrote: On 8/17/2016 5:11 PM, Chris Wilson wrote: On Wed, Aug 17, 2016 at 12:27:30PM +0100, Tvrtko Ursulin wrote: +int intel_guc_suspend(struct drm_device

Re: [Intel-gfx] [PATCH 19/19] drm/i915: Sync against the GuC log buffer flush work item on system suspend

2016-08-18 Thread Goel, Akash
On 8/18/2016 4:25 PM, Imre Deak wrote: On to, 2016-08-18 at 09:15 +0530, Goel, Akash wrote: On 8/17/2016 9:07 PM, Goel, Akash wrote: On 8/17/2016 6:41 PM, Imre Deak wrote: On ke, 2016-08-17 at 18:15 +0530, Goel, Akash wrote: On 8/17/2016 5:11 PM, Chris Wilson wrote: On Wed, Aug 17

Re: [Intel-gfx] [PATCH 19/19] drm/i915: Sync against the GuC log buffer flush work item on system suspend

2016-08-18 Thread Goel, Akash
On 8/18/2016 6:29 PM, Imre Deak wrote: On to, 2016-08-18 at 16:54 +0530, Goel, Akash wrote: On 8/18/2016 4:25 PM, Imre Deak wrote: On to, 2016-08-18 at 09:15 +0530, Goel, Akash wrote: On 8/17/2016 9:07 PM, Goel, Akash wrote: On 8/17/2016 6:41 PM, Imre Deak wrote: On ke, 2016-08-17 at

Re: [Intel-gfx] [PATCH 19/19] drm/i915: Sync against the GuC log buffer flush work item on system suspend

2016-08-18 Thread Goel, Akash
On 8/18/2016 7:48 PM, Imre Deak wrote: On to, 2016-08-18 at 19:17 +0530, Goel, Akash wrote: [...] Thanks for the inputs. Sorry not familiar with freezable WQ semantics. But after looking at code, this is what I understood :- 1. freezable Workqueues will be frozen before the system suspend

Re: [Intel-gfx] [PATCH 19/19] drm/i915: Sync against the GuC log buffer flush work item on system suspend

2016-08-18 Thread Goel, Akash
On 8/18/2016 8:25 PM, Imre Deak wrote: On to, 2016-08-18 at 20:05 +0530, Goel, Akash wrote: On 8/18/2016 7:48 PM, Imre Deak wrote: On to, 2016-08-18 at 19:17 +0530, Goel, Akash wrote: [...] Thanks for the inputs. Sorry not familiar with freezable WQ semantics. But after looking at code

Re: [Intel-gfx] [PATCH 08/19] drm/i915: Add a relay backed debugfs interface for capturing GuC logs

2016-08-19 Thread Goel, Akash
On 8/19/2016 11:33 PM, Chris Wilson wrote: On Fri, Aug 19, 2016 at 02:13:07PM +0530, akash.g...@intel.com wrote: static void *guc_get_write_buffer(struct intel_guc *guc) { - return NULL; + /* FIXME: Cover the check under a lock ? */ + if (!guc->log.relay_chan) +

Re: [Intel-gfx] [PATCH 17/19] drm/i915: Use SSE4.1 movntdqa based memcpy for sampling GuC log buffer

2016-08-19 Thread Goel, Akash
On 8/19/2016 11:49 PM, Chris Wilson wrote: On Fri, Aug 19, 2016 at 02:13:16PM +0530, akash.g...@intel.com wrote: From: Akash Goel In order to have fast reads from the GuC log buffer, used SSE4.1 movntdqa based memcpy function i915_memcpy_from_wc. GuC log buffer has a WC type vmalloc mapping

Re: [Intel-gfx] [PATCH 14/19] drm/i915: Forcefully flush GuC log buffer on reset

2016-08-19 Thread Goel, Akash
On 8/19/2016 11:40 PM, Chris Wilson wrote: On Fri, Aug 19, 2016 at 02:13:13PM +0530, akash.g...@intel.com wrote: From: Sagar Arun Kamble Before capturing the GuC logs as a part of error state, there should be a force log buffer flush action sent to GuC before proceeding with GPU reset and re

Re: [Intel-gfx] [PATCH 15/19] drm/i915: Debugfs support for GuC logging control

2016-08-19 Thread Goel, Akash
On 8/19/2016 11:48 PM, Chris Wilson wrote: On Fri, Aug 19, 2016 at 02:13:14PM +0530, akash.g...@intel.com wrote: +static int i915_guc_log_control_get(void *data, u64 *val) +{ + struct drm_device *dev = data; + struct drm_i915_private *dev_priv = to_i915(dev); + + if (!dev_pri

Re: [Intel-gfx] [PATCH] tools/intel_guc_logger: Utility for capturing GuC firmware logs in a file

2016-09-06 Thread Goel, Akash
On 9/6/2016 6:47 PM, Tvrtko Ursulin wrote: Hi, On 06/09/16 11:43, akash.g...@intel.com wrote: From: Akash Goel This patch provides a test utility which helps capture GuC firmware logs and then dump them to file. The logs are pulled from a debugfs file '/sys/kernel/debug/dri/guc_log' and st

Re: [Intel-gfx] [PATCH] tools/intel_guc_logger: Utility for capturing GuC firmware logs in a file

2016-09-07 Thread Goel, Akash
On 9/6/2016 9:22 PM, Tvrtko Ursulin wrote: On 06/09/16 16:33, Goel, Akash wrote: On 9/6/2016 6:47 PM, Tvrtko Ursulin wrote: Hi, On 06/09/16 11:43, akash.g...@intel.com wrote: From: Akash Goel This patch provides a test utility which helps capture GuC firmware logs and then dump them to

Re: [Intel-gfx] [PATCH] tools/intel_guc_logger: Utility for capturing GuC firmware logs in a file

2016-09-07 Thread Goel, Akash
On 9/7/2016 3:07 PM, Tvrtko Ursulin wrote: On 07/09/16 09:44, Chris Wilson wrote: On Wed, Sep 07, 2016 at 01:40:27PM +0530, Goel, Akash wrote: On 9/6/2016 9:22 PM, Tvrtko Ursulin wrote: [snip] +while (!stop_logging) +{ +if (test_duration && (igt_seconds_elapse

Re: [Intel-gfx] [RFC 03/12] drm/i915: Support for GuC interrupts

2016-05-28 Thread Goel, Akash
On 5/28/2016 1:13 AM, Chris Wilson wrote: On Sat, May 28, 2016 at 01:12:54AM +0530, akash.g...@intel.com wrote: From: Sagar Arun Kamble There are certain types of interrupts which Host can recieve from GuC. GuC ukernel sends an interrupt to Host for certain events, like for example retrieve/

Re: [Intel-gfx] [RFC 09/12] drm/i915: Add a char device file interface to capture GuC ukernel logs

2016-05-28 Thread Goel, Akash
On 5/28/2016 1:18 AM, Chris Wilson wrote: On Sat, May 28, 2016 at 01:13:00AM +0530, akash.g...@intel.com wrote: From: Akash Goel This patch provides a new character device file interface '/dev/dri/guc_log' for the User to capture the GuC ukernel logs. Do not make the device conditional on

Re: [Intel-gfx] [RFC 03/12] drm/i915: Support for GuC interrupts

2016-05-28 Thread Goel, Akash
On 5/28/2016 1:26 AM, Chris Wilson wrote: On Sat, May 28, 2016 at 01:12:54AM +0530, akash.g...@intel.com wrote: From: Sagar Arun Kamble There are certain types of interrupts which Host can recieve from GuC. GuC ukernel sends an interrupt to Host for certain events, like for example retrieve/

Re: [Intel-gfx] [RFC 03/12] drm/i915: Support for GuC interrupts

2016-05-28 Thread Goel, Akash
On 5/28/2016 5:43 PM, Chris Wilson wrote: On Sat, May 28, 2016 at 02:52:16PM +0530, Goel, Akash wrote: On 5/28/2016 1:26 AM, Chris Wilson wrote: On Sat, May 28, 2016 at 01:12:54AM +0530, akash.g...@intel.com wrote: From: Sagar Arun Kamble There are certain types of interrupts which Host

Re: [Intel-gfx] [RFC 03/12] drm/i915: Support for GuC interrupts

2016-05-28 Thread Goel, Akash
On 5/28/2016 8:05 PM, Chris Wilson wrote: On Sat, May 28, 2016 at 07:15:52PM +0530, Goel, Akash wrote: On 5/28/2016 5:43 PM, Chris Wilson wrote: On Sat, May 28, 2016 at 02:52:16PM +0530, Goel, Akash wrote: On 5/28/2016 1:26 AM, Chris Wilson wrote: On Sat, May 28, 2016 at 01:12:54AM

Re: [Intel-gfx] [RFC 00/12] Support for sustained capturing of GuC firmware logs

2016-06-03 Thread Goel, Akash
On 6/3/2016 12:45 PM, Daniel Vetter wrote: On Thu, Jun 02, 2016 at 12:21:49PM +0200, Johannes Berg wrote: On Thu, 2016-06-02 at 10:16 +, Daniel Vetter wrote: I still kinda like relayfs, except that it's not available in non- debug builds. But so are plenty of other really interesting fil

Re: [Intel-gfx] [PATCH 09/11] drm/i915: New module param to control the size of buffer used for storing GuC firmware logs

2016-06-27 Thread Goel, Akash
On 6/27/2016 7:01 PM, Jani Nikula wrote: On Mon, 27 Jun 2016, akash.g...@intel.com wrote: From: Akash Goel On recieving the log buffer flush interrupt from GuC firmware, Driver stores the snapshot of the log buffer in a local buffer, from which Userspace can pull the logs. By default Driver

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Decouple GuC log setup from verbosity parameter

2016-06-27 Thread Goel, Akash
On 6/27/2016 8:30 PM, Tvrtko Ursulin wrote: On 27/06/16 13:16, akash.g...@intel.com wrote: From: Sagar Arun Kamble GuC Log buffer allocation was tied up with verbosity level kernel parameter i915.guc_log_level. User could be given a provision to enable logging at runtime and not necessarily

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Decouple GuC log setup from verbosity parameter

2016-06-27 Thread Goel, Akash
On 6/27/2016 9:26 PM, Tvrtko Ursulin wrote: On 27/06/16 16:32, Goel, Akash wrote: On 6/27/2016 8:30 PM, Tvrtko Ursulin wrote: On 27/06/16 13:16, akash.g...@intel.com wrote: From: Sagar Arun Kamble GuC Log buffer allocation was tied up with verbosity level kernel parameter i915

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Add low level set of routines for programming PM IER/IIR/IMR register set

2016-06-27 Thread Goel, Akash
On 6/27/2016 9:16 PM, Tvrtko Ursulin wrote: On 27/06/16 13:16, akash.g...@intel.com wrote: From: Akash Goel So far PM IER/IIR/IMR registers were being used only for Turbo related interrupts. But interrupts coming from GuC also use the same set. As a precursor to supporting GuC interrupts, a

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Add low level set of routines for programming PM IER/IIR/IMR register set

2016-06-28 Thread Goel, Akash
On 6/28/2016 2:05 PM, Tvrtko Ursulin wrote: On 27/06/16 17:35, Goel, Akash wrote: On 6/27/2016 9:16 PM, Tvrtko Ursulin wrote: On 27/06/16 13:16, akash.g...@intel.com wrote: From: Akash Goel So far PM IER/IIR/IMR registers were being used only for Turbo related interrupts. But interrupts

Re: [Intel-gfx] [PATCH 06/11] drm/i915: Add a relay backed debugfs interface for capturing GuC logs

2016-06-28 Thread Goel, Akash
On 6/28/2016 3:17 PM, Chris Wilson wrote: On Mon, Jun 27, 2016 at 05:46:53PM +0530, akash.g...@intel.com wrote: +static void guc_remove_log_relay_file(struct intel_guc *guc) +{ + relay_close(guc->log_relay_chan); +} + +static void guc_create_log_relay_file(struct intel_guc *guc) +{ +

Re: [Intel-gfx] [PATCH 10/11] drm/i915: Support to create write combined type vmaps

2016-06-28 Thread Goel, Akash
On 6/28/2016 3:22 PM, Chris Wilson wrote: On Mon, Jun 27, 2016 at 05:46:57PM +0530, akash.g...@intel.com wrote: From: Chris Wilson diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 20c701c..3ef1ee5 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/g

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Support for GuC interrupts

2016-06-28 Thread Goel, Akash
On 6/28/2016 3:33 PM, Tvrtko Ursulin wrote: On 27/06/16 13:16, akash.g...@intel.com wrote: From: Sagar Arun Kamble There are certain types of interrupts which Host can recieve from GuC. GuC ukernel sends an interrupt to Host for certain events, like for example retrieve/consume the logs gen

Re: [Intel-gfx] [PATCH] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-11-25 Thread Goel, Akash
On 11/25/2015 2:51 PM, Daniel Vetter wrote: On Tue, Nov 24, 2015 at 10:39:38PM +, Chris Wilson wrote: On Tue, Nov 24, 2015 at 07:14:31PM +0100, Daniel Vetter wrote: On Tue, Nov 24, 2015 at 12:04:06PM +0200, Ville Syrjälä wrote: On Tue, Nov 24, 2015 at 03:35:24PM +0530, akash.g...@intel.c

Re: [Intel-gfx] [PATCH] drm/i915: Disable shrinker for non-swapped backed objects

2015-11-25 Thread Goel, Akash
On 11/25/2015 3:28 PM, Chris Wilson wrote: On Wed, Nov 25, 2015 at 10:17:49AM +0100, Daniel Vetter wrote: On Tue, Nov 24, 2015 at 11:17:38PM +, Chris Wilson wrote: On Tue, Nov 24, 2015 at 06:15:47PM +0100, Daniel Vetter wrote: On Mon, Nov 23, 2015 at 09:20:24AM +, Chris Wilson wrote:

Re: [Intel-gfx] [PATCH] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-11-25 Thread Goel, Akash
On 11/25/2015 10:58 PM, Chris Wilson wrote: On Wed, Nov 25, 2015 at 01:02:20PM +0200, Ville Syrjälä wrote: On Tue, Nov 24, 2015 at 10:39:38PM +, Chris Wilson wrote: On Tue, Nov 24, 2015 at 07:14:31PM +0100, Daniel Vetter wrote: On Tue, Nov 24, 2015 at 12:04:06PM +0200, Ville Syrjälä wrot

Re: [Intel-gfx] [PATCH] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-11-29 Thread Goel, Akash
On 11/25/2015 3:30 PM, Daniel Vetter wrote: On Wed, Nov 25, 2015 at 02:57:47PM +0530, Goel, Akash wrote: On 11/25/2015 2:51 PM, Daniel Vetter wrote: On Tue, Nov 24, 2015 at 10:39:38PM +, Chris Wilson wrote: On Tue, Nov 24, 2015 at 07:14:31PM +0100, Daniel Vetter wrote: On Tue, Nov 24

Re: [Intel-gfx] [PATCH] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-12-01 Thread Goel, Akash
On 11/30/2015 1:45 PM, Daniel Vetter wrote: On Mon, Nov 30, 2015 at 11:54:14AM +0530, Goel, Akash wrote: On 11/25/2015 3:30 PM, Daniel Vetter wrote: On Wed, Nov 25, 2015 at 02:57:47PM +0530, Goel, Akash wrote: On 11/25/2015 2:51 PM, Daniel Vetter wrote: On Tue, Nov 24, 2015 at 10:39

Re: [Intel-gfx] [PATCH v3] drm/i915 : Avoid superfluous invalidation of CPU cache lines

2015-12-01 Thread Goel, Akash
On 12/1/2015 7:30 PM, Ville Syrjälä wrote: On Tue, Dec 01, 2015 at 01:49:10PM +, Chris Wilson wrote: On Tue, Dec 01, 2015 at 03:28:28PM +0200, Ville Syrjälä wrote: On Tue, Dec 01, 2015 at 01:09:33PM +, Chris Wilson wrote: On Tue, Dec 01, 2015 at 02:34:41PM +0200, Ville Syrjälä wrote:

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Make GPU pages movable

2016-10-18 Thread Goel, Akash
On 10/18/2016 5:35 PM, Joonas Lahtinen wrote: On ma, 2016-04-04 at 14:18 +0100, Chris Wilson wrote: From: Akash Goel On a long run of more than 2-3 days, physical memory tends to get fragmented severely, which considerably slows down the system. In such a scenario, the shrinker is also unabl

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make GPU pages movable

2016-11-04 Thread Goel, Akash
On 11/4/2016 7:07 PM, Chris Wilson wrote: Best if we send these as a new series to unconfuse CI. Okay will send as a new series. On Fri, Nov 04, 2016 at 06:18:26PM +0530, akash.g...@intel.com wrote: +static int do_migrate_page(struct drm_i915_gem_object *obj) +{ + struct drm_i915_pri

  1   2   3   >