This variable is only used locally in the irq postinstall
functions for ivybridge and ironlake.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h |1 -
drivers/gpu/drm/i915/i915_irq.c | 10 ++
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu
after a certain grace period (2 minutes).
Should the interrupt storm persist it will be detected immediately
and it will be disabled again.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h |2 +
drivers/gpu/drm/i915/i915_irq.c | 58
s and fall back to periodic
device polling.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 25 +++--
1 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 2da788f..aa4986d 10
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 178 ++
1 files changed, 103 insertions(+), 75 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 4e75df0..356472f 100644
--- a/drivers/gpu/drm
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 89 --
1 files changed, 47 insertions(+), 42 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 356472f..2da788f 100644
--- a/drivers/gpu/drm
Hi Daniel,
On Fri, Jan 11, 2013 at 09:34:08PM +0100, Daniel Vetter wrote:
>
> Nice work, and we know that we need this since quite a while. But
> unfortunately we've not yet come around to implement something. Some
> high-level comments on how I think this should best be handled:
>
> - imo dv_pr
Hi Daniel,
I've played around a bit now, and implemented your suggestions:
On Thu, Jan 17, 2013 at 03:45:26PM +0100, Daniel Vetter wrote:
> On Thu, Jan 17, 2013 at 03:01:06PM +0100, Egbert Eich wrote:
> > Hi Daniel,
> >
> > On Fri, Jan 11, 2013 at 09:34:08PM
On Tue, Jan 22, 2013 at 02:48:29PM +0100, Daniel Vetter wrote:
> On Tue, Jan 22, 2013 at 2:22 PM, Egbert Eich wrote:
>
> Hm, I've thought the hw supports short dp pulses on eDP port A in case
> the panel needs our attention, but maybe I've mixed that up with the
> dp a
Before testing if the panel VDD is enabled on eDP cancel any pending
disable worker. This makes sure the worker doesn't fire when we expect
VDD to be enabled.
https://bugs.freedesktop.org/show_bug.cgi?id=86201
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_dp.c | 1 +
1 file ch
It may be required to wrap the generic DP I2C transfer function to
perfrom certain operations before of after this function is called.
Make this function available to the driver.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_dp_helper.c | 3 ++-
include/drm/drm_dp_helper.h | 2 ++
2
This way a driver can replace this function with its own version.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_dp_helper.c | 5 +++--
include/drm/drm_dp_helper.h | 8
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu
It may be required to wrap the generic DP DPCD transfer function to
perfrom certain operations before of after this function is called.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_dp_helper.c | 3 ++-
include/drm/drm_dp_helper.h | 4
2 files changed, 6 insertions(+), 1 deletion
From: Ville Syrjälä
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_dp.c | 48 -
1 file changed, 28 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 81f959d..a24c8cc7 100644
-
enablement to the top so that it is performed only
once per master_xfer() or dpcd_access().
This fixes https://bugs.freedesktop.org/show_bug.cgi?id=86201
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_dp.c | 116 ---
drivers/gpu/drm/i915/intel_drv.h
e top.
This fixes the long delay observed in
https://bugs.freedesktop.org/show_bug.cgi?id=86201
Egbert Eich (4):
drm/DP: Create pointer to generic DPCD access function
drm/DP: Export drm_dp_i2c
Ville Syrjälä writes:
> On Mon, Nov 24, 2014 at 07:32:49PM +0200, Ville Syrjälä wrote:
> > On Mon, Nov 24, 2014 at 05:56:20PM +0100, Egbert Eich wrote:
> > > Before testing if the panel VDD is enabled on eDP cancel any pending
> > > disable worker. This makes sure t
Daniel Vetter writes:
> On Mon, Nov 24, 2014 at 5:56 PM, Egbert Eich wrote:
> > Before testing if the panel VDD is enabled on eDP cancel any pending
> > disable worker. This makes sure the worker doesn't fire when we expect
> > VDD to be enabled.
> >
?id=86201
v2: use cancel_delayed_work() instead of cancel_delayed_work_sync()
as the pps_mutexes will provide the required serialization with
edp_panel_vdd_work() while the sync variant may deadlock. Suggested
by Ville Syrjälä .
Made commit message a bit clearer.
Signed-off-by: Egbert Eich
Daniel Vetter writes:
> Imo this approach with overwrite all the entry points won't scale since
> besides i2c and dpcd there will be more sooner or later (oui, dp mst, some
> debugfs userspace dp aux tools, ...).
>
> I think what we need is the same as in the i2c layer has with the
> xfer_p
Hi Daniel, hi Imre,
Daniel Vetter writes:
> Adding Egbert since he's done the original hack here. Imre please keep
> him on cc.
> -Daniel
I finally managed to get this set of patches tested on the platform that
exhibited the intermittent blanking problem when terminating the Xserver.
I can c
Chris Wilson writes:
> On Fri, Jun 27, 2014 at 12:07:47AM +0200, Egbert Eich wrote:
> >
> > Hi Daniel, hi Imre,
> >
> > Daniel Vetter writes:
> > > Adding Egbert since he's done the original hack here. Imre please keep
> > > him on cc.
introduced with commit
commit 61bc95c1fbbb6a08b55bbe161fdf1ea5493fc595
Author: Egbert Eich
Date: Mon Mar 4 09:24:38 2013 -0500
DRM/i915: On G45 enable cursor plane briefly after enabling the display
plane.
to avoided occasional screen blanking on mode changes can finally
be removed
.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_crt.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index af5e43b..685f3de 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b
ady locked.
Add a non-locking version as well.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_probe_helper.c | 19 ---
include/drm/drm_crtc_helper.h | 1 +
2 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c
b/drive
errupts on gmch platforms")
and
commit 3432087ef846d760427eceff0ff4e7d0a2565b8a
("drm/i915: Only WARN about a stuck hotplug irq ONCE")
may actually become obsolete now.
Egbert Eich (4):
drm: Add a non-locking version of drm_kms_helper_poll_enable().
drm/i915: Ca
This copy-and-past error was introduced in:
commit fd63e2a972c670887e5e8a08440111d3812c0996
Author: Imre Deak
Date: Tue Jul 21 15:32:44 2015 -0700
drm/i915: combine i9xx_get_hpd_pins and pch_get_hpd_pins
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_irq.c | 2 +-
1 file
+0200
drm/probe-helper: Grab mode_config.mutex in poll_init/enable
a deadlock occurred.
Call the newly implemented non-locking version of this function.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/intel_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Lukas Wunner writes:
> Hi Egbert,
>
> On Tue, Sep 01, 2015 at 10:21:32PM +0200, Egbert Eich wrote:
> > drm_kms_helper_poll_enable() was converted to lock the mode_config
> > mutex in commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f
> > ("drm/probe-helper: Gra
Lukas Wunner writes:
>
> It seems DRM convention is to append _locked or _unlocked, e.g.:
> drm_fb_helper_restore_fbdev_mode_unlocked
> drm_gem_object_unreference_unlocked
>
Oh, I missed that.
Did you check what these functions actually do - and compare it to
what I try to achieve?
Egbert
Lukas Wunner writes:
> Hi Egbert,
>
> On Wed, Sep 02, 2015 at 12:10:19AM +0200, Egbert Eich wrote:
> > Lukas Wunner writes:
> > > On Tue, Sep 01, 2015 at 10:21:32PM +0200, Egbert Eich wrote:
> > > > drm_kms_helper_poll_enable() was converted to loc
Daniel Vetter writes:
> On Tue, Sep 01, 2015 at 10:21:35PM +0200, Egbert Eich wrote:
> > A HPD interrupt may fire during intel_crt_detect_hotplug() - especially
> > when HPD interrupt storms occur.
> > Since the interrupt handler changes the enabled interrupt lines when it
Jani Nikula writes:
> On Wed, 02 Sep 2015, Egbert Eich wrote:
> > This is exactly the scenatio I'm getting here. I get HPD interrupts at an
> > order of 10^4 / sec.
>
> Makes you wonder if either you have faulty hardware or we are
> configuring the har
Daniel Vetter writes:
> On Wed, Sep 02, 2015 at 04:19:00PM +0200, Egbert Eich wrote:
>
> Hm I missed that this same register is also accessed by the irq handler
> code, and it's not just that touching these bits can cause interrupts. So
> yeah we need your patch, but it
k occurred.
Call the newly implemented non-locking version of this function.
Changes since v1:
- use function name suffix '_locked' for the function that
is to be called from a locked context.
Signed-off-by: Egbert Eich
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/i915/intel_hotp
ady locked.
Add a non-locking version as well.
Changes since v1:
- use function name suffix '_locked' for the function that
is to be called from a locked context.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_probe_helper.c | 19 ---
include/drm/drm_crtc_hel
the rmw cycles with IRQ save spinlocks.
Changes since v1:
- Implement a function which takes care of accessing PORT_HOTPLUG_EN.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.h | 3 ++
drivers/gpu/drm/i915/i915_irq.c | 64
drivers/gpu/drm
Daniel Vetter writes:
> On Wed, Sep 23, 2015 at 04:15:27PM +0200, Egbert Eich wrote:
> > An HPD interrupt may fire while we are in a function that changes
> > the PORT_HOTPLUG_EN register - especially when an HPD interrupt
> > storm occurs.
> > Since the interrupt
Jani Nikula writes:
>
> Shouldn't this be _unlocked?
>
> I thought the convention was that functions that do not acquire locks
> are called _unlocked (although they may require a lock to be held when
> called). And you might have foo() that grabs locks around a call to
> foo_unlocked().
>
This makes sure no hpd interrupt or reenable worker fires when
resetting or suspending.
We already call intel_hpd_init() in most cases on resume and
after reset to undo this.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/i915/i915_drv.c | 3 +++
drivers/gpu/drm/i915/i915_drv.h | 1
Jani Nikula writes:
> On Wed, 30 Sep 2015, Daniel Vetter wrote:
> > On Wed, Sep 30, 2015 at 05:09:04PM +0800, kbuild test robot wrote:
> >> tree: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes
> >> head: ad96c5f13442b17fafccc30f81efae2f08351f99
> >> commit: 10d3a5618b3aba24d
Regarding commit 7809e5ae35b9d8d0710f0874b2e3f10be144e38b
On Wed, Jul 01, 2015 at 07:25:56PM -0700, Matt Roper wrote:
> Determine whether we need to apply this workaround at atomic check time
> and just set a flag that will be used by the main watermark update
> routine.
>
> Moving this workaroun
101 - 141 of 141 matches
Mail list logo
