Re: [Intel-gfx] [PATCH v4 2/5] drm: Add private data field to trace control block

2016-07-20 Thread Dmitry V. Levin
On Mon, Sep 07, 2015 at 08:23:57PM +0200, Patrik Jakobsson wrote: > On Mon, Sep 7, 2015 at 6:51 PM, Dmitry V. Levin wrote: > > On Mon, Aug 31, 2015 at 02:37:07PM +0200, Patrik Jakobsson wrote: > > [...] > >> Here's my take on it (I assume it needs so

Re: [Intel-gfx] kernel oops loading i915 after "x86/asm: Pin sensitive CR4 bits" (873d50d58)

2019-07-10 Thread Dmitry V. Levin
Hi, On Wed, Jul 10, 2019 at 01:44:17PM +0800, Xi Ruoyao wrote: > Hello, > > When I try to build and run the latest mainline kernel, it Oops loading i915 > module: > > BUG: unable to handle page fault for address: 9edc1598 > #PF: supervisor write access in kernel mode > #PF: error_code(0x

Re: [Intel-gfx] [PATCH v4 2/5] drm: Add private data field to trace control block

2015-11-23 Thread Dmitry V. Levin
On Mon, Sep 07, 2015 at 08:23:57PM +0200, Patrik Jakobsson wrote: > On Mon, Sep 7, 2015 at 6:51 PM, Dmitry V. Levin wrote: > > On Mon, Aug 31, 2015 at 02:37:07PM +0200, Patrik Jakobsson wrote: > > [...] > >> Here's my take on it (I assume it needs so

Re: [Intel-gfx] [PATCH v4 3/5] drm: Add dispatcher and driver identification for DRM

2015-11-23 Thread Dmitry V. Levin
On Fri, Sep 11, 2015 at 12:57:06PM +0200, Patrik Jakobsson wrote: > On Tue, Sep 08, 2015 at 03:36:25AM +0300, Dmitry V. Levin wrote: > > On Mon, Aug 24, 2015 at 02:42:48PM +0200, Patrik Jakobsson wrote: [...] > > > +static char *drm_get_driver_name(struct tcb *tcp) > >

Re: [Intel-gfx] [PATCH 2/4] drm: Add dispatcher and driver identification for DRM

2015-06-09 Thread Dmitry V. Levin
On Tue, Jun 09, 2015 at 01:26:42PM +0200, Patrik Jakobsson wrote: [...] > --- a/Makefile.am > +++ b/Makefile.am > @@ -121,6 +121,7 @@ strace_SOURCES = \ > utime.c \ > utimes.c\ > v4l2.c \ > + drm.c \ > vsprintf.c \ > wait.c

Re: [Intel-gfx] [PATCH 3/4] drm: Add decoding of i915 ioctls

2015-06-09 Thread Dmitry V. Levin
On Tue, Jun 09, 2015 at 01:26:43PM +0200, Patrik Jakobsson wrote: [...] > +static int i915_getparam(struct tcb *tcp, const unsigned int code, long arg) > +{ > + struct drm_i915_getparam param; > + int value; > + > + if (entering(tcp) || umove(tcp, arg, ¶m)) > + return 0; > +

Re: [Intel-gfx] [PATCH 4/4] drm: Add decoding of DRM and KMS ioctls

2015-06-09 Thread Dmitry V. Levin
On Tue, Jun 09, 2015 at 01:26:44PM +0200, Patrik Jakobsson wrote: [...] > +static int drm_version(struct tcb *tcp, const unsigned int code, long arg) > +{ > + struct drm_version ver; > + char *name, *date, *desc; > + int ret; > + > + if (entering(tcp) || umove(tcp, arg, &ver)) > +

Re: [Intel-gfx] [PATCH 4/4] drm: Add decoding of DRM and KMS ioctls

2015-06-09 Thread Dmitry V. Levin
On Tue, Jun 09, 2015 at 04:38:40PM +0200, Gabriel Laskar wrote: > On Tue, 9 Jun 2015 16:29:31 +0200 > Patrik Jakobsson wrote: > > > On Tue, Jun 09, 2015 at 03:51:08PM +0200, Gabriel Laskar wrote: > > > On Tue, 9 Jun 2015 13:26:44 +0200 > > > Patrik Jakobsson wrote: > > > > > > > This patch add

Re: [Intel-gfx] [PATCH 2/4] drm: Add dispatcher and driver identification for DRM

2015-06-09 Thread Dmitry V. Levin
On Tue, Jun 09, 2015 at 01:26:42PM +0200, Patrik Jakobsson wrote: [...] > +static int drm_get_driver_name(struct tcb *tcp, char *name, size_t bufsize) > +{ > + char path[PATH_MAX]; > + char link[PATH_MAX]; > + int ret; > + > + ret = getfdpath(tcp, tcp->u_arg[0], path, PATH_MAX - 1);

Re: [Intel-gfx] [PATCH 2/4] drm: Add dispatcher and driver identification for DRM

2015-06-10 Thread Dmitry V. Levin
On Wed, Jun 10, 2015 at 01:52:33PM +0200, Patrik Jakobsson wrote: > On Wed, Jun 10, 2015 at 01:14:20AM +0300, Dmitry V. Levin wrote: > > On Tue, Jun 09, 2015 at 01:26:42PM +0200, Patrik Jakobsson wrote: [...] > > > +#define DRM_MAX_NAME_LEN 128 > > > + > > > +i

Re: [Intel-gfx] [PATCH 3/4] drm: Add decoding of i915 ioctls

2015-06-10 Thread Dmitry V. Levin
On Wed, Jun 10, 2015 at 02:45:24PM +0200, Patrik Jakobsson wrote: > On Wed, Jun 10, 2015 at 01:35:35AM +0300, Dmitry V. Levin wrote: > > On Tue, Jun 09, 2015 at 01:26:43PM +0200, Patrik Jakobsson wrote: [...] > > > +static int i915_setparam(struct tcb *tcp, const unsigned int cod

Re: [Intel-gfx] [PATCH 2/4] drm: Add dispatcher and driver identification for DRM

2015-06-12 Thread Dmitry V. Levin
On Thu, Jun 11, 2015 at 04:11:49PM +0200, Patrik Jakobsson wrote: > On Thu, Jun 11, 2015 at 02:26:59AM +0300, Dmitry V. Levin wrote: > > On Wed, Jun 10, 2015 at 01:52:33PM +0200, Patrik Jakobsson wrote: > > > On Wed, Jun 10, 2015 at 01:14:20AM +0300, Dmitry V. Levin wrote: >

Re: [Intel-gfx] [PATCH 3/4] drm: Add decoding of i915 ioctls

2015-06-12 Thread Dmitry V. Levin
On Thu, Jun 11, 2015 at 03:34:14PM +0200, Patrik Jakobsson wrote: > On Thu, Jun 11, 2015 at 02:27:12AM +0300, Dmitry V. Levin wrote: > > On Wed, Jun 10, 2015 at 02:45:24PM +0200, Patrik Jakobsson wrote: > > > On Wed, Jun 10, 2015 at 01:35:35AM +0300, Dmitry V. Levin wrote: >

Re: [Intel-gfx] [PATCH 2/4] drm: Add dispatcher and driver identification for DRM

2015-06-14 Thread Dmitry V. Levin
On Sun, Jun 14, 2015 at 01:12:45PM +0200, Patrik Jakobsson wrote: [...] > How about adding a "void *private" field to struct tcb. That way any > syscall can store additional data across the life of the tcb. We can add a field to struct tcb, but its semantics wrt memory management should be strictl

Re: [Intel-gfx] [PATCH v3 2/5] drm: Add private data field to trace control block

2015-07-02 Thread Dmitry V. Levin
On Wed, Jul 01, 2015 at 02:52:45PM +0200, Patrik Jakobsson wrote: [...] > --- a/defs.h > +++ b/defs.h > @@ -266,6 +266,13 @@ struct tcb { > int u_error;/* Error code */ > long scno; /* System call number */ > long u_arg[MAX_ARGS]; /* System call argument

Re: [Intel-gfx] [PATCH v3 4/5] drm: Add decoding of i915 ioctls

2015-07-02 Thread Dmitry V. Levin
On Wed, Jul 01, 2015 at 02:52:47PM +0200, Patrik Jakobsson wrote: [...] > --- a/drm.c > +++ b/drm.c > @@ -35,6 +35,9 @@ > > #define DRM_MAX_NAME_LEN 128 > > +extern int drm_i915_decode_number(struct tcb *tcp, unsigned int arg); Please rename "arg" to "code", and ... > +extern int drm_i915_io

Re: [Intel-gfx] [PATCH v3 4/5] drm: Add decoding of i915 ioctls

2015-07-07 Thread Dmitry V. Levin
On Mon, Jul 06, 2015 at 04:40:24PM +0200, Gabriel Laskar wrote: > On Mon, 6 Jul 2015 12:35:52 +0200, Patrik Jakobsson wrote: > > On Fri, Jul 03, 2015 at 03:36:09AM +0300, Dmitry V. Levin wrote: > > > On Wed, Jul 01, 2015 at 02:52:47PM +0200, Patrik Jakobsson wrote: > > >

Re: [Intel-gfx] [PATCH v4 2/5] drm: Add private data field to trace control block

2015-09-07 Thread Dmitry V. Levin
On Mon, Aug 31, 2015 at 02:37:07PM +0200, Patrik Jakobsson wrote: [...] > Here's my take on it (I assume it needs some discussion): > > int > set_tcb_priv_data(struct tcb *tcp, void *priv_data) > { > /* A free callback is required before setting private data and private >* data must

Re: [Intel-gfx] [PATCH v4 3/5] drm: Add dispatcher and driver identification for DRM

2015-09-07 Thread Dmitry V. Levin
On Mon, Aug 24, 2015 at 02:42:48PM +0200, Patrik Jakobsson wrote: > * Makefile.am: Add compilation of drm.c. > * defs.h: Add extern declaration of drm_ioctl when drm headers are found. > * drm.c: New file. > * ioctl.c (ioctl_decode): Dispatch drm ioctls when drm headers are found. * defs.h (drm_de

Re: [Intel-gfx] [PATCH v4 4/5] drm: Add decoding of i915 ioctls

2015-09-07 Thread Dmitry V. Levin
On Mon, Aug 24, 2015 at 02:42:49PM +0200, Patrik Jakobsson wrote: > +static int i915_getparam(struct tcb *tcp, const unsigned int code, long arg) > +{ > + struct drm_i915_getparam param; > + int value; > + > + if (umove(tcp, arg, ¶m)) > + return RVAL_DECODED; > + > + if

Re: [Intel-gfx] [PATCH v4 4/5] drm: Add decoding of i915 ioctls

2015-09-07 Thread Dmitry V. Levin
On Tue, Sep 08, 2015 at 04:18:11AM +0300, Dmitry V. Levin wrote: [...] > So the whole function should look smth like this: > > static int i915_getparam(struct tcb *tcp, const unsigned int code, long arg) > { > struct drm_i915_getparam param; > >

Re: [Intel-gfx] [PATCH v4 5/5] drm: Add decoding of DRM and KMS ioctls

2015-09-08 Thread Dmitry V. Levin
On Mon, Aug 24, 2015 at 02:42:50PM +0200, Patrik Jakobsson wrote: > First batch of drm / kms ioctls. Several comments in addition to issues similar to 4/5 patch. > +static int drm_mode_rm_fb(struct tcb *tcp, const unsigned int code, long arg) > +{ > + unsigned int handle; > + > + > + if (

Re: [Intel-gfx] [PATCH v4 4/5] drm: Add decoding of i915 ioctls

2015-09-09 Thread Dmitry V. Levin
On Tue, Sep 08, 2015 at 04:30:52AM +0300, Dmitry V. Levin wrote: > On Tue, Sep 08, 2015 at 04:18:11AM +0300, Dmitry V. Levin wrote: > [...] > > So the whole function should look smth like this: > > > > static int i915_getparam(struct tcb *tcp, const uns

Re: [Intel-gfx] [PATCH v4 4/5] drm: Add decoding of i915 ioctls

2015-09-11 Thread Dmitry V. Levin
On Fri, Sep 11, 2015 at 01:31:02PM +0200, Patrik Jakobsson wrote: > On Tue, Sep 08, 2015 at 04:18:11AM +0300, Dmitry V. Levin wrote: > > On Mon, Aug 24, 2015 at 02:42:49PM +0200, Patrik Jakobsson wrote: > > > +static int i915_getparam(struct tcb *tcp, const unsigned int cod

Re: [Intel-gfx] [PATCH v4 5/5] drm: Add decoding of DRM and KMS ioctls

2015-09-11 Thread Dmitry V. Levin
On Fri, Sep 11, 2015 at 01:39:29PM +0200, Patrik Jakobsson wrote: > On Wed, Sep 09, 2015 at 01:50:40AM +0300, Dmitry V. Levin wrote: > > On Mon, Aug 24, 2015 at 02:42:50PM +0200, Patrik Jakobsson wrote: > > > +static int drm_mode_create_dumb(struct tcb *tcp, const unsigned int

Re: [Intel-gfx] [PATCH v4 5/5] drm: Add decoding of DRM and KMS ioctls

2015-09-11 Thread Dmitry V. Levin
On Fri, Sep 11, 2015 at 02:20:35PM +0200, Patrik Jakobsson wrote: > On Fri, Sep 11, 2015 at 03:10:05PM +0300, Dmitry V. Levin wrote: > > On Fri, Sep 11, 2015 at 01:39:29PM +0200, Patrik Jakobsson wrote: > > > On Wed, Sep 09, 2015 at 01:50:40AM +0300, Dmitry V. Levin wrote: >

Re: [Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace

2015-05-13 Thread Dmitry V. Levin
On Tue, May 12, 2015 at 07:37:59PM +0200, Gabriel Laskar wrote: > On Tue, 12 May 2015 14:35:28 +0200, Patrik Jakobsson wrote: > > On Mon, May 11, 2015 at 08:08:19PM +0200, Gabriel Laskar wrote: > > > On Mon, 11 May 2015 15:54:24 +0200, Patrik Jakobsson wrote: > > > > On Mon, May 11, 2015 at 12:50:3

Re: [Intel-gfx] [PATCH v3 4/5] drm: Add decoding of i915 ioctls

2015-07-10 Thread Dmitry V. Levin
On Fri, Jul 10, 2015 at 02:36:38PM +0200, Patrik Jakobsson wrote: > On Wed, Jul 08, 2015 at 03:11:36AM +0300, Dmitry V. Levin wrote: > > On Mon, Jul 06, 2015 at 04:40:24PM +0200, Gabriel Laskar wrote: [...] > > > Anyway, SYS_FUNC(ioctl) is a bit complicated, and the handling of t

Re: [Intel-gfx] [PATCH v3 1/5] drm: Add config for detecting libdrm

2015-07-23 Thread Dmitry V. Levin
On Thu, Jul 23, 2015 at 05:48:21AM -0400, Mike Frysinger wrote: > On 01 Jul 2015 14:52, Patrik Jakobsson wrote: > > Use pkg-config to try to find libdrm. If that fails use the standard > > include directory for kernel drm headers in /usr/include/drm. > > > > * configure.ac: Use pkg-config to find

Re: [Intel-gfx] [PATCH v3 1/5] drm: Add config for detecting libdrm

2015-08-01 Thread Dmitry V. Levin
On Fri, Jul 31, 2015 at 11:09:11AM +0200, Patrik Jakobsson wrote: > On Thu, Jul 30, 2015 at 10:04:49AM -0400, Mike Frysinger wrote: > > On 30 Jul 2015 15:30, Patrik Jakobsson wrote: > > > On Thu, Jul 23, 2015 at 05:48:21AM -0400, Mike Frysinger wrote: > > > > On 01 Jul 2015 14:52, Patrik Jakobsson