Re: [Intel-gfx] [PATCH 3/4] drm: Add decoding of i915 ioctls

[Dmitry V. Levin]

On Tue, Jun 09, 2015 at 01:26:43PM +0200, Patrik Jakobsson wrote:
[...]
> +static int i915_getparam(struct tcb *tcp, const unsigned int code, long arg)
> +{
> +     struct drm_i915_getparam param;
> +     int value;
> +
> +     if (entering(tcp) || umove(tcp, arg, &param))
> +             return 0;
> +     if (umove(tcp, (long)param.value, &value))
> +             return 0;
> +
> +     tprintf(", {param=");

We use tprints to print regular strings.

> +static int i915_setparam(struct tcb *tcp, const unsigned int code, long arg)
> +{
> +     struct drm_i915_setparam param;
> +
> +     if (exiting(tcp) || umove(tcp, arg, &param))
> +             return 0;

In this and other ioctl printers that unconditionally return 0 on exit,
wouldn't the caller treat it as an ioctl that hasn't been printed?


-- 
ldv

pgp5rnp2hAveW.pgp
Description: PGP signature

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx