On Thu, Dec 05, 2013 at 01:56:15PM +, Damien Lespiau wrote:
> A while ago, Ben added support for Quanta devices that had the display
> hardware
> fused off. We can a bit more general than that by reading the FUSE_STRAP
> register and setting num_pipes to 0 when detecting such con
FUSE_STRAP has a bit to inform us that the display has been fused off.
Use it to setup the definitive number of pipes at run-time.
v2: actually tweak num_pipes, not num_planes
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 19 ++-
1 file changed, 18
Starting from IVB, pipe C can be fused off. We have yet to see such
configuration in the wild though (ie not tested).
v2: Actually tweak num_pipes, not num_planes.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 4
drivers/gpu/drm/i915/i915_reg.h | 1 +
2 files changed
On Thu, Dec 05, 2013 at 02:09:33PM +, Chris Wilson wrote:
> Patches look fine. Just relying on fuse registers being correct is like
> relying on vbt being correct, fraught with anxiety.
Well, I believe those bits are directly reflecting the fuses/straps
programmed (the sames that will actually
On Thu, Dec 05, 2013 at 10:19:20AM -0800, Ben Widawsky wrote:
> On Thu, Dec 05, 2013 at 02:21:08PM +0000, Damien Lespiau wrote:
> > On Thu, Dec 05, 2013 at 02:09:33PM +, Chris Wilson wrote:
> > > Patches look fine. Just relying on fuse registers being correct is like
> >
moved it to _new() mid-development and forgot to remove the return
value.
Reviewed-by: Damien Lespiau
> ---
> lib/igt_debugfs.c | 7 ++-
> lib/igt_debugfs.h | 2 +-
> tests/kms_pipe_crc_basic.c | 2 +-
> 3 files changed, 4 insertions(+), 7 deletions(-)
>
and
was a left over from the initial implementation, but who cares).
Reviewed-by: Damien Lespiau
> ---
> lib/igt_debugfs.c | 18 ++
> lib/igt_debugfs.h | 1 +
> tests/kms_cursor_crc.c | 18 ++
> tests/kms_fbc_crc.c| 14
On Fri, Dec 06, 2013 at 10:48:42AM +0100, Daniel Vetter wrote:
> Or more precisely: It already has an igt_require. So we cant ditch it
> from tests.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Damien Lespiau
> ---
> tests/kms_cursor_crc.c | 1 -
> tests/kms
On Fri, Dec 06, 2013 at 02:14:52AM -0800, Kenneth Graunke wrote:
> On 12/06/2013 12:54 AM, Xiang, Haihao wrote:
> > From: "Xiang, Haihao"
> >
> > Otherwise the stale data in the buffer
> >
> > Signed-off-by: Xiang, Haihao
> > ---
> > lib/intel_batchbuffer.c |2 ++
> > 1 file changed, 2 ins
On Fri, Dec 06, 2013 at 02:15:18AM -0800, Kenneth Graunke wrote:
> On 12/06/2013 12:54 AM, Xiang, Haihao wrote:
> > From: "Xiang, Haihao"
> >
> > Otherwise it may result in GPU hang
> >
> > Signed-off-by: Xiang, Haihao
> > ---
> > lib/rendercopy_gen8.c |2 +-
> > 1 file changed, 1 insertio
On Fri, Dec 06, 2013 at 04:54:46PM +0800, Xiang, Haihao wrote:
> From: "Xiang, Haihao"
>
> Emit PIPELINE_SELECT twice and make sure the commands in
> the first batch buffer have been done.
>
> However I don't know why this works !!!
Hum :) on one hand, it's great that you found this w/a, on the
On Fri, Dec 06, 2013 at 09:16:58AM +0800, Xiang, Haihao wrote:
> From: "Xiang, Haihao"
>
> write(...) is used for Render Target Write and Media Block Write.
> The two message types no longer share the same cache agent on GEN8,
> So a parameter is needed for cache agent. The 4th parameter of write
gt; Signed-off-by: Jani Nikula
> Signed-off-by: Rodrigo Vivi
> Reviewed-by: Damien Lespiau
This one has been merged already.
--
Damien
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, Dec 09, 2013 at 11:29:35PM -0800, Kenneth Graunke wrote:
> We don't want depth/stencil fast clears or HiZ resolves; we want normal
> drawing. Without this, the pixel pipeline doesn't work.
>
> Signed-off-by: Kenneth Graunke
> Cc: Ben Widawsky
> Cc: D
uint8_t *' and we can drop the cast entirely.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Damien Lespiau
(I guess the data argument of intel_sdvo_write_infoframe() could be
constified as well)
--
Damien
> ---
> drivers/gpu/drm/i915/intel_drv.h | 2 +-
> drivers/gpu/drm
ar split today.
>
> v2: - Clock on the debug message is in KHz
> - Add missing POSTING_READ
>
> Signed-off-by: Paulo Zanoni
Reviewed-by: Damien Lespiau
/*
* As a side note, CodingStyle stipulates this is the preferred style
* for multi-line comments. Really a small d
d-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 21 ++---
drivers/gpu/drm/i915/i915_drv.h | 5 ++---
drivers/gpu/drm/i915/intel_display.c | 4 ++--
3 files changed, 22 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers
The previous series (and cover letter) can be found at:
http://lists.freedesktop.org/archives/intel-gfx/2013-December/036949.html
Changes:
- Use SFUSE_STRAP bit 7 in addition to FUSE_STRAP bit 30 to detect fused off
display,
- Remove pipe C test for now as we don't know of any device that
: Ben Widawsky
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.c | 13 -
include/drm/i915_pciids.h | 9 -
2 files changed, 22 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index a13b8ed..7717030 100644
--- a/dr
We had 2 set of defines for the same register, so make it one.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_reg.h | 18 --
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/intel_display.c | 3 +--
3 files changed, 10 insertions(+), 13
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 704dc7d..ac1d691 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm
FUSE_STRAP has a bit to inform us that the display has been fused off.
Use it to setup the definitive number of pipes at run-time.
v2: actually tweak num_pipes, not num_planes
v3: also tests SFUSE_STRAP bit 7
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 18
in struct drm_i915_private
- adjust i915_dump_device_info()
- adjust i915_driver_load()
- adjust the INTEL_INFO() macro
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 4 +-
drivers/gpu/drm/i915/i915_drv.h | 4 +-
drivers/gpu/drm/i915/i915_gem.c | 2 +-
drive
brought it back.
>
> Signed-off-by: Paulo Zanoni
Reviewed-by: Damien Lespiau
> ---
> drivers/gpu/drm/i915/intel_drv.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_drv.h
> b/drivers/gpu/drm/i915/intel_drv.h
> index 3f074c8..e4f01ca 10064
On Wed, Dec 11, 2013 at 06:50:09PM -0200, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> I want to add more code to the post_enable function.
>
> Signed-off-by: Paulo Zanoni
Reviewed-by: Damien Lespiau
--
Damien
___
Intel-gfx mailing
A I/O or memory accesses.".
>
> Notice that this is just a partial fix to fd.o #67813. This fixes the
> case where the power well is already enabled when we unbind, not when
> it's disabled when we unbind.
>
> V2: - Rebase (first version was sent in September).
> V3: -
in struct drm_i915_private
- adjust i915_dump_device_info()
- adjust i915_driver_load()
- adjust the INTEL_INFO() macro
v2: cast the info pointer returned by INTEL_INFO() to be const to catch
uses that would modify the structure post-initialization.
(Ville Syrjälä)
Signed-off-by: Damien Lespiau
v3, following up a couple of review comments from Ville:
http://lists.freedesktop.org/archives/intel-gfx/2013-December/037313.html
Changes:
- Always use INTEL_INFO() after initialization to access dev_priv->info
(well, except in the reg macros, where it's just too impractical),
- Cast th
e info fields at run-time.
v2: rename num_plane to num_sprites (Ville Syrjälä)
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 21 ++---
drivers/gpu/drm/i915/i915_drv.h | 5 ++---
drivers/gpu/drm/i915/intel_display.c | 4 ++--
3 files changed,
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_pm.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index c01d08d..351065d 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu
: Ben Widawsky
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.c | 13 -
include/drm/i915_pciids.h | 9 -
2 files changed, 22 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index a13b8ed..7717030 100644
--- a/dr
FUSE_STRAP has a bit to inform us that the display has been fused off.
Use it to setup the definitive number of pipes at run-time.
v2: actually tweak num_pipes, not num_planes
v3: also tests SFUSE_STRAP bit 7
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 18
If we make sure that all the dev_priv->info usages are wrapped by
INTEL_INFO(), we can easily modify the ->info field to be structure and
not a pointer while keeping the const protection in the INTEL_INFO()
macro.
Suggested-by: Ville Syrjälä
Signed-off-by: Damien Lespiau
---
drivers/g
We had 2 set of defines for the same register, so make it one.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_reg.h | 18 --
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/intel_display.c | 3 +--
3 files changed, 10 insertions(+), 13
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index c3e170f..ea6b578 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm
#x27;t
try.
[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:30:DP-3]
[drm:intel_dp_detect], [CONNECTOR:30:DP-3]
[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:30:DP-3] disconnected
[drm:intel_dp_aux_ch], dp_aux_ch timeout status 0x7015003f
[drm:intel_dp_sink_dpms], failed to write sink power state
Signed-off-by: Dami
On Thu, Dec 12, 2013 at 05:30:14PM +0200, Jani Nikula wrote:
> > -#define INTEL_INFO(dev)(to_i915(dev)->info)
> > +#define INTEL_INFO(dev)((const struct intel_device_info
> > *)&to_i915(dev)->info)
>
> If that were an inline function you wouldn't have to cast to add const:
>
> static inl
On Thu, Dec 12, 2013 at 04:58:21PM +, Chris Wilson wrote:
> On Thu, Dec 12, 2013 at 02:36:37PM +0000, Damien Lespiau wrote:
> > If we make sure that all the dev_priv->info usages are wrapped by
> > INTEL_INFO(), we can easily modify the ->info field to be structure and
&g
v1 was a stale thing which should have never seen the light of day.
> (Haihao)
>
> Cc: Kenneth Graunke
> Signed-off-by: Ben Widawsky
Reviewed-by: Damien Lespiau
> ---
> drivers/gpu/drm/i915/i915_reg.h | 4
> drivers/gpu/drm/i915/intel_pm.c | 8
> 2 fi
On Thu, Dec 12, 2013 at 03:28:04PM -0800, Ben Widawsky wrote:
> WaVSRefCountFullforceMissDisable and
> WaDSRefCountFullforceMissDisable
>
> VS is a carry-over from HSW, and DS is likely not used by anyone yet.
>
> Cc: Kenneth Graunke
> Signed-off-by: Ben Widawsky
Review
- *.log/*.trs are generated by make check
- TAGS are generated by make tags
- build-aux, config.h.in~ by autoconf
- *.sw? are temporary files create by vim
- name_from_fd wasn't ignored yet for some reason
Signed-off-by: Damien Lespiau
---
.gitignore | 8 +++-
1 file changed, 7 inser
Signed-off-by: Damien Lespiau
---
intel/test_decode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/intel/test_decode.c b/intel/test_decode.c
index 0fcdf3b..b710f34 100644
--- a/intel/test_decode.c
+++ b/intel/test_decode.c
@@ -146,6 +146,7 @@ infer_devid(const char *batch_filename
Signed-off-by: Damien Lespiau
---
tests/generate_test_batches.c | 20
1 file changed, 20 insertions(+)
diff --git a/tests/generate_test_batches.c b/tests/generate_test_batches.c
index 997ce37..41f883d 100644
--- a/tests/generate_test_batches.c
+++ b/tests
These batches can be used to test the CS parser in libdrm. Let's start
by generating a MI_FLUSH_DW command that flushes a DWord (as opposed to
a QWord).
Signed-off-by: Damien Lespiau
---
tests/.gitignore | 1 +
tests/Makefile.sources| 1 +
tests/generate_test_batc
libdrm has a way to unit-test the CS decoder: test_decode can decode a raw
batch and compare it to a reference output.
However, one still needs to genarate the raw, binary, batches to feed to
test_decode. This couple of patches do exactly that.
--
Damien
On Fri, Dec 13, 2013 at 07:03:11PM +0100, Daniel Vetter wrote:
> On Fri, Dec 13, 2013 at 05:51:25PM +0000, Damien Lespiau wrote:
> > - *.log/*.trs are generated by make check
> > - TAGS are generated by make tags
> > - build-aux, config.h.in~ by autoconf
> > - *.sw? ar
On Fri, Dec 13, 2013 at 06:15:45PM +, Damien Lespiau wrote:
> libdrm has a way to unit-test the CS decoder: test_decode can decode a raw
> batch and compare it to a reference output.
>
> However, one still needs to genarate the raw, binary, batches to feed to
> test_decode.
>
> Signed-off-by: Wei Yongjun
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_de
4 pieces of code were looking very similar. Let's factor out a common
function in the not so unlikely case we need to tweak that code.
Signed-off-by: Damien Lespiau
---
tools/intel_error_decode.c | 52 +++---
1 file changed, 21 insertions(+), 31 dele
On Tue, Dec 17, 2013 at 10:38:48AM +0100, Daniel Vetter wrote:
> On Thu, Dec 12, 2013 at 02:36:36PM +0000, Damien Lespiau wrote:
> > Signed-off-by: Damien Lespiau
>
> Merged this one here, not really sure what to do with the rest.
So, apparently, there's some unhappiness wi
On Tue, Dec 17, 2013 at 10:17:38AM +0100, Daniel Vetter wrote:
> On Mon, Dec 16, 2013 at 08:50:36PM -0800, Ben Widawsky wrote:
> > Reposting this as a new series since two of the patches dropped off
> > since last time.
> >
> > Functionally it's the same as before. Like before, the patch "drm/i915
On Mon, Dec 16, 2013 at 12:02:53PM +, Damien Lespiau wrote:
> 4 pieces of code were looking very similar. Let's factor out a common
> function in the not so unlikely case we need to tweak that code.
>
> Signed-off-by: Damien Lespiau
Pushed.
--
Damien
> ---
> too
Also intel_iosf_read() does not exist, and would need a bit more
arguments.
Signed-off-by: Damien Lespiau
---
tools/intel_iosf_read.c | 70 -
1 file changed, 70 deletions(-)
delete mode 100644 tools/intel_iosf_read.c
diff --git a/tools
That's how the registers are named in the kernel defines.
Signed-off-by: Damien Lespiau
---
lib/instdone.c | 6 +++---
lib/intel_reg.h| 6 +++---
tools/intel_error_decode.c | 2 +-
tools/intel_gpu_top.c | 8
tools/intel_reg_dumper.c | 2 +-
5
This tool only supports ILK. I take the fact that nobody has felt the
need to update for later platform a sign it's not very useful.
Signed-off-by: Damien Lespiau
---
tools/.gitignore | 1 -
tools/Makefile.sources | 1 -
tools/intel_disable_clock_gating.c
This is the only place where they are used and we've even started using
1 << n constants with gen 7.
Signed-off-by: Damien Lespiau
---
lib/instdone.c | 242
lib/intel_reg.h | 237 --
The GEN6_INSTDONE_1 and GEN6_INSTDONE_2 registers are just the old
INSTDONE_I965 and INSTDONE_1 registers but renamed. Let's use the old
names (this is what the kernel does).
Signed-off-by: Damien Lespiau
---
lib/instdone.c | 6 +++---
tools/intel_reg_dumper.c | 4 ++--
2
Signed-off-by: Damien Lespiau
---
lib/instdone.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/instdone.c b/lib/instdone.c
index b4d51f0..1399df7 100644
--- a/lib/instdone.c
+++ b/lib/instdone.c
@@ -37,6 +37,7 @@ int num_instdone_bits = 0;
static void
add_instdone_bit(uint32_t reg
Having one source for registers defines sounds like a good idea. These patches,
written long ago, were a baby step towards that goal by cleaning-up the
INSTDONE definitons to be like the kernel ones.
Along the way, I removed one tool that isn't even compiled and another unusued
one.
--
Damien
_
Follow up of the v3:
http://lists.freedesktop.org/archives/intel-gfx/2013-December/037333.html
The main change is the removal of INTEL_INFO() from the driver (patches 1 to
5), a clean-up suggested by Chris: the usage of that macro hides that we go
from dev to dev_priv while we could use the dev_
Finally, we reach the goal of the last few patches: the removal of
INTEL_INFO() in favor of a direct dev_priv usage.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915
The last occurences of INTEL_INFO() that weren't caught by the sed in:
drm/i915: Mass replace INTEL_INFO() by dev_priv->info
Nothing particularly noticeable except, maybe, the nice feeling of
removing a few back and forth between *dev and *dev_priv.
Signed-off-by: Damien Lespiau
---
: Ben Widawsky
Reviewed-by: Mika Kuoppala
Reviewed-by: Ville Syrjälä
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.c | 13 -
include/drm/i915_pciids.h | 9 -
2 files changed, 22 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gp
A pointer to the struct drm_device is not needed in a few of the WM
functions, so just pass a pointer to dev_priv.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_pm.c | 50 +
1 file changed, 26 insertions(+), 24 deletions(-)
diff --git a
e info fields at run-time.
v2: rename num_plane to num_sprites (Ville Syrjälä)
v3: Rebase on to of the INTEL_INFO() removal
Reviewed-by: Mika Kuoppala (for v2)
Reviewed-by: Ville Syrjälä (for v2)
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dm
While the longer goal is to have dev_priv == dev by properly subclassing
struct drm_device, quite a few macros in i915_drv.h need the dev
argument. Let's not try to disrupt everything yet and just remove their
usage of INTEL_INFO() as a first step.
Signed-off-by: Damien Lespiau
---
driver
)
Reviewed-by: Ville Syrjälä (for v3)
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_dma.c | 15 +++
drivers/gpu/drm/i915/i915_reg.h | 1 +
2 files changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index 953e35e..c208650
We had 2 set of defines for the same register, so make it one.
Reviewed-by: Mika Kuoppala
Reviewed-by: Ville Syrjälä
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_reg.h | 18 --
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
drivers/gpu/drm/i915
A lot of the WM functions are only reading from that structure and are
already using const. While converting the code to use dev_priv instead
of dev, I noticed a few places where we can give that hint.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_pm.c | 8
1 file
Reviewed-by: Mika Kuoppala
Reviewed-by: Ville Syrjälä
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_drv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index a0713e2..c289b8f 100644
--- a
On Mon, Jan 06, 2014 at 04:41:43PM -0800, Kenneth Graunke wrote:
> On 01/06/2014 07:02 AM, Damien Lespiau wrote:
> > Having one source for registers defines sounds like a good idea. These
> > patches,
> > written long ago, were a baby step towards that goal by cleanin
On Tue, Jan 07, 2014 at 09:07:10AM +0100, Daniel Vetter wrote:
> > - Quick! Merge patch 3 before it conflicts and someone needs to review
> > that giant thing again!
>
> As long as topic/ppgtt is still hanging out there and not yet merged into
> dinq that can't happen due to conflict galore. And s
v1)
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_display.c | 22 ++
drivers/gpu/drm/i915/intel_drv.h | 1 +
2 files changed, 23 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index ba9d62e..40a6247 10
we have an HDMI monitor on
> HSW and then suspend/resume.
>
> Cc: sta...@vger.kernel.org
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64379
> Tested-by: Qingshuai Tian
> Signed-off-by: Paulo Zanoni
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drive
On Wed, Jan 08, 2014 at 11:12:28AM -0200, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> LPT does have PCH refclk, but it's different form the IBX/CPT/PPT one
> and doesn't use the same structs. It is wrong to have a message saying
> that "LPT does not has PCH refclk" (sic). While at it, signal tha
On Wed, Jan 08, 2014 at 04:07:06PM +, devon.dav...@intel.com wrote:
> From: Devon Davies
>
> NDEBUG is defined by default in Android and causes assert(x) to be
> defined as void(x). This change ensures that asserts work as
> expected in tools.
>
> This flag is already inside tests/Android.mk
On Wed, Jan 08, 2014 at 05:13:28PM +, Mateo Lozano, Oscar wrote:
> > -Original Message-
> > From: intel-gfx-boun...@lists.freedesktop.org [mailto:intel-gfx-
> > boun...@lists.freedesktop.org] On Behalf Of devon.dav...@intel.com
> > Sent: Wednesday, January 08, 2014 4:07 PM
> > To: intel
This field is really the size of the per-driver private data attached to
a struct drm_buf. Name it accordingly and add a comment so it doesn't
get confused with, say, the size of the private data attatched to a struct
drm_device.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/drm_b
the device structure.
This patch enables drivers to declare the size of the device structure
they want DRM core to create for them.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/drm_stub.c | 8 +++-
include/drm/drmP.h | 8
2 files changed, 15 insertions(+), 1 deletion(-)
d
_private in our
struct drm_driver definition for the DRM core to allocate enough
space,
- to ease the transition, dev->dev_private is still valid and points
to the start of the structure.
- don't kfree dev_private either in the _load() error path or the
_unload() vfunc.
This field is only used when creating a new buffer and can already be
found in the drm_driver structure, so no need to duplicate the
information for every buffer.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/drm_bufs.c | 13 ++---
include/drm/drmP.h | 1 -
2 files changed
Not specifying it makes it a bit easier to identify drivers that really
need this field, and down the line, ease refactoring. This field doesn't
make sense for KMS drivers anyway.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/ast/ast_drv.c | 1 -
drivers/gpu/drm/qxl/qxl_
I was reminded on Monday that we'd like to be able to subclass struct
drm_device so we don't have to always juggle between a pointer to a struct
drm_device and its drv_private field to access everything we care about.
It'd be nicer for those two pointers to have the same value to avoid a few
extra
On Wed, Jan 08, 2014 at 09:26:51PM +0100, Daniel Vetter wrote:
> > So the parent structure is expected to have "struct drm_device" at
> > offset 0? I'd rather like to see a "drm_dev_init()" alongside
> > drm_dev_alloc() similar to device_initialize().
>
> Yeah, I think for subclassing we want driv
On Fri, Jan 10, 2014 at 05:10:20PM +0200, Jani Nikula wrote:
> It's an accident waiting to happen.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/intel_drv.h |4 ++--
> 1 file changed, 2 insertions(+), 2 deletio
There are only two cases here, pre and post SNB (PPGTT).
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/drivers/gpu/drm/i915/i915_gem_gtt.c
index
i
It looks that way indeed (not tested either).
Reviewed-by: Damien Lespiau
--
Damien
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Not tested.
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/driv
ck does could use a little update, in
any case:
Reviewed-by: Damien Lespiau
I can't review patch 3/3 as I wrote a part of it, we need to find a
victim.
--
Damien
> ---
> drivers/gpu/drm/i915/intel_display.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
On Tue, Jan 07, 2014 at 02:55:55PM -0200, Paulo Zanoni wrote:
> +static bool
> +intel_ddi_ensure_encoder_type(struct intel_encoder *encoder)
[...]
> + if (connector->base.status == connector_status_connected) {
> + DRM_DEBUG_KMS("Can't change DDI %c personality to
catch this case earlier
v4: Authorize unknown encoders with a "connected" connector to change
personality (Damien)
Testcase: igt/kms_setmode/clone-exclusive-crtc
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68463
Tested-by: Paulo Zanoni
Signed-off-by: Damien Lesp
On Tue, Jan 14, 2014 at 06:01:38PM +, robert.beck...@intel.com wrote:
> From: Robert Beckett
>
> Fix usage of shared variable LOCAL_PATH in deferred variable expansion area.
Out of curiosity, do you mind explaining what the late evaluation of
LOCAL_PATH broke? and why you didn't need to upda
On Tue, Jan 14, 2014 at 06:29:48PM +, Beckett, Robert wrote:
> In Makefile language, rule and dependency definitions use immediate
> expansions of variables, so they get expanded as soon as the rule is
> created (1st pass). Rule implementation (a.k.a recipe) use deferred
> expansion (2nd pass).
On Tue, Jan 14, 2014 at 06:14:07AM -0800, Ben Widawsky wrote:
> +#include
> +#include
> +#include
> +#include
> +#include
> +#if 0
> +#include
> +#include
> +#endif
Could remove that #if
Last time I remember we talked about a intel_display_test.c where we
could shove more stuff (Rodrigo's
On Tue, Jan 14, 2014 at 11:35:22PM +0100, Daniel Vetter wrote:
> On Tue, Jan 14, 2014 at 02:05:45PM -0800, Ben Widawsky wrote:
> > On Tue, Jan 14, 2014 at 11:04:16AM -0800, Jesse Barnes wrote:
> > > It ought to work ok in 3.14. We have some fun stuff coming after that,
> > > but all the basics are
Those are two distinct concepts. Just use a comment to remind us to
remove that W/A at some point.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_pm.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915
It can be handy at times to forbid i915 from loading at startup to
modprobe it later.
In particular, when trying to debug a problem that occurs at startup,
it's usually easier to boot into a working machine and modprobe the
driver at a more convenient time.
Signed-off-by: Damien Le
On Thu, Jan 16, 2014 at 07:07:09PM +0200, Ville Syrjälä wrote:
> On Thu, Jan 16, 2014 at 04:33:26PM +0000, Damien Lespiau wrote:
> > It can be handy at times to forbid i915 from loading at startup to
> > modprobe it later.
>
> modprobe.blacklist=i915
Ah, yeah, th
On Tue, Jan 14, 2014 at 04:21:50PM -0200, Rodrigo Vivi wrote:
> This debugfs interface will allow intel-gpu-tools test case
> to verify if screen has been updated properly on cases like PSR.
>
> v2: Accepted all Daniel's suggestions:
> * grab modeset lock
> * loop over connector and check
On Thu, Jan 16, 2014 at 05:55:06PM +, Damien Lespiau wrote:
> > + /* Wait 2 vblanks to be sure we will have the correct CRC value */
> > + intel_wait_for_vblank(dev, intel_crtc->pipe);
> > + intel_wait_for_vblank(dev, intel_crtc->pipe);
>
> I think t
On Thu, Jan 16, 2014 at 08:06:08PM -0700, Todd Previte wrote:
> For HSW+ platforms, enable the 5.4Ghz (HBR2) link rate for devices that
> support it. The
> sink device must report that is supports Displayport 1.2 and the HBR2 bit
> rate in the
> DPCD in order to use HBR2.
> ---
> drivers/gpu/drm
601 - 700 of 2567 matches
Mail list logo
