Re: [Intel-gfx] [PATCH 43/49] drm/i915/bdw: Handle context switch events

On Thu, Mar 27, 2014 at 06:00:12PM +, oscar.ma...@intel.com wrote: > +void gen8_handle_context_events(struct intel_engine *ring) > +{ > + struct drm_i915_private *dev_priv = ring->dev->dev_private; > + u32 status_pointer; > + u8 read_pointer; > + u8 write_pointer; > + u32 st

Re: [Intel-gfx] [PATCH] drm/i915: fix command parser debug print format mismatches

On Thu, Apr 03, 2014 at 11:32:30AM +0200, Daniel Vetter wrote: > On Wed, Apr 02, 2014 at 08:26:23AM -0700, Randy Dunlap wrote: > > On 04/02/2014 01:24 AM, Jani Nikula wrote: > > > Drop the cast from the pointer diff to fix: > > > > > > drivers/gpu/drm/i915/i915_cmd_parser.c:405:4: warning: format

Re: [Intel-gfx] [PATCH 42/49] drm/i915/bdw: Get prepared for a two-stage execlist submit process

On Thu, Mar 27, 2014 at 06:00:11PM +, oscar.ma...@intel.com wrote: > +int gen8_switch_context_queue(struct intel_engine *ring, > + struct i915_hw_context *to, > + u32 tail) > +{ > + struct drm_i915_gem_request *req = NULL; > + unsigned

Re: [Intel-gfx] [PATCH 42/49] drm/i915/bdw: Get prepared for a two-stage execlist submit process

On Fri, Apr 04, 2014 at 12:12:35PM +0100, Damien Lespiau wrote: > On Thu, Mar 27, 2014 at 06:00:11PM +, oscar.ma...@intel.com wrote: > > +int gen8_switch_context_queue(struct intel_engine *ring, > > + struct i915_hw_context *to, > > +

[Intel-gfx] [PATCH 0/2] Module parameter to enable execlists

I feel like it'd be wise, when we merge execlists support, to provide a way to disable them, just in case. Actually, it may be even wiser, would we want to merge them early, to merge execlists disabled by default. -- Damien Damien Lespiau (2): drm/i915: Factor out a enable_exec

[Intel-gfx] [PATCH 2/2] drm/i915: Add a module parameter to enable execlists

bug subtle problems that will inevitably arise. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h| 1 + drivers/gpu/drm/i915/i915_gem.c| 3 +++ drivers/gpu/drm/i915/i915_params.c | 6 ++ 3 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drive

[Intel-gfx] [PATCH 1/2] drm/i915: Factor out a enable_execlists() function

So it's clear what the condition is. We'll add a bit more code shortly. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_gem.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c ind

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add a module parameter to enable execlists

On Mon, Apr 07, 2014 at 03:05:39PM +0100, Damien Lespiau wrote: > Execlist are relatively new, and so it'd be wise to be able to merge > that support disabled by default while still allowing a module parameter > to enable that feature. > > Even if we end up enabling execlists

Re: [Intel-gfx] [PATCH 44/49] drm/i915/bdw: Display execlists info in debugfs

On Thu, Mar 27, 2014 at 06:00:13PM +, oscar.ma...@intel.com wrote: > From: Oscar Mateo > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -2347,6 +2347,7 @@ int gen8_switch_context_queue(struct intel_engine *ring, > struct i915_hw_c

Re: [Intel-gfx] [PATCH 00/49] Execlists

On Thu, Mar 27, 2014 at 05:59:29PM +, oscar.ma...@intel.com wrote: > From: Oscar Mateo > > Hi all, > > This patch series implement execlists for GEN8+. Before continuing, it > is important to mention that I might have taken upon myself to > assemble the series and rewrite it for upstreaming,

[Intel-gfx] [PATCH 1/3] drm/i915: Protect the argument expansion in LRI and SRM macros

It seems like it wouldn't be too unlikely to be wanting to use a an expression in the macro argument and things could go very wrong. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 3/3] drm/i915/bdw: Use the GEN8 SRM when qeueing a flip

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 3697433..a646ed4 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/3] drm/i915/bdw: Provide a gen8 version of SRM

GEN8 now has a qword to code for 48bit addresses. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 22d8b14..bc5ec33 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/3] GEN8 SRM changes

STORE_REGISTER_MEM has now one extra dword on gen8. This series is not exactly well tested. -- Damien Damien Lespiau (3): drm/i915: Protect the argument expansion in LRI and SRM macros drm/i915/bdw: Provide a gen8 version of SRM drm/i915/bdw: Use the GEN8 SRM when qeueing a flip drivers

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bdw: Use the GEN8 SRM when qeueing a flip

On Mon, Apr 07, 2014 at 01:59:17PM -0700, Ben Widawsky wrote: > Cool. This explains the bad DERRMR values I was seeing in in error > states. I'm honestly didn't check if we actually need an SRM for BDW > still, but I'll assume you did check. Just checked, the LRI command still mentions that we nee

[Intel-gfx] [PATCH] drm/i915: Rename GEN8_PIPE_FLIP_DONE to PRIMARY_FLIP_DONE

It is now clear that this interrupt is for the primary plane and not something global to the pipe. It also matches what the spec calls it. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 3 insertions(+), 3

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bdw: Use the GEN8 SRM when qeueing a flip

On Tue, Apr 08, 2014 at 07:24:23AM +0100, Chris Wilson wrote: > On Mon, Apr 07, 2014 at 11:20:14PM +0100, Damien Lespiau wrote: > > On Mon, Apr 07, 2014 at 01:59:17PM -0700, Ben Widawsky wrote: > > > Cool. This explains the bad DERRMR values I was seeing in in error > >

[Intel-gfx] [PATCH] drm/i915: Remove misleading debug message

haswell_write_eld() is also used on broadwell, so let's not explicitely mention Haswell. The rest of the function has plenty of debug output which will print the function name, so we know where we are anyway. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 3 --- 1

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915: New drm crtc property for varying the size of borders

On Tue, Apr 08, 2014 at 05:31:06PM +0100, Damien Lespiau wrote: > On Mon, Apr 07, 2014 at 04:06:34AM +, Goel, Akash wrote: > > Hi Ville, > > > > Please could you review this patch. > > You need a pass of checkpatch.pl in here. Not sure what happened with > the

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915: New drm crtc property for varying the size of borders

On Mon, Apr 07, 2014 at 04:06:34AM +, Goel, Akash wrote: > Hi Ville, > > Please could you review this patch. You need a pass of checkpatch.pl in here. Not sure what happened with the coding style. -- Damien ___ Intel-gfx mailing list Intel-gfx@lis

[Intel-gfx] [PATCH] drm/i915: Remove spurious semicolons

Found by running the semicolon.cocci spatch: https://github.com/coccinelle/coccinellery/blob/master/semicolon/semicolon.cocci Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/dvo_ch7xxx.c | 2 +- drivers/gpu/drm/i915/dvo_ivch.c | 2 +- drivers/gpu/drm/i915/dvo_ns2501.c | 2

Re: [Intel-gfx] [PATCH 71/71] drm/i915/chv: Handle video DIP registers on CHV

sets, we'd need a new pipe offset per > register, which seems wasteful. So instead just use the _PIPE3() macro > to handle these registers. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/i915_reg.h | 17

Re: [Intel-gfx] [PATCH 70/71] drm/i915: Don't use pipe_offset stuff for DPLL registers

to be more obvious, and protect the > arguments properly. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/bdw: BDW swizzling in done by the memory controller

't have to manually swizzle when accessing tiled buffers from the CPU, and so we always return I915_BIT_6_SWIZZLE_NONE from i915_gem_detect_bit_6_swizzle(), which short-circuits the initialization of the registers mentionned above in i915_gem_init_swizzling(). Signed-off-by: Damien Lespiau ---

[Intel-gfx] [PATCH] BDW swizzling

a machine to test this theory on. -- Damien Damien Lespiau (1): drm/i915/bdw: BDW swizzling in done by the memory controller drivers/gpu/drm/i915/i915_gem.c| 2 -- drivers/gpu/drm/i915/i915_gem_tiling.c | 10 +- drivers/gpu/drm/i915/i915_reg.h| 1 - 3 files

Re: [Intel-gfx] [PATCH] BDW swizzling

On Thu, Apr 10, 2014 at 10:32:46AM -0700, Ben Widawsky wrote: > On Thu, Apr 10, 2014 at 05:24:07PM +0100, Damien Lespiau wrote: > > While cruising through the specs, I noticed a note about swizzling changes > > on > > BDW. My understanding is that we don't need to e

Re: [Intel-gfx] [PATCH] drm/i915/bdw: BDW swizzling in done by the memory controller

On Fri, Apr 11, 2014 at 11:09:03AM +0200, Daniel Vetter wrote: > So not yet sold on the story here, at least for gen8/bdw. Apparently > people haven't screamed about this yet, so it probably works. Having thought about it a bit more, I don't see how the CPU side would know about the tiling layout

Re: [Intel-gfx] [PATCH] tests: add gem_reset_stats

On Tue, Nov 12, 2013 at 07:58:16PM +0200, Mika Kuoppala wrote: > + buf[roff] = MI_BATCH_BUFFER_START; > + buf[roff + 1] = gtt_off + (roff << 2); I was thinking that this probably need to be adapted for BDW if we want to loop at the right address (MI_BATCH_BUFFER_START has an extra dword, a

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use for_each_pipe in intel_display_crc_init

On Thu, Nov 14, 2013 at 11:30:42AM +0100, Daniel Vetter wrote: > We have a nice macro, so use it. > > Signed-off-by: Daniel Vetter For both patches: Reviewed-by: Damien Lespiau -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freede

[Intel-gfx] [igt] Making the test-suite easier to run

The objective of this series is to make the test-suite easier to run by embedding a copy a piglit and providing porcelain on top of it in the form of a makefile target. Beside python, there's no external dependency to run the test suite after this series. The provided makefile target runs the full

[Intel-gfx] [PATCH 04/23] piglit: Adapt igt.tests to discover the tests directory itself

Signed-off-by: Damien Lespiau --- piglit/tests/igt.tests | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/piglit/tests/igt.tests b/piglit/tests/igt.tests index f388492..16e4586 100644 --- a/piglit/tests/igt.tests +++ b/piglit/tests/igt.tests @@ -31,20 +31,10

[Intel-gfx] [PATCH 03/23] piglit: Import igt.tests from piglit

Signed-off-by: Damien Lespiau --- piglit/tests/igt.tests | 125 + 1 file changed, 125 insertions(+) create mode 100644 piglit/tests/igt.tests diff --git a/piglit/tests/igt.tests b/piglit/tests/igt.tests new file mode 100644 index 000..f388492

[Intel-gfx] [PATCH 07/23] piglit: Support resuming from a previous run

E=20131114-piglit-results.1 Signed-off-by: Damien Lespiau --- Makefile.am | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index 471dd3d..5742b82 100644 --- a/Makefile.am +++ b/Makefile.am @@ -58,9 +58,18 @@ TEST_TARGETS := # TEST_TARG

[Intel-gfx] [PATCH 01/23] piglit: Add a script to synchronise the piglit test runner

The goal is to to remove the need to clone and compile piglit to run a piglit enabled igt. Compiling piglit is not actually needed and we can just grab the python files from a reference checktout. Signed-off-by: Damien Lespiau --- piglit/sync-from-piglit | 24 1 file

[Intel-gfx] [PATCH 23/23] pm_pc8: Use SLOW_QUICK() with the number of rounds

igt has some test suite wide support to specify slow/quick numbers of rounds with the SLOW_QUICK() macro. This allows us to run the tests with IGT_QUICK=1 and get the fast version of tests and provide a unified interface. Cc: Paulo Zanoni Signed-off-by: Damien Lespiau --- tests/pm_pc8.c | 2

[Intel-gfx] [PATCH 19/23] piglit: Update the README file with the new way of running tests

Signed-off-by: Damien Lespiau --- README | 54 -- 1 file changed, 32 insertions(+), 22 deletions(-) diff --git a/README b/README index 246e24c..021888f 100644 --- a/README +++ b/README @@ -24,38 +24,48 @@ tests/ changes. Hopefully

[Intel-gfx] [PATCH 22/23] lib: Change SLOW_QUICK() to use igt_run_quick()

IGT_QUICK=1 is now triggering the quick version of the tests. Signed-off-by: Damien Lespiau --- lib/drmtest.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/drmtest.h b/lib/drmtest.h index c93fe6b..3a07329 100644 --- a/lib/drmtest.h +++ b/lib/drmtest.h @@ -303,7 +303,7

[Intel-gfx] [PATCH 20/23] framework: Dump the result of 'uname -a' in the report

Sent to the piglit ml: http://lists.freedesktop.org/archives/piglit/2013-November/008465.html Signed-off-by: Damien Lespiau --- piglit/framework/core.py | 3 +++ piglit/framework/summary.py| 1 + piglit/templates/testrun_info.mako | 6 ++ 3 files changed, 10 insertions

[Intel-gfx] [PATCH 13/23] piglit: Add a hint that there's an HTML summary

And also add the possibility for someone to copy/paste the index.html path to view the HTML summary for use with, say, xdg-open. Signed-off-by: Damien Lespiau --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 4eace31..bd86a29 100644 --- a

[Intel-gfx] [PATCH 10/23] piglit: Run our test suite with --no-concurrency

Tests tend to assume they are the only thing running, some need DRM master, some fill the memory. All in all, they are some correctness issues if we run tests concurrently. Acked-by: Ben Widawsky Signed-off-by: Damien Lespiau --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Intel-gfx] [PATCH 06/23] piglit: Add the option to inject piglit arguments

This is useful in extreme cases (for instance, to exclude drv_module_reload if known to fail). Signed-off-by: Damien Lespiau --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 8611929..471dd3d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -61,6

[Intel-gfx] [PATCH 05/23] piglit: Add a 'run-tests' Makefile target

Let's start to craft porcelain targets to run the test suite. First stop, run the piglit tests enumerated by igt.tests. Signed-off-by: Damien Lespiau --- Makefile.am | 20 scripts/Makefile.am | 2 +- scripts/build-piglit.sh | 20 ++

[Intel-gfx] [PATCH 21/23] lib: Introduce igt_run_quick()

simulation before looking at the IGT_QUICK env variable. Signed-off-by: Damien Lespiau --- lib/drmtest.c | 15 +++ lib/drmtest.h | 3 ++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 15ed847..5760c87 100644 --- a/lib/dr

[Intel-gfx] [PATCH 08/23] piglit: Merge filters from previous invocations when resuming

This commit has been posted to the piglit ml: http://lists.freedesktop.org/archives/piglit/2013-November/008452.html Signed-off-by: Damien Lespiau --- piglit/piglit-run.py | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/piglit/piglit-run.py b/piglit/piglit

[Intel-gfx] [PATCH 16/23] drm_lib.sh: Tune the DRM master message a bit

check_drm_clients can be used to make sure there's no master running. Tune a bit the error message as this is really what we want to test. Signed-off-by: Damien Lespiau --- tests/drm_lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/drm_lib.sh b/tests/drm_l

[Intel-gfx] [PATCH 15/23] piglit: Support R= as RESUME= for the lazies

Signed-off-by: Damien Lespiau --- Makefile.am | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Makefile.am b/Makefile.am index bd86a29..5086406 100644 --- a/Makefile.am +++ b/Makefile.am @@ -58,13 +58,14 @@ TEST_TARGETS := # TEST_TARGETS += run-test run-tests

[Intel-gfx] [PATCH 17/23] piglit: Make sure there's no DRM master before launching the tests

Also, use && between statements so we stop the chain once something fails. Signed-off-by: Damien Lespiau --- Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 5086406..e790efe 100644 --- a/Makefile.am +++ b/Makefile.am

[Intel-gfx] [PATCH 18/23] piglit: Make sure we are running the tests as root

Signed-off-by: Damien Lespiau --- Makefile.am| 1 + tests/Makefile.sources | 1 + tests/check_root | 5 + 3 files changed, 7 insertions(+) create mode 100755 tests/check_root diff --git a/Makefile.am b/Makefile.am index e790efe..7988d01 100644 --- a/Makefile.am +++ b

[Intel-gfx] [PATCH 12/23] piglit: Always write the HTML test results

Even if a previous run has already done it. Useful when resuming an already done test (which in turns is useful to load/write the json file to apply any piglit change). Signed-off-by: Damien Lespiau --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am

[Intel-gfx] [PATCH 09/23] piglit: Fix resuming of previous runs

Signed-off-by: Damien Lespiau --- piglit/framework/core.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/piglit/framework/core.py b/piglit/framework/core.py index e7767c2..e0fe46c 100644 --- a/piglit/framework/core.py +++ b/piglit/framework/core.py @@ -58,6 +5

[Intel-gfx] [PATCH 11/23] piglit: Generate a Makefile.am from the sync script

When syncing the piglit runner, also generate the Makefile.am to include the runner in a dist'ed tarball Signed-off-by: Damien Lespiau --- Makefile.am | 2 +- configure.ac| 1 + piglit/Makefile.am | 29 + piglit/sync-from-piglit

[Intel-gfx] [PATCH 14/23] framework: Humanize time values in the HTML report

test should be that long! (Daniel Vetter) Display 1 decimal if the duration is < 60s (Daniel Vetter) Sent to the piglit ml: http://lists.freedesktop.org/archives/piglit/2013-November/008464.html Signed-off-by: Damien Lespiau --- piglit/framework/summary

Re: [Intel-gfx] [PATCH 10/23] piglit: Run our test suite with --no-concurrency

On Fri, Nov 15, 2013 at 06:08:27PM +0100, Daniel Vetter wrote: > On Fri, Nov 15, 2013 at 04:33:27PM +0000, Damien Lespiau wrote: > > Tests tend to assume they are the only thing running, some need DRM > > master, some fill the memory. All in all, they are some correctness >

Re: [Intel-gfx] [PATCH 16/23] drm_lib.sh: Tune the DRM master message a bit

On Fri, Nov 15, 2013 at 06:13:48PM +0100, Daniel Vetter wrote: > On Fri, Nov 15, 2013 at 04:33:33PM +0000, Damien Lespiau wrote: > > check_drm_clients can be used to make sure there's no master running. > > Tune a bit the error message as this is really what we want to test. &g

Re: [Intel-gfx] [igt] Making the test-suite easier to run

On Fri, Nov 15, 2013 at 04:33:17PM +, Damien Lespiau wrote: > Another useful feature is to be able to resume an interrupted run. To > do that, make run-tests needs to know which run we are talking about: There's a known bug with piglit here in that resuming doesn

Re: [Intel-gfx] [PATCH 19/23] piglit: Update the README file with the new way of running tests

On Fri, Nov 15, 2013 at 06:16:08PM +0100, Daniel Vetter wrote: > On Fri, Nov 15, 2013 at 04:33:36PM +0000, Damien Lespiau wrote: > > Signed-off-by: Damien Lespiau > > Hm, I'd keep the references to the real piglit somewhere, since our copy > here is just for convenie

Re: [Intel-gfx] [igt] Making the test-suite easier to run

On Fri, Nov 15, 2013 at 06:23:18PM +0100, Daniel Vetter wrote: > - I think we need to make it very clear that piglit should still be > developed upstream. So local changes shouldn't be allowed at all imo. Sure, I'll wait until my patches are upstreamed to resend the series without the local patc

Re: [Intel-gfx] [PATCH] intel: Add support for GPU reset status query ioctl

here are still some > deltas between the kernel i915_drm.h and the one in libdrm, but those > can be resolved in other patches. > > Signed-off-by: Ian Romanick > Reviewed-by: Kenneth Graunke [v3] > Cc: Mika Kuoppala > Cc: Daniel Vetter Looks good to me.

Re: [Intel-gfx] [PATCH 1/2] drm/i915: reuse WRPLL when possible

-off-by: Paulo Zanoni Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_ddi.c | 37 ++--- > 1 file changed, 22 insertions(+), 15 deletions(-) > > It is that easy because I already planned to enable PLL sharing

Re: [Intel-gfx] [PATCH 2/2] drm/i915: split intel_ddi_pll_mode_set in 2 pieces

On Wed, Oct 30, 2013 at 06:27:44PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > @@ -657,10 +657,8 @@ bool intel_ddi_pll_mode_set(struct drm_crtc *crtc) > return false; > } > > - /* We don't need to turn any PLL on because we'll use LCPLL. */ >

Re: [Intel-gfx] [PATCH] intel: make sure VG_CLEAR() will always do memory clear

On Wed, Nov 20, 2013 at 05:22:48PM +0800, Zhenyu Wang wrote: > If valgrind is not available, current VG_CLEAR() would just ignore > memory clear operation which might make invalid ioctl argument. So > make sure VG_CLEAR() will always clear memory. > --- > intel/intel_bufmgr_gem.c | 2 +- > 1 file

Re: [Intel-gfx] [PATCH] intel: Use memset instead of VG_CLEAR

by: Zhenyu Wang > Cc: Damien Lespiau > Cc: Daniel Vetter I was thinking that I missed it in the (lidrm) review, but it's actually a newer patch that introduces the checks. Lesson learned for next ioctl reviews (kernel), have a better pass on the input validation and think about rejecti

Re: [Intel-gfx] [PATCH] intel: make sure VG_CLEAR() will always do memory clear

On Wed, Nov 20, 2013 at 11:53:54PM +0800, Zhenyu Wang wrote: > > VG_CLEAR() is really just for valgrind. If you need to set some specific > > variable/field to 0 then you need to set it to 0 and not rely on > > VG_CLEAR() to do it for you. > > > > ok, in valgrind case it does memory clear for ioc

Re: [Intel-gfx] AVI infoframes: default aspect ratio/VIC for CEA modes

On Wed, Nov 20, 2013 at 09:48:26PM +, Gohad, Tushar wrote: > Folks, > > A newbie question - When filling in an HDMI AVI infoframe, how does > one correctly determine the "default" picture aspect ratio (and VIC) > for CEA modes that support multiple (4:3 and 16:9) aspect ratios. > 720x576p for

Re: [Intel-gfx] AVI infoframes: default aspect ratio/VIC for CEA modes

On Wed, Nov 20, 2013 at 10:11:55PM +, Damien Lespiau wrote: > On Wed, Nov 20, 2013 at 09:48:26PM +, Gohad, Tushar wrote: > > Folks, > > > > A newbie question - When filling in an HDMI AVI infoframe, how does > > one correctly determine the "default" p

Re: [Intel-gfx] AVI infoframes: default aspect ratio/VIC for CEA modes

On Wed, Nov 20, 2013 at 11:45:03PM +, Gohad, Tushar wrote: > > > On Wed, Nov 20, 2013 at 09:48:26PM +, Gohad, Tushar wrote: > > > > Folks, > > > > > > > > When filling in an HDMI AVI infoframe, how does > > > > one correctly determine the "default" picture aspect ratio (and VIC) > > > > for

Re: [Intel-gfx] AVI infoframes: default aspect ratio/VIC for CEA modes

On Thu, Nov 21, 2013 at 07:19:45PM +0200, Ville Syrjälä wrote: > > > It seems natural to extend those flags to describe the picture aspect > > > ratio (that > > > why dri-devel is in Cc., touching core DRM). > > > > To start with we can use a single bit in drm_display_mode->flags to > > distingu

[Intel-gfx] [PATCH 1/2] intel_dump_decode: Actually parse the -d option

Signed-off-by: Damien Lespiau --- tools/intel_dump_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/intel_dump_decode.c b/tools/intel_dump_decode.c index a3cd2e5..959ec87 100644 --- a/tools/intel_dump_decode.c +++ b/tools/intel_dump_decode.c @@ -168,7 +168,7

[Intel-gfx] [PATCH 2/2] intel_dump_decode: Support the INTEL_DEVID_OVERRIDE env variable

This is the one that already works in libdrm, so don't disappoint people coming with expectations. Signed-off-by: Damien Lespiau --- tools/intel_dump_decode.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/intel_dump_decode.c b/tools/intel_dump_decode.c

[Intel-gfx] Fix gen8 rendercopy instruction lengths

Kayden noticed a few of those were wrong. It's clearly time to fix them! -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 2/4] rendercopy/bdw: Fix the various 3DSTATE_CONSTANT_* instruction length

Signed-off-by: Damien Lespiau --- lib/rendercopy_gen8.c | 48 +++- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c index 723f4ef..8bcf2bb 100644 --- a/lib/rendercopy_gen8.c +++ b/lib

[Intel-gfx] [PATCH 1/4] rendercopy/bdw: Fix the STATE_SIP instruction length

Signed-off-by: Damien Lespiau --- lib/rendercopy_gen8.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c index 660ff03..723f4ef 100644 --- a/lib/rendercopy_gen8.c +++ b/lib/rendercopy_gen8.c @@ -470,8 +470,9

[Intel-gfx] [PATCH 3/4] rendercopy/bdw: Fix the 3DSTATE_HIER_DEPTH_BUFFER instruction length

Signed-off-by: Damien Lespiau --- lib/rendercopy_gen8.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c index 8bcf2bb..0eeb179 100644 --- a/lib/rendercopy_gen8.c +++ b/lib/rendercopy_gen8.c @@ -783,7 +783,9 @@ gen8_emit_depth

[Intel-gfx] [PATCH 4/4] rendercopy/bdw: Fix the 3DSTATE_STENCIL_BUFFER instruction length

Signed-off-by: Damien Lespiau --- lib/rendercopy_gen8.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c index 0eeb179..8d7d88b 100644 --- a/lib/rendercopy_gen8.c +++ b/lib/rendercopy_gen8.c @@ -789,7 +789,9 @@ gen8_emit_depth

Re: [Intel-gfx] [PATCH] tests/igt: Add runtime environment checks

On Tue, Nov 26, 2013 at 11:49:43AM -0800, Ben Widawsky wrote: > > Only in the make target he created, not in piglit itself. Imo we should > > have all the testrunner logic in one place, i.e. in the piglit sources. > > -Daniel > > Damien, can you comment? I could have sworn you said something diffe

Re: [Intel-gfx] [PATCH] drm/i915: drop DRM_ERROR in intel_fbdev init

On Tue, Nov 26, 2013 at 11:25:54AM -0800, Jesse Barnes wrote: > This should just be a debug. Add another debug msg to the inherit path > while we're at it. > > Signed-off-by: Jesse Barnes Reviewed-by: Damien Lespiau Bugzilla: https://bugs.freedesktop.org/show

Re: [Intel-gfx] [PATCH 1/2] intel_dump_decode: Actually parse the -d option

On Fri, Nov 22, 2013 at 05:33:41PM +, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau No screams, pushed the 2 commits. -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/in

Re: [Intel-gfx] Fix gen8 rendercopy instruction lengths

On Fri, Nov 22, 2013 at 06:25:58PM +, Damien Lespiau wrote: > Kayden noticed a few of those were wrong. It's clearly time to fix them! No screams, pushed. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedes

[Intel-gfx] [PATCH 1/2] drm: Make the connector mode_valid() vfunc return a drm_mode_status enum

To make it clear what exactly mode_valid() should return. Signed-off-by: Damien Lespiau --- include/drm/drm_crtc_helper.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_crtc_helper.h b/include/drm/drm_crtc_helper.h index ef6ad3a..b1388b5 100644 --- a

[Intel-gfx] [PATCH 2/2] drm/i915: Return a drm_mode_status enum in the mode_valid vfuncs

We had some mode_valid() vfuncs returning an int, others the enum. Let's use the latter everywhere. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_crt.c | 5 +++-- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_dsi.c | 5 +++-- drivers/gpu/drm

[Intel-gfx] Modeset without a detected monitor on DDI platforms

Here's a tentative patch that I unfortunately can't test on HSW because my dev machine seems quite unhappy. The patch had limited testing on simulation though. The general problem is that intel_digital_port encoders personalities (ie intel_encoder->type) are only set by ->detect() at the moment. I

[Intel-gfx] [PATCH] drm/i915: Set the digital port encoder personality during modeset

the DDI encoder as part of a modeset, we need to ensure that the personality of the encoder matches the selected connector. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ddi.c | 50 drivers/gpu/drm/i915/intel_display.c | 2 ++ drivers/gpu/

[Intel-gfx] [PATCH 1/2] drm/i915: Introduce new intel_output_name()

That we can use for debugging purposes. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 13 + drivers/gpu/drm/i915/intel_drv.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/2] drm/i915: Set the digital port encoder personality during modeset

the DDI encoder as part of a modeset, we need to ensure that the personality of the encoder matches the selected connector. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ddi.c | 85 1 file changed, 85 insertions(+) diff --git a/drivers/gpu/

[Intel-gfx] Modeset without a detected monitor on DDI platforms v2.5

Completely untested, so buggy, I'm sure. In any case, might be of some use. You're in a much better position to do this, I don't have a DDI machine that works. -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop

Re: [Intel-gfx] [PATCH] drm/i915: Skip clock checks on BDW

On Mon, Dec 02, 2013 at 11:23:39AM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We don't have clock state readout support for DDI, so skip the pipe > config clock checks on all DDI platforms. > > Signed-off-by: Ville Syrjälä Reviewed-by: Dami

Re: [Intel-gfx] [PATCH 4/6] drm/i915: use __packed instead of __attribute__((packed))

gt; Signed-off-by: Jani Nikula > Signed-off-by: Rodrigo Vivi Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_bios.h | 48 > +- > drivers/gpu/drm/i915/intel_opregion.c | 8 +++--- > drivers/gpu/drm/i915/intel_sdvo_reg

[Intel-gfx] Some DisplayPort clean-ups

While cruising in intel_dp.c, a few things caught my eye. -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/4] drm/i915: Fix copy/paste DP vs eDP error in comment

It's all about tiny details. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index c8382f5..c8a5fb7 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH 3/4] drm/i915: Remove if 0'ed static arrays

Sweeping some dead code away. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_dp.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 7a825db..07fcc9e 100644 --- a/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH 4/4] drm/i915: Cleanup the DP_AUX_CTL macros

Let's use a less verbose version to fill the DP_AUX_CTL register. Improves the readability a little bit. Also sort the fields by their place in the register. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 8 drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH 2/4] drm/i915: Remove the has_aux_irq = false code path in intel_dp_aux_ch()

has_aux_irq is initialized to true and never touched again these days. Just remove it along with the has_aux_irq = false code path. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_dp.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 7/7] drm/i915: Use I915_MAX_PIPES in the pipe/plane_to_crtc_mapping definitions

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 8a3e5cd..85d126e 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm

[Intel-gfx] [PATCH 6/7] drm/i915: Remove the Quanta special case

We now read out the FUSE_STRAP register, looking for configurations with display fused off. Let's remove the Quanta special case and rely on the programmed fuses to set num_pipes to 0. This patch is untested. Cc: Ben Widawsky Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH 4/7] drm/i915: Disable display when fused off

FUSE_STRAP has a bit to inform us that the display has been fused off. Use it to setup the definitive number of pipes at run-time. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_dma.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers

[Intel-gfx] [PATCH 5/7] drm/i915: Support fused off pipe C configurations

Starting from IVB, pipe C can be fused off. We have yet to see such configuration in the wild though (ie not tested). Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_dma.c | 4 drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 3/7] drm/i915: Consolidate FUSE_STRAP in one set of defines

We had 2 set of defines for the same register, so make it one. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 18 -- drivers/gpu/drm/i915/intel_ddi.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 3 +-- 3 files changed, 10 insertions(+), 13

[Intel-gfx] [PATCH 1/7] drm/i915: Make the intel_device_info structure kept in dev_priv writable

quite sure we'll find other flags/limits to stick into dev_priv->info. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_dma.c | 4 +- drivers/gpu/drm/i915/i915_drv.h | 4 +- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/i915_irq.c | 4 +

[Intel-gfx] [PATCH 2/7] drm/i915: Move num_plane to the intel_device_info structure

d-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_dma.c | 21 ++--- drivers/gpu/drm/i915/i915_drv.h | 5 ++--- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 3 files changed, 22 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers

[Intel-gfx] Supporting fused display configurations

A while ago, Ben added support for Quanta devices that had the display hardware fused off. We can a bit more general than that by reading the FUSE_STRAP register and setting num_pipes to 0 when detecting such condition. To achieve that, the intel_device_info structure in dev_priv needed to be made

<    1   2   3   4   5   6   7   8   9   10   >