Re: [Intel-gfx] [PATCH] tests: scrap old automake based kernel test runner

. > > References: > https://lists.gnu.org/archive/html/help-debbugs/2013-06/msg0.html > Signed-off-by: Daniel Vetter If you need one of those: Acked-by: Damien Lespiau > --- > Makefile.am | 3 --- > README| 25 ++--- > tests/Make

[Intel-gfx] HDMI 4k support v2

Following up the first instance of this series: http://lists.freedesktop.org/archives/dri-devel/2013-August/043125.html Here is a v2 with Ville's review pass and a few additions: - Alternate clock modes for 4k resolutions - HDMI vendor specific infoframe support in drivers/video/hdmi.c - E

[Intel-gfx] [PATCH 01/12] drm: Don't export drm_find_cea_extension() any more

This function is only used inside drm_edid.c. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 5 ++--- include/drm/drm_crtc.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index dfc7a1b..e014785

[Intel-gfx] [PATCH 02/12] drm/edid: Fix add_cea_modes() style issues

A few styles issues have crept in here, fix them before touching this code again. v2: constify arguments that can be (Ville Syrjälä) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 03/12] drm/edid: Parse the HDMI CEA block and look for 4k modes

earer that offset is relative to the end of the required fields of the HDMI VSDB (Ville Syrjälä) Signed-off-by: Damien Lespiau Tested-by: Cancan Feng Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67030 --- drivers/gpu/drm/drm_edid.c | 124 +++--

[Intel-gfx] [PATCH 04/12] drm: Add support for alternate clocks of 4k modes

Suggested-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 68 ++ 1 file changed, 62 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 0faa08e..606335f 100644

[Intel-gfx] [PATCH 05/12] video/hdmi: Don't let the user of this API create invalid infoframes

To set the active aspect ratio value in the AVI infoframe today, you not only have to set the active_aspect field, but also the active_info_valid bit. Out of the 1 user of this API, we had 100% misuse, forgetting the _valid bit. This was fixed in: Author: Damien Lespiau Date: Tue Aug 6 20

[Intel-gfx] [PATCH 06/12] video/hdmi: Derive the bar data valid bit from the bar data fields

Just like: Author: Damien Lespiau Date: Mon Aug 12 11:53:24 2013 +0100 video/hdmi: Don't let the user of this API create invalid infoframes But this time for the horizontal/vertical bar data present bits. Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 5 +++-- in

[Intel-gfx] [PATCH 07/12] video/hdmi: Introduce helpers for the HDMI vendor specific infoframe

Provide the programming model than the other infoframe types. The generic _pack() function can't handle those yet as we need to move the vendor OUI in the generic hdmi_vendor_infoframe structure to know which kind of vendor infoframe we are dealing with. Signed-off-by: Damien Le

[Intel-gfx] [PATCH 08/12] gpu: host1x: Port the HDMI vendor infoframe code the common helpers

I just wrote the bits to define and pack HDMI vendor specific infoframe. Port the host1x driver to use those so I can refactor the infoframe code a bit more. Cc: Thierry Reding Cc: Terje Bergström Cc: linux-te...@vger.kernel.org Signed-off-by: Damien Lespiau --- drivers/gpu/host1x/drm/hdmi.c

[Intel-gfx] [PATCH 09/12] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

HDMI, but details..) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 1 - include/linux/hdmi.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index ec47eb8..9a07a33 100644 --- a/drivers/gpu/drm/drm_ed

[Intel-gfx] [PATCH 10/12] video/hdmi: Hook the HDMI vendor infoframe with the generic _pack()

this API has been ported in: Author: Damien Lespiau Date: Mon Aug 12 18:08:37 2013 +0100 gpu: host1x: Port the HDMI vendor infoframe code the common helpers Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 45 + include/linux/h

[Intel-gfx] [PATCH 11/12] drm: Add a helper to forge HDMI vendor infoframes

This can then be used by DRM drivers to setup their vendor infoframes. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 36 include/drm/drm_edid.h | 4 2 files changed, 40 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b

[Intel-gfx] [PATCH 12/12] drm/i915/hdmi: Write HDMI vendor specific infoframes

With all the common infoframe bits now in place, we can finally write the vendor specific infoframes in our driver. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_hdmi.c | 28 2 files changed, 30 insertions

[Intel-gfx] [PATCH igt] intel_infoframes: Add support for decoding HDMI VICs

The HDMI vendor infoframe can contain a HDMI VIC (as of HDMI 1.4, only used for 4k formats). Signed-off-by: Damien Lespiau --- tools/intel_infoframes.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/tools/intel_infoframes.c b/tools

[Intel-gfx] HDMI 4k support v3

Follow up on v2: http://lists.freedesktop.org/archives/dri-devel/2013-August/043604.html With the quick and nice reviews from Ville and Simon, it's time for a v3: - Fix embarrassing hmdi typo - Fix the sending of vendor specific infoframes for side-by-side half modes - Smaller changes here

[Intel-gfx] [PATCH 01/12] drm: Don't export drm_find_cea_extension() any more

This function is only used inside drm_edid.c. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 5 ++--- include/drm/drm_crtc.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 02/12] drm/edid: Fix add_cea_modes() style issues

A few styles issues have crept in here, fix them before touching this code again. v2: constify arguments that can be (Ville Syrjälä) v3: constify, but better (Ville Syrjälä) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 12 +++- 1 file changed, 7 insertions(+), 5

[Intel-gfx] [PATCH 03/12] drm/edid: Parse the HDMI CEA block and look for 4k modes

earer that offset is relative to the end of the required fields of the HDMI VSDB (Ville Syrjälä) v3: Fix 'Unknow' typo (Simon Farnsworth) Signed-off-by: Damien Lespiau Tested-by: Cancan Feng Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67030 Reviewed-by: Simon Farnsworth -

[Intel-gfx] [PATCH 04/12] drm: Add support for alternate clocks of 4k modes

v2: Fix hmdi typo (Simon Farnsworth, Ville Syrjälä) Suggested-by: Ville Syrjälä Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä Reviewed-by: Simon Farnsworth --- drivers/gpu/drm/drm_edid.c | 68 ++ 1 file changed, 62 insertions(+), 6

[Intel-gfx] [PATCH 05/12] video/hdmi: Don't let the user of this API create invalid infoframes

To set the active aspect ratio value in the AVI infoframe today, you not only have to set the active_aspect field, but also the active_info_valid bit. Out of the 1 user of this API, we had 100% misuse, forgetting the _valid bit. This was fixed in: Author: Damien Lespiau Date: Tue Aug 6 20

[Intel-gfx] [PATCH 06/12] video/hdmi: Derive the bar data valid bit from the bar data fields

Just like: Author: Damien Lespiau Date: Mon Aug 12 11:53:24 2013 +0100 video/hdmi: Don't let the user of this API create invalid infoframes But this time for the horizontal/vertical bar data present bits. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- dr

[Intel-gfx] [PATCH 07/12] video/hdmi: Introduce helpers for the HDMI vendor specific infoframe

-side (half), hmdi typo, pack 3D_Ext_Data (Ville Syrjälä) Signed-off-by: Damien Lespiau --- drivers/video/hdmi.c | 88 include/linux/hdmi.h | 26 2 files changed, 114 insertions(+) diff --git a/drivers/video/hdmi.c b/drivers/

[Intel-gfx] [PATCH 10/12] video/hdmi: Hook the HDMI vendor infoframe with the generic _pack()

this API has been ported in: Author: Damien Lespiau Date: Mon Aug 12 18:08:37 2013 +0100 gpu: host1x: Port the HDMI vendor infoframe code the common helpers v2: Change oui to be an unsigned int (Ville Syrjälä) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/

[Intel-gfx] [PATCH 08/12] gpu: host1x: Port the HDMI vendor infoframe code the common helpers

imp up the commit message with the note about the length (Ville Syrjälä) Cc: Thierry Reding Cc: Terje Bergström Cc: linux-te...@vger.kernel.org Signed-off-by: Damien Lespiau --- drivers/gpu/host1x/drm/hdmi.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) di

[Intel-gfx] [PATCH 09/12] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

HDMI, but details..) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 1 - include/linux/hdmi.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index d76d608..3aa653f 100644 ---

[Intel-gfx] [PATCH 11/12] drm: Add a helper to forge HDMI vendor infoframes

This can then be used by DRM drivers to setup their vendor infoframes. v2: Fix hmdi typo (Simon Farnsworth) Signed-off-by: Damien Lespiau Reviewed-by: Simon Farnsworth Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 36 include/drm/drm_edid.h

[Intel-gfx] [PATCH 12/12] drm/i915/hdmi: Write HDMI vendor specific infoframes

With all the common infoframe bits now in place, we can finally write the vendor specific infoframes in our driver. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_hdmi.c | 28 2

Re: [Intel-gfx] [PATCH] i915: Add a Kconfig option to turn on i915.preliminary_hw_support by default

something similar in mind for this on other little parameters/debug features). Reviewed-by: Damien Lespiau It doesn't apply cleanly to drm-intel/drm-intel-nightly which is the preferred branch to base patches on. Daniel might fix this himself as this is rather trivial to solve. -- Damien &

Re: [Intel-gfx] [PATCH] assembler: error for the wrong syntax of SEND instruction on GEN6+

; Signed-off-by: Xiang, Haihao > Signed-off-by: Ben Widawsky > --- > > Somehow this ended up in our internal IGT. Anyone have an issue with me > pushing it to igt proper? Maybe just a small rewording of "the syntax of send instruction" error message. Otherwise:

Re: [Intel-gfx] [PATCH] drm/i915: enable the power well before module unload

tools. > > Cc: sta...@vger.kernel.org > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67813 > Signed-off-by: Paulo Zanoni Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/i915_dma.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletio

Re: [Intel-gfx] [PATCH 04/14] drm/i915: add MIPI DSI register definitions

On Tue, Aug 13, 2013 at 04:29:43PM +0300, Jani Nikula wrote: > Add definitions for VLV MIPI DSI registers. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_reg.h | 409 > +++ > 1 file changed, 409 insertions(+) I wonder if it'd be the right

Re: [Intel-gfx] [PATCH igt] intel_infoframes: Add support for decoding HDMI VICs

On Wed, Aug 14, 2013 at 10:54:17AM +0100, Simon Farnsworth wrote: > Reviewed-by: Simon Farnsworth Thanks for the review, pushed this along with a patch to decode 3D_Ext_Data when Side-by-side (half) is programmed in 3D_structure -- Damien ___ Intel-gf

Re: [Intel-gfx] [PATCH 09/12] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

On Thu, Aug 15, 2013 at 05:12:00PM +0200, Thierry Reding wrote: > On Wed, Aug 14, 2013 at 06:19:12PM +0100, Damien Lespiau wrote: > [...] > > +#define HDMI_IDENTIFIER 0x000c03 > > HDMI_IDENTIFIER sounds really generic. Perhaps HDMI_INFOFRAME_OUI_HDMI? This identifier is not

[Intel-gfx] HDMI 4k support v4

Follow up on v3: http://lists.freedesktop.org/archives/dri-devel/2013-August/043696.html Changes between v3 and v4: - Future proof the sending of 3D_Ext_Data - Renamed struct hdmi_hdmi_infoframe to hdmi_vendor_infoframe (by, in turn, renaming the hdmi_vendor_infoframe enum to hdmi_vendor

[Intel-gfx] [PATCH 01/14] drm: Don't export drm_find_cea_extension() any more

This function is only used inside drm_edid.c. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 5 ++--- include/drm/drm_crtc.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 02/14] drm/edid: Fix add_cea_modes() style issues

A few styles issues have crept in here, fix them before touching this code again. v2: constify arguments that can be (Ville Syrjälä) v3: constify, but better (Ville Syrjälä) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 12 +++- 1 file

[Intel-gfx] [PATCH 04/14] drm: Add support for alternate clocks of 4k modes

v2: Fix hmdi typo (Simon Farnsworth, Ville Syrjälä) Suggested-by: Ville Syrjälä Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä Reviewed-by: Simon Farnsworth --- drivers/gpu/drm/drm_edid.c | 68 ++ 1 file changed, 62 insertions(+), 6

[Intel-gfx] [PATCH 05/14] video/hdmi: Don't let the user of this API create invalid infoframes

To set the active aspect ratio value in the AVI infoframe today, you not only have to set the active_aspect field, but also the active_info_valid bit. Out of the 1 user of this API, we had 100% misuse, forgetting the _valid bit. This was fixed in: Author: Damien Lespiau Date: Tue Aug 6 20

[Intel-gfx] [PATCH 06/14] video/hdmi: Derive the bar data valid bit from the bar data fields

Just like: Author: Damien Lespiau Date: Mon Aug 12 11:53:24 2013 +0100 video/hdmi: Don't let the user of this API create invalid infoframes But this time for the horizontal/vertical bar data present bits. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- dr

[Intel-gfx] [PATCH 03/14] drm/edid: Parse the HDMI CEA block and look for 4k modes

earer that offset is relative to the end of the required fields of the HDMI VSDB (Ville Syrjälä) v3: Fix 'Unknow' typo (Simon Farnsworth) Signed-off-by: Damien Lespiau Tested-by: Cancan Feng Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67030 Reviewed-by: Simon Farnswor

[Intel-gfx] [PATCH 07/14] video/hdmi: Introduce helpers for the HDMI vendor specific infoframe

-side (half), hmdi typo, pack 3D_Ext_Data (Ville Syrjälä) v3: Future proof the sending of 3D_Ext_Data (Ville Syrjälä), Fix multi-lines comment style (Thierry Reding) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/video/hdmi.c

[Intel-gfx] [PATCH 08/14] gpu: host1x: Port the HDMI vendor infoframe code the common helpers

imp up the commit message with the note about the length (Ville Syrjälä) Cc: Thierry Reding Cc: Terje Bergström Cc: linux-te...@vger.kernel.org Signed-off-by: Damien Lespiau --- drivers/gpu/host1x/drm/hdmi.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) di

[Intel-gfx] [PATCH 09/14] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

HDMI, but details..) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 1 - include/linux/hdmi.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index d76d608..3aa653f 100644 ---

[Intel-gfx] [PATCH 10/14] video/hdmi: Hook the HDMI vendor infoframe with the generic _pack()

this API has been ported in: Author: Damien Lespiau Date: Mon Aug 12 18:08:37 2013 +0100 gpu: host1x: Port the HDMI vendor infoframe code the common helpers v2: Change oui to be an unsigned int (Ville Syrjälä) Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/

[Intel-gfx] [PATCH 11/14] video/hdmi: Use hdmi_vendor_infoframe for the HDMI specific infoframe

We just got rid of the version of hdmi_vendor_infoframe that had a byte array for anyone to poke at. It's now time to shuffle around the naming of hdmi_hdmi_infoframe to make hdmi_vendor_infoframe become the HDMI vendor specific structure. Cc: Thierry Reding Signed-off-by: Damien Le

[Intel-gfx] [PATCH 12/14] drm: Add a helper to forge HDMI vendor infoframes

This can then be used by DRM drivers to setup their vendor infoframes. v2: Fix hmdi typo (Simon Farnsworth) v3: Adapt to the hdmi_vendor_infoframe rename Signed-off-by: Damien Lespiau Reviewed-by: Simon Farnsworth Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 36

[Intel-gfx] [PATCH 13/14] drm/i915/hdmi: Write HDMI vendor specific infoframes

With all the common infoframe bits now in place, we can finally write the vendor specific infoframes in our driver. Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_hdmi.c | 28 2

[Intel-gfx] [PATCH 14/14] video/hdmi: Rename HDMI_IDENTIFIER to HDMI_IEEE_OUI

HDMI_IDENTIFIER was felt too generic, rename it to what it is, the IEEE OUI corresponding to HDMI Licensing, LLC. http://standards.ieee.org/develop/regauth/oui/oui.txt Cc: Thierry Reding Signed-off-by: Damien Lespiau --- drivers/gpu/drm/drm_edid.c | 2 +- drivers/video/hdmi.c | 4

Re: [Intel-gfx] [PATCH 06/12] video/hdmi: Derive the bar data valid bit from the bar data fields

On Thu, Aug 15, 2013 at 04:45:56PM +0200, Thierry Reding wrote: > On Wed, Aug 14, 2013 at 06:19:09PM +0100, Damien Lespiau wrote: > > Just like: > > > > Author: Damien Lespiau > > Date: Mon Aug 12 11:53:24 2013 +0100 > > > > video/hdmi: Don&#x

[Intel-gfx] Removal of some unused defines

A small series to remove a few of those. I guess it's debatable if the i915_READ_* for ring registers should be removed or the code ported to always use those macros. -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.fre

[Intel-gfx] [PATCH 2/4] drm/i915: Remove HAS_PIPE_CONTROL()

The code using this was removed in: commit 88f23b8fa3e6357c423af24ec31c661fc12f884b Author: Chris Wilson Date: Sun Dec 5 15:08:31 2010 + drm/i915: Avoid using PIPE_CONTROL on Ironlake Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 2 -- 1 file changed

[Intel-gfx] [PATCH 1/4] drm/i915: Remove DSPARB_HWCONTROL()

This define hasn't been used since: commit 652c393a3368af84359da37c45afc35a91144960 Author: Jesse Barnes Date: Mon Aug 17 13:31:43 2009 -0700 drm/i915: add dynamic clock frequency control Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 2 -- 1 file ch

[Intel-gfx] [PATCH 3/4] drm: Remove IS_IRONLAKE_D()

This define hasn't been used since: commit cfdf1fa23f4074c9f8766dc67a928bbf680b1ac9 Author: Kristian Høgsberg Date: Wed Dec 16 15:16:16 2009 -0500 drm/i915: Implement IS_* macros using static tables Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 1 - 1

[Intel-gfx] [PATCH 4/4] drm/i915: Remove I915_READ_{NOPID, SYNC_0, SYNC_1})()

The code directly uses the registers and ring->mmio_base. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ringbuffer.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h index 5e6be84..432a

Re: [Intel-gfx] [PATCH] drm/Kconfig: favor n for DRM_I915_PRELIMINARY_HW_SUPPORT

On Mon, Aug 19, 2013 at 04:20:40PM -0700, Ben Widawsky wrote: > We generally don't want people or distros to use this option unless they > know what they're doing. I missed the initial conversation but it's > likely a way for people who have a built-in i915.ko and have no other > way to change the

Re: [Intel-gfx] [PATCH] drm/Kconfig: favor n for DRM_I915_PRELIMINARY_HW_SUPPORT

; > + > > Heh. You didn't comment on the one part I really wanted to add ;-). The > rest of the patch doesn't matter much to me. A patch with that hunk has my Reviewed-by: Damien Lespiau -- Damien ___ Intel-gfx mailing list Int

Re: [Intel-gfx] [PATCH] assembler: error for the wrong syntax of SEND instruction on GEN6+

On Thu, Aug 15, 2013 at 02:47:47PM -0700, Ben Widawsky wrote: > I forgot to reword... but I had meant to. Already pushed, feel free to > fix up. Sorry. Done! Hopefully slighty better. -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH 09/12] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

On Mon, Aug 19, 2013 at 09:31:42PM +0200, Thierry Reding wrote: > On Mon, Aug 19, 2013 at 02:49:50PM +0100, Damien Lespiau wrote: > > On Thu, Aug 15, 2013 at 05:12:00PM +0200, Thierry Reding wrote: > > > On Wed, Aug 14, 2013 at 06:19:12PM +0100, Damien Lespiau wrote: > >

Re: [Intel-gfx] The whole round of i-g-t testing cost too long running time

On Wed, Apr 16, 2014 at 08:42:27AM -0700, Jesse Barnes wrote: > And can you elaborate on the CRC tests? It doesn't seem like those > should take more than a few frames to verify we're getting what we > expect... Indeed, if the CRC tests take a long time, that's a bug (for instance we may never re

Re: [Intel-gfx] [PATCH 3/3] drm/i915: add null render states for gen6, gen7 and gen8

On Tue, Apr 22, 2014 at 08:19:44PM +0300, Mika Kuoppala wrote: > These are generated with intel-gpu-tools/tools/null_state_gen. I couldn't find the patches adding this to intel-gpu-tools. Mind posting them here (or probably just push them to i-g-t?) Thanks, -- Damien ___

Re: [Intel-gfx] [PATCH 3/3] drm/i915: add null render states for gen6, gen7 and gen8

On Fri, May 02, 2014 at 09:43:29PM +0100, Damien Lespiau wrote: > On Tue, Apr 22, 2014 at 08:19:44PM +0300, Mika Kuoppala wrote: > > These are generated with intel-gpu-tools/tools/null_state_gen. > > I couldn't find the patches adding this to intel-gpu-tools. Mind posting >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: consider the source max DP lane count too

o Zanoni > Signed-off-by: Jani Nikula Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/intel_dp.c | 20 ++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

Re: [Intel-gfx] [PATCH 1/3] drm/i915: consider the source max DP lane count too

On Tue, May 06, 2014 at 02:56:50PM +0300, Jani Nikula wrote: > From: Paulo Zanoni > > Even if the panel claims it can support 4 lanes, there's the > possibility that the HW can't, so consider this while selecting the > max lane count. > > Signed-off-by: Paulo Zanoni > Signed-off-by: Jani Nikula

Re: [Intel-gfx] [PATCH 1/3] drm/i915: consider the source max DP lane count too

On Tue, May 06, 2014 at 02:34:41PM +0100, Damien Lespiau wrote: > On Tue, May 06, 2014 at 02:56:50PM +0300, Jani Nikula wrote: > > From: Paulo Zanoni > > > > Even if the panel claims it can support 4 lanes, there's the > > possibility that the HW can't,

Re: [Intel-gfx] [PATCH 2/3] drm/i915: clean up VBT eDP link param decoding

On Tue, May 06, 2014 at 02:56:51PM +0300, Jani Nikula wrote: > Use defines, do not set anything if VBT has values unknown to us. > > Signed-off-by: Jani Nikula Reviewed-by: Damien Lespiau -- Damien ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH 3/3] drm/i915: use lane count and link rate from VBT as minimums for eDP

> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73539 > Tested-by: Markus Blank-Burian > Signed-off-by: Jani Nikula Reviewed-by: Damien Lespiau -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freede

Re: [Intel-gfx] [IGT PATCH] intel_bios_reader: make edp block decode match kernel

suppor this. Just do what the kernel does, that's what we're interested > in anyway. > > Signed-off-by: Jani Nikula Reviewed-by: Damien Lespiau You may want to add checks on the VBT revision that introduce the different parameters. We're also missing the VswingP

Re: [Intel-gfx] [IGT PATCH] intel_bios_reader: make edp block decode match kernel

On Tue, May 06, 2014 at 07:04:21PM +0300, Jani Nikula wrote: > On Tue, 06 May 2014, Damien Lespiau wrote: > > On Tue, May 06, 2014 at 02:27:23PM +0300, Jani Nikula wrote: > >> All the somewhat recent VBT specs and the kernel have different format > >> for the eDP block

Re: [Intel-gfx] [PATCH] drm/i915: Use hash tables for the command parser

On Thu, May 08, 2014 at 10:56:05AM +0100, Tvrtko Ursulin wrote: > > Hi Brad, > > On 04/28/2014 04:22 PM, bradley.d.vol...@intel.com wrote: > [snip] > >-BUG_ON(!validate_cmds_sorted(ring)); > >+BUG_ON(!validate_cmds_sorted(ring, cmd_tables, cmd_table_count)); > > BUG_ON(!validate_regs_

Re: [Intel-gfx] [PATCH] drm/i915: Use hash tables for the command parser

On Thu, May 08, 2014 at 01:25:33PM +0100, Tvrtko Ursulin wrote: > > On 05/08/2014 12:44 PM, Damien Lespiau wrote: > >On Thu, May 08, 2014 at 10:56:05AM +0100, Tvrtko Ursulin wrote: > >> > >>Hi Brad, > >> > >>On 04/28/2014 04:22 PM, bradley.d.v

Re: [Intel-gfx] [PATCH] drm/i915: Use hash tables for the command parser

On Mon, Apr 28, 2014 at 08:22:08AM -0700, bradley.d.vol...@intel.com wrote: > From: Brad Volkin > +/* > + * Different command ranges have different numbers of bits for the opcode. > + * In order to use the opcode bits, and only the opcode bits, for the hash > key > + * we should use the MI_* comm

Re: [Intel-gfx] [PATCH] drm/i915: Use hash tables for the command parser

On Thu, May 08, 2014 at 02:05:07PM +0100, Damien Lespiau wrote: > On Mon, Apr 28, 2014 at 08:22:08AM -0700, bradley.d.vol...@intel.com wrote: > > From: Brad Volkin > > +/* > > + * Different command ranges have different numbers of bits for the opcode. > > + * In order

Re: [Intel-gfx] [PATCH] drm/i915: Use hash tables for the command parser

On Thu, May 08, 2014 at 12:44:57PM +0100, Damien Lespiau wrote: > I was hoping we could compute a (near) minimal perfect hash function > though. Let me try to dig a bit. So, I went a bit further here and we can actually generate a minimal perfect hash function. I took the 44 HSW render o

Re: [Intel-gfx] [PATCH] tools/null_state_gen: generate null render state

On Tue, May 06, 2014 at 04:39:01PM +0300, Mika Kuoppala wrote: > Generate valid (null) render state for each gen. Output > it as a c source file with batch and relocations. > > Signed-off-by: Mika Kuoppala > --- > configure.ac |1 + > lib/gen6_render.h

Re: [Intel-gfx] [PATCH] tools/null_state_gen: generate null render state

On Tue, May 06, 2014 at 04:39:01PM +0300, Mika Kuoppala wrote: > diff --git a/tools/null_state_gen/Makefile.am > b/tools/null_state_gen/Makefile.am > new file mode 100644 > index 000..40d2237 > --- /dev/null > +++ b/tools/null_state_gen/Makefile.am > @@ -0,0 +1,16 @@ > +bin_PROGRAMS = intel_nu

Re: [Intel-gfx] [PATCH] drm/i915: Use hash tables for the command parser

On Thu, May 08, 2014 at 08:53:38AM -0700, Volkin, Bradley D wrote: > On Thu, May 08, 2014 at 06:15:44AM -0700, Lespiau, Damien wrote: > > On Thu, May 08, 2014 at 02:05:07PM +0100, Damien Lespiau wrote: > > > On Mon, Apr 28, 2014 at 08:22:08AM -0700, bradley.d.vol...@inte

Re: [Intel-gfx] [PATCH 24/50] drm/i915/bdw: Populate LR contexts (somewhat)

On Fri, May 09, 2014 at 01:08:54PM +0100, oscar.ma...@intel.com wrote: > + if (ring->id == RCS) { > + reg_state[CTX_LRI_HEADER_2] = MI_LOAD_REGISTER_IMM(1); > + reg_state[CTX_LRI_HEADER_2] |= MI_LRI_FORCE_POSTED; This header doesn't have bit 12 set in BSpec. > +

Re: [Intel-gfx] [PATCH] tools/null_state_gen: generate null render state

On Tue, May 06, 2014 at 04:39:01PM +0300, Mika Kuoppala wrote: > diff --git a/tools/null_state_gen/intel_renderstate_gen8.c > b/tools/null_state_gen/intel_renderstate_gen8.c > new file mode 100644 > index 000..7e22b24 > --- /dev/null > +++ b/tools/null_state_gen/intel_renderstate_gen8.c [...]

Re: [Intel-gfx] [PATCH] tools/null_state_gen: generate null render state

On Tue, May 06, 2014 at 02:47:40PM +0100, Chris Wilson wrote: > Why does this work? It is neither the most minimal batch, nor the > maximal. Which state is truly required? It looks like cargo-culted > Chinese. I'll have to echo this. It's really not obvious why this is needed. If you look at the r

Re: [Intel-gfx] [3.14.0-rc4] regression: drm FIFO underruns

On Fri, May 09, 2014 at 06:11:37PM +0200, Jörg Otte wrote: > > Jörg, can you please boot with drm.debug=0xe, reproduce the issue and > > then attach the complete dmesg? Please make sure that the dmesg > > contains the boot-up stuff too. > > > > Thanks, Daniel > Here it is. I should mention it only

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: add igt_set_timeout

On Mon, May 12, 2014 at 11:35:20AM +0100, Thomas Wood wrote: > Add a function to stop and fail a test after the specified number of > seconds have elapsed. > > Signed-off-by: Thomas Wood Looks like a useful helper to have in any case. Both patches are: Acked-by: Damien Lespiau

Re: [Intel-gfx] [PATCH] drm/i915: Use hash tables for the command parser

l of the leaks. > > v2: improved comment describing selection of hash key mask (Damien) > replace a BUG_ON() with an error return (Tvrtko, Ville) > commit message improvements > > Signed-off-by: Brad Volkin Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu

Re: [Intel-gfx] [PATCH] drm/i915: Use the connector name in fbdev debug messages

On Tue, May 13, 2014 at 01:45:09PM +0100, Chris Wilson wrote: > - DRM_DEBUG_KMS("connector %s on crtc %d: %s\n", > + DRM_DEBUG_KMS("connector %s on pipe %d [CRTC:%d]: %dx%d%s\n", > drm_get_connector_name(connector), > + p

Re: [Intel-gfx] [PATCH] drm/i915: Use the connector name in fbdev debug messages

On Tue, May 13, 2014 at 01:59:16PM +0100, Chris Wilson wrote: > On Tue, May 13, 2014 at 01:51:46PM +0100, Damien Lespiau wrote: > > On Tue, May 13, 2014 at 01:45:09PM +0100, Chris Wilson wrote: > > > - DRM_DEBUG_KMS("connector %s on crtc %d: %s\n", > > &g

[Intel-gfx] [PATCH 0/5] Misc preparation patches

ready for public consumption. -- Damien Damien Lespiau (5): drm/i915: Introduce a for_each_intel_crtc() macro drm/i915: Introduce a for_each_crtc() macro drm/i915: Expose ilk_wm_max_level() drm/i915: Use ilk_wm_max_level() in latency debugfs files drm/i915: Don't cast void* poi

[Intel-gfx] [PATCH 1/5] drm/i915: Introduce a for_each_intel_crtc() macro

Fed up with having that long list_for_each_entry() invocation? Use for_each_intel_crtc()! Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 5f4f631

[Intel-gfx] [PATCH 4/5] drm/i915: Use ilk_wm_max_level() in latency debugfs files

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 18b3565..6801987 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b

[Intel-gfx] [PATCH 5/5] drm/i915: Don't cast void* pointers

That's not necessary and makes the code not as neat as it could be. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 74 ++--- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/dr

[Intel-gfx] [PATCH 3/5] drm/i915: Expose ilk_wm_max_level()

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index d8b540b..97a2c56 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH 2/5] drm/i915: Introduce a for_each_crtc() macro

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 9ed53a9..f6967ef 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [3.14.0-rc4] regression: drm FIFO underruns

On Tue, May 13, 2014 at 06:38:32PM +0200, Daniel Vetter wrote: > > Doesn't work for me, I still have an underrun at boot-up. > > I'm at a loss tbh with ideas. We successfully disable both pipes, then > enable pipe A and it all works. > > Then we enable pipe B and _both_ pipes underrun immediately

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Use ilk_wm_max_level() in latency debugfs files

On Tue, May 13, 2014 at 06:46:23PM +0200, Daniel Vetter wrote: > On Tue, May 13, 2014 at 03:30:27PM +0100, Damien Lespiau wrote: > > Signed-off-by: Damien Lespiau > > I prefer "expose foo" and "use foo" in the same patch. I'll squash these > two if you&

[Intel-gfx] [PATCH 4/4] drm/i915: Use for_each_crtc() when iterating through the CRTCs

ev,crtc) { ... } Followed by a couple of fixups by hand (that spatch doesn't match the cases where list_for_each_entry() is not followed by a set of '{', '}', but I couldn't figure out a way to leave the '{' out of the iterator match). Signed-of

[Intel-gfx] [PATCH 1/4] drm/i915: Introduce a for_each_intel_crtc() macro

Fed up with having that long list_for_each_entry() invocation? Use for_each_intel_crtc()! Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 8885455

[Intel-gfx] [PATCH 3/4] drm/i915: Introduce a for_each_crtc() macro

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index edf7299..4006dfe 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 0/4] for_each_{intel_,}crtc v2

With Daniel's help to figure out an arcane corner of coccinelle, here is v2 of a series introducing macros to iterate through the CRTCs instead of using list_for_each_entry() and mode_config.crtc_list, a tiny bit more readable and easier to recall. Damien Lespiau (4): drm/i915: Introd

[Intel-gfx] [PATCH 2/4] drm/i915: Use for_each_intel_crtc() when iterating through intel_crtcs

ev,crtc) { ... } Followed by a couple of fixups by hand (that spatch doesn't match the cases where list_for_each_entry() is not followed by a set of '{', '}', but I couldn't figure out a way to leave the '{' out of the iterator match). Signed-off-by: Damien Lespiau

Re: [Intel-gfx] [PATCH 1/2] drm/i915: use dev_priv directly in i915_driver_unload

On Tue, May 13, 2014 at 10:21:59PM +0200, Daniel Vetter wrote: > Noticed while playing with coccinelle. > > Signed-off-by: Daniel Vetter Reviewed-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Intel-gfx] [PATCH] tools/null_state_gen: generate null render state

On Tue, May 06, 2014 at 04:39:01PM +0300, Mika Kuoppala wrote: > Generate valid (null) render state for each gen. Output > it as a c source file with batch and relocations. > > Signed-off-by: Mika Kuoppala With the GT3 URB allocation restriction added, this series is Acked-by: Da

<    1   2   3   4   5   6   7   8   9   10   >