[Intel-gfx] [PATCH 51/90] assembler: Use brw_set_dest() to encode the destination

assembler can either take subnr in bytes or in number of elements, so we need a resolve step when setting a brw_reg. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |3 + assembler/gram.y| 171 +++ assembler/main.c| 11 +++ 3

[Intel-gfx] [PATCH 52/90] assembler: Factor out the source register validation

The goal is to use brw_set_src[01](), so let's start by validating the register we have before generating the opcode. Signed-off-by: Damien Lespiau --- assembler/gram.y | 61 ++--- 1 files changed, 25 insertions(+), 36 deletions(-) diff --

[Intel-gfx] [PATCH 53/90] assembler: ExecSize can be as big as 32 channels

See the IVB PRM, vol4 part3 5.2.3. Signed-off-by: Damien Lespiau --- assembler/brw_eu_emit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/assembler/brw_eu_emit.c b/assembler/brw_eu_emit.c index ea4baeb..ed24e48 100644 --- a/assembler/brw_eu_emit.c +++ b/assembler

[Intel-gfx] [PATCH 54/90] assembler: Fix comparisons between reg.type and Architecture registers

Of course the assertion is there to make sure GRF and MRF have a reg.nr < 128. To exclude ARF registers, reg.file has be checked, not reg.type (channel type). Most likely a typo never caught. Signed-off-by: Damien Lespiau --- assembler/brw_eu_emit.c |4 ++-- 1 files changed, 2 inserti

[Intel-gfx] [PATCH 55/90] assembler: Store immediate values in reg.dw1.ud

Another step in pushing the parsing in struct brw_reg. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |2 +- assembler/gram.y| 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h index 0e3b965

[Intel-gfx] [PATCH 56/90] assembler: Don't warn if identical declared registers are redefined

ut in that case. Signed-off-by: Damien Lespiau --- assembler/gram.y | 74 +++--- 1 files changed, 59 insertions(+), 15 deletions(-) diff --git a/assembler/gram.y b/assembler/gram.y index be8ff01..8b56bd9 100644 --- a/assembler/gram.y +++ b/asse

[Intel-gfx] [PATCH 57/90] assembler: Add location support

Let's generate location information about the tokens we are parsing. This can be used to give accurate location when reporting errors and warnings. Signed-off-by: Damien Lespiau --- assembler/gram.y |1 + assembler/lex.l | 24 ++-- 2 files changed, 19 insertions(

[Intel-gfx] [PATCH 58/90] assembler: Add error() and warn() shorthands and use them in set_src[01]

Now that we have locations, we can write error() and warn() functions giving more information about where it's going wrong. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |2 + assembler/gram.y| 121 ++- 2 files change

[Intel-gfx] [PATCH 59/90] assembler: Add a check for when width is 1 and hstride is not 0

The list of region restrictions in bspec do say that we can't have: width == 1 && hstrize != 0 We do have plenty of assembly code that don't respect that behaviour. So let's hide the warning under a -W flag (for now) while we fix things. Signed-off-by: Damien

[Intel-gfx] [PATCH 60/90] assembler: Add a check for when ExecSize and width are 1

Another check (that we hit if we try to use brw_set_src0()). Again, protect it with the -W option. Signed-off-by: Damien Lespiau --- assembler/gram.y | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/assembler/gram.y b/assembler/gram.y index

[Intel-gfx] [PATCH 61/90] assembler: Add the input filename to the error/warning messages

Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |2 ++ assembler/gram.y|4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h index 1e67c1c..9558a29 100644 --- a/assembler/gen4asm.h +++ b/assembler/gen4asm.h @@ -47,6

[Intel-gfx] [PATCH 62/90] assembler: Use brw_set_src0()

assembler generate the same opcodes. We can fix all this, but it requires validation, something that I cannot do right now. Signed-off-by: Damien Lespiau --- assembler/brw_eu_emit.c | 25 - assembler/gram.y| 66 -- 2 files c

[Intel-gfx] [PATCH 63/90] assembler: Port the warning and error reporting to warn()/error()

This way we ensure to have a single place where these are handled. The immediate benefit is that now line numbers are always printed out, which is quite handy. Signed-off-by: Damien Lespiau --- assembler/gram.y | 274 ++ 1 files changed, 113

[Intel-gfx] [PATCH 64/90] assembler: Cleanup visibility of a few global variables/functions

Not everything has to be exported out the compilation unit. Do a small cleanup pass. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |2 + assembler/gram.y| 102 --- assembler/main.c| 12 +++--- 3 files changed, 56 insertions

[Intel-gfx] [PATCH 65/90] assembler: Fix ')' placement in condition

A small typo in the condition. Signed-off-by: Damien Lespiau --- assembler/gram.y |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/assembler/gram.y b/assembler/gram.y index 4b5c6a3..c86e28f 100644 --- a/assembler/gram.y +++ b/assembler/gram.y @@ -2226,7 +2226,7

[Intel-gfx] [PATCH 66/90] assembler: Implement register-indirect addressing mode in brw_set_src1()

The assembler allows people to do that and that's something available since Crestline. Signed-off-by: Damien Lespiau --- assembler/brw_eu_emit.c | 39 +++ 1 files changed, 27 insertions(+), 12 deletions(-) diff --git a/assembler/brw_eu_emit.c b/asse

[Intel-gfx] [PATCH 67/90] assembler: Use brw_set_src1()

Everything is now aligned to be able to use brw_set_src1() in the opcode generation, so use it. Signed-off-by: Damien Lespiau --- assembler/gram.y | 54 +- 1 files changed, 5 insertions(+), 49 deletions(-) diff --git a/assembler/gram.y b

[Intel-gfx] [PATCH 68/90] assembler: Renamed the instruction field to insn

This will be less typing for the refactoring to come (which is use struct brw_program_instruction in gram.y for the type of all the instructions). Signed-off-by: Damien Lespiau --- assembler/disasm-main.c |6 +++--- assembler/gen4asm.h |4 ++-- assembler/gram.y|6

[Intel-gfx] [PATCH 70/90] assembler: Move struct relocation out of relocatable instructions

ned-off-by: Damien Lespiau --- assembler/gen4asm.h |5 +-- assembler/gram.y| 76 ++- assembler/main.c|4 +- 3 files changed, 43 insertions(+), 42 deletions(-) diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h index 0781ea

[Intel-gfx] [PATCH 71/90] assembler: Gather all predicate data in its own structure

Rather than user a full instruction for that. Also use set_instruction_predicate() for a case that coud not be done like that before the refactoring (because everyone now uses the same instruction structure). Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |7 ++ assembler/gram.y

[Intel-gfx] [PATCH 72/90] assembler: Unify adding options to the header

fixed now! Signed-off-by: Damien Lespiau --- assembler/gram.y | 121 -- 1 files changed, 45 insertions(+), 76 deletions(-) diff --git a/assembler/gram.y b/assembler/gram.y index 23d7cfb..99376a2 100644 --- a/assembler/gram.y +++ b/assembler/gram.y

[Intel-gfx] [PATCH 73/90] assembler: Isolate all the options in their own structure

Like with the predicate fields before, there's no need to use the full instruction to collect the list of options. This allows us to decouple the list of options from a specific instruction encoding. Signed-off-by: Damien Lespiau --- assembler/gen4asm.h | 12 + assembler/g

[Intel-gfx] [PATCH 74/90] assembler: Introduce set_instruction_opcode()

Signed-off-by: Damien Lespiau --- assembler/gram.y | 72 ++ 1 files changed, 40 insertions(+), 32 deletions(-) diff --git a/assembler/gram.y b/assembler/gram.y index c6ba086..2d72037 100644 --- a/assembler/gram.y +++ b/assembler/gram.y

[Intel-gfx] [PATCH 75/90] assembler: Introduce set_intruction_pred_cond()

This allow us to factor out the test that checks if, when using both predicates and conditional modifiers, we are using the same flag register. Also get rid of of a FIXME that we are now dealing with (the warning mentioned above). Signed-off-by: Damien Lespiau --- assembler/gram.y | 88

[Intel-gfx] [PATCH 76/90] assembler: Introduce set_instruction_saturate()

Also simplify the logic that was setting the saturate bit in the math instruction. Signed-off-by: Damien Lespiau --- assembler/gram.y | 26 ++ 1 files changed, 14 insertions(+), 12 deletions(-) diff --git a/assembler/gram.y b/assembler/gram.y index 917bccf..43c34f6

[Intel-gfx] [PATCH 77/90] assembler: Expose setters for 3src operands

Signed-off-by: Damien Lespiau --- assembler/brw_eu.h | 17 + assembler/brw_eu_emit.c | 43 +++ 2 files changed, 52 insertions(+), 8 deletions(-) diff --git a/assembler/brw_eu.h b/assembler/brw_eu.h index 6d656a4..20d4b82 100644

[Intel-gfx] [PATCH 78/90] assembler: Add support for D and UD in 3-src instructions

Signed-off-by: Damien Lespiau --- assembler/brw_defines.h |5 + assembler/brw_eu_emit.c | 23 +++ 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/assembler/brw_defines.h b/assembler/brw_defines.h index 23402e3..98757da 100644 --- a/assembler

[Intel-gfx] [PATCH 80/90] assembler: Don't pollute the library files with gen4asm.h

gen4asm.h is assembler specific while we want the library files to be somewhat of a proper library. This means that we have to redefine the GL* typedefs for brw_structs.h, not using any of thet GL typedef will be for a future commit. Signed-off-by: Damien Lespiau --- assembler/brw_disasm.c

[Intel-gfx] [PATCH 82/90] assembler: Use set_instruction_src1() in send

No reason not to! Signed-off-by: Damien Lespiau --- assembler/gram.y | 17 ++--- 1 files changed, 6 insertions(+), 11 deletions(-) diff --git a/assembler/gram.y b/assembler/gram.y index cd42004..d69d7b4 100644 --- a/assembler/gram.y +++ b/assembler/gram.y @@ -1200,9 +1200,8

[Intel-gfx] [PATCH 81/90] assembler: Put struct opcode_desc back in brw_context.h

I originally moved struct opcode_desc from brw_context.h to brw_eu.h on the mesa side, but that was before the realization we needed struct brw_context if we wanted to not touch the code too much. So put it back there now that the mesa patch has been dropped. Signed-off-by: Damien Lespiau

[Intel-gfx] [PATCH 83/90] assembler: Finish importing brw_eu_*c from mesa

Signed-off-by: Damien Lespiau --- assembler/Makefile.am|2 + assembler/brw_eu_debug.c | 92 ++ assembler/brw_eu_util.c | 125 ++ 3 files changed, 219 insertions(+), 0 deletions(-) create mode 100644

[Intel-gfx] [PATCH 79/90] assembler: Use brw_*() functions for 3-src instructions

Signed-off-by: Damien Lespiau --- assembler/gram.y | 79 +++-- 1 files changed, 28 insertions(+), 51 deletions(-) diff --git a/assembler/gram.y b/assembler/gram.y index 43c34f6..cd42004 100644 --- a/assembler/gram.y +++ b/assembler/gram.y

[Intel-gfx] [PATCH 84/90] assembler: Merge declared_register's type into the reg structure

Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |1 - assembler/gram.y| 12 +--- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h index 3b98444..49baf9d 100644 --- a/assembler/gen4asm.h +++ b/assembler/gen4asm.h

[Intel-gfx] [PATCH 85/90] assembler: Use defines for width

Instead of just using hardcoded numbers or resorting to ffs(). Signed-off-by: Damien Lespiau --- assembler/gram.y | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/assembler/gram.y b/assembler/gram.y index aa6d709..9d58fe6 100644 --- a/assembler

[Intel-gfx] [PATCH 86/90] assembler: Remove trailing white space

Signed-off-by: Damien Lespiau --- assembler/brw_eu.c | 16 +++--- assembler/brw_eu_debug.c | 20 +- assembler/brw_eu_emit.c | 48 +++--- assembler/brw_eu_util.c | 18 assembler/disasm-main.c |2

[Intel-gfx] [PATCH 88/90] assembler: Group the header inclusions together

Signed-off-by: Damien Lespiau --- assembler/gen4asm.h |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h index 8bfbcfe..dca7f0f 100644 --- a/assembler/gen4asm.h +++ b/assembler/gen4asm.h @@ -34,6 +34,8 @@ #include #include

[Intel-gfx] [PATCH 89/90] assembler: Fix the decoding of the destination horizontal stride

dest_horizontal_stride needs go through the horiz_stride[] indirection to pick up the rigth stride when its value is 11b (4 elements). Signed-off-by: Damien Lespiau --- assembler/brw_disasm.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/assembler/brw_disasm.c b

[Intel-gfx] [PATCH 90/90] assembler: Mark format() as PRINTFLIKE in the disassembler

So when making changes in code using that function, we get warnings about mismatches between the format string and arguments. Signed-off-by: Damien Lespiau --- assembler/brw_disasm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/assembler/brw_disasm.c b/assembler

Re: [Intel-gfx] [PATCH 00/10] [RFC v2] quick dump

On Sun, Feb 03, 2013 at 10:13:10AM -0800, Ben Widawsky wrote: > - The build kind of sucks on Arch because of Arch's choices regarding > python libraries. To build this on Arch, you must run something like: > ./autogen.sh PYTHON_LDFLAGS="-L/usr/lib/python3.3 -lpython3.3m" Don't you have a pytho

Re: [Intel-gfx] [PATCH] Build: Add --disable-tests configure flag to avoid tests build.

On Mon, Feb 04, 2013 at 07:52:27PM -0200, Rodrigo Vivi wrote: > Tests are still being built by default. However this request > came from OSVs in order to allow them to include i-g-t in their > distributions by default avoiding adding more and more dependencies > since we are improving and adding mo

[Intel-gfx] [PATCH i-g-t] tests: Forbid to run the blit tests with count of 1

From: Damien Lespiau Invoking say, sudo ./tests/gem_render_linear_blits 1 does not make a lot of sense as we're creating a single bo. The test does not yell at you and passes, even if the rendercopy function does not do anything. This makes it quite harmful when trying to debug rende

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Kill obj->pending_flip

On Tue, Jan 29, 2013 at 06:13:33PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The pending flip mask no longer set anywhere, so trying to wait for > while it's non-zero is a no-op. Remove it completely. > > Signed-off-by: Ville Syrjälä Revi

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Don't wait for page flips if there was GPU reset

ed by sampling the reset_counter before the > flip is submitted, and then while waiting for the flip, the sampled > counter is compared with the current reset_counter value. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau You might want to rename reset_counter to flip_reset_cou

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Wake up pending_flip_queue as part of reset handling

ng has finished. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Move intel_crtc_has_pending_flip() earlier

On Tue, Jan 29, 2013 at 06:13:36PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Just shuffle the code around. No functional changes. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau Mastering the art of small orthognal commits

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add intel_crtc_wait_for_pending_flips_locked()

rapper that > grab struct_mutex and calls intel_crtc_wait_for_pending_flips_locked(). > > This changes the behaviour of intel_crtc_wait_for_pending_flips() > so that it now holds struct_mutex while waiting for pending flips. > > Signed-off-by: Ville Syrjälä Revi

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Really wait for pending flips in intel_pipe_set_base()

_base() to achieve the > desired result. > > Signed-off-by: Ville Syrjälä Reviewed-by: Damien Lespiau -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Fix a typo in a intel_modeset_stage_output_state() comment

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7635947..e7fc6e5 100644 --- a/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] "Quick" mode

In order to have the tests finish in a reasonable time in certain environments, it'd be nice to have a "quick" mode that uses low loop and buffer counts. Of course, more tests would be converted in the long run. -- Damien ___ Intel-gfx mailing list In

[Intel-gfx] [PATCH 1/2] lib: Add a way to specify values for "quick" runs

In some environments, we don't really want to loop 10 times or allocate 152352621 buffers because it makes the tests too long to run. This adds a way to specify "quick" values to reduce the time taken by certain tests. Signed-off-by: Damien Lespiau --- lib/d

[Intel-gfx] [PATCH 2/2] tests: Add a quick variant to the gem_storedw_* tests

Signed-off-by: Damien Lespiau --- tests/gem_storedw_batches_loop.c |2 +- tests/gem_storedw_loop_blt.c |2 +- tests/gem_storedw_loop_bsd.c |2 +- tests/gem_storedw_loop_render.c |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests

[Intel-gfx] [PATCH] render/gen7: Don't use a message register to store vl

tel-gen4disasm -g7 - - { 0x00600041, 0x208077be, 0x008d03c0, 0x008d0180 }, + { 0x00600041, 0x288077bd, 0x008d03c0, 0x008d0180 }, mul(8) m4<1>F g30<8,8,1>F g12<8,8,1>F { align1 }; mul(8) g68<1>F g30<8,8,1>F g12<8,8,1>

Re: [Intel-gfx] Sync the assembler with Mesa's opcode emission code

On Mon, Feb 04, 2013 at 03:26:55PM +, Damien Lespiau wrote: > Hey, > > Some time ago, Daniel mentioned merging the assembler into intel-gpu-tools to > lower maintenance cost and have more eyes on the code. > > This series is the aftermath of that with an effort to sync the

[Intel-gfx] [PATCH] drm/i915: Remove platforms in the preliminary_hw_support description

We already managed to get it out of sync (Haswell has been promoted out of this option), so let's remove all mentions to platforms. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 1/3] intel/aub: Sync the AUB defines with mesa's

Signed-off-by: Damien Lespiau --- intel/intel_aub.h | 76 + 1 files changed, 53 insertions(+), 23 deletions(-) diff --git a/intel/intel_aub.h b/intel/intel_aub.h index a36fd53..5f0aba8 100644 --- a/intel/intel_aub.h +++ b/intel/intel_aub.h

[Intel-gfx] [PATCH 2/3] intel/aub: Implement a way to specify the output .aub filename

Signed-off-by: Damien Lespiau --- intel/intel_bufmgr.h |3 +++ intel/intel_bufmgr_gem.c | 26 +- 2 files changed, 28 insertions(+), 1 deletions(-) diff --git a/intel/intel_bufmgr.h b/intel/intel_bufmgr.h index 8d7f239..15f818e 100644 --- a/intel/intel_bufmgr.h

[Intel-gfx] [PATCH 3/3] intel/aub: Return early if we disable aub dumps

No need to prepare the .aub header and dump in that case, it'll be done with the next call with true. Signed-off-by: Damien Lespiau --- intel/intel_bufmgr_gem.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c

[Intel-gfx] [PATCH 1/4] lib: Factor out a function to check if an environment variable is set

Signed-off-by: Damien Lespiau --- lib/drmtest.c | 24 +--- 1 files changed, 13 insertions(+), 11 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 117fb31..641028c 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -574,22 +574,24 @@ bool

[Intel-gfx] [PATCH 2/4] lib: Allow to override the device id at run time

Using the same environment variable as libdrm so one doesn't have to remember two different things. This is helpful to run a test under a fake identity, to, say, dump an aub file. Signed-off-by: Damien Lespiau --- lib/intel_drm.c | 14 ++ 1 files changed, 10 insertions(

[Intel-gfx] [PATCH 3/4] rendercopy: Add a way to dump an .aub file with the rendercopy bos

To not bump the dependency on libdrm for a debug feature, the use of new libdrm symbols are gated by ENABLE_AUB_DUMP and depends on having the next (2.4.43) libdrm release. Signed-off-by: Damien Lespiau --- configure.ac|6 ++ lib/drmtest.c | 10

[Intel-gfx] [PATCH 4/4] build: Guard the inclusions of config.h with HAVE_CONFIG_H

ned-off-by: Damien Lespiau --- lib/intel_drm.c |2 ++ tests/gem_fence_thrash.c |2 ++ tests/kms_flip.c |2 ++ tests/testdisplay.c |2 ++ tools/intel_gpu_top.c|2 ++ 5 files changed, 10 insertions(+), 0 deletions(-) diff --git a/lib/intel_drm.c b/lib/i

[Intel-gfx] Instrumenting rendercopy, the last bit

This continues (and finishes for now) the series started: http://lists.freedesktop.org/archives/intel-gfx/2013-February/024954.html To instrument rendercopy (produce an .aub file) for use with the simulator. ___ Intel-gfx mailing list Intel-gfx@lists.fr

[Intel-gfx] [PATCH] tests: Make it easy to tell if rendercopy is doing the right thing

nting numbers and look very much alike. So, when dumping an .aub file for inspection, let's fill the destination buffer with a constant color (0xffff) and dump both src and dest bos into bmp files. Signed-off-by: Damien Lespiau --- tests/gem_render_linear_blits.c | 14 +

Re: [Intel-gfx] [i-g-t][PATH] debugger: Include path for cairo to fix compiler error

On Thu, Feb 28, 2013 at 01:37:52PM +0800, Xiang, Haihao wrote: > From: "Xiang, Haihao" > > CC eudb.o > In file included from eudb.c:44:0: > ../lib/drmtest.h:34:19: fatal error: cairo.h: No such file or directory > compilation terminated. > make[3]: *** [eudb.o] Error 1 > > Signed-off-by: X

Re: [Intel-gfx] Sync the assembler with Mesa's opcode emission code

On Thu, Feb 14, 2013 at 07:18:41PM +, Damien Lespiau wrote: > http://cgit.freedesktop.org/~damien/intel-gpu-tools/log/?h=assembler-rebased As agreed on IRC and after making sure the rework doesn't introduce regressions in our existing shaders, I've finally merged this assembl

Re: [Intel-gfx] [PATCH IGT 2/6] intel_reg_dumper: recognize LPT

On Fri, Mar 01, 2013 at 05:44:18PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Signed-off-by: Paulo Zanoni > --- > tools/intel_reg_dumper.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/intel_reg_dumper.c b/tools/intel_reg_dumper.c > index 20f33

Re: [Intel-gfx] [PATCH IGT 2/6] intel_reg_dumper: recognize LPT

On Tue, Mar 05, 2013 at 01:05:32PM -0300, Paulo Zanoni wrote: > Hi > > 2013/3/5 Damien Lespiau : > > On Fri, Mar 01, 2013 at 05:44:18PM -0300, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> Signed-off-by: Paulo Zanoni > >> --- > &

[Intel-gfx] [PATCH 1/6] drm/i915: Warn if a pipe is enabled with a bogus port

If TRANS_DDI_FUNC_CTL has been wrongly programmed with an incorrect port, we are currently trying to read PORT_CLK_SEL(port) with an initialized value. Handle that case by returning PORT_CLK_SEL_NONE and warning about it. Signed-off-by: Damien Lespiau to add to first --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/6] drm/i915: Initialize wait in intel_ddi_prepare_link_retrain()

We weren't initializing wait, which could lead to the use of a random value from the stack in the "if (wait)" condition. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ddi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 3/6] drm/i915: Error out if we are trying to use VGA with SPLL already in use

Our static analysis tool noticed that 'reg' could be used uninitialized if we are trying to get a PLL to drive VGA and SPLL is already in use (plls->spll_refcoung != 0). In the (error) case above, let's return false to the caller and emit an error. Signed-off-by: Damien Lespiau

[Intel-gfx] [PATCH 4/6] drm/i915: Cleanup if the EDP transcoder has a bobug input value

. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 502cb28..875baf1 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 5/6] drm/i915: Rename intel_ddi_enable_pipe_func() to transcoder_func()

We are really talking about the transcoder function here and the disable version uses trancoder in its name already, so let's try to be consistent. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ddi.c |2 +- drivers/gpu/drm/i915/intel_display.c |2 +- drivers/gp

[Intel-gfx] [PATCH 6/6] drm/i915: Use BUG() in a case of a programming error

The port number should always be correctly set. Do the same thing as the switch above and use BUG() to signal that branch is not supposed to be taken. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_dp.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a

Re: [Intel-gfx] [PATCH v3] drm/i915: bounds check execbuffer relocation count

On Thu, Mar 14, 2013 at 12:32:00PM -0700, Kees Cook wrote: > On Thu, Mar 14, 2013 at 9:57 AM, Daniel Vetter wrote: > > On Wed, Mar 13, 2013 at 9:28 PM, Daniel Vetter wrote: > >> On Tue, Mar 12, 2013 at 09:07:46AM +, Chris Wilson wrote: > >>> On Mon, Mar 11, 2013 at 05:31:45PM -0700, Kees Cook

Re: [Intel-gfx] [PATCH] assembler: Add a regions visualizer tool

On Tue, Mar 12, 2013 at 05:53:01PM +, Chris Cummins wrote: > This adds a html/js tool for visualizing GEN instruction source operand > regions, similar to those used in the Programmer's Reference Manual. To > use the tool, open the file assembler/gen_regions/gen_regions.html in > your browser-o

[Intel-gfx] [PATCH i-g-t] lib: Make sure we can also use the short form of the subtest options

From: Damien Lespiau Signed-off-by: Damien Lespiau --- lib/drmtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index 641028c..2d4fc89 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -530,7 +530,7 @@ void drmtest_subtest_init(int argc

Re: [Intel-gfx] [PATCH i-g-t] lib: Make sure we can also use the short form of the subtest options

On Thu, Mar 21, 2013 at 08:14:39PM +0100, Daniel Vetter wrote: > My original thinking behind only allowing the long option name is to > avoid collisions with cmdline options for the test executable itself. > E.g. when we'd teach testdisplay a few different default runs, but you > could still dig in

[Intel-gfx] [PATCH v2] drm/i915: Warn if a pipe is enabled with a bogus port

) Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ddi.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index d26147c..258e38e 100644 --- a/drivers/gpu/drm/i915/intel_ddi.c +++ b/drivers

[Intel-gfx] Craft a list of tests to run in simulation (and tune them)

For early bring-up, it's useful to have a list of tests to check everything is in order. The Makefile file is a great place to keep such a list. The IGT_SIMULATION environment variable controls the list of tests to run (either with make test/check or with piglit) and allows us to tune the various

[Intel-gfx] [PATCH i-g-t 1/5] README: Reword a few sentences

To be a bit more correct (they were understandable though). Signed-off-by: Damien Lespiau --- README | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README b/README index be29177..c484a93 100644 --- a/README +++ b/README @@ -27,17 +27,17 @@ tests/ Run this

[Intel-gfx] [PATCH i-g-t 2/5] lib: Rename IGT_QUICK to IGT_SIMULATION

It's more accurate this way as the quick mode is really useful for in the simulation environment. Signed-off-by: Damien Lespiau --- lib/drmtest.c | 10 +- lib/drmtest.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/drmtest.c b/lib/drmtest.c index a6

[Intel-gfx] [PATCH i-g-t 3/5] tests: Use IGT_SIMULATION to tune the list of tests to run

don't make too much sense in simulation. Signed-off-by: Damien Lespiau --- tests/Makefile.am | 43 --- 1 file changed, 40 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 2fddfe8..33db962 100644 --- a/tests/Makefile

[Intel-gfx] [PATCH i-g-t 4/5] tests: Instrument tests run in simulation to run quickly

Signed-off-by: Damien Lespiau --- tests/gem_cpu_reloc.c | 3 +++ tests/gem_ctx_basic.c | 5 + tests/gem_exec_nop.c| 2 +- tests/gem_mmap_gtt.c| 5 - tests/gem_pipe_control_store_loop.c | 2 +- tests/gem_render_linear_blits.c

[Intel-gfx] [PATCH i-g-t 5/5] build: Make grep silent with running make test

-q will prevent grep from writing to stdout and print "root" when make test is running as root. Signed-off-by: Damien Lespiau --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 33db962..d32e944 100644 -

Re: [Intel-gfx] [PATCH 0/2] lib/scatterlist: sg_page_iter: support for memory w/o backing pages

tree [1], where the iterator is in use already. > > [1] git://people.freedesktop.org/~danvet/drm-intel [nightly branch] > > Imre Deak (2): > lib/scatterlist: sg_page_iter: support sg lists w/o backing pages > Revert "drm/i915: set dummy page for stolen objects&quo

Re: [Intel-gfx] [PATCH] drm/i915: Apply alignment restrictions on scanout surfaces for VT-d

ktop.org/show_bug.cgi?id=59626 > References: https://bugs.freedesktop.org/show_bug.cgi?id=59627 > References: https://bugs.freedesktop.org/show_bug.cgi?id=59631 > Signed-off-by: Chris Wilson Reviewed-by: Damien Lespiau Maybe rename the mentions to "shadow page" to scratch page as it

Re: [Intel-gfx] [PATCH i-g-t 3/5] tests: Use IGT_SIMULATION to tune the list of tests to run

On Tue, Apr 02, 2013 at 10:06:37AM -0700, Ben Widawsky wrote: > > [Sun, Yi] So what's the conclusion, how can I do to solve the too long time > > issue? > > I noticed Damien's patches aren't on the branch yet. > > If we want to split all i-g-t test cases to different HAS, how can we split > > it?

Re: [Intel-gfx] [PATCH 1/7] drm/i915: check the power well inside haswell_get_pipe_config

c6229cb38664754dffe8776 > Author: Daniel Vetter > Date: Thu Mar 28 10:42:00 2013 +0100 > drm/i915: add hw state readout/checking for pipe_config > > Signed-off-by: Paulo Zanoni Reviewed-by: Damien Lespiau -- Damien ___ Intel

Re: [Intel-gfx] [PATCH 2/7] drm/i915: use cpu_transcoder for TRANS_DDI_FUNC_CTL

01 2013 +0100 > drm/i915: hw readout support for ->has_pch_encoders > > Signed-off-by: Paulo Zanoni Reviewed-by: Damien Lespiau -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/7] drm/i915: add intel_display_power_enabled

On Thu, Apr 18, 2013 at 04:35:42PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > This should replace intel_using_power_well. The idea is that we're > adding the requested power domain as an argument, so this might enable > the code to look less platform-specific and also allows us to easily

Re: [Intel-gfx] [PATCH 4/7] drm/i915: add power well and cpu transcoder info to the error state

On Thu, Apr 18, 2013 at 04:35:43PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > We need to dump these registers if we want to properly interpret the > others. > > Signed-off-by: Paulo Zanoni Reviewed-by: Damien Lespiau -- Damien ___

Re: [Intel-gfx] [PATCH 5/7] drm/i915: clear FPGA_DBG_RM_NOCLAIM when capturing error state

M_NOCLAIM bit. > > Signed-off-by: Paulo Zanoni Reviewed-by: Damien Lespiau -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 6/7] drm/i915: check the power well on i915_pipe_enabled

On Thu, Apr 18, 2013 at 04:35:45PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > This fixes "unclaimed register" messages when the power well is > disabled and there's a GPU hang. > > v2: Use the new intel_display_power_enabled(). > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/

Re: [Intel-gfx] [PATCH 7/7] drm/i915: only disable DDI sound if intel_crtc->eld_vld

ld_vld to false after the mode_set function. > V3: Add both "type != INTEL_OUTPUT_EDP" requested. > > Signed-off-by: Paulo Zanoni (having read back the original comments from Daniel and Ville) Reviewed-by: Damien Lespiau -- Damien ___ I

[Intel-gfx] [PATCH] drm/i915: Remove mention of Haswell in DDI code

From: Damien Lespiau We are trying to have more platform-orthogonal pieces of code. The DDI code shouldn't mention Haswell. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dd

[Intel-gfx] [PATCH v2] drm/i915: Remove mention of Haswell in DDI code

We are trying to have more platform-orthogonal pieces of code. The DDI code shouldn't mention Haswell. v2: Fix the email address Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915: Remove unused power well register definitions

Those registers are not used, let's not keep them around for no reason. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 60e0e19..a766d86 100644

[Intel-gfx] Try to make the device info flags a bit more maintainable

Hi, We had a few places (3) to update every time we wanted to add a device info flag, somewhat error prone. With this series we just need to touch DEV_INFO_FOR_EACH_FLAG() to add a flag (patches 1-3). On top of that, I add two more flags, has_ddi (patch 4) and has_fpga_dbg (patches 5/6), flags th

[Intel-gfx] [PATCH 1/6] drm/i915: Turn DEV_INFO_FLAGS into for foreach style macro

DEV_INFO_FOR_FLAG() now takes 2 parameters: • A function to apply to the flag • A separator This will allow us to use the macro twice in the DRM_DEBUG_DRIVER() call of i915_dump_device_info(). Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 8 +++--- drivers/gpu

[Intel-gfx] [PATCH 2/6] drm/i915: Replace the line of %s by a DEV_INFO_FOR_EACH_FLAG() invocation

This way, when adding a device flag we don't have to manually maintain that list. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c

<    6   7   8   9   10   11   12   13   14   15   >