From: Damien Lespiau <damien.lesp...@intel.com>
Invoking say,
sudo ./tests/gem_render_linear_blits 1
does not make a lot of sense as we're creating a single bo. The test
does not yell at you and passes, even if the rendercopy function does
not do anything. This makes it quite harmful when trying to debug
rendercopy without realizing that count is the number of allocated bos
and must be >= 2.
Signed-off-by: Damien Lespiau <damien.lesp...@intel.com>
---
tests/gem_linear_blits.c | 4 ++++
tests/gem_render_linear_blits.c | 5 +++++
tests/gem_render_tiled_blits.c | 5 +++++
tests/gem_tiled_blits.c | 3 +++
4 files changed, 17 insertions(+)
diff --git a/tests/gem_linear_blits.c b/tests/gem_linear_blits.c
index fe15f1d..ec2dc56 100644
--- a/tests/gem_linear_blits.c
+++ b/tests/gem_linear_blits.c
@@ -189,6 +189,10 @@ int main(int argc, char **argv)
count = atoi(argv[1]);
if (count == 0)
count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
+ else if (count < 2) {
+ fprintf(stderr, "count must be >= 2\n");
+ return 1;
+ }
if (count > intel_get_total_ram_mb() * 9 / 10) {
count = intel_get_total_ram_mb() * 9 / 10;
diff --git a/tests/gem_render_linear_blits.c b/tests/gem_render_linear_blits.c
index 8ba24a3..a7e0189 100644
--- a/tests/gem_render_linear_blits.c
+++ b/tests/gem_render_linear_blits.c
@@ -85,6 +85,11 @@ int main(int argc, char **argv)
count = atoi(argv[1]);
if (count == 0)
count = 3 * gem_aperture_size(fd) / SIZE / 2;
+ else if (count < 2) {
+ fprintf(stderr, "count must be >= 2\n");
+ return 1;
+ }
+
printf("Using %d 1MiB buffers\n", count);
bo = malloc(sizeof(*bo)*count);
diff --git a/tests/gem_render_tiled_blits.c b/tests/gem_render_tiled_blits.c
index 31b2ee1..626e652 100644
--- a/tests/gem_render_tiled_blits.c
+++ b/tests/gem_render_tiled_blits.c
@@ -88,6 +88,11 @@ int main(int argc, char **argv)
count = atoi(argv[1]);
if (count == 0)
count = 3 * gem_aperture_size(fd) / SIZE / 2;
+ else if (count < 2) {
+ fprintf(stderr, "count must be >= 2\n");
+ return 1;
+ }
+
printf("Using %d 1MiB buffers\n", count);
buf = malloc(sizeof(*buf)*count);
diff --git a/tests/gem_tiled_blits.c b/tests/gem_tiled_blits.c
index a6d5555..bb43976 100644
--- a/tests/gem_tiled_blits.c
+++ b/tests/gem_tiled_blits.c
@@ -132,6 +132,9 @@ int main(int argc, char **argv)
if (count == 0) {
count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
count += (count & 1) == 0;
+ } else if (count < 2) {
+ fprintf(stderr, "count must be >= 2\n");
+ return 1;
}
if (count > intel_get_total_ram_mb() * 9 / 10) {
--
1.7.11.7
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
