)
- rename local variable intel_format_modifiers to modifiers (Ville)
- actually use sprite modifiers
- split out modifier/formats by platform (Ville)
Cc: Ville Syrjälä
Cc: Kristian H. Kristensen
Reviewed-by: Emil Velikov (v8)
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915
On 17-07-29 13:53:10, Daniel Stone wrote:
Hi Ben,
On 26 July 2017 at 19:08, Ben Widawsky wrote:
+ } else if (INTEL_GEN(dev_priv) >= 9) {
intel_primary_formats = skl_primary_formats;
num_formats = ARRAY_SIZE(skl_primary_formats);
- modifi
On 17-07-31 10:29:55, Daniel Vetter wrote:
On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote:
On 17-07-29 13:53:10, Daniel Stone wrote:
> Hi Ben,
>
> On 26 July 2017 at 19:08, Ben Widawsky wrote:
> > + } else if (INTEL_GEN
that does sound a bit wasteful space wise.
v2: Drop the 'dev' argument from the hook
v3: Include the description of the CCS surface layout
v4: Pretend CCS tiles are regular 128 byte wide Y tiles (Jason)
Cc: Daniel Vetter
Cc: Ben Widawsky
Cc: Jason Ekstrand
Reviewed-by: Ben Widaw
ent adjustments (Liviu)
v5: Some new platforms added due to rebase
v6: Add some missed plane inits (or maybe they're new - who knows at
this point) (Daniel)
v7: Add sun8i (Daniel)
Signed-off-by: Ben Widawsky
Reviewed-by: Daniel Stone (v2)
Reviewed-by: Liviu Dudau
Acked-by: Philippe Cornu
rotation is not supported in combination
with
decompression either.
This patch may contain work from at least the following people:
* Vandana Kannan
* Daniel Vetter
* Ben Widawsky
v2: Deal with display workaro
(Ville)
Make BUILD_BUG_ON for blob header size
Cc: Rob Clark
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
Reviewed-by: Daniel Stone (v2)
Reviewed-by: Liviu Dudau (v2)
Reviewed-by: Emil Velikov (v3)
---
drivers/gpu/drm/drm_mode_config.c | 7
drivers/gpu/drm/drm_plane.c
)
- rename local variable intel_format_modifiers to modifiers (Ville)
- actually use sprite modifiers
- split out modifier/formats by platform (Ville)
v10:
- Undo vendor check from v9
Cc: Ville Syrjälä
Cc: Kristian H. Kristensen
Reviewed-by: Emil Velikov (v8)
Signed-off-by: Ben
v2:
- Support sprite plane.
- Support pipe C/D limitation on GEN9.
v3:
- Rename structure (Ville)
- Handle GLK (Ville)
v4:
- Fix PIPE_C check, introduced in v2 (Daniel)
- Whitespace fix (Daniel)
Cc: Daniel Stone
Cc: Kristian Høgsberg
Signed-off-by: Ben Widawsky
---
drivers/gpu
ndent on userptr, but I don't believe we create many
usrptr BOs as the implementation and API reduce the number of BOs in general.
I don't see any reason not to do any of this though. Series is
Acked-by: Ben Widawsky
As an introduction, this allows i915 to create fewer sg table
On 17-09-11 16:25:58, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Other kernel users might want to look at total GPU busyness
in order to implement things like package power distribution
algorithms more efficiently.
Signed-off-by: Tvrtko Ursulin
Cc: Ben Widawsky
Cc: Ben Widawsky
Acked-by
even though there are still
plenty of stale comments in the spec suggesting that we do.
We do need to make sure every hardware unit that deals with the
compressed data uses the same hash mode.
Cc: Ben Widawsky
Cc: Jason Ekstrand
Cc: Daniel Stone
Signed-off-by: Ville Syrjälä
[snip]
Review
t the end of the series
as it is. If it has a more serious user I would need to implement a
proper solution.
Regards,
Tvrtko
P-state driver was looking to use this as a way to make determinations about how
much to limit CPU frequency. Srinivas was privy to the original discussion
--
Ben Wid
-basic: CRASH (0.004s)
Signed-off-by: Gabriel Krisman Bertazi
1-3 so far are
Reviewed-by: Ben Widawsky
---
tests/kms_ccs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 775c6999699f..73025a1e019f 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
On 17-09-27 15:34:17, Gabriel Krisman Bertazi wrote:
Signed-off-by: Gabriel Krisman Bertazi
---
tests/kms_ccs.c | 37 +++--
1 file changed, 27 insertions(+), 10 deletions(-)
diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 73025a1e019f..35dfcca6be14 100644
---
On 17-09-27 15:34:18, Gabriel Krisman Bertazi wrote:
Signed-off-by: Gabriel Krisman Bertazi
Did someone recommend this test? While we have some hardware limitations on
current generations that make it difficult to use multiple BOs, it's certainly
not impossible, and future HW might make this l
On 17-09-27 15:34:19, Gabriel Krisman Bertazi wrote:
Two scenarios tested:
- unaligned stride
- Stride too small
Signed-off-by: Gabriel Krisman Bertazi
Jason, could you provide your opinion on this? I've always felt the kernel
interface shouldn't be validating stride at all.
---
tests/kms
e ability to disable RC6 is valuable not just for debugging
purposes. Folks with very latency sensitive workloads are often willing to
forego power savings. The real problem I see is that we don't test without rc6
in our setup, which indeed makes i
On 17-11-01 18:09:47, Joonas Lahtinen wrote:
+ Kimmo and Paul
On Wed, 2017-11-01 at 07:43 -0700, Ben Widawsky wrote:
On 17-11-01 14:07:28, Joonas Lahtinen wrote:
> On Mon, 2017-10-30 at 10:48 -0700, Rodrigo Vivi wrote:
> > On Mon, Oct 30, 2017 at 01:00:51PM +, David Weineh
On 17-08-01 15:43:50, Kenneth Graunke wrote:
On Tuesday, August 1, 2017 9:58:17 AM PDT Ben Widawsky wrote:
v2:
- Support sprite plane.
- Support pipe C/D limitation on GEN9.
v3:
- Rename structure (Ville)
- Handle GLK (Ville)
v4:
- Fix PIPE_C check, introduced in v2 (Daniel
On 17-08-02 12:14:15, Daniel Vetter wrote:
On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote:
On 17-07-31 10:29:55, Daniel Vetter wrote:
> On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote:
> > On 17-07-29 13:53:10, Daniel Stone wrote:
> > > Hi Ben,
>
On 17-08-03 10:08:51, Daniel Vetter wrote:
On Wed, Aug 2, 2017 at 5:43 PM, Ben Widawsky wrote:
On 17-08-02 12:14:15, Daniel Vetter wrote:
On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote:
On 17-07-31 10:29:55, Daniel Vetter wrote:
> On Sat, Jul 29, 2017 at 09:25:50AM -0700,
On 17-08-03 12:00:56, Daniel Stone wrote:
Hi,
On 1 August 2017 at 17:58, Ben Widawsky wrote:
@@ -1240,6 +1253,19 @@ intel_sprite_plane_create(struct drm_i915_private
*dev_priv,
plane_formats = skl_plane_formats;
num_plane_formats = ARRAY_SIZE(skl_plane_formats
CCS that's documented in the
PRM. By keeping everything CCS cache-line aligned, our chances of
generating correct data for an arbitrary-size surface are much higher.
Signed-off-by: Jason Ekstrand
Cc: Ville Syrjälä
Cc: Ben Widawsky
Cc: Daniel Stone
Cc: Daniel Vetter
Reviewed-by: Ben Widaws
't fully know how it
works yet. Trying to fully describe it is premature.
Signed-off-by: Jason Ekstrand
Cc: Ben Widawsky
Cc: Ville Syrjälä
---
include/uapi/drm/drm_fourcc.h | 35 ++-
1 file changed, 22 insertions(+), 13 deletions(-)
diff --git a/include/uapi/d
This was specifically requested by Emil.
On 17-08-24 22:10:53, Ville Syrjälä wrote:
From: Ville Syrjälä
The unreachable() is very much unreachable and the compiler knows
that, so there's no point in having it.
Cc: Ben Widawsky
Cc: Jason Ekstrand
Cc: Daniel Stone
Signed-off-by:
that we don't need to enforce any massive 2 or 4
MiB alignment for all compressed resources even though there are still
plenty of stale comments in the spec suggesting that we do.
We do need to make sure every hardware unit that deals with the
compressed data uses the same hash mode.
Cc
On 17-08-24 22:10:50, Ville Syrjälä wrote:
From: Ville Syrjälä
The CCS won't have the same stride as the main surface anyway so trying
to guard against the fence stride not matching the CCS stride is
not sensible. Just skip the fence vs. fb alignment check for the aux
plane.
Cc: Ben Wid
*
*/
__u64 formats;
--
hex(0x1f << 98)
'0x7c'
Reviewed-by: Ben Widawsky
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 17-08-31 16:52:15, Gabriel Krisman Bertazi wrote:
With this patch the new testcase igt@kms_ccs@pipe-X-invalid-ccs-offset
succeeds.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/gpu/drm/i915/intel_display.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/inte
they can only be reached by
expanding the tool and forgetting to handle new parameters, with an
error message printed.
CC: Ben Widawsky
Signed-off-by: Petri Latvala
---
tools/intel_l3_parity.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tools
On 17-09-09 02:06:35, Zhi Wang wrote:
Factor out setup_private_pat() for introducing the following patches.
Reviewed-by: Chris Wilson
Cc: Rodrigo Vivi
Cc: Chris Wilson
Cc: Joonas Lahtinen
Signed-off-by: Zhi Wang
Reviewed-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 20
if (scratch_bo == NULL) {
fprintf(stderr, "Couldn't flink buffer\n");
abort();
The series looks good to me, but keep in mind that we never actually made this
work after Sandybridge, and even there, nobody ever ran it but me :-)
Reviewed-by: Ben Widawsk
ces,
and eg. 90/270 degree rotation is not supported in combination with
decompression either.
This patch may contain work from at least the following people:
* Vandana Kannan
* Daniel Vetter
* Ben Widawsky
v2: Deal with display workarounds 0390, 0531, 1125 (Paulo)
Cc: Paulo Zanoni
Cc: Van
ces,
and eg. 90/270 degree rotation is not supported in combination with
decompression either.
This patch may contain work from at least the following people:
* Vandana Kannan
* Daniel Vetter
* Ben Widawsky
v2: Deal with display workarounds 0390, 0531, 1125 (Paulo)
Cc: Paulo Zanoni
Cc: Van
On 17-03-01 12:51:17, Ville Syrjälä wrote:
On Tue, Feb 28, 2017 at 03:20:38PM -0800, Ben Widawsky wrote:
On 17-02-28 12:18:39, Jason Ekstrand wrote:
>I've said it before but reading through Ben's patches again make me want to
>be peskier about it. I would really like the U
: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
Sent: Thursday, March 16, 2017 3:20 PM
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky
Subject: [01/15] drm/i915: Copy user requested buffers into the error state
Introduce a new execobject.flag (EXEC_OBJECT_CAPTURE) that userspace may
use to
On 17-03-21 16:23:05, Tahvanainen, Jari wrote:
See below [Jari]...
-Original Message-
From: Ben Widawsky [mailto:b...@bwidawsk.net]
Sent: Tuesday, March 21, 2017 5:38 PM
To: Tahvanainen, Jari
Cc: Chris Wilson ; intel-gfx@lists.freedesktop.org
Subject: Re: [01/15] drm/i915: Copy user
t the restriction.
Let's start to round up when computing the color plane dimesions
so that we'll not end up with too low an estimate for the memory
requirements and whatnot.
Cc: Ben Widawsky
Cc: Jason Ekstrand
Signed-off-by: Ville Syrjälä
Both 1 and 2 are:
Reviewed-by: Ben Widawsky
)
v3:
- Handle cursor formats (Ville)
- Put handling for LINEAR in the mod_support functions (Ville)
Cc: Ville Syrjälä
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 112 +--
drivers/gpu/drm/i915/intel_sprite.c
They're the same, so use the one which makes more sense.
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm
"Kristian H. Kristensen"
References: https://patchwork.kernel.org/patch/9482393/
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 1 +
drivers/gpu/drm/arm/hdlcd_crtc.c| 1 +
drivers/gpu/drm/arm/malidp_planes.c | 2 +-
dri
On 17-03-29 23:17:13, Ville Syrjälä wrote:
On Fri, Mar 24, 2017 at 02:29:50PM -0700, Ben Widawsky wrote:
This was based on a patch originally by Kristian. It has been modified
pretty heavily to use the new callbacks from the previous patch.
v2:
- Add LINEAR and Yf modifiers to list (Ville
make sprite and cursor have separate functions
---
Ville, I think this addresses most of your comments. I'm guessing you're going
to ask for separate gen sprite plane functions, but I think this looks pretty
decent as is.
---
drivers/gpu/drm/i915/intel_display.c | 26 --
drivers
. Kristensen
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 132 +--
drivers/gpu/drm/i915/intel_sprite.c | 76 +++-
2 files changed, 202 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b
On 16-12-06 13:34:02, Paulo Zanoni wrote:
2016-12-01 20:09 GMT-02:00 Ben Widawsky :
From: Ben Widawsky
This patch series ultimately adds support within the i965 driver for
Renderbuffer Decompression with GBM. In short, this feature reduces memory
bandwidth by allowing the GPU to work with
On 16-12-29 17:34:19, Ben Widawsky wrote:
On 16-12-06 13:34:02, Paulo Zanoni wrote:
2016-12-01 20:09 GMT-02:00 Ben Widawsky :
From: Ben Widawsky
This patch series ultimately adds support within the i965 driver for
Renderbuffer Decompression with GBM. In short, this feature reduces memory
Acked-by: Ben Widawsky
On 16-12-06 16:06:50, Tomeu Vizoso wrote:
Add a few subtests that check that lossless compressed render targets
are properly displayed. Also test a few error conditions.
Cc: Ville Syrjälä
Cc: Ben Widawsky
Signed-off-by: Tomeu Vizoso
---
Hi,
this has been tested
GPU hang
involving this batch.
Use this at your discretion, the contents of the error state. although
compressed, are allocated with GFP_ATOMIC (i.e. limited) and kept for all
eternity (until the error state is destroyed).
Based on an earlier patch by Ben Widawsky
Signed-off-by: Chris Wilson
Cc
On 17-01-03 11:27:52, Rodrigo Vivi wrote:
No functional changes. Apparently spec has been changed
the valid table showing 0x192A as Server GT4
while 0x193A is Server GT4e.
Libdrm and Mesa already have this right. So let's fix the ref here.
Cc: Ben Widawsky
Signed-off-by: Rodrigo
x27; to the new hook (Laurent)
Cc: Laurent Pinchart
Cc: Ben Widawsky
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
drivers/gpu/drm/drm_fourcc.c | 25 +
drivers/gpu/drm/drm_framebuffer.c| 9 +++--
drivers/gpu/drm/drm_m
ot supported in combination with
decompression either.
This patch may contain work from at least the following people:
* Vandana Kannan
* Daniel Vetter
* Ben Widawsky
Cc: Vandana Kannan
Cc: Daniel Vetter
Cc: Ben Widawsky
Cc: Jason Ekstrand
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/
ch case we immediately be
able to tell if any of that stuff changed by just comparing the
pointers. But that does sound a bit wasteful space wise.
v2: Drop the 'dev' argument from the hook
v3: Include the description of the CCS surface layout
Cc: Vandana Kannan
Cc: Daniel Vetter
Cc: Ben
came from where.
Entire series available here:
git://github.com/vsyrjala/linux.git fb_format_dedup_4_ccs
Cc: Vandana Kannan
Cc: Daniel Vetter
Cc: Ben Widawsky
Cc: Jason Ekstrand
Cc: Laurent Pinchart
In addition to review comments I've left, this series (patch 8 and 9 in
particula
On 17-01-11 17:05:04, Ville Syrjälä wrote:
On Thu, Jan 05, 2017 at 02:45:37PM +0100, Christian König wrote:
Am 05.01.2017 um 12:37 schrieb Ville Syrjälä:
> On Wed, Jan 04, 2017 at 07:38:55PM +0100, Rainer Hochecker wrote:
>> From: Rainer Hochecker
>>
>> This adds fourcc codes for 16bit planes r
This was based on a patch originally by Kristian. It has been modified
pretty heavily to use the new callbacks from the previous patch.
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 109 ++-
drivers/gpu/drm
Cc: Kristian Høgsberg
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_display.c | 10 --
drivers/gpu/drm/i915/intel_sprite.c | 2 ++
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
e the modifiers
array a sentinel based structure instead of a sized one. Upon discussion
on IRC, it was determined that having an invalid modifier might make
sense in general as well.
References: https://patchwork.kernel.org/patch/9482393/
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/ar
://lists.freedesktop.org/archives/dri-devel/2016-December/127942.html
Ben Widawsky (3):
drm: Add new DRM_IOCTL_MODE_GETPLANE2
drm/i915: Add format modifiers for Intel
drm/i915: Add support for GET_PLANE2 CCS modifiers
drivers/gpu/drm/arc/arcpgu_crtc.c | 1 +
drivers/gpu/drm/arm
This is expected because it's based on Ville's patch series to define the new
modifiers.
On 17-01-12 01:01:31, Patchwork wrote:
== Series Details ==
Series: GET_PLANE2 w/ i915 implementation
URL : https://patchwork.freedesktop.org/series/17873/
State : failure
== Summary ==
LD [M] sound/p
On 17-01-12 12:51:20, Ville Syrjälä wrote:
On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote:
This was based on a patch originally by Kristian. It has been modified
pretty heavily to use the new callbacks from the previous patch.
Cc: Kristian H. Kristensen
Signed-off-by: Ben
On 17-01-12 20:32:07, Ville Syrjälä wrote:
On Thu, Jan 12, 2017 at 10:00:55AM -0800, Ben Widawsky wrote:
On 17-01-12 12:51:20, Ville Syrjälä wrote:
>On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote:
>> This was based on a patch originally by Kristian. It has been modified
.
Use this at your discretion, the contents of the error state. although
compressed, are allocated with GFP_ATOMIC (i.e. limited) and kept for all
eternity (until the error state is destroyed).
v2: rebased from Chris's tree on top of drm-tip (Mika)
Based on an earlier patch by Ben Widawsky
S
.kernel.org/patch/9482393/
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 1 +
drivers/gpu/drm/arm/hdlcd_crtc.c| 1 +
drivers/gpu/drm/arm/malidp_planes.c | 2 +-
drivers/gpu/drm/armada/armada_crtc.c| 1 +
drivers/gpu/dr
sabled contexts. Or else it blows up pre
gen6 (Ben)
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_gem.c | 15 ---
drivers/gpu/drm/i915/i915_gem_context.c | 23 ---
3 files changed, 25 insertions(+
On Sat, May 25, 2013 at 12:27:01PM -0700, Ben Widawsky wrote:
> After we plumb our code to support multiple address spaces (VMs), there
> are a few situations where we want to be able to traverse the list of
> all address spaces in the system. Cases like eviction, or error state
> co
ger progress.
>
> v2: use atchd to detect stuck ring from loop (Ben Widawsky)
>
> v3: Use acthd to check when ring needs kicking.
> Declare hang on third time in order to give time for
> kick_ring to take effect.
>
> Signed-off-by: Mika Kuoppala
>
>
>
> ---
&
On Tue, May 28, 2013 at 02:30:56PM +0100, Damien Lespiau wrote:
> On Sat, Apr 27, 2013 at 05:59:20PM -0700, Ben Widawsky wrote:
> > @@ -2720,12 +2720,12 @@ static void gen6_enable_rps(struct drm_device *dev)
> > gen6_set_rps(dev_priv->dev, (gt_perf_sta
On Tue, May 28, 2013 at 04:06:07PM +0100, Damien Lespiau wrote:
> On Sat, Apr 27, 2013 at 05:59:27PM -0700, Ben Widawsky wrote:
> > From: "Xiang, Haihao"
> >
> > v2 (Ben): s/hsw/hws
> >
> > Signed-off-by: Xiang, Haihao
> > [Order changed,
On Tue, May 28, 2013 at 03:01:54PM +0100, Damien Lespiau wrote:
> On Sat, Apr 27, 2013 at 05:59:24PM -0700, Ben Widawsky wrote:
> > The motivation here is we're going to add some new interrupt definitions
> > and handling outside of the GT interrupts which is all we've
again to Damien for the review this far.
v1 with more background:
http://lists.freedesktop.org/archives/intel-gfx/2013-April/027308.html
Ben Widawsky (14):
drm/i915: Comments for semaphore clarification
drm/i915: Semaphore MBOX update generalization
drm/i915: Introduce VECS: the 4th ring
structures.
This patch should have no functional impact.
v2: The English parts (as opposed to register names) of the comments
were reversed. (Damien)
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_reg.h | 12 ++--
drivers/gpu/drm/i915/intel_ringbuffer.c | 18
which supported semaphores had a fixed number of
rings and so it made sense for the code to be very specialized
(hardcoded).
The patch does contain a functional change, but should have no
behavioral changes.
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers
rings
is a bit scary. As such the patch is not terribly useful by itself, but
a pretty nice place to find issues during a bisection.
Reviewed-by: Damien Lespiau
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++
drivers/gpu/drm/i915/intel_ringbuffer.h | 3 ++-
2 files
amien)
Restore the still valid invariant. (Damien)
The bsd semaphore register should be MI_SEMAPHORE_SYNC_VVE (Damien)
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_reg.h | 40 ++---
drivers/gpu/drm/i915/intel_ringbuffer.c | 6 +
2 files change
v2: Use the correct lock to protect PM interrupt regs, this was
accidentally lost from earlier (Haihao)
Fix return types (Ben)
Reviewed-by: Damien Lespiau
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 46 +++--
drivers/gpu/drm/i915
patch a bit nicer.
The change should also only effect HSW platforms.
Reviewed-by: Damien Lespiau
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_irq.c | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b
v2: Add new PCH_NOP check (Damien)
Add SDEIMR comment (Damien)
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_irq.c | 33 -
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
From: "Xiang, Haihao"
The flag will be useful to help share code between IVB, and HSW as the
programming is similar in many places with this as one of the major
differences.
Signed-off-by: Xiang, Haihao
[Commit message + small fix by]
Reviewed-by: Damien Lespiau
Signed-off-by: Be
hanged quite a bit, and I believe removing this
assertion is perfectly safe.
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_irq.c | 10 ++
drivers/gpu/drm/i915/intel_pm.c | 2 +-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/dr
the weird one. Doing this allows us to call
gen6_ring_flush for the vebox because calling blt_ring_flush would be
weird...
This patch should have no functional change.
Reviewed-by: Damien Lespiau
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 12 ++--
1 file
le/disable rps functions (Haihao)
v3: Bug found by Chris where we were clearing the wrong bits at rps
disable.
expanded commit message
v4: v3 was based off the wrong branch
v5: Added the setting of PMIMR because of previous patch update
CC: Chris Wilson
Signed-off-by: Ben Widawsky
---
driver
It's overkill on older gens, but it's useful for newer gens.
Reviewed-by: Damien Lespiau
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 16
drivers/gpu/drm/i915/intel_ringbuffer.h | 4 +++-
2 files changed, 11 insertions(+), 9 deletion
v2: Add set_seqno which didn't exist before rebase (Haihao)
Signed-off-by: Ben Widawsky
Reviewed-by: Damien Lespiau
Signed-off-by: Xiang, Haihao
---
drivers/gpu/drm/i915/i915_gem.c | 11 ++-
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm
in each set, ie. one for global, and one for ring. This made
things confusing when using the wrong defines in the wrong places.
rebase: Modified VLV bits
v2: Renamed GT_RENDER_MASTER to GT_RENDER_CS_MASTER (Damien)
Reviewed-by: Damien Lespiau
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/
From: "Xiang, Haihao"
A user can run batchbuffer via VEBOX ring.
Signed-off-by: Xiang, Haihao
Reviewed-by: Damien Lespiau
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 9 +
include/uapi/drm/i915_drm.h| 1 +
2 files c
From: "Xiang, Haihao"
v2: Removed rebase relic VECS ring from i915_gem_request_info (Damien)
Signed-off-by: Xiang, Haihao
[Order changed, and modified by]
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drive
From: "Xiang, Haihao"
This will let userland only try to use the new ring
when the appropriate kernel is present
Signed-off-by: Xiang, Haihao
Reviewed-by: Damien Lespiau
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_dma.c | 3 +++
include/uapi/drm/i915_drm.h | 2 +
, Haihao
Reviewed-by: Damien Lespiau
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_irq.c | 31 +--
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++-
3 files changed, 30 insertions(+), 7 deletions
no PPGTT, and we
disable PPGTT on gen6 with VT-D. Since Mesa depends on gen6+ having HW
contexts, this is a requirement.
Just compiled tested for now, I'll do more testing on it if the relevant
parties find it swallowable.
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_dma.c
From: "Xiang, Haihao"
v2: Removed rebase relic VECS ring from i915_gem_request_info (Damien)
v3: s/hsw/hws in debugfs which I introduced in v2 (Jon)
Signed-off-by: Xiang, Haihao
[Order changed, and modified by]
CC: "Bloomfield, Jon"
Signed-off-by: Ben Widawsky
---
t; -
> - return false;
> -}
> -
> /**
> * This is called when the chip hasn't reported back with completed
> * batchbuffers in a long time. We keep track per ring seqno progress and
> --
> 1.7.9.5
>
--
Ben Widawsky, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
15: report Gen5+ CPU and PCH FIFO underruns
>
> Cc: Paulo Zanoni
> Cc: Ben Widawsky
> Signed-off-by: Daniel Vetter
Reviewed-by: Ben Widawsky
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
___
Intel-gfx mailing list
If we properly keep track of the pages_pin_count, then when we later add
multiple address spaces, the put_pages doesn't need any special checks
to be able to perform it's job.
CC: Chris Wilson
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_gem.c | 5 +++--
1 file
It's not terribly interesting to know that a parameter doesn't exist,
and it can get in the way of interesting messages, especially with the
staggered VECS merging as we've done.
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_dma.c | 3 +--
1 file changed, 1 insertion(
This is the only place I could find where we don't already unbind the
object before freeing it. This change will allow us to have a nice
assertion on free about whether or not an object still has pinned pages.
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/intel_fb.c | 1 +
1 file ch
Since it will be used for the global bound/unbound list with full PPGTT,
this helps clarify things for upcoming code rework.
Recommended-by: Chris Wilson
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_debugfs.c| 11 ++-
drivers/gpu/drm/i915/i915_drv.h| 2
This is the only place I could find where we don't already unbind the
object before freeing it. This change will allow us to have a nice
assertion on free about whether or not an object still has pinned pages.
v2: Just use the i915 object instead of casting
Signed-off-by: Ben Wid
On Fri, May 31, 2013 at 08:52:29PM +0200, Daniel Vetter wrote:
> On Tue, May 28, 2013 at 07:22:34PM -0700, Ben Widawsky wrote:
> > From: "Xiang, Haihao"
> >
> > This will let userland only try to use the new ring
> > when the appropriate kernel is present
On Fri, May 31, 2013 at 08:39:32PM +0100, Chris Wilson wrote:
> On Fri, May 31, 2013 at 11:45:29AM -0700, Ben Widawsky wrote:
> > This is the only place I could find where we don't already unbind the
> > object before freeing it. This change will allow us to have a nice
> &g
101 - 200 of 3830 matches
Mail list logo
