On 07/08/2024 04:46, Matthew Wilcox wrote:
> On Tue, Aug 06, 2024 at 10:26:17PM +0800, kernel test robot wrote:
>> kernel test robot noticed "kernel_BUG_at_include/linux/page-flags.h" on:
>>
>> commit: cdc4ad36a871b7ac43fcc6b2891058d332ce60ce ("fs: Convert
>> aops->write_begin to take a folio")
>>
== Series Details ==
Series: usb: typec: ucsi: Fix a potential deadlock in ucsi_send_command_common()
URL : https://patchwork.freedesktop.org/series/136962/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15192 -> Patchwork_136962v1
==
> -Original Message-
> From: Golani, Mitulkumar Ajitkumar
>
> Sent: Wednesday, August 7, 2024 9:33 AM
> Cc: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org; Kandpal,
> Suraj
> Subject: [PATCH v2] drm/i915/bmg: Read display register timeout
>
> Log the address of the re
From: Chris Wilson
After we detect that mmio is returning all 0xff, we believe that the GPU
has dropped off the pci bus and is dead. Mark the device as wedged such
that we can propagate the failure back to userspace and wait for
recovery.
Signed-off-by: Chris Wilson
Signed-off-by: Andi Shyti
-
> -Original Message-
> From: Deak, Imre
> Sent: Tuesday, August 6, 2024 10:11 PM
> To: Murthy, Arun R
> Cc: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/xe/pm: Change HPD to polling on runtime suspend
>
> On Tue, Aug 06, 2024 at 02:25:13PM
== Series Details ==
Series: drm/i915/bmg: Read display register timeout (rev2)
URL : https://patchwork.freedesktop.org/series/136497/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15191_full -> Patchwork_136497v2_full
Summ
On Fri, 05 Jul 2024, Arun R Murthy wrote:
> Statistics is generated from the image frame that is coming to display
> and an event is sent to user after reading this histogram data.
> This statistics/histogram is then shared with the user upon getting a
> request from user. User can then use this h
On Wed, Aug 07, 2024 at 04:46:15AM GMT, Matthew Wilcox wrote:
> On Tue, Aug 06, 2024 at 10:26:17PM +0800, kernel test robot wrote:
> > kernel test robot noticed "kernel_BUG_at_include/linux/page-flags.h" on:
> >
> > commit: cdc4ad36a871b7ac43fcc6b2891058d332ce60ce ("fs: Convert
> > aops->write_be
On Fri, 05 Jul 2024, Arun R Murthy wrote:
> Upon enabling histogram an interrupt is trigerred after the generation
> of the statistics. This patch registers the histogram interrupt and
> handles the interrupt.
>
> Signed-off-by: Arun R Murthy
> ---
> .../gpu/drm/i915/display/intel_display_irq.c
On Fri, 05 Jul 2024, Arun R Murthy wrote:
> In LNL+, histogram/IE data and index registers are added which was
> included in the control registers in the legacy platforms. The new
> registers are used for reading histogram and writing the IET LUT data.
>
> Signed-off-by: Arun R Murthy
> ---
> ..
On Fri, 05 Jul 2024, Arun R Murthy wrote:
> +/* GLOBAL_HIST related registers */
> +#define _DPST_CTL_A 0x490C0
> +#define _DPST_CTL_B 0x491C0
> +#define DPST_CTL(pipe)
> _MMIO_PIPE(pipe, _DPST
Hi,
This patch series concludes on the memory mapping fixes and
improvements by allowing partial memory mapping for the cpu
memory as well.
The partial memory mapping by adding an object offset was
implicitely included in commit 8bdd9ef7e9b1 ("drm/i915/gem: Fix
Virtual Memory mapping boundaries c
In preparation for the upcoming partial memory mapping feature,
we want to make sure that when looking for a node we consider
also the offset and not just the starting address of the virtual
memory node.
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 6 +++---
1 file ch
To enable partial memory mapping of GPU virtual memory, it's
necessary to introduce an offset to the object's memory
(obj->mm.pages) scatterlist. This adjustment compensates for
instances when userspace mappings do not start from the beginning
of the object.
Based on a patch by Chris Wilson.
Sign
On 06/08/2024 14:38, Jani Nikula wrote:
__i915_printk() does nothing for notice/info levels. Just use the
regular drm_notice() and drm_info() calls.
"does nothing"? You mean does nothing _special_?
The patch itself looks okay.
Regards,
Tvrtko
Signed-off-by: Jani Nikula
---
drivers/gpu
> > +static int intel_histogram_enable(struct intel_crtc *intel_crtc) {
> > + struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
> > + struct intel_histogram *histogram = intel_crtc->histogram;
> > + int pipe = intel_crtc->pipe;
> > + u64 res;
> > + u32 gbandthreshold;
> > +
>
On 06/08/2024 14:38, Jani Nikula wrote:
i915_report_error() has only two users, both in driver probe. I doubt
these cases are worth having a dedicated wrapper to also print bug
reporting info. Just switch them to regular drm_err() and remove the
wrapper.
Signed-off-by: Jani Nikula
---
drive
== Series Details ==
Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable
URL : https://patchwork.freedesktop.org/series/136975/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On 06/08/2024 14:38, Jani Nikula wrote:
With the previous cleanups, the last remaining user of __i915_printk()
is i915_probe_error(). Switch that to use drm_dbg() and drm_err()
instead, dropping the request to report bugs in the few remaining
specific cases.
Aren't those few cases legitimate
By moving the pfn calculation to the set_address_limits()
function we improve code readability. This way,
set_address_limits() is responsible for calculating all memory
mapping paramenters: "start", "end" and "pfn".
This suggestion from Jonathan was made during the review of
commit 8bdd9ef7e9b1 ("
== Series Details ==
Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable
URL : https://patchwork.freedesktop.org/series/136975/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15194 -> Patchwork_136975v1
Summary
Quoting Tvrtko Ursulin (2024-05-21 13:12:01)
> From: Tvrtko Ursulin
>
> Kernel test robot reports i915 can hit a warn in kvmalloc_node which has
> a purpose of dissalowing crazy size kernel allocations. This was added in
> 7661809d493b ("mm: don't allow oversized kvmalloc() calls"):
>
>/
Hi,
On 05/08/2024 19:48, Kees Cook wrote:
This seems like some kind of pre-existing issue in the igt test, reachable
via eb_copy_relocations(). The only warning in kvmalloc_node_noprof() is:
/* Don't even allow crazy sizes */
if (unlikely(size > INT_MAX)) {
== Series Details ==
Series: Allow partial memory mapping for cpu memory
URL : https://patchwork.freedesktop.org/series/136981/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15194 -> Patchwork_136981v1
Summary
---
**
On Wed, 07 Aug 2024, Tvrtko Ursulin wrote:
> On 06/08/2024 14:38, Jani Nikula wrote:
>> __i915_printk() does nothing for notice/info levels. Just use the
>> regular drm_notice() and drm_info() calls.
>
> "does nothing"? You mean does nothing _special_?
Yeah, does nothing in addition to the regula
On Wed, 07 Aug 2024, Tvrtko Ursulin wrote:
> On 06/08/2024 14:38, Jani Nikula wrote:
>> With the previous cleanups, the last remaining user of __i915_printk()
>> is i915_probe_error(). Switch that to use drm_dbg() and drm_err()
>> instead, dropping the request to report bugs in the few remaining
>
On Wed, 2024-08-07 at 11:57 +0530, Chaitanya Kumar Borah wrote:
> From: Heikki Krogerus
>
> The function returns with the ppm_lock held if there's an
> error or the PPM reports BUSY condition.
>
> This is a core-for-ci patch for [1]
>
> [1]
> https://lore.kernel.org/linux-usb/20240806112029.29
On 2024-08-07 at 11:45:53 GMT, Andi Shyti wrote:
> By moving the pfn calculation to the set_address_limits()
> function we improve code readability. This way,
> set_address_limits() is responsible for calculating all memory
> mapping paramenters: "start", "end" and "pfn".
>
> This suggestion from
Add hwmon support for fan1_input attribute, which will expose fan speed
in RPM. With this in place we can monitor fan speed using lm-sensors tool.
$ sensors
i915-pci-0300
Adapter: PCI adapter
in0: 653.00 mV
fan1:3833 RPM
power1: N/A (max = 43.00 W)
energy1: 32.02 k
== Series Details ==
Series: drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()
URL : https://patchwork.freedesktop.org/series/136985/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15195 -> Patchwork_136985v1
===
On Wed, 07 Aug 2024, "Coelho, Luciano" wrote:
> On Wed, 2024-08-07 at 11:57 +0530, Chaitanya Kumar Borah wrote:
>> From: Heikki Krogerus
>>
>> The function returns with the ppm_lock held if there's an
>> error or the PPM reports BUSY condition.
>>
>> This is a core-for-ci patch for [1]
>>
>> [
== Series Details ==
Series: drm/i915/hwmon: expose fan speed (rev3)
URL : https://patchwork.freedesktop.org/series/136036/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15195 -> Patchwork_136036v3
Summary
---
**SUCC
Hi,
I was bothered a few times to see the double space in the
parameters list so that I decided to replace once and for all all
the double spaces that are not added on purpose to maintain some
visual alignment in the code.
Checkpatch doesn't have any rules for that because, indeed, this
is used a
Do not use double blanks, ", " in function parameters where it's
not required by any alignment purpose. Replase it with a single
blank, ", ".
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 2 +-
drivers/gpu/drm/i915/gt/selftest_migrate.c | 2 +-
d
Do not use double blanks, ", " in function parameters where it's
not required by any alignment purpose. Replase it with a single
blank, ", ".
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +-
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
d
On Wed, 07 Aug 2024, Andi Shyti wrote:
> Hi,
>
> I was bothered a few times to see the double space in the
> parameters list so that I decided to replace once and for all all
> the double spaces that are not added on purpose to maintain some
> visual alignment in the code.
>
> Checkpatch doesn't h
Hi Raag,
> +static umode_t
> +hwm_fan_is_visible(const struct hwm_drvdata *ddat, u32 attr)
> +{
> + struct i915_hwmon *hwmon = ddat->hwmon;
> +
> + switch (attr) {
> + case hwmon_fan_input:
> + return i915_mmio_reg_valid(hwmon->rg.fan_speed) ? 0444 : 0;
> + default:
> +
== Series Details ==
Series: Trivial double space style fix
URL : https://patchwork.freedesktop.org/series/136995/
State : warning
== Summary ==
Error: dim checkpatch failed
0075161e228e drm/i915: Replace double blank with single blank after comma in
gem/ and gt/
2b5f0fa917e4 drm/i915: Replac
== Series Details ==
Series: Trivial double space style fix
URL : https://patchwork.freedesktop.org/series/136995/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/dp_mst: Fix MST state after a sink reset (rev2)
URL : https://patchwork.freedesktop.org/series/136443/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/136443/revisions/2/mbox/ not
applied
Applying: drm/i915/dp_
== Series Details ==
Series: Trivial double space style fix
URL : https://patchwork.freedesktop.org/series/136995/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136995v1
Summary
---
**FAILURE**
-Original Message-
From: Andi Shyti
Sent: Wednesday, August 7, 2024 3:46 AM
To: intel-gfx ; dri-devel
Cc: Niemiec, Krzysztof ; Andi Shyti
; Cavitt, Jonathan
Subject: [PATCH] drm/i915/gem: Improve pfn calculation readability in
vm_fault_gtt()
>
> By moving the pfn calculation to the
-Original Message-
From: Andi Shyti
Sent: Wednesday, August 7, 2024 2:10 AM
To: intel-gfx ; dri-devel
Cc: Chris Wilson ; Das, Nirmoy
; Cavitt, Jonathan ; Andi
Shyti
Subject: [PATCH] drm/i915/gt: Mark the GT as dead when mmio is unreliable
>
> From: Chris Wilson
>
> After we detect
On Wed, Aug 07, 2024 at 12:15:33PM +0300, Murthy, Arun R wrote:
>
> > -Original Message-
> > From: Deak, Imre
> > Sent: Tuesday, August 6, 2024 10:11 PM
> > To: Murthy, Arun R
> > Cc: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org
> > Subject: Re: [PATCH] drm/xe/pm: Chan
Hi John,
On Mon, Aug 05, 2024 at 05:57:19PM -0700, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> The context switch hold out workaround also applies to DG2.
>
> Signed-off-by: John Harrison
Reviewed-by: Andi Shyti
Thanks,
Andi
Log the address of the register that caused the timeout
interrupt by reading RMTIMEOUTREG_CAPTURE
--v2:
- Update RMTIMEOUTREG_CAPTURE naming (Suraj)
--v3:
- XeLpdp naming convention.
- Use if condition instead of else if
Signed-off-by: Mitul Golani
Reviewed-by: Suraj Kandpal
---
drivers/gpu/d
On 07/08/2024 12:40, Jani Nikula wrote:
On Wed, 07 Aug 2024, Tvrtko Ursulin wrote:
On 06/08/2024 14:38, Jani Nikula wrote:
With the previous cleanups, the last remaining user of __i915_printk()
is i915_probe_error(). Switch that to use drm_dbg() and drm_err()
instead, dropping the request to
== Series Details ==
Series: Trivial double space style fix (rev2)
URL : https://patchwork.freedesktop.org/series/136995/
State : warning
== Summary ==
Error: dim checkpatch failed
1130089304ff drm/i915: Replace double blank with single blank after comma in
gem/ and gt/
af7a3374fd65 drm/i915:
== Series Details ==
Series: Trivial double space style fix (rev2)
URL : https://patchwork.freedesktop.org/series/136995/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Trivial double space style fix (rev2)
URL : https://patchwork.freedesktop.org/series/136995/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136995v2
Summary
---
**FAILUR
Hi Mikulaus,
On Mon, Aug 05, 2024 at 04:29:52PM +0200, Mikulas Patocka wrote:
> Zdenek Kabelac reported that his syslog was flooded with many messages:
> Purging GPU memory, 0 pages freed, 0 pages still pinned, 2029 pages left
> available.
Checkpatch complains here:
WARNING:COMMIT_LOG_LONG_LINE
Hi Jani,
On Tue, Aug 06, 2024 at 04:38:30PM +0300, Jani Nikula wrote:
> __i915_printk() does nothing for notice/info levels. Just use the
> regular drm_notice() and drm_info() calls.
>
> Signed-off-by: Jani Nikula
With the commit log improvements suggested by Tvrtko and
yourself:
Reviewed-by:
Hi Jani,
On Tue, Aug 06, 2024 at 04:38:31PM +0300, Jani Nikula wrote:
> i915_report_error() has only two users, both in driver probe. I doubt
> these cases are worth having a dedicated wrapper to also print bug
> reporting info. Just switch them to regular drm_err() and remove the
> wrapper.
>
>
Hi Jani,
On Tue, Aug 06, 2024 at 04:38:32PM +0300, Jani Nikula wrote:
> With the previous cleanups, the last remaining user of __i915_printk()
> is i915_probe_error(). Switch that to use drm_dbg() and drm_err()
> instead, dropping the request to report bugs in the few remaining
> specific cases.
>
Hi Thorsten,
> > /* This check is primarily to ensure that oa_period <=
> > -* UINT32_MAX (before passing to do_div which only
> > +* UINT32_MAX (before passing it to div_u64 which only
> > * accepts a u32 denominator
== Series Details ==
Series: drm/i915/bmg: Read display register timeout (rev3)
URL : https://patchwork.freedesktop.org/series/136497/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136497v3
Summary
--
== Series Details ==
Series: Trivial double space style fix (rev3)
URL : https://patchwork.freedesktop.org/series/136995/
State : warning
== Summary ==
Error: dim checkpatch failed
7f0b95c3cf8d drm/i915: Replace double blank with single blank after comma in
gem/ and gt/
7b29ef50efd0 drm/i915:
== Series Details ==
Series: Trivial double space style fix (rev3)
URL : https://patchwork.freedesktop.org/series/136995/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Trivial double space style fix (rev3)
URL : https://patchwork.freedesktop.org/series/136995/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136995v3
Summary
---
**SUCCES
On Tue, Aug 06, 2024 at 03:14:02PM GMT, Jani Nikula wrote:
On Tue, 06 Aug 2024, Jani Nikula wrote:
On Thu, 01 Aug 2024, Gustavo Sousa wrote:
Quoting Jani Nikula (2024-07-29 11:30:04-03:00)
The test code seems to assume struct drm_device * is stored in
drvdata. This is (currently) not the cas
Quoting Jani Nikula (2024-08-06 11:14:00-03:00)
>On Tue, 06 Aug 2024, Jani Nikula wrote:
>> On Thu, 01 Aug 2024, Gustavo Sousa wrote:
>>> Quoting Jani Nikula (2024-07-29 11:30:10-03:00)
Use to_intel_display() instead of kdev_to_i915() in the HDCP component
API hooks. Avoid further drive-b
On Tue, Aug 6, 2024 at 3:06 AM Thomas Zimmermann wrote:
>
> Hi
>
> Am 05.08.24 um 21:00 schrieb Deucher, Alexander:
> > [Public]
> >
> >> -Original Message-
> >> From: Thomas Zimmermann
> >> Sent: Wednesday, July 31, 2024 8:17 AM
> >> To: maarten.lankho...@linux.intel.com; mrip...@kernel.
Hi Ma,
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index c2c388212e2e..9dd7b5985d57 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -6115,7 +6115,7 @@ static in
== Series Details ==
Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable
URL : https://patchwork.freedesktop.org/series/136975/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15194_full -> Patchwork_136975v1_full
== Series Details ==
Series: Allow partial memory mapping for cpu memory (rev2)
URL : https://patchwork.freedesktop.org/series/136981/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136981v2
Summary
--
Hi Thorsten,
> diff --git a/drivers/gpu/drm/i915/i915_perf.c
> b/drivers/gpu/drm/i915/i915_perf.c
> index 025a79fe5920..6ff905d2b78f 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -4063,17 +4063,13 @@ static int read_properties_unlocked(struct i915_p
== Series Details ==
Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev2)
URL : https://patchwork.freedesktop.org/series/136975/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev2)
URL : https://patchwork.freedesktop.org/series/136975/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136975v2
S
On Wed, Aug 07, 2024 at 02:24:27PM +0100, Andi Shyti wrote:
> Hi Raag,
>
> > +static umode_t
> > +hwm_fan_is_visible(const struct hwm_drvdata *ddat, u32 attr)
> > +{
> > + struct i915_hwmon *hwmon = ddat->hwmon;
> > +
> > + switch (attr) {
> > + case hwmon_fan_input:
> > + return i
In panel fitter/pipe scaler scenario the pch_pfit configuration
currently takes place before accounting for pipe_src width for
joiner. This causes issue when pch_pfit and joiner get enabled
together.
Introduce a new boolean flag need_joiner which is set during dp
compute_config in joiner case and
Hi
Am 07.08.24 um 21:47 schrieb Alex Deucher:
On Tue, Aug 6, 2024 at 3:06 AM Thomas Zimmermann wrote:
Hi
Am 05.08.24 um 21:00 schrieb Deucher, Alexander:
[Public]
-Original Message-
From: Thomas Zimmermann
Sent: Wednesday, July 31, 2024 8:17 AM
To: maarten.lankho...@linux.intel.co
== Series Details ==
Series: Consider joiner calculation for panel fitting (rev3)
URL : https://patchwork.freedesktop.org/series/136561/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136561v3
Summary
== Series Details ==
Series: drm/i915/bmg: Read display register timeout (rev3)
URL : https://patchwork.freedesktop.org/series/136497/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15196_full -> Patchwork_136497v3_full
Summ
HPD is interrupt based and on runtime suspend change it to polling as
HPD is not a wakeup event. A worker thread is scheduled for doing this
polling and it keeps polling for HPD live status on an internval of 10s.
On runtime resume disable polling and fallback to interrupt mechanism.
v2: move poll
== Series Details ==
Series: drm/xe/pm: Change HPD to polling on runtime suspend (rev2)
URL : https://patchwork.freedesktop.org/series/136917/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/136917/revisions/2/mbox/ not
applied
Applying: drm/xe/dis
75 matches
Mail list logo
