On Tue, Aug 6, 2024 at 3:06 AM Thomas Zimmermann <tzimmerm...@suse.de> wrote:
>
> Hi
>
> Am 05.08.24 um 21:00 schrieb Deucher, Alexander:
> > [Public]
> >
> >> -----Original Message-----
> >> From: Thomas Zimmermann <tzimmerm...@suse.de>
> >> Sent: Wednesday, July 31, 2024 8:17 AM
> >> To: maarten.lankho...@linux.intel.com; mrip...@kernel.org;
> >> airl...@gmail.com; dan...@ffwll.ch
> >> Cc: amd-...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; intel-
> >> g...@lists.freedesktop.org; intel...@lists.freedesktop.org; Thomas
> >> Zimmermann <tzimmerm...@suse.de>; Deucher, Alexander
> >> <alexander.deuc...@amd.com>; Koenig, Christian
> >> <christian.koe...@amd.com>; Pan, Xinhui <xinhui....@amd.com>
> >> Subject: [PATCH 1/9] drm/amdgpu: Use backlight power constants
> >>
> >> Replace FB_BLANK_ constants with their counterparts from the backlight
> >> subsystem. The values are identical, so there's no change in functionality
> >> or
> >> semantics.
> >>
> >> Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
> >> Cc: Alex Deucher <alexander.deuc...@amd.com>
> >> Cc: "Christian König" <christian.koe...@amd.com>
> >> Cc: Xinhui Pan <xinhui....@amd.com>
> > This patch and the radeon patch are:
> > Acked-by: Alex Deucher <alexander.deuc...@amd.com>
> >
> > Feel free to take them via whatever tree makes sense if you are trying to
> > keep the patches together, or let me know if you want me to pick them up.
>
> Thank you for the reviews. Please pick up both patches into the rsp AMD
> trees. The i915 patch already went into Intel trees and the rest of the
> series will go into drm-misc.
What changes do these depend on? BACKLIGHT_POWER_ON isn't declared in
my -next tree yet. Might be easier to just run them through drm-misc
if that's where the change is.
Alex
>
> Best regards
> Thomas
>
> >
> > Thanks,
> >
> > Alex
> >
> >> ---
> >> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> >> b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> >> index 25feab188dfe..650ec95bb40a 100644
> >> --- a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> >> +++ b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> >> @@ -215,7 +215,7 @@ void
> >> amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder
> >> *amdgpu_encode
> >> dig->bl_dev = bd;
> >>
> >> bd->props.brightness =
> >> amdgpu_atombios_encoder_get_backlight_brightness(bd);
> >> - bd->props.power = FB_BLANK_UNBLANK;
> >> + bd->props.power = BACKLIGHT_POWER_ON;
> >> backlight_update_status(bd);
> >>
> >> DRM_INFO("amdgpu atom DIG backlight initialized\n");
> >> --
> >> 2.45.2
>
> --
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
>
