Re: [Intel-gfx] [PATCH v3 3/4] PCI/VGA: only deal with VGA class devices

Hi, On 2023/6/9 03:12, Bjorn Helgaas wrote: Start with verb and capitalize to match ("Deal only with ...") On Thu, Jun 08, 2023 at 07:43:21PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng vgaarb only deal with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function wi

Re: [Intel-gfx] [PATCH v3 4/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

Hi, On 2023/6/9 03:19, Bjorn Helgaas wrote: On Thu, Jun 08, 2023 at 07:43:22PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng The vga_is_firmware_default() function is arch-dependent, which doesn't sound right. At least, it also works on the Mips and LoongArch platforms. Tested with the drm/am

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Track buffer objects belonging to clients

On 08-06-2023 20:21, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In order to show per client memory usage lets start tracking which > objects belong to which clients. > > We start with objects explicitly created by object creation UAPI and > track it on a new per client lists, protected

[Intel-gfx] [PATCH 1/2] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names

Starting from DP2.0 specs, DPCD 248h is renamed LINK_QUAL_PATTERN_SELECT and it has the same values of registers DPCD 10Bh-10Eh. Use the PHY pattern names defined for DPCD 10Bh-10Eh in order to add CP2520 Pattern 3 (TPS4) phy pattern support in the next patch of this series and DP2.1 PHY patterns f

[Intel-gfx] [PATCH 2/2] drm/i915/dp: Add TPS4 PHY test pattern support

Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source tests. Bspec: 50482, 50484 CC: Jani Nikula Cc: Imre Deak Cc: Lee Shawn C Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/i915/display/intel_dp.c | 11 +++ drivers/gpu/drm/i915/i915_reg.h | 4 2 files ch

[Intel-gfx] [PATCH] drm/i915/dp: Cable type identification for DP2.1

For DP alt mode display driver get the information about cable speed and cable type through TCSS_DDI_STATUS register which will be updated by type-c platform driver. Accodingly Update dpcd 0x110 with cable information before link training start. This change came part of DP2.1 SCR. Note: This patch

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names

== Series Details == Series: series starting with [1/2] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names URL : https://patchwork.freedesktop.org/series/119106/ State : warning == Summary == Error: dim checkpatch failed f0c7baf40bbf drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test patt

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dp: Cable type identification for DP2.1

== Series Details == Series: drm/i915/dp: Cable type identification for DP2.1 URL : https://patchwork.freedesktop.org/series/119109/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add new vswing table for C20 phy to support DP 1.4 (rev3)

== Series Details == Series: drm/i915/mtl: Add new vswing table for C20 phy to support DP 1.4 (rev3) URL : https://patchwork.freedesktop.org/series/118925/ State : success == Summary == CI Bug Log - changes from CI_DRM_13248 -> Patchwork_118925v3 ===

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)

Hi Jani: Please take the as my S-O-B since this is a patch about GVT-g. I still don't know why my intel email smtp doesn't work. Thanks, Zhi. -Original Message- From: Intel-gfx On Behalf Of Jani Nikula Sent: Monday, June 5, 2023 10:36 PM To: Zhi Wang Cc: intel-gfx@lists.freedesktop.

Re: [Intel-gfx] [PATCH v5 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

On Tue, 06 Jun 2023, Luca Coelho wrote: > In order to avoid flush_scheduled_work() usage, add a dedicated > workqueue in the drm_i915_private structure. In this way, we don't > need to use the system queue anymore. > > This change is mostly mechanical and based on Tetsuo's original > patch[1]. >

[Intel-gfx] [PATCH] drm/i915/display/dp: On AUX xfer timeout restart freshly

As part of restart on AUX xfer timeout, check for busy status and then start sending the data. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 50 + 1 file changed, 22 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/i915/display/int

Re: [Intel-gfx] [PATCH] drm/i915/gsc: Fix error code in intel_gsc_uc_heci_cmd_submit_nonpriv()

On Wed, Jun 07, 2023 at 06:44:54PM +, Teres Alexis, Alan Previn wrote: > On Tue, 2023-06-06 at 21:32 +0300, Dan Carpenter wrote: > > On Tue, Jun 06, 2023 at 06:07:19PM +, Teres Alexis, Alan Previn wrote: > > > That was my bad, i could have sword i'd fixed that before the final rev. > > > T

[Intel-gfx] [PULL] drm-intel-fixes

Hi Dave & Daniel, Here's the drm-intel-fixes PR for v6.4-rc6. Couple of display compatibility fixes and two static checker fixes for selftests. Regards, Joonas *** drm-intel-fixes-2023-06-08: CDCLK voltage fix for ADL-P and eDP wake sync pulse fix. Two error handling fixes to selftests (to ap

[Intel-gfx] [PULL] drm-intel-fixes

Hi Dave, Daniel, drm-misc-fixes for v6.4-rc6. Seems to be mostly small fixes, just a few more for ivpu. Cheers, ~Maarten drm-misc-fixes-2023-06-08: drm-misc-fixes for v6.4-rc6: - resume and modeset fixes for ast. - Fill in fb-helper vars more correctly. - Assorted ivpu fixes. - lima context d

[Intel-gfx] [PULL] drm-MISC-fixes

Oops, forgot to fix topic. :-) On 2023-06-08 10:41, Joonas Lahtinen wrote: > Hi Dave & Daniel, > > Here's the drm-intel-fixes PR for v6.4-rc6. > > Couple of display compatibility fixes and two static checker fixes for > selftests. > > Regards, Joonas > > *** > > drm-intel-fixes-2023-06-08: > > CDC

Re: [Intel-gfx] [PULL] drm-MISC-fixes

On Thu, 08 Jun 2023, Maarten Lankhorst wrote: > Oops, forgot to fix topic. :-) And replied to the wrong message. ;) But why was it wrong, not using dim? BR, Jani. > > On 2023-06-08 10:41, Joonas Lahtinen wrote: >> Hi Dave & Daniel, >> >> Here's the drm-intel-fixes PR for v6.4-rc6. >> >> Coupl

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)

On Thu, 08 Jun 2023, "Wang, Zhi A" wrote: > Please take the as my S-O-B since this is a > patch about GVT-g. I still don't know why my intel email smtp doesn't > work. Thanks, pushed. You should be able to configure git to set your author From: in the patch, even when sending the patch email wi

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)

Thanks so much for the trick. Learned. -Original Message- From: Jani Nikula Sent: Thursday, June 8, 2023 5:01 PM To: Wang, Zhi A ; Zhi Wang Cc: intel-gfx@lists.freedesktop.org Subject: RE: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in co

Re: [Intel-gfx] [PATCH 00/15] drm/i915: re-enable -Wunused-but-set-variable

On Wed, 07 Jun 2023, Jani Nikula wrote: > On Wed, 07 Jun 2023, "Hogander, Jouni" wrote: >> On Fri, 2023-05-26 at 19:37 +0300, Jani Nikula wrote: >>> Bring back -Wunused-but-set-variable both in W=1 build as well as >>> locally for CI and development. This already found dubious code. >> >> for the

Re: [Intel-gfx] [PATCH] drm/i915/display/dp: On AUX xfer timeout restart freshly

On Thu, 08 Jun 2023, Arun R Murthy wrote: > As part of restart on AUX xfer timeout, check for busy status and then > start sending the data. Why? Always answer the question "why" in the commit messages. The commit message is completely inadequate for the changes. BR, Jani. > > Signed-off-by:

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: implement internal workqueues (rev2)

On 07/06/2023 09:34, Patchwork wrote: 8< IGT changes Possible regressions * igt@i915_selftest@mock@requests: o shard-apl: PASS -> INCOMPLET

Re: [Intel-gfx] [PATCH v5 0/3] drm/i915: implement internal workqueues

On Tue, 06 Jun 2023, Luca Coelho wrote: > Hi, > > This series implements internal workqueues in the i915 driver in order > to avoid using the system queue. We add one generic workqueue in the > drm_i915_private structure, one specific for wake references and one > in a self-test. > > This is base

Re: [Intel-gfx] [PULL] drm-MISC-fixes

Hey, On 2023-06-08 10:50, Jani Nikula wrote: > On Thu, 08 Jun 2023, Maarten Lankhorst > wrote: >> Oops, forgot to fix topic. :-) > And replied to the wrong message. ;) > > But why was it wrong, not using dim? Gah! I was grabbing the tmp file used for the pull request from dim, but it doesn't r

[Intel-gfx] [PATCHv2] drm/i915/display/dp: On AUX xfer timeout restart freshly

At the begining of the aux transfer a check for aux control busy bit is done. Then as per the spec on aux transfer timeout, need to retry freshly for 3 times with a delay which is taken care by the control register. On each of these 3 trials a check for busy has to be done so as to start freshly.

[Intel-gfx] [RFC] fbcon: Reschedule cursor worker if try lock fails

With the removal of timer implementation for cursor work[1], the cursor delayed work does not get rescheduled if it fails to acquire the console lock. This change pushes the cursor work to the queue if we fail to acquire the lock. This has been found to cause issue during the resume sequence of th

[Intel-gfx] [PATCH][next] drm/i915/mtl: Fix spelling mistake "initate" -> "initiate"

There is a spelling mistake in a drm_dbg_kms message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/display/intel_pmdemand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_pmdemand.c b/drivers/gpu/drm/i915/display/intel_pm

Re: [Intel-gfx] [PATCH][next] drm/i915/mtl: Fix spelling mistake "initate" -> "initiate"

On Thu, 08 Jun 2023, Colin Ian King wrote: > There is a spelling mistake in a drm_dbg_kms message. Fix it. > > Signed-off-by: Colin Ian King Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_pmdemand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

[Intel-gfx] [CI] drm/i915: Fix a VMA UAF for multi-gt platform

From: Nirmoy Das Ensure correct handling of closed VMAs on multi-gt platforms to prevent Use-After-Free. Currently, when GT0 goes idle, closed VMAs that are exclusively added to GT0's closed_vma link (gt->closed_vma) and subsequently freed by i915_vma_parked(), which assumes the entire GPU is idl

[Intel-gfx] [PATCH 1/3] drm/i915: copy-paste the extra warnings from scripts/Makefile.extrawarn

We enable a lot more compiler warnings than the kernel defaults. A lot of them are comparable with the W=1 warnings (and warning disables!) in scripts/Makefile.extrawarn. Copy-paste them with s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it easier to compare. Some of them overlap with the -Wall we also

[Intel-gfx] [PATCH 2/3] drm/i915: fix Makefile sort and indent

Unify the line continuations and indents, and sort the build lists. Signed-off-by: Jani Nikula --- Note: This is easiest to review by applying and looking at 'git show -w' --- drivers/gpu/drm/i915/Makefile | 167 ++ 1 file changed, 88 insertions(+), 79 deletions

[Intel-gfx] [PATCH 3/3] drm/i915: move Makefile display debugfs files next to display

Keep the display build lists together. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index ac62cc54474b..5740e71bdef2 100644 --- a/drivers/gpu/d

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dp: On AUX xfer timeout restart freshly (rev2)

== Series Details == Series: drm/i915/display/dp: On AUX xfer timeout restart freshly (rev2) URL : https://patchwork.freedesktop.org/series/119055/ State : warning == Summary == Error: dim checkpatch failed 2a1723da181b drm/i915/display/dp: On AUX xfer timeout restart freshly -:6: WARNING:TYPO

[Intel-gfx] [PATCH v3 0/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

From: Sui Jingfeng Patch 1,2 and 3 do basic clean up to the vgaarb module. Patch 4 introduce is_boot_device function callback to vga_client_register Sui Jingfeng (4): PCI/VGA: tidy up the code and comment format PCI/VGA: Use unsigned type for the io_state variable PCI/VGA: only deal with V

[Intel-gfx] [PATCH v3 1/4] PCI/VGA: tidy up the code and comment format

From: Sui Jingfeng This patch replaces the leading space with a tab and removes the double blank line, no functional change. Signed-off-by: Sui Jingfeng --- drivers/pci/vgaarb.c | 26 +- include/linux/vgaarb.h | 8 +++- 2 files changed, 16 insertions(+), 18 delet

[Intel-gfx] [PATCH v3 2/4] PCI/VGA: Use unsigned type for the io_state variable

From: Sui Jingfeng The io_state variable in the vga_arb_write() function is declared with unsigned int type, while the vga_str_to_iostate() function takes int * type. To keep them consistent, replace the third argument of vga_str_to_iostate() function with the unsigned int * type. Signed-off-by:

[Intel-gfx] [PATCH v3 3/4] PCI/VGA: only deal with VGA class devices

From: Sui Jingfeng vgaarb only deal with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function with pci_get_class(). Filter the non pci display device out. There no need to process the non display PCI device. Signed-off-by: Sui Jingfeng --- drivers/pci/vgaarb.c | 22 +

[Intel-gfx] [PATCH v3 4/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

From: Sui Jingfeng The vga_is_firmware_default() function is arch-dependent, which doesn't sound right. At least, it also works on the Mips and LoongArch platforms. Tested with the drm/amdgpu and drm/radeon drivers. However, it's difficult to enumerate all arch-driver combinations. I'm wrong if t

Re: [Intel-gfx] [PATCH v2 02/19] drm/i915/dsb: Use non-locked register access

On Tue, 06 Jun 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Avoid the locking overhead for DSB registers. We don't need the locks > and intel_dsb_commit() in particular needs to be called from the > vblank evade critical section and thus needs to be fast. Mmmh, I always find it slightly

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/dp: On AUX xfer timeout restart freshly (rev2)

== Series Details == Series: drm/i915/display/dp: On AUX xfer timeout restart freshly (rev2) URL : https://patchwork.freedesktop.org/series/119055/ State : success == Summary == CI Bug Log - changes from CI_DRM_13249 -> Patchwork_119055v2 S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fbcon: Reschedule cursor worker if try lock fails

== Series Details == Series: fbcon: Reschedule cursor worker if try lock fails URL : https://patchwork.freedesktop.org/series/119060/ State : warning == Summary == Error: dim checkpatch failed 1a20091de4c7 fbcon: Reschedule cursor worker if try lock fails -:33: WARNING:COMMIT_LOG_LONG_LINE: Po

[Intel-gfx] ✓ Fi.CI.BAT: success for fbcon: Reschedule cursor worker if try lock fails

== Series Details == Series: fbcon: Reschedule cursor worker if try lock fails URL : https://patchwork.freedesktop.org/series/119060/ State : success == Summary == CI Bug Log - changes from CI_DRM_13249 -> Patchwork_119060v1 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Fix spelling mistake "initate" -> "initiate"

== Series Details == Series: drm/i915/mtl: Fix spelling mistake "initate" -> "initiate" URL : https://patchwork.freedesktop.org/series/119063/ State : success == Summary == CI Bug Log - changes from CI_DRM_13249 -> Patchwork_119063v1 Summar

Re: [Intel-gfx] [PATCH v2] x86/mm: Fix PAT bit missing from page protection modify mask

On Thursday, 8 June 2023 00:47:36 CEST Edgecombe, Rick P wrote: > On Wed, 2023-06-07 at 23:33 +0200, Janusz Krzysztofik wrote: > > > So since _PAGE_PSE is actually the same value as _PAGE_PAT, you > > > don't > > > actually need to have _PAGE_PSE in _HPAGE_CHG_MASK in order to get > > > functional

[Intel-gfx] [PATCH v6 3/3] drm/i915/selftests: add local workqueue for SW fence selftest

From: Luca Coelho Instead of using a global workqueue for the SW fence selftest, allocate a separate one temporarily only while running the test. Cc: Tetsuo Handa Cc: Jani Nikula Cc: Ville Syrjälä Reviewed-by: Tvrtko Ursulin Signed-off-by: Luca Coelho Signed-off-by: Jani Nikula --- driver

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915/selftests: add local workqueue for SW fence selftest

On 2023/06/08 22:35, Jani Nikula wrote: > From: Luca Coelho > > Instead of using a global workqueue for the SW fence selftest, > allocate a separate one temporarily only while running the test. > > Cc: Tetsuo Handa > Cc: Jani Nikula > Cc: Ville Syrjälä > Reviewed-by: Tvrtko Ursulin > Signed-

[Intel-gfx] [PATCH v6 0/3] drm/i915: implement internal workqueues

This is v6 of [1], creating i915->unordered_wq also for mock devices. BR, Jani. [1] https://patchwork.freedesktop.org/series/118947/ Luca Coelho (3): drm/i915: use pointer to i915 instead of rpm in wakeref drm/i915: add a dedicated workqueue inside drm_i915_private drm/i915/selftests: add

[Intel-gfx] [PATCH v6 1/3] drm/i915: use pointer to i915 instead of rpm in wakeref

From: Luca Coelho Currently a pointer to an intel_runtime_pm structure is stored in the wake reference structures so the runtime data can be accessed. We can save the entire device information (drm_i915_private) instead, since we'll need to reference the new workqueue we'll add in subsequent pat

[Intel-gfx] [PATCH v6 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

From: Luca Coelho In order to avoid flush_scheduled_work() usage, add a dedicated workqueue in the drm_i915_private structure. In this way, we don't need to use the system queue anymore. This change is mostly mechanical and based on Tetsuo's original patch[1]. v6 by Jani: - Also create unorder

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix a VMA UAF for multi-gt platform (rev6)

== Series Details == Series: drm/i915: Fix a VMA UAF for multi-gt platform (rev6) URL : https://patchwork.freedesktop.org/series/118887/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13250 -> Patchwork_118887v6 Summary

Re: [Intel-gfx] [PATCH v6 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

On 08/06/2023 14:35, Jani Nikula wrote: From: Luca Coelho In order to avoid flush_scheduled_work() usage, add a dedicated workqueue in the drm_i915_private structure. In this way, we don't need to use the system queue anymore. This change is mostly mechanical and based on Tetsuo's original

Re: [Intel-gfx] [PATCH v6 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

On 2023/06/08 22:35, Jani Nikula wrote: > From: Luca Coelho > > In order to avoid flush_scheduled_work() usage, add a dedicated > workqueue in the drm_i915_private structure. In this way, we don't > need to use the system queue anymore. > > This change is mostly mechanical and based on Tetsuo's

Re: [Intel-gfx] [RFC 02/10] drm: Update file owner during use

On 21/04/2023 13:13, Emil Velikov wrote: Greetings everyone, Above all - hell yeah. Thank you Tvrtko, this has been annoying the hell out of me for ages. Yay! On Tue, 14 Mar 2023 at 14:19, Tvrtko Ursulin wrote: From: Tvrtko Ursulin With the typical model where the display server opend

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: copy-paste the extra warnings from scripts/Makefile.extrawarn

== Series Details == Series: series starting with [1/3] drm/i915: copy-paste the extra warnings from scripts/Makefile.extrawarn URL : https://patchwork.freedesktop.org/series/119067/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won'

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: copy-paste the extra warnings from scripts/Makefile.extrawarn

== Series Details == Series: series starting with [1/3] drm/i915: copy-paste the extra warnings from scripts/Makefile.extrawarn URL : https://patchwork.freedesktop.org/series/119067/ State : success == Summary == CI Bug Log - changes from CI_DRM_13250 -> Patchwork_119067v1 ===

[Intel-gfx] [PATCH 1/5] drm/i915: Track buffer objects belonging to clients

From: Tvrtko Ursulin In order to show per client memory usage lets start tracking which objects belong to which clients. We start with objects explicitly created by object creation UAPI and track it on a new per client lists, protected by a new per client lock. In order for delayed destruction (

[Intel-gfx] [PATCH 3/5] drm/i915: Track page table backing store usage

From: Tvrtko Ursulin Account page table backing store against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gtt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/int

[Intel-gfx] [PATCH v2 0/5] fdinfo memory stats

From: Tvrtko Ursulin Second try, this time actually per client! :) I added tracking of most classes of objects which contribute to clients memory footprint and accouting along the similar lines as in Rob's msm code. Then printing it out to fdinfo using the drm helper Rob added. Example fdinfo w

[Intel-gfx] [PATCH 4/5] drm/i915: Account ring buffer and context state storage

From: Tvrtko Ursulin Account ring buffers and logical context space against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 ++ drivers/gpu/drm/i915/i915_drm_client.c | 10 ++ drivers/gpu/drm/i915/i915_dr

[Intel-gfx] [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories. Obj

[Intel-gfx] [PATCH 2/5] drm/i915: Record which clients own a VM

From: Tvrtko Ursulin To enable accounting of indirect client memory usage (such as page tables) in the following patch, lets start recording the creator of each PPGTT. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 --- drivers/gpu/drm/i915/gem

[Intel-gfx] [PATCH 0/4] drm/i915: further device info cleanups

Building on Matt's display info separation, we can finally trivially make device info a const pointer to rodata. BR, Jani. Cc: Matt Roper Cc: Lucas De Marchi Jani Nikula (4): drm/i915: separate display info printing from the rest drm/i915: fix display info usage drm/i915: move display d

[Intel-gfx] [PATCH 1/4] drm/i915: separate display info printing from the rest

Add new function intel_display_device_info_print() and print the display device info there instead of intel_device_info_print(). This also fixes the display runtime info printing to use the actual runtime info instead of the static defaults. Cc: Matt Roper Cc: Lucas De Marchi Signed-off-by: Jani

[Intel-gfx] [PATCH 2/4] drm/i915: fix display info usage

Prefer DISPLAY_INFO() over INTEL_INFO()->display. Cc: Matt Roper Cc: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 3/4] drm/i915: move display device and runtime info to struct intel_display

Continue moving all things display further into display files and structures. Cc: Matt Roper Cc: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_core.h | 9 + drivers/gpu/drm/i915/i915_drv.h | 5 ++--- drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH 4/4] drm/i915: make device info a const pointer to rodata

Finally we can get rid of the pseudo-const write-once device info, and convert it into a const pointer to device info in rodata. Cc: Matt Roper Cc: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- drivers/gpu/drm/i915/intel_device_info.c | 17 +

[Intel-gfx] [PULL] drm-intel-gt-next

Hi Dave, Daniel, Here goes the final pull request for 6.5. A few improvements to robustness of dealing with GuC communication issues, compute applications, small BAR systems perf/OA monitoring. Then a little bit more of Meteorlake enablement which this time round includes the HuC loading code, a

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mst: Make sure all resources are freed for MST topology manager before destroy

== Series Details == Series: drm/i915/mst: Make sure all resources are freed for MST topology manager before destroy URL : https://patchwork.freedesktop.org/series/119010/ State : success == Summary == CI Bug Log - changes from CI_DRM_13245_full -> Patchwork_119010v1_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for PCI/VGA: introduce is_boot_device function callback to vga_client_register

== Series Details == Series: PCI/VGA: introduce is_boot_device function callback to vga_client_register URL : https://patchwork.freedesktop.org/series/119068/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13250 -> Patchwork_119068v1 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Include of display limits doesn't need 'display/'

== Series Details == Series: drm/i915/display: Include of display limits doesn't need 'display/' URL : https://patchwork.freedesktop.org/series/119018/ State : success == Summary == CI Bug Log - changes from CI_DRM_13245_full -> Patchwork_119018v1_full =

Re: [Intel-gfx] [v3] drm/i915/mtl: Add new vswing table for C20 phy to support DP 1.4

> -Original Message- > From: Lee, Shawn C > Sent: Wednesday, June 7, 2023 11:02 PM > To: intel-gfx@lists.freedesktop.org > Cc: Lee, Shawn C ; Kahola, Mika > ; Taylor, Clinton A ; > Sripada, Radhakrishna ; Shankar, Uma > > Subject: [v3] drm/i915/mtl: Add new vswing table for C20 phy to

[Intel-gfx] ✓ Fi.CI.IGT: success for x86/mm: Fix PAT bit missing from page protection modify mask (rev2)

== Series Details == Series: x86/mm: Fix PAT bit missing from page protection modify mask (rev2) URL : https://patchwork.freedesktop.org/series/116883/ State : success == Summary == CI Bug Log - changes from CI_DRM_13245_full -> Patchwork_116883v2_full =

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Record which clients own a VM

Hi Tvrtko, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Tvrtko-Ursulin/drm-i915-Track-buffer-objects-belonging-to-clients/20230608-225344 base: git://anongit.freedesktop.org/drm/drm-tip

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement internal workqueues (rev4)

== Series Details == Series: drm/i915: implement internal workqueues (rev4) URL : https://patchwork.freedesktop.org/series/118947/ State : warning == Summary == Error: dim checkpatch failed 4fef60b7a41e drm/i915: use pointer to i915 instead of rpm in wakeref a5ce4ea23a6e drm/i915: add a dedica

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: implement internal workqueues (rev4)

== Series Details == Series: drm/i915: implement internal workqueues (rev4) URL : https://patchwork.freedesktop.org/series/118947/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v1] drm/i915/gsc: take a wakeref for the proxy-init-completion check

Ensure intel_gsc_uc_fw_init_done and intel_gsc_uc_fw_proxy_init takes a wakeref before reading GSC Shim registers. NOTE: another patch in review also adds a call from selftest to this same function. (https://patchwork.freedesktop.org/series/117713/) which is why i am adding the wakeref inside the

Re: [Intel-gfx] [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

See my comments below. > -Original Message- > From: Alan Previn > Sent: May 30, 2023 1:01 PM > To: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Alan Previn > > Subject: [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before > selftests > > On MTL, i

Re: [Intel-gfx] [PATCH v1] drm/i915/gsc: take a wakeref for the proxy-init-completion check

On 6/8/2023 11:04 AM, Alan Previn wrote: Ensure intel_gsc_uc_fw_init_done and intel_gsc_uc_fw_proxy_init takes a wakeref before reading GSC Shim registers. NOTE: another patch in review also adds a call from selftest to this same function. (https://patchwork.freedesktop.org/series/117713/) wh

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: implement internal workqueues (rev4)

== Series Details == Series: drm/i915: implement internal workqueues (rev4) URL : https://patchwork.freedesktop.org/series/118947/ State : success == Summary == CI Bug Log - changes from CI_DRM_13252 -> Patchwork_118947v4 Summary ---

Re: [Intel-gfx] [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

On Thu, 2023-06-08 at 18:14 +, Dong, Zhanjun wrote: > See my comments below. > > > -Original Message- > > From: Alan Previn alan:snip > > +static int > > +__wait_gsc_proxy_completed(struct drm_i915_private *i915, > > + unsigned long timeout_ms) > > +{ > > + boo

[Intel-gfx] ✗ Fi.CI.BUILD: failure for fdinfo memory stats

== Series Details == Series: fdinfo memory stats URL : https://patchwork.freedesktop.org/series/119082/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M] drivers/gpu/drm/i915/gem/i915_gem_context.o In fil

Re: [Intel-gfx] [PATCH] drm/i915/gsc: Fix error code in intel_gsc_uc_heci_cmd_submit_nonpriv()

On Thu, 2023-06-08 at 11:37 +0300, Dan Carpenter wrote: > On Wed, Jun 07, 2023 at 06:44:54PM +, Teres Alexis, Alan Previn wrote: > > On Tue, 2023-06-06 at 21:32 +0300, Dan Carpenter wrote: > > > On Tue, Jun 06, 2023 at 06:07:19PM +, Teres Alexis, Alan Previn wrote: > > > > That was my bad,

Re: [Intel-gfx] [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

> -Original Message- > From: Teres Alexis, Alan Previn > Sent: June 8, 2023 2:31 PM > To: Dong, Zhanjun ; intel- > g...@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org > Subject: Re: [v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes > before selftests > > On Thu, 2

Re: [Intel-gfx] [PATCH v3 1/4] PCI/VGA: tidy up the code and comment format

Capitalize subject to match ("Tidy ...") On Thu, Jun 08, 2023 at 07:43:19PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > This patch replaces the leading space with a tab and removes the double > blank line, no functional change. Can you move this to the end of the series? The functional

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: further device info cleanups

== Series Details == Series: drm/i915: further device info cleanups URL : https://patchwork.freedesktop.org/series/119086/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: further device info cleanups

== Series Details == Series: drm/i915: further device info cleanups URL : https://patchwork.freedesktop.org/series/119086/ State : warning == Summary == Error: dim checkpatch failed 4151efbd9a55 drm/i915: separate display info printing from the rest -:36: CHECK:MACRO_ARG_PRECEDENCE: Macro argu

Re: [Intel-gfx] [PATCH v3 3/4] PCI/VGA: only deal with VGA class devices

Start with verb and capitalize to match ("Deal only with ...") On Thu, Jun 08, 2023 at 07:43:21PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > vgaarb only deal with the VGA devcie(pdev->class == 0x0300), so replace the > pci_get_subsys() function with pci_get_class(). Filter the non pci d

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: further device info cleanups

== Series Details == Series: drm/i915: further device info cleanups URL : https://patchwork.freedesktop.org/series/119086/ State : success == Summary == CI Bug Log - changes from CI_DRM_13253 -> Patchwork_119086v1 Summary --- **SUCCE

Re: [Intel-gfx] [PATCH v3 4/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

On Thu, Jun 08, 2023 at 07:43:22PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > The vga_is_firmware_default() function is arch-dependent, which doesn't > sound right. At least, it also works on the Mips and LoongArch platforms. > Tested with the drm/amdgpu and drm/radeon drivers. However,

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: Introduce device info port_mask

On Fri, Jun 02, 2023 at 05:11:45PM +0300, Jani Nikula wrote: > On Wed, 31 May 2023, Ville Syrjala wrote: > > @@ -556,6 +590,16 @@ static const struct intel_display_device_info > > gen11_display = { > > > > static const struct intel_display_device_info tgl_display = { > > XE_D_DISPLAY, > >

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915: Init DDI outputs based on port_mask on skl+

On Fri, Jun 02, 2023 at 05:41:50PM +0300, Jani Nikula wrote: > On Wed, 31 May 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Instead of listing every platform's possible DDI outputs > > in intel_setup_outputs() just loop over the new port_mask > > to achieve the same thing. > > For p

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gsc: take a wakeref for the proxy-init-completion check

== Series Details == Series: drm/i915/gsc: take a wakeref for the proxy-init-completion check URL : https://patchwork.freedesktop.org/series/119092/ State : success == Summary == CI Bug Log - changes from CI_DRM_13253 -> Patchwork_119092v1

Re: [Intel-gfx] [PATCH v2 7/7] drm/i915: Convert HSW/BDW to use port_mask for DDI probe

On Fri, Jun 02, 2023 at 05:51:19PM +0300, Jani Nikula wrote: > On Wed, 31 May 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Make HSW/BDW use port_mask for output probing as well. > > To achieve that the strap checks are moved into > > intel_ddi_init() itself. Or should we move them t

[Intel-gfx] [PATCH v2 00/13] drm/i915/dsi: ICL+ DSI modeset sequence fixes

From: Ville Syrjälä Rebase of the ICL+ DSI modeset sequence stuff. Ville Syrjälä (13): drm/i915/dsi: Do panel power on + reset deassert earlier on icl+ drm/i915/dsi: Do display on sequence later on icl+ drm/i915/dsi: Print the VBT MIPI sequence delay duration drm/i915/dsi: Split icl+ D-P

[Intel-gfx] [PATCH v2 01/13] drm/i915/dsi: Do panel power on + reset deassert earlier on icl+

From: Ville Syrjälä Looks like we're trying to talk to the DSI panel even before turning it on, on icl+. Bspec doesn't actually specify when these should be done, but certainly we need to turn the panel on at least before talking to it. So let's move the power on + reset deassert steps to be the

[Intel-gfx] [PATCH v2 02/13] drm/i915/dsi: Do display on sequence later on icl+

From: Ville Syrjälä Doing the init OTP and display on DSI sequences back to back doesn't really make any sense (a single sequence would suffice then). Move the display on sequence to be done just before backlight on, which is also what Windows does. Reviewed-by: Jani Nikula Signed-off-by: Ville

[Intel-gfx] [PATCH v2 03/13] drm/i915/dsi: Print the VBT MIPI sequence delay duration

From: Ville Syrjälä Help out debugging things by printing out how long the VBT delay sequence is supposed to wait. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[Intel-gfx] [PATCH v2 05/13] drm/i915/dsi: Gate DSI clocks earlier

From: Ville Syrjälä The clock gating step is in the wrong spot compared to the TGL+ bspec sequence. Move it the right place. Windows also seems to use the TGL+ order here always. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 5 ++--- 1 file

[Intel-gfx] [PATCH v2 04/13] drm/i915/dsi: Split icl+ D-PHY vs. DSI timing steps

From: Ville Syrjälä The programming of the DPHY vs. DSI _TIMING registers are two separate steps in the TGL+ bspec sequence, with some other stuff in between. Implement the same split. Windows also seems follow the bspec TGL+ sequence, even on ICL/JSL. Reviewed-by: Jani Nikula Signed-off-by: Vi

[Intel-gfx] [PATCH v2 06/13] drm/i915/dsi: Respect power cycle delay on icl+

From: Ville Syrjälä Handle the DSI panel power cycle delay on icl+. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 6 ++ drivers/gpu/drm/i915/display/intel_dsi.c | 13 + drivers/gpu/drm/i915/display/intel_dsi.h | 1 + dri

  1   2   >