Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-04-28 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Friday, April 28, 2023 2:21 PM > > On 2023/4/28 02:32, Alex Williamson wrote: > > On Thu, 27 Apr 2023 06:59:17 + > > "Liu, Yi L" wrote: > > > >>> From: Tian, Kevin > >>> Sent: Thursday, April 27, 2023 2:39 PM > >>> > From: Liu, Yi L > Sent: Wednesday, Ap

Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-04-28 Thread Yi Liu
On 2023/4/28 15:00, Tian, Kevin wrote: From: Liu, Yi L Sent: Friday, April 28, 2023 2:21 PM On 2023/4/28 02:32, Alex Williamson wrote: On Thu, 27 Apr 2023 06:59:17 + "Liu, Yi L" wrote: From: Tian, Kevin Sent: Thursday, April 27, 2023 2:39 PM From: Liu, Yi L Sent: Wednesday, April 26

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: use pat_index instead of cache_level

2023-04-28 Thread Patchwork
== Series Details == Series: drm/i915: use pat_index instead of cache_level URL : https://patchwork.freedesktop.org/series/117082/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13071_full -> Patchwork_117082v1_full Summary

[Intel-gfx] [PULL] gvt-next-fixes

2023-04-28 Thread Zhenyu Wang
Hi, Here's one single change for gvt to use idr based dmabuf object reference instead of old adhoc code. We've verified no regression for internal test. Thanks. -- The following changes since commit d944eafed618a8507270b324ad9d5405bb7f0b3e: drm/i915: Check pipe source size when using skl+ sca

[Intel-gfx] [RFC v2 0/4] Expose RPS thresholds in sysfs

2023-04-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin >From patch 4: User feedback indicates significant performance gains are possible in specific games with non default RPS up/down thresholds. Expose these tunables via sysfs which will allow users to achieve best performance when running games and best power

[Intel-gfx] [RFC 1/4] drm/i915: Move setting of rps thresholds to init

2023-04-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Since 36d516be867c ("drm/i915/gt: Switch to manual evaluation of RPS") thresholds are invariant so lets move their setting to init time. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_rps.c | 27 --- 1 file changed, 16 insertions(+)

[Intel-gfx] [RFC 2/4] drm/i915: Record default rps threshold values

2023-04-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Record the default values as preparation for exposing the sysfs controls. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 +++ drivers/gpu/drm/i915/gt/intel_rps.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i91

[Intel-gfx] [RFC 3/4] drm/i915: Add helpers for managing rps thresholds

2023-04-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In preparation for exposing via sysfs add helpers for managing rps thresholds. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_rps.c | 36 + drivers/gpu/drm/i915/gt/intel_rps.h | 4 2 files changed, 40 insertions(+) diff -

[Intel-gfx] [RFC 4/4] drm/i915: Expose RPS thresholds in sysfs

2023-04-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin User feedback indicates significant performance gains are possible in specific games with non default RPS up/down thresholds. Expose these tunables via sysfs which will allow users to achieve best performance when running games and best power efficiency elsewhere. Note this

Re: [Intel-gfx] [PATCH v3 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-28 Thread Intel
On 4/28/23 07:47, fei.y...@intel.com wrote: From: Fei Yang The first three patches in this series are taken from https://patchwork.freedesktop.org/series/116868/ These patches are included here because the last patch has dependency on the pat_index refactor. This series is focusing on uAPI c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Expose RPS thresholds in sysfs (rev2)

2023-04-28 Thread Patchwork
== Series Details == Series: Expose RPS thresholds in sysfs (rev2) URL : https://patchwork.freedesktop.org/series/117054/ State : warning == Summary == Error: dim checkpatch failed 561c9fe0d33c drm/i915: Move setting of rps thresholds to init -:6: ERROR:GIT_COMMIT_ID: Please use git commit des

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Expose RPS thresholds in sysfs (rev2)

2023-04-28 Thread Patchwork
== Series Details == Series: Expose RPS thresholds in sysfs (rev2) URL : https://patchwork.freedesktop.org/series/117054/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [RFC 4/4] drm/i915: Expose RPS thresholds in sysfs

2023-04-28 Thread Tvrtko Ursulin
On 28/04/2023 09:14, Tvrtko Ursulin wrote: From: Tvrtko Ursulin User feedback indicates significant performance gains are possible in specific games with non default RPS up/down thresholds. Expose these tunables via sysfs which will allow users to achieve best performance when running games

Re: [Intel-gfx] [PATCH v8 1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-04-28 Thread Andi Shyti
Hi Andrzej, On Wed, Apr 26, 2023 at 11:28:48PM +0200, Andrzej Hajda wrote: > From: Jonathan Cavitt > > Convert the igt_mock_ppgtt_huge_fill and igt_mock_ppgtt_64K mock selftests > into live selftests as their requirements have recently become > platform-dependent. Additionally, apply necessary p

[Intel-gfx] ✗ Fi.CI.BAT: failure for Expose RPS thresholds in sysfs (rev2)

2023-04-28 Thread Patchwork
== Series Details == Series: Expose RPS thresholds in sysfs (rev2) URL : https://patchwork.freedesktop.org/series/117054/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13071 -> Patchwork_117054v2 Summary --- **FAILUR

Re: [Intel-gfx] [PATCH v8 7/7] drm/i915: Track gt pm wakerefs

2023-04-28 Thread Andi Shyti
Hi Andrzej, On Tue, Apr 25, 2023 at 12:05:44AM +0200, Andrzej Hajda wrote: > Track every intel_gt_pm_get() until its corresponding release in > intel_gt_pm_put() by returning a cookie to the caller for acquire that > must be passed by on released. When there is an imbalance, we can see who > eithe

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Allow user to set cache at BO creation (rev3)

2023-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Allow user to set cache at BO creation (rev3) URL : https://patchwork.freedesktop.org/series/116870/ State : success == Summary == CI Bug Log - changes from CI_DRM_13071_full -> Patchwork_116870v3_full

Re: [Intel-gfx] [PATCH 01/13] drm/i915/mtl: C20 PLL programming

2023-04-28 Thread Andi Shyti
Hi Mika, > +static void intel_c20_pll_program(struct drm_i915_private *i915, > + const struct intel_crtc_state *crtc_state, > + struct intel_encoder *encoder) > +{ > + const struct intel_c20pll_state *pll_state = > &crtc_state->cx0pl

Re: [Intel-gfx] [PATCH v8 2/2] drm/i915: Use correct huge page manager for MTL

2023-04-28 Thread Andi Shyti
Hi Andrzej, > MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. > This is because MTL reports as not supporting 64K pages, or more > accurately, the system that reports whether a platform has 64K pages > reports false for MTL. This is only half correct, as the 64K page support >

Re: [Intel-gfx] [PATCH 01/13] drm/i915/mtl: C20 PLL programming

2023-04-28 Thread Kahola, Mika
> -Original Message- > From: Andi Shyti > Sent: Friday, April 28, 2023 12:07 PM > To: Kahola, Mika > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 01/13] drm/i915/mtl: C20 PLL programming > > Hi Mika, > > > +static void intel_c20_pll_program(struct drm_i915_priva

Re: [Intel-gfx] [PATCH 02/13] drm/i915/mtl: C20 HW readout

2023-04-28 Thread Andi Shyti
Hi Mika, [...] > +static int intel_c20_phy_check_hdmi_link_rate(int clock) > +{ > + const struct intel_c20pll_state * const *tables = mtl_c20_hdmi_tables; > + int i; > + > + for (i = 0; tables[i]; i++) { > + if (clock == tables[i]->link_bit_rate) > + re

Re: [Intel-gfx] [PATCH 03/13] drm/i915/mtl: Dump C20 pll hw state

2023-04-28 Thread Andi Shyti
Hi Mika, > + > + if (intel_c20_use_mplla(hw_state->clock)) { > + for (i = 0; i < ARRAY_SIZE(hw_state->mplla); i++) > + drm_dbg_kms(&i915->drm, "mplla[%d] = 0x%.4x\n", i, > hw_state->mplla[i]); > + } else { > + for (i = 0; i < ARRAY_SIZE(hw_state

Re: [Intel-gfx] [PATCH 07/13] drm/i915/mtl: Enabling/disabling sequence Thunderbolt pll

2023-04-28 Thread Andi Shyti
Hi Mika, On Thu, Apr 20, 2023 at 03:40:44PM +0300, Mika Kahola wrote: > Enabling and disabling sequence for Thunderbolt PLL. if you will resend it: /Enabling/Enable/ Andi

Re: [Intel-gfx] [PATCH 1/6] drm/uapi: Document CTM matrix better

2023-04-28 Thread Simon Ser
Acked-by: Simon Ser

Re: [Intel-gfx] [PATCH v4 0/9] Enhance vfio PCI hot reset for vfio cdev device

2023-04-28 Thread Jiang, Yanting
> VFIO_DEVICE_PCI_HOT_RESET requires user to pass an array of group fds to > prove that it owns all devices affected by resetting the calling device. > While for > cdev devices, user can use an iommufd-based ownership checking model and > invoke VFIO_DEVICE_PCI_HOT_RESET with a zero-length fd arra

Re: [Intel-gfx] [PATCH v10 00/22] Add vfio_device cdev for iommufd support

2023-04-28 Thread Jiang, Yanting
> Subject: [PATCH v10 00/22] Add vfio_device cdev for iommufd support > > Existing VFIO provides group-centric user APIs for userspace. Userspace opens > the /dev/vfio/$group_id first before getting device fd and hence getting > access > to device. This is not the desired model for iommufd. Per t

Re: [Intel-gfx] [PATCH v2 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-28 Thread Tvrtko Ursulin
On 27/04/2023 17:07, Yang, Fei wrote: > On 26/04/2023 16:41, Yang, Fei wrote: >>> On 26/04/2023 07:24, fei.y...@intel.com wrote: From: Fei Yang The first three patches in this series are taken from https://patchwork.freedesktop.org/series/116868/ These patches a

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915: Allow user to set cache at BO creation

2023-04-28 Thread Tvrtko Ursulin
On 28/04/2023 06:47, fei.y...@intel.com wrote: From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at o

[Intel-gfx] [PATCH v2 00/13] drm/i915/mtl: Add support for C20 phy

2023-04-28 Thread Mika Kahola
Add support for C20 phy for Type-C connections. C20 phy differs from C10 and hence we need to separately handle this case. v2: Fixes for C20 pll programming and hw readout Signed-off-by: Mika Kahola Anusha Srivatsa (1): drm/i915/mtl: Pin assignment for TypeC Gustavo Sousa (1): drm/i915/mtl

[Intel-gfx] [PATCH v2 01/13] drm/i915/mtl: C20 PLL programming

2023-04-28 Thread Mika Kahola
C20 phy PLL programming sequence for DP, DP2.0, HDMI2.x non-FRL and HDMI2.x FRL. This enables C20 MPLLA and MPLLB programming sequence. add 4 lane support for c20. v2: Add 6.48Gbps and 6.75Gbps modes for eDP (RK) Fix lane check (RK) Fix multiline commenting (Arun) use usleep_range() in

[Intel-gfx] [PATCH v2 02/13] drm/i915/mtl: C20 HW readout

2023-04-28 Thread Mika Kahola
Create a table for C20 DP1.4, DP2.0 and HDMI2.1 rates. The PLL settings are based on table, not for algorithmic alternative. For DP 1.4 only MPLLB is in use. Once register settings are done, we read back C20 HW state. BSpec: 64568 v2: Updated pll tables (RK) MPLLB selection fix (RK) Signed-

[Intel-gfx] [PATCH v2 04/13] drm/i915/mtl: C20 port clock calculation

2023-04-28 Thread Mika Kahola
Calculate port clock with C20 phy. BSpec: 64568 Reviewed-by: Radhakrishna Sripada Reviewed-by: Arun R Murthy Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 45 +++ drivers/gpu/drm/i915/display/intel_cx0_phy.h | 2 + .../gpu/drm/i915/display/in

[Intel-gfx] [PATCH v2 03/13] drm/i915/mtl: Dump C20 pll hw state

2023-04-28 Thread Mika Kahola
As we already do with C10 chip, let's dump the pll hw state for C20 as well. Reviewed-by: Radhakrishna Sripada Reviewed-by: Arun R Murthy Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 20 drivers/gpu/drm/i915/display/intel_cx0_phy.h | 2 ++

[Intel-gfx] [PATCH v2 06/13] drm/i915/mtl: For DP2.0 10G and 20G rates use MPLLA

2023-04-28 Thread Mika Kahola
Use MPLLA for DP2.0 rates 10G and 20G, when ssc is enabled. v2: Fix typo in commit message (Animesh) Reviewed-by: Radhakrishna Sripada Reviewed-by: Arun R Murthy Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletio

[Intel-gfx] [PATCH v2 05/13] drm/i915/mtl: Add voltage swing sequence for C20

2023-04-28 Thread Mika Kahola
DP1.4 and DP20 voltage swing sequence for C20 phy. Bspec: 65449, 67636, 67610 Reviewed-by: Arun R Murthy Signed-off-by: Mika Kahola Signed-off-by: Clint Taylor Signed-off-by: Radhakrishna Sripada --- .../gpu/drm/i915/display/intel_cx0_phy_regs.h | 4 ++ .../drm/i915/display/intel_ddi_buf_tr

[Intel-gfx] [PATCH v2 10/13] drm/i915/mtl: Power up TCSS

2023-04-28 Thread Mika Kahola
Add register writes to enable powering up Type-C subsystem i.e. TCSS. For MeteorLake we need to request TCSS to power up and check the TCSS power state after 500 us. In addition, for PICA we need to set/clear the Type-C PHY ownnership bit when Type-C device is connected/disconnected. Reviewed-by:

[Intel-gfx] [PATCH v2 07/13] drm/i915/mtl: Enabling/disabling sequence Thunderbolt pll

2023-04-28 Thread Mika Kahola
Enabling and disabling sequence for Thunderbolt PLL. Bspec: 64568 v2: Use intel_de_wait_for_register() (RK) Reviewed-by: Radhakrishna Sripada Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 135 ++- drivers/gpu/drm/i915/display/intel_cx0_phy.h |

[Intel-gfx] [PATCH v2 11/13] drm/i915/mtl: TypeC HPD live status query

2023-04-28 Thread Mika Kahola
From: Imre Deak The HPD live status for MTL has to be read from different set of registers. MTL deserves a new function for this purpose and cannot reuse the existing HPD live status detection Reviewed-by: Matt Atwood Signed-off-by: Anusha Srivatsa Signed-off-by: Imre Deak Signed-off-by: Mik

[Intel-gfx] [PATCH v2 08/13] drm/i915/mtl: Readout Thunderbolt HW state

2023-04-28 Thread Mika Kahola
Readout hw state for Thunderbolt. Reviewed-by: Radhakrishna Sripada Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 27 drivers/gpu/drm/i915/display/intel_cx0_phy.h | 2 +- drivers/gpu/drm/i915/display/intel_ddi.c | 5 +++- 3 files change

[Intel-gfx] [PATCH v2 13/13] drm/i915/mtl: Enable TC ports

2023-04-28 Thread Mika Kahola
Finally, we can enable TC ports for Meteorlake. Reviewed-by: Clint Taylor Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_display.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/disp

[Intel-gfx] [PATCH v2 12/13] drm/i915/mtl: Pin assignment for TypeC

2023-04-28 Thread Mika Kahola
From: Anusha Srivatsa Unlike previous platforms that used PORT_TX_DFLEXDPSP for max_lane calculation, MTL uses only PORT_TX_DFLEXPA1 from which the max_lanes has to be calculated. Bspec: 50235, 65380 Reviewed-by: Matt Atwood Signed-off-by: Anusha Srivatsa Signed-off-by: Jose Roberto de Souza

[Intel-gfx] [PATCH v2 09/13] drm/i915/mtl: Define mask for DDI AUX interrupts

2023-04-28 Thread Mika Kahola
From: Gustavo Sousa Xe_LPD+ defines interrupt bits for only DDI ports in the DE Port Interrupt registers. The bits for Type-C ports are defined in the PICA interrupt registers. BSpec: 50064 Reviewed-by: Radhakrishna Sripada Signed-off-by: Gustavo Sousa Signed-off-by: Mika Kahola --- drivers

Re: [Intel-gfx] [RFC PATCH] x86/mm: Fix PAT bit missing from page protection modify mask

2023-04-28 Thread Andi Shyti
Hi Janusz, On Mon, Apr 24, 2023 at 02:35:24PM +0200, Janusz Krzysztofik wrote: > Visible glitches have been observed when running graphics applications on > Linux under Xen hypervisor. Those observations have been confirmed with > failures from kms_pwrite_crc Intel GPU test that verifies data coh

Re: [Intel-gfx] [PATCH 05/13] drm/i915/psr: Bring back HSW/BDW PSR AUX CH registers/setup

2023-04-28 Thread Hogander, Jouni
Hello, Please check my inline comments below. On Fri, 2023-04-21 at 15:02 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Reintroduce the special PSR AUX CH setup for hsw/bdw. Not all > of it was even removed (BDW AUX data registers were left behind). > Update the code to use REG_BIT() &

Re: [Intel-gfx] [PATCH 08/13] drm/i915/psr: Implement WaPsrDPAMaskVBlankInSRD:hsw

2023-04-28 Thread Hogander, Jouni
On Fri, 2023-04-21 at 15:03 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Implement WaPsrDPAMaskVBlankInSRD:hsw, which makes the hardware > generate the extra vblank between link training and first frame > being transmitted. This is the same thing that's controlled by > TRANS_CHICKEN[21]

Re: [Intel-gfx] [PATCH 08/13] drm/i915/psr: Implement WaPsrDPAMaskVBlankInSRD:hsw

2023-04-28 Thread Ville Syrjälä
On Fri, Apr 28, 2023 at 10:36:17AM +, Hogander, Jouni wrote: > On Fri, 2023-04-21 at 15:03 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Implement WaPsrDPAMaskVBlankInSRD:hsw, which makes the hardware > > generate the extra vblank between link training and first frame > > being

Re: [Intel-gfx] [PATCH 05/13] drm/i915/psr: Bring back HSW/BDW PSR AUX CH registers/setup

2023-04-28 Thread Ville Syrjälä
On Fri, Apr 28, 2023 at 10:18:34AM +, Hogander, Jouni wrote: > Hello, > > Please check my inline comments below. > > On Fri, 2023-04-21 at 15:02 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Reintroduce the special PSR AUX CH setup for hsw/bdw. Not all > > of it was even remov

Re: [Intel-gfx] [PATCH v2] drm/i915/dsi: Use unconditional msleep() instead of intel_dsi_msleep()

2023-04-28 Thread Ville Syrjälä
On Tue, Apr 25, 2023 at 09:44:41PM +0200, Hans de Goede wrote: > The intel_dsi_msleep() helper skips sleeping if the MIPI-sequences have > a version of 3 or newer and the panel is in vid-mode. > > This is based on the big comment around line 730 which starts with > "Panel enable/disable sequences

Re: [Intel-gfx] [PATCH 13/13] drm/i915/psr: Re-enable PSR1 on hdw/bdw

2023-04-28 Thread Hogander, Jouni
On Fri, 2023-04-21 at 15:03 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > All known issues fixed now, so re-enable PSR1 on hsw/bdw. Please note s/hdw/hsw/ in subject. > > Signed-off-by: Ville Syrjälä > --- >  drivers/gpu/drm/i915/i915_pci.c | 4 ++-- >  1 file changed, 2 insertions(+),

Re: [Intel-gfx] [PATCH 08/13] drm/i915/psr: Implement WaPsrDPAMaskVBlankInSRD:hsw

2023-04-28 Thread Hogander, Jouni
On Fri, 2023-04-28 at 13:55 +0300, Ville Syrjälä wrote: > On Fri, Apr 28, 2023 at 10:36:17AM +, Hogander, Jouni wrote: > > On Fri, 2023-04-21 at 15:03 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Implement WaPsrDPAMaskVBlankInSRD:hsw, which makes the hardware > > > genera

Re: [Intel-gfx] [PATCH 05/13] drm/i915/psr: Bring back HSW/BDW PSR AUX CH registers/setup

2023-04-28 Thread Hogander, Jouni
On Fri, 2023-04-28 at 14:03 +0300, Ville Syrjälä wrote: > On Fri, Apr 28, 2023 at 10:18:34AM +, Hogander, Jouni wrote: > > Hello, > > > > Please check my inline comments below. > > > > On Fri, 2023-04-21 at 15:02 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Reintroduce

Re: [Intel-gfx] [PATCH v8 0/2] drm/i915: Hugepage manager and test for MTL

2023-04-28 Thread Andrzej Hajda
On 26.04.2023 23:28, Andrzej Hajda wrote: This patchset patches sent by Jonathan and Andi, with addressed CI failures: 1. Fixed checking alignment of 64K pages on both Pre-Gen12 and Gen12. 2. Fixed start alignment of 2M pages. Regards Andrzej Jonathan Cavitt (2): drm/i915: Migrate platform-d

Re: [Intel-gfx] [PATCH 13/13] drm/i915/psr: Re-enable PSR1 on hdw/bdw

2023-04-28 Thread Ville Syrjälä
On Fri, Apr 28, 2023 at 11:19:39AM +, Hogander, Jouni wrote: > On Fri, 2023-04-21 at 15:03 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > All known issues fixed now, so re-enable PSR1 on hsw/bdw. > > Please note s/hdw/hsw/ in subject. > > > > > Signed-off-by: Ville Syrjälä >

Re: [Intel-gfx] [RFC PATCH] x86/mm: Fix PAT bit missing from page protection modify mask

2023-04-28 Thread Andi Shyti
Hi Janusz, On Mon, Apr 24, 2023 at 02:35:24PM +0200, Janusz Krzysztofik wrote: > Visible glitches have been observed when running graphics applications on > Linux under Xen hypervisor. Those observations have been confirmed with > failures from kms_pwrite_crc Intel GPU test that verifies data coh

Re: [Intel-gfx] [PATCH 13/13] drm/i915/psr: Re-enable PSR1 on hdw/bdw

2023-04-28 Thread Hogander, Jouni
On Fri, 2023-04-28 at 14:36 +0300, Ville Syrjälä wrote: > On Fri, Apr 28, 2023 at 11:19:39AM +, Hogander, Jouni wrote: > > On Fri, 2023-04-21 at 15:03 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > All known issues fixed now, so re-enable PSR1 on hsw/bdw. > > > > Please no

Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-04-28 Thread Jason Gunthorpe
On Fri, Apr 28, 2023 at 02:21:26PM +0800, Yi Liu wrote: > but this patch needs to use vfio_iommufd_emulated_bind() and > vfio_iommufd_emulated_unbind() for the noiommu devices when binding > to iommufd. So needs to check noiommu in the vfio_iommufd_bind() > and vfio_iommu_unbind() as well. I'm no

[Intel-gfx] [RFC PATCH] dma-buf/dma-fence: Use a successful read_trylock() annotation for dma_fence_begin_signalling()

2023-04-28 Thread Thomas Hellström
Condsider the following call sequence: /* Upper layer */ dma_fence_begin_signalling(); lock(tainted_shared_lock); /* Driver callback */ dma_fence_begin_signalling(); ... The driver might here use a utility that is annotated as intended for the dma-fence signalling critical path. Now if the upper

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Use gt_err for GT info

2023-04-28 Thread Tejas Upadhyay
It will be more informative regarding GT if we use gt_err instead. Cc: Andi Shyti Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/gt/selftest_engine_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_pm.c b/drivers/gpu/drm/

[Intel-gfx] [PATCH 2/2] drm/i915/selftests: Use gt_err for GT info

2023-04-28 Thread Tejas Upadhyay
It will be more informative regarding GT if we use gt_err instead. Cc: Andi Shyti Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c b/drivers/g

[Intel-gfx] [PATCH 0/2] drm/i915: Use gt_err inplace of pr_err

2023-04-28 Thread Tejas Upadhyay
When we use gt_err we get GT info when that failure hits which helps in debugging. Cc: Andi Shyti Signed-off-by: Tejas Upadhyay Tejas Upadhyay (2): drm/i915/gt: Use gt_err for GT info drm/i915/selftests: Use gt_err for GT info drivers/gpu/drm/i915/gt/selftest_engine_pm.c| 3 ++- drive

Re: [Intel-gfx] [RFC PATCH] dma-buf/dma-fence: Use a successful read_trylock() annotation for dma_fence_begin_signalling()

2023-04-28 Thread Thomas Hellström
On 4/28/23 14:52, Thomas Hellström wrote: Condsider the following call sequence: /* Upper layer */ dma_fence_begin_signalling(); lock(tainted_shared_lock); /* Driver callback */ dma_fence_begin_signalling(); ... The "Upper layer" here currently being the drm scheduler and "Driver callback"

Re: [Intel-gfx] [PATCH 1/6] drm/uapi: Document CTM matrix better

2023-04-28 Thread Ville Syrjälä
On Fri, Apr 28, 2023 at 12:31:10AM +0200, Xaver Hugl wrote: > I can't say anything about the other commits in this series, but > "Document in which order the CTM matrix elements are stored" is > Reviewed-by: Xaver Hugl Thanks for the review+ack. Pushed to drm-misc-next. -- Ville Syrjälä Intel

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Use gt_err for GT info

2023-04-28 Thread Andi Shyti
Hi Tejas, On Fri, Apr 28, 2023 at 06:29:51PM +0530, Tejas Upadhyay wrote: > It will be more informative regarding > GT if we use gt_err instead. > > Cc: Andi Shyti > Signed-off-by: Tejas Upadhyay Thanks for this cleanup! Reviewed-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH 2/2] drm/i915/selftests: Use gt_err for GT info

2023-04-28 Thread Andi Shyti
Hi Tejas, On Fri, Apr 28, 2023 at 06:29:52PM +0530, Tejas Upadhyay wrote: > It will be more informative regarding > GT if we use gt_err instead. > > Cc: Andi Shyti > Signed-off-by: Tejas Upadhyay Reviewed-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH 05/11] drm/i915: Add support for disabling any CRTCs during HW readout/sanitization

2023-04-28 Thread Ville Syrjälä
On Wed, Apr 26, 2023 at 07:52:59PM +0300, Imre Deak wrote: > During HW readout/sanitization CRTCs can be disabled only if they don't > have an attached encoder (and so the encoder disable hooks don't need to > be called). An upcoming patch will need to disable CRTCs also with an > attached an encod

Re: [Intel-gfx] [PATCH 06/11] drm/i915/dp: Add link training debug and error printing helpers

2023-04-28 Thread Ville Syrjälä
On Wed, Apr 26, 2023 at 07:53:00PM +0300, Imre Deak wrote: > Add functions for printing link training debug and error messages, both > to prepare for the next patch, which downgrades an error to debug if the > sink is disconnected and to remove some code duplication. > > Signed-off-by: Imre Deak

Re: [Intel-gfx] [PATCH 0/8] drm/i915: HuC loading and authentication for MTL

2023-04-28 Thread Ceraolo Spurio, Daniele
On 4/27/2023 10:25 PM, Saarinen, Jani wrote: Hi, -Original Message- From: Intel-gfx On Behalf Of Ye, Tony Sent: perjantai 28. huhtikuuta 2023 6.11 To: Ceraolo Spurio, Daniele ; intel- g...@lists.freedesktop.org Cc: Teres Alexis, Alan Previn ; dri- de...@lists.freedesktop.org; Zhang,

Re: [Intel-gfx] [PATCH 10/11] drm/i915: Factor out call_with_modeset_ctx()

2023-04-28 Thread Ville Syrjälä
On Wed, Apr 26, 2023 at 07:53:04PM +0300, Imre Deak wrote: > Factor out a helper to call a function with the atomic locks held, > required by a follow-up patch resetting an active DP link. > > No functional changes. > > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_ddi.c |

Re: [Intel-gfx] [PATCH v3 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-28 Thread Yang, Fei
> On 4/28/23 07:47, fei.y...@intel.com wrote: >> From: Fei Yang >> >> The first three patches in this series are taken from >> https://patchwork.freedesktop.org/series/116868/ >> These patches are included here because the last patch >> has dependency on the pat_index refactor. >> >> This series i

Re: [Intel-gfx] [PATCH v10 00/22] Add vfio_device cdev for iommufd support

2023-04-28 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Jiang, Yanting [mailto:yanting.ji...@intel.com] > Sent: 28 April 2023 10:30 > To: Liu, Yi L ; alex.william...@redhat.com; > j...@nvidia.com; Tian, Kevin > Cc: j...@8bytes.org; robin.mur...@arm.com; coh...@redhat.com; > eric.au...@redhat.com; nicol...@nvidia.

Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-04-28 Thread Yi Liu
On 2023/4/28 20:07, Jason Gunthorpe wrote: On Fri, Apr 28, 2023 at 02:21:26PM +0800, Yi Liu wrote: but this patch needs to use vfio_iommufd_emulated_bind() and vfio_iommufd_emulated_unbind() for the noiommu devices when binding to iommufd. So needs to check noiommu in the vfio_iommufd_bind() an

Re: [Intel-gfx] [PATCH v3 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-28 Thread Intel
On 4/28/23 17:19, Yang, Fei wrote: > On 4/28/23 07:47, fei.y...@intel.com wrote: >> From: Fei Yang >> >> The first three patches in this series are taken from >> https://patchwork.freedesktop.org/series/116868/ >> These patches are included here because the last patch >> has dependency on the p

Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-04-28 Thread Yi Liu
On 2023/4/28 02:32, Alex Williamson wrote: On Thu, 27 Apr 2023 06:59:17 + "Liu, Yi L" wrote: [...] I'm not quite sure about it so far. For mdev devices, the device driver may use vfio_pin_pages/vfio_dma_rw () to pin page. Hence such drivers need to listen to dma_unmap() event. But for no

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Add support for C20 phy (rev2)

2023-04-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add support for C20 phy (rev2) URL : https://patchwork.freedesktop.org/series/116755/ State : warning == Summary == Error: dim checkpatch failed 7bd367a64eec drm/i915/mtl: C20 PLL programming -:175: WARNING:LONG_LINE: line length of 109 exceeds 100 co

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Add support for C20 phy (rev2)

2023-04-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add support for C20 phy (rev2) URL : https://patchwork.freedesktop.org/series/116755/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add support for C20 phy (rev2)

2023-04-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add support for C20 phy (rev2) URL : https://patchwork.freedesktop.org/series/116755/ State : success == Summary == CI Bug Log - changes from CI_DRM_13073 -> Patchwork_116755v2 Summary --- *

Re: [Intel-gfx] [PATCH 05/11] drm/i915: Add support for disabling any CRTCs during HW readout/sanitization

2023-04-28 Thread Imre Deak
On Fri, Apr 28, 2023 at 05:02:35PM +0300, Ville Syrjälä wrote: > On Wed, Apr 26, 2023 at 07:52:59PM +0300, Imre Deak wrote: > > During HW readout/sanitization CRTCs can be disabled only if they don't > > have an attached encoder (and so the encoder disable hooks don't need to > > be called). An upc

Re: [Intel-gfx] [PATCH v3 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-28 Thread Yang, Fei
>> On 4/28/23 17:19, Yang, Fei wrote: >>> On 4/28/23 07:47, fei.y...@intel.com wrote: From: Fei Yang The first three patches in this series are taken from https://patchwork.freedesktop.org/series/116868/ These patches are included here because the last patch has depen

Re: [Intel-gfx] [PATCH 05/11] drm/i915: Add support for disabling any CRTCs during HW readout/sanitization

2023-04-28 Thread Imre Deak
On Fri, Apr 28, 2023 at 08:22:54PM +0300, Imre Deak wrote: > On Fri, Apr 28, 2023 at 05:02:35PM +0300, Ville Syrjälä wrote: > > On Wed, Apr 26, 2023 at 07:52:59PM +0300, Imre Deak wrote: > > > During HW readout/sanitization CRTCs can be disabled only if they don't > > > have an attached encoder (an

[Intel-gfx] ✓ Fi.CI.BAT: success for dma-buf/dma-fence: Use a successful read_trylock() annotation for dma_fence_begin_signalling()

2023-04-28 Thread Patchwork
== Series Details == Series: dma-buf/dma-fence: Use a successful read_trylock() annotation for dma_fence_begin_signalling() URL : https://patchwork.freedesktop.org/series/117115/ State : success == Summary == CI Bug Log - changes from CI_DRM_13073 -> Patchwork_117115v1 ===

Re: [Intel-gfx] [PATCH v2 01/13] drm/i915/mtl: C20 PLL programming

2023-04-28 Thread Radhakrishna Sripada
On Fri, Apr 28, 2023 at 12:54:21PM +0300, Mika Kahola wrote: > C20 phy PLL programming sequence for DP, DP2.0, HDMI2.x non-FRL and > HDMI2.x FRL. This enables C20 MPLLA and MPLLB programming sequence. add > 4 lane support for c20. > > v2: Add 6.48Gbps and 6.75Gbps modes for eDP (RK) > Fix lane

Re: [Intel-gfx] [PATCH 1/5] drm/i915/guc: Don't capture Gen8 regs on Xe devices

2023-04-28 Thread John Harrison
On 4/26/2023 14:14, Teres Alexis, Alan Previn wrote: On Wed, 2023-04-26 at 10:23 -0700, Harrison, John C wrote: On 4/25/2023 10:55, Teres Alexis, Alan Previn wrote: On Thu, 2023-04-06 at 15:26 -0700, Harrison, John C wrote: From: John Harrison A pair of pre-Xe registers were being included i

Re: [Intel-gfx] [PATCH 10/11] drm/i915: Factor out call_with_modeset_ctx()

2023-04-28 Thread Imre Deak
On Fri, Apr 28, 2023 at 05:32:44PM +0300, Ville Syrjälä wrote: > On Wed, Apr 26, 2023 at 07:53:04PM +0300, Imre Deak wrote: > > Factor out a helper to call a function with the atomic locks held, > > required by a follow-up patch resetting an active DP link. > > > > No functional changes. > > > >

[Intel-gfx] [PATCH v2 4/4] drm/i915/guc: Fix error capture for virtual engines

2023-04-28 Thread John . C . Harrison
From: John Harrison GuC based register dumps in error capture logs were basically broken for virtual engines. This can be seen in igt@gem_exec_balancer@hang: [IGT] gem_exec_balancer: starting subtest hang [drm] GPU HANG: ecode 12:4:e1524110, in gem_exec_balanc [6388] [drm] GT0: GUC: No regi

[Intel-gfx] [PATCH v2 2/4] drm/i915/guc: Consolidate duplicated capture list code

2023-04-28 Thread John . C . Harrison
From: John Harrison Remove 99% duplicated steered register list code. Also, include the pre-Xe steered registers in the pre-Xe list generation. Signed-off-by: John Harrison Reviewed-by: Alan Previn --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 112 +- 1 file changed, 29

[Intel-gfx] [PATCH v2 1/4] drm/i915/guc: Don't capture Gen8 regs on Xe devices

2023-04-28 Thread John . C . Harrison
From: John Harrison A pair of pre-Xe registers were being included in the Xe capture list. GuC was rejecting those as being invalid and logging errors about them. So, stop doing it. Signed-off-by: John Harrison Reviewed-by: Alan Previn Fixes: dce2bd542337 ("drm/i915/guc: Add Gen9 registers for

[Intel-gfx] [PATCH v2 0/4] Improvements to GuC error capture

2023-04-28 Thread John . C . Harrison
From: John Harrison The GuC error capture list creation was including Gen8 registers on Xe platforms. While fixing that, it was noticed that there were other issues. The platform naming was wrong, the naming of lists was misleading, the steered register code was duplicated and steered registers w

[Intel-gfx] [PATCH v2 3/4] drm/i915/guc: Capture list naming clean up

2023-04-28 Thread John . C . Harrison
From: John Harrison Don't use 'xe_lp*' prefixes for register lists that are common with Gen8. Don't add Xe only GSC registers to pre-Xe devices that don't even have a GSC engine. Fix Xe_LP name. Don't use GEN9 as a prefix for register lists that contain all GEN8 registers. Rename the 'default

[Intel-gfx] [PATCH v2 1/8] DO NOT REVIEW: drm/i915: Add support for MTL GSC SW Proxy

2023-04-28 Thread Daniele Ceraolo Spurio
This is a squash of the GSC proxy series, which is being reviewed separately [1]. It's being included here because some of the patches in this series depend on it. This is not a functional dependencies, the patches just touch the same code and the proxy patches are planned to be merged first, so it

[Intel-gfx] [PATCH v2 0/8] drm/i915: HuC loading and authentication for MTL

2023-04-28 Thread Daniele Ceraolo Spurio
The HuC loading and authentication flow is once again changing and a new "clear-media only" authentication step is introduced. The flow is as follows: 1) The HuC is loaded via DMA - same as all non-GSC HuC binaries. 2) The HuC is authenticated by the GuC - this is the same step as performed for a

[Intel-gfx] [PATCH v2 2/8] drm/i915/uc: perma-pin firmwares

2023-04-28 Thread Daniele Ceraolo Spurio
Now that each FW has its own reserved area, we can keep them always pinned and skip the pin/unpin dance on reset. This will make things easier for the 2-step HuC authentication, which requires the FW to be pinned in GGTT after the xfer is completed. Given that we use dummy vmas for the pinning, we

[Intel-gfx] [PATCH v2 5/8] drm/i915/huc: differentiate the 2 steps of the MTL HuC auth flow

2023-04-28 Thread Daniele Ceraolo Spurio
Before we add the second step of the MTL HuC auth (via GSC), we need to have the ability to differentiate between them. To do so, the huc authentication check is duplicated for GuC and GSC auth, with meu binaries being considered fully authenticated only after the GSC auth step. To report the diff

[Intel-gfx] [PATCH v2 3/8] drm/i915/huc: Parse the GSC-enabled HuC binary

2023-04-28 Thread Daniele Ceraolo Spurio
The new binaries that support the 2-step authentication have contain the legacy-style binary, which we can use for loading the HuC via DMA. To find out where this is located in the image, we need to parse the meu manifest of the GSC binary. The manifest consist of a partition header followed by ent

[Intel-gfx] [PATCH v2 8/8] drm/i915/huc: define HuC FW version for MTL

2023-04-28 Thread Daniele Ceraolo Spurio
Follow the same logic as DG2, so just a meu binary with no version number. Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/u

[Intel-gfx] [PATCH v2 7/8] drm/i915/mtl/huc: Use the media gt for the HuC getparam

2023-04-28 Thread Daniele Ceraolo Spurio
On MTL, for obvious reasons, HuC is only available on the media tile. We already disable SW support for HuC on the root gt due to the absence of VCS engines, but we also need to update the getparam to point to the HuC struct in the media GT. Signed-off-by: Daniele Ceraolo Spurio Cc: John Harrison

[Intel-gfx] [PATCH v2 4/8] drm/i915/huc: Load GSC-enabled HuC via DMA xfer if the fuse says so

2023-04-28 Thread Daniele Ceraolo Spurio
In the previous patch we extracted the offset of the legacy-style HuC binary located within the GSC-enabled blob, so now we can use that to load the HuC via DMA if the fuse is set that way. Note that we now need to differentiate between "GSC-enabled binary" and "loaded by GSC", so the former case h

[Intel-gfx] [PATCH v2 6/8] drm/i915/mtl/huc: auth HuC via GSC

2023-04-28 Thread Daniele Ceraolo Spurio
The full authentication via the GSC requires an heci packet submission to the GSC FW via the GSC CS. The GSC has new PXP command for this (literally called NEW_HUC_AUTH). The intel_huc_auth fuction is also updated to handle both authentication types. Signed-off-by: Daniele Ceraolo Spurio Cc: Alan

Re: [Intel-gfx] [PATCH 06/11] drm/i915/dp: Add link training debug and error printing helpers

2023-04-28 Thread Imre Deak
On Fri, Apr 28, 2023 at 05:21:53PM +0300, Ville Syrjälä wrote: > On Wed, Apr 26, 2023 at 07:53:00PM +0300, Imre Deak wrote: > > Add functions for printing link training debug and error messages, both > > to prepare for the next patch, which downgrades an error to debug if the > > sink is disconnect

Re: [Intel-gfx] [PATCH v2 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-28 Thread Yang, Fei
> On 27/04/2023 17:07, Yang, Fei wrote: >>> On 26/04/2023 16:41, Yang, Fei wrote: > On 26/04/2023 07:24, fei.y...@intel.com wrote: >> From: Fei Yang >> >> The first three patches in this series are taken from >> https://patchwork.freedesktop.org/series/116868/ >> These patc

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use gt_err inplace of pr_err

2023-04-28 Thread Patchwork
== Series Details == Series: drm/i915: Use gt_err inplace of pr_err URL : https://patchwork.freedesktop.org/series/117116/ State : success == Summary == CI Bug Log - changes from CI_DRM_13074 -> Patchwork_117116v1 Summary --- **SUCCE

  1   2   >