Re: [Intel-gfx] [PATCH v5] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-18 Thread Andrzej Hajda
On 18.04.2023 01:53, Andi Shyti wrote: In multi-gt systems IRQs need to be reset and enabled per GT. This might add some redundancy when handling interrupts for engines that might not exist in every tile, but helps to keep the code cleaner and more understandable. Signed-off-by: Andi Shyti Cc:

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Provide sysfs for efficient freq

2023-04-18 Thread Andi Shyti
Hi Vinay, On Mon, Apr 17, 2023 at 11:04:31PM -0700, Belgaumkar, Vinay wrote: > > On 4/17/2023 6:39 PM, Andi Shyti wrote: > > Hi Vinay, > > > > Looks good, just few minor comments below, > > > > [...] > > > > > @@ -267,13 +267,11 @@ static int run_test(struct intel_gt *gt, int > > > test_type)

[Intel-gfx] ✓ Fi.CI.IGT: success for fdinfo alternative memory stats proposal

2023-04-18 Thread Patchwork
== Series Details == Series: fdinfo alternative memory stats proposal URL : https://patchwork.freedesktop.org/series/116581/ State : success == Summary == CI Bug Log - changes from CI_DRM_13022_full -> Patchwork_116581v1_full Summary --

Re: [Intel-gfx] [PATCH] drm/i915/gt: Consider multi-gt at all places

2023-04-18 Thread Tvrtko Ursulin
On 17/04/2023 19:13, Upadhyay, Tejas wrote: -Original Message- From: Tvrtko Ursulin Sent: Wednesday, April 5, 2023 2:01 PM To: Upadhyay, Tejas ; Intel- g...@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Consider multi-gt at all places On 05/04/2023 07:56, Upa

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-04-18 Thread Patchwork
== Series Details == Series: drm/dp_mst: Clear MSG_RDY flag before sending new message URL : https://patchwork.freedesktop.org/series/116623/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13023 -> Patchwork_116623v1 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Initialize dkl_phy spin lock from display code path (rev2)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/i915: Initialize dkl_phy spin lock from display code path (rev2) URL : https://patchwork.freedesktop.org/series/116325/ State : success == Summary == CI Bug Log - changes from CI_DRM_13022_full -> Patchwork_116325v2_full

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Tvrtko Ursulin
On 17/04/2023 20:39, Rob Clark wrote: On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add support to dump GEM stats to fdinfo. Signed-off-by: Tvrtko Ursulin --- Documentation/gpu/drm-usage-stats.rst | 12 +++ drivers/gpu/drm/drm_file.c| 52 ++

Re: [Intel-gfx] [PATCH 1/1] drm/i915/debugfs: New debugfs for display clock frequencies

2023-04-18 Thread Jani Nikula
On Fri, 14 Apr 2023, Lucas De Marchi wrote: > On Wed, Apr 12, 2023 at 12:22:51PM +0300, Jani Nikula wrote: >>On Wed, 12 Apr 2023, Bhanuprakash Modem wrote: >>> + >>> static ssize_t i915_displayport_test_active_write(struct file *file, >>> const char

Re: [Intel-gfx] [PATCH v1 2/4] drm/i915: update the QGV point frequency calculations

2023-04-18 Thread Lisovskiy, Stanislav
On Sun, Apr 16, 2023 at 06:54:15PM +0300, Vinod Govindapillai wrote: > From MTL onwwards, pcode locks the QGV point based on peak BW of > the intended QGV point passed by the driver. So the peak BW > calculation must match the value expected by the pcode. Update > the calculations as per the Bspec.

[Intel-gfx] [PATCH v3] drm/i915/display: Increase AUX timeout for Type-C

2023-04-18 Thread Suraj Kandpal
Type-C PHYs are taking longer than expected for Aux IO Power Enabling. Workaround: Increase the timeout. WA_14017248603: adlp Bspec: 55480 ---v2 -change style on how we mention WA [Ankit] -fix bat error by creating new func that is only called for aux power well scenarios so we can avoid null poi

Re: [Intel-gfx] [PATCH v1 2/4] drm/i915: update the QGV point frequency calculations

2023-04-18 Thread Govindapillai, Vinod
On Tue, 2023-04-18 at 12:25 +0300, Lisovskiy, Stanislav wrote: > On Sun, Apr 16, 2023 at 06:54:15PM +0300, Vinod Govindapillai wrote: > > From MTL onwwards, pcode locks the QGV point based on peak BW of > > the intended QGV point passed by the driver. So the peak BW > > calculation must match the v

Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Fix CP current state

2023-04-18 Thread Gupta, Anshuman
> -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, April 12, 2023 9:18 AM > To: intel-gfx@lists.freedesktop.org > Cc: Gupta, Anshuman ; Nautiyal, Ankit K > ; Kandpal, Suraj > Subject: [PATCH] drm/i915/hdcp: Fix CP current state > > In many cases there is a need to change t

Re: [Intel-gfx] [PATCH v3] drm/i915/display: Increase AUX timeout for Type-C

2023-04-18 Thread Jani Nikula
On Tue, 18 Apr 2023, Suraj Kandpal wrote: > Type-C PHYs are taking longer than expected for Aux IO Power Enabling. > Workaround: Increase the timeout. > > WA_14017248603: adlp This needs to be in a comment, and removed from the commit message. > Bspec: 55480 This needs to be moved down... > >

Re: [Intel-gfx] [PATCH v3] drm/i915/display: Increase AUX timeout for Type-C

2023-04-18 Thread Imre Deak
On Tue, Apr 18, 2023 at 02:53:46PM +0530, Suraj Kandpal wrote: > Type-C PHYs are taking longer than expected for Aux IO Power Enabling. > Workaround: Increase the timeout. > > WA_14017248603: adlp > Bspec: 55480 > > ---v2 > -change style on how we mention WA [Ankit] > -fix bat error by creating n

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-18 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Monday, April 17, 2023 9:39 PM > > On Fri, Apr 14, 2023 at 09:11:30AM +, Tian, Kevin wrote: > > > The only corner case with this option is when a user mixes group > > and cdev usages. iirc you mentioned it's a valid usage to be supported. > > In that case the

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-18 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, April 18, 2023 12:11 PM > [...] > > We haven't discussed how it fails when called on a group-opened device > in a mixed environment. I'd propose that the INFO ioctl behaves > exactly as it does today, reporting group-id and BDF for each affected > device.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Make IRQ reset and postinstall multi-gt aware (rev7)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/i915: Make IRQ reset and postinstall multi-gt aware (rev7) URL : https://patchwork.freedesktop.org/series/115465/ State : success == Summary == CI Bug Log - changes from CI_DRM_13023_full -> Patchwork_115465v7_full ==

Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Fix CP current state

2023-04-18 Thread Kandpal, Suraj
> > > -Original Message- > > From: Kandpal, Suraj > > Sent: Wednesday, April 12, 2023 9:18 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: Gupta, Anshuman ; Nautiyal, Ankit K > > ; Kandpal, Suraj > > Subject: [PATCH] drm/i915/hdcp: Fix CP current state > > > > In many cases there is a

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Tvrtko Ursulin
On 17/04/2023 17:20, Christian König wrote: Am 17.04.23 um 17:56 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Add support to dump GEM stats to fdinfo. Signed-off-by: Tvrtko Ursulin ---   Documentation/gpu/drm-usage-stats.rst | 12 +++   drivers/gpu/drm/drm_file.c    | 52 +++

[Intel-gfx] [PATCH v4] drm/i915/display: Increase AUX timeout for Type-C

2023-04-18 Thread Suraj Kandpal
Type-C PHYs are taking longer than expected for Aux IO Power Enabling. Workaround: Increase the timeout. ---v2 -change style on how we mention WA [Ankit] -fix bat error by creating new func that is only called for aux power well scenarios so we can avoid null pointer error as it is called everywhe

[Intel-gfx] [PATCH v4] drm/i915/display: Increase AUX timeout for Type-C

2023-04-18 Thread Suraj Kandpal
Type-C PHYs are taking longer than expected for Aux IO Power Enabling. Workaround: Increase the timeout. ---v2 -change style on how we mention WA [Ankit] -fix bat error by creating new func that is only called for aux power well scenarios so we can avoid null pointer error as it is called everywhe

Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Fix CP current state

2023-04-18 Thread Gupta, Anshuman
> -Original Message- > From: Kandpal, Suraj > Sent: Tuesday, April 18, 2023 4:16 PM > To: Gupta, Anshuman ; intel- > g...@lists.freedesktop.org > Cc: Nautiyal, Ankit K ; Shankar, Uma > > Subject: RE: [PATCH] drm/i915/hdcp: Fix CP current state > > > > > > -Original Message- >

Re: [Intel-gfx] [PATCH v4] drm/i915/display: Increase AUX timeout for Type-C

2023-04-18 Thread Imre Deak
On Tue, Apr 18, 2023 at 04:24:54PM +0530, Suraj Kandpal wrote: > Type-C PHYs are taking longer than expected for Aux IO Power Enabling. > Workaround: Increase the timeout. > > ---v2 > -change style on how we mention WA [Ankit] > -fix bat error by creating new func that is only called for aux power

[Intel-gfx] ✓ Fi.CI.IGT: success for Handle dma fences in dirtyfb ioctl

2023-04-18 Thread Patchwork
== Series Details == Series: Handle dma fences in dirtyfb ioctl URL : https://patchwork.freedesktop.org/series/116620/ State : success == Summary == CI Bug Log - changes from CI_DRM_13023_full -> Patchwork_116620v1_full Summary --- *

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/dp_mst: Clear MSG_RDY flag before sending new message (rev2)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/dp_mst: Clear MSG_RDY flag before sending new message (rev2) URL : https://patchwork.freedesktop.org/series/116623/ State : success == Summary == CI Bug Log - changes from CI_DRM_13025 -> Patchwork_116623v2

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Increase AUX timeout for Type-C (rev6)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/i915/display: Increase AUX timeout for Type-C (rev6) URL : https://patchwork.freedesktop.org/series/116010/ State : warning == Summary == Error: dim checkpatch failed 3f84391d7543 drm/i915/display: Increase AUX timeout for Type-C -:39: CHECK:OPEN_ENDED_LINE: Li

Re: [Intel-gfx] [PATCH v4] drm/i915/display: Increase AUX timeout for Type-C

2023-04-18 Thread Kandpal, Suraj
> -Original Message- > From: Deak, Imre > Sent: Tuesday, April 18, 2023 4:34 PM > To: Kandpal, Suraj > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani > Subject: Re: [PATCH v4] drm/i915/display: Increase AUX timeout for Type-C > > On Tue, Apr 18, 2023 at 04:24:54PM +0530, Suraj Kan

Re: [Intel-gfx] [PATCH v1 2/4] drm/i915: update the QGV point frequency calculations

2023-04-18 Thread Lisovskiy, Stanislav
On Tue, Apr 18, 2023 at 12:47:33PM +0300, Govindapillai, Vinod wrote: > On Tue, 2023-04-18 at 12:25 +0300, Lisovskiy, Stanislav wrote: > > On Sun, Apr 16, 2023 at 06:54:15PM +0300, Vinod Govindapillai wrote: > > > From MTL onwwards, pcode locks the QGV point based on peak BW of > > > the intended Q

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Increase AUX timeout for Type-C (rev6)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/i915/display: Increase AUX timeout for Type-C (rev6) URL : https://patchwork.freedesktop.org/series/116010/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13025 -> Patchwork_116010v6 Summary

Re: [Intel-gfx] [PATCH v4] drm/i915/display: Increase AUX timeout for Type-C

2023-04-18 Thread Imre Deak
On Tue, Apr 18, 2023 at 02:45:27PM +0300, Kandpal, Suraj wrote: > [...] > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power_map.c > > > b/drivers/gpu/drm/i915/display/intel_display_power_map.c > > > index 6645eb1911d8..f0d51a30430a 100644 > > > --- a/drivers/gpu/drm/i915/display/int

Re: [Intel-gfx] [PATCH] drm/i915/display: Return correct err code for bpc < 0

2023-04-18 Thread Ville Syrjälä
On Mon, Apr 17, 2023 at 03:48:12PM -0700, Manasi Navare wrote: > Hi Ville, > > Could you suggest how to handle the intel_dp_link_compute_config() > when the max_bpp is returned as 0, currently > it just exits the loop and returns a -EINVAL and this triggers the DSC path. > While we should be compl

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-18 Thread Jason Gunthorpe
On Mon, Apr 17, 2023 at 02:06:42PM -0600, Alex Williamson wrote: > On Mon, 17 Apr 2023 16:31:56 -0300 > Jason Gunthorpe wrote: > > > On Mon, Apr 17, 2023 at 01:01:40PM -0600, Alex Williamson wrote: > > > Yes, it's not trivial, but Jason is now proposing that we consider > > > mixing groups, cdevs

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-18 Thread Jason Gunthorpe
On Tue, Apr 18, 2023 at 05:02:44AM +, Tian, Kevin wrote: > Yes I chatted with Yi about it. > > If the calling device of the INFO ioctl is opened by group then behave > as it does today. > > If the calling device is opened via cdev then use dev_id scheme as > discussed above. > > in hot_rese

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-18 Thread Jason Gunthorpe
On Tue, Apr 18, 2023 at 10:23:55AM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Monday, April 17, 2023 9:39 PM > > > > On Fri, Apr 14, 2023 at 09:11:30AM +, Tian, Kevin wrote: > > > > > The only corner case with this option is when a user mixes group > > > and cdev usages. iir

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/display: Increase AUX timeout for Type-C (rev7)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/i915/display: Increase AUX timeout for Type-C (rev7) URL : https://patchwork.freedesktop.org/series/116010/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/116010/revisions/7/mbox/ not applied Patch is empty. When y

[Intel-gfx] [PATCH v5] drm/i915/display: Increase AUX timeout for Type-C

2023-04-18 Thread Suraj Kandpal
Type-C PHYs are taking longer than expected for Aux IO Power Enabling. Workaround: Increase the timeout. ---v2 -change style on how we mention WA [Ankit] -fix bat error by creating new func that is only called for aux power well scenarios so we can avoid null pointer error as it is called everywhe

Re: [Intel-gfx] [PATCH] drm/i915/dp_mst: Fix active port PLL selection for secondary MST streams

2023-04-18 Thread Kahola, Mika
> -Original Message- > From: Deak, Imre > Sent: Friday, April 14, 2023 8:38 PM > To: intel-gfx@lists.freedesktop.org > Cc: Kahola, Mika > Subject: [PATCH] drm/i915/dp_mst: Fix active port PLL selection for secondary > MST streams > > The port PLL selection needs to be up-to-date in the C

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin wrote: > > > On 17/04/2023 20:39, Rob Clark wrote: > > On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Add support to dump GEM stats to fdinfo. > >> > >> Signed-off-by: Tvrtko Ursulin > >> --- > >>

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Increase AUX timeout for Type-C (rev8)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/i915/display: Increase AUX timeout for Type-C (rev8) URL : https://patchwork.freedesktop.org/series/116010/ State : warning == Summary == Error: dim checkpatch failed a0f5885b6afe drm/i915/display: Increase AUX timeout for Type-C -:45: CHECK:OPEN_ENDED_LINE: Li

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Increase AUX timeout for Type-C (rev8)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/i915/display: Increase AUX timeout for Type-C (rev8) URL : https://patchwork.freedesktop.org/series/116010/ State : success == Summary == CI Bug Log - changes from CI_DRM_13026 -> Patchwork_116010v8 Summary

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 3:47 AM Tvrtko Ursulin wrote: > > > On 17/04/2023 17:20, Christian König wrote: > > Am 17.04.23 um 17:56 schrieb Tvrtko Ursulin: > >> From: Tvrtko Ursulin > >> > >> Add support to dump GEM stats to fdinfo. > >> > >> Signed-off-by: Tvrtko Ursulin > >> --- > >> Documentat

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Tvrtko Ursulin
On 18/04/2023 14:49, Rob Clark wrote: On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin wrote: On 17/04/2023 20:39, Rob Clark wrote: On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add support to dump GEM stats to fdinfo. Signed-off-by: Tvrtko Ursulin ---

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 14:49, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 17/04/2023 20:39, Rob Clark wrote: > >>> On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > >>> wrote: > > Fro

Re: [Intel-gfx] [PATCH] drm/i915/display: Return correct err code for bpc < 0

2023-04-18 Thread Nautiyal, Ankit K
On 4/18/2023 6:16 PM, Ville Syrjälä wrote: On Mon, Apr 17, 2023 at 03:48:12PM -0700, Manasi Navare wrote: Hi Ville, Could you suggest how to handle the intel_dp_link_compute_config() when the max_bpp is returned as 0, currently it just exits the loop and returns a -EINVAL and this triggers th

Re: [Intel-gfx] [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-18 Thread Rob Clark
On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Show how more driver specific set of memory stats could be shown, > more specifically where object can reside in multiple regions, showing all > the supported stats, and where there is more to show than just user v

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Tvrtko Ursulin
On 18/04/2023 15:36, Rob Clark wrote: On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin wrote: On 18/04/2023 14:49, Rob Clark wrote: On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin wrote: On 17/04/2023 20:39, Rob Clark wrote: On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: From:

Re: [Intel-gfx] [PATCH] drm/i915/display: Return correct err code for bpc < 0

2023-04-18 Thread Ville Syrjälä
On Tue, Apr 18, 2023 at 08:09:16PM +0530, Nautiyal, Ankit K wrote: > > On 4/18/2023 6:16 PM, Ville Syrjälä wrote: > > On Mon, Apr 17, 2023 at 03:48:12PM -0700, Manasi Navare wrote: > >> Hi Ville, > >> > >> Could you suggest how to handle the intel_dp_link_compute_config() > >> when the max_bpp is

Re: [Intel-gfx] [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-18 Thread Tvrtko Ursulin
On 18/04/2023 15:39, Rob Clark wrote: On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin Show how more driver specific set of memory stats could be shown, more specifically where object can reside in multiple regions, showing all the supported stats, and where there

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/dp_mst: Clear MSG_RDY flag before sending new message (rev2)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/dp_mst: Clear MSG_RDY flag before sending new message (rev2) URL : https://patchwork.freedesktop.org/series/116623/ State : success == Summary == CI Bug Log - changes from CI_DRM_13025_full -> Patchwork_116623v2_full

Re: [Intel-gfx] [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:58 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 15:39, Rob Clark wrote: > > On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Show how more driver specific set of memory stats could be shown, > >> more specifically where

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:46 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 15:36, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 18/04/2023 14:49, Rob Clark wrote: > >>> On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin > >>> wrote: > > > >

Re: [Intel-gfx] [PATCH 0/2] Add support for dumping error captures via kernel logging

2023-04-18 Thread Rodrigo Vivi
On Tue, Apr 11, 2023 at 06:50:53PM +0200, Daniel Vetter wrote: > On Tue, Apr 11, 2023 at 09:41:04AM -0700, John Harrison wrote: > > On 4/11/2023 07:41, Rodrigo Vivi wrote: > > > On Mon, Apr 10, 2023 at 12:25:21PM -0700, john.c.harri...@intel.com wrote: > > > > From: John Harrison > > > > > > > >

[Intel-gfx] [PATCH v4] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-18 Thread José Roberto de Souza
Start to move the initialization of display locks from i915_driver_early_probe(), this way it is also executed when running Xe kmd. This will fix a warning in Xe kmd: [ 201.894839] xe :00:02.0: [drm] [ENCODER:235:DDI A/PHY A] failed to retrieve link info, disabling eDP [ 202.136336] xe 000

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Tvrtko Ursulin
On 18/04/2023 17:13, Rob Clark wrote: On Tue, Apr 18, 2023 at 7:46 AM Tvrtko Ursulin wrote: On 18/04/2023 15:36, Rob Clark wrote: On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin wrote: On 18/04/2023 14:49, Rob Clark wrote: On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin wrote: On 17/0

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-18 Thread Alex Williamson
On Tue, 18 Apr 2023 05:02:44 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Tuesday, April 18, 2023 12:11 PM > > > > On Tue, 18 Apr 2023 03:24:46 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson > > > > Sent: Tuesday, April 18, 2023 4:07 AM > > > > > > > > O

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-18 Thread Alex Williamson
On Tue, 18 Apr 2023 10:34:45 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, April 18, 2023 12:11 PM > > > [...] > > > > We haven't discussed how it fails when called on a group-opened device > > in a mixed environment. I'd propose that the INFO ioctl behaves > > exactl

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Increase AUX timeout for Type-C (rev8)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/i915/display: Increase AUX timeout for Type-C (rev8) URL : https://patchwork.freedesktop.org/series/116010/ State : success == Summary == CI Bug Log - changes from CI_DRM_13026_full -> Patchwork_116010v8_full

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 9:44 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 17:13, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 7:46 AM Tvrtko Ursulin > > wrote: > >> On 18/04/2023 15:36, Rob Clark wrote: > >>> On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin > >>> wrote: > > > On 18/

Re: [Intel-gfx] [RFC 4/6] drm: Add simple fdinfo memory helpers

2023-04-18 Thread Rob Clark
On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > For drivers who only wish to show one memory region called 'system, > and only account the GEM buffer object handles under it. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/drm_file.c | 45 +++

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: split out load detect to a separate file

2023-04-18 Thread Rodrigo Vivi
On Mon, Apr 17, 2023 at 06:37:40PM +0300, Jani Nikula wrote: > Load detect is shared between tv and crt but otherwise isolated in > intel_display.c. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/d

Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Block waiting for GuC reset to complete

2023-04-18 Thread Dixit, Ashutosh
On Mon, 17 Apr 2023 22:35:58 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Mon, Apr 10, 2023 at 03:35:09PM -0700, Ashutosh Dixit wrote: > > Instead of erroring out when GuC reset is in progress, block waiting for > > GuC reset to complete which is a more reasonable uapi behavior. > > > > v2: Avoi

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: throw out struct intel_load_detect_pipe

2023-04-18 Thread Rodrigo Vivi
On Mon, Apr 17, 2023 at 06:37:41PM +0300, Jani Nikula wrote: > An error-valued pointer can handle all in one without the wrapper > struct. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_crt.c | 18 - > .../gpu/drm/i915/display/intel_load_detect.c

[Intel-gfx] [PATCH 00/15] drm/i915: Scaler/pfit stuff

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä One scaler bugfix, and a bunch of scaler/pfit cleanups/etc. Ville Syrjälä (15): drm/i915: Check pipe source size when using skl+ scalers drm/i915: Relocate VBLANK_EVASION_TIME_US drm/i915: Relocate intel_atomic_setup_scalers() drm/i915: Relocate skl_get_pfit_config()

[Intel-gfx] [PATCH 02/15] drm/i915: Relocate VBLANK_EVASION_TIME_US

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Move the VBLANK_EVASION_TIME_US definition to a slightly better place. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc.h| 10 ++ drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- drivers/gpu/drm/i915/display/intel_spr

[Intel-gfx] [PATCH 01/15] drm/i915: Check pipe source size when using skl+ scalers

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä The skl+ scalers only sample 12 bits of PIPESRC so we can't do any plane scaling at all when the pipe source size is >4k. Make sure the pipe source size is also below the scaler's src size limits. Might not be 100% accurate, but should at least be safe. We can refine the limi

[Intel-gfx] [PATCH 06/15] drm/i915: Namespace pfit registers properly

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Give the PFIT_CONTROL bits a consistent namespace. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_lvds.c| 2 +- drivers/gpu/drm/i915/display/intel_overlay.c | 2 +- drivers/gpu/drm/i915/display/intel_panel.c | 25 ++-- drivers/gp

[Intel-gfx] [PATCH 05/15] drm/i915: Use REG_BIT() & co for the pre-ilk pfit registers

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Modernize the gmch pfit register definitions using REG_BIT/etc. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 15 +++--- drivers/gpu/drm/i915/display/intel_overlay.c | 16 +++--- drivers/gpu/drm/i915/display/intel_panel.c | 8 +-- driver

[Intel-gfx] [PATCH 10/15] drm/i915: Remove dead scaler register defines

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä We have some duplicated scaler register defines that are never used. Remove them. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_re

[Intel-gfx] [PATCH 03/15] drm/i915: Relocate intel_atomic_setup_scalers()

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Move intel_atomic_setup_scalers() next to the other scaler code in skl_scaler.c. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic.c | 256 --- drivers/gpu/drm/i915/display/intel_atomic.h | 4 - drivers/gpu/drm/i915/display/skl_sca

[Intel-gfx] [PATCH 07/15] drm/i915: Use REG_BIT() & co. for ilk+ pfit registers

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Polish the ilk+ pfit registers with REG_BIT() & co., and also take the opportunity to unify the ivb/hsw vs. not checks in ilk_pfit_enable() and ilk_get_pfit_config(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 9 +++-- drivers/gpu/d

[Intel-gfx] [PATCH 08/15] drm/i915: Drop a useless forward declararion

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä ilk_pfit_enable() is defined before the first use. No need for a forwared declaration. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gp

[Intel-gfx] [PATCH 13/15] drm/i915: Define bitmasks for sik+ scaler window pos/size

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Define and use the bitmasks for the x/y components of the skl+ scaler window pos/size registers. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_scaler.c | 14 -- drivers/gpu/drm/i915/i915_reg.h | 8 2 files changed, 16 inse

[Intel-gfx] [PATCH 12/15] drm/i915: s/PS_COEE_INDEX_AUTO_INC/PS_COEF_INDEX_AUTO_INC/

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Fix a typo in the PS_COEF_INDEX_AUTO_INC define. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_scaler.c | 2 +- drivers/gpu/drm/i915/i915_reg.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/

[Intel-gfx] [PATCH 11/15] drm/i915: Rename skl+ scaler binding bits

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Rename the scaler binding bits to match the spec more closely. Also call the parameters 'plane_id' to make it a bit more clear what to pass in. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_scaler.c | 12 ++-- drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 09/15] drm/i915: Define bitmasks for ilk pfit window pos/size

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Define and use the bitmasks for the x/y components of the ilk+ panel filter window pos/size registers. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 12 drivers/gpu/drm/i915/i915_reg.h | 8 2 files change

[Intel-gfx] [PATCH 14/15] drm/i915: Use REG_BIT() & co. for pipe scaler registers

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Pimp the skl+ scaler register bits with REG_BIT()/etc. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 98 ++--- 1 file changed, 53 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/

[Intel-gfx] [PATCH 15/15] drm/i915: Define more PS_CTRL bits

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä To avoid annoying spec lookups let's define more PS_CTRL bits in the header. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h i

[Intel-gfx] [PATCH 04/15] drm/i915: Relocate skl_get_pfit_config()

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Move skl_get_pfit_config() next to the other skl+ scaler code and rename it to skl_scaler_get_config() so that it has a consistnet namespace. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 49 ++-- drivers/gpu/drm/i915/displa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Initialize dkl_phy spin lock from display code path (rev3)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/i915: Initialize dkl_phy spin lock from display code path (rev3) URL : https://patchwork.freedesktop.org/series/116325/ State : success == Summary == CI Bug Log - changes from CI_DRM_13026 -> Patchwork_116325v3 ==

Re: [Intel-gfx] [PATCH v7 6/8] drm/i915/uapi/pxp: Fix UAPI spec comments and add GET_PARAM for PXP

2023-04-18 Thread Lionel Landwerlin
On 14/04/2023 18:17, Teres Alexis, Alan Previn wrote: Hi Lionel, does this patch work for you? Hi, Sorry for the late answer. That looks good : Acked-by: Lionel Landwerlin Thanks, -Lionel On Mon, 2023-04-10 at 10:22 -0700, Ceraolo Spurio, Daniele wrote: On 4/6/2023 10:44 AM, Alan

[Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Dump error capture to dmesg on CTB error

2023-04-18 Thread John . C . Harrison
From: John Harrison In the past, There have been sporadic CTB failures which proved hard to reproduce manually. The most effective solution was to dump the GuC log at the point of failure and let the CI system do the repro. It is preferable not to dump the GuC log via dmesg for all issues as it i

[Intel-gfx] [PATCH v2 0/2] Add support for dumping error captures via kernel logging

2023-04-18 Thread John . C . Harrison
From: John Harrison Sometimes, the only effective way to debug an issue is to dump all the interesting information at the point of failure. So add support for doing that. v2: Extra CONFIG wrapping (review feedback from Rodrigo) Signed-off-by: John Harrison John Harrison (2): drm/i915: Dump

[Intel-gfx] [PATCH v2 1/2] drm/i915: Dump error capture to kernel log

2023-04-18 Thread John . C . Harrison
From: John Harrison This is useful for getting debug information out in certain situations, such as failing kernel selftests and CI runs that don't log error captures. It is especially useful for things like retrieving GuC logs as GuC operation can't be tracked by adding printk or ftrace entries.

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Scaler/pfit stuff

2023-04-18 Thread Patchwork
== Series Details == Series: drm/i915: Scaler/pfit stuff URL : https://patchwork.freedesktop.org/series/116661/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers LD [M] drivers/gpu/drm/i915/i915.o CC [M] driv

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-18 Thread Mark Brown
On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > Note there was a ppc compile fail, which is why we pushed the ttm revert. > That /should/ be fixed now, but would be good if you can confirm? According to Nathan (CCed) there's still issues with the interaction with the PowerPC tree

Re: [Intel-gfx] [PATCH 2/5] drm/i915/guc: Print status register when waiting for GuC to load

2023-04-18 Thread Ceraolo Spurio, Daniele
On 4/14/2023 5:57 PM, john.c.harri...@intel.com wrote: From: John Harrison If the GuC load is taking an excessively long time, the wait loop currently prints the GT frequency. Extend that to include the GuC status as well so we can see if the GuC is actually making progress or not. Signed-o

Re: [Intel-gfx] [PATCH v7 6/8] drm/i915/uapi/pxp: Fix UAPI spec comments and add GET_PARAM for PXP

2023-04-18 Thread Teres Alexis, Alan Previn
On Tue, 2023-04-18 at 21:06 +0300, Landwerlin, Lionel G wrote: > On 14/04/2023 18:17, Teres Alexis, Alan Previn wrote: > > Hi Lionel, does this patch work for you? > > > Hi, Sorry for the late answer. > > That looks good : alan: Great - thanks Lionel! :) I'll help get the MESA side PR out in com

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-18 Thread Alex Williamson
On Tue, 18 Apr 2023 09:57:32 -0300 Jason Gunthorpe wrote: > On Mon, Apr 17, 2023 at 02:06:42PM -0600, Alex Williamson wrote: > > On Mon, 17 Apr 2023 16:31:56 -0300 > > Jason Gunthorpe wrote: > > > > > On Mon, Apr 17, 2023 at 01:01:40PM -0600, Alex Williamson wrote: > > > > Yes, it's not tri

Re: [Intel-gfx] [PATCH 1/5] drm/i915/guc: Decode another GuC load failure case

2023-04-18 Thread Ceraolo Spurio, Daniele
On 4/14/2023 5:57 PM, john.c.harri...@intel.com wrote: From: John Harrison Explain another potential firmware failure mode and early exit the long wait if hit. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio Daniele --- drivers/gpu/drm/i915/gt/uc/abi/guc_errors_ab

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for dumping error captures via kernel logging (rev2)

2023-04-18 Thread Patchwork
== Series Details == Series: Add support for dumping error captures via kernel logging (rev2) URL : https://patchwork.freedesktop.org/series/116280/ State : warning == Summary == Error: dim checkpatch failed 0fdd3a06a2b6 drm/i915: Dump error capture to kernel log -:64: WARNING:OOM_MESSAGE: Pos

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add support for dumping error captures via kernel logging (rev2)

2023-04-18 Thread Patchwork
== Series Details == Series: Add support for dumping error captures via kernel logging (rev2) URL : https://patchwork.freedesktop.org/series/116280/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for dumping error captures via kernel logging (rev2)

2023-04-18 Thread Patchwork
== Series Details == Series: Add support for dumping error captures via kernel logging (rev2) URL : https://patchwork.freedesktop.org/series/116280/ State : success == Summary == CI Bug Log - changes from CI_DRM_13026 -> Patchwork_116280v2

[Intel-gfx] [PATCH v2 11/15] drm/i915: Rename skl+ scaler binding bits

2023-04-18 Thread Ville Syrjala
From: Ville Syrjälä Rename the scaler binding bits to match the spec more closely. Also call the parameters 'plane_id' to make it a bit more clear what to pass in. v2: Don't break gvt Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_scaler.c | 12 ++-- drivers/gpu/drm

[Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step

2023-04-18 Thread Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep Wa_22011802037 was being applied to all graphics_ver 11 & 12. This patch updates the if statement to apply the W/A to right platforms and extends it to MTL-M:A step. v1.1: Fix checkpatch warning. v2: Change the check to reflect the wa at other palces(Lucas

[Intel-gfx] [PATCH v2 1/4] drm/i915: Use separate "DC off" power well for ADL-P and DG2

2023-04-18 Thread Radhakrishna Sripada
From: Matt Roper Although ADL-P and DG2 both use the same general power well setup, the DC5/DC6 requirements are slightly different which means each platform should have its own "DC off" power well. DG2 (i.e., Xe_HPD IP) requires that DC5 be disabled whenever PG2 is active. However ADL-P (i.e.,

[Intel-gfx] [PATCH v2 2/4] drm/i915/mtl: Re-use ADL-P's "DC off" power well

2023-04-18 Thread Radhakrishna Sripada
From: Matt Roper As with ADL-P, MTL's "DC off" power well should be a dependency of the PGC and PGD power wells, not the entire PG2 well. In fact, the DC5/DC6 requirements between the two platforms are the same, so the Xe_LPD "DC off" well definition can just be re-used for Xe_LPD+. Bspec: 4919

[Intel-gfx] [PATCH v2 0/4] More MTL WA and powerwell patches

2023-04-18 Thread Radhakrishna Sripada
This series adds 2 MTL WA's and 2 patches to fix re-use "DC off" power wells. v2: Haridhar Kalvala (1): drm/i915/mtl: WA to clear RDOP clock gating Madhumitha Tolakanahalli Pradeep (1): drm/i915/mtl: Extend Wa_22011802037 to MTL A-step Matt Roper (2): drm/i915: Use separate "DC off" power

[Intel-gfx] [PATCH v2 4/4] drm/i915/mtl: WA to clear RDOP clock gating

2023-04-18 Thread Radhakrishna Sripada
From: Haridhar Kalvala Workaround implementation to clear RDOP clock gating. Bspec: 33453 Signed-off-by: Haridhar Kalvala Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_w

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Rename skl+ scaler binding bits

2023-04-18 Thread kernel test robot
Hi Ville, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Ville-Syrjala/drm-i915-Check-pipe-source-size-when-using-skl-scalers/20230419-015829 base: git://anongit.freedesktop.org/drm/drm-ti

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Scaler/pfit stuff (rev2)

2023-04-18 Thread Patchwork
== Series Details == Series: drm/i915: Scaler/pfit stuff (rev2) URL : https://patchwork.freedesktop.org/series/116661/ State : warning == Summary == Error: dim checkpatch failed 96742f02457a drm/i915: Check pipe source size when using skl+ scalers -:19: WARNING:COMMIT_LOG_USE_LINK: Unknown lin

  1   2   >