On Thu, 13 Apr 2023, Bhanuprakash Modem wrote:
> Instead of mixing display & non-display stuff together, move
> display specific clock info to new debugfs. This patch will
> create a new debugfs "i915_cdclk_info" to expose Current & Max
> cdclk and Max pixel clock frequency info.
>
> Example:
> $
On TGP, the RTC (always running) was reduced from 3MHz to 32KHz.
As a result of this change, when HPD active going low pulse or HPD IRQ
is presented and the refclk (19.2MHz) is not toggling already toggling,
there is a 60 to 90us synchronization delay which effectively reduces
the duration of the I
== Series Details ==
Series: drm/i915/mtl: Add Support for C10 phy (rev4)
URL : https://patchwork.freedesktop.org/series/116191/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13005_full -> Patchwork_116191v4_full
Summary
--
nk-link_validation.c:warning:variable-bw_needed-set-but-not-used
| |--
drivers-gpu-drm-amd-amdgpu-..-display-dc-link-link_validation.c:warning:variable-link-set-but-not-used
| `--
drivers-net-wireless-legacy-ray_cs.c:warning:strncpy-specified-bound-equals-destination-size
|-- alpha-randcon
On Fri, Apr 14, 2023 at 12:53:45PM +0530, Suraj Kandpal wrote:
> On TGP, the RTC (always running) was reduced from 3MHz to 32KHz.
> As a result of this change, when HPD active going low pulse or HPD IRQ
> is presented and the refclk (19.2MHz) is not toggling already toggling,
> there is a 60 to 90u
> -Original Message-
> From: Ville Syrjälä
> Sent: Friday, April 14, 2023 1:36 PM
> To: Kandpal, Suraj
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: PCH display HPD IRQ is not
> detected with default filter value
>
> On Fri, Apr 14, 2023 at
On Fri, 14 Apr 2023, Suraj Kandpal wrote:
> On TGP, the RTC (always running) was reduced from 3MHz to 32KHz.
> As a result of this change, when HPD active going low pulse or HPD IRQ
> is presented and the refclk (19.2MHz) is not toggling already toggling,
> there is a 60 to 90us synchronization de
== Series Details ==
Series: drm/i915/display: PCH display HPD IRQ is not detected with default
filter value
URL : https://patchwork.freedesktop.org/series/116468/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
>
> On Fri, 14 Apr 2023, Suraj Kandpal wrote:
> > On TGP, the RTC (always running) was reduced from 3MHz to 32KHz.
> > As a result of this change, when HPD active going low pulse or HPD IRQ
> > is presented and the refclk (19.2MHz) is not toggling already
> > toggling, there is a 60 to 90us synch
On Fri, 14 Apr 2023, "Kandpal, Suraj" wrote:
>>
>> On Fri, 14 Apr 2023, Suraj Kandpal wrote:
>> > On TGP, the RTC (always running) was reduced from 3MHz to 32KHz.
>> > As a result of this change, when HPD active going low pulse or HPD IRQ
>> > is presented and the refclk (19.2MHz) is not togglin
On Thu, 13 Apr 2023, Gustavo Sousa wrote:
> Quoting Jani Nikula (2023-04-13 06:47:32)
>> Follow the usual naming conventions.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
>> .../drm/i915/display/intel_display_driver.c | 16 +++---
>>
On Thu, 13 Apr 2023, Gustavo Sousa wrote:
> Quoting Jani Nikula (2023-04-13 06:47:31)
>> +/* interface for intel_display_driver.c */
>> +void intel_setup_outputs(struct drm_i915_private *i915);
>> +void intel_sanitize_watermarks(struct drm_i915_private *i915);
>
> I can't find the implementation f
>
> On Fri, 14 Apr 2023, "Kandpal, Suraj" wrote:
> >>
> >> On Fri, 14 Apr 2023, Suraj Kandpal wrote:
> >> > On TGP, the RTC (always running) was reduced from 3MHz to 32KHz.
> >> > As a result of this change, when HPD active going low pulse or HPD
> >> > IRQ is presented and the refclk (19.2MHz)
> From: Alex Williamson
> Sent: Friday, April 14, 2023 2:07 AM
>
> We had already iterated a proposal where the group-id is replaced with
> a dev-id in the existing ioctl and a flag indicates when the return
> value is a dev-id vs group-id. This had a gap that userspace cannot
> determine if a r
On Thu, 13 Apr 2023, Gustavo Sousa wrote:
> Quoting Jani Nikula (2023-04-13 06:47:31)
>> +/* interface for intel_display_driver.c */
>> +void intel_setup_outputs(struct drm_i915_private *i915);
>> +void intel_sanitize_watermarks(struct drm_i915_private *i915);
>
> I can't find the implementation f
On Thu, 13 Apr 2023, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The point of the WARN was to print something, not oops
> straight up. Currently that is precisely what happens
> if we can't find the connector for the crtc in the atomic
> state. Get the dev pointer from the atomic state instead
Hi Suraj,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-tip/drm-tip]
url:
https://github.com/intel-lab-lkp/linux/commits/Suraj-Kandpal/drm-i915-display-PCH-display-HPD-IRQ-is-not-detected-with-default-filter-value/20230414-152733
base: git
On Thu, 13 Apr 2023, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> intel_mpllb_state_verify() blows up if you call it for a
> non-modeset/fastset commit on account of the relevant
> connector not being part of the overall atomic state.
> Currently the state checker only runs for modeset/fastset
On Fri, 14 Apr 2023, Jani Nikula wrote:
> On Thu, 13 Apr 2023, Ville Syrjala wrote:
>> From: Ville Syrjälä
>>
>> The point of the WARN was to print something, not oops
>> straight up. Currently that is precisely what happens
>> if we can't find the connector for the crtc in the atomic
>> state.
This seems like an unnecessary wrapper layer. Removing it will be
helpful later.
Reviewed-by: Gustavo Sousa
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 28 +++-
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915
v2 of https://patchwork.freedesktop.org/series/116431/ with the minor
review comments addressed.
BR,
Jani.
Jani Nikula (10):
drm/i915/display: remove intel_display_commit_duplicated_state()
drm/i915/display: start high level display driver file
drm/i915/display: move intel_modeset_probe_def
The only way to truly clean up intel_display.[ch] is to move stuff out
of them until there's absolutely nothing left.
Start moving the high level display driver entry points, i.e. functions
called from top level driver code only, to a new file, which we'll call
intel_display_driver.c. The intentio
High level display functionality only called from driver top level code.
Reviewed-by: Gustavo Sousa
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 23 ---
drivers/gpu/drm/i915/display/intel_display.h | 1 -
.../drm/i915/display/intel_display_dri
Follow the usual naming conventions.
Reviewed-by: Gustavo Sousa
Reviewed-by: Lucas De Marchi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_driver.c | 2 +-
drivers/gpu/drm/i915/display/intel_display_driver.h | 2 +-
drivers/gpu/drm/i915/i915_pci.c
High level display functionality only called from driver top level code.
v2:
- Remove unnecessary declarations for intel_sanitize_watermarks() and
intel_atomic_check() (Gustavo)
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 373 +
drivers/gpu/d
Follow the usual naming conventions.
v2:
- Also rename references in comments (Gustavo)
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
.../drm/i915/display/intel_display_driver.c | 16 ++--
.../drm/i915/display/intel_display_driver.h | 14 +
Split out the display reset functionality to a separate file to
declutter intel_display.c. Rename the functions accordingly. The minor
downside is having to expose __intel_display_resume().
Reviewed-by: Gustavo Sousa
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile |
High level display functionality only called from driver top level code.
Reviewed-by: Gustavo Sousa
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 102 --
drivers/gpu/drm/i915/display/intel_display.h | 8 --
.../drm/i915/display/intel_display_d
Follow the usual naming conventions. Switch to i915 arguments and naming
while at it.
Reviewed-by: Gustavo Sousa
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_driver.c | 24 +--
.../drm/i915/display/intel_display_driver.h | 11 -
.../drm/i915/disp
Add intel_display_driver_early_probe() as the early probe call to
replace intel_init_display_hooks(). The latter will be "demoted" to
setting up hooks in intel_display.c only.
Reviewed-by: Gustavo Sousa
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 11 -
On 2023/03/15 19:47, Luca Coelho wrote:
> On Tue, 2023-03-14 at 20:21 +0900, Tetsuo Handa wrote:
>> Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a
>> macro") says, flush_scheduled_work() is dangerous and will be forbidden.
>>
>> Now that i915 is the last flush_scheduled_wo
Hi Suraj,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-tip/drm-tip]
url:
https://github.com/intel-lab-lkp/linux/commits/Suraj-Kandpal/drm-i915-display-PCH-display-HPD-IRQ-is-not-detected-with-default-filter-value/20230414-152733
base: git
On Thu, 13 Apr 2023, Tvrtko Ursulin wrote:
> On 11/04/2023 11:56, Jani Nikula wrote:
>> The goal has been to just make device info a pointer to static const
>> data, i.e. the static const structs in i915_pci.c. See [1]. However,
>> there were issues with intel_device_info_runtime_init() clearing t
Am 13.04.23 um 15:13 schrieb Daniel Vetter:
On Thu, 13 Apr 2023 at 11:46, Christian König wrote:
Am 13.04.23 um 10:48 schrieb Daniel Vetter:
On Wed, 12 Apr 2023 at 16:18, Christian König wrote:
Am 12.04.23 um 11:08 schrieb Daniel Vetter:
On Tue, 11 Apr 2023 at 15:45, Daniel Vetter wrote:
On Fri, 14 Apr 2023, Tetsuo Handa wrote:
> On 2023/03/15 19:47, Luca Coelho wrote:
>> On Tue, 2023-03-14 at 20:21 +0900, Tetsuo Handa wrote:
>>> Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a
>>> macro") says, flush_scheduled_work() is dangerous and will be forbidden.
>>>
== Series Details ==
Series: drm/i915/display: split out high level display entry points (rev2)
URL : https://patchwork.freedesktop.org/series/116431/
State : warning
== Summary ==
Error: dim checkpatch failed
77af4641cabb drm/i915/display: remove intel_display_commit_duplicated_state()
47834b
== Series Details ==
Series: drm/i915/display: split out high level display entry points (rev2)
URL : https://patchwork.freedesktop.org/series/116431/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/
Hi Tvrtko,
On Wed, Apr 12, 2023 at 04:45:13PM +0100, Tvrtko Ursulin wrote:
[snip]
> >
> > [snip]
> > > However I am unsure if disabling pagefaulting is needed or not. Thomas,
> > > Matt, being the last to touch this area, perhaps you could have a look?
> > > Because I notice we have a fallback
On 2023/04/14 19:13, Jani Nikula wrote:
> On Fri, 14 Apr 2023, Tetsuo Handa wrote:
>> On 2023/03/15 19:47, Luca Coelho wrote:
>>> On Tue, 2023-03-14 at 20:21 +0900, Tetsuo Handa wrote:
Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a
macro") says, flush_scheduled_
== Series Details ==
Series: drm/i915/mtl: Define MOCS and PAT tables for MTL (rev4)
URL : https://patchwork.freedesktop.org/series/115980/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13005 -> Patchwork_115980v4
Summary
-
On Thu, Apr 13, 2023 at 02:24:40PM -0700, Radhakrishna Sripada wrote:
> From: José Roberto de Souza
>
> The differences between MTL and TGL DP sequences are big enough to
> MTL have its own functions.
>
> Also it is much easier to follow MTL sequences against spec with
> its own functions.
>
>
> From: Tian, Kevin
> Sent: Friday, April 14, 2023 5:12 PM
>
> > From: Alex Williamson
> > Sent: Friday, April 14, 2023 2:07 AM
> >
> > We had already iterated a proposal where the group-id is replaced with
> > a dev-id in the existing ioctl and a flag indicates when the return
> > value is a de
On Thu, Apr 13, 2023 at 02:24:41PM -0700, Radhakrishna Sripada wrote:
> Like DG2, we still don't have a proper algorithm that can be used
> for calculating PHY settings, but we do have tables of register
> values for a handful of the more common link rates. Some support is
> better than none, so le
== Series Details ==
Series: drm/i915/display: split out high level display entry points (rev2)
URL : https://patchwork.freedesktop.org/series/116431/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13006 -> Patchwork_116431v2
Hi all,
Today's linux-next merge of the drm-misc tree got a conflict in:
drivers/gpu/drm/ttm/ttm_pool.c
between commit:
23baf831a32c0 ("mm, treewide: redefine MAX_ORDER sanely")
from the mm-stable tree and commit:
56e51681246e5 ("drm/ttm: revert "Reduce the number of used allocation ord
On Thu, 2023-03-02 at 18:10 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Add a mechanism by which we can enable the HPD sense for
> individual encoders.
>
> This will be used during eDP probing to figure out if
> anything is actually connected. The normal intel_hpd_irq_setup()
> thing d
On Thu, 2023-03-02 at 18:10 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> We need to untangle the mess where some SKL machines (at least)
> declare both DDI A and DDI E to be present in their VBT, and
> both using AUX A. DDI A is a ghost eDP, wheres DDI E may be a
> real DP->VGA converter
Hi Ville
Btw, I dont see the _hotplug_mask() defined anywhere..
Am I missing any patch?
BR
Vinod
On Fri, 2023-04-14 at 15:59 +0300, Govindapillai, Vinod wrote:
> On Thu, 2023-03-02 at 18:10 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Add a mechanism by which we can enable the H
Quoting Jani Nikula (2023-04-14 06:41:57)
> High level display functionality only called from driver top level code.
>
> v2:
> - Remove unnecessary declarations for intel_sanitize_watermarks() and
> intel_atomic_check() (Gustavo)
>
> Signed-off-by: Jani Nikula
Reviewed-by: Gustavo Sousa
> -
Quoting Jani Nikula (2023-04-14 06:41:58)
> Follow the usual naming conventions.
>
> v2:
> - Also rename references in comments (Gustavo)
>
> Signed-off-by: Jani Nikula
Reviewed-by: Gustavo Sousa
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> .../drm/i915/display/intel_disp
On Fri, Apr 14, 2023 at 01:23:16PM +, Govindapillai, Vinod wrote:
> Hi Ville
>
> Btw, I dont see the _hotplug_mask() defined anywhere..
> Am I missing any patch?
The previous patch in the series.
>
> BR
> Vinod
>
> On Fri, 2023-04-14 at 15:59 +0300, Govindapillai, Vinod wrote:
> > On Thu,
Hi Lionel, does this patch work for you?
On Mon, 2023-04-10 at 10:22 -0700, Ceraolo Spurio, Daniele wrote:
> On 4/6/2023 10:44 AM, Alan Previn wrote:
alan:snip
> > +/*
> > + * Query the status of PXP support in i915.
> > + *
> > + * The query can fail in the following scenarios with the listed er
Hi,
On 2023-03-28 at 13:54:27 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> So far the width of the PID column was hardcoded to six characters which
> is not enough on systems with high uptime, where PID numbers can grow
> large, and results in broken line formatting.
>
> Fix it by tr
On 2023-03-28 at 13:54:28 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> It appears we had an off by one of a kind where we were not using the full
> width of the terminal window for the global metrics section.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Kamil Konieczny
> ---
>
On 2023-03-28 at 13:54:29 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> When numeric display is selected in the interactive mode it is more
> descriptive to show client's non-normalized (by number of engines per
> class) usage. Rendering of the visual representation (bar) is kept the
>
Thank you for the review Imre and Mika for submitting the patches.
Pushed the series onto drm-tip.
-Radhakrishna(RK) Sripada
> -Original Message-
> From: Deak, Imre
> Sent: Friday, April 14, 2023 4:39 AM
> To: Sripada, Radhakrishna
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [
On Wed, Apr 12, 2023 at 12:22:51PM +0300, Jani Nikula wrote:
On Wed, 12 Apr 2023, Bhanuprakash Modem wrote:
+
static ssize_t i915_displayport_test_active_write(struct file *file,
const char __user *ubuf,
MTL features a dedicated media engine that operates on its
independent GT, requiring activation of its specific interrupt
set.
Enable the necessary interrupts in a single action when the media
engine is present, bypassing the need to iterate through all the
GTs.
Signed-off-by: Andi Shyti
---
Hi,
On Fri, 14 Apr 2023 09:11:30 +
"Tian, Kevin" wrote:
> > From: Alex Williamson
> > Sent: Friday, April 14, 2023 2:07 AM
> >
> > We had already iterated a proposal where the group-id is replaced with
> > a dev-id in the existing ioctl and a flag indicates when the return
> > value is a dev-id
On 4/14/2023 9:25 AM, Andi Shyti wrote:
MTL features a dedicated media engine that operates on its
independent GT, requiring activation of its specific interrupt
set.
Enable the necessary interrupts in a single action when the media
engine is present, bypassing the need to iterate through all
On Fri, 14 Apr 2023 11:38:24 +
"Liu, Yi L" wrote:
> > From: Tian, Kevin
> > Sent: Friday, April 14, 2023 5:12 PM
> >
> > > From: Alex Williamson
> > > Sent: Friday, April 14, 2023 2:07 AM
> > >
> > > We had already iterated a proposal where the group-id is replaced with
> > > a dev-id in
The port PLL selection needs to be up-to-date in the CRTC state of both
the primary and all secondary MST streams. The commit removing the
encoder update_prepare/complete hooks (see Fixes: below), stopped doing
this for secondary streams, fix this up.
Fixes: 0f752b2178c9 ("drm/i915: Remove the enc
== Series Details ==
Series: drm/i915/display: split out high level display entry points (rev2)
URL : https://patchwork.freedesktop.org/series/116431/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13006_full -> Patchwork_116431v2_full
==
Hi Daniele,
> > MTL features a dedicated media engine that operates on its
> > independent GT, requiring activation of its specific interrupt
> > set.
> >
> > Enable the necessary interrupts in a single action when the media
> > engine is present, bypassing the need to iterate through all the
> >
On Thu, 13 Apr 2023 15:44:12 -0700, Vinay Belgaumkar wrote:
>
> Use default of 0 where GT id is not being used.
>
> Signed-off-by: Vinay Belgaumkar
> ---
> lib/igt_pm.c | 20 ++--
> lib/igt_pm.h | 2 +-
> tests/i915/i915_pm_rps.c | 6 +++---
> 3 files cha
== Series Details ==
Series: drm/i915/gt: Mask media GuC interrupts
URL : https://patchwork.freedesktop.org/series/116493/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13008 -> Patchwork_116493v1
Summary
---
**FAILU
From: Ville Syrjälä
intel_{mpllb,c10pll}_state_verify() blows up if you call them
for a non-modeset/fastset commit on account of the relevant
connector not being part of the overall atomic state.
Currently the state checker only runs for modeset/fastset
commits, but for testing purposes it is som
== Series Details ==
Series: drm/i915/dp_mst: Fix active port PLL selection for secondary MST streams
URL : https://patchwork.freedesktop.org/series/116501/
State : warning
== Summary ==
Error: dim checkpatch failed
c712173a3b8b drm/i915/dp_mst: Fix active port PLL selection for secondary MST
On 4/14/2023 11:10 AM, Dixit, Ashutosh wrote:
On Thu, 13 Apr 2023 15:44:12 -0700, Vinay Belgaumkar wrote:
Use default of 0 where GT id is not being used.
Signed-off-by: Vinay Belgaumkar
---
lib/igt_pm.c | 20 ++--
lib/igt_pm.h | 2 +-
tests/i915/i
Borrow some subtests from xe_guc_pc. Also add per GT debugfs helpers.
v3: Review comments and add HAX patch
v4: Modify the condition for skipping the test
v5: Update the SLPC helper to per GT
v6: Review comments (Ashutosh)
Signed-off-by: Vinay Belgaumkar
Vinay Belgaumkar (4):
lib/debugfs: Add
These can be used to open per-gt debugfs files.
Reviewed-by: Ashutosh Dixit
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Vinay Belgaumkar
---
lib/igt_debugfs.c | 60 +++
lib/igt_debugfs.h | 4
2 files changed, 64 insertions(+)
diff --git a/lib
Use default of 0 where GT id is not being used.
v2: Add a helper for GT 0 (Ashutosh)
Signed-off-by: Vinay Belgaumkar
---
lib/igt_pm.c | 36 ++--
lib/igt_pm.h | 3 ++-
2 files changed, 28 insertions(+), 11 deletions(-)
diff --git a/lib/igt_pm.c b/lib/igt_pm.c
in
Validate basic api for GT freq control. Also test
interaction with GT reset. We skip rps tests with
SLPC enabled, this will re-introduce some coverage.
SLPC selftests are already covering some other workload
related scenarios.
v2: Rename test (Rodrigo)
v3: Review comments (Ashutosh)
v4: Skip when
Trying out for CI. Do not review.
Signed-off-by: Vinay Belgaumkar
---
tests/intel-ci/fast-feedback.testlist | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/intel-ci/fast-feedback.testlist
b/tests/intel-ci/fast-feedback.testlist
index d9fcb62d..653668dd 100644
--- a/tests/intel-ci/fa
== Series Details ==
Series: drm/i915/dp_mst: Fix active port PLL selection for secondary MST streams
URL : https://patchwork.freedesktop.org/series/116501/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13008 -> Patchwork_116501v1
==
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: Make intel_{mpllb,
c10pll}_state_verify() safer (rev2)
URL : https://patchwork.freedesktop.org/series/116461/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: Make intel_{mpllb,
c10pll}_state_verify() safer (rev2)
URL : https://patchwork.freedesktop.org/series/116461/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13008 -> Patchwork_116461v2
===
On Fri, 14 Apr 2023 12:16:37 -0700, Vinay Belgaumkar wrote:
>
Hi Vinay,
> Use default of 0 where GT id is not being used.
>
> v2: Add a helper for GT 0 (Ashutosh)
>
> Signed-off-by: Vinay Belgaumkar
> ---
> lib/igt_pm.c | 36 ++--
> lib/igt_pm.h | 3 ++-
> 2 fil
On Fri, 2023-04-14 at 17:21 +0300, Ville Syrjälä wrote:
> On Fri, Apr 14, 2023 at 01:23:16PM +, Govindapillai, Vinod wrote:
> > Hi Ville
> >
> > Btw, I dont see the _hotplug_mask() defined anywhere..
> > Am I missing any patch?
>
> The previous patch in the series.
Thanks! I was following th
SLPC enables use of efficient freq at init by default. It is
possible for GuC to request frequencies that are higher than
the 'software' max if user has set it lower than the efficient
level.
Scenarios/tests that require strict fixing of freq below the efficient
level will need to disable it throu
On Fri, 2023-03-03 at 18:58 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Pair each _hotplug_enables() function with
> a corresponding _hotplug_mask() function so that
> we can determine right bits to clear on a per hpd_pin basis.
> We'll need this for turning on HPD sense for a specific
== Series Details ==
Series: drm/i915/guc/slpc: Provide sysfs for efficient freq
URL : https://patchwork.freedesktop.org/series/116510/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC [M] drivers/gpu/drm/i9
On Thu, 2023-03-02 at 18:10 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Replace the hardcoded masks with just a loop over all hpd
> pins using the _hotplug_mask() functions.
>
> Signed-off-by: Ville Syrjälä
> ---
Reviewed-by: Vinod Govindapillai
> drivers/gpu/drm/i915/i915_irq.c |
SLPC enables use of efficient freq at init by default. It is
possible for GuC to request frequencies that are higher than
the 'software' max if user has set it lower than the efficient
level.
Scenarios/tests that require strict fixing of freq below the efficient
level will need to disable it throu
From: Cong Liu
This patch fixes memory leaks on error escapes in function fake_get_pages
Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist
creation")
Signed-off-by: Cong Liu
Reviewed-by: Andrzej Hajda
Reviewed-by: Andi Shyti
Signed-off-by: Andi Shyti
---
Hi,
just
== Series Details ==
Series: drm/i915/guc/slpc: Provide sysfs for efficient freq (rev2)
URL : https://patchwork.freedesktop.org/series/116510/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/guc/slpc: Provide sysfs for efficient freq (rev2)
URL : https://patchwork.freedesktop.org/series/116510/
State : warning
== Summary ==
Error: dim checkpatch failed
86d4ab64d0b0 drm/i915/guc/slpc: Provide sysfs for efficient freq
-:33: CHECK:PARENTHESIS_ALI
== Series Details ==
Series: drm/i915/guc/slpc: Provide sysfs for efficient freq (rev2)
URL : https://patchwork.freedesktop.org/series/116510/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13009 -> Patchwork_116510v2
Summar
== Series Details ==
Series: drm/i915: Fix memory leaks in i915 selftests
URL : https://patchwork.freedesktop.org/series/116513/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13009 -> Patchwork_116513v1
Summary
---
*
On Fri, 14 Apr 2023 15:34:15 -0700, Vinay Belgaumkar wrote:
>
> @@ -457,6 +458,34 @@ int intel_guc_slpc_get_max_freq(struct intel_guc_slpc
> *slpc, u32 *val)
> return ret;
> }
>
> +int intel_guc_slpc_set_ignore_eff_freq(struct intel_guc_slpc *slpc, bool val)
> +{
> + struct drm_i915_pri
From: John Harrison
GuC based register dumps in error capture logs were basically broken
for virtual engines. This can be seen in igt@gem_exec_balancer@hang:
[IGT] gem_exec_balancer: starting subtest hang
[drm] GPU HANG: ecode 12:4:e1524110, in gem_exec_balanc [6388]
[drm] GT0: GUC: No regi
From: John Harrison
Enhance the firmware table verification code to catch more potential
errors and to generally improve the code itself.
Track patch level version even on reduced version files to allow user
notification of missing bug fixes.
Detect another immediate failure case when loading G
From: John Harrison
Explain another potential firmware failure mode and early exit the
long wait if hit.
Signed-off-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 1 +
drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 6 ++
2 files changed, 7 insertions(+)
diff --
From: John Harrison
When reduced version firmware files were added (matching major
component being the only strict requirement), the minor version was
still tracked and a notification reported if it was older. However,
the patch version should really be tracked as well for the same
reasons. The K
From: John Harrison
It was noticed that duplicte entries in the firmware table could cause
an infinite loop in the firmware loading code if that entry failed to
load. Duplicate entries are a bug anyway and so should never happen.
Ensure they don't by tweaking the table validation code to reject
d
From: John Harrison
If the GuC load is taking an excessively long time, the wait loop
currently prints the GT frequency. Extend that to include the GuC
status as well so we can see if the GuC is actually making progress or
not.
Signed-off-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_
From: John Harrison
The validation of the firmware table was being done inside the code
for scanning the table for the next available firmware blob. Which is
unnecessary. Potentially, it should be a selftest. But either way, the
first step is pulling it out into a separate function that can be
ca
== Series Details ==
Series: drm/i915/guc: Fix error capture for virtual engines
URL : https://patchwork.freedesktop.org/series/116515/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13009 -> Patchwork_116515v1
Summary
-
== Series Details ==
Series: Improvements to uc firmare management
URL : https://patchwork.freedesktop.org/series/116517/
State : warning
== Summary ==
Error: dim checkpatch failed
e2f47c7391c0 drm/i915/guc: Decode another GuC load failure case
a317c98847de drm/i915/guc: Print status register
== Series Details ==
Series: Improvements to uc firmare management
URL : https://patchwork.freedesktop.org/series/116517/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
1 - 100 of 103 matches
Mail list logo
