Hi Jason,
On 4/5/23 13:41, Jason Gunthorpe wrote:
> On Tue, Apr 04, 2023 at 05:59:01PM +0200, Eric Auger wrote:
>
>>> but the hot reset shall fail as the group is not owned by the user.
>> sure it shall but I fail to understand if the reset fails or the device
>> plug is somehow delayed until the
> From: Alex Williamson
> Sent: Wednesday, April 5, 2023 11:13 PM
>
> On Wed, 5 Apr 2023 09:31:39 +
> "Liu, Yi L" wrote:
>
> > > From: Alex Williamson
> > > Sent: Wednesday, April 5, 2023 5:01 AM
> > >
> > > On Sat, 1 Apr 2023 07:44:28 -0700
> > > Yi Liu wrote:
> > >
> > > > as there are
On 31/03/2023 09:31, Jani Nikula wrote:
> On Thu, 30 Mar 2023, Andrew Morton wrote:
>> On Thu, 30 Mar 2023 21:53:03 + David Laight
>> wrote:
>>
But wouldn't all these issues be addressed by simply doing
#define is_power_of_2(n) (n != 0 && ((n & (n - 1)) == 0))
?
On Wed, 5 Apr 2023 08:01:49 +
"Liu, Yi L" wrote:
> > From: Liu, Yi L
> > Sent: Wednesday, April 5, 2023 3:55 PM
>
> > >
> > > Therefore, I think as written, the singleton dev_set hot-reset is
> > > enabled for iommufd and (unintentionally?) for the group path, while
> > > also negating a
On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 05.04.23 um 15:18 schrieb Daniel Vetter:
> > On Wed, Apr 05, 2023 at 01:16:27PM +0200, Javier Martinez Canillas wrote:
> > > Thomas Zimmermann writes:
> > >
> > > [...]
> > >
> > > >
> > > > Your comment says that i
On Wed, 05 Apr 2023, Lee Jones wrote:
> On Tue, 04 Apr 2023, Jani Nikula wrote:
>
>> On Mon, 03 Apr 2023, Lee Jones wrote:
>> > On Mon, 03 Apr 2023, Jani Nikula wrote:
>> >
>> >> On Fri, 31 Mar 2023, Lee Jones wrote:
>> >> > Fixes the following W=1 kernel build warning(s):
>> >> >
>> >> > drive
On Wed, 5 Apr 2023 14:04:51 +
"Liu, Yi L" wrote:
> Hi Eric,
>
> > From: Eric Auger
> > Sent: Wednesday, April 5, 2023 8:20 PM
> >
> > Hi Yi,
> > On 4/1/23 16:44, Yi Liu wrote:
> > > for the users that accept device fds passed from management stacks to be
> > > able to figure out the host
Daniel Vetter writes:
[...]
>>
>> but only the 'var->xres > fb->width || var->yres > fb->height' from the
>> conditions checked could be false after your __fill_var() call above.
>>
>> You should drop the 'var->bits_per_pixel > bpp', 'var->xres_virtual >
>> fb->width' and 'var->yres_virtual >
On Wed, Apr 05, 2023 at 10:25:45AM -0600, Alex Williamson wrote:
> But that kind of brings to light the question of what does the user do
> when they encounter this situation.
What does it do now when it encounters a group_id it doesn't
understand? Userspace already doesn't know if the foreign gr
On Wed, 05 Apr 2023, Jani Nikula wrote:
> On Wed, 05 Apr 2023, Lee Jones wrote:
> > On Tue, 04 Apr 2023, Jani Nikula wrote:
> >
> >> On Mon, 03 Apr 2023, Lee Jones wrote:
> >> > On Mon, 03 Apr 2023, Jani Nikula wrote:
> >> >
> >> >> On Fri, 31 Mar 2023, Lee Jones wrote:
> >> >> > Fixes the foll
On Wed, Apr 05, 2023 at 09:36:46AM -0600, Alex Williamson wrote:
> > If we don't support singletion dev_set hot-reset, noiommu devices in cdev
> > path shall fail the hot-reset if empty-fd array is provided. But we may just
> > document that empty-fd array does not work for noiommu. User should
>
On Wed, 5 Apr 2023 13:37:05 -0300
Jason Gunthorpe wrote:
> On Wed, Apr 05, 2023 at 10:25:45AM -0600, Alex Williamson wrote:
>
> > But that kind of brings to light the question of what does the user do
> > when they encounter this situation.
>
> What does it do now when it encounters a group_i
Daniel Vetter writes:
> On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote:
[...]
>> > > >/*
>> > > > * WARNING: Apparently we must kick fbdev drivers before vgacon,
>> > > > * otherwise the vga fbdev driver falls over.
>> > > > */
>> > > >
On Wed, 5 Apr 2023 14:00:00 +
"Liu, Yi L" wrote:
> Hi Eric,
>
> > From: Eric Auger
> > Sent: Wednesday, April 5, 2023 9:46 PM
> >
> > Hi Yi,
> >
> > On 4/1/23 17:18, Yi Liu wrote:
> > > This gives notes for userspace applications on device cdev usage.
> > >
> > > Reviewed-by: Kevin Tian
== Series Details ==
Series: Add hwmon support for dgfx selftests (rev9)
URL : https://patchwork.freedesktop.org/series/109850/
State : warning
== Summary ==
Error: dim checkpatch failed
7b4acee0a7ff drm/i915/selftests: Rename librapl library to libpower
Traceback (most recent call last):
Fi
== Series Details ==
Series: Add hwmon support for dgfx selftests (rev9)
URL : https://patchwork.freedesktop.org/series/109850/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+./arch/x86/include/asm/bitop
== Series Details ==
Series: Add hwmon support for dgfx selftests (rev9)
URL : https://patchwork.freedesktop.org/series/109850/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12972 -> Patchwork_109850v9
Summary
---
**
On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas
wrote:
>
> Daniel Vetter writes:
>
> > On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote:
>
> [...]
>
> >> > > >/*
> >> > > > * WARNING: Apparently we must kick fbdev drivers before
> >> > > > vgacon,
> >> > >
On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote:
> Daniel Vetter writes:
>
> [...]
>
> >>
> >> but only the 'var->xres > fb->width || var->yres > fb->height' from the
> >> conditions checked could be false after your __fill_var() call above.
> >>
> >> You should drop t
On Wed, Apr 05, 2023 at 10:52:15AM -0600, Alex Williamson wrote:
> On Wed, 5 Apr 2023 13:37:05 -0300
> Jason Gunthorpe wrote:
>
> > On Wed, Apr 05, 2023 at 10:25:45AM -0600, Alex Williamson wrote:
> >
> > > But that kind of brings to light the question of what does the user do
> > > when they en
Daniel Vetter writes:
> On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote:
>> Daniel Vetter writes:
[...]
>> >
>> > The __fill_var is after this. I'm honestly not sure what the exact
>>
>> Ah, your patch adds it after that indeed. Please ignore my comment then.
>
> So r
Daniel Vetter writes:
> On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas
> wrote:
>>
>> Daniel Vetter writes:
[...]
>>
>> Yeah, agreed that if vga_remove_vgacon() isn't enough and another helper
>> is needed then starts to get a little silly. Maybe one option is to add a
>> 3rd param to
On Wed, Apr 5, 2023 at 7:15 PM Daniel Vetter wrote:
>
> On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas
> wrote:
> >
> > Daniel Vetter writes:
> >
> > > On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote:
> >
> > [...]
> >
> > >> > > >/*
> > >> > > > * WARNIN
On Tue, Jan 31, 2023 at 3:33 AM Tvrtko Ursulin
wrote:
>
> From: Tvrtko Ursulin
>
> Rudimentary vendor agnostic example of how lib_igt_drm_clients can be used
> to display a sorted by card and usage list of processes using GPUs.
>
> Borrows a bit of code from intel_gpu_top but for now omits the fa
On 4/5/23 18:25, Alex Williamson wrote:
> On Wed, 5 Apr 2023 14:04:51 +
> "Liu, Yi L" wrote:
>
>> Hi Eric,
>>
>>> From: Eric Auger
>>> Sent: Wednesday, April 5, 2023 8:20 PM
>>>
>>> Hi Yi,
>>> On 4/1/23 16:44, Yi Liu wrote:
for the users that accept device fds passed from management
Hi Yi,
On 4/1/23 17:18, Yi Liu wrote:
> This makes the vfio file kAPIs to accept vfio device files, also a
> preparation for vfio device cdev support.
>
> For the kvm set with vfio device file, kvm pointer is stored in struct
> vfio_device_file, and use kvm_ref_lock to protect kvm set and kvm
> po
Hi Dave and Daniel,
here's this week's PR for drm-misc-fixes. As requested, it comes
a day earlier than usual due to Easter holidays.
Best regards
Thomas
drm-misc-fixes-2023-04-05:
Short summary of fixes pull:
* ivpu: DMA fence and suspend fixes
* nouveau: Color-depth fixes
* panfrost: Fix m
== Series Details ==
Series: Add hwmon support for dgfx selftests
URL : https://patchwork.freedesktop.org/series/116136/
State : warning
== Summary ==
Error: dim checkpatch failed
083f9b0b94c1 drm/i915/selftests: Rename librapl library to libpower
Traceback (most recent call last):
File "scr
== Series Details ==
Series: Add hwmon support for dgfx selftests
URL : https://patchwork.freedesktop.org/series/116136/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+./arch/x86/include/asm/bitops.h:117
== Series Details ==
Series: Add hwmon support for dgfx selftests
URL : https://patchwork.freedesktop.org/series/116136/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12973 -> Patchwork_116136v1
Summary
---
**SUCCESS
On Wed, 5 Apr 2023 14:23:43 -0300
Jason Gunthorpe wrote:
> On Wed, Apr 05, 2023 at 10:52:15AM -0600, Alex Williamson wrote:
> > On Wed, 5 Apr 2023 13:37:05 -0300
> > Jason Gunthorpe wrote:
> >
> > > On Wed, Apr 05, 2023 at 10:25:45AM -0600, Alex Williamson wrote:
> > >
> > > > But that kin
On Wed, Apr 05, 2023 at 08:28:55PM +0200, Thomas Zimmermann wrote:
> Hi Dave and Daniel,
>
> here's this week's PR for drm-misc-fixes. As requested, it comes
> a day earlier than usual due to Easter holidays.
>
> Best regards
> Thomas
>
> drm-misc-fixes-2023-04-05:
> Short summary of fixes pull:
On Wed, 5 Apr 2023 12:56:21 -0600
Alex Williamson wrote:
> On Wed, 5 Apr 2023 14:23:43 -0300
> Jason Gunthorpe wrote:
>
> > On Wed, Apr 05, 2023 at 10:52:15AM -0600, Alex Williamson wrote:
> > > On Wed, 5 Apr 2023 13:37:05 -0300
> > > Jason Gunthorpe wrote:
> > >
> > > > On Wed, Apr 05,
On Wed, Apr 05, 2023 at 12:56:21PM -0600, Alex Williamson wrote:
> Usability needs to be a consideration as well. An interface where the
> result is effectively arbitrary from a user perspective because the
> kernel is solely focused on whether the operation is allowed,
> evaluating constraints th
== Series Details ==
Series: drm/i915/display: Increase AUX timeout for Type-C (rev2)
URL : https://patchwork.freedesktop.org/series/116010/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12973 -> Patchwork_116010v2
Summary
On Wed, 05 Apr 2023 06:57:42 -0700, Rodrigo Vivi wrote:
>
Hi Rodrigo,
> On Fri, Mar 31, 2023 at 08:11:29PM -0700, Dixit, Ashutosh wrote:
> > On Fri, 31 Mar 2023 19:00:49 -0700, Vinay Belgaumkar wrote:
> > >
> >
> > Hi Vinay,
> >
> > > @@ -478,20 +507,15 @@ int intel_guc_slpc_set_min_freq(struct
On Wed, 5 Apr 2023 16:21:09 -0300
Jason Gunthorpe wrote:
> On Wed, Apr 05, 2023 at 12:56:21PM -0600, Alex Williamson wrote:
> > Usability needs to be a consideration as well. An interface where the
> > result is effectively arbitrary from a user perspective because the
> > kernel is solely focus
On Wed, Apr 05, 2023 at 12:42:30PM -0700, Dixit, Ashutosh wrote:
> On Wed, 05 Apr 2023 06:57:42 -0700, Rodrigo Vivi wrote:
> >
>
> Hi Rodrigo,
>
> > On Fri, Mar 31, 2023 at 08:11:29PM -0700, Dixit, Ashutosh wrote:
> > > On Fri, 31 Mar 2023 19:00:49 -0700, Vinay Belgaumkar wrote:
> > > >
> > >
> >
== Series Details ==
Series: series starting with [1/2] drm/i915/tc: demote a kernel-doc comment to
a regular comment
URL : https://patchwork.freedesktop.org/series/116144/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be check
== Series Details ==
Series: series starting with [1/2] drm/i915/tc: demote a kernel-doc comment to
a regular comment
URL : https://patchwork.freedesktop.org/series/116144/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12974 -> Patchwork_116144v1
=
On 2023-04-05 00:45:24, Lionel Landwerlin wrote:
> On 04/04/2023 19:04, Yang, Fei wrote:
> >> Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache at
> >> BO creation
> >>
> >> Just like the protected content uAPI, there is no way for userspace to tell
> >> this feature is availa
On Wed, Apr 05, 2023 at 07:42:08PM +0200, Javier Martinez Canillas wrote:
> Daniel Vetter writes:
>
> > On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote:
> >> Daniel Vetter writes:
>
> [...]
>
> >> >
> >> > The __fill_var is after this. I'm honestly not sure what the ex
== Series Details ==
Series: i915: Correct description of default value for enable_psr2_sel_fetch
URL : https://patchwork.freedesktop.org/series/116150/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12974 -> Patchwork_116150v1
==
Daniel Vetter writes:
> On Wed, Apr 05, 2023 at 07:42:08PM +0200, Javier Martinez Canillas wrote:
[...]
>> >> Ah, your patch adds it after that indeed. Please ignore my comment then.
>> >
>> > So rb: you?
>> >
>>
>> Yes, I already provided it in my previous email and has been picked by
>> patc
On 4/3/2023 17:34, Matt Roper wrote:
On Mon, Apr 03, 2023 at 02:33:34PM -0700, john.c.harri...@intel.com wrote:
From: John Harrison
A pair of pre-Gen12 registers were being included in the Gen12 capture
list. GuC was rejecting those as being invalid and logging errors
about them. So, stop doin
== Series Details ==
Series: drm/atomic-helper: Don't set deadline for modesets (rev2)
URL : https://patchwork.freedesktop.org/series/116140/
State : warning
== Summary ==
Error: dim checkpatch failed
0989a3e3ca58 drm/atomic-helper: Don't set deadline for modesets
-:29: WARNING:BAD_REPORTED_BY
== Series Details ==
Series: drm/atomic-helper: Don't set deadline for modesets (rev2)
URL : https://patchwork.freedesktop.org/series/116140/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12974 -> Patchwork_116140v2
Summary
On Wed, Apr 05, 2023 at 02:13:31PM -0700, John Harrison wrote:
> On 4/3/2023 17:34, Matt Roper wrote:
> > On Mon, Apr 03, 2023 at 02:33:34PM -0700, john.c.harri...@intel.com wrote:
> > > From: John Harrison
> > >
> > > A pair of pre-Gen12 registers were being included in the Gen12 capture
> > > l
>Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache at BO
>creation
>
>On 04/04/2023 19:04, Yang, Fei wrote:
>>> Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set
>>> cache at BO creation
>>>
>>> On 01/04/2023 09:38, fei.y...@intel.com wrote:
From: Fei Yang
On Wed, Apr 05, 2023 at 01:49:45PM -0600, Alex Williamson wrote:
> > > QEMU can make a policy decision today because the kernel provides a
> > > sufficiently reliable interface, ie. based on the set of owned groups, a
> > > hot-reset is all but guaranteed to work.
> >
> > And we don't change
On Tue, 04 Apr 2023 23:59:30 -0700, Riana Tauro wrote:
>
Hi Riana,
> Hwmon reads the energy/power consumed by discrete soc,
> i.e. energy/power includes the power drawn from non-gfx discrete
> components
>
> This test uses the power consumed by GT to validate RC6
> power consumption.
> Skip compa
In preparation for follow-on patches, refactor hwm_power_max_write to take
hwmon_lock and runtime pm wakeref at start of the function and release them
at the end, therefore acquiring these just once each.
Signed-off-by: Ashutosh Dixit
---
drivers/gpu/drm/i915/i915_hwmon.c | 28 +++---
On dGfx, the PL1 power limit being enabled and set to a low value results
in a low GPU operating freq. It also negates the freq raise operation which
is done before GuC firmware load. As a result GuC firmware load can time
out. Such timeouts were seen in the GL #8062 bug below (where the PL1 power
Instead of erroring out when GuC reset is in progress, block waiting for
GuC reset to complete which is a more reasonable uapi behavior.
Signed-off-by: Ashutosh Dixit
---
drivers/gpu/drm/i915/i915_hwmon.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/
Split the v3 patch into 3 patches for easier review, can squash later if needed.
Cc: Rodrigo Vivi
Cc: Tvrtko Ursulin
Ashutosh Dixit (3):
drm/i915/hwmon: Get mutex and rpm ref just once in hwm_power_max_write
drm/i915/guc: Disable PL1 power limit when loading GuC firmware
drm/i915/hwmon: B
On Mon, 27 Mar 2023 10:47:25 -0700, Rodrigo Vivi wrote:
>
Hi Rodrigo,
Sorry for the delay, I got pulled away into a couple of other things and
could only now get back to this.
>
> +Daniel
>
> On Mon, Mar 27, 2023 at 09:58:52AM -0700, Dixit, Ashutosh wrote:
> > On Sun, 26 Mar 2023 04:52:59 -0700,
On Tue, 28 Mar 2023 02:14:42 -0700, Tvrtko Ursulin wrote:
>
Hi Tvrtko,
> On 27/03/2023 18:47, Rodrigo Vivi wrote:
> >
> > +Daniel
> >
> > On Mon, Mar 27, 2023 at 09:58:52AM -0700, Dixit, Ashutosh wrote:
> >> On Sun, 26 Mar 2023 04:52:59 -0700, Rodrigo Vivi wrote:
> >>>
> >>
> >> Hi Rodrigo,
> >>
On Wed, 05 Apr 2023 13:12:29 -0700, Rodrigo Vivi wrote:
>
> On Wed, Apr 05, 2023 at 12:42:30PM -0700, Dixit, Ashutosh wrote:
> > On Wed, 05 Apr 2023 06:57:42 -0700, Rodrigo Vivi wrote:
> > >
Hi Rodrigo,
> >
> > > On Fri, Mar 31, 2023 at 08:11:29PM -0700, Dixit, Ashutosh wrote:
> > > > On Fri, 31
== Series Details ==
Series: drm/i915/guc: Disable PL1 power limit when loading GuC firmware
URL : https://patchwork.freedesktop.org/series/116172/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86
Hi Eric,
> From: Eric Auger
> Sent: Thursday, April 6, 2023 1:58 AM
[...]
> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
> index 25432ef213ee..5a34364e3b94 100644
> --- a/include/uapi/linux/vfio.h
> +++ b/include/uapi/linux/vfio.h
> @@ -650,11 +650,3
== Series Details ==
Series: drm/i915/guc: Disable PL1 power limit when loading GuC firmware
URL : https://patchwork.freedesktop.org/series/116172/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12976 -> Patchwork_116172v1
S
On Wed, Apr 05, 2023 at 06:50:22AM -0700, Rob Clark wrote:
> On Wed, Apr 5, 2023 at 6:31 AM Daniel Vetter wrote:
> >
> > If the crtc is being switched on or off then the semantics of
> > computing the timestampe of the next vblank is somewhat ill-defined.
> > And indeed, the code splats with a war
>
alan:snip
> > @@ -140,10 +141,15 @@ static void pxp_init_full(struct intel_pxp *pxp)
> > if (ret)
> > return;
> >
> > - if (HAS_ENGINE(pxp->ctrl_gt, GSC0))
> > + if (HAS_ENGINE(pxp->ctrl_gt, GSC0)) {
> > ret = intel_pxp_gsccs_init(pxp);
> > - else
> > +
>
alan:snip
> > void intel_pxp_irq_enable(struct intel_pxp *pxp)
> > {
> > - struct intel_gt *gt = pxp->ctrl_gt;
> > + struct intel_gt *gt = intel_pxp_get_irq_gt(pxp);
>
> in this function we use the gt for:
>
> 1 - the lock: see above about this
>
> 2 - gen11_gt_reset_one_iir(): this
> On Mon, Apr 03, 2023 at 07:39:37PM +, Yang, Fei wrote:
>>> Subject: Re: [PATCH 5/7] drm/i915: use pat_index instead of cache_level
>>>
>>> On Mon, Apr 03, 2023 at 04:57:21PM +, Yang, Fei wrote:
> Subject: Re: [PATCH 5/7] drm/i915: use pat_index instead of
> cache_level
>
>
Hi Alex,
> From: Alex Williamson
> Sent: Thursday, April 6, 2023 3:50 AM
>
> On Wed, 5 Apr 2023 16:21:09 -0300
> Jason Gunthorpe wrote:
>
> > On Wed, Apr 05, 2023 at 12:56:21PM -0600, Alex Williamson wrote:
> > > Usability needs to be a consideration as well. An interface where the
> > > resu
101 - 166 of 166 matches
Mail list logo
