Re: [Intel-gfx] LOOKS GOOD: Possible regression in drm/i915 driver: memleak

2022-12-22 Thread Tvrtko Ursulin
On 22/12/2022 00:12, Mirsad Goran Todorovac wrote: On 20. 12. 2022. 20:34, Mirsad Todorovac wrote: On 12/20/22 16:52, Tvrtko Ursulin wrote: On 20/12/2022 15:22, srinivas pandruvada wrote: +Added DRM mailing list and maintainers On Tue, 2022-12-20 at 15:33 +0100, Mirsad Todorovac wrote: Hi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm, fbdev: Remove apertures structure and FBINFO_MISC_FIRMWARE (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: drm, fbdev: Remove apertures structure and FBINFO_MISC_FIRMWARE (rev2) URL : https://patchwork.freedesktop.org/series/112069/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_112069v2

[Intel-gfx] [PATCH 4/4] fixup! drm/i915: Remove platform comments from workarounds

2022-12-22 Thread Lucas De Marchi
--- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- drivers/gpu/drm/i915/i915_perf.c | 4 ++-- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- drivers/gpu/drm/i915/intel_uncore.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/in

[Intel-gfx] [PATCH 3/4] drm/i915: Remove platform comments from workarounds

2022-12-22 Thread Lucas De Marchi
The comments are redundant to the checks being done to apply the workarounds and very often get outdated as workarounds need to be extended to new platforms or steppings. Remove them altogether with the following matches (platforms extracted from intel_workarounds.c): find drivers/gpu/drm

[Intel-gfx] [PATCH 0/4] Remove platform acronyms and stepping from comments

2022-12-22 Thread Lucas De Marchi
Cleanup gt and display wrt the comments for the workarounds. Rationale is in the patch itself. I'm providing the patches, as generated by the commands in the commit message, with a fixup on top to remove false positives. The intention for when this is ready to be applied is to squash the fixup: it

[Intel-gfx] [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-22 Thread Lucas De Marchi
The comments are redundant to the checks being done to apply the workarounds and very often get outdated as workarounds need to be extended to new platforms or steppings. Remove them altogether with the following matches (platforms extracted from intel_workarounds.c): find drivers/gpu/drm

[Intel-gfx] [PATCH 2/4] fixup! drm/i915/gt: Remove platform comments from workarounds

2022-12-22 Thread Lucas De Marchi
--- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 2 +- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +- drivers/gpu/drm/i915/gt/intel_reset.c| 2 +- drivers/gpu/drm/i915/gt/intel_ring_submission.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_workarounds.c

Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes

2022-12-22 Thread Ville Syrjälä
On Fri, Dec 16, 2022 at 03:30:13PM +, Andrew Cooper wrote: > On 08/12/2022 1:55 pm, Marek Marczykowski-Górecki wrote: > > Hi, > > > > There is an issue with i915 on Xen PV (dom0). The end result is a lot of > > glitches, like here: https://openqa.qubes-os.org/tests/54748#step/startup/8 > > (thi

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display/vlv: fix pixel overlap register update (rev3)

2022-12-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/vlv: fix pixel overlap register update (rev3) URL : https://patchwork.freedesktop.org/series/112045/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_112045v3

[Intel-gfx] ✓ Fi.CI.IGT: success for Fixes for intel fb helper

2022-12-22 Thread Patchwork
== Series Details == Series: Fixes for intel fb helper URL : https://patchwork.freedesktop.org/series/112133/ State : success == Summary == CI Bug Log - changes from CI_DRM_12520_full -> Patchwork_112133v1_full Summary --- **SUCCESS*

Re: [Intel-gfx] [PATCH] drm/i915: Enable XE_HP 4Tile support

2022-12-22 Thread Juha-Pekka Heikkila
On 21.12.2022 17.35, Jonathan Cavitt wrote: Add .has_4tile tag to XE_HP_FEATURES set. Remove duplicate entry from DG2_FEATURES. Signed-off-by: Jonathan Cavitt Cc: Bommu Krishnaiah Cc: Roper Matthew D Cc: Kempczynski Zbigniew Cc: Telukuntla Sreedhar Acked-by: Matt Roper --- drivers/gpu/dr

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/color: Add function to load degamma LUT in MTL

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915/color: Add function to load degamma LUT in MTL URL : https://patchwork.freedesktop.org/series/112135/ State : success == Summary == CI Bug Log - changes from CI_DRM_12520_full -> Patchwork_112135v1_full

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reset twice

2022-12-22 Thread Gwan-gyeong Mun
On 12/15/22 10:07 PM, Rodrigo Vivi wrote: On Wed, Dec 14, 2022 at 11:37:19PM +0100, Andi Shyti wrote: Hi Rodrigo, On Tue, Dec 13, 2022 at 01:18:48PM +, Vivi, Rodrigo wrote: On Tue, 2022-12-13 at 00:08 +0100, Andi Shyti wrote: Hi Rodrigo, On Mon, Dec 12, 2022 at 11:55:10AM -0500, Rodri

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: series starting with [v3,1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version (rev2) URL : https://patchwork.freedesktop.org/series/112121/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_112121v2 ===

Re: [Intel-gfx] [PATCH] treewide: Convert del_timer*() to timer_shutdown*()

2022-12-22 Thread Paolo Abeni
On Tue, 2022-12-20 at 13:45 -0500, Steven Rostedt wrote: > [ > Linus, > > I ran the script against your latest master branch: > commit b6bb9676f2165d518b35ba3bea5f1fcfc0d969bf > > As the timer_shutdown*() code is now in your tree, I figured > we can start doing the conversions.

[Intel-gfx] [PATCH i-g-t] tests/gem_mmap_gtt: add test mmap_closed_bo

2022-12-22 Thread Tvrtko Ursulin
From: Chuansheng Liu Recently we figured out one memory leak in i915 driver when running below alike test: create_bo gem_mmap_gtt bo gem_mmap_gtt bo twice close_bo then the memory leak is detected. More details can be referred in https://patchwork.freedesktop.org/patch/475802/?series=100532&rev

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-22 Thread Tvrtko Ursulin
On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to the checks being done to apply the workarounds and very often get outdated as workarounds need to be extended to new platforms or steppings. Remove them altogether with the following matches (platforms extracted from int

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Implement Wa_14015648006 (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915/display: Implement Wa_14015648006 (rev2) URL : https://patchwork.freedesktop.org/series/103518/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521_full -> Patchwork_103518v2_full Summa

[Intel-gfx] [PATCH] drm/i915: Fix same object multiple mmap memory leak

2022-12-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This is the fix proposed by Chuansheng Liu to close a memory leak caused by refactoring done in 786555987207 ("drm/i915/gem: Store mmap_offsets in an rbtree rather than a plain list"). Original commit text from Liu was this: > > The below memory leak information is caught:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes for various UC related issues (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: Fixes for various UC related issues (rev2) URL : https://patchwork.freedesktop.org/series/112080/ State : warning == Summary == Error: dim checkpatch failed bf35e0a177be drm/i915/guc: Fix missing return code checks in submission init 4c3490ae03f6 drm/i915/guc: Fix

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixes for various UC related issues (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: Fixes for various UC related issues (rev2) URL : https://patchwork.freedesktop.org/series/112080/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes for various UC related issues (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: Fixes for various UC related issues (rev2) URL : https://patchwork.freedesktop.org/series/112080/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_112080v2 Summary --- **S

[Intel-gfx] [PATCH 00/19] Introduce __xchg, non-atomic xchg

2022-12-22 Thread Andrzej Hajda
Hi all, I hope there will be place for such tiny helper in kernel. Quick cocci analyze shows there is probably few thousands places where it could be useful. I am not sure who is good person to review/ack such patches, so I've used my intuition to construct to/cc lists, sorry for mistakes. This is

[Intel-gfx] [PATCH 01/19] arch/alpha: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/alpha/include/asm/cmpxchg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/alpha/include/asm/cmpxchg.h b/arch/alpha/include/asm/cmpxchg.h index 6e0a850aa9d38c..40e8159ef6e794 1006

[Intel-gfx] [PATCH 02/19] arch/arc: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/arc/include/asm/cmpxchg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arc/include/asm/cmpxchg.h b/arch/arc/include/asm/cmpxchg.h index c5b544a5fe8106..e138fde067dea5 100644 --- a

[Intel-gfx] [PATCH 03/19] arch/arm: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/arm/include/asm/cmpxchg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm/cmpxchg.h b/arch/arm/include/asm/cmpxchg.h index 4dfe538dfc689b..6953fc05a97886 100644 --- a

[Intel-gfx] [PATCH 04/19] arch/arm64: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/arm64/include/asm/cmpxchg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/include/asm/cmpxchg.h b/arch/arm64/include/asm/cmpxchg.h index 497acf134d9923..3a36ba58e8c2ef 100644

[Intel-gfx] [PATCH 05/19] arch/hexagon: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/hexagon/include/asm/cmpxchg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/hexagon/include/asm/cmpxchg.h b/arch/hexagon/include/asm/cmpxchg.h index cdb705e1496af8..92dc5e5f836f

[Intel-gfx] [PATCH 06/19] arch/ia64: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/ia64/include/asm/cmpxchg.h | 2 +- arch/ia64/include/uapi/asm/cmpxchg.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/ia64/include/asm/cmpxchg.h b/arch/ia64/include/asm/cmpxc

[Intel-gfx] [PATCH 07/19] arch/loongarch: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/loongarch/include/asm/cmpxchg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/loongarch/include/asm/cmpxchg.h b/arch/loongarch/include/asm/cmpxchg.h index ecfa6cf79806e6..979fde61

[Intel-gfx] [PATCH 09/19] arch/mips: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/mips/include/asm/cmpxchg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/include/asm/cmpxchg.h b/arch/mips/include/asm/cmpxchg.h index 7ec9493b28614f..feed343ad483a9 100644 --

[Intel-gfx] [PATCH 08/19] arch/m68k: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/m68k/include/asm/cmpxchg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/m68k/include/asm/cmpxchg.h b/arch/m68k/include/asm/cmpxchg.h index 6cf464cdab067e..d7f3de9c5d6f79 100644

[Intel-gfx] [PATCH 10/19] arch/openrisc: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/openrisc/include/asm/cmpxchg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/openrisc/include/asm/cmpxchg.h b/arch/openrisc/include/asm/cmpxchg.h index 79fd16162ccb6d..5725e22e106

[Intel-gfx] [PATCH 13/19] arch/riscv: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/riscv/include/asm/atomic.h | 2 +- arch/riscv/include/asm/cmpxchg.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/riscv/include/asm/atomic.h b/arch/riscv/include/asm/atomic.h ind

[Intel-gfx] [PATCH 11/19] arch/parisc: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/parisc/include/asm/cmpxchg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/parisc/include/asm/cmpxchg.h b/arch/parisc/include/asm/cmpxchg.h index 5f274be105671e..c1d776bb16b4ed 10

[Intel-gfx] [PATCH 12/19] arch/powerpc: correct logged function names in xchg helpers

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/powerpc/include/asm/cmpxchg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/include/asm/cmpxchg.h b/arch/powerpc/include/asm/cmpxchg.h index 05f246c0e36eb3..b5624c9fe09bf7

[Intel-gfx] [PATCH 14/19] arch/s390: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/s390/include/asm/cmpxchg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/include/asm/cmpxchg.h b/arch/s390/include/asm/cmpxchg.h index 84c3f0d576c5b1..efc16f4aac8643 100644 --

[Intel-gfx] [PATCH 15/19] arch/sh: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/sh/include/asm/cmpxchg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/sh/include/asm/cmpxchg.h b/arch/sh/include/asm/cmpxchg.h index 0ed9b3f4a57796..288f6f38d98fb4 100644 --- a/ar

[Intel-gfx] [PATCH 16/19] arch/sparc: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/sparc/include/asm/cmpxchg_32.h | 4 ++-- arch/sparc/include/asm/cmpxchg_64.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/sparc/include/asm/cmpxchg_32.h b/arch/sparc/include/asm

[Intel-gfx] [PATCH 17/19] arch/xtensa: rename internal name __xchg to __arch_xchg

2022-12-22 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda --- arch/xtensa/include/asm/cmpxchg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/xtensa/include/asm/cmpxchg.h b/arch/xtensa/include/asm/cmpxchg.h index eb87810357ad88..675a11ea8de76b 10

[Intel-gfx] [PATCH 18/19] linux/include: add non-atomic version of xchg

2022-12-22 Thread Andrzej Hajda
The pattern of setting variable with new value and returning old one is very common in kernel. Usually atomicity of the operation is not required, so xchg seems to be suboptimal and confusing in such cases. Signed-off-by: Andrzej Hajda --- include/linux/non-atomic/xchg.h | 19 +++

[Intel-gfx] [PATCH 19/19] drm/i915/gt: use __xchg instead of internal helper

2022-12-22 Thread Andrzej Hajda
Prefer core helper if available. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 2 +- drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_ggtt.c

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: Make firmware loading backwards-compatible (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Make firmware loading backwards-compatible (rev2) URL : https://patchwork.freedesktop.org/series/112116/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521_full -> Patchwork_112116v2_full =

[Intel-gfx] [PATCH 0/5] drm/i915: vblank stuff

2022-12-22 Thread Ville Syrjala
From: Ville Syrjälä A bunch of stuff related to vblank length/start. Ville Syrjälä (5): drm/i915/vrr: Fix "window2" handling drm/i915/psr: Fix the delayed vblank w/a drm/i915/psr: Add the latency reporting chicken bit for pipe D drm/i915: Extract skl_wm_latency() drm/i915: Reject wm le

[Intel-gfx] [PATCH 2/5] drm/i915/psr: Fix the delayed vblank w/a

2022-12-22 Thread Ville Syrjala
From: Ville Syrjälä Fix the code to correctly determine whether delayed vblank is used or not. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_psr.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/driv

[Intel-gfx] [PATCH 1/5] drm/i915/vrr: Fix "window2" handling

2022-12-22 Thread Ville Syrjala
From: Ville Syrjälä The "window2" delay is just the difference of vactive (undelayed vblank) vs. vblank_start (delayed vblank). Just use vblank_start during the VRR calculations so that things work correctly regardless of whether delayed vblank is used or not. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH 3/5] drm/i915/psr: Add the latency reporting chicken bit for pipe D

2022-12-22 Thread Ville Syrjala
From: Ville Syrjälä Pipe D has a chicken bit for the latency reporting override thing as well. Add it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_psr.c | 2 ++ drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH 4/5] drm/i915: Extract skl_wm_latency()

2022-12-22 Thread Ville Syrjala
From: Ville Syrjälä Extract the skl+ wm latnecy determination into a small helper so that everyone has the same idea what the latency should be. This introduces a slight functional change in that skl_cursor_allocation() will now start to account for the extra 4 usec that the kbk/cfl/cml IPC w/a

[Intel-gfx] [PATCH 5/5] drm/i915: Reject wm levels that exceed vblank time

2022-12-22 Thread Ville Syrjala
From: Ville Syrjälä The pipe needs a certain amount of time during vblank to prefill sufficiently. If the vblank is too short the relevant watermark level must be disabled. Start implementing the necessary calculations to check this. Scaler and DSC prefill are left out for now as handling those

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/gvt: Replace one-element array with flexible-array member

2022-12-22 Thread Patchwork
== Series Details == Series: i915/gvt: Replace one-element array with flexible-array member URL : https://patchwork.freedesktop.org/series/112150/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_112150v1 Su

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev8)

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev8) URL : https://patchwork.freedesktop.org/series/108732/ State : warning == Summary == Error: dim checkpatch failed c4caf92615d0 drm/i915/gvt: fix double free bug in split_2MB_gtt_entry -:73: CHECK:OPEN_

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Enable XE_HP 4Tile support

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915: Enable XE_HP 4Tile support URL : https://patchwork.freedesktop.org/series/112143/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521_full -> Patchwork_112143v1_full Summary ---

Re: [Intel-gfx] [PATCH 18/19] linux/include: add non-atomic version of xchg

2022-12-22 Thread Andy Shevchenko
On Thu, Dec 22, 2022 at 12:46:34PM +0100, Andrzej Hajda wrote: > The pattern of setting variable with new value and returning old > one is very common in kernel. Usually atomicity of the operation > is not required, so xchg seems to be suboptimal and confusing in > such cases. FWIW, Reviewed-by: A

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev8)

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev8) URL : https://patchwork.freedesktop.org/series/108732/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_108732v8 S

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Fix missing return code checks in submission init

2022-12-22 Thread Ceraolo Spurio, Daniele
On 12/21/2022 8:30 PM, john.c.harri...@intel.com wrote: From: John Harrison The CI results for the 'fast request' patch set (enables error return codes for fire-and-forget H2G messages) hit an issue with the KMD sending context submission requests on an invalid context. That was caused by a

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Fix a static analysis warning

2022-12-22 Thread Ceraolo Spurio, Daniele
Reviewed-by: Daniele Ceraolo Spurio Daniele On 12/21/2022 8:30 PM, john.c.harri...@intel.com wrote: From: John Harrison A static analyser was complaining about not checking for null pointers. However, the location of the complaint can only be reached in the first place if said pointer is non

[Intel-gfx] ✓ Fi.CI.IGT: success for drm, fbdev: Remove apertures structure and FBINFO_MISC_FIRMWARE (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: drm, fbdev: Remove apertures structure and FBINFO_MISC_FIRMWARE (rev2) URL : https://patchwork.freedesktop.org/series/112069/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521_full -> Patchwork_112069v2_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Only select I2C_ALGOBIT for drivers that actually need it (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: drm: Only select I2C_ALGOBIT for drivers that actually need it (rev2) URL : https://patchwork.freedesktop.org/series/90163/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_90163v2 ===

[Intel-gfx] [PATCH v2 1/2] drm/i915/display/core: use intel_de_rmw if possible

2022-12-22 Thread Andrzej Hajda
The helper makes the code more compact and readable. Signed-off-by: Andrzej Hajda --- v2: fixed indentation --- drivers/gpu/drm/i915/display/intel_display.c | 22 +-- .../drm/i915/display/intel_display_power.c| 49 ++ .../i915/display/intel_display_power_well.c | 82 +++-- driv

[Intel-gfx] [PATCH v2 2/2] drm/i915/display/misc: use intel_de_rmw if possible

2022-12-22 Thread Andrzej Hajda
The helper makes the code more compact and readable. Signed-off-by: Andrzej Hajda --- v2: fixed indentation --- drivers/gpu/drm/i915/display/g4x_dp.c | 12 ++-- drivers/gpu/drm/i915/display/g4x_hdmi.c | 8 +-- .../gpu/drm/i915/display/intel_backlight.c| 59 +++

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reset twice

2022-12-22 Thread Andi Shyti
Hi GG, > > > > > > >  drivers/gpu/drm/i915/gt/intel_reset.c | 34 > > > > > > > ++- > > > > > > >  1 file changed, 28 insertions(+), 6 deletions(-) > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c > > > > > > > b/drivers/gpu/drm/i915/gt/intel

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pxp: Add missing cleanup steps for PXP global-teardown

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Add missing cleanup steps for PXP global-teardown URL : https://patchwork.freedesktop.org/series/112154/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_112154v1 S

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/display/vlv: fix pixel overlap register update (rev3)

2022-12-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/vlv: fix pixel overlap register update (rev3) URL : https://patchwork.freedesktop.org/series/112045/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521_full -> Patchwork_112045v3_full ==

Re: [Intel-gfx] [PATCH 00/19] Introduce __xchg, non-atomic xchg

2022-12-22 Thread Geert Uytterhoeven
Hi Andrzej, Thanks for your series! On Thu, Dec 22, 2022 at 12:49 PM Andrzej Hajda wrote: > I hope there will be place for such tiny helper in kernel. > Quick cocci analyze shows there is probably few thousands places > where it could be useful. > I am not sure who is good person to review/ack s

Re: [Intel-gfx] [PATCH 00/19] Introduce __xchg, non-atomic xchg

2022-12-22 Thread Andrzej Hajda
On 22.12.2022 15:12, Geert Uytterhoeven wrote: Hi Andrzej, Thanks for your series! On Thu, Dec 22, 2022 at 12:49 PM Andrzej Hajda wrote: I hope there will be place for such tiny helper in kernel. Quick cocci analyze shows there is probably few thousands places where it could be useful. I a

Re: [Intel-gfx] LOOKS GOOD: Possible regression in drm/i915 driver: memleak

2022-12-22 Thread Mirsad Goran Todorovac
On 12/22/2022 09:04, Tvrtko Ursulin wrote: On 22/12/2022 00:12, Mirsad Goran Todorovac wrote: On 20. 12. 2022. 20:34, Mirsad Todorovac wrote: As I hear no reply from Tvrtko, and there is already 1d5h uptime with no leaks (but the kworker with memstick_check nag I couldn't bisect on the only

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: series starting with [v3,1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version (rev2) URL : https://patchwork.freedesktop.org/series/112121/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521_full -> Patchwork_112121v2_full =

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-22 Thread Lucas De Marchi
On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to the checks being done to apply the workarounds and very often get outdated as workarounds need to be extended to new platforms or steppings. Remove them alt

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable HDCP2.x via GSC CS (rev4)

2022-12-22 Thread Patchwork
== Series Details == Series: Enable HDCP2.x via GSC CS (rev4) URL : https://patchwork.freedesktop.org/series/111876/ State : warning == Summary == Error: dim checkpatch failed 50e4dfd0597f drm/i915/gsc: Create GSC request submission mechanism Traceback (most recent call last): File "scripts/

[Intel-gfx] ✓ Fi.CI.IGT: success for Fixes for various UC related issues (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: Fixes for various UC related issues (rev2) URL : https://patchwork.freedesktop.org/series/112080/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521_full -> Patchwork_112080v2_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdmi: Go for scrambling only if platform supports TMDS clock > 340MHz (rev3)

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915/hdmi: Go for scrambling only if platform supports TMDS clock > 340MHz (rev3) URL : https://patchwork.freedesktop.org/series/111877/ State : success == Summary == CI Bug Log - changes from CI_DRM_12522 -> Patchwork_111877v3

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsb: Remove check for dsb in dsb_commit

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915/dsb: Remove check for dsb in dsb_commit URL : https://patchwork.freedesktop.org/series/112159/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12522 -> Patchwork_112159v1 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable HDCP2.x via GSC CS (rev4)

2022-12-22 Thread Patchwork
== Series Details == Series: Enable HDCP2.x via GSC CS (rev4) URL : https://patchwork.freedesktop.org/series/111876/ State : success == Summary == CI Bug Log - changes from CI_DRM_12522 -> Patchwork_111876v4 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Remove platform acronyms and stepping from comments

2022-12-22 Thread Patchwork
== Series Details == Series: Remove platform acronyms and stepping from comments URL : https://patchwork.freedesktop.org/series/112161/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm

Re: [Intel-gfx] [PATCH 00/19] Introduce __xchg, non-atomic xchg

2022-12-22 Thread Andrew Morton
On Thu, 22 Dec 2022 12:46:16 +0100 Andrzej Hajda wrote: > Hi all, > > I hope there will be place for such tiny helper in kernel. > Quick cocci analyze shows there is probably few thousands places > where it could be useful. So to clarify, the intent here is a simple readability cleanup for exi

[Intel-gfx] ✓ Fi.CI.IGT: success for i915/gvt: Replace one-element array with flexible-array member

2022-12-22 Thread Patchwork
== Series Details == Series: i915/gvt: Replace one-element array with flexible-array member URL : https://patchwork.freedesktop.org/series/112150/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521_full -> Patchwork_112150v1_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for Remove platform acronyms and stepping from comments

2022-12-22 Thread Patchwork
== Series Details == Series: Remove platform acronyms and stepping from comments URL : https://patchwork.freedesktop.org/series/112161/ State : success == Summary == CI Bug Log - changes from CI_DRM_12522 -> Patchwork_112161v1 Summary -

[Intel-gfx] [PULL] drm-misc-fixes

2022-12-22 Thread Maxime Ripard
Hi, here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2022-12-22: One fix for a use-after-free in panfrost, one to fix the error handling in dma_buf_export and one to fix a compile error with drm_plane_helper_atomic_check missing a definition for drm_atomic_state The following changes sin

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix same object multiple mmap memory leak

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix same object multiple mmap memory leak URL : https://patchwork.freedesktop.org/series/112166/ State : warning == Summary == Error: dim checkpatch failed ac57a13bb1d3 drm/i915: Fix same object multiple mmap memory leak -:10: ERROR:GIT_COMMIT_ID: Please

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev8)

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev8) URL : https://patchwork.freedesktop.org/series/108732/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12521_full -> Patchwork_108732v8_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix same object multiple mmap memory leak

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix same object multiple mmap memory leak URL : https://patchwork.freedesktop.org/series/112166/ State : success == Summary == CI Bug Log - changes from CI_DRM_12522 -> Patchwork_112166v1 Summary -

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce __xchg, non-atomic xchg

2022-12-22 Thread Patchwork
== Series Details == Series: Introduce __xchg, non-atomic xchg URL : https://patchwork.freedesktop.org/series/112169/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce __xchg, non-atomic xchg

2022-12-22 Thread Patchwork
== Series Details == Series: Introduce __xchg, non-atomic xchg URL : https://patchwork.freedesktop.org/series/112169/ State : success == Summary == CI Bug Log - changes from CI_DRM_12522 -> Patchwork_112169v1 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Only select I2C_ALGOBIT for drivers that actually need it (rev2)

2022-12-22 Thread Patchwork
== Series Details == Series: drm: Only select I2C_ALGOBIT for drivers that actually need it (rev2) URL : https://patchwork.freedesktop.org/series/90163/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521_full -> Patchwork_90163v2_full =

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: vblank stuff

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915: vblank stuff URL : https://patchwork.freedesktop.org/series/112170/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12523 -> Patchwork_112170v1 Summary --- **FAILURE** Serious

[Intel-gfx] [PATCH] drm/i915: Flush power delayed put when connector init failed

2022-12-22 Thread Maarten Lankhorst
When intel_dp_init_connector fails, some power wells used in dp aux communication may not be completely disabled yet. This may result in a null pointer dereference when icl_aux_pw_to_phy() is called from icl_combo_phy_aux_power_well_disable() after the encoder and connector are already freed. Sign

Re: [Intel-gfx] [PATCH] drm/i915: Flush power delayed put when connector init failed

2022-12-22 Thread Imre Deak
On Thu, Dec 22, 2022 at 09:18:04PM +0100, Maarten Lankhorst wrote: > When intel_dp_init_connector fails, some power wells used in dp aux > communication may not be completely disabled yet. This may result in a > null pointer dereference when icl_aux_pw_to_phy() is called from > icl_combo_phy_aux_po

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/display/core: use intel_de_rmw if possible

2022-12-22 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/display/core: use intel_de_rmw if possible URL : https://patchwork.freedesktop.org/series/112171/ State : success == Summary == CI Bug Log - changes from CI_DRM_12523 -> Patchwork_112171v1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Flush power delayed put when connector init failed

2022-12-22 Thread Patchwork
== Series Details == Series: drm/i915: Flush power delayed put when connector init failed URL : https://patchwork.freedesktop.org/series/112182/ State : success == Summary == CI Bug Log - changes from CI_DRM_12523 -> Patchwork_112182v1 Summ

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths

2022-12-22 Thread Gustavo Sousa
On Wed, Dec 21, 2022 at 04:23:45PM -0800, Lucas De Marchi wrote: > On Wed, Dec 21, 2022 at 12:26:26PM +0200, Jani Nikula wrote: > > On Tue, 20 Dec 2022, Gustavo Sousa wrote: > > > As we do not require specific versions anymore, change the convention > > > for blob filenames to stop using version n

[Intel-gfx] [RFC PATCH 01/20] drm/suballoc: Introduce a generic suballocation manager

2022-12-22 Thread Matthew Brost
From: Thomas Hellström Initially we tried to leverage the amdgpu suballocation manager. It turnes out, however, that it tries extremely hard not to enable signalling on the fences that hold the memory up for freeing, which makes it hard to understand and to fix potential issues with it. So in a

[Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2022-12-22 Thread Matthew Brost
Hello, This is a submission for Xe, a new driver for Intel GPUs that supports both integrated and discrete platforms starting with Tiger Lake (first platform with Intel Xe Architecture). The intention of this new driver is to have a fresh base to work from that is unencumbered by older platforms,

[Intel-gfx] [RFC PATCH 06/20] drm/sched: Start run wq before TDR in drm_sched_start

2022-12-22 Thread Matthew Brost
If the TDR is set to a very small value it can fire before the run wq is started in the function drm_sched_start. The run wq is expected to running when the TDR fires, fix this ordering so this expectation is always met. Signed-off-by: Matthew Brost --- drivers/gpu/drm/scheduler/sched_main.c | 4

[Intel-gfx] [RFC PATCH 12/20] drm/i915/display: Neuter frontbuffer tracking harder

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Remove intel_frontbuffer type, and use fb->bits. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_cursor.c | 6 +- drivers/gpu/drm/i915/display/intel_display.c | 4 +- .../drm/i915/display/intel_display_types.h| 8 +- drivers/gpu/drm/

[Intel-gfx] [RFC PATCH 02/20] drm/amd: Convert amdgpu to use suballocation helper.

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Now that we have a generic suballocation helper, Use it in amdgpu. The debug output is slightly different and suballocation may be slightly more cpu-hungry. Signed-off-by: Maarten Lankhorst Co-developed-by: Thomas Hellström Signed-off-by: Thomas Hellström --- drivers/

[Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2022-12-22 Thread Matthew Brost
In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 mapping between a drm_gpu_scheduler and drm_sched_entity. At first this seems a bit odd but let us explain the reasoning below. 1. In XE the submission order from multiple drm_sched_entity is not guaranteed to be the same completi

[Intel-gfx] [RFC PATCH 08/20] drm/sched: Add helper to set TDR timeout

2022-12-22 Thread Matthew Brost
Add helper to set TDR timeout and restart the TDR with new timeout value. This will be used in XE, new Intel GPU driver, to trigger the TDR to cleanup drm_sched_entity that encounter errors. Signed-off-by: Matthew Brost --- drivers/gpu/drm/scheduler/sched_main.c | 18 ++ include/

[Intel-gfx] [RFC PATCH 09/20] drm: Add a gpu page-table walker helper

2022-12-22 Thread Matthew Brost
From: Thomas Hellström Add a gpu page table walker similar in functionality to the cpu page-table walker in mm/pagewalk.c. This is made a drm helper in the hope that it might prove useful to other drivers, but we could of course make it single-driver only and rename the functions initially. Also

[Intel-gfx] [RFC PATCH 03/20] drm/radeon: Use the drm suballocation manager implementation.

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Use the generic suballocation helper. Note that the generic suballocator only allows a single alignment, so we may waste a few more bytes for radeon_semaphore, shouldn't be a big deal, could be re-added if needed. Also, similar to amdgpu, debug output changes slightly and

[Intel-gfx] [RFC PATCH 15/20] drm/i915: Rename find_section to find_bdb_section

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst This prevents a namespace collision on other archs. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_bios.c | 46 +++ 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/

  1   2   >