[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Don't use port enum as register offset (rev3)

2022-09-23 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't use port enum as register offset (rev3) URL : https://patchwork.freedesktop.org/series/108833/ State : success == Summary == CI Bug Log - changes from CI_DRM_12171 -> Patchwork_108833v3 S

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

2022-09-23 Thread Tvrtko Ursulin
Hi Nathan, On 22/09/2022 20:51, Nathan Chancellor wrote: When booting with clang's kernel control flow integrity series [1], there are numerous violations when accessing the files under /sys/devices/pci:00/:00:02.0/drm/card0/gt/gt0: $ cd /sys/devices/pci:00/:00:02.0/drm/car

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Delay disabling GuC scheduling of an idle context

2022-09-23 Thread Patchwork
== Series Details == Series: Delay disabling GuC scheduling of an idle context URL : https://patchwork.freedesktop.org/series/108931/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915: Improve debug print in vm_fault_ttm

2022-09-23 Thread Das, Nirmoy
On 9/22/2022 6:38 PM, Matthew Auld wrote: On 22/09/2022 13:09, Nirmoy Das wrote: Print the error code returned by __i915_ttm_migrate() for better debuggability. References: https://gitlab.freedesktop.org/drm/intel/-/issues/6889 Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/i915/gem/i915_ge

[Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload

2022-09-23 Thread Nirmoy Das
i915_gem_drain_freed_objects() might not be enough to free all the objects and RCU delayed work might get scheduled after the i915 device struct gets freed. Call i915_gem_drain_workqueue() to catch all RCU delayed work. Suggested-by: Chris Wilson Acked-by: Tvrtko Ursulin Signed-off-by: Nirmoy D

[Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects

2022-09-23 Thread Nirmoy Das
i915_gem_drain_workqueue() call i915_gem_drain_freed_objects() so no need to call that again. Reviewed-by: Tvrtko Ursulin Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/i915_gem.c | 2 -- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 - 2 files changed, 3 deletions(-

[Intel-gfx] ✓ Fi.CI.BAT: success for Delay disabling GuC scheduling of an idle context

2022-09-23 Thread Patchwork
== Series Details == Series: Delay disabling GuC scheduling of an idle context URL : https://patchwork.freedesktop.org/series/108931/ State : success == Summary == CI Bug Log - changes from CI_DRM_12171 -> Patchwork_108931v1 Summary ---

[Intel-gfx] [PULL] drm-misc-next

2022-09-23 Thread Maxime Ripard
Hi Daniel, Dave, We haven't had a drm-misc-next PR for a while, so here it is. It should be the last drm-misc-next PR for 6.1 Maxime drm-misc-next-2022-09-23: drm-misc-next for 6.1: UAPI Changes: Cross-subsystem Changes: - dma-buf: Improve signaling when debugging Core Changes: - Backlig

Re: [Intel-gfx] [RFC v4 03/14] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-23 Thread Tvrtko Ursulin
On 22/09/2022 17:18, Matthew Auld wrote: On 22/09/2022 09:09, Tvrtko Ursulin wrote: On 21/09/2022 19:00, Niranjana Vishwanathapura wrote: On Wed, Sep 21, 2022 at 10:13:12AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Expose i915_gem_object_max_page_s

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Mark FBC B gone if pipe B is gone

2022-09-23 Thread Ville Syrjälä
On Fri, Sep 23, 2022 at 09:24:28AM +0300, Luca Coelho wrote: > On Thu, 2022-09-22 at 14:57 +0300, Ville Syrjälä wrote: > > On Thu, Sep 22, 2022 at 02:37:35PM +0300, Luca Coelho wrote: > > > On Thu, 2022-09-22 at 12:36 +0300, Ville Syrjälä wrote: > > > > On Thu, Sep 22, 2022 at 11:51:16AM +0300, Jan

[Intel-gfx] ✗ Fi.CI.IGT: failure for DG2 fix for CCS starvation

2022-09-23 Thread Patchwork
== Series Details == Series: DG2 fix for CCS starvation URL : https://patchwork.freedesktop.org/series/108919/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12168_full -> Patchwork_108919v1_full Summary --- **FAILURE

Re: [Intel-gfx] [PATCH v2 01/33] drm/tests: Order Kunit tests in Makefile

2022-09-23 Thread Thomas Zimmermann
Am 22.09.22 um 16:25 schrieb Maxime Ripard: Since we've recently added a ton of tests, the list starts to be a bit of a mess and creates unneeded conflicts. Let's order it alphabetically. Signed-off-by: Maxime Ripard Acked-by: Thomas Zimmermann diff --git a/drivers/gpu/drm/tests/Makefi

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Extend PSR support

2022-09-23 Thread Lisovskiy, Stanislav
On Wed, Sep 07, 2022 at 11:15:43AM +0300, Mika Kahola wrote: > From: José Roberto de Souza > > Meteorlake and display 14 platform don't have any PSR differences > when comparing to Alderlake-P display, so it was only necessary to > extend some checks to properly program hardware. > > BSpec: 5522

Re: [Intel-gfx] [PATCH v2 03/33] drm/atomic-helper: Rename drm_atomic_helper_connector_tv_reset to avoid ambiguity

2022-09-23 Thread Thomas Zimmermann
Hi Am 22.09.22 um 16:25 schrieb Maxime Ripard: We currently have two sets of TV properties. The first one is there to deal with analog TV properties, creating properties such as the TV mode, subconnectors, saturation, hue and so on. It's created by calling the drm_mode_create_tv_properties() fu

[Intel-gfx] ✓ Fi.CI.BAT: success for Add PXP firmware respose on ARB failure

2022-09-23 Thread Patchwork
== Series Details == Series: Add PXP firmware respose on ARB failure URL : https://patchwork.freedesktop.org/series/108935/ State : success == Summary == CI Bug Log - changes from CI_DRM_12171 -> Patchwork_108935v1 Summary --- **SUCC

Re: [Intel-gfx] [PATCH v2 04/33] drm/connector: Rename subconnector state variable

2022-09-23 Thread Thomas Zimmermann
Hi Am 22.09.22 um 16:25 schrieb Maxime Ripard: There is two TV subconnector related properties registered by drm_mode_create_tv_properties(): subconnector and select subconnector. While the select subconnector property is stored in the kernel by the drm_tv_connector_state structure, the subconn

Re: [Intel-gfx] [PATCH v2 06/33] drm/connector: Rename legacy TV property

2022-09-23 Thread Thomas Zimmermann
Hi Am 22.09.22 um 16:25 schrieb Maxime Ripard: The current tv_mode has driver-specific values that don't allow to easily share code using it, either at the userspace or kernel level. Since we're going to introduce a new, generic, property that fit the same purpose, let's rename this one to lega

Re: [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper

2022-09-23 Thread Jani Nikula
On Thu, 22 Sep 2022, Gustavo Sousa wrote: > Use *_hpd_invert() helpers whenever possible to isolate logic specific > to hotplug inversion from common HPD setup logic to improve readability > and maintainability of the source code. > > While we only define dg1_hpd_invert() here, future platforms ar

[Intel-gfx] [PATCH v11 0/9] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-23 Thread Gwan-gyeong Mun
This patch series fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation, etc. We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead o

[Intel-gfx] [PATCH v11 2/9] overflow: Move and add few utility macros into overflow

2022-09-23 Thread Gwan-gyeong Mun
Moves overflows_type utility macro into overflow header from i915_utils header. The overflows_type can be used to catch the truncaion (overflow) between different data types. And it adds check_assign() macro which performs an assigning source value into destination pointer along with an overflow ch

[Intel-gfx] [PATCH v11 1/9] overflow: Allow mixed type arguments

2022-09-23 Thread Gwan-gyeong Mun
From: Kees Cook When the check_[op]_overflow() helpers were introduced, all arguments were required to be the same type to make the fallback macros simpler. However, now that the fallback macros have been removed[1], it is fine to allow mixed types, which makes using the helpers much more useful,

[Intel-gfx] [PATCH v11 3/9] compiler_types.h: Add assert_same_type to catch type mis-match while compiling

2022-09-23 Thread Gwan-gyeong Mun
Adds assert_same_type and assert_same_typable macros to catch type mis-match while compiling. The existing typecheck() macro outputs build warnings, but the newly added assert_same_type() macro uses the static_assert macro (which uses _Static_assert keyword and it introduced in C11) to generate a b

[Intel-gfx] [PATCH v11 5/9] drm/i915: Check for integer truncation on scatterlist creation

2022-09-23 Thread Gwan-gyeong Mun
From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table into which we try to fit very many pages. As the o

[Intel-gfx] [PATCH v11 6/9] drm/i915: Check for integer truncation on the configuration of ttm place

2022-09-23 Thread Gwan-gyeong Mun
There is an impedance mismatch between the first/last valid page frame number of ttm place in unsigned and our memory/page accounting in unsigned long. As the object size is under the control of userspace, we have to be prudent and catch the conversion errors. To catch the implicit truncation as we

[Intel-gfx] [PATCH v11 4/9] drm/i915/gem: Typecheck page lookups

2022-09-23 Thread Gwan-gyeong Mun
From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the lookup so that we can be sure that we are safe. A

[Intel-gfx] [PATCH v11 8/9] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

2022-09-23 Thread Gwan-gyeong Mun
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG. Signed-off-by:

[Intel-gfx] [PATCH v11 9/9] drm/i915: Remove truncation warning for large objects

2022-09-23 Thread Gwan-gyeong Mun
From: Chris Wilson Having addressed the issues surrounding incorrect types for local variables and potential integer truncation in using the scatterlist API, we have closed all the loop holes we had previously identified with dangerously large object creation. As such, we can eliminate the warnin

[Intel-gfx] [PATCH v11 7/9] drm/i915: Check if the size is too big while creating shmem file

2022-09-23 Thread Gwan-gyeong Mun
The __shmem_file_setup() function returns -EINVAL if size is greater than MAX_LFS_FILESIZE. To handle the same error as other code that returns -E2BIG when the size is too large, it add a code that returns -E2BIG when the size is larger than the size that can be handled. v4: If BITS_PER_LONG is 32

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove unused function parameter (rev2)

2022-09-23 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused function parameter (rev2) URL : https://patchwork.freedesktop.org/series/108863/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168_full -> Patchwork_108863v2_full Summa

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for iommu: Remove iova cpu hotplugging flushing

2022-09-23 Thread Janusz Krzysztofik
On Thursday, 22 September 2022 21:18:51 CEST Patchwork wrote: > == Series Details == > > Series: iommu: Remove iova cpu hotplugging flushing > URL : https://patchwork.freedesktop.org/series/108880/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_12166_full -> Patchwork

Re: [Intel-gfx] [RFC v4 13/14] drm/i915/vm_bind: Skip vma_lookup for persistent vmas

2022-09-23 Thread Tvrtko Ursulin
On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: vma_lookup is tied to segment of the object instead of section Can be, but not only that. It would be more accurate to say it is based of gtt views. of VA space. Hence, it do not support aliasing (ie., multiple bindings to the same sec

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload

2022-09-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix a potential UAF at device unload URL : https://patchwork.freedesktop.org/series/108944/ State : success == Summary == CI Bug Log - changes from CI_DRM_12171 -> Patchwork_108944v1

[Intel-gfx] [PATCH v2] drm/i915: Improve debug print in vm_fault_ttm

2022-09-23 Thread Nirmoy Das
Print the error code returned by __i915_ttm_migrate() for better debuggability. v2: Fix kernel test robot warning. References: https://gitlab.freedesktop.org/drm/intel/-/issues/6889 Acked-by: Matthew Auld Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file chan

Re: [Intel-gfx] [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes

2022-09-23 Thread Thomas Zimmermann
Hi Am 22.09.22 um 16:25 schrieb Maxime Ripard: Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and 625-lines modes in their drivers. Since those modes are fairly standard, and that we'll need to use them in more places in the future, it makes sense to move their definition into

Re: [Intel-gfx] [PATCH v2 13/33] drm/client: Add some tests for drm_connector_pick_cmdline_mode()

2022-09-23 Thread Thomas Zimmermann
Hi Am 22.09.22 um 16:25 schrieb Maxime Ripard: drm_connector_pick_cmdline_mode() is in charge of finding a proper drm_display_mode from the definition we got in the video= command line argument. Let's add some unit tests to make sure we're not getting any regressions there. Signed-off-by: Maxi

Re: [Intel-gfx] [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes

2022-09-23 Thread Jani Nikula
On Fri, 23 Sep 2022, Thomas Zimmermann wrote: > Am 22.09.22 um 16:25 schrieb Maxime Ripard: >> +drm_dbg_kms(dev, >> +"Generating a %ux%u%c, %u-line mode with a %lu kHz clock\n", >> +hactive, vactive, >> +interlace ? 'i' : 'p', >> +

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: prepare for uC loading on MTL

2022-09-23 Thread Patchwork
== Series Details == Series: drm/i915: prepare for uC loading on MTL URL : https://patchwork.freedesktop.org/series/108925/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168_full -> Patchwork_108925v1_full Summary ---

Re: [Intel-gfx] [PATCH 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-09-23 Thread Jani Nikula
On Thu, 22 Sep 2022, Daniele Ceraolo Spurio wrote: > From: Aravind Iddamsetty > > With MTL standalone media architecture the wopcm layout has changed with > separate partitioning in WOPCM for GCD/GT GuC and SA Media GuC. The size > of WOPCM is 4MB with lower 2MB for SA Media and upper 2MB for GC

Re: [Intel-gfx] [PATCH v2 13/33] drm/client: Add some tests for drm_connector_pick_cmdline_mode()

2022-09-23 Thread Javier Martinez Canillas
On 9/23/22 11:15, Thomas Zimmermann wrote: > Hi > > Am 22.09.22 um 16:25 schrieb Maxime Ripard: >> drm_connector_pick_cmdline_mode() is in charge of finding a proper >> drm_display_mode from the definition we got in the video= command line >> argument. >> >> Let's add some unit tests to make sure

Re: [Intel-gfx] [bug report] drm/i915/guc: Implement multi-lrc submission

2022-09-23 Thread Dan Carpenter
On Thu, Sep 22, 2022 at 01:01:48PM -0700, John Harrison wrote: > On 9/22/2022 07:26, Dan Carpenter wrote: > > Hello Matthew Brost, > > > > The patch 6b540bf6f143: "drm/i915/guc: Implement multi-lrc > > submission" from Oct 14, 2021, leads to the following Smatch static > > checker warning: > > >

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Don't use port enum as register offset

2022-09-23 Thread Jani Nikula
On Wed, 21 Sep 2022, Balasubramani Vivekanandan wrote: > Display DDI ports are enumerated as PORT_A,PORT_B... . The enums are > also used as an index to access the DDI_BUF_CTL register for the port. > > With the introduction of TypeC ports, new enums PORT_TC1,PORT_TC2.. were > added starting from

Re: [Intel-gfx] [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes

2022-09-23 Thread Thomas Zimmermann
Hi Am 23.09.22 um 11:18 schrieb Jani Nikula: On Fri, 23 Sep 2022, Thomas Zimmermann wrote: Am 22.09.22 um 16:25 schrieb Maxime Ripard: + drm_dbg_kms(dev, + "Generating a %ux%u%c, %u-line mode with a %lu kHz clock\n", + hactive, vactive, +

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Don't use port enum as register offset

2022-09-23 Thread Ville Syrjälä
On Fri, Sep 23, 2022 at 12:52:48PM +0300, Jani Nikula wrote: > On Wed, 21 Sep 2022, Balasubramani Vivekanandan > wrote: > > Display DDI ports are enumerated as PORT_A,PORT_B... . The enums are > > also used as an index to access the DDI_BUF_CTL register for the port. > > > > With the introduction

Re: [Intel-gfx] [PATCH v2 13/33] drm/client: Add some tests for drm_connector_pick_cmdline_mode()

2022-09-23 Thread Thomas Zimmermann
Hi Am 23.09.22 um 11:26 schrieb Javier Martinez Canillas: On 9/23/22 11:15, Thomas Zimmermann wrote: Hi Am 22.09.22 um 16:25 schrieb Maxime Ripard: drm_connector_pick_cmdline_mode() is in charge of finding a proper drm_display_mode from the definition we got in the video= command line argumen

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Remove flush_scheduled_work() from live_execlists

2022-09-23 Thread Das, Nirmoy
Reviewed-by: Nirmoy Das On 6/30/2022 2:57 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin There are ongoing efforts to remove usages of flush_scheduled_work() from drivers in order to avoid several cases of potentential problems when flushing is done from certain contexts. Remove the call fro

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-23 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/108945/ State : warning == Summary == Error: dim checkpatch failed c7e564bf76cd overflow: Allow mix

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-23 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/108945/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode use

Re: [Intel-gfx] [PATCH 1/7] drm/i915/huc: only load HuC on GTs that have VCS engines

2022-09-23 Thread Tvrtko Ursulin
On 22/09/2022 23:11, Daniele Ceraolo Spurio wrote: On MTL the primary GT doesn't have any media capabilities, so no video engines and no HuC. We must therefore skip the HuC fetch and load on that specific case. Given that other multi-GT platforms might have HuC on the primary GT, we can't just

[Intel-gfx] [PATCH 0/3] Add SLPC selftest live_slpc_power

2022-09-23 Thread Riana Tauro
live_slpc_power tests if running at low frequency saves power Rev2 : Add multi-tile support Riana Tauro (3): drm/i915/guc/slpc: Run SLPC selftests on all tiles drm/i915/selftests: Add helper function measure_power drm/i915/guc/slpc: Add SLPC selftest live_slpc_power drivers/gpu/drm/i915/g

[Intel-gfx] [PATCH 3/3] drm/i915/guc/slpc: Add SLPC selftest live_slpc_power

2022-09-23 Thread Riana Tauro
A fundamental assumption is that at lower frequencies, not only do we run slower, but we save power compared to higher frequencies. live_slpc_power checks if running at low frequency saves power v2: re-use code to measure power fixed cosmetic review comments (Vinay) Signed-off-by: Riana Tauro

[Intel-gfx] [PATCH 2/3] drm/i915/selftests: Add helper function measure_power

2022-09-23 Thread Riana Tauro
move the power measurement and the triangle filter to a different function. No functional changes. Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_rps.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/driv

[Intel-gfx] [PATCH 1/3] drm/i915/guc/slpc: Run SLPC selftests on all tiles

2022-09-23 Thread Riana Tauro
Run slpc selftests on all tiles Signed-off-by: Riana Tauro --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 45 - 1 file changed, 37 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_slpc.c b/drivers/gpu/drm/i915/gt/selftest_slpc.c index f8a1d27df

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Remove flush_scheduled_work() from live_execlists

2022-09-23 Thread Tvrtko Ursulin
On 23/09/2022 11:32, Das, Nirmoy wrote: Reviewed-by: Nirmoy Das Thanks! Pushed now. Should land with 6.2. Regards, Tvrtko On 6/30/2022 2:57 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin There are ongoing efforts to remove usages of flush_scheduled_work() from drivers in order to avo

Re: [Intel-gfx] [PATCH v2 13/33] drm/client: Add some tests for drm_connector_pick_cmdline_mode()

2022-09-23 Thread Javier Martinez Canillas
On 9/23/22 12:30, Thomas Zimmermann wrote: [...] + +#ifdef CONFIG_DRM_KUNIT_TEST +#include "tests/drm_client_modeset_test.c" +#endif >>> >>> I strongly dislike this style of including source files in each other. >>> It's a recipe for all kind of build errors. Can you do someth

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-23 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/108945/ State : success == Summary == CI Bug Log - changes from CI_DRM_12173 -> Patchwork_108945v1

Re: [Intel-gfx] [PATCH v2 13/33] drm/client: Add some tests for drm_connector_pick_cmdline_mode()

2022-09-23 Thread Maxime Ripard
On Fri, Sep 23, 2022 at 12:30:09PM +0200, Thomas Zimmermann wrote: > Am 23.09.22 um 11:26 schrieb Javier Martinez Canillas: > > On 9/23/22 11:15, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 22.09.22 um 16:25 schrieb Maxime Ripard: > > > > drm_connector_pick_cmdline_mode() is in charge of find

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915/pxp: Add firmware status when ARB session fails

2022-09-23 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/pxp: Add firmware status when ARB session fails URL : https://patchwork.freedesktop.org/series/108928/ State : success == Summary == CI Bug Log - changes from CI_DRM_12169_full -> Patchwork_108928v1_full

Re: [Intel-gfx] [PATCH v2 13/33] drm/client: Add some tests for drm_connector_pick_cmdline_mode()

2022-09-23 Thread Jani Nikula
On Thu, 22 Sep 2022, Maxime Ripard wrote: > drm_connector_pick_cmdline_mode() is in charge of finding a proper > drm_display_mode from the definition we got in the video= command line > argument. > > Let's add some unit tests to make sure we're not getting any regressions > there. > > Signed-off-b

[Intel-gfx] ✓ Fi.CI.IGT: success for Add PXP firmware respose on ARB failure

2022-09-23 Thread Patchwork
== Series Details == Series: Add PXP firmware respose on ARB failure URL : https://patchwork.freedesktop.org/series/108929/ State : success == Summary == CI Bug Log - changes from CI_DRM_12169_full -> Patchwork_108929v1_full Summary ---

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Fix PSR_IMR/IIR field handling

2022-09-23 Thread Souza, Jose
On Fri, 2022-09-23 at 06:11 +, Hogander, Jouni wrote: > On Thu, 2022-09-22 at 13:08 +, Souza, Jose wrote: > > On Thu, 2022-09-22 at 10:59 +0300, Jouni Högander wrote: > > > Current PSR code is supposed to use TRANSCODER_EDP to force 0 shift > > > for > > > bits in PSR_IMR/IIR registers: > >

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Fix PSR_IMR/IIR field handling

2022-09-23 Thread Hogander, Jouni
On Fri, 2022-09-23 at 12:37 +, Souza, Jose wrote: > On Fri, 2022-09-23 at 06:11 +, Hogander, Jouni wrote: > > On Thu, 2022-09-22 at 13:08 +, Souza, Jose wrote: > > > On Thu, 2022-09-22 at 10:59 +0300, Jouni Högander wrote: > > > > Current PSR code is supposed to use TRANSCODER_EDP to fo

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Improve debug print in vm_fault_ttm (rev2)

2022-09-23 Thread Patchwork
== Series Details == Series: drm/i915: Improve debug print in vm_fault_ttm (rev2) URL : https://patchwork.freedesktop.org/series/108887/ State : warning == Summary == Error: dim checkpatch failed 751ba3d859b3 drm/i915: Improve debug print in vm_fault_ttm -:24: WARNING:LONG_LINE: line length of

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Fix PSR_IMR/IIR field handling

2022-09-23 Thread Souza, Jose
On Fri, 2022-09-23 at 12:45 +, Hogander, Jouni wrote: > On Fri, 2022-09-23 at 12:37 +, Souza, Jose wrote: > > On Fri, 2022-09-23 at 06:11 +, Hogander, Jouni wrote: > > > On Thu, 2022-09-22 at 13:08 +, Souza, Jose wrote: > > > > On Thu, 2022-09-22 at 10:59 +0300, Jouni Högander wrote

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Improve debug print in vm_fault_ttm (rev2)

2022-09-23 Thread Patchwork
== Series Details == Series: drm/i915: Improve debug print in vm_fault_ttm (rev2) URL : https://patchwork.freedesktop.org/series/108887/ State : success == Summary == CI Bug Log - changes from CI_DRM_12174 -> Patchwork_108887v2 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Add SLPC selftest live_slpc_power (rev2)

2022-09-23 Thread Patchwork
== Series Details == Series: Add SLPC selftest live_slpc_power (rev2) URL : https://patchwork.freedesktop.org/series/108900/ State : success == Summary == CI Bug Log - changes from CI_DRM_12174 -> Patchwork_108900v2 Summary --- **SUC

[Intel-gfx] [PATCH] drm/i915: Stop using flush_scheduled_work on driver remove

2022-09-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Kernel is trying to eliminate callers of flush_scheduled_work so lets try to accommodate. We currently call it from intel_modeset_driver_remove_noirq on the driver remove path but the comment next to it does not tell me what exact work it wants to flush. I can spot three (o

[Intel-gfx] [PATCH] drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual

2022-09-23 Thread Anshuman Gupta
We had already grabbed the rpm wakeref at obj destruction path, but it also required to grab the wakeref when object moves. When i915_gem_object_release_mmap_offset() gets called by i915_ttm_move_notify(), it will release the mmap offset without grabbing the wakeref. We want to avoid that therefore

[Intel-gfx] [PATCH v3] drm/i915: Improve debug print in vm_fault_ttm

2022-09-23 Thread Nirmoy Das
Print the error code returned by __i915_ttm_migrate() for better debuggability. v2: Fix kernel test robot warning. v3: Fix dim checkpatch warning. References: https://gitlab.freedesktop.org/drm/intel/-/issues/6889 Acked-by: Matthew Auld Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i91

Re: [Intel-gfx] [PATCH v2] drm/i915: Improve debug print in vm_fault_ttm

2022-09-23 Thread Andrzej Hajda
On 23.09.2022 10:45, Nirmoy Das wrote: Print the error code returned by __i915_ttm_migrate() for better debuggability. v2: Fix kernel test robot warning. References: https://gitlab.freedesktop.org/drm/intel/-/issues/6889 Acked-by: Matthew Auld Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-09-23 Thread Ceraolo Spurio, Daniele
On 9/23/2022 2:24 AM, Jani Nikula wrote: On Thu, 22 Sep 2022, Daniele Ceraolo Spurio wrote: From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed with separate partitioning in WOPCM for GCD/GT GuC and SA Media GuC. The size of WOPCM is 4MB with lower

Re: [Intel-gfx] [PATCH 1/7] drm/i915/huc: only load HuC on GTs that have VCS engines

2022-09-23 Thread Ceraolo Spurio, Daniele
On 9/23/2022 3:53 AM, Tvrtko Ursulin wrote: On 22/09/2022 23:11, Daniele Ceraolo Spurio wrote: On MTL the primary GT doesn't have any media capabilities, so no video engines and no HuC. We must therefore skip the HuC fetch and load on that specific case. Given that other multi-GT platforms m

[Intel-gfx] [PATCH i-g-t] gem_ctx_persistence: adjust reset timeout

2022-09-23 Thread Andrzej Hajda
Tests on DG2 show that context cancel can take even 350ms, due to error state capturing in guc_handle_context_reset. Since it happens only in debug mode and tests runs in debug mode it should be fine to adjust the timeout. Let's double this value, to be on safe side. It should fix multiple test tim

Re: [Intel-gfx] [PATCH i-g-t] tests/i915/gem_ctx_persistence: adjust saturated-hostile test timeout

2022-09-23 Thread Andrzej Hajda
On 22.09.2022 10:13, Andrzej Hajda wrote: GPU occasionally can hang during saturated-hostile test. Detection of such case and reset can take up to 5 seconds. While at it fix typo in definition of RESET_TIMEOUT_MS. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1551 Signed-off-by: A

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Stop using flush_scheduled_work on driver remove

2022-09-23 Thread Patchwork
== Series Details == Series: drm/i915: Stop using flush_scheduled_work on driver remove URL : https://patchwork.freedesktop.org/series/108970/ State : success == Summary == CI Bug Log - changes from CI_DRM_12175 -> Patchwork_108970v1 Summar

Re: [Intel-gfx] [PATCH] drm/i915: Stop using flush_scheduled_work on driver remove

2022-09-23 Thread Ville Syrjälä
On Fri, Sep 23, 2022 at 03:29:34PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Kernel is trying to eliminate callers of flush_scheduled_work so lets > try to accommodate. > > We currently call it from intel_modeset_driver_remove_noirq on the driver > remove path but the comment next

Re: [Intel-gfx] [PATCH 0/6] Introduce struct cdclk_step

2022-09-23 Thread Srivatsa, Anusha
> -Original Message- > From: Ville Syrjälä > Sent: Tuesday, September 20, 2022 2:59 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > ; Vivi, Rodrigo > Subject: Re: [PATCH 0/6] Introduce struct cdclk_step > > On Tue, Sep 20, 2022 at 06:48:46PM +, Sri

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual

2022-09-23 Thread Patchwork
== Series Details == Series: drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual URL : https://patchwork.freedesktop.org/series/108972/ State : warning == Summary == Error: dim checkpatch failed 09fac79aedc6 drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual -:122: CHECK:BRACES: Blank lin

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual

2022-09-23 Thread Patchwork
== Series Details == Series: drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual URL : https://patchwork.freedesktop.org/series/108972/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual

2022-09-23 Thread Patchwork
== Series Details == Series: drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual URL : https://patchwork.freedesktop.org/series/108972/ State : success == Summary == CI Bug Log - changes from CI_DRM_12175 -> Patchwork_108972v1 Summary ---

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: Read graphics/media/display arch version from hw

2022-09-23 Thread Lucas De Marchi
On Thu, Sep 15, 2022 at 06:46:46PM -0700, Radhakrishna Sripada wrote: From: Matt Roper Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own

Re: [Intel-gfx] [PATCH v6 2/3] drm/i915: Parse and set stepping for platforms with GMD

2022-09-23 Thread Lucas De Marchi
On Thu, Sep 15, 2022 at 06:46:47PM -0700, Radhakrishna Sripada wrote: From: José Roberto de Souza Expand the current stepping convention to accommodate the GMD stepping info. Typically GMD step maps to letter stepping by "A + step %4" and number to "A + step /4" i.e, GMD step 0 maps to STEP_A0,

Re: [Intel-gfx] [PATCH] drm/i915/dg2: introduce Wa_22015475538

2022-09-23 Thread Matt Roper
On Tue, Sep 20, 2022 at 01:43:59PM -0700, Matt Atwood wrote: > Wa_22015475538 applies to all DG2 (and ATSM) skus. The workaround > implementation is identical to Wa_16011620976. LSC_CHICKEN_BIT_0_UDW is > a general render register instead of rcs so adding this move to the > proper wa init function.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Don't use port enum as register offset (rev3)

2022-09-23 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't use port enum as register offset (rev3) URL : https://patchwork.freedesktop.org/series/108833/ State : success == Summary == CI Bug Log - changes from CI_DRM_12171_full -> Patchwork_108833v3_full =

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: introduce Wa_22015475538

2022-09-23 Thread Matt Roper
On Wed, Sep 21, 2022 at 12:19:05AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dg2: introduce Wa_22015475538 > URL : https://patchwork.freedesktop.org/series/108795/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_12161_full -> Patchwork_108795v

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Improve debug print in vm_fault_ttm (rev3)

2022-09-23 Thread Patchwork
== Series Details == Series: drm/i915: Improve debug print in vm_fault_ttm (rev3) URL : https://patchwork.freedesktop.org/series/108887/ State : success == Summary == CI Bug Log - changes from CI_DRM_12175 -> Patchwork_108887v3 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Allow D3 when we are not actively managing a known PCI device.

2022-09-23 Thread Vivi, Rodrigo
Rafael, could you please add your thoughts here? On Thu, 2022-09-22 at 12:40 +, Gupta, Anshuman wrote: > > > > -Original Message- > > From: Gupta, Anshuman > > Sent: Thursday, September 22, 2022 4:40 PM > > To: Vivi, Rodrigo ; Tvrtko Ursulin > > > > Cc: Nikula, Jani ; intel- > > g..

[Intel-gfx] ✓ Fi.CI.IGT: success for Delay disabling GuC scheduling of an idle context

2022-09-23 Thread Patchwork
== Series Details == Series: Delay disabling GuC scheduling of an idle context URL : https://patchwork.freedesktop.org/series/108931/ State : success == Summary == CI Bug Log - changes from CI_DRM_12171_full -> Patchwork_108931v1_full Summa

Re: [Intel-gfx] [PATCH 0/6] Introduce struct cdclk_step

2022-09-23 Thread Ville Syrjälä
On Fri, Sep 23, 2022 at 04:56:53PM +, Srivatsa, Anusha wrote: > > > > -Original Message- > > From: Ville Syrjälä > > Sent: Tuesday, September 20, 2022 2:59 PM > > To: Srivatsa, Anusha > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > > ; Vivi, Rodrigo > > Subject: Re: [PATCH

[Intel-gfx] ✓ Fi.CI.IGT: success for Add PXP firmware respose on ARB failure

2022-09-23 Thread Patchwork
== Series Details == Series: Add PXP firmware respose on ARB failure URL : https://patchwork.freedesktop.org/series/108935/ State : success == Summary == CI Bug Log - changes from CI_DRM_12171_full -> Patchwork_108935v1_full Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Fix a potential UAF at device unload

2022-09-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix a potential UAF at device unload URL : https://patchwork.freedesktop.org/series/108944/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12171_full -> Patchwork_108944v1_full ==

[Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support

2022-09-23 Thread Badal Nilawar
This series adds the HWMON support for DGFX Test-with: 20220919144408.251981-1-riana.ta...@intel.com v2: - Reorganized series. Created first patch as infrastructure patch followed by feature patches. (Ashutosh) - Fixed review comments (Jani) - Fixed review comments (Ashutosh) v3: - F

[Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-23 Thread Badal Nilawar
From: Dale B Stimson The i915 HWMON module will be used to expose voltage, power and energy values for dGfx. Here we set up i915 hwmon infrastructure including i915 hwmon registration, basic data structures and functions. v2: - Create HWMON infra patch (Ashutosh) - Fixed review comments (Jan

[Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-09-23 Thread Badal Nilawar
From: Riana Tauro Use i915 HWMON subsystem to display current input voltage. v2: - Updated date and kernel version in feature description - Fixed review comments (Ashutosh) v3: Use macro HWMON_CHANNEL_INFO to define hwmon channel (Guenter) v4: - Fixed review comments (Ashutosh) - Use hwm

[Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-23 Thread Badal Nilawar
From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2: - Fix review comments (Ashutosh) - Do not restore power1_max upon module unload/load sequence because on production systems modules are always loaded and not unloaded/reloaded (Ashutosh)

[Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-09-23 Thread Badal Nilawar
From: Dale B Stimson Use i915 HWMON to display device level energy input. v2: Updated the date and kernel version in feature description v3: - Cleaned up hwm_energy function and removed unused function i915_hwmon_energy_status_get (Ashutosh) v4: KernelVersion: 6.2, Date: February 2023 in d

[Intel-gfx] [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power

2022-09-23 Thread Badal Nilawar
From: Ashutosh Dixit Expose the card reactive critical (I1) power. I1 is exposed as power1_crit in microwatts (typically for client products) or as curr1_crit in milliamperes (typically for server). v2: Add curr1_crit functionality (Ashutosh) v3: Use HWMON_CHANNEL_INFO to define power1_crit, cur

[Intel-gfx] [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV

2022-09-23 Thread Badal Nilawar
From: Dale B Stimson Extend hwmon power/energy for XEHPSDV especially per gt level energy usage. v2: Update to latest HWMON spec (Ashutosh) v3: Fix review comments (Ashutosh) v4: Fix review comments (Anshuman) Signed-off-by: Ashutosh Dixit Signed-off-by: Dale B Stimson Signed-off-by: Badal Ni

[Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-09-23 Thread Badal Nilawar
From: Ashutosh Dixit Expose power1_max_interval, that is the tau corresponding to PL1. Some bit manipulation is needed because of the format of PKG_PWR_LIM_1_TIME in GT0_PACKAGE_RAPL_LIMIT register (1.x * power(2,y)). v2: Update date and kernel version in Documentation (Badal) v3: Cleaned up hwm

[Intel-gfx] [PATCH v2 00/15] Add DG2 OA support

2022-09-23 Thread Umesh Nerlige Ramappa
Add OA format support for DG2 and various fixes for DG2. This series has 2 uapi changes listed below: 1) drm/i915/perf: Add OAG and OAR formats for DG2 DG2 has new OA formats defined that can be selected by the user. The UMD changes that are consumed by GPUvis are: https://patchwork.freedesktop.

[Intel-gfx] [PATCH v2 04/15] drm/i915/perf: Determine gen12 oa ctx offset at runtime

2022-09-23 Thread Umesh Nerlige Ramappa
Some SKUs of same gen12 platform may have different oactxctrl offsets. For gen12, determine oactxctrl offsets at runtime. v2: (Lionel) - Move MI definitions to intel_gpu_commands.h - Ensure __find_reg_in_lri does read past context image size Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/

  1   2   >