Re: [Intel-gfx] [PATCH v2 13/15] vfio/ccw: Use the new device life cycle helpers

2022-09-08 Thread Tian, Kevin
ping @Eric Farman. ccw is the only tricky player in this series. Please help take a look in case of any oversight here. > From: Tian, Kevin > Sent: Thursday, September 1, 2022 10:38 PM > > ccw is the only exception which cannot use vfio_alloc_device() because > its private device structure is d

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Noop lrc_init_wa_ctx() on recent/future platforms

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915: Noop lrc_init_wa_ctx() on recent/future platforms URL : https://patchwork.freedesktop.org/series/108278/ State : success == Summary == CI Bug Log - changes from CI_DRM_12090_full -> Patchwork_108278v1_full =

Re: [Intel-gfx] [PATCH v2 15/15] vfio: Add struct device to vfio_device

2022-09-08 Thread Eric Auger
Hi Kevin, On 9/1/22 16:37, Kevin Tian wrote: > From: Yi Liu > > and replace kref. With it a 'vfio-dev/vfioX' node is created under the > sysfs path of the parent, indicating the device is bound to a vfio > driver, e.g.: > > /sys/devices/pci\:6f/\:6f\:01.0/vfio-dev/vfio0 > > It is also a p

Re: [Intel-gfx] [PATCH v2 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-09-08 Thread Eric Auger
Hi Kevin, On 9/8/22 08:19, Tian, Kevin wrote: >> From: Eric Auger >> Sent: Thursday, September 8, 2022 3:28 AM >>> +/* >>> + * Alloc and initialize vfio_device so it can be registered to vfio >>> + * core. >>> + * >>> + * Drivers should use the wrapper vfio_alloc_device() for allocation. >>> + *

Re: [Intel-gfx] [PATCH] drm/dp_mst: Avoid deleting payloads for connectors staying enabled

2022-09-08 Thread Imre Deak
On Wed, Sep 07, 2022 at 02:23:51PM -0400, Lyude Paul wrote: > Surprised this didn't come up on Intel's CI (or at least it certainly didn't > when the series that introduced this was tested), Yes, this was a problem in CI which didn't have any MST sinks. Now there is and the problem is visible: htt

Re: [Intel-gfx] [PATCH v2 15/15] vfio: Add struct device to vfio_device

2022-09-08 Thread Yi Liu
On 2022/9/8 17:06, Eric Auger wrote: Hi Kevin, On 9/1/22 16:37, Kevin Tian wrote: From: Yi Liu and replace kref. With it a 'vfio-dev/vfioX' node is created under the sysfs path of the parent, indicating the device is bound to a vfio driver, e.g.: /sys/devices/pci\:6f/\:6f\:01.0/vfio-

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-08 Thread Greg KH
On Thu, Sep 08, 2022 at 05:09:40PM +0800, Zheng Hacker wrote: > Hi Zhenyu, > > This issue has been open for a few days. Could you plz write a patch > for that :) I'm not familiar with the logical code here. As this is only able to be hit in a theoretical system, it isn't that high of a priority,

Re: [Intel-gfx] [RFC PATCH 2/2] Fix per client busyness locking

2022-09-08 Thread Tvrtko Ursulin
On 07/09/2022 16:03, Dixit, Ashutosh wrote: On Wed, 07 Sep 2022 00:28:48 -0700, Tvrtko Ursulin wrote: On 06/09/2022 19:29, Umesh Nerlige Ramappa wrote: On Thu, Sep 01, 2022 at 04:55:22PM -0700, Dixit, Ashutosh wrote: On Wed, 31 Aug 2022 15:45:49 -0700, Umesh Nerlige Ramappa wrote: [snip]

Re: [Intel-gfx] [PATCH v2 15/15] vfio: Add struct device to vfio_device

2022-09-08 Thread Eric Auger
On 9/8/22 11:17, Yi Liu wrote: > On 2022/9/8 17:06, Eric Auger wrote: >> Hi Kevin, >> >> On 9/1/22 16:37, Kevin Tian wrote: >>> From: Yi Liu >>> >>> and replace kref. With it a 'vfio-dev/vfioX' node is created under the >>> sysfs path of the parent, indicating the device is bound to a vfio >>>

Re: [Intel-gfx] [PATCH] drm/i915: Rename ggtt_view as gtt_view

2022-09-08 Thread Tvrtko Ursulin
On 07/09/2022 14:48, Tvrtko Ursulin wrote: On 06/09/2022 17:14, Tvrtko Ursulin wrote: On 05/09/2022 10:34, Tvrtko Ursulin wrote: On 01/09/2022 19:38, Niranjana Vishwanathapura wrote: So far, different views (normal, partial, rotated and remapped) into the same object are only supported fo

Re: [Intel-gfx] [PATCH] drm/i915: Set correct domains values at _i915_vma_move_to_active

2022-09-08 Thread Matthew Auld
On 07/09/2022 18:26, Nirmoy Das wrote: Fix regression introduced by commit: "drm/i915: Individualize fences before adding to dma_resv obj" which sets obj->read_domains to 0 for both read and write paths. Also set obj->write_domain to 0 on read path which was removed by the commit. References: ht

Re: [Intel-gfx] [PATCH] drm/i915: Set correct domains values at _i915_vma_move_to_active

2022-09-08 Thread Das, Nirmoy
On 9/8/2022 11:40 AM, Matthew Auld wrote: On 07/09/2022 18:26, Nirmoy Das wrote: Fix regression introduced by commit: "drm/i915: Individualize fences before adding to dma_resv obj" which sets obj->read_domains to 0 for both read and write paths. Also set obj->write_domain to 0 on read path whi

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Set correct domains values at _i915_vma_move_to_active

2022-09-08 Thread Das, Nirmoy
On 9/8/2022 3:01 AM, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i915: Set correct domains values at _i915_vma_move_to_active *URL:* https://patchwork.freedesktop.org/series/108258/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patch

Re: [Intel-gfx] [PATCH] drm/i915: Set correct domains values at _i915_vma_move_to_active

2022-09-08 Thread Matthew Auld
On 08/09/2022 10:46, Das, Nirmoy wrote: On 9/8/2022 11:40 AM, Matthew Auld wrote: On 07/09/2022 18:26, Nirmoy Das wrote: Fix regression introduced by commit: "drm/i915: Individualize fences before adding to dma_resv obj" which sets obj->read_domains to 0 for both read and write paths. Also set

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "drm/i915/dg2: extend Wa_1409120013 to DG2" (rev2)

2022-09-08 Thread Patchwork
== Series Details == Series: Revert "drm/i915/dg2: extend Wa_1409120013 to DG2" (rev2) URL : https://patchwork.freedesktop.org/series/108266/ State : success == Summary == CI Bug Log - changes from CI_DRM_12091_full -> Patchwork_108266v2_full ===

Re: [Intel-gfx] [PATCH] drm/i915: Set correct domains values at _i915_vma_move_to_active

2022-09-08 Thread Das, Nirmoy
On 9/8/2022 12:13 PM, Matthew Auld wrote: On 08/09/2022 10:46, Das, Nirmoy wrote: On 9/8/2022 11:40 AM, Matthew Auld wrote: On 07/09/2022 18:26, Nirmoy Das wrote: Fix regression introduced by commit: "drm/i915: Individualize fences before adding to dma_resv obj" which sets obj->read_domains

Re: [Intel-gfx] [PATCH 5/8] drm/i915/gt: Fix perf limit reasons bit positions

2022-09-08 Thread Andi Shyti
Hi, On Wed, Sep 07, 2022 at 10:21:53PM -0700, Ashutosh Dixit wrote: > Perf limit reasons bit positions were off by one. > > Fixes: fa68bff7cf27 ("drm/i915/gt: Add sysfs throttle frequency interfaces") > Cc: sta...@vger.kernel.org # v5.18+ > Cc: Sujaritha Sundaresan > Cc: Andi Shyti > Signed-off

[Intel-gfx] ✗ Fi.CI.IGT: failure for Initial Meteorlake Support (rev8)

2022-09-08 Thread Patchwork
== Series Details == Series: Initial Meteorlake Support (rev8) URL : https://patchwork.freedesktop.org/series/106786/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12091_full -> Patchwork_106786v8_full Summary --- **

Re: [Intel-gfx] [PATCH] drm/i915: Invert if/else ladder for frequency read

2022-09-08 Thread Ville Syrjälä
On Wed, Sep 07, 2022 at 01:30:41PM -0700, Lucas De Marchi wrote: > Continue converting the driver to the convention of last version first, > extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will > be handled by the first branch. > > With the new ranges it's easier to see what plat

Re: [Intel-gfx] [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-08 Thread Maxime Ripard
Hi, On Tue, Aug 30, 2022 at 10:01:11AM -0300, Maíra Canal wrote: > On 8/29/22 10:11, Maxime Ripard wrote: > > Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and > > 625-lines modes in their drivers. > > > > Since those modes are fairly standard, and that we'll need to use them >

Re: [Intel-gfx] [PATCH v2 32/41] drm/vc4: vec: Convert to the new TV mode property

2022-09-08 Thread Maxime Ripard
Hi Noralf, On Tue, Aug 30, 2022 at 09:01:08PM +0200, Noralf Trønnes wrote: > > +static const struct drm_prop_enum_list tv_mode_names[] = { > > Maybe call it legacy_tv_mode_enums? > > > > > + { VC4_VEC_TV_MODE_NTSC, "NTSC", }, > > > > + { VC4_VEC_TV_MODE_NTSC_J, "NTSC-J", }, > > > > + {

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: freq caps and perf_limit_reasons changes for MTL (rev2)

2022-09-08 Thread Patchwork
== Series Details == Series: i915: freq caps and perf_limit_reasons changes for MTL (rev2) URL : https://patchwork.freedesktop.org/series/108091/ State : success == Summary == CI Bug Log - changes from CI_DRM_12091_full -> Patchwork_108091v2_full ===

Re: [Intel-gfx] [PATCH v2 32/41] drm/vc4: vec: Convert to the new TV mode property

2022-09-08 Thread Maxime Ripard
On Thu, Sep 08, 2022 at 01:31:34PM +0200, Mateusz Kwiatkowski wrote: > W dniu 08.09.2022 o 13:23, Maxime Ripard pisze: > > Hi Noralf, > > > > On Tue, Aug 30, 2022 at 09:01:08PM +0200, Noralf Trønnes wrote: > >>> +static const struct drm_prop_enum_list tv_mode_names[] = { > >> > >> Maybe call it leg

Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects

2022-09-08 Thread Tvrtko Ursulin
On 06/09/2022 18:46, Ville Syrjala wrote: From: Ville Syrjälä On gen3 the selftests are pretty much always tripping this: <4> [383.822424] pci :00:02.0: drm_WARN_ON(dev_priv->mm.shrink_count) <4> [383.822546] WARNING: CPU: 2 PID: 3560 at drivers/gpu/drm/i915/i915_gem.c:1223 i915_gem_clea

Re: [Intel-gfx] [PATCH 5/8] drm/i915/gt: Fix perf limit reasons bit positions

2022-09-08 Thread Sundaresan, Sujaritha
On 9/8/2022 4:12 PM, Andi Shyti wrote: Hi, On Wed, Sep 07, 2022 at 10:21:53PM -0700, Ashutosh Dixit wrote: Perf limit reasons bit positions were off by one. Fixes: fa68bff7cf27 ("drm/i915/gt: Add sysfs throttle frequency interfaces") Cc: sta...@vger.kernel.org # v5.18+ Cc: Sujaritha Sundares

[Intel-gfx] [PULL] drm-misc-fixes

2022-09-08 Thread Thomas Zimmermann
Hi Dave and Daniel, this is the weekly PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2022-09-08: Short summary of fixes pull: * edid: Fix EDID 1.4 range-descriptor parsing * panfrost: Fix devfreq OPP * ttm: Fix ghost-object bulk moves The following changes since commit a3f7c10a26

Re: [Intel-gfx] [PATCH 5/8] drm/i915/gt: Fix perf limit reasons bit positions

2022-09-08 Thread Andi Shyti
On Thu, Sep 08, 2022 at 06:07:08PM +0530, Sundaresan, Sujaritha wrote: > > On 9/8/2022 4:12 PM, Andi Shyti wrote: > > Hi, > > > > On Wed, Sep 07, 2022 at 10:21:53PM -0700, Ashutosh Dixit wrote: > > > Perf limit reasons bit positions were off by one. > > > > > > Fixes: fa68bff7cf27 ("drm/i915/gt:

Re: [Intel-gfx] [PATCH v3 05/11] drm/i915/mtl: Add gmbus and gpio support

2022-09-08 Thread Balasubramani Vivekanandan
On 31.08.2022 14:49, Radhakrishna Sripada wrote: > Add tables to map the GMBUS pin pairs to GPIO registers and port to DDC. > From spec we have registers GPIO_CTL[1-5] mapped to native display phys and > GPIO_CTL[9-12] are mapped to TC ports. > > v2: > - Drop unused GPIO pins(MattR) > > BSpec: 4

Re: [Intel-gfx] [PATCH v4 05/11] drm/i915/mtl: Add gmbus and gpio support

2022-09-08 Thread Balasubramani Vivekanandan
On 01.09.2022 23:03, Radhakrishna Sripada wrote: > Add tables to map the GMBUS pin pairs to GPIO registers and port to DDC. > From spec we have registers GPIO_CTL[1-5] mapped to native display phys and > GPIO_CTL[9-12] are mapped to TC ports. > > v2: > - Drop unused GPIO pins(MattR) > > BSpec: 4

Re: [Intel-gfx] [PATCH v2 32/41] drm/vc4: vec: Convert to the new TV mode property

2022-09-08 Thread Maxime Ripard
On Wed, Aug 31, 2022 at 04:23:21AM +0200, Mateusz Kwiatkowski wrote: > I tested your patchset on my Pi and it mostly works. Good work! However, > I noticed a couple of issues. > > > -static int vc4_vec_encoder_atomic_check(struct drm_encoder *encoder, > > -                    struct drm_crtc_state

Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects

2022-09-08 Thread Ville Syrjälä
On Thu, Sep 08, 2022 at 01:23:50PM +0100, Tvrtko Ursulin wrote: > > On 06/09/2022 18:46, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > On gen3 the selftests are pretty much always tripping this: > > <4> [383.822424] pci :00:02.0: drm_WARN_ON(dev_priv->mm.shrink_count) > > <4> [383.822

[Intel-gfx] [PULL] drm-intel-fixes

2022-09-08 Thread Rodrigo Vivi
Hi Dave and Daniel, A few fixes, but most targeting stable. Here goes drm-intel-fixes-2022-09-08: - Fix MIPI sequence block copy from BIOS' table. (Ville) - Fix PCODE min freq setup when GuC's SLPC is in use. (Rodrigo) - Implement Workaround for eDP. (Ville) - Fix has_flat_ccs selection for DG1.

Re: [Intel-gfx] (subset) [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable

2022-09-08 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:11:50 +0200, Maxime Ripard wrote: > Our mode_set implementation can be merged into our atomic_enable > implementation to simplify things, so let's do this. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects

2022-09-08 Thread Das, Nirmoy
Hi Ville, I fixed a similar issue in DII but I couldn't reproduce it in drm http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2. I wonder if that fixes the problem you are facing then I can send that to drm. diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects

2022-09-08 Thread Tvrtko Ursulin
On 08/09/2022 15:32, Das, Nirmoy wrote: Hi Ville, I fixed a similar issue in DII but I couldn't reproduce it in drm http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2. I wonder if that fixes the problem you are facing then I can send that to drm. diff --git a/drivers/gpu/d

Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects

2022-09-08 Thread Ville Syrjälä
On Thu, Sep 08, 2022 at 04:32:56PM +0200, Das, Nirmoy wrote: > Hi Ville, > > > I fixed a similar issue in DII but I couldn't reproduce it in drm > > http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2. > > I wonder if that fixes the problem you are facing then I can send that > t

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Kick rcu harder to free objects (rev2)

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915: Kick rcu harder to free objects (rev2) URL : https://patchwork.freedesktop.org/series/108196/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108196/revisions/2/mbox/ not applied Applying: drm/i915: Kick rcu h

Re: [Intel-gfx] [PATCH 5/8] drm/i915/gt: Fix perf limit reasons bit positions

2022-09-08 Thread Dixit, Ashutosh
On Thu, 08 Sep 2022 05:37:08 -0700, Sundaresan, Sujaritha wrote: > > On 9/8/2022 4:12 PM, Andi Shyti wrote: > > Hi, > > > > On Wed, Sep 07, 2022 at 10:21:53PM -0700, Ashutosh Dixit wrote: > >> Perf limit reasons bit positions were off by one. > >> > >> Fixes: fa68bff7cf27 ("drm/i915/gt: Add sysfs t

[Intel-gfx] [PATCH] drm/i915/gt: Fix perf limit reasons bit positions

2022-09-08 Thread Ashutosh Dixit
Perf limit reasons bit positions were off by one. Fixes: fa68bff7cf27 ("drm/i915/gt: Add sysfs throttle frequency interfaces") Cc: sta...@vger.kernel.org # v5.18+ Signed-off-by: Ashutosh Dixit Acked-by: Andi Shyti Reviewed-by: Sujaritha Sundaresan --- drivers/gpu/drm/i915/i915_reg.h | 16 +

Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix perf limit reasons bit positions

2022-09-08 Thread Dixit, Ashutosh
On Thu, 08 Sep 2022 08:58:21 -0700, Ashutosh Dixit wrote: > > Perf limit reasons bit positions were off by one. > > Fixes: fa68bff7cf27 ("drm/i915/gt: Add sysfs throttle frequency interfaces") > Cc: sta...@vger.kernel.org # v5.18+ > Signed-off-by: Ashutosh Dixit > Acked-by: Andi Shyti > Reviewed-

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for GSC support for XeHP SDV and DG2 (rev5)

2022-09-08 Thread Ceraolo Spurio, Daniele
On 9/7/2022 11:01 PM, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* GSC support for XeHP SDV and DG2 (rev5) *URL:* https://patchwork.freedesktop.org/series/106638/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106638v5/index.

Re: [Intel-gfx] [PATCH v3 05/14] drm/i915: Prepare more multi-GT initialization

2022-09-08 Thread Iddamsetty, Aravind
On 07-09-2022 05:19, Matt Roper wrote: > We're going to introduce an additional intel_gt for MTL's media unit > soon. Let's provide a bit more multi-GT initialization framework in > preparation for that. The initialization will pull the list of GTs for > a platform from the device info structu

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Fix perf limit reasons bit positions (rev2)

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix perf limit reasons bit positions (rev2) URL : https://patchwork.freedesktop.org/series/108277/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v3 12/14] drm/i915/xelpmp: Expose media as another GT

2022-09-08 Thread Iddamsetty, Aravind
On 07-09-2022 05:19, Matt Roper wrote: > Xe_LPM+ platforms have "standalone media." I.e., the media unit is > designed as an additional GT with its own engine list, GuC, forcewake, > etc. Let's allow platforms to include media GTs in their device info. > > v2: > - Simplify GSI register handl

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Fix perf limit reasons bit positions (rev2)

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix perf limit reasons bit positions (rev2) URL : https://patchwork.freedesktop.org/series/108277/ State : success == Summary == CI Bug Log - changes from CI_DRM_12098 -> Patchwork_108277v2 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Invert if/else ladder for frequency read

2022-09-08 Thread Lucas De Marchi
On Thu, Sep 08, 2022 at 02:08:55PM +0300, Ville Syrjälä wrote: On Wed, Sep 07, 2022 at 01:30:41PM -0700, Lucas De Marchi wrote: Continue converting the driver to the convention of last version first, extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will be handled by the first b

[Intel-gfx] [PATCH] drm/i915/dsb: hide struct intel_dsb better

2022-09-08 Thread Jani Nikula
struct intel_dsb can be an opaque type, hidden in intel_dsb.c. Make it so. Reduce related includes while at it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 1 + drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_dsb.c |

Re: [Intel-gfx] [PATCH v4.1] drm/i915: Move display and media IP version to runtime info

2022-09-08 Thread Matt Roper
On Fri, Sep 02, 2022 at 03:10:54PM -0700, Radhakrishna Sripada wrote: > Future platforms can read the IP version from a register and the > IP version numbers need not be hard coded in device info. Move the > ip version for media and display to runtime info. > > On platforms where hard coding of IP

Re: [Intel-gfx] [PATCH v4 03/11] drm/i915: Parse and set stepping for platforms with GMD

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:34PM -0700, Radhakrishna Sripada wrote: > From: José Roberto de Souza > > The GMD step field do not properly match the current stepping convention > that we use(STEP_A0, STEP_A1, STEP_B0...). > > One platform could have { arch = 12, rel = 70, step = 1 } and the > ac

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dsb: hide struct intel_dsb better

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915/dsb: hide struct intel_dsb better URL : https://patchwork.freedesktop.org/series/108310/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsb: hide struct intel_dsb better

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915/dsb: hide struct intel_dsb better URL : https://patchwork.freedesktop.org/series/108310/ State : success == Summary == CI Bug Log - changes from CI_DRM_12099 -> Patchwork_108310v1 Summary --- **S

Re: [Intel-gfx] [PATCH] drm/i915/dsb: hide struct intel_dsb better

2022-09-08 Thread Ville Syrjälä
On Thu, Sep 08, 2022 at 07:57:02PM +0300, Jani Nikula wrote: > struct intel_dsb can be an opaque type, hidden in intel_dsb.c. Make it > so. Reduce related includes while at it. > > Signed-off-by: Jani Nikula One thing I was mildly worried about with dsb is the cost of creating the batch (updatin

Re: [Intel-gfx] [PATCH v4.1] drm/i915/mtl: Define engine context layouts

2022-09-08 Thread Matt Roper
On Wed, Sep 07, 2022 at 04:33:17PM -0700, Radhakrishna Sripada wrote: > From: Matt Roper > > The part of the media and blitter engine contexts that we care about for > setting up an initial state are the same on MTL as they were on DG2 > (and PVC), so we need to update the driver conditions to re

Re: [Intel-gfx] [PATCH v4 05/11] drm/i915/mtl: Add gmbus and gpio support

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:36PM -0700, Radhakrishna Sripada wrote: > Add tables to map the GMBUS pin pairs to GPIO registers and port to DDC. > From spec we have registers GPIO_CTL[1-5] mapped to native display phys and > GPIO_CTL[9-12] are mapped to TC ports. > > v2: > - Drop unused GPIO pins

Re: [Intel-gfx] [PATCH v4 06/11] drm/i915/mtl: Add display power wells

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:37PM -0700, Radhakrishna Sripada wrote: > From: Imre Deak > > Add support for display power wells on MTL. The differences from XE_LPD: > - The AUX HW block is moved to the PICA block, where the registers are on > an always-on power well and the functionality needs

Re: [Intel-gfx] [PATCH v4 06/11] drm/i915/mtl: Add display power wells

2022-09-08 Thread Matt Roper
On Thu, Sep 08, 2022 at 11:07:16AM -0700, Matt Roper wrote: > On Thu, Sep 01, 2022 at 11:03:37PM -0700, Radhakrishna Sripada wrote: > > From: Imre Deak > > > > Add support for display power wells on MTL. The differences from XE_LPD: > > - The AUX HW block is moved to the PICA block, where the reg

Re: [Intel-gfx] [PATCH v4 07/11] drm/i915/mtl: Add DP AUX support on TypeC ports

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:38PM -0700, Radhakrishna Sripada wrote: > From: Imre Deak > > On MTL TypeC ports the AUX_CH_CTL and AUX_CH_DATA addresses have > changed wrt. previous platforms, adjust the code accordingly. > > Signed-off-by: Imre Deak > Signed-off-by: Radhakrishna Sripada As no

Re: [Intel-gfx] [PATCH] drm/i915/dsb: hide struct intel_dsb better

2022-09-08 Thread Jani Nikula
On Thu, 08 Sep 2022, Ville Syrjälä wrote: > On Thu, Sep 08, 2022 at 07:57:02PM +0300, Jani Nikula wrote: >> struct intel_dsb can be an opaque type, hidden in intel_dsb.c. Make it >> so. Reduce related includes while at it. >> >> Signed-off-by: Jani Nikula > > One thing I was mildly worried about

Re: [Intel-gfx] [PATCH 04/19] drm/i915/perf: Determine gen12 oa ctx offset at runtime

2022-09-08 Thread Lionel Landwerlin
On 06/09/2022 23:35, Umesh Nerlige Ramappa wrote: On Tue, Sep 06, 2022 at 10:48:50PM +0300, Lionel Landwerlin wrote: On 23/08/2022 23:41, Umesh Nerlige Ramappa wrote: Some SKUs of same gen12 platform may have different oactxctrl offsets. For gen12, determine oactxctrl offsets at runtime. Signe

[Intel-gfx] [PATCH 0/3] drm/i915: Move skl+ wm code into its own file

2022-09-08 Thread Ville Syrjala
From: Ville Syrjälä Hoist all the skl+ wm related stuff from intel_pm.c into its own file. Ville Syrjälä (3): drm/i915: Split intel_read_wm_latency() into per-platform versions drm/i915: Extract skl_watermark.c drm/i915: Use REG_FIELD_GET() to extract skl+ wm latencies drivers/gpu/drm/i9

[Intel-gfx] [PATCH 1/3] drm/i915: Split intel_read_wm_latency() into per-platform versions

2022-09-08 Thread Ville Syrjala
From: Ville Syrjälä No reaon to have this humongous if ladder in intel_read_wm_latency(). Just split it into nicer per-platforms functions. Also do the s/dev_priv/i915/ while touching all of this code. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_pm.c | 201 +---

[Intel-gfx] [PATCH 3/3] drm/i915: Use REG_FIELD_GET() to extract skl+ wm latencies

2022-09-08 Thread Ville Syrjala
From: Ville Syrjälä Replace the hand rolled stuff with REG_FIELD_GET() for reading out the skl+ watermark latencies. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/skl_watermark.c | 22 +++- drivers/gpu/drm/i915/i915_reg.h | 8 +++ 2 files chang

Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects

2022-09-08 Thread Das, Nirmoy
On 9/8/2022 4:55 PM, Tvrtko Ursulin wrote: On 08/09/2022 15:32, Das, Nirmoy wrote: Hi Ville, I fixed a similar issue in DII but I couldn't reproduce it in drm http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2. I wonder if that fixes the problem you are facing then I can se

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Move skl+ wm code into its own file

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915: Move skl+ wm code into its own file URL : https://patchwork.freedesktop.org/series/108313/ State : warning == Summary == Error: dim checkpatch failed eff551e7ad3c drm/i915: Split intel_read_wm_latency() into per-platform versions 129d570bf892 drm/i915: Ex

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Move skl+ wm code into its own file

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915: Move skl+ wm code into its own file URL : https://patchwork.freedesktop.org/series/108313/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915: Kick rcu harder to free objects

2022-09-08 Thread Das, Nirmoy
On 9/8/2022 5:11 PM, Ville Syrjälä wrote: On Thu, Sep 08, 2022 at 04:32:56PM +0200, Das, Nirmoy wrote: Hi Ville, I fixed a similar issue in DII but I couldn't reproduce it in drm http://intel-gfx-pw.fi.intel.com/patch/228850/?series=15910&rev=2. I wonder if that fixes the problem you are f

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move skl+ wm code into its own file

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915: Move skl+ wm code into its own file URL : https://patchwork.freedesktop.org/series/108313/ State : success == Summary == CI Bug Log - changes from CI_DRM_12100 -> Patchwork_108313v1 Summary ---

Re: [Intel-gfx] [PATCH v4 09/11] drm/i915/mtl: Update MBUS_DBOX credits

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:40PM -0700, Radhakrishna Sripada wrote: > Display version 14 platforms have different credits values > compared to ADL-P. Update the credits based on pipe usage. > > v2: Simplify DBOX BW Credit definition(MattR) > > Bspec: 49213 > > Cc: Jose Roberto de Souza > Cc:

[Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload

2022-09-08 Thread Nirmoy Das
i915_gem_drain_freed_objects() might not be enough to free all the objects and RCU delayed work might get scheduled after the i915 device struct gets freed. Call i915_gem_drain_workqueue() to catch all RCU delayed work. Suggested-by: Chris Wilson Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i

[Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects

2022-09-08 Thread Nirmoy Das
i915_gem_drain_workqueue() call i915_gem_drain_freed_objects() so no need to call that again. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/i915_gem.c | 2 -- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/gpu/d

[Intel-gfx] [PATCH v1 0/3] drm/i915: A couple of if/else ladder refactors

2022-09-08 Thread Lucas De Marchi
deletions(-) --- base-commit: adc57f2b82896fed07bc8e34956c15bb1448fca2 change-id: 20220908-if-ladder-df33a06d4f4e Best regards, -- Lucas De Marchi

[Intel-gfx] [PATCH v1 3/3] drm/i915: Invert if/else ladder for stolen init

2022-09-08 Thread Lucas De Marchi
Continue converting the driver to the convention of last version first, extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will be handled by the first branch. Signed-off-by: Lucas De Marchi diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_g

[Intel-gfx] [PATCH v1 1/3] drm/i915: Invert if/else ladder for frequency read

2022-09-08 Thread Lucas De Marchi
Continue converting the driver to the convention of last version first, extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will be handled by the first branch. With the new ranges it's easier to see what platform a branch started to be taken. Besides the >= 11 change, the branch tak

[Intel-gfx] [PATCH v1 2/3] drm/i915/gt: Extract per-platform function for frequency read

2022-09-08 Thread Lucas De Marchi
Instead of calling read_clock_frequency() to walk the if/else ladder per platform, move the ladder to intel_gt_init_clock_frequency() and use one function per branch. With the new logic, it's now clear the call to gen9_get_crystal_clock_freq() was just dead code, as gen9 is handled by another func

Re: [Intel-gfx] [PATCH v4 10/11] drm/i915/mtl: Update CHICKEN_TRANS* register addresses

2022-09-08 Thread Matt Roper
On Thu, Sep 01, 2022 at 11:03:41PM -0700, Radhakrishna Sripada wrote: > From: Madhumitha Tolakanahalli Pradeep > > > In Display version 14, Transcoder Chicken Registers have updated address. > This patch performs checks to use the right register when required. > > v2: Omit display version check

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix a potential UAF at device unload

2022-09-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix a potential UAF at device unload URL : https://patchwork.freedesktop.org/series/108314/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12100 -> Patchwork_108314v1

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Fix perf limit reasons bit positions (rev2)

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix perf limit reasons bit positions (rev2) URL : https://patchwork.freedesktop.org/series/108277/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12098_full -> Patchwork_108277v2_full

Re: [Intel-gfx] [PATCH v3 08/14] drm/i915: Initialize MMIO access for each GT

2022-09-08 Thread Ceraolo Spurio, Daniele
On 9/6/2022 4:49 PM, Matt Roper wrote: In a multi-GT system we need to initialize MMIO access for each GT, not just the primary GT. Cc: Daniele Ceraolo Spurio Reviewed-by: Daniele Ceraolo Spurio Daniele Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_driver.c | 27 +

Re: [Intel-gfx] [PATCH v3 09/14] drm/i915: Handle each GT on init/release and suspend/resume

2022-09-08 Thread Ceraolo Spurio, Daniele
On 9/6/2022 4:49 PM, Matt Roper wrote: In preparation for enabling a second GT, there are a number of GT/uncore operations that happen during initialization or suspend flows that need to be performed on each GT, not just the primary, Cc: Daniele Ceraolo Spurio Signed-off-by: Matt Roper Re

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: A couple of if/else ladder refactors

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915: A couple of if/else ladder refactors URL : https://patchwork.freedesktop.org/series/108315/ State : warning == Summary == Error: dim checkpatch failed 8e2c6bd18bc2 drm/i915: Invert if/else ladder for frequency read -:120: WARNING:UNNECESSARY_ELSE: else is

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: A couple of if/else ladder refactors

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915: A couple of if/else ladder refactors URL : https://patchwork.freedesktop.org/series/108315/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bito

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: A couple of if/else ladder refactors

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915: A couple of if/else ladder refactors URL : https://patchwork.freedesktop.org/series/108315/ State : success == Summary == CI Bug Log - changes from CI_DRM_12100 -> Patchwork_108315v1 Summary ---

Re: [Intel-gfx] [PATCH v3 10/14] drm/i915/uncore: Add GSI offset to uncore

2022-09-08 Thread Ceraolo Spurio, Daniele
On 9/6/2022 4:49 PM, Matt Roper wrote: GT non-engine registers (referred to as "GSI" registers by the spec) have the same relative offsets on standalone media as they do on the primary GT, just with an additional "GSI offset" added to their MMIO address. If we store this GSI offset in the sta

Re: [Intel-gfx] [PATCH v3 13/14] drm/i915/mtl: Use primary GT's irq lock for media GT

2022-09-08 Thread Ceraolo Spurio, Daniele
On 9/6/2022 4:49 PM, Matt Roper wrote: When we hook up interrupts (in the next patch), interrupts for the media GT are still processed as part of the primary GT's interrupt flow. As such, we should share the same IRQ lock with the primary GT. Let's convert gt->irq_lock into a pointer and jus

Re: [Intel-gfx] [PATCH v3 02/15] mei: add support to GSC extended header

2022-09-08 Thread Winkler, Tomas
> > On Fri, Aug 19, 2022 at 03:53:22PM -0700, Daniele Ceraolo Spurio wrote: > > --- a/drivers/misc/mei/hw-me.c > > +++ b/drivers/misc/mei/hw-me.c > > @@ -590,7 +590,10 @@ static int mei_me_hbuf_write(struct mei_device > *dev, > > u32 dw_cnt; > > int empty_slots; > > > > - if (WARN_ON(!

Re: [Intel-gfx] [PATCH v3 10/14] drm/i915/uncore: Add GSI offset to uncore

2022-09-08 Thread Matt Roper
On Thu, Sep 08, 2022 at 02:16:27PM -0700, Ceraolo Spurio, Daniele wrote: > > > On 9/6/2022 4:49 PM, Matt Roper wrote: > > GT non-engine registers (referred to as "GSI" registers by the spec) > > have the same relative offsets on standalone media as they do on the > > primary GT, just with an addi

[Intel-gfx] [PATCH v3.1 10/14] drm/i915/uncore: Add GSI offset to uncore

2022-09-08 Thread Matt Roper
GT non-engine registers (referred to as "GSI" registers by the spec) have the same relative offsets on standalone media as they do on the primary GT, just with an additional "GSI offset" added to their MMIO address. If we store this GSI offset in the standalone media's intel_uncore structure, it c

Re: [Intel-gfx] [PATCH v3.1 10/14] drm/i915/uncore: Add GSI offset to uncore

2022-09-08 Thread Ceraolo Spurio, Daniele
On 9/8/2022 3:45 PM, Matt Roper wrote: GT non-engine registers (referred to as "GSI" registers by the spec) have the same relative offsets on standalone media as they do on the primary GT, just with an additional "GSI offset" added to their MMIO address. If we store this GSI offset in the sta

Re: [Intel-gfx] [PATCH 04/19] drm/i915/perf: Determine gen12 oa ctx offset at runtime

2022-09-08 Thread Umesh Nerlige Ramappa
On Thu, Sep 08, 2022 at 09:32:12PM +0300, Lionel Landwerlin wrote: On 06/09/2022 23:35, Umesh Nerlige Ramappa wrote: On Tue, Sep 06, 2022 at 10:48:50PM +0300, Lionel Landwerlin wrote: On 23/08/2022 23:41, Umesh Nerlige Ramappa wrote: Some SKUs of same gen12 platform may have different oactxctr

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Add "standalone media" support for MTL (rev5)

2022-09-08 Thread Patchwork
== Series Details == Series: i915: Add "standalone media" support for MTL (rev5) URL : https://patchwork.freedesktop.org/series/107908/ State : warning == Summary == Error: dim checkpatch failed 6c1062d5ca5c drm/i915: Move locking and unclaimed check into mmio_debug_{suspend, resume} 71776530

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Add "standalone media" support for MTL (rev5)

2022-09-08 Thread Patchwork
== Series Details == Series: i915: Add "standalone media" support for MTL (rev5) URL : https://patchwork.freedesktop.org/series/107908/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Add "standalone media" support for MTL (rev5)

2022-09-08 Thread Patchwork
== Series Details == Series: i915: Add "standalone media" support for MTL (rev5) URL : https://patchwork.freedesktop.org/series/107908/ State : success == Summary == CI Bug Log - changes from CI_DRM_12101 -> Patchwork_107908v5 Summary -

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsb: hide struct intel_dsb better

2022-09-08 Thread Patchwork
== Series Details == Series: drm/i915/dsb: hide struct intel_dsb better URL : https://patchwork.freedesktop.org/series/108310/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12099_full -> Patchwork_108310v1_full Summary

[Intel-gfx] [CI] PR for new HuC binary

2022-09-08 Thread Daniele Ceraolo Spurio
The following changes since commit 2f2f0181581d3e35bfdb9fc65f609ee9d3fbaeb7: Mellanox: Add new mlxsw_spectrum firmware xx.2010.3146 (2022-09-02 07:28:59 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware dg2_huc_7.10.6 for you to fetch changes up

[Intel-gfx] [PATCH v4 00/15]

2022-09-08 Thread Daniele Ceraolo Spurio
On DG2, HuC loading is performed by the GSC, via a PXP command. The load operation itself is relatively simple (just send a message to the GSC with the physical address of the HuC in LMEM), but there are timing changes that requires special attention. In particular, to send a PXP command we need to

Re: [Intel-gfx] [PATCH v4 00/15]

2022-09-08 Thread Ceraolo Spurio, Daniele
Please ignore this cover letter, I've only realized I was missing a title and aborted the git-send after sending it. Proper series coming in a couple of mins. Daniele On 9/8/2022 5:10 PM, Daniele Ceraolo Spurio wrote: On DG2, HuC loading is performed by the GSC, via a PXP command. The load op

[Intel-gfx] [PATCH v4 00/15] drm/i915: HuC loading for DG2

2022-09-08 Thread Daniele Ceraolo Spurio
On DG2, HuC loading is performed by the GSC, via a PXP command. The load operation itself is relatively simple (just send a message to the GSC with the physical address of the HuC in LMEM), but there are timing changes that requires special attention. In particular, to send a PXP command we need to

[Intel-gfx] [PATCH v4 03/15] mei: adjust extended header kdocs

2022-09-08 Thread Daniele Ceraolo Spurio
From: Tomas Winkler Fix kdoc for struct mei_ext_hdr and mei_ext_begin(). V4: New in the series Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Cc: Greg Kroah-Hartman --- drivers/misc/mei/hw.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/driv

[Intel-gfx] [PATCH v4 01/15] mei: add support to GSC extended header

2022-09-08 Thread Daniele Ceraolo Spurio
From: Tomas Winkler GSC extend header is of variable size and data is provided in a sgl list inside the header and not in the data buffers, need to enable the path. V2: 1. Add missing kdoc for mei_cl_cb 2. In mei_me_hbuf_write() use dev_err() when validationg parameters instead of WARN_ON()

[Intel-gfx] [PATCH v4 10/15] drm/i915/dg2: setup HuC loading via GSC

2022-09-08 Thread Daniele Ceraolo Spurio
The GSC will perform both the load and the authentication, so we just need to check the auth bit after the GSC has replied. Since we require the PXP module to load the HuC, the earliest we can trigger the load is during the pxp_bind operation. Note that GSC-loaded HuC survives GT reset, so we need

  1   2   >