Re: [Intel-gfx] [RFC 7/7] drm/i915/guc: Print the GuC error capture output register list.

On 07/01/2022 17:03, Teres Alexis, Alan Previn wrote: On Fri, 2022-01-07 at 09:03 +, Tvrtko Ursulin wrote: On 06/01/2022 18:33, Teres Alexis, Alan Previn wrote: On Thu, 2022-01-06 at 09:38 +, Tvrtko Ursulin wrote: On 05/01/2022 17:30, Teres Alexis, Alan Previn wrote: On Tue, 2022-0

[Intel-gfx] [PATCH 1/4] drm/i915: split out PCI config space registers from i915_reg.h

The PCI config space registers don't really belong next to the MMIO register definitions. v2: Fix copyright year (Matt) Cc: Matt Roper Reviewed-by: Matt Roper Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_backlight.c| 1 + drivers/gpu/drm/i915/display/intel_cdclk.c|

[Intel-gfx] [PATCH 3/4] drm/i915/vga: switch to use VGA definitions from video/vga.h

The video/vga.h has macros for the VGA registers. Switch to use them. Suggested-by: Matt Roper Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vga.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers

[Intel-gfx] [PATCH 2/4] drm/i915: split out vlv sideband registers from i915_reg.h

Add a dedicated file vlv_sideband_reg.h for the VLV/CHV sideband registers. The sideband registers macros are needed by the same files that need vlv_sideband.h, so include the definitions from there. v2: Fix copyright year (Matt) Cc: Matt Roper Reviewed-by: Matt Roper Signed-off-by: Jani Nikula

[Intel-gfx] [PATCH 4/4] drm/i915: remove VGA register definitions

The only user of the VGA registers has switched to using the definitions in linux/vga.h, so these have become redundant. Remove them. Suggested-by: Matt Roper Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 41 - 1 file changed, 41 deletions(-)

Re: [Intel-gfx] [PATCH 2/3] drm/i915: move VGA registers to intel_vga.c

On Fri, 07 Jan 2022, Matt Roper wrote: > On Fri, Jan 07, 2022 at 11:49:50AM +0200, Jani Nikula wrote: >> The only users of the VGA register macros are in intel_vga.c. Hide the >> macros there. >> >> Cc: Matt Roper >> Signed-off-by: Jani Nikula > > It looks like only 5 of the ~30 registers here

Re: [Intel-gfx] [PATCH 1/3] drm/i915: split out PCI config space registers from i915_reg.h

On Fri, 07 Jan 2022, Matt Roper wrote: > On Fri, Jan 07, 2022 at 11:49:49AM +0200, Jani Nikula wrote: >> The PCI config space registers don't really belong next to the MMIO >> register definitions. >> >> Cc: Matt Roper >> Signed-off-by: Jani Nikula >> --- > ... >> diff --git a/drivers/gpu/drm/i

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: split out PCI config space registers from i915_reg.h

== Series Details == Series: series starting with [1/4] drm/i915: split out PCI config space registers from i915_reg.h URL : https://patchwork.freedesktop.org/series/98672/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6a1b0048ac62 drm/i915: split out PCI config space register

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: split out PCI config space registers from i915_reg.h

== Series Details == Series: series starting with [1/4] drm/i915: split out PCI config space registers from i915_reg.h URL : https://patchwork.freedesktop.org/series/98672/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won'

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Drop unused register definitions

On Fri, 07 Jan 2022, Lucas De Marchi wrote: > On Fri, Jan 07, 2022 at 12:46:48PM +0200, Jani Nikula wrote: >>I still tell people to 1) split out register definitions to separate >>patches, and 2) add macros for the entire feature and full contents for >>each register, even if they remain unused. >

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915/gt: Move engine registers to their own header

On Fri, 07 Jan 2022, Matt Roper wrote: > Let's start breaking up and cleaning up the massive i915_reg.h file. > We'll start by moving all registers that are defined in relation to an > engine base to their own header. > > There are probably a bunch of other "engine registers" that we haven't > mov

Re: [Intel-gfx] [PATCH v2 7/7] drm/i915: Move SNPS PHY registers to their own header

On Fri, 07 Jan 2022, Matt Roper wrote: > These registers are only needed in a couple files and on specific > platforms; let's keep them separate from the general register pool. > > Cc: Jani Nikula > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_snps_phy.c | 1 + > .../dr

Re: [Intel-gfx] [PATCH v2 7/7] drm/i915: Move SNPS PHY registers to their own header

On Mon, 10 Jan 2022, Jani Nikula wrote: > On Fri, 07 Jan 2022, Matt Roper wrote: >> These registers are only needed in a couple files and on specific >> platforms; let's keep them separate from the general register pool. >> >> Cc: Jani Nikula >> Signed-off-by: Matt Roper >> --- >> drivers/gpu/

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: split out PCI config space registers from i915_reg.h

== Series Details == Series: series starting with [1/4] drm/i915: split out PCI config space registers from i915_reg.h URL : https://patchwork.freedesktop.org/series/98672/ State : success == Summary == CI Bug Log - changes from CI_DRM_11058 -> Patchwork_21947

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: Parameterize PWRCTX_MAXCNT

On Fri, 07 Jan 2022, Matt Roper wrote: > Rather than having separate definitions for each engine, create a single > parameterized macro that takes the engine base offset. This will also > ensure we get to the proper offset if we ever need to use these > registers on newer platforms (where the med

Re: [Intel-gfx] [PATCH v2 3/7] drm/i915: Parameterize ECOSKPD

On Fri, 07 Jan 2022, Matt Roper wrote: > Combine the separate render and blitter register definitions into a > single definition. We already know we have some workarounds on an > upcoming platform that will need to update the ECOSKPD register for > other engines too, so this helps pave the way fo

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915: Use RING_PSMI_CTL rather than per-engine macros

On Fri, 07 Jan 2022, Matt Roper wrote: > We have a parameterized macro for RING_PSMI_CTL; let's use that instead > of the per-engine definitions where possible. > > Cc: Jani Nikula > Signed-off-by: Matt Roper Reviewed-by: Jani Nikula > --- > .../gpu/drm/i915/gt/intel_ring_submission.c | 10

Re: [Intel-gfx] [PATCH v2 5/7] drm/i915: Replace GFX_MODE_GEN7 with RING_MODE_GEN7

On Fri, 07 Jan 2022, Matt Roper wrote: > It's preferable to use parameterized register macros where possible. > > Signed-off-by: Matt Roper Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- > drivers/gpu/drm/i915/gvt/mmio_context.c | 4 ++-- > drivers/gp

Re: [Intel-gfx] [PATCH v2 1/7] drm/i915: Use parameterized GPR register definitions everywhere

On Fri, 07 Jan 2022, Matt Roper wrote: > Since we have an engine-parameterized macro GEN8_RING_CS_GPR, let's use > that in place of the HSW_CS_GPR and BCS_GPR register definitions. > > Cc: Jani Nikula > Signed-off-by: Matt Roper Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_cmd_

[Intel-gfx] [PATCH v4 2/7] drm/i915: Add locking to i915_gem_evict_vm()

i915_gem_evict_vm will need to be able to evict objects that are locked by the current ctx. By testing if the current context already locked the object, we can do this correctly. This allows us to evict the entire vm even if we already hold some objects' locks. Previously, this was spread over sev

[Intel-gfx] [PATCH v4 0/7] drm/i915: Remove short term pins from execbuf by requiring lock to unbind.

Previously, short term pinning in execbuf was required because i915_vma was effectively independent from objects, and has its own refcount, locking, lifetime rules and pinning. This series removes the separate locking, by requiring vma->obj->resv to be held when pinning and unbinding. This will al

[Intel-gfx] [PATCH v4 1/7] drm/i915: Call i915_gem_evict_vm in vm_fault_gtt to prevent new ENOSPC errors, v2.

Now that we cannot unbind kill the currently locked object directly because we're removing short term pinning, we may have to unbind the object from gtt manually, using a i915_gem_evict_vm() call. Changes since v1: - Remove -ENOSPC warning, can still happen with concurrent mmaps where we can't u

[Intel-gfx] [PATCH v4 3/7] drm/i915: Add object locking to i915_gem_evict_for_node and i915_gem_evict_something

Because we will start to require the obj->resv lock for unbinding, ensure these shrinker functions also take the lock. This requires some function signature changes, to ensure that the ww context is passed around, but is mostly straightforward. Previously this was split up into several patches, b

[Intel-gfx] [PATCH v4 4/7] drm/i915: Add i915_vma_unbind_unlocked, and take obj lock for i915_vma_unbind, v2.

We want to remove more members of i915_vma, which requires the locking to be held more often. Start requiring gem object lock for i915_vma_unbind, as it's one of the callers that may unpin pages. Some special care is needed when evicting, because the last reference to the object may be held by th

[Intel-gfx] [PATCH v4 7/7] drm/i915: Remove short-term pins from execbuf, v6.

Add a flag PIN_VALIDATE, to indicate we don't need to pin and only protected by the object lock. This removes the need to unpin, which is done by just releasing the lock. eb_reserve is slightly reworked for readability, but the same steps are still done: - First pass pins with NONBLOCK. - Second

[Intel-gfx] [PATCH v4 6/7] drm/i915: Remove support for unlocked i915_vma unbind

Now that we require the object lock for all ops, some code handling race conditions can be removed. This is required to not take short-term pins inside execbuf. Signed-off-by: Maarten Lankhorst Acked-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_vma.c | 55 +--

[Intel-gfx] [PATCH v4 5/7] drm/i915: Remove assert_object_held_shared

This duck tape workaround is no longer required, unbind and destroy are fixed to take the obj->resv mutex before destroying and obj->mm.lock has been removed, always requiring obj->resv as well. Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_obj

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2)

== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2) URL : https://patchwork.freedesktop.org/series/98137/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0a564d5e4bd9 drm/i915: Call i915_gem_evict_vm in vm_fault_gtt to p

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2)

== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2) URL : https://patchwork.freedesktop.org/series/98137/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be che

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: split out PCI config space registers from i915_reg.h

== Series Details == Series: series starting with [1/4] drm/i915: split out PCI config space registers from i915_reg.h URL : https://patchwork.freedesktop.org/series/98672/ State : success == Summary == CI Bug Log - changes from CI_DRM_11058_full -> Patchwork_21947_full ==

Re: [Intel-gfx] [PATCH v6 4/6] drm/i915: Use vma resources for async unbinding

On 07/01/2022 14:23, Thomas Hellström wrote: Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences should

[Intel-gfx] [PATCH v2 2/6] drm/plane: Fix typo in format_mod_supported documentation

Fix minor typo: "valdiate" -> "validate". Signed-off-by: José Expósito --- include/drm/drm_plane.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 0c1102dc4d88..06759badf99f 100644 --- a/include/drm/drm_plane.h +++ b/inc

[Intel-gfx] [PATCH] drm/i915: remove questionable fence optimization during copy

First of all as discussed multiple times now kernel copies *must* always wait for all fences in a BO before actually doing the copy. This is mandatory. Additional to that drop the handling when there can't be a shared slot allocated on the source BO and just properly return an error code. Otherwis

[Intel-gfx] [PATCH v3 6/6] drm/stm: ltdc: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/stm/ltdc.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index dbdee954692a

[Intel-gfx] [PATCH v2 5/6] drm: mxsfb: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c i

Re: [Intel-gfx] [PATCH v3 2/6] drm/plane: Fix typo in format_mod_supported documentation

Hi Simon, On Wed, Jan 05, 2022 at 11:54:43PM +, Simon Ser wrote: > Pushed patches 1 & 2 to drm-misc-next. Thanks for your contribution! Thanks a lot for the review and for applying the changes, appreciate it. Is there something that needs to improve in the other 4 patches? Or just waiting on

[Intel-gfx] [PATCH -next] drm/i915/gvt: Fix intel_vgpu_default_mmio_write() kernel-doc comment

Fix function name in handlers.c kernel-doc comment to remove some warnings found by running scripts/kernel-doc, which is caused by using 'make W=1'. drivers/gpu/drm/i915/gvt/handlers.c:3812: warning: expecting prototype for intel_t_default_mmio_write(). Prototype was for intel_vgpu_default_mmio_wri

Re: [Intel-gfx] [PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional

Thanks for your reviews :) I'll wait a couple of days to see if somebody else wants to comment and I'll send v3 adding the reviewed by tags and fixing the compiler warning. On Thu, Dec 23, 2021 at 05:03:19PM +0200, Ville Syrjälä wrote: > Another related thing that might be worth checking is whethe

[Intel-gfx] [PATCH v2 0/6] Add missing format_mod_supported functions

Hi all, This patchset supersedes [1]. Now the title is a bit misleading, but I left it this way to (hopefully) facilitate the maintainers' work. A little context: Originally, I sent a patch adding modifiers to the VKMS driver and Simon Ser kindly reviewed it and pointed out that "format_mod_suppo

[Intel-gfx] [PATCH v2 3/6] drm/simple-kms: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/drm_simple_kms_helper.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_sim

Re: [Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

LGTM — Aun-Ali Zaidi > On Jan 8, 2022, at 3:59 AM, Ashish Arora > wrote: > > > I believe I forgot to add Aditya to the conversation. So, I am sending the > patch as an attachment for those who want to test :)<0001-drm.patch>

[Intel-gfx] [PATCH v3 0/6] Add missing format_mod_supported functions

Hi all, This patchset supersedes [1]. Now the title is a bit misleading, but I left it this way to (hopefully) facilitate the maintainers' work. A little context: Originally, I sent a patch adding modifiers to the VKMS driver and Simon Ser kindly reviewed it and pointed out that "format_mod_suppo

[Intel-gfx] [PATCH -next v2] drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

Fix the following coccicheck warning: ./drivers/gpu/drm/i915/display/intel_fbc.c:1757:0-23: WARNING: intel_fbc_debugfs_false_color_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/i915/display/intel_fbc.c | 8 1 fi

Re: [Intel-gfx] [PATCH] drm/i915: remove questionable fence optimization during copy

Am 21.12.21 um 16:47 schrieb Thomas Hellström: Hi, Christian, On Tue, 2021-12-21 at 15:07 +0100, Christian König wrote: First of all as discussed multiple times now kernel copies *must* always wait for all fences in a BO before actually doing the copy. This is mandatory. This patch looks ok to

[Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

From: Ashish Arora On certain 4k panels, the BIOS framebuffer is larger than what panel requires causing display corruption. Introduce a check for the same. Signed-off-by: Ashish Arora --- drivers/gpu/drm/i915/display/intel_fbdev.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

May I add your reviewed-by Aun-Ali Zaidi ? > On 08-Jan-2022, at 3:56 PM, Aun-Ali Zaidi wrote: > > LGTM > > — > Aun-Ali Zaidi > >> On Jan 8, 2022, at 3:59 AM, Ashish Arora >> wrote: >> >> >> I believe I forgot to add Aditya to the conversation. So, I am sending the >> patch as an attachmen

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/fbc: Register per-crtc debugfs files

Hi Ville, On Mon, Dec 13, 2021 at 05:14:35PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Expose FBC debugfs files for each crtc. These may or may not point > to the same FBC instance depending on the platform. > > We leave the old global debugfs files in place until > igt catches up t

[Intel-gfx] [PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional

The documentation for "drm_plane_funcs.format_mod_supported" reads: This *optional* hook is used for the DRM to determine if the given format/modifier combination is valid for the plane. This allows the DRM to generate the correct format bitmask (which formats apply to which modifier), and

[Intel-gfx] [PATCH v2 4/6] drm/i915/display: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/i915/display/intel_cursor.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm

Re: [Intel-gfx] [PATCH - v2] drm/i915: Discard large BIOS framebuffers causing display corruption.

Hi Jani Please review the patch and tell is something else is required. From: Ashish Arora Sent: Friday, 7 January, 2022, 8:32 pm To: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com; rodrigo.v...@intel.com Cc: intel-gfx@lists.freedesktop.org; Linux

[Intel-gfx] [PATCH] drm/i915/selftests: Fix NULL vs IS_ERR checking for kernel_context

Since i915_gem_create_context() function return error pointers, the kernel_context() function does not return null, It returns error pointers too. Using IS_ERR() to check the return value to fix this. Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/i915/gt/selftest_execlists.c | 41 +

[Intel-gfx] [PATCH v3 4/6] drm/i915/display: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/i915/display/intel_cursor.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

Hi Orlando Thanks for informing that the Macs are also affected :). I've sne the v2 of the patch. You may try out if you want to. Get Outlook for Android From: Orlando Chamberlain Sent: Saturday, January 8, 2022 10:41:50 AM To: jani.nik..

[Intel-gfx] [PATCH v2 6/6] drm/stm: ltdc: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/stm/ltdc.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index dbdee954692a

[Intel-gfx] [PATCH v3 5/6] drm: mxsfb: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c i

[Intel-gfx] i915 hangs up every second time in deep suspend

My Lenovo Thinkbook 13s-IWL is hanging up every second time when I put the device into the deep suspend mode. I put the device into suspend, the display is turning off, but the power button does not reach the slowly flashing mode. After a while the Laptop simply reboots. I was able to work around

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/fbc: Register per-crtc debugfs files

On Tue, Dec 21, 2021 at 06:05:34PM +0200, Ville Syrjälä wrote: > On Sat, Dec 18, 2021 at 06:00:47PM -0700, Nathan Chancellor wrote: > > Hi Ville, > > > > On Mon, Dec 13, 2021 at 05:14:35PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Expose FBC debugfs files for each crtc. T

Re: [Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

I believe I forgot to add Aditya to the conversation. So, I am sending the patch as an attachment for those who want to test :) 0001-drm.patch Description: 0001-drm.patch

[Intel-gfx] [PATCH -next] drm/i915/fbc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

Fix the following coccicheck warning: ./drivers/gpu/drm/i915/display/intel_fbc.c:1757:0-23: WARNING: intel_fbc_debugfs_false_color_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- 1 file cha

[Intel-gfx] [PATCH - v2] drm/i915: Discard large BIOS framebuffers causing display corruption.

From: Ashish Arora On certain 4k panels, the BIOS framebuffer is larger than what panel requires causing display corruption. Introduce a check for the same. Signed-off-by: Ashish Arora --- drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) d

[Intel-gfx] [PATCH v3 3/6] drm/simple-kms: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito --- drivers/gpu/drm/drm_simple_kms_helper.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_sim

[Intel-gfx] [PATCH] i915: make array flex_regs static const

Don't populate the read-only array flex_regs on the stack but instead it static const. Also makes the object code a little smaller. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_per

[Intel-gfx] [PATCH v3 2/6] drm/plane: Fix typo in format_mod_supported documentation

Fix minor typo: "valdiate" -> "validate". Signed-off-by: José Expósito Reviewed-by: Simon Ser --- include/drm/drm_plane.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 0c1102dc4d88..06759badf99f 100644 --- a/include/d

[Intel-gfx] [PATCH v3 1/6] drm/plane: Make format_mod_supported truly optional

The documentation for "drm_plane_funcs.format_mod_supported" reads: This *optional* hook is used for the DRM to determine if the given format/modifier combination is valid for the plane. This allows the DRM to generate the correct format bitmask (which formats apply to which modifier), and

Re: [Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

> On 07-Jan-2022, at 6:17 PM, Jani Nikula wrote: > > On Fri, 07 Jan 2022, Ashish Arora wrote: >> From: Ashish Arora >> >> On certain 4k panels, the BIOS framebuffer is larger than what panel >> requires causing display corruption. Introduce a check for the same. > > This is quite thin on de

Re: [Intel-gfx] [PATCH] drm/i915: Discard large BIOS framebuffers causing display corruption.

On 07-Jan-2022, at 6:17 PM, Jani Nikula mailto:jani.nik...@linux.intel.com>> wrote: On Fri, 07 Jan 2022, Ashish Arora mailto:ashisharora.li...@outlook.com>> wrote: From: Ashish Arora mailto:ashisharora.li...@outlook.com>> On certain 4k panels, the BIOS framebuffer is larger than what panel r

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: remove questionable fence optimization during copy

== Series Details == Series: drm/i915: remove questionable fence optimization during copy URL : https://patchwork.freedesktop.org/series/98679/ State : failure == Summary == Applying: drm/i915: remove questionable fence optimization during copy Using index info to reconstruct a base tree... M

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2)

== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2) URL : https://patchwork.freedesktop.org/series/98137/ State : success == Summary == CI Bug Log - changes from CI_DRM_11059 -> Patchwork_21948

Re: [Intel-gfx] [PATCH v6 5/6] drm/i915: Asynchronous migration selftest

On 07/01/2022 14:23, Thomas Hellström wrote: Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound vma set up on the migrated buffer object. Signed-off-by: Thomas Hellström --- driver

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Fix intel_vgpu_default_mmio_write() kernel-doc comment

== Series Details == Series: drm/i915/gvt: Fix intel_vgpu_default_mmio_write() kernel-doc comment URL : https://patchwork.freedesktop.org/series/98681/ State : success == Summary == CI Bug Log - changes from CI_DRM_11059 -> Patchwork_21950

Re: [Intel-gfx] [PATCH v6 6/6] drm/i915: Use struct vma_resource instead of struct vma_snapshot

On Fri, 7 Jan 2022 at 14:24, Thomas Hellström wrote: > > There is always a struct vma_resource guaranteed to be alive when we > access a corresponding struct vma_snapshot. > > So ditch the latter and instead of allocating vma_snapshots, reference > the already existning vma_resource. > > This requ

Re: [Intel-gfx] [PATCH 0/5] drm/i915: clean up i915_drv.h, part 1

On Fri, 07 Jan 2022, Jani Nikula wrote: > On Fri, 07 Jan 2022, Jani Nikula wrote: >> First five patches from [1], chopping it up a bit. > > Aarrgh. Today I learned, the hard way, that you can actually specify > both files *and* rev-list to git send-email at the same time, and it'll > send all. *f

Re: [Intel-gfx] [PATCH 2/4] drm/i915: split out vlv sideband registers from i915_reg.h

On Mon, 10 Jan 2022, Jani Nikula wrote: > Add a dedicated file vlv_sideband_reg.h for the VLV/CHV sideband > registers. The sideband registers macros are needed by the same files > that need vlv_sideband.h, so include the definitions from there. > > v2: Fix copyright year (Matt) > > Cc: Matt Roper

Re: [Intel-gfx] [PATCH v6 5/6] drm/i915: Asynchronous migration selftest

On 1/10/22 14:59, Matthew Auld wrote: On 07/01/2022 14:23, Thomas Hellström wrote: Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound vma set up on the migrated buffer object. Sign

Re: [Intel-gfx] [PATCH v6 5/6] drm/i915: Asynchronous migration selftest

On 10/01/2022 14:36, Thomas Hellström wrote: On 1/10/22 14:59, Matthew Auld wrote: On 07/01/2022 14:23, Thomas Hellström wrote: Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound vm

Re: [Intel-gfx] [PATCH v6 4/6] drm/i915: Use vma resources for async unbinding

On 1/10/22 14:21, Matthew Auld wrote: On 07/01/2022 14:23, Thomas Hellström wrote: Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration

[Intel-gfx] [PATCH 0/6] drm/i915: clean up i915_drv.h, part 2

Next six patches from [1], chopping it up a bit. BR, Jani. [1] https://patchwork.freedesktop.org/series/98515/ Jani Nikula (6): drm/i915: split out i915_gem.h declarations from i915_drv.h drm/i915: split out i915_gem_internal.h from i915_drv.h drm/i915: remove leftover i915_gem_pm.h decla

[Intel-gfx] [PATCH 1/6] drm/i915: split out i915_gem.h declarations from i915_drv.h

i915_gem.h should be the place for declarations for i915_gem.c, but looks like it's filled with all sorts of cruft. Even so, move the declarations where they belong. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 32 - drive

[Intel-gfx] [PATCH 2/6] drm/i915: split out i915_gem_internal.h from i915_drv.h

We already have the i915_gem_internal.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dsb.c | 2 ++ drivers/gpu/drm/i915/display/intel_overlay.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_internal.c | 1 + drivers/gpu/drm/i915/gem/i915_

[Intel-gfx] [PATCH 4/6] drm/i915: split out gem/i915_gem_dmabuf.h from i915_drv.h

We already have the gem/i915_gem_dmabuf.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_dmabuf.h | 18 ++ drivers/gpu/drm/i915/gem/i915_gem_object.c | 2 ++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH 5/6] drm/i915: split out gem/i915_gem_create.h from i915_drv.h

We already have the gem/i915_gem_create.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_create.h | 17 + drivers/gpu/drm/i915/i915_driver.c | 1 + drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH 6/6] drm/i915: split out gem/i915_gem_domain.h from i915_drv.h

We already have the gem/i915_gem_domain.c file. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dpt.c| 4 +++- drivers/gpu/drm/i915/display/intel_fb_pin.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_domain.c | 5 +++-- drivers/gpu/drm/i915/gem/i91

[Intel-gfx] [PATCH 3/6] drm/i915: remove leftover i915_gem_pm.h declarations from i915_drv.h

Remove the duplicates. Acked-by: Tvrtko Ursulin Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 4 drivers/gpu/drm/i915/i915_gem.c | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index b

Re: [Intel-gfx] [PATCH 3/3] drm/atomic: Make private objs proper objects

On Fri, Dec 31, 2021 at 03:23:31PM +0200, Jani Nikula wrote: > On Wed, 12 Jul 2017, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Make the atomic private object stuff less special by introducing proper > > base classes for the object and its state. Drivers can embed these in

Re: [Intel-gfx] [PATCH 1/2] drm/dp: note that DPCD 0x2002-0x2003 match 0x200-0x201

On Tue, Jan 04, 2022 at 08:48:56PM +0200, Jani Nikula wrote: > DP_SINK_COUNT_ESI and DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0 have the same > contents as DP_SINK_COUNT and DP_DEVICE_SERVICE_IRQ_VECTOR, > respectively. IIRC there was an oversight in the earlier spec revisions that showed bit 7 as reserved

Re: [Intel-gfx] [PATCH 2/2] drm/mst: use DP_GET_SINK_COUNT() for sink count in ESI

On Tue, Jan 04, 2022 at 08:48:57PM +0200, Jani Nikula wrote: > Take bit 7 into account when reading sink count from > DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Intel-gfx] [PATCH 3/4] drm/i915/vga: switch to use VGA definitions from video/vga.h

On Mon, Jan 10, 2022 at 11:57:39AM +0200, Jani Nikula wrote: > The video/vga.h has macros for the VGA registers. Switch to use them. > > Suggested-by: Matt Roper > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vga.c | 9 + > 1 file changed, 5 insertions(+), 4 del

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Drop unused register definitions

On Mon, Jan 10, 2022 at 12:55:36PM +0200, Jani Nikula wrote: On Fri, 07 Jan 2022, Lucas De Marchi wrote: On Fri, Jan 07, 2022 at 12:46:48PM +0200, Jani Nikula wrote: I still tell people to 1) split out register definitions to separate patches, and 2) add macros for the entire feature and full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2)

== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2) URL : https://patchwork.freedesktop.org/series/98137/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11059_full -> Patchwork_21948_full ==

Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU

On Fri, Jan 07, 2022 at 08:57:32PM -0600, Bjorn Helgaas wrote: > On Fri, Jan 07, 2022 at 01:05:16PM -0800, Lucas De Marchi wrote: > > early_pci_scan_bus() does a depth-first traversal, possibly calling > > the quirk functions for each device based on vendor, device and class > > from early_qrk tabl

Re: [Intel-gfx] [PATCH v3 2/3] x86/quirks: Improve line wrap on quirk conditions

On Fri, Jan 07, 2022 at 01:05:15PM -0800, Lucas De Marchi wrote: > Remove extra parenthesis and wrap lines so it's easier to read what are > the conditions being checked. The call to the hook also had an extra > indentation: remove here to conform to coding style. > > Signed-off-by: Lucas De March

[Intel-gfx] [PATCH v7 0/6] drm/i915: Asynchronous vma unbinding

This patch series introduces infrastructure for asynchronous vma unbinding. The single enabled use-case is initially at buffer object migration where we otherwise sync when unbinding vmas before migration. This in theory allows us to pipeline any number of migrations, but in practice the number i

[Intel-gfx] [PATCH v7 1/6] drm/i915: Initial introduction of vma resources

Introduce vma resources, sort of similar to TTM resources, needed for asynchronous bind management. Initially we will use them to hold completion of unbinding when we capture data from a vma, but they will be used extensively in upcoming patches for asynchronous vma unbinding. v6: - Some document

[Intel-gfx] [PATCH v7 2/6] drm/i915: Use the vma resource as argument for gtt binding / unbinding

When introducing asynchronous unbinding, the vma itself may no longer be alive when the actual binding or unbinding takes place. Update the gtt i915_vma_ops accordingly to take a struct i915_vma_resource instead of a struct i915_vma for the bind_vma() and unbind_vma() ops. Similarly change the ins

[Intel-gfx] [PATCH v7 3/6] drm/i915: Don't pin the object pages during pending vma binds

A pin-count is already held by vma->pages so taking an additional pin during async binds is not necessary. When we introduce async unbinding we have other means of keeping the object pages alive. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/i915_vma.c | 5

[Intel-gfx] [PATCH v7 4/6] drm/i915: Use vma resources for async unbinding

Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences should be coalesced with the migration blit fence to a

[Intel-gfx] [PATCH v7 5/6] drm/i915: Asynchronous migration selftest

Add a selftest to exercise asynchronous migration and -unbining. Extend the gem_migrate selftest to perform the migrations while depending on a spinner and a bound vma set up on the migrated buffer object. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i9

[Intel-gfx] [PATCH v7 6/6] drm/i915: Use struct vma_resource instead of struct vma_snapshot

There is always a struct vma_resource guaranteed to be alive when we access a corresponding struct vma_snapshot. So ditch the latter and instead of allocating vma_snapshots, reference the already existning vma_resource. This requires a couple of extra members in struct vma_resource but that's a s

Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU

On Mon, Jan 10, 2022 at 12:11:36PM -0500, Rodrigo Vivi wrote: > On Fri, Jan 07, 2022 at 08:57:32PM -0600, Bjorn Helgaas wrote: > > On Fri, Jan 07, 2022 at 01:05:16PM -0800, Lucas De Marchi wrote: > > > early_pci_scan_bus() does a depth-first traversal, possibly calling > > > the quirk functions for

Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU

On Mon, Jan 10, 2022 at 11:32:11AM -0600, Bjorn Helgaas wrote: > On Mon, Jan 10, 2022 at 12:11:36PM -0500, Rodrigo Vivi wrote: > > On Fri, Jan 07, 2022 at 08:57:32PM -0600, Bjorn Helgaas wrote: > > > On Fri, Jan 07, 2022 at 01:05:16PM -0800, Lucas De Marchi wrote: > > > > early_pci_scan_bus() does

  1   2   >