Re: [Intel-gfx] [PATCH 2/2] drm/mst: use DP_GET_SINK_COUNT() for sink count in ESI

[Ville Syrjälä]

On Tue, Jan 04, 2022 at 08:48:57PM +0200, Jani Nikula wrote:
> Take bit 7 into account when reading sink count from
> DP_DEVICE_SERVICE_IRQ_VECTOR_ESI0.
> 
> Signed-off-by: Jani Nikula <jani.nik...@intel.com>
> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c 
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index f3d79eda94bb..ab4372e9fe43 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4196,7 +4196,7 @@ int drm_dp_mst_hpd_irq(struct drm_dp_mst_topology_mgr 
> *mgr, u8 *esi, bool *handl
>       int ret = 0;
>       int sc;
>       *handled = false;
> -     sc = esi[0] & 0x3f;
> +     sc = DP_GET_SINK_COUNT(esi[0]);

I wouldn't mind a s/sc/sink_count/ as well.

Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com>

>  
>       if (sc != mgr->sink_count) {
>               mgr->sink_count = sc;
> -- 
> 2.30.2

-- 
Ville Syrjälä
Intel