[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove short term pins from execbuf by requiring lock to unbind.

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. URL : https://patchwork.freedesktop.org/series/98137/ State : warning == Summary == $ dim checkpatch origin/drm-tip bc08f58eeb3f drm/i915: Remove unused bits of i915_vma/active api 91bcecf2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove short term pins from execbuf by requiring lock to unbind.

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. URL : https://patchwork.freedesktop.org/series/98137/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked se

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Remove short term pins from execbuf by requiring lock to unbind.

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. URL : https://patchwork.freedesktop.org/series/98137/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/i915_gem_evict.c:110: warning: Functi

Re: [Intel-gfx] [PATCH v4 1/2] i915/gvt: Introduce the mmio_info_table.c to support VFIO new mdev API

2021-12-17 Thread Wang, Zhi A
On 11/30/2021 6:46 PM, Christoph Hellwig wrote: > I still think this goes into the wrong direction. > > Something closer to your first version that also saves away the > gvt->mmio.mmio_attribute flags in the core i915 module, and which > splits the MMIO table into one that contains just the offset,

[Intel-gfx] ✗ Fi.CI.BUILD: failure for DG2 accelerated migration/clearing support (rev3)

2021-12-17 Thread Patchwork
== Series Details == Series: DG2 accelerated migration/clearing support (rev3) URL : https://patchwork.freedesktop.org/series/97544/ State : failure == Summary == Applying: drm/i915/gtt: allow overriding the pt alignment Applying: drm/i915/gtt: add xehpsdv_ppgtt_insert_entry Applying: drm/i915

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove short term pins from execbuf by requiring lock to unbind.

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. URL : https://patchwork.freedesktop.org/series/98137/ State : success == Summary == CI Bug Log - changes from CI_DRM_11009 -> Patchwork_21861 ===

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check for wedged before doing stuff

2021-12-17 Thread Tvrtko Ursulin
On 16/12/2021 20:30, John Harrison wrote: On 12/16/2021 00:47, Tvrtko Ursulin wrote: On 15/12/2021 22:45, john.c.harri...@intel.com wrote: From: John Harrison A fault injection probe test hit a BUG_ON in a GuC error path. It showed that the GuC code could potentially attempt to do many thin

[Intel-gfx] [PATCH v2 0/7] drm/i915: Asynchronous vma unbinding

2021-12-17 Thread Thomas Hellström
This patch series introduces infrastructure for asynchronous vma unbinding. The single enabled use-case is initially at buffer object migration where we otherwise sync when unbinding vmas before migration. This in theory allows us to pipeline any number of migrations, but in practice the number is

[Intel-gfx] [PATCH v2 1/7] drm/i915: Avoid using the i915_fence_array when collecting dependencies

2021-12-17 Thread Thomas Hellström
Since the gt migration code was using only a single fence for dependencies, these were collected in a dma_fence_array. However, it turns out that it's illegal to use some dma_fences in a dma_fence_array, in particular other dma_fence_arrays and dma_fence_chains, and this causes trouble for us movin

[Intel-gfx] [PATCH v2 2/7] drm/i915: Break out the i915_deps utility

2021-12-17 Thread Thomas Hellström
Since it's starting to be used outside the i915 TTM move code, move it to a separate set of files. v2: - Update the documentation. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 176 + drivers/

[Intel-gfx] [PATCH v2 5/7] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2021-12-17 Thread Thomas Hellström
When introducing asynchronous unbinding, the vma itself may no longer be alive when the actual binding or unbinding takes place. Update the gtt i915_vma_ops accordingly to take a struct i915_vma_resource instead of a struct i915_vma for the bind_vma() and unbind_vma() ops. Similarly change the ins

[Intel-gfx] [PATCH v2 3/7] drm/i915: Require the vm mutex for i915_vma_bind()

2021-12-17 Thread Thomas Hellström
Protect updates of struct i915_vma flags and async binding / unbinding with the vm::mutex. This means that i915_vma_bind() needs to assert vm::mutex held. In order to make that possible drop the caching of kmap_atomic() maps around i915_vma_bind(). An alternative would be to use kmap_local() but s

[Intel-gfx] [PATCH v2 4/7] drm/i915: Initial introduction of vma resources

2021-12-17 Thread Thomas Hellström
Introduce vma resources, sort of similar to TTM resources, needed for asynchronous bind management. Initially we will use them to hold completion of unbinding when we capture data from a vma, but they will be used extensively in upcoming patches for asynchronous vma unbinding. Signed-off-by: Thom

[Intel-gfx] [PATCH v2 6/7] drm/i915: Use vma resources for async unbinding

2021-12-17 Thread Thomas Hellström
Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences should be coalesced with the migration blit fence to a

[Intel-gfx] [PATCH v2 7/7] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2021-12-17 Thread Thomas Hellström
There is always a struct vma_resource guaranteed to be alive when we access a corresponding struct vma_snapshot. So ditch the latter and instead of allocating vma_snapshots, reference the already existning vma_resource. This requires a couple of extra members in struct vma_resource but that's a s

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: Request RP0 before loading firmware (rev3)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915/guc: Request RP0 before loading firmware (rev3) URL : https://patchwork.freedesktop.org/series/97682/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm()

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm() URL : https://patchwork.freedesktop.org/series/98154/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11009 -> Patchwork_21863

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Enabling WD Transcoder

2021-12-17 Thread Jani Nikula
On Fri, 17 Dec 2021, "Kandpal, Suraj" wrote: > From: suraj kandpal > > Adding support for writeback transcoder to start capturing frames using > interrupt mechanism I stopped reviewing this after a while, because there's just way too much unrelated noise in the patch to even be able to focus on

Re: [Intel-gfx] [PATCH 1/4] drm: add writeback pointers to drm_connector

2021-12-17 Thread Jani Nikula
On Fri, 17 Dec 2021, "Kandpal, Suraj" wrote: > From: suraj kandpal > > Adding drm_writeback_connector to drm_connector so that > writeback_connector can be fetched from drm_connector This needs some explaining, since drm_connector_to_writeback() does exactly that. > Adding drm_connector and drm

[Intel-gfx] [PATCH v3] drm/i915/dsi: let HW maintain the HS-TRAIL timing

2021-12-17 Thread William Tseng
This change is to avoid over-specification of the TEOT timing parameter, which is derived from software in current design. Supposed that THS-TRAIL and THS-EXIT have the minimum values, i.e., 60 and 100 in ns. If SW is overriding the HW default, the TEOT value becomes 150 ns, approximately calculat

Re: [Intel-gfx] [PATCH 2/4] drm/komeda: change driver to use drm_writeback_connector.base pointer

2021-12-17 Thread Jani Nikula
On Fri, 17 Dec 2021, "Kandpal, Suraj" wrote: > From: suraj kandpal > > Changing driver to use drm_writeback_connector.base pointer Every commit should build and work on its own, so this makes me believe the previous patch breaks the build. Also, why? You see that (in our clunky object hierarch

[Intel-gfx] ✗ Fi.CI.BUILD: failure for More preparation for multi gt patches (rev2)

2021-12-17 Thread Patchwork
== Series Details == Series: More preparation for multi gt patches (rev2) URL : https://patchwork.freedesktop.org/series/98032/ State : failure == Summary == Applying: drm/i915: Store backpointer to GT in uncore Applying: drm/i915: Introduce to_gt() helper Applying: drm/i915/display: Use to_gt

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Define WD trancoder for i915

2021-12-17 Thread Jani Nikula
On Fri, 17 Dec 2021, "Kandpal, Suraj" wrote: > From: suraj kandpal > > Adding WD Types, WD transcoder to enum list and WD Transcoder offsets This should be part of the patch that uses them. BR, Jani. > > Signed-off-by: suraj kandpal > --- > drivers/gpu/drm/i915/display/intel_display.h

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Request RP0 before loading firmware (rev3)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915/guc: Request RP0 before loading firmware (rev3) URL : https://patchwork.freedesktop.org/series/97682/ State : success == Summary == CI Bug Log - changes from CI_DRM_11009 -> Patchwork_21864 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm()

2021-12-17 Thread Jani Nikula
On Thu, 16 Dec 2021, Harish Chegondi wrote: > Check return pointer from intel_crtc_for_plane() before dereferencing > it, as it can be NULL. If you're doing this to satisfy some static analyzer, in these cases the code would read *much* better if you added the NULL check inside intel_crtc_active(

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: remove circ_buf.h includes

2021-12-17 Thread Jani Nikula
On Thu, 16 Dec 2021, Patchwork wrote: > == Series Details == > > Series: drm/i915: remove circ_buf.h includes > URL : https://patchwork.freedesktop.org/series/98130/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > 24a5cb6b532c drm/i915: remove circ_buf.h includes > -:44

Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform

2021-12-17 Thread Srivatsa, Anusha
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Thursday, December 16, 2021 5:28 PM > To: Surendrakumar Upadhyay, TejaskumarX > ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform > > On Fri, 10 Dec

Re: [Intel-gfx] [PATCH v3 04/17] drm/i915: Take object lock in i915_ggtt_pin if ww is not set

2021-12-17 Thread Matthew Auld
On Thu, 16 Dec 2021 at 14:28, Maarten Lankhorst wrote: > > i915_vma_wait_for_bind needs the vma lock held, fix the caller. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH v3 05/17] drm/i915: Force ww lock for i915_gem_object_ggtt_pin_ww, v2.

2021-12-17 Thread Matthew Auld
On Thu, 16 Dec 2021 at 14:28, Maarten Lankhorst wrote: > > We will need the lock to unbind the vma, and wait for bind to complete. > Remove the special casing for the !ww path, and force ww locking for all. > > Changes since v1: > - Pass err to for_i915_gem_ww handling for -EDEADLK handling. > > S

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove short term pins from execbuf by requiring lock to unbind.

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. URL : https://patchwork.freedesktop.org/series/98137/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11009_full -> Patchwork_21861_full =

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dmc: Eliminate remnant GEN references

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Eliminate remnant GEN references URL : https://patchwork.freedesktop.org/series/98166/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11009 -> Patchwork_21866 Summary --- **F

Re: [Intel-gfx] [PATCH 4/7] drm/i915/guc: Don't hog IRQs when destroying contexts

2021-12-17 Thread Tvrtko Ursulin
On 14/12/2021 17:04, Matthew Brost wrote: From: John Harrison While attempting to debug a CT deadlock issue in various CI failures (most easily reproduced with gem_ctx_create/basic-files), I was seeing CPU deadlock errors being reported. This were because the context destroy loop was blocking w

Re: [Intel-gfx] [PATCH 4/7] drm/i915/guc: Don't hog IRQs when destroying contexts

2021-12-17 Thread Tvrtko Ursulin
On 17/12/2021 11:06, Tvrtko Ursulin wrote: On 14/12/2021 17:04, Matthew Brost wrote: From: John Harrison While attempting to debug a CT deadlock issue in various CI failures (most easily reproduced with gem_ctx_create/basic-files), I was seeing CPU deadlock errors being reported. This were b

Re: [Intel-gfx] [PATCH v3 07/17] drm/i915: Ensure i915_vma tests do not get -ENOSPC with the locking changes.

2021-12-17 Thread Matthew Auld
On Thu, 16 Dec 2021 at 14:28, Maarten Lankhorst wrote: > > Now that we require locking to evict, multiple vmas from the same object > might not be evicted. This is expected and required, because execbuf will > move to short-term pinning by using the lock only. This will cause these > tests to fail

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Request RP0 before loading firmware (rev3)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915/guc: Request RP0 before loading firmware (rev3) URL : https://patchwork.freedesktop.org/series/97682/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11009_full -> Patchwork_21864_full Su

Re: [Intel-gfx] [PATCH v3 08/17] drm/i915: Call i915_gem_evict_vm in vm_fault_gtt to prevent new ENOSPC errors

2021-12-17 Thread Matthew Auld
On Thu, 16 Dec 2021 at 14:28, Maarten Lankhorst wrote: > > Now that we cannot unbind kill the currently locked object directly "unbind kill" > because we're removing short term pinning, we may have to unbind the > object from gtt manually, using a i915_gem_evict_vm() call. > > Signed-off-by: Maa

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915: Use vma resources for async unbinding

2021-12-17 Thread kernel test robot
6-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unb

Re: [Intel-gfx] [PATCH] drm/i915/guc: Log engine resets

2021-12-17 Thread Tvrtko Ursulin
On 14/12/2021 15:07, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Log engine resets done by the GuC firmware in the similar way it is done by the execlists backend. This way we have notion of where the hangs are before the GuC gains support for proper error capture. Ping - any interest to lo

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Adding writeback support for i915

2021-12-17 Thread Patchwork
== Series Details == Series: Adding writeback support for i915 URL : https://patchwork.freedesktop.org/series/98168/ State : failure == Summary == Applying: drm: add writeback pointers to drm_connector Using index info to reconstruct a base tree... M include/drm/drm_connector.h Falling b

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Asynchronous vma unbinding (rev2)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev2) URL : https://patchwork.freedesktop.org/series/98055/ State : warning == Summary == $ dim checkpatch origin/drm-tip 04617ab4c517 drm/i915: Avoid using the i915_fence_array when collecting dependencies c9d9298d1a0b drm/i9

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Asynchronous vma unbinding (rev2)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev2) URL : https://patchwork.freedesktop.org/series/98055/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: Asynchronous vma unbinding (rev2)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev2) URL : https://patchwork.freedesktop.org/series/98055/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h CC [M] drivers/gpu/dr

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Asynchronous vma unbinding (rev2)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev2) URL : https://patchwork.freedesktop.org/series/98055/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11012 -> Patchwork_21868 Summary --- **FAIL

Re: [Intel-gfx] [PATCH v3 09/17] drm/i915: Trylock the object when shrinking

2021-12-17 Thread Matthew Auld
On Thu, 16 Dec 2021 at 14:28, Maarten Lankhorst wrote: > > We're working on requiring the obj->resv lock during unbind, fix > the shrinker to take the objectl ock. lock > > Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH v3 11/17] drm/i915: Add ww ctx to i915_gem_object_trylock

2021-12-17 Thread Matthew Auld
On Thu, 16 Dec 2021 at 14:28, Maarten Lankhorst wrote: > > This is required for i915_gem_evict_vm, to be able to evict the entire VM, > including objects that are already locked to the current ww ctx. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH v3 12/17] drm/i915: Add locking to i915_gem_evict_vm()

2021-12-17 Thread Matthew Auld
On Thu, 16 Dec 2021 at 14:28, Maarten Lankhorst wrote: > > i915_gem_evict_vm will need to be able to evict objects that are > locked by the current ctx. By testing if the current context already > locked the object, we can do this correctly. This allows us to > evict the entire vm even if we alrea

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: let HW maintain the HS-TRAIL timing (rev3)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915/dsi: let HW maintain the HS-TRAIL timing (rev3) URL : https://patchwork.freedesktop.org/series/96750/ State : success == Summary == CI Bug Log - changes from CI_DRM_11012 -> Patchwork_21869 Summary

Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform

2021-12-17 Thread Jani Nikula
On Fri, 10 Dec 2021, Tejas Upadhyay wrote: > Adding PCI device ids and enabling ADL-N platform. > ADL-N from i915 point of view is subplatform of ADL-P. > > BSpec: 68397 > > Changes since V2: > - Added version log history > Changes since V1: > - replace IS_ALDERLAKE_N with IS_ADLP_N -

Re: [Intel-gfx] [PATCH v3 13/17] drm/i915: Add object locking to i915_gem_evict_for_node and i915_gem_evict_something

2021-12-17 Thread Matthew Auld
On Thu, 16 Dec 2021 at 14:28, Maarten Lankhorst wrote: > > Because we will start to require the obj->resv lock for unbinding, > ensure these shrinker functions also take the lock. > > This requires some function signature changes, to ensure that the > ww context is passed around, but is mostly str

[Intel-gfx] [PATCH v3 0/7] drm/i915: Asynchronous vma unbinding

2021-12-17 Thread Thomas Hellström
This patch series introduces infrastructure for asynchronous vma unbinding. The single enabled use-case is initially at buffer object migration where we otherwise sync when unbinding vmas before migration. This in theory allows us to pipeline any number of migrations, but in practice the number is

[Intel-gfx] [PATCH v3 1/7] drm/i915: Avoid using the i915_fence_array when collecting dependencies

2021-12-17 Thread Thomas Hellström
Since the gt migration code was using only a single fence for dependencies, these were collected in a dma_fence_array. However, it turns out that it's illegal to use some dma_fences in a dma_fence_array, in particular other dma_fence_arrays and dma_fence_chains, and this causes trouble for us movin

[Intel-gfx] [PATCH v3 2/7] drm/i915: Break out the i915_deps utility

2021-12-17 Thread Thomas Hellström
Since it's starting to be used outside the i915 TTM move code, move it to a separate set of files. v2: - Update the documentation. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 176 + drivers/

[Intel-gfx] [PATCH v3 3/7] drm/i915: Require the vm mutex for i915_vma_bind()

2021-12-17 Thread Thomas Hellström
Protect updates of struct i915_vma flags and async binding / unbinding with the vm::mutex. This means that i915_vma_bind() needs to assert vm::mutex held. In order to make that possible drop the caching of kmap_atomic() maps around i915_vma_bind(). An alternative would be to use kmap_local() but s

[Intel-gfx] [PATCH v3 4/7] drm/i915: Initial introduction of vma resources

2021-12-17 Thread Thomas Hellström
Introduce vma resources, sort of similar to TTM resources, needed for asynchronous bind management. Initially we will use them to hold completion of unbinding when we capture data from a vma, but they will be used extensively in upcoming patches for asynchronous vma unbinding. Signed-off-by: Thom

[Intel-gfx] [PATCH v3 7/7] drm/i915: Use struct vma_resource instead of struct vma_snapshot

2021-12-17 Thread Thomas Hellström
There is always a struct vma_resource guaranteed to be alive when we access a corresponding struct vma_snapshot. So ditch the latter and instead of allocating vma_snapshots, reference the already existning vma_resource. This requires a couple of extra members in struct vma_resource but that's a s

[Intel-gfx] [PATCH v3 5/7] drm/i915: Use the vma resource as argument for gtt binding / unbinding

2021-12-17 Thread Thomas Hellström
When introducing asynchronous unbinding, the vma itself may no longer be alive when the actual binding or unbinding takes place. Update the gtt i915_vma_ops accordingly to take a struct i915_vma_resource instead of a struct i915_vma for the bind_vma() and unbind_vma() ops. Similarly change the ins

[Intel-gfx] [PATCH v3 6/7] drm/i915: Use vma resources for async unbinding

2021-12-17 Thread Thomas Hellström
Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences should be coalesced with the migration blit fence to a

Re: [Intel-gfx] [PATCH v3 13/17] drm/i915: Add object locking to i915_gem_evict_for_node and i915_gem_evict_something

2021-12-17 Thread Maarten Lankhorst
On 17-12-2021 14:55, Matthew Auld wrote: > On Thu, 16 Dec 2021 at 14:28, Maarten Lankhorst > wrote: >> Because we will start to require the obj->resv lock for unbinding, >> ensure these shrinker functions also take the lock. >> >> This requires some function signature changes, to ensure that the >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsi: let HW maintain the HS-TRAIL timing (rev3)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915/dsi: let HW maintain the HS-TRAIL timing (rev3) URL : https://patchwork.freedesktop.org/series/96750/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11012_full -> Patchwork_21869_full Su

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Asynchronous vma unbinding (rev3)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev3) URL : https://patchwork.freedesktop.org/series/98055/ State : warning == Summary == $ dim checkpatch origin/drm-tip af22ef498eaa drm/i915: Avoid using the i915_fence_array when collecting dependencies 664fd217a101 drm/i9

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Asynchronous vma unbinding (rev3)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev3) URL : https://patchwork.freedesktop.org/series/98055/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v3 03/17] drm/i915: Remove pages_mutex and intel_gtt->vma_ops.set/clear_pages members, v3.

2021-12-17 Thread Matthew Auld
On Thu, 16 Dec 2021 at 14:28, Maarten Lankhorst wrote: > > Big delta, but boils down to moving set_pages to i915_vma.c, and removing > the special handling, all callers use the defaults anyway. We only remap > in ggtt, so default case will fall through. > > Because we still don't require locking i

Re: [Intel-gfx] [PATCH v3 08/17] drm/i915: Call i915_gem_evict_vm in vm_fault_gtt to prevent new ENOSPC errors

2021-12-17 Thread Maarten Lankhorst
On 17-12-2021 12:58, Matthew Auld wrote: > On Thu, 16 Dec 2021 at 14:28, Maarten Lankhorst > wrote: >> Now that we cannot unbind kill the currently locked object directly > "unbind kill" > >> because we're removing short term pinning, we may have to unbind the >> object from gtt manually, using a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Asynchronous vma unbinding (rev3)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev3) URL : https://patchwork.freedesktop.org/series/98055/ State : success == Summary == CI Bug Log - changes from CI_DRM_11012 -> Patchwork_21870 Summary --- **SUCC

[Intel-gfx] [PATCH 1/6] drm/i915/bios: Introduce has_ddi_port_info()

2021-12-17 Thread Ville Syrjala
From: Ville Syrjälä Pull the "do we want to use i915->vbt.ports[]?" check into a central place. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c

[Intel-gfx] [PATCH 0/6] drm/i915: Extend parse_ddi_port() to all g4x+ platforms

2021-12-17 Thread Ville Syrjala
From: Ville Syrjälä Quick attempt at unifying the VBT DDI parsing to all g4x+ platforms. Note that we'll still use the hardware straps as the primary source of port presence information on old platforms since the device type bits in VBT tend to be often a bit wrong (for DP++ ports at least). Ho

[Intel-gfx] [PATCH 2/6] drm/i915/bios: Use i915->vbt.ports[] on CHV

2021-12-17 Thread Ville Syrjala
From: Ville Syrjälä CHV is currently straddling the divide by using parse_ddi_ports() stuff for aux_ch/ddc_pin but going through all old codepaths for the rest (intel_bios_is_port_present(), intel_bios_is_port_edp(), intel_bios_is_port_dp_dual_mode()). Let's switch over full and use i915->vbt.por

[Intel-gfx] [PATCH 3/6] drm/i915/bios: Use i915->vbt.ports[] for all g4x+

2021-12-17 Thread Ville Syrjala
From: Ville Syrjälä Extend the vbt.ports[] stuff for all g4x+ platforms. We do need to drop the version check as some elk/ctg machines may have VBTs older than that. The oldest I know is an elk with version 142. But the child device stuff has had the correct size since at least version 125 (obser

[Intel-gfx] [PATCH 5/6] drm/i915/bios: Nuke DEVICE_TYPE_DP_DUAL_MODE_BITS

2021-12-17 Thread Ville Syrjala
From: Ville Syrjälä Replace the DEVICE_TYPE_DP_DUAL_MODE_BITS stuff with just a DP+HDMI check. The rest of the bits shouldn't really matter anyway. The slight change in behaviour here is that now we do look at the DEVICE_TYPE_NOT_HDMI_OUTPUT bit (via intel_bios_encoder_supports_hdmi()) when we p

[Intel-gfx] [PATCH 4/6] drm/i915/bios: Throw out the !has_ddi_port_info() codepaths

2021-12-17 Thread Ville Syrjala
From: Ville Syrjälä Now that we parse the DDI port info from the VBT on all g4x+ platforms we can throw out all the old codepaths in intel_bios_is_port_present(), intel_bios_is_port_edp() and intel_bios_is_port_dp_dual_mode(). None of these should be called on pre-g4x platforms. For good measure

[Intel-gfx] [PATCH 6/6] drm/i915/hdmi: Ignore DP++ TMDS clock limit for native HDMI ports

2021-12-17 Thread Ville Syrjala
From: Ville Syrjälä Lots of machines these days seem to have a crappy type1 DP dual mode adaptor chip slapped onto the motherboard. Based on the DP dual mode spec we currently limit those to 165MHz max TMDS clock. Windows OTOH ignores DP dual mode adaptors when the VBT indicates that the port is

[Intel-gfx] [PATCH v2] drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm()

2021-12-17 Thread Harish Chegondi
Check return pointer from intel_crtc_for_plane() before dereferencing it, as it can be NULL. v2: Moved the NULL check into intel_crtc_active(). Cc: Jani Nikula Cc: Caz Yokoyama Cc: Radhakrishna Sripada Signed-off-by: Harish Chegondi --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed,

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm()

2021-12-17 Thread Ville Syrjälä
On Fri, Dec 17, 2021 at 08:02:55AM -0800, Harish Chegondi wrote: > Check return pointer from intel_crtc_for_plane() before dereferencing > it, as it can be NULL. Can't actually bu NULL. But I guess no real harm in having the check if it shuts up some static analysis thing. > > v2: Moved the NULL

[Intel-gfx] How to fix screen resolution detection?

2021-12-17 Thread Alan Stern
The screen resolution on my laptop is not reported accurately. Here's an extract from the output of xdpyinfo: screen #0: dimensions:3200x1800 pixels (847x476 millimeters) resolution:96x96 dots per inch The number of pixels is correct, but the size and resolution values smack of a b

Re: [Intel-gfx] [PATCH] drm/i915/guc: Log engine resets

2021-12-17 Thread Matthew Brost
On Fri, Dec 17, 2021 at 12:15:53PM +, Tvrtko Ursulin wrote: > > On 14/12/2021 15:07, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Log engine resets done by the GuC firmware in the similar way it is done > > by the execlists backend. > > > > This way we have notion of where the han

Re: [Intel-gfx] [PATCH] drm/i915/mst: update slot information for 128b/132b

2021-12-17 Thread Ville Syrjälä
On Thu, Dec 16, 2021 at 04:05:48PM +0200, Jani Nikula wrote: > 128b/132b supports using 64 slots starting from 0, while 8b/10b reserves > slot 0 for metadata. > > Commit d6c6a76f80a1 ("drm: Update MST First Link Slot Information Based > on Encoding Format") added support for updating the topology

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Extend parse_ddi_port() to all g4x+ platforms

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Extend parse_ddi_port() to all g4x+ platforms URL : https://patchwork.freedesktop.org/series/98183/ State : success == Summary == CI Bug Log - changes from CI_DRM_11013 -> Patchwork_21871 Summary -

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm() (rev2)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Fix possible NULL pointer dereferences in i9xx_update_wm() (rev2) URL : https://patchwork.freedesktop.org/series/98154/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11013 -> Patchwork_21872 ==

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Asynchronous vma unbinding (rev3)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Asynchronous vma unbinding (rev3) URL : https://patchwork.freedesktop.org/series/98055/ State : success == Summary == CI Bug Log - changes from CI_DRM_11012_full -> Patchwork_21870_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Extend parse_ddi_port() to all g4x+ platforms

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915: Extend parse_ddi_port() to all g4x+ platforms URL : https://patchwork.freedesktop.org/series/98183/ State : success == Summary == CI Bug Log - changes from CI_DRM_11013_full -> Patchwork_21871_full Sum

[Intel-gfx] [PATCH] drm/i915/display: Move cdclk checks to atomic check

2021-12-17 Thread Anusha Srivatsa
Checking cdclk conditions during atomic check and preparing for commit phase so we can have atomic commit as simple as possible. Add the specific steps to be taken during cdclk changes, prepare for squashing, crawling and modeset scenarios. Rename functions intel_cdclk_can_squash() and intel_cdclk_

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Move cdclk checks to atomic check (rev2)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Move cdclk checks to atomic check (rev2) URL : https://patchwork.freedesktop.org/series/97850/ State : warning == Summary == $ dim checkpatch origin/drm-tip a83c610f1486 drm/i915/display: Move cdclk checks to atomic check -:120: CHECK:PARENTHESIS_

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Move cdclk checks to atomic check (rev2)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Move cdclk checks to atomic check (rev2) URL : https://patchwork.freedesktop.org/series/97850/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: Move cdclk checks to atomic check (rev2)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Move cdclk checks to atomic check (rev2) URL : https://patchwork.freedesktop.org/series/97850/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_cdclk.c:2025: warning: Function paramete

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Move cdclk checks to atomic check (rev2)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Move cdclk checks to atomic check (rev2) URL : https://patchwork.freedesktop.org/series/97850/ State : success == Summary == CI Bug Log - changes from CI_DRM_11013 -> Patchwork_21873 Summary --

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Eliminate remnant GEN references

2021-12-17 Thread Yokoyama, Caz
On Thu, 2021-12-16 at 19:41 -0800, Madhumitha Tolakanahalli Pradeep wrote: > Replace GEN with DISPLAY_VER, in line with the naming > convention > followed in the i915 driver code. > > Signed-off-by: Madhumitha Tolakanahalli Pradeep < > madhumitha.tolakanahalli.prad...@intel.com> > --- > drivers/g

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Move cdclk checks to atomic check (rev2)

2021-12-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Move cdclk checks to atomic check (rev2) URL : https://patchwork.freedesktop.org/series/97850/ State : success == Summary == CI Bug Log - changes from CI_DRM_11013_full -> Patchwork_21873_full

Re: [Intel-gfx] [PATCH v8 11/16] drm/i915/gem: Use to_gt() helper for GGTT accesses

2021-12-17 Thread Matt Roper
On Tue, Dec 14, 2021 at 09:33:41PM +0200, Andi Shyti wrote: > From: Michał Winiarski > > GGTT is currently available both through i915->ggtt and gt->ggtt, and we > eventually want to get rid of the i915->ggtt one. > Use to_gt() for all i915->ggtt accesses to help with the future > refactoring. >

Re: [Intel-gfx] [PATCH v8 12/16] drm/i915/display: Use to_gt() helper for GGTT accesses

2021-12-17 Thread Matt Roper
On Tue, Dec 14, 2021 at 09:33:42PM +0200, Andi Shyti wrote: > From: Michał Winiarski > > GGTT is currently available both through i915->ggtt and gt->ggtt, and we > eventually want to get rid of the i915->ggtt one. > Use to_gt() for all i915->ggtt accesses to help with the future > refactoring. >

Re: [Intel-gfx] [PATCH v8 13/16] drm/i915/gt: Use to_gt() helper for GGTT accesses

2021-12-17 Thread Matt Roper
On Tue, Dec 14, 2021 at 09:33:43PM +0200, Andi Shyti wrote: > From: Michał Winiarski > > GGTT is currently available both through i915->ggtt and gt->ggtt, and we > eventually want to get rid of the i915->ggtt one. > Use to_gt() for all i915->ggtt accesses to help with the future > refactoring. >

Re: [Intel-gfx] [PATCH v8 14/16] drm/i915/selftests: Use to_gt() helper for GGTT accesses

2021-12-17 Thread Matt Roper
On Tue, Dec 14, 2021 at 09:33:44PM +0200, Andi Shyti wrote: > From: Michał Winiarski > > GGTT is currently available both through i915->ggtt and gt->ggtt, and we > eventually want to get rid of the i915->ggtt one. > Use to_gt() for all i915->ggtt accesses to help with the future > refactoring. >

Re: [Intel-gfx] [PATCH v8 15/16] drm/i915: Use to_gt() helper for GGTT accesses

2021-12-17 Thread Matt Roper
On Tue, Dec 14, 2021 at 09:33:45PM +0200, Andi Shyti wrote: > From: Michał Winiarski > > GGTT is currently available both through i915->ggtt and gt->ggtt, and we > eventually want to get rid of the i915->ggtt one. > Use to_gt() for all i915->ggtt accesses to help with the future > refactoring. >

Re: [Intel-gfx] [PATCH v8 16/16] drm/i915: Remove unused i915->ggtt

2021-12-17 Thread Matt Roper
On Tue, Dec 14, 2021 at 09:33:46PM +0200, Andi Shyti wrote: > The reference to the GGTT from the private date is not used > anymore. Remove it. You may want to also mention here that tile0's ggtt will now be dynamically allocated (and auto-deallocated on driver unload by the drmm_* infrastructure)

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for More preparation for multi gt patches

2021-12-17 Thread Matt Roper
On Wed, Dec 15, 2021 at 07:25:17AM +, Patchwork wrote: > == Series Details == > > Series: More preparation for multi gt patches > URL : https://patchwork.freedesktop.org/series/98032/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11002_full -> Patchwork_21849_ful

[Intel-gfx] [PATCH] x86/quirks: Fix logic to apply quirk once

2021-12-17 Thread Lucas De Marchi
When using QFLAG_APPLY_ONCE we make sure the quirk is applied only once. This is useful when it's enough one device to trigger a certain condition or when the resource in each that applies is global to the system rather than local to the device. However we call the quirk handler based on vendor, c

[Intel-gfx] ✓ Fi.CI.BAT: success for x86/quirks: Fix logic to apply quirk once

2021-12-17 Thread Patchwork
== Series Details == Series: x86/quirks: Fix logic to apply quirk once URL : https://patchwork.freedesktop.org/series/98200/ State : success == Summary == CI Bug Log - changes from CI_DRM_11014 -> Patchwork_21874 Summary --- **SUCCES