Re: [Intel-gfx] missing signoff on drm-intel-gt-next pull

2021-08-11 Thread Jani Nikula
On Wed, 11 Aug 2021, Joonas Lahtinen wrote: > Quoting Dave Airlie (2021-08-11 06:48:39) >> dim: db47fe727e1f ("drm/i915/step: >> s/_revid_tbl/_revids"): committer Signed-off-by >> missing. >> >> I'm not sure how much pain it is to fix that up, but >> commit db47fe727e1fc516cf60fc9ab8299605ef3c2d5

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree

2021-08-11 Thread Jani Nikula
On Tue, 10 Aug 2021, Daniel Vetter wrote: > On Mon, Aug 09, 2021 at 09:19:39AM -0700, Matt Roper wrote: >> On Mon, Aug 09, 2021 at 04:05:59PM +0200, Daniel Vetter wrote: >> > On Fri, Aug 06, 2021 at 09:36:56AM +0300, Joonas Lahtinen wrote: >> > > Hi Matt, >> > > >> > > Always use the dim tooling

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix the 12 BPC bits for PIPE_MISC reg (rev2)

2021-08-11 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix the 12 BPC bits for PIPE_MISC reg (rev2) URL : https://patchwork.freedesktop.org/series/93306/ State : success == Summary == CI Bug Log - changes from CI_DRM_10465_full -> Patchwork_20797_full ==

Re: [Intel-gfx] missing signoff on drm-intel-gt-next pull

2021-08-11 Thread Dave Airlie
On Wed, 11 Aug 2021 at 17:11, Jani Nikula wrote: > > On Wed, 11 Aug 2021, Joonas Lahtinen wrote: > > Quoting Dave Airlie (2021-08-11 06:48:39) > >> dim: db47fe727e1f ("drm/i915/step: > >> s/_revid_tbl/_revids"): committer Signed-off-by > >> missing. > >> > >> I'm not sure how much pain it is to f

Re: [Intel-gfx] missing signoff on drm-intel-gt-next pull

2021-08-11 Thread Jani Nikula
On Wed, 11 Aug 2021, Dave Airlie wrote: > On Wed, 11 Aug 2021 at 17:11, Jani Nikula wrote: >> >> On Wed, 11 Aug 2021, Joonas Lahtinen wrote: >> > Quoting Dave Airlie (2021-08-11 06:48:39) >> >> dim: db47fe727e1f ("drm/i915/step: >> >> s/_revid_tbl/_revids"): committer Signed-off-by >> >> missing

Re: [Intel-gfx] [PATCH v4 02/14] vfio/mbochs: Fix missing error unwind of mbochs_used_mbytes

2021-08-11 Thread Cornelia Huck
On Thu, Aug 05 2021, Jason Gunthorpe wrote: > Convert mbochs to use an atomic scheme for this like mtty was changed > into. The atomic fixes various race conditions with probing. Add the > missing error unwind. Also add the missing kfree of mdev_state->pages. > > Fixes: 681c1615f891 ("vfio/mbochs

Re: [Intel-gfx] [PATCH v4 08/14] vfio/pci: Move to the device set infrastructure

2021-08-11 Thread Cornelia Huck
On Thu, Aug 05 2021, Jason Gunthorpe wrote: > From: Yishai Hadas > > PCI wants to have the usual open/close_device() logic with the slight > twist that the open/close_device() must be done under a singelton lock > shared by all of the vfio_devices that are in the PCI "reset group". > > The reset

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree

2021-08-11 Thread Daniel Vetter
On Wed, Aug 11, 2021 at 10:16:41AM +0300, Jani Nikula wrote: > On Tue, 10 Aug 2021, Daniel Vetter wrote: > > On Mon, Aug 09, 2021 at 09:19:39AM -0700, Matt Roper wrote: > >> On Mon, Aug 09, 2021 at 04:05:59PM +0200, Daniel Vetter wrote: > >> > On Fri, Aug 06, 2021 at 09:36:56AM +0300, Joonas Lahti

Re: [Intel-gfx] [PATCH 46/46] drm/i915/guc: Add delay before disabling scheduling on contexts

2021-08-11 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 07:32:26PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 07:17:27PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:43PM -0700, Matthew Brost wrote: > > > Some workloads use lots of contexts that continually pin / unpin > > > contexts. With GuC submissi

Re: [Intel-gfx] [PATCH 25/46] drm/i915/guc: Update debugfs for GuC multi-lrc

2021-08-11 Thread Daniel Vetter
On Tue, Aug 10, 2021 at 05:29:46PM +, Matthew Brost wrote: > On Tue, Aug 10, 2021 at 11:27:31AM +0200, Daniel Vetter wrote: > > On Tue, Aug 10, 2021 at 11:23:39AM +0200, Daniel Vetter wrote: > > > On Mon, Aug 09, 2021 at 07:13:11PM +, Matthew Brost wrote: > > > > On Mon, Aug 09, 2021 at 06:

Re: [Intel-gfx] [PATCH v4 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set

2021-08-11 Thread Cornelia Huck
On Thu, Aug 05 2021, Jason Gunthorpe wrote: > vfio_pci_try_bus_reset() is triggering a reset of the entire_dev set if > any device within it has accumulated a needs_reset. This reset can only be > done once all of the drivers operating the PCI devices to be reset are in > a known safe state. > >

Re: [Intel-gfx] [PATCH v4 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set

2021-08-11 Thread Cornelia Huck
On Thu, Aug 05 2021, Jason Gunthorpe wrote: > Like vfio_pci_dev_set_try_reset() this code wants to reset all of the > devices in the "reset group" which is the same membership as the device > set. > > Instead of trying to reconstruct the device set from the PCI list go > directly from the device

Re: [Intel-gfx] [PATCH v4 14/14] vfio: Remove struct vfio_device_ops open/release

2021-08-11 Thread Cornelia Huck
On Thu, Aug 05 2021, Jason Gunthorpe wrote: > Nothing uses this anymore, delete it. > > Signed-off-by: Yishai Hadas > Reviewed-by: Christoph Hellwig > Signed-off-by: Jason Gunthorpe > --- > drivers/vfio/mdev/vfio_mdev.c | 22 -- > drivers/vfio/vfio.c | 14 +--

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree

2021-08-11 Thread Jani Nikula
On Wed, 11 Aug 2021, Daniel Vetter wrote: > On Wed, Aug 11, 2021 at 10:16:41AM +0300, Jani Nikula wrote: >> On Tue, 10 Aug 2021, Daniel Vetter wrote: >> > On Mon, Aug 09, 2021 at 09:19:39AM -0700, Matt Roper wrote: >> >> On Mon, Aug 09, 2021 at 04:05:59PM +0200, Daniel Vetter wrote: >> >> > On Fr

Re: [Intel-gfx] [PATCH v3] drm/i915/display: Fix the 12 BPC bits for PIPE_MISC reg

2021-08-11 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of > Shankar, > Uma > Sent: Wednesday, August 11, 2021 11:39 AM > To: Nautiyal, Ankit K ; > intel-gfx@lists.freedesktop.org > Cc: Zanoni, Paulo R ; ville.syrj...@linux.intel.com; > daniel.vet...@ffwll.ch; jani.nik...@linux.intel.com; > j

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree

2021-08-11 Thread Rodrigo Vivi
On Wed, Aug 11, 2021 at 10:16:41AM +0300, Jani Nikula wrote: > On Tue, 10 Aug 2021, Daniel Vetter wrote: > > On Mon, Aug 09, 2021 at 09:19:39AM -0700, Matt Roper wrote: > >> On Mon, Aug 09, 2021 at 04:05:59PM +0200, Daniel Vetter wrote: > >> > On Fri, Aug 06, 2021 at 09:36:56AM +0300, Joonas Lahti

Re: [Intel-gfx] [V3 2/7] drm/i915/jsl: program DSI panel GPIOs

2021-08-11 Thread Lee, Shawn C
On Tue, 11 Aug 2021, "Lee, Shawn C" wrote: >On Tue, 10 Aug 2021, Jani Nikula wrote: >>On Tue, 10 Aug 2021, "Lee, Shawn C" wrote: >>> On Tue, 10 Aug 2021, Jani Nikula wrote: On Fri, 23 Jul 2021, Lee Shawn C wrote: > DSI driver should have its own implementation to toggle gpio pins

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/hdcp: HDCP2.2 MST dock fixes (rev4)

2021-08-11 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: HDCP2.2 MST dock fixes (rev4) URL : https://patchwork.freedesktop.org/series/93570/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./drivers/gpu/drm/am

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree

2021-08-11 Thread Matt Roper
On Wed, Aug 11, 2021 at 11:48:00AM +0200, Daniel Vetter wrote: > On Wed, Aug 11, 2021 at 10:16:41AM +0300, Jani Nikula wrote: > > On Tue, 10 Aug 2021, Daniel Vetter wrote: > > > On Mon, Aug 09, 2021 at 09:19:39AM -0700, Matt Roper wrote: > > >> On Mon, Aug 09, 2021 at 04:05:59PM +0200, Daniel Vett

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: HDCP2.2 MST dock fixes (rev4)

2021-08-11 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: HDCP2.2 MST dock fixes (rev4) URL : https://patchwork.freedesktop.org/series/93570/ State : success == Summary == CI Bug Log - changes from CI_DRM_10467 -> Patchwork_20798 Summary --- **SUC

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: HDCP2.2 MST dock fixes (rev4)

2021-08-11 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: HDCP2.2 MST dock fixes (rev4) URL : https://patchwork.freedesktop.org/series/93570/ State : success == Summary == CI Bug Log - changes from CI_DRM_10467_full -> Patchwork_20798_full Summary --

Re: [Intel-gfx] [PATCH 25/46] drm/i915/guc: Update debugfs for GuC multi-lrc

2021-08-11 Thread Matthew Brost
On Wed, Aug 11, 2021 at 12:04:04PM +0200, Daniel Vetter wrote: > On Tue, Aug 10, 2021 at 05:29:46PM +, Matthew Brost wrote: > > On Tue, Aug 10, 2021 at 11:27:31AM +0200, Daniel Vetter wrote: > > > On Tue, Aug 10, 2021 at 11:23:39AM +0200, Daniel Vetter wrote: > > > > On Mon, Aug 09, 2021 at 07:

Re: [Intel-gfx] [PATCH 46/46] drm/i915/guc: Add delay before disabling scheduling on contexts

2021-08-11 Thread Matthew Brost
On Wed, Aug 11, 2021 at 11:55:48AM +0200, Daniel Vetter wrote: > On Mon, Aug 09, 2021 at 07:32:26PM +, Matthew Brost wrote: > > On Mon, Aug 09, 2021 at 07:17:27PM +0200, Daniel Vetter wrote: > > > On Tue, Aug 03, 2021 at 03:29:43PM -0700, Matthew Brost wrote: > > > > Some workloads use lots of

Re: [Intel-gfx] [PATCH 11/46] drm/i915/guc: Don't call switch_to_kernel_context with GuC submission

2021-08-11 Thread Matthew Brost
On Tue, Aug 10, 2021 at 08:47:10AM +0200, Daniel Vetter wrote: > On Mon, Aug 09, 2021 at 06:20:51PM +, Matthew Brost wrote: > > On Mon, Aug 09, 2021 at 04:27:01PM +0200, Daniel Vetter wrote: > > > On Tue, Aug 03, 2021 at 03:29:08PM -0700, Matthew Brost wrote: > > > > Calling switch_to_kernel_co

Re: [Intel-gfx] [PATCH 14/46] drm/i915: Expose logical engine instance to user

2021-08-11 Thread Matthew Brost
On Tue, Aug 10, 2021 at 08:53:16AM +0200, Daniel Vetter wrote: > On Mon, Aug 09, 2021 at 06:37:01PM +, Matthew Brost wrote: > > On Mon, Aug 09, 2021 at 04:30:06PM +0200, Daniel Vetter wrote: > > > On Tue, Aug 03, 2021 at 03:29:11PM -0700, Matthew Brost wrote: > > > > Expose logical engine insta

Re: [Intel-gfx] [PATCH 16/46] drm/i915/guc: Implement GuC parent-child context pin / unpin functions

2021-08-11 Thread Matthew Brost
On Tue, Aug 10, 2021 at 11:07:55AM +0200, Daniel Vetter wrote: > On Tue, Aug 10, 2021 at 10:53:37AM +0200, Daniel Vetter wrote: > > On Mon, Aug 09, 2021 at 06:58:23PM +, Matthew Brost wrote: > > > On Mon, Aug 09, 2021 at 05:17:34PM +0200, Daniel Vetter wrote: > > > > On Tue, Aug 03, 2021 at 03:

Re: [Intel-gfx] [PATCH 16/46] drm/i915/guc: Implement GuC parent-child context pin / unpin functions

2021-08-11 Thread Matthew Brost
On Tue, Aug 10, 2021 at 10:53:37AM +0200, Daniel Vetter wrote: > On Mon, Aug 09, 2021 at 06:58:23PM +, Matthew Brost wrote: > > On Mon, Aug 09, 2021 at 05:17:34PM +0200, Daniel Vetter wrote: > > > On Tue, Aug 03, 2021 at 03:29:13PM -0700, Matthew Brost wrote: > > > > Implement GuC parent-child

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_List

2021-08-11 Thread Rodrigo Vivi
On Tue, Aug 10, 2021 at 04:52:11PM -0700, Juston Li wrote: > When reading RepeaterAuth_Send_ReceiverID_List, RxInfo is read by itself > once to retrieve the DEVICE_COUNT to calculate the size of the > ReceiverID list then read a second time as a part of reading ReceiverID > list. > > On some MST d

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_List

2021-08-11 Thread Li, Juston
On Wed, 2021-08-11 at 15:34 -0400, Rodrigo Vivi wrote: > On Tue, Aug 10, 2021 at 04:52:11PM -0700, Juston Li wrote: > > When reading RepeaterAuth_Send_ReceiverID_List, RxInfo is read by > > itself > > once to retrieve the DEVICE_COUNT to calculate the size of the > > ReceiverID list then read a sec

Re: [Intel-gfx] [PATCH] drm/i915: Only access SFC_DONE when media domain is not fused off

2021-08-11 Thread Souza, Jose
On Fri, 2021-08-06 at 10:41 -0700, Matt Roper wrote: > The SFC_DONE register lives within the corresponding VD0/VD2/VD4/VD6 > forcewake domain and is not accessible if the vdbox in that domain is > fused off and the forcewake is not initialized. > > This mistake went unnoticed because until recent

Re: [Intel-gfx] [PATCH] drm/i915: Only access SFC_DONE when media domain is not fused off

2021-08-11 Thread Matt Roper
On Wed, Aug 11, 2021 at 01:55:48PM -0700, Souza, Jose wrote: > On Fri, 2021-08-06 at 10:41 -0700, Matt Roper wrote: > > The SFC_DONE register lives within the corresponding VD0/VD2/VD4/VD6 > > forcewake domain and is not accessible if the vdbox in that domain is > > fused off and the forcewake is n

[Intel-gfx] [PATCH v4 1/3] drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg()

2021-08-11 Thread Juston Li
Update cp_irq_count_cached when reading messages rather than when writing a message to make sure the value is up to date and not stale from a previously handled CP_IRQ. AKE flow doesn't always respond to a read with a ACK write msg. E.g. AKE_Send_Pairing_Info will "timeout" because we received a

[Intel-gfx] [PATCH v4 0/3] drm/i915/hdcp: HDCP2.2 MST dock fixes

2021-08-11 Thread Juston Li
Fixes to get HDCP2.2 over MST working on MST docking stations with certain behaviors that cause the current flow to fail. Tested with Dell WD-19 and Lenovo ThinkPad USB Type-C Dock Gen 2. These fixes should make the flow more robust to handle behaviors that as far as I can tell are unclear in the

[Intel-gfx] [PATCH v4 2/3] drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_List

2021-08-11 Thread Juston Li
When reading RepeaterAuth_Send_ReceiverID_List, RxInfo is read by itself once to retrieve the DEVICE_COUNT to calculate the size of the ReceiverID list then read a second time as a part of reading ReceiverID list. On some MST docking stations, RxInfo can only be read after the RxStatus READY bit i

[Intel-gfx] [PATCH v4 3/3] drm/i915/hdcp: reuse rx_info for mst stream type1 capability check

2021-08-11 Thread Juston Li
On some MST docking stations, rx_info can only be read after RepeaterAuth_Send_ReceiverID_List and the RxStatus READY bit is set otherwise the read will return -EIO. This behavior causes the mst stream type1 capability test to fail to read rx_info and determine if the topology supports type1 and f

Re: [Intel-gfx] [PATCH v4 00/14] Provide core infrastructure for managing open/release

2021-08-11 Thread Alex Williamson
On Thu, 5 Aug 2021 22:18:56 -0300 Jason Gunthorpe wrote: > This is in support of Max's series to split vfio-pci. For that to work the > reflck concept embedded in vfio-pci needs to be sharable across all of the > new VFIO PCI drivers which motivated re-examining how this is > implemented. > > A

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: HDCP2.2 MST dock fixes (rev5)

2021-08-11 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: HDCP2.2 MST dock fixes (rev5) URL : https://patchwork.freedesktop.org/series/93570/ State : success == Summary == CI Bug Log - changes from CI_DRM_10470 -> Patchwork_20799 Summary --- **SUC

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: HDCP2.2 MST dock fixes (rev5)

2021-08-11 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: HDCP2.2 MST dock fixes (rev5) URL : https://patchwork.freedesktop.org/series/93570/ State : success == Summary == CI Bug Log - changes from CI_DRM_10470_full -> Patchwork_20799_full Summary --

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm tree

2021-08-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/intel_device_info.h between commit: 3ffe82d701a4 ("drm/i915/xehp: handle new steering options") from the drm tree and commit: 22e26af76903 ("drm/i915: Fork DG1 interrupt handler") from the dr

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Implement Wa_1508744258

2021-08-11 Thread Timo Aaltonen
On 9.7.2021 0.18, José Roberto de Souza wrote: Same bit was required for Wa_14012131227 in DG1 now it is also required as Wa_1508744258 to TGL, RKL, DG1, ADL-S and ADL-P. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 +++ 1

Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print

2021-08-11 Thread Nautiyal, Ankit K
Patch looks good to me. I think we must add fixes tag with the below commit: https://cgit.freedesktop.org/drm-tip/commit/?id=9488a030ac91447ea186ca3b7ec5c72ff03bc202 Reviewed-by: Ankit Nautiyal On 7/27/2021 12:21 AM, Swati Sharma wrote: drm_dp_dpcd_read/write already has debug error message.

[Intel-gfx] [PATCH 1/5] drm/i915/dp: Fix eDP max rate for display 11+

2021-08-11 Thread Animesh Manna
From: Matt Atwood intel_dp_set_source_rates() calls intel_dp_is_edp(), which is unsafe to use before intel_encoder->type is set. This causes incorrect max source rate to be used for display 11+. On EHL and JSL, HBR3 is used instead of HBR2, and on the other affected platforms, HBR2 is used instea

[Intel-gfx] [PATCH 0/5] Fix in max source calculation for dp/edp

2021-08-11 Thread Animesh Manna
HBR3 support for display gen11+ platform is depends upon some conditions which are mentioned below. ICL: - eDP (only on DDI-A): Up to HBR3 for higher Vccio. - DP: - (DDI-B, combo phy): upto HBR2. - (DDI-C to DDI-F): upto HBR3   RKLC: - eDP/DP: Up to HBR3? Vccio dependent? (missing

[Intel-gfx] [PATCH 2/5] drm/i915/dp: fix TGL and ICL max source rates

2021-08-11 Thread Animesh Manna
From: Jani Nikula Combo phy is limited to 5.4 GHz on low-voltage SKUs. Combo phy DP is limited to 5.4 GHz, while combo phy eDP can do 8.1 GHz. Bspec: 20584, 20598, 49180, 49201 Cc: Imre Deak Signed-off-by: Jani Nikula Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_dp.c

[Intel-gfx] [PATCH 3/5] drm/i915/dp: fix EHL/JSL max source rates calculation

2021-08-11 Thread Animesh Manna
Only higher voltage sku can support HBR3 so a condition check added in max source rate calculation for ehl/jsl. Bspec: 32247, 20598 Cc: Jani Nikula Cc: Imre Deak Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_dp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[Intel-gfx] [PATCH 5/5] drm/i915/dp: fix for ADL_P/S and DG2 dp/edp max source rates

2021-08-11 Thread Animesh Manna
Added support for platforms having DISPLAY13 like DG2, ADL_P and ADL_S. Bspec: 53597, 53720, 53657, 54034, 49185, 55409 Cc: Jani Nikula Cc: Imre Deak Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_dp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/

[Intel-gfx] [PATCH 4/5] drm/i915/dp: fix DG1 and RKL max source rates

2021-08-11 Thread Animesh Manna
From: Jani Nikula Combo phy is limited to 5.4 GHz on low-voltage SKUs, but both eDP and DP can do 8.1 GHz on combo phy. Bspec: 49182, 49205, 49202 Cc: Imre Deak Signed-off-by: Jani Nikula Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_dp.c | 16 +++- 1 file

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Implement Wa_1508744258

2021-08-11 Thread Timo Aaltonen
On 12.8.2021 6.27, Timo Aaltonen wrote: On 9.7.2021 0.18, José Roberto de Souza wrote: Same bit was required for Wa_14012131227 in DG1 now it is also required as Wa_1508744258 to TGL, RKL, DG1, ADL-S and ADL-P. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza ---   drivers/gpu/drm/i91

[Intel-gfx] [PATCH 0/5] drm/i915/gt: Initialize unused MOCS entries to L3_WB

2021-08-11 Thread Ayaz A Siddiqui
Gen >= 12 onwards MOCS table doesn't have a setting for PTE so I915_MOCS_PTE is not a valid index and it will have different MOCS values based on the platform. To detect these kinds of misprogramming, all the unspecified and reserved MOCS indexes are set to WB_L3. This series also contains patche

[Intel-gfx] [PATCH 4/5] drm/i915/gt: Initialize unused MOCS entries with device specific values

2021-08-11 Thread Ayaz A Siddiqui
During to creation mocs table,used field of drm_i915_mocs_entry is being checked, if used field is 0, then it will check values of index 1. All the unspecified indexes of xxx_mocs_table[] will contain control value and l3cc value of index I915_MOCS_PTE if its initialized. This patch is intended to

[Intel-gfx] [PATCH 1/5] drm/i915/gt: Add support of mocs propagation

2021-08-11 Thread Ayaz A Siddiqui
Now there are lots of Command and registers that require mocs index programming. So propagating mocs_index from mocs to gt so that it can be used directly without having platform-specific checks. Signed-off-by: Ayaz A Siddiqui Cc: CQ Tang --- drivers/gpu/drm/i915/gt/intel_gt_types.h | 4 d

[Intel-gfx] [PATCH 3/5] drm/i915/gt: Set BLIT_CCTL reg to un-cached

2021-08-11 Thread Ayaz A Siddiqui
From: Apoorva Singh Blitter commands which does not have MOCS fields rely on cacheability of BlitterCacheControlRegister which was mapped to index 0 by default.Once we changed the MOCS value of index 0 to L3 WB, tests like gem_linear_blits started failing due to change in cacheability from UC to

[Intel-gfx] [PATCH 2/5] drm/i915/gt: Use cmd_cctl override for platforms >= gen12

2021-08-11 Thread Ayaz A Siddiqui
From: Srinivasan Shanmugam Program CMD_CCTL to use a mocs entry for uncached access. This controls memory accesses by CS as it reads instructions from the ring and batch buffers. Signed-off-by: Srinivasan Shanmugam Signed-off-by: Ayaz A Siddiqui Cc: Chris Wilson Cc: Matt Roper --- drivers/g

[Intel-gfx] [PATCH 5/5] drm/i95/adl: Define MOCS table for Alderlake

2021-08-11 Thread Ayaz A Siddiqui
In order to program unused and reserved mocs entries to L3_WB, we need to create a separate mocs table for alderlake. This patch will also covers wa_1608975824. Cc: Lucas De Marchi Signed-off-by: Ayaz A Siddiqui --- drivers/gpu/drm/i915/gt/intel_mocs.c | 40 +++- 1 file