Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg

2021-03-25 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal On 3/24/2021 5:00 PM, Anshuman Gupta wrote: As documented in HDCP 2.2 DP Errata spec transmitter should abort the authentication protocol in case transmitter has not received the entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg within {110,7,

[Intel-gfx] [PATCH] drivers: gpu: drm: Remove repeated declaration

2021-03-25 Thread Wan Jiabing
struct drm_i915_private, struct intel_crtc_state and struct intel_crtc have been declared before. Remove the duplicate. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/i915/display/intel_crt.h | 1 - drivers/gpu/drm/i915/display/intel_display.h | 1 - drivers/gpu/drm/i915/display/intel_vrr.h

Re: [Intel-gfx] [PATCH 03/11] security: commoncap: fix -Wstringop-overread warning

2021-03-25 Thread James Morris
On Mon, 22 Mar 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 introdces a harmless warning for cap_inode_getsecurity: > > security/commoncap.c: In function ‘cap_inode_getsecurity’: > security/commoncap.c:440:33: error: ‘memcpy’ reading 16 bytes from a region > of size 0 [-Werror=s

Re: [Intel-gfx] [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-25 Thread Jani Nikula
On Mon, 22 Mar 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns that intel_dp_check_mst_status() has a local array of > fourteen bytes and passes the last four bytes into a function that > expects a six-byte array: > > drivers/gpu/drm/i915/display/intel_dp.c: In function > ‘inte

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()

2021-03-25 Thread Lisovskiy, Stanislav
On Thu, Mar 25, 2021 at 02:44:14AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Accidentally transposed the arguments to skl_plane_wm_level() > which is causing us to mistakenly think that the plane watermarks > have/have not changed when the opposite may be true. Swap the > arguments so

[Intel-gfx] linux-next: please do not base your tree on v5.12-rc1-dontuse

2021-03-25 Thread Stephen Rothwell
Hi all, The latest version of the drm-misc tree consists of just 2 commits on top of Linus' v5.12-rc1-dontuse tag. -- Cheers, Stephen Rothwell pgp3hJ0faDbsT.pgp Description: OpenPGP digital signature ___ Intel-gfx mailing list Intel-gfx@lists.freedes

Re: [Intel-gfx] [PATCH v4] vfio/pci: Add support for opregion v2.1+

2021-03-25 Thread Gao, Fred
Thank you for offering your valuable advice. Will send the updated version soon. > -Original Message- > From: Alex Williamson > Sent: Saturday, March 20, 2021 3:27 AM > To: Gao, Fred > Cc: k...@vger.kernel.org; intel-gfx@lists.freedesktop.org; Zhenyu Wang > ; Fonn, Swee Yee > Subject: R

[Intel-gfx] [PATCH v5] vfio/pci: Add support for opregion v2.1+

2021-03-25 Thread Fred Gao
Before opregion version 2.0 VBT data is stored in opregion mailbox #4, but when VBT data exceeds 6KB size and cannot be within mailbox #4 then from opregion v2.0+, Extended VBT region, next to opregion is used to hold the VBT data, so the total size will be opregion size plus extended VBT region si

Re: [Intel-gfx] linux-next: please do not base your tree on v5.12-rc1-dontuse

2021-03-25 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 9:48 AM Stephen Rothwell wrote: > > Hi all, > > The latest version of the drm-misc tree consists of just 2 commits on > top of Linus' v5.12-rc1-dontuse tag. Yeah committer pushed patches to the wrong tree, which meant you get the wrong tree. We'll fix for tomorrow. -Daniel

[Intel-gfx] [PATCH] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v8.

2021-03-25 Thread Maarten Lankhorst
Instead of doing what we do currently, which will never work with PROVE_LOCKING, do the same as AMD does, and something similar to relocation slowpath. When all locks are dropped, we acquire the pages for pinning. When the locks are taken, we transfer those pages in .get_pages() to the bo. As a fin

[Intel-gfx] [PULL] drm-intel-fixes

2021-03-25 Thread Rodrigo Vivi
Hi Dave and Daniel, with GT fence revocation runtime PM logic targeting 4.12+ stable, here goes drm-intel-fixes-2021-03-25-1: - DisplayPort LTTPR fixes around link training and limiting it according to supported spec version. (Imre) - Fix enabled_planes bitmask to really represent only logicall

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly

2021-03-25 Thread Lisovskiy, Stanislav
On Thu, Mar 25, 2021 at 02:44:15AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The dbuf bandwidth calculations don't need the planes to be > added to the state. Each plane's data rate has already been > precalculated and stored in the crtc state, and that with > the dbuf slice usage for

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Add RFC section

2021-03-25 Thread Simon Ser
Acked-by: Simon Ser ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PULL] drm-misc-next

2021-03-25 Thread Maxime Ripard
Hi Dave, Daniel, It's still a fairly quiet week, but here's this week's drm-misc-next PR maxime drm-misc-next-2021-03-25: drm-misc-next for 5.13: UAPI Changes: - New USB connector type Cross-subsystem Changes: Core Changes: - ttm: Introduce a per-device LRU lock, remove swap LRU Driver C

[Intel-gfx] [PATCH] drm/i915: Tweaked Wa_14010685332 for all PCHs

2021-03-25 Thread Anshuman Gupta
dispcnlunit1_cp_xosc_clkreq clock observed to be active on TGL-H platform despite Wa_14010685332 original sequence thus blocks entry to deeper s0ix state. The Tweaked Wa_14010685332 sequence fixes this issue, therefore use tweaked Wa_14010685332 sequence for every PCH since PCH_CNP. Fixes: b89689

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

2021-03-25 Thread Tvrtko Ursulin
On 24/03/2021 17:18, Jason Ekstrand wrote: On Wed, Mar 24, 2021 at 6:36 AM Tvrtko Ursulin wrote: On 24/03/2021 09:52, Daniel Vetter wrote: On Wed, Mar 24, 2021 at 09:28:58AM +, Tvrtko Ursulin wrote: On 23/03/2021 17:51, Jason Ekstrand wrote: This API is entirely unnecessary and I'd

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

2021-03-25 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 10:48 AM Tvrtko Ursulin wrote: > > > On 24/03/2021 17:18, Jason Ekstrand wrote: > > On Wed, Mar 24, 2021 at 6:36 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 24/03/2021 09:52, Daniel Vetter wrote: > >>> On Wed, Mar 24, 2021 at 09:28:58AM +, Tvrtko Ursulin wrote: > >>

Re: [Intel-gfx] [PATCH] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v8.

2021-03-25 Thread Intel
On 3/25/21 10:23 AM, Maarten Lankhorst wrote: Instead of doing what we do currently, which will never work with PROVE_LOCKING, do the same as AMD does, and something similar to relocation slowpath. When all locks are dropped, we acquire the pages for pinning. When the locks are taken, we transf

Re: [Intel-gfx] [PATCH] drm/i915: Tweaked Wa_14010685332 for all PCHs

2021-03-25 Thread Rodrigo Vivi
On Thu, Mar 25, 2021 at 03:02:13PM +0530, Anshuman Gupta wrote: > dispcnlunit1_cp_xosc_clkreq clock observed to be active on TGL-H platform > despite Wa_14010685332 original sequence thus blocks entry to deeper s0ix > state. > > The Tweaked Wa_14010685332 sequence fixes this issue, therefore use

Re: [Intel-gfx] [PATCH] drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v8.

2021-03-25 Thread Daniel Vetter
On Thu, Mar 25, 2021 at 10:55:11AM +0100, Thomas Hellström (Intel) wrote: > > On 3/25/21 10:23 AM, Maarten Lankhorst wrote: > > Instead of doing what we do currently, which will never work with > > PROVE_LOCKING, do the same as AMD does, and something similar to > > relocation slowpath. When all l

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly

2021-03-25 Thread Ville Syrjälä
On Thu, Mar 25, 2021 at 11:35:53AM +0200, Lisovskiy, Stanislav wrote: > On Thu, Mar 25, 2021 at 02:44:15AM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The dbuf bandwidth calculations don't need the planes to be > > added to the state. Each plane's data rate has already been > > pr

[Intel-gfx] [PULL] drm-misc-fixes

2021-03-25 Thread Maarten Lankhorst
drm-misc-fixes-2021-03-25: drm-misc-fixes for v5.12: - Use FOLL_FORCE and FOLL_LONGTERM in etnaviv The following changes since commit 6909115442759efef3d4bc5d9c54d7943f1afc14: drm/omap: dsi: fix unsigned expression compared with zero (2021-03-17 13:59:23 +0200) are available in the Git reposit

[Intel-gfx] [PATCH 1/2] drm/i915/display/vlv_dsi: Do not skip panel_pwr_cycle_delay when disabling the panel

2021-03-25 Thread Hans de Goede
After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down displays gracefully on reboot"), the DSI panel on a Cherry Trail based Predia Basic tablet would no longer properly light up after reboot. I've managed to reproduce this without rebooting by doing: chvt 3; echo 1 > /sys/class/graph

[Intel-gfx] [PATCH 2/2] drm/i915/display/vlv_dsi: Move panel_pwr_cycle_delay to next panel-on

2021-03-25 Thread Hans de Goede
Instead of sleeping panel_pwr_cycle_delay ms when turning the panel off, record the time it is turned off and if necessary wait any (remaining) time when the panel is turned on again. Also sleep the remaining time on shutdown, because on reboot the GOP will immediately turn on the panel again. Cc

[Intel-gfx] [PATCH v2] drm/i915: Tweaked Wa_14010685332 for all PCHs

2021-03-25 Thread Anshuman Gupta
dispcnlunit1_cp_xosc_clkreq clock observed to be active on TGL-H platform despite Wa_14010685332 original sequence, thus blocks entry to deeper s0ix state. The Tweaked Wa_14010685332 sequence fixes this issue, therefore use tweaked Wa_14010685332 sequence for every PCH since PCH_CNP. v2: - remov

Re: [Intel-gfx] [PATCH v2] drm/i915: Tweaked Wa_14010685332 for all PCHs

2021-03-25 Thread Rodrigo Vivi
On Thu, Mar 25, 2021 at 05:39:47PM +0530, Anshuman Gupta wrote: > dispcnlunit1_cp_xosc_clkreq clock observed to be active on TGL-H platform > despite Wa_14010685332 original sequence, thus blocks entry to deeper s0ix > state. > > The Tweaked Wa_14010685332 sequence fixes this issue, therefore use

Re: [Intel-gfx] [PATCH v2 0/2] HDCP 2.2 DP errata

2021-03-25 Thread Jani Nikula
On Wed, 24 Mar 2021, Anshuman Gupta wrote: > HDCP DP 2.2 errata is part of HDCP DP 2.3 specs > as well. > > Anshuman Gupta (2): > drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg > drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16 > > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 45 ++

Re: [Intel-gfx] [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-25 Thread Arnd Bergmann
On Thu, Mar 25, 2021 at 9:05 AM Jani Nikula wrote: > > Clearly something is wrong here, but I can't quite figure out what. > > Changing the array size to 16 bytes avoids the warning, but is > > probably the wrong solution here. > > Ugh. drm_dp_channel_eq_ok() does not actually require more than >

Re: [Intel-gfx] [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-25 Thread Martin Sebor
On 3/25/21 3:53 AM, Arnd Bergmann wrote: On Thu, Mar 25, 2021 at 9:05 AM Jani Nikula wrote: Clearly something is wrong here, but I can't quite figure out what. Changing the array size to 16 bytes avoids the warning, but is probably the wrong solution here. Ugh. drm_dp_channel_eq_ok() does not

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: missing workarounds and refactors

2021-03-25 Thread Patchwork
== Series Details == Series: drm/i915: missing workarounds and refactors URL : https://patchwork.freedesktop.org/series/88408/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member '

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: missing workarounds and refactors

2021-03-25 Thread Patchwork
== Series Details == Series: drm/i915: missing workarounds and refactors URL : https://patchwork.freedesktop.org/series/88408/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9894 -> Patchwork_19849 Summary --- **FAILU

[Intel-gfx] [PATCH v2 03/50] drm/i915/xelpd: Enhanced pipe underrun reporting

2021-03-25 Thread Matt Roper
XE_LPD brings enhanced underrun recovery: the hardware can somewhat mitigate underruns by using an interpolated replacement pixel (soft underrun) or the previous pixel (hard underrun). Furthermore, underruns can now be caused downstream by the port, even if the pipe itself is operating properly.

[Intel-gfx] [PATCH v2 01/50] drm/i915/xelpd: add XE_LPD display characteristics

2021-03-25 Thread Matt Roper
Let's start preparing for upcoming platforms that will use an XE_LPD design. v2: - Use the now-preferred "XE_LPD" term to refer to this design - Utilize DISPLAY_VER() rather than a feature flag - Drop unused mbus_size field (Lucas) Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_pci.

[Intel-gfx] [PATCH v2 00/50] Introduce Alder Lake-P

2021-03-25 Thread Matt Roper
The previous version of this series was here: https://lists.freedesktop.org/archives/intel-gfx/2021-March/262168.html The preparation patches that convert display/ to use DISPLAY_VER() instead of INTEL_GEN() have landed on drm-tip now, so this is mostly just a straightforward rebase of the

[Intel-gfx] [PATCH v2 06/50] drm/i915/xelpd: Handle new location of outputs D and E

2021-03-25 Thread Matt Roper
The DDI naming template for display version 12 went A-C, TC1-TC6. With XE_LPD, that naming scheme for DDI's has now changed to A-E, TC1-TC4. The XE_LPD design keeps the register offsets and bitfields relating to the TC outputs in the same location they were previously. The new "D" and "E" output

[Intel-gfx] [PATCH v2 05/50] drm/i915/xelpd: Support 128k plane stride

2021-03-25 Thread Matt Roper
From: Juha-Pekka Heikkilä XE_LPD supports plane strides up to 128KB. v2: - Drop a duplicated comment - Add missing horizontal pixels for cpp!=8 case (Lucas) - Take into account larger possible offsets for warnings Cc: Vandita Kulkarni Signed-off-by: Juha-Pekka Heikkilä Signed-off-by: Matt

[Intel-gfx] [PATCH v2 09/50] drm/i915/xelpd: Increase maximum watermark lines to 255

2021-03-25 Thread Matt Roper
XE_LPD continues to use the same "skylake-style" watermark programming as other recent platforms. The only change to the watermark calculations compared to Display12 is that XE_LPD now allows a maximum of 255 lines vs the old limit of 31. Due to the larger possible lines value, the corresponding

[Intel-gfx] [PATCH v2 07/50] drm/i915/xelpd: Add XE_LPD power wells

2021-03-25 Thread Matt Roper
Aside from the hardware-managed PG0, XE_LPD has power wells 1-2 and A-D. These power wells should be enabled/disabled according to the following dependency tree (enable top to bottom, disable bottom to top): PG0 | --PG1-- / \

[Intel-gfx] [PATCH v2 04/50] drm/i915/xelpd: Define plane capabilities

2021-03-25 Thread Matt Roper
XE_LPD's plane support is identical to RKL and ADL-S --- 5 universal + 1 cursor with NV12 UV support on planes 1-3 and NV12 Y support on planes 4-5. v2: - Drop the extra 90/270 rotation check in skl_plane_check_fb(); the DRM property code will already prevent userspace from passing us values

[Intel-gfx] [PATCH v2 15/50] drm/i915/xelpd: Calculate VDSC RC parameters

2021-03-25 Thread Matt Roper
From: Vandita Kulkarni Add methods to calculate rc parameters for all bpps, against the fixed arrays that we already have for 8,10,12 valid o/p bpps, to cover RGB 444 formats. Our hw doesn't support YUV compression yet. The calculations used here are from VESA C model for DSC 1.1 v2: - Checkp

[Intel-gfx] [PATCH v2 02/50] drm/i915/xelpd: Handle proper AUX interrupt bits

2021-03-25 Thread Matt Roper
XE_LPD has new AUX interrupt bits for DDI-D and DDI-E that take the spots that were used by TC5/TC6 on Display12 platforms. While we're at it, let's convert the bit definitions for all TGL+ aux bits over to the modern REG_BIT() notation. v2: - Maintain bit order rather than logical order. (Luca

[Intel-gfx] [PATCH v2 14/50] drm/i915: Get slice height before computing rc params

2021-03-25 Thread Matt Roper
From: Vandita Kulkarni We need slice height to calculate few RC parameters hence assign slice height first. Cc: Manasi Navare Signed-off-by: Vandita Kulkarni Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_dp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) d

[Intel-gfx] [PATCH v2 19/50] drm/i915/adl_p: ADL_P device info enabling

2021-03-25 Thread Matt Roper
From: Clinton Taylor Add ADL-P to the device_info table and support MACROS. Bspec: 49185, 55372, 55373 Cc: Matt Atwood Cc: Matt Roper Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- arch/x86/kernel/early-quirks.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 1 +

[Intel-gfx] [PATCH v2 10/50] drm/i915/xelpd: Required bandwidth increases when VT-d is active

2021-03-25 Thread Matt Roper
If VT-d is active, the memory bandwidth usage of the display is 5% higher. Take this into account when determining whether we can support a display configuration. Bspec: 64631 Cc: Matt Atwood Signed-off-by: Matt Roper Reviewed-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_bw.c |

[Intel-gfx] [PATCH v2 16/50] drm/i915/xelpd: Add rc_qp_table for rcparams calculation

2021-03-25 Thread Matt Roper
From: Vandita Kulkarni Add the qp table for 444 formats, for 8bpc, 10bpc and 12bpc, as given by the VESA C model for DSC 1.1 v2: - Add include guard to header (Jani) - Move the big tables to a .c file (Chris, Jani, Lucas) Cc: Manasi Navare Signed-off-by: Vandita Kulkarni Signed-off-by: Matt

[Intel-gfx] [PATCH v2 11/50] drm/i915/xelpd: Add Wa_14011503030

2021-03-25 Thread Matt Roper
Cc: Aditya Swarup Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_display_power.c | 4 drivers/gpu/drm/i915/i915_reg.h| 2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/displa

[Intel-gfx] [PATCH v2 18/50] drm/i915/adl_p: Add PCI Devices IDs

2021-03-25 Thread Matt Roper
From: Clinton Taylor Add 18 known PCI device IDs Bspec: 55376 Cc: Caz Yokoyama Cc: Matt Atwood Cc: Matt Roper Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper Reviewed-by: Anusha Srivatsa --- include/drm/i915_pciids.h | 21 + 1 file changed, 21 insertions(+) di

[Intel-gfx] [PATCH v2 20/50] drm/i915/adl_p: Add PCH support

2021-03-25 Thread Matt Roper
From: Clinton Taylor Add ADP-P PCH device ID and assign as ADL PCH if found. Previously we would assign the DDC pin map based on the PCH, but it can also change based on the CPU. From Bspec 20124: "The physical port to pin pair mapping are defined in the Bspec per PCH. Mapping can further change

[Intel-gfx] [PATCH v2 12/50] drm/i915/display/dsc: Refactor intel_dp_dsc_compute_bpp

2021-03-25 Thread Matt Roper
From: Vandita Kulkarni Move the platform specific max bpc calculation into intel_dp_dsc_compute_bpp function Cc: Manasi Navare Signed-off-by: Vandita Kulkarni Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_dp.c | 20 ++-- 1 file changed, 10 insertions(+), 10

[Intel-gfx] [PATCH v2 08/50] drm/i915/xelpd: Handle LPSP for XE_LPD

2021-03-25 Thread Matt Roper
From: Uma Shankar Enable LPSP for XE_LPD and get the proper power well enable check in place. For XE_LPD it is PW2 which need to check for LPSP. v2: - Move the XE_LPD check outside of the switch. (Lucas) Cc: Anshuman Gupta Cc: Animesh Manna Cc: Matt Roper Cc: Lucas De Marchi Suggested-by:

[Intel-gfx] [PATCH v2 17/50] drm/i915/xelpd: Add VRR guardband for VRR CTL

2021-03-25 Thread Matt Roper
From: Manasi Navare On XE_LPD, VRR CTL register adds a new VRR Guardband bitfield replacing the pipeline full and deprecating the pipeline override bit. This patch adds this corresponding bitfield in the register defs, crtc state vrr structure and populates this in vrr compute config and vrr ena

[Intel-gfx] [PATCH v2 21/50] drm/i915/adl_p: Add dedicated SAGV watermarks

2021-03-25 Thread Matt Roper
XE_LPD reduces the number of regular watermark latency levels from 8 to 6 on non-dgfx platforms. However the hardware also adds a special purpose SAGV wateramrk (and an accompanying transition watermark) that will be used by the hardware in place of the level 0 values during SAGV transitions. Bsp

[Intel-gfx] [PATCH v2 22/50] drm/i915/adl_p: Extend PLANE_WM bits for blocks & lines

2021-03-25 Thread Matt Roper
ADL-P further extends the bits in PLANE_WM that represent blocks and lines; we need to extend our masks accordingly. Since these bits are reserved and MBZ on earlier platforms, it's safe to use the larger bitmask on all platforms. Bspec: 50419 Cc: Matt Atwood Signed-off-by: Matt Roper Signed-of

[Intel-gfx] [PATCH v2 23/50] drm/i915/adl_p: Load DMC

2021-03-25 Thread Matt Roper
From: Anusha Srivatsa Load DMC v2.08 on ADLP. The release notes mention that this version enables few power savings features. Cc: Lucas De Marchi Cc: Clint Taylor Signed-off-by: Anusha Srivatsa Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_c

[Intel-gfx] [PATCH v2 13/50] drm/i915/xelpd: Support DP1.4 compression BPPs

2021-03-25 Thread Matt Roper
From: Vandita Kulkarni Support compression BPPs from bpc to uncompressed BPP -1. So far we have 8,10,12 as valid compressed BPPS now the support is extended. Cc: Manasi Navare Signed-off-by: Vandita Kulkarni Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_dp.c | 32 +

[Intel-gfx] [PATCH v2 31/50] drm/i915/adl_p: Add ddb allocation support

2021-03-25 Thread Matt Roper
From: Vandita Kulkarni On adlp the two mbuses have two display pipes and two DBUFS, Pipe A and D on Mbus1 and Pipe B and C on Mbus2. The Mbus can be joined and all the DBUFS can be used on Pipe A or B. Bspec: 49255 Cc: Anusha Srivatsa Signed-off-by: Vandita Kulkarni Signed-off-by: Clinton Tayl

[Intel-gfx] [PATCH v2 36/50] drm/i915/adl_p: Add initial ADL_P Workarounds

2021-03-25 Thread Matt Roper
From: Anusha Srivatsa Most of the context WA are already implemented for previous platforms. Adding adl_p platform tag to reflect so. BSpec: 54369 Cc: Matt Roper Cc: Aditya Swarup Cc: Madhumitha Tolakanahalli Pradeep Cc: Radhakrishna Sripada Cc: José Roberto de Souza Cc: Swathi Dhanavanthr

[Intel-gfx] [PATCH v2 41/50] drm/i915/bigjoiner: Mode validation with uncompressed pipe joiner

2021-03-25 Thread Matt Roper
From: Animesh Manna No need for checking dsc flag for uncompressed pipe joiner mode validation. Cc: Manasi Navare Signed-off-by: Animesh Manna Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_dp.c | 7 +-- 1 file changed, 5 insertions(+), 2

[Intel-gfx] [PATCH v2 30/50] drm/i915/adl_p: Don't config MBUS and DBUF during display initialization

2021-03-25 Thread Matt Roper
From: José Roberto de Souza Alderlake-P don't have programing sequences for MBUS or DBUF during display initializaiton, instead it requires programing to those registers during modeset because it to depend on the pipes left enabled. Bspec: 49213 Cc: Matt Roper Signed-off-by: José Roberto de Sou

[Intel-gfx] [PATCH v2 37/50] drm/i915/adlp: Define GuC/HuC for Alderlake_P

2021-03-25 Thread Matt Roper
From: Clint Taylor Initial GuC/HuC definitions for ADL_P Cc: Anusha Srivatsa Cc: Matt Roper Signed-off-by: Clint Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/driv

[Intel-gfx] [PATCH v2 47/50] drm/i915/display/adl_p: Implement Wa_22011320316

2021-03-25 Thread Matt Roper
From: José Roberto de Souza Implementation details are in the HSD 22011320316, requiring CD clock to be at least 307MHz to make DC states to work. Cc: Matt Roper Cc: Anusha Srivatsa Signed-off-by: José Roberto de Souza Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- drivers/gpu

[Intel-gfx] [PATCH v2 25/50] drm/i915/adl_p: Add cdclk support for ADL-P

2021-03-25 Thread Matt Roper
From: Anusha Srivatsa ADL-P has 3 possible refclk frequencies: 19.2MHz, 24MHz and 38.4MHz BSpec: 55409, 49208 Cc: Matt Roper Cc: Clinton Taylor Cc: José Roberto de Souza Signed-off-by: Anusha Srivatsa Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v2 24/50] drm/i915/adl_p: Setup ports/phys

2021-03-25 Thread Matt Roper
From: Anusha Srivatsa The SoC has 6 DDI ports(DDI A,DDI B and DDI TC1-4. The first two are connected to combo phys while the rest are connected to TC phys. Cc: Matt Roper Cc: Clinton Taylor Cc: Lucas De Marchi Cc: Swathi Dhanavanthri Signed-off-by: Anusha Srivatsa Signed-off-by: Clinton Tay

[Intel-gfx] [PATCH v2 34/50] drm/i915/adl_p: MBUS programming

2021-03-25 Thread Matt Roper
From: Vandita Kulkarni Update MBUS_CTL register if the 2 mbus can be joined as per the current DDB allocation and active pipes, also update hashing mode and pipe select bits as per the sequence mentioned in the bspec. Cc: Stanislav Lisovskiy Cc: José Roberto de Souza Signed-off-by: Vandita Ku

[Intel-gfx] [PATCH v2 43/50] drm/i915/bigjoiner: atomic commit changes for uncompressed joiner

2021-03-25 Thread Matt Roper
From: Animesh Manna Respective bit for master or slave to be set for uncompressed bigjoiner in dss_ctl1 register. Cc: Manasi Navare Signed-off-by: Animesh Manna Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_display.c | 6 +++ drivers/gpu/drm

[Intel-gfx] [PATCH v2 26/50] drm/i915/display/tc: Rename safe_mode functions ownership

2021-03-25 Thread Matt Roper
From: José Roberto de Souza When DP_PHY_MODE_STATUS_NOT_SAFE is set, it means that display has the control over the TC phy. The "not safe" naming is confusing using ownership make it easier to read also future platforms will have a new register that does the same job as DP_PHY_MODE_STATUS_NOT_SAF

[Intel-gfx] [PATCH v2 27/50] drm/i915/adl_p: Handle TC cold

2021-03-25 Thread Matt Roper
From: José Roberto de Souza On ADL-P TC cold is exited and blocked when legacy aux is powered, that is exacly the same of what ICL need for static TC ports. TODO: When a TBT hub or monitor is connected it will cause TBT and legacy aux to be powered at the same time, hopefully this will not cause

[Intel-gfx] [PATCH v2 45/50] drm/i915/adl_p: Update memory bandwidth parameters

2021-03-25 Thread Matt Roper
From: Anusha Srivatsa ADL_P has same memory characteristics as ADL_S platform. Bspec: 64631 Cc: José Roberto de Souza Cc: Clint Taylor Signed-off-by: Anusha Srivatsa Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_bw.c | 2 +- 1 file changed,

[Intel-gfx] [PATCH v2 48/50] drm/i915/display/adl_p: Remove CCS support

2021-03-25 Thread Matt Roper
From: José Roberto de Souza Buffer compression is not usable in A stepping. Cc: Matt Roper Cc: Anusha Srivatsa Cc: Clinton A Taylor Cc: Juha-Pekka Heikkilä Signed-off-by: José Roberto de Souza Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper Reviewed-by: Anusha Srivatsa --- .../d

[Intel-gfx] [PATCH v2 38/50] drm/i915/adl_p: Define and use ADL-P specific DP translation tables

2021-03-25 Thread Matt Roper
From: Mika Kahola Define and use DP voltage swing and pre-emphasis translation tables for ADL-P. BSpec: 54956 Cc: Imre Deak Signed-off-by: Mika Kahola Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_ddi.c | 7 +++- .../drm/i915/display/i

[Intel-gfx] [PATCH v2 32/50] drm/i915: Introduce MBUS relative dbuf offsets

2021-03-25 Thread Matt Roper
From: Ville Syrjälä The dbuf slices are going to be split across several MBUS units. The actual dbuf programming will use offsets relative to the MBUS unit. To accomodate that we shall store the MBUS relative offsets into the dbuf_state->ddb[] and crtc_state->plane_ddb*[]. For crtc_state->wm.skl

[Intel-gfx] [PATCH v2 39/50] drm/i915/adl_p: Enable/disable loadgen sharing

2021-03-25 Thread Matt Roper
From: Mika Kahola Disable loadgen sharing for DP link rate 1.62 GHz and HDMI 5.94 GHz. For all other modes, we can enable loadgen sharing feature. BSpec: 55359 Cc: Imre Deak Signed-off-by: Mika Kahola Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/

[Intel-gfx] [PATCH v2 50/50] drm/i915/display/adl_p: Implement PSR changes

2021-03-25 Thread Matt Roper
From: José Roberto de Souza Implements changes around PSR for alderlake-P: - EDP_SU_TRACK_ENABLE was removed and bit 30 now has other function - Some bits of PSR2_MAN_TRK_CTL moved and SF_PARTIAL_FRAME_UPDATE was removed setting SU_REGION_START/END_ADDR will do this job - SU_REGION_START/END_A

[Intel-gfx] [PATCH v2 28/50] drm/i915/adl_p: Implement TC sequences

2021-03-25 Thread Matt Roper
From: José Roberto de Souza ADL-P have basically the same TC connection and disconnection sequences as ICL and TGL, the major difference is the new registers. So here adding functions without the icl prefix in the name and making the new functions call the platform specific function to access th

[Intel-gfx] [PATCH v2 33/50] drm/i915: Move intel_modeset_all_pipes()

2021-03-25 Thread Matt Roper
From: Ville Syrjälä Move intel_modeset_all_pipes() to a central place so that we can use it elsewhere as well. No functional changes. Cc: Stanislav Lisovskiy Signed-off-by: Ville Syrjälä Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_cdclk.c

[Intel-gfx] [PATCH v2 46/50] drm/i915/adl_p: Implement Wa_22011091694

2021-03-25 Thread Matt Roper
From: José Roberto de Souza Adding a new hook to ADL-P just to avoid another platform check in gen12lp_init_clock_gating() but also open to it. BSpec: 54369 Cc: Matt Roper Cc: Anusha Srivatsa Signed-off-by: José Roberto de Souza Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- d

[Intel-gfx] [PATCH v2 42/50] drm/i915/bigjoiner: Avoid dsc_compute_config for uncompressed bigjoiner

2021-03-25 Thread Matt Roper
From: Animesh Manna For uncompressed big joiner DSC engine will not be used so will avoid compute config of DSC. Cc: Manasi Navare Signed-off-by: Animesh Manna Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_dp.c | 8 ++-- 1 file changed, 6

[Intel-gfx] [PATCH v2 44/50] drm/i915/adlp: Add PIPE_MISC2 programming

2021-03-25 Thread Matt Roper
From: Anusha Srivatsa When scalers are enabled, we need to program underrun bubble counter to 0x50 to avoid Soft Pipe A underruns. Make sure other bits dont get overwritten. Cc: Matt Roper Cc: Clint Taylor Cc: José Roberto de Souza Signed-off-by: Anusha Srivatsa Signed-off-by: Clinton Taylor

[Intel-gfx] [PATCH v2 40/50] drm/i915/adl_p: Add PLL Support

2021-03-25 Thread Matt Roper
From: Anusha Srivatsa The clocks in ALD_P is similar to that of TGL. The combo PLLs use the same DPLL0, DPLL1 and TBT_PLL. This patch adds the helper function intel_mg_pll_enable_reg() which is similar to intel_combo_pll_enable_reg() for being lookup place for PLL_ENABLE register in combo phy c

[Intel-gfx] [PATCH v2 29/50] drm/i915/adl_p: Enable modular fia

2021-03-25 Thread Matt Roper
From: José Roberto de Souza Alderlake P have modular FIA like TGL but it is always modular in all skus, not like TGL that we had to read a register to check if it is monolithic or modular. BSpec: 55480 BSpec: 50572 Cc: Imre Deak Signed-off-by: José Roberto de Souza Signed-off-by: Clinton Taylo

[Intel-gfx] [PATCH v2 49/50] drm/i915/perf: Enable OA formats for ADL_P

2021-03-25 Thread Matt Roper
From: Umesh Nerlige Ramappa Enable relevant OA formats for ADL_P. Cc: Ashutosh Dixit Signed-off-by: Umesh Nerlige Ramappa Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_perf.c | 1 + 1 file changed, 1 insertion(+) diff --g

[Intel-gfx] [PATCH v2 35/50] drm/i915/adl_p: Tx escape clock with DSI

2021-03-25 Thread Matt Roper
From: Mika Kahola Today when the DSI controller is paired with the Combo-PHY it uses the high-speed (HS) Word clock for its low power (LP) transmit PPI communication to the DPHY. The interface signaling only changes state at an Escape clock frequency (i.e. its effectively running on a virtual Tx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: add gem/gt TODO

2021-03-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: add gem/gt TODO URL : https://patchwork.freedesktop.org/series/88413/ State : warning == Summary == $ dim checkpatch origin/drm-tip 591bc42605c7 drm/i915: add gem/gt TODO -:41: WARNING:FILE_PATH_CHANGES: added, moved or deleted

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: add gem/gt TODO

2021-03-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: add gem/gt TODO URL : https://patchwork.freedesktop.org/series/88413/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: add gem/gt TODO

2021-03-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: add gem/gt TODO URL : https://patchwork.freedesktop.org/series/88413/ State : success == Summary == CI Bug Log - changes from CI_DRM_9895 -> Patchwork_19850 Summary ---

[Intel-gfx] [PATCH i-g-t 1/5] benchmarks: Build gem_exec_tracer with meson

2021-03-25 Thread Arkadiusz Hiler
Seems it has been overlooked during mesonification. It's a shared module that's meant to be LD_PRELOAD-ed to intercept EXECBUFFER2 calls for the purpose of replaying them later. Signed-off-by: Arkadiusz Hiler --- benchmarks/meson.build | 8 1 file changed, 8 insertions(+) diff --git a

[Intel-gfx] [PATCH i-g-t 4/5] .gitlab-ci: Don't test Autotools

2021-03-25 Thread Arkadiusz Hiler
Signed-off-by: Arkadiusz Hiler --- .gitlab-ci.yml | 18 -- Dockerfile.build-debian | 8 2 files changed, 26 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e226d9d7..2b03fc98 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -154,17 +154,6 @@

[Intel-gfx] [PATCH i-g-t 5/5] Get rid of GNU Autotools

2021-03-25 Thread Arkadiusz Hiler
Autotools have been deprecated in favor of Meson since early 2019. Cc: Daniel Vetter Cc: Petri Latvala Cc: Tomi Sarvela Signed-off-by: Arkadiusz Hiler --- Makefile.am | 44 --- autogen.sh | 17 - benchmarks/Makefile.am | 28 -- benchmark

[Intel-gfx] [PATCH i-g-t 3/5] tests: Remove ddx_intel_after_fbdev

2021-03-25 Thread Arkadiusz Hiler
It's not a even a proper test. Suggested-by: Petri Latvala Signed-off-by: Arkadiusz Hiler --- tests/Makefile.sources | 4 -- tests/ddx_intel_after_fbdev | 73 - 2 files changed, 77 deletions(-) delete mode 100755 tests/ddx_intel_after_fbdev diff --git

[Intel-gfx] [PATCH i-g-t 2/5] tests: Build gem_concurrent_all with meson

2021-03-25 Thread Arkadiusz Hiler
...and add it to test-list-full.txt just like we do when building with autotools. Signed-off-by: Arkadiusz Hiler --- tests/meson.build | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/meson.build b/tests/meson.build index 54a1a3c7..8e3cd390 100644 --- a/tests/meson.build

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()

2021-03-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level() URL : https://patchwork.freedesktop.org/series/88420/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:10

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()

2021-03-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level() URL : https://patchwork.freedesktop.org/series/88420/ State : success == Summary == CI Bug Log - changes from CI_DRM_9895 -> Patchwork_19851 =

[Intel-gfx] [PATCH] drm/i915/dg1: Add HWMON power sensor support

2021-03-25 Thread Dale B Stimson
As part of the System Managemenent Interface (SMI), use the HWMON subsystem to display power utilization. The following standard HWMON power sensors are currently supported (and appropriately scaled): /sys/class/drm/card0/device/hwmon/hwmon - energy1_input - power1_cap -

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drivers: gpu: drm: Remove repeated declaration

2021-03-25 Thread Patchwork
== Series Details == Series: drivers: gpu: drm: Remove repeated declaration URL : https://patchwork.freedesktop.org/series/88431/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or membe

Re: [Intel-gfx] [PATCH v3 3/8] drm/i915: add new helpers for accessing stepping info

2021-03-25 Thread Souza, Jose
On Mon, 2021-03-08 at 15:56 +0200, Jani Nikula wrote: > Add new runtime info field for stepping. Add new helpers for accessing > them. As we'll be switching platforms over to the new scheme > incrementally, check for non-initialized steppings. > > In case a platform does not have separate display

Re: [Intel-gfx] [PATCH v3 4/8] drm/i915: switch KBL to the new stepping scheme

2021-03-25 Thread Souza, Jose
On Mon, 2021-03-08 at 15:56 +0200, Jani Nikula wrote: > Add new symbolic names for revision ids, and convert KBL revids to use > them via the new stepping check macros. > > This also fixes theoretical out of bounds access to kbl_revids array. > > v2: Rename stepping->step > > Signed-off-by: Jani

[Intel-gfx] ✓ Fi.CI.BAT: success for drivers: gpu: drm: Remove repeated declaration

2021-03-25 Thread Patchwork
== Series Details == Series: drivers: gpu: drm: Remove repeated declaration URL : https://patchwork.freedesktop.org/series/88431/ State : success == Summary == CI Bug Log - changes from CI_DRM_9895 -> Patchwork_19852 Summary --- **SU

Re: [Intel-gfx] [PATCH v3 5/8] drm/i915: switch TGL and ADL to the new stepping scheme

2021-03-25 Thread Souza, Jose
On Mon, 2021-03-08 at 15:56 +0200, Jani Nikula wrote: > This changes the way revids not present in the array are handled: > > - For gaps in the array, the next present revid is used. > > - For revids beyond the array, the new STEP_FUTURE is used instead of >   the last revid in the array. > > In

Re: [Intel-gfx] [PATCH v3 8/8] drm/i915: rename i915_rev_steppings->intel_step_info

2021-03-25 Thread Souza, Jose
On Mon, 2021-03-08 at 15:56 +0200, Jani Nikula wrote: > Matter of taste. Match the prefix for everything else related to > steppings. No functional changes. Reviewed-by: José Roberto de Souza For the renaming patches, 6, 7 and 8 I'm also fine with the current naming up to you. > > Signed-off-

Re: [Intel-gfx] [PATCH] drivers: gpu: drm: Remove repeated declaration

2021-03-25 Thread Souza, Jose
The changes looks good but can you resend changing the commit message to: "drm/i915: Remove repeated declaration"? To better match with i915 patches. With this change you can add Reviewed-by: José Roberto de Souza On Thu, 2021-03-25 at 13:00 +0800, Wan Jiabing wrote: > struct drm_i915_private,

  1   2   >