[Intel-gfx] [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (v2)

2020-03-05 Thread Mario Kleiner
This fixes a problem found on the MacBookPro 2017 Retina panel. The panel reports 10 bpc color depth in its EDID, and the firmware chooses link settings at boot which support enough bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc), but the DP_MAX_LINK_RATE dpcd register only reports 2.7 Gbp

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017

2020-03-05 Thread Mario Kleiner
On Wed, Mar 4, 2020 at 4:32 PM Jani Nikula wrote: > > On Sat, 29 Feb 2020, Mario Kleiner wrote: > > This fixes a problem found on the MacBookPro 2017 Retina panel. > > > > The panel reports 10 bpc color depth in its EDID, and the > > firmware chooses link settings at boot which support enough > >

Re: [Intel-gfx] [PATCH v2 07/20] drm/i915: Unify the low level dbuf code

2020-03-05 Thread Lisovskiy, Stanislav
On Wed, 2020-03-04 at 20:30 +0200, Ville Syrjälä wrote: > On Wed, Mar 04, 2020 at 05:23:05PM +, Lisovskiy, Stanislav wrote: > > > > > - /* If 2nd DBuf slice required, enable it here */ > > >if (INTEL_GEN(dev_priv) >= 11 && slices_union != > > > hw_enabled_slices) > > > -

[Intel-gfx] [PATCH] drm/i915: Improve the start alignment of bonded pairs

2020-03-05 Thread Chris Wilson
Always wait on the start of the signaler request to reduce the problem of dequeueing the bonded pair too early -- we want both payloads to start at the same time, with no latency, and yet still allow others to make full use of the slack in the system. Remindme: add testcases for starting the bonde

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm/i915: Apply i915_request_skip() on submission

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Apply i915_request_skip() on submission URL : https://patchwork.freedesktop.org/series/74264/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8063_full -> Patchwork_16816_full =

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (v2)

2020-03-05 Thread Jani Nikula
On Thu, 05 Mar 2020, Mario Kleiner wrote: > This fixes a problem found on the MacBookPro 2017 Retina panel. > > The panel reports 10 bpc color depth in its EDID, and the > firmware chooses link settings at boot which support enough > bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc), > but t

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (v2)

2020-03-05 Thread Jani Nikula
On Thu, 05 Mar 2020, Jani Nikula wrote: > On Thu, 05 Mar 2020, Mario Kleiner wrote: >> This fixes a problem found on the MacBookPro 2017 Retina panel. >> >> The panel reports 10 bpc color depth in its EDID, and the >> firmware chooses link settings at boot which support enough >> bandwidth for 10

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use firmware v2.06 for TGL

2020-03-05 Thread Jani Nikula
On Wed, 04 Mar 2020, Daniele Ceraolo Spurio wrote: > On 3/3/20 1:29 AM, Jani Nikula wrote: >> Please ensure 2.06 is in linux-firmware upstream before v5.7 kernel >> release. > > I've just sent the PR to linux-firmware so it shouldn't be an issue to > get the binary upstream in time for 5.6, but

Re: [Intel-gfx] [PATCH v2 07/20] drm/i915: Unify the low level dbuf code

2020-03-05 Thread Lisovskiy, Stanislav
On Tue, 2020-02-25 at 19:11 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The low level dbuf slice code is rather inconsitent with its > functiona naming and organization. Make it more consistent. > > Also share the enable/disable functions between all platforms > since the same code wor

Re: [Intel-gfx] [PATCH] drm/i915/display: Decrease log level

2020-03-05 Thread Lisovskiy, Stanislav
On Tue, 2020-03-03 at 03:08 +0530, Swati Sharma wrote: > Converting error to debug print if sink fails to configure scrambling > or > TMDS bit clock ratio. In this case, we are timing out while disabling > the scrambling and setting the SCDC ratio, as there is no response > to the I2C SCDC write fr

Re: [Intel-gfx] [PATCH v3] drm/i915/dsb: Pre allocate and late cleanup of cmd buffer

2020-03-05 Thread Daniel Vetter
On Wed, Feb 12, 2020 at 08:15:22PM +0530, Animesh Manna wrote: > Pre-allocate command buffer in atomic_commit using intel_dsb_prepare > function which also includes pinning and map in cpu domain. > > No change is dsb write/commit functions. > > Now dsb get/put function is refactored and currently

Re: [Intel-gfx] [PATCH v6 1/3] intel_acpi: Rename drm_dev local variable to dev

2020-03-05 Thread Jani Nikula
On Wed, 04 Mar 2020, Rajat Jain wrote: > Change the struct drm_device * local variable from drm_dev to dev > per the feedback received here: > https://lkml.org/lkml/2020/1/24/1143 > > Signed-off-by: Rajat Jain Reviewed-by: Jani Nikula > --- > v6: Initial patch (v6 to match other patches in the

Re: [Intel-gfx] [PATCH v6 2/3] drm/i915: Lookup and attach ACPI device node for connectors

2020-03-05 Thread Jani Nikula
On Wed, 04 Mar 2020, Rajat Jain wrote: > Lookup and attach ACPI nodes for intel connectors. The lookup is done > in compliance with ACPI Spec 6.3 > https://uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf > (Ref: Pages 1119 - 1123). > > This can be useful for any connector specific

Re: [Intel-gfx] [PATCH v2 06/20] drm/i915: Polish some dbuf debugs

2020-03-05 Thread Lisovskiy, Stanislav
On Wed, 2020-03-04 at 20:26 +0200, Ville Syrjälä wrote: > On Wed, Mar 04, 2020 at 04:29:47PM +, Lisovskiy, Stanislav wrote: > > On Tue, 2020-02-25 at 19:11 +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Polish some of the dbuf code to give more meaningful debug > > > messag

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Add support for integrated privacy screens

2020-03-05 Thread Jani Nikula
On Wed, 04 Mar 2020, Rajat Jain wrote: > Certain laptops now come with panels that have integrated privacy > screens on them. This patch adds support for such panels by adding > a privacy-screen property to the intel_connector for the panel, that > the userspace can then use to control and check t

Re: [Intel-gfx] [PATCH v6 1/3] intel_acpi: Rename drm_dev local variable to dev

2020-03-05 Thread Jani Nikula
On Wed, 04 Mar 2020, Rajat Jain wrote: > Change the struct drm_device * local variable from drm_dev to dev > per the feedback received here: > https://lkml.org/lkml/2020/1/24/1143 I don't know what's up with the two identical (or similar) threads here, but I replied in the thread starting at [1].

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Add mechanism to submit a context WA on ring submission URL : https://patchwork.freedesktop.org/series/74281/ State : warning == Summary == $ dim checkpatch origin/drm-tip efd9736ffc9a drm/i915: Add mechanism to submit a con

[Intel-gfx] [PULL] drm-misc-fixes

2020-03-05 Thread Maarten Lankhorst
drm-misc-fixes-2020-03-05: Fixes for v5.6.rc5: - Fix memory leak - Fix resource id creation race in virtio. - Various mmap fixes. - Fix fence leak in ttm_buffer_object_transfer(). - Fixes for sun4i VI layer format support. - kirin: Revert "Fix for hikey620 display offset problem" The following chan

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [CI,1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Add mechanism to submit a context WA on ring submission URL : https://patchwork.freedesktop.org/series/74281/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dp

[Intel-gfx] [PULL] drm-intel-fixes

2020-03-05 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2020-03-05: drm/i915 fixes for v5.6-rc5: - Break up long lists of object reclaim with cond_resched() - PSR probe fix - TGL workarounds - Selftest return value fix - Drop timeline mutex while waiting for retirement - Wait for OA configuration completion before wr

[Intel-gfx] [PATCH] drm/i915: Actually emit the await_start

2020-03-05 Thread Chris Wilson
Fix the inverted test to emit the wait on the end of the previous request if we /haven't/ already. Fixes: 6a79d848403d ("drm/i915: Lock signaler timeline while navigating") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: # v5.5+ --- drivers/gpu/drm/i915/i915_request.c | 2 +- 1 file changed

Re: [Intel-gfx] [PATCH] drm/i915/gem: Limit struct_mutex to eb_reserve

2020-03-05 Thread Jani Nikula
On Wed, 04 Mar 2020, Chris Wilson wrote: > drivers/gpu/drm/i915/i915_drv.h | 6 --- Immediately looks like a good patch! BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Add mechanism to submit a context WA on ring submission URL : https://patchwork.freedesktop.org/series/74281/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8068 -> Patchwork_16825 ===

Re: [Intel-gfx] [PATCH] drm/i915: Actually emit the await_start

2020-03-05 Thread Tvrtko Ursulin
On 05/03/2020 10:42, Chris Wilson wrote: Fix the inverted test to emit the wait on the end of the previous request if we /haven't/ already. Fixes: 6a79d848403d ("drm/i915: Lock signaler timeline while navigating") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: # v5.5+ --- drivers/gpu/

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_balancer: Exercise bonded-payload synchronisation

2020-03-05 Thread Chris Wilson
Our goal with bonded submission is to submit the pair of user batches to the HW at roughly the same time, and trying to avoid any bubbles. If we submit the secondary batch too early, it will be running before the first and stuck on the HW preventing others from utilising the GPU. At worst, it may e

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for gem_userptr_blits: mmap-offset-invalidate enhancements

2020-03-05 Thread Janusz Krzysztofik
Hi, Here are my comments to CI results from testing the IGT changes on Trybot with kernel change that prevents non-GTT mmap-offset mapping to userptr reverted. On Thu, 2020-03-05 at 06:15 +, Patchwork wrote: > == Series Details == > > Series: gem_userptr_blits: mmap-offset-invalidate enhance

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Enable timeslice on partial virtual engine dequeue

2020-03-05 Thread Mika Kuoppala
Chris Wilson writes: > If we stop filling the ELSP due to an incompatible virtual engine > request, check if we should enable the timeslice on behalf of the queue. > Leaves me pondering more of the why. So that on these boundaries also, the last rq gets subdued to a timeslice and not get a free

Re: [Intel-gfx] [PATCH] drm/i915: Improve the start alignment of bonded pairs

2020-03-05 Thread Mika Kuoppala
Chris Wilson writes: > Always wait on the start of the signaler request to reduce the problem > of dequeueing the bonded pair too early -- we want both payloads to > start at the same time, with no latency, and yet still allow others to > make full use of the slack in the system. > > Remindme: ad

[Intel-gfx] [CI 2/2] drm/i915/gen7: Clear all EU/L3 residual contexts

2020-03-05 Thread Chris Wilson
From: Prathap Kumar Valsan On gen7 and gen7.5 devices, there could be leftover data residuals in EU/L3 from the retiring context. This patch introduces workaround to clear that residual contexts, by submitting a batch buffer with dedicated HW context to the GPU with ring allocation for each conte

[Intel-gfx] [CI 1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-03-05 Thread Chris Wilson
From: Mika Kuoppala This patch adds framework to submit an arbitrary batchbuffer on each context switch to clear residual state for render engine on Gen7/7.5 devices. The idea of always emitting the context and vm setup around each request is primary to make reset recovery easy, and not require

Re: [Intel-gfx] [igt-dev] [PATCH] i915/gem_exec_params: add test_invalid_batch_start

2020-03-05 Thread Mika Kuoppala
Matthew Auld writes: > Sanity check that kernel rejects too large batch_start_offset. > > Signed-off-by: Matthew Auld > Cc: Chris Wilson > --- > tests/i915/gem_exec_params.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/tests/i915/gem_exec_params.c b/tests/i915

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: properly sanity check batch_start_offset

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915: properly sanity check batch_start_offset URL : https://patchwork.freedesktop.org/series/74287/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter or

Re: [Intel-gfx] [PATCH] drm/i915: properly sanity check batch_start_offset

2020-03-05 Thread Mika Kuoppala
Matthew Auld writes: > Check the edge case where batch_start_offset sits exactly on the batch > size. > > Testcase: igt/gem_exec_params/invalid-batch-start-offset > Fixes: 0b5372727be3 ("drm/i915/cmdparser: Use cached vmappings") > Signed-off-by: Matthew Auld > Cc: Chris Wilson > --- > drivers

[Intel-gfx] [RESEND PATCH v2 0/7] drm: drm_fb_helper cleanup.

2020-03-05 Thread Pankaj Bharadiya
This series addresses below drm_fb_helper tasks from Documentation/gpu/todo.rst. - The max connector argument for drm_fb_helper_init() isn't used anymore and can be removed. - The helper doesn't keep an array of connectors anymore so these can be removed: drm_fb_helper_single_add_all_connecto

[Intel-gfx] [RESEND PATCH v2 3/7] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-05 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya Reviewed-by: Emil Velikov Re

[Intel-gfx] [RESEND PATCH v2 2/7] drm/radeon: remove radeon_fb_{add, remove}_connector functions

2020-03-05 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya Reviewed-by: Emil Velikov Re

[Intel-gfx] ✗ Fi.CI.BUILD: failure for i915/gem_exec_params: add test_invalid_batch_start

2020-03-05 Thread Patchwork
== Series Details == Series: i915/gem_exec_params: add test_invalid_batch_start URL : https://patchwork.freedesktop.org/series/74289/ State : failure == Summary == Applying: i915/gem_exec_params: add test_invalid_batch_start error: sha1 information is lacking or useless (tests/i915/gem_exec_pa

[Intel-gfx] [RESEND PATCH v2 1/7] drm: Remove unused arg from drm_fb_helper_init

2020-03-05 Thread Pankaj Bharadiya
The max connector argument for drm_fb_helper_init() isn't used anymore hence remove it. All the drm_fb_helper_init() calls are modified with below sementic patch. @@ expression E1, E2, E3; @@ - drm_fb_helper_init(E1,E2, E3) + drm_fb_helper_init(E1,E2) Signed-off-by: Pankaj Bharadiya Reviewed-

[Intel-gfx] [RESEND PATCH v2 4/7] drm/i915/display: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-05 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya Reviewed-by: Emil Velikov Re

[Intel-gfx] [RESEND PATCH v2 5/7] drm: Remove drm_fb_helper add, add all and remove connector calls

2020-03-05 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() and drm_fb_helper_single_add_all_connectors() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h This removal is

[Intel-gfx] [RESEND PATCH v2 7/7] drm/todo: Update drm_fb_helper tasks

2020-03-05 Thread Pankaj Bharadiya
drm_fb_helper tasks are completed now hence remove them from todo list. Changes since v1: * remove entire drm_fb_helper tasks from todo list. Daniel's "64914da24ea9 drm/fbdev-helper: don't force restores" already fixes first one (Daniel) Signed-off-by: Pankaj Bharadiya Reviewed-by: Laurent P

[Intel-gfx] [RESEND PATCH v2 6/7] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions

2020-03-05 Thread Pankaj Bharadiya
drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector() don't keep an array of connectors anymore and are just dummy. Now we have no callers to these functions hence remove them. Signed-off-by: Pankaj Bharadiya Reviewed-by: Laurent Pin

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: properly sanity check batch_start_offset

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915: properly sanity check batch_start_offset URL : https://patchwork.freedesktop.org/series/74287/ State : success == Summary == CI Bug Log - changes from CI_DRM_8068 -> Patchwork_16826 Summary ---

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_balancer: Exercise bonded-payload synchronisation

2020-03-05 Thread Tvrtko Ursulin
On 05/03/2020 11:15, Chris Wilson wrote: Our goal with bonded submission is to submit the pair of user batches to the HW at roughly the same time, and trying to avoid any bubbles. If we submit the secondary batch too early, it will be running before the first and stuck on the HW preventing othe

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gem: Limit struct_mutex to eb_reserve

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915/gem: Limit struct_mutex to eb_reserve URL : https://patchwork.freedesktop.org/series/74291/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter or memb

Re: [Intel-gfx] [PATCH] drm/i915/tgl: WaDisableGPGPUMidThreadPreemption

2020-03-05 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-03-04 15:31:44) > From: Tvrtko Ursulin > > Enable FtrPerCtxtPreemptionGranularityControl bit and select thread- > group as the default preemption level. > > v2: > * Remove register whitelisting (Rafael, Tony). > > Signed-off-by: Tvrtko Ursulin > Cc: Michał Winiars

Re: [Intel-gfx] [PATCH] drm/i915/tgl: WaDisableGPGPUMidThreadPreemption

2020-03-05 Thread Ye, Tony
On 3/5/2020 1:01 AM, Rafael Antognolli wrote: On Wed, Mar 04, 2020 at 04:24:13PM +, Tvrtko Ursulin wrote: On 04/03/2020 16:02, Rafael Antognolli wrote: On Wed, Mar 04, 2020 at 03:31:44PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Enable FtrPerCtxtPreemptionGranularityControl bi

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Limit struct_mutex to eb_reserve

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915/gem: Limit struct_mutex to eb_reserve URL : https://patchwork.freedesktop.org/series/74291/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8068 -> Patchwork_16828 Summary --- **FA

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/1] Revert "drm/i915/tgl: Add extra hdc flush workaround"

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [1/1] Revert "drm/i915/tgl: Add extra hdc flush workaround" URL : https://patchwork.freedesktop.org/series/74293/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: w

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Enable timeslice on partial virtual engine dequeue

2020-03-05 Thread Mika Kuoppala
Mika Kuoppala writes: > Chris Wilson writes: > >> If we stop filling the ELSP due to an incompatible virtual engine >> request, check if we should enable the timeslice on behalf of the queue. >> > > Leaves me pondering more of the why. > > So that on these boundaries also, the last rq gets subdu

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] Revert "drm/i915/tgl: Add extra hdc flush workaround"

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [1/1] Revert "drm/i915/tgl: Add extra hdc flush workaround" URL : https://patchwork.freedesktop.org/series/74293/ State : success == Summary == CI Bug Log - changes from CI_DRM_8068 -> Patchwork_16829 ==

Re: [Intel-gfx] [PATCH v2 07/20] drm/i915: Unify the low level dbuf code

2020-03-05 Thread Ville Syrjälä
On Thu, Mar 05, 2020 at 08:28:30AM +, Lisovskiy, Stanislav wrote: > On Wed, 2020-03-04 at 20:30 +0200, Ville Syrjälä wrote: > > On Wed, Mar 04, 2020 at 05:23:05PM +, Lisovskiy, Stanislav wrote: > > > > > > > - /* If 2nd DBuf slice required, enable it here */ > > > >if (INTEL_

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: WaDisableGPGPUMidThreadPreemption

2020-03-05 Thread Tvrtko Ursulin
On 04/03/2020 19:11, Patchwork wrote: == Series Details == Series: drm/i915/tgl: WaDisableGPGPUMidThreadPreemption URL : https://patchwork.freedesktop.org/series/74274/ State : success == Summary == CI Bug Log - changes from CI_DRM_8066 -> Patchwork_16821 ==

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (rev6)

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (rev6) URL : https://patchwork.freedesktop.org/series/72747/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Fu

Re: [Intel-gfx] [PATCH v2 06/20] drm/i915: Polish some dbuf debugs

2020-03-05 Thread Ville Syrjälä
On Thu, Mar 05, 2020 at 09:53:34AM +, Lisovskiy, Stanislav wrote: > On Wed, 2020-03-04 at 20:26 +0200, Ville Syrjälä wrote: > > On Wed, Mar 04, 2020 at 04:29:47PM +, Lisovskiy, Stanislav wrote: > > > On Tue, 2020-02-25 at 19:11 +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (rev6)

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (rev6) URL : https://patchwork.freedesktop.org/series/72747/ State : success == Summary == CI Bug Log - changes from CI_DRM_8068 -> Patchwork_16830

[Intel-gfx] [PATCH] drm/i915: Return early for await_start on same timeline

2020-03-05 Thread Chris Wilson
Requests within a timeline are ordered by that timeline, so awaiting for the start of a request within the timeline is a no-op. This used to work by falling out of the mutex_trylock() as the signaler and waiter had the same timeline and not returning an error. Fixes: 6a79d848403d ("drm/i915: Lock

[Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime and R0 checks during auth

2020-03-05 Thread Oliver Barta
From: Oliver Barta Including HDCP_STATUS_ENC bit in the checks is pointless. It is simply not set at this point. Signed-off-by: Oliver Barta Fixes: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base implementation") --- [v2] rebased on top of latest changes drivers/gpu/drm/i915/display/intel

Re: [Intel-gfx] [PATCH] drm/i915/display: Decrease log level

2020-03-05 Thread Ville Syrjälä
On Thu, Mar 05, 2020 at 08:55:31AM +, Lisovskiy, Stanislav wrote: > On Tue, 2020-03-03 at 03:08 +0530, Swati Sharma wrote: > > Converting error to debug print if sink fails to configure scrambling > > or > > TMDS bit clock ratio. In this case, we are timing out while disabling > > the scramblin

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Don't check for wm changes until we've compute the wms fully

2020-03-05 Thread Ville Syrjälä
On Wed, Mar 04, 2020 at 11:25:42PM +, Souza, Jose wrote: > On Wed, 2020-03-04 at 13:46 +0200, Ville Syrjälä wrote: > > On Wed, Mar 04, 2020 at 12:21:01AM +, Souza, Jose wrote: > > > On Fri, 2020-02-28 at 22:35 +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > > > > > Current

Re: [Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check

2020-03-05 Thread Oliver Barta
On Tue, Mar 3, 2020 at 10:33 AM Ramalingam C wrote: > > On 2020-02-29 at 11:39:22 +0100, Oliver Barta wrote: > > From: Oliver Barta > > > > The check was always succeeding even in case of a mismatch due to the > > HDCP_STATUS_ENC bit being set. Make sure both bits are actually set. > > > > Signed

[Intel-gfx] [PATCH] drm/i915/execlists: Show the "switch priority hint" in dumps

2020-03-05 Thread Chris Wilson
Show the timeslicing priority hint in engine dumps to aide debugging. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_lrc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt

Re: [Intel-gfx] [PATCH v2 07/20] drm/i915: Unify the low level dbuf code

2020-03-05 Thread Lisovskiy, Stanislav
On Thu, 2020-03-05 at 15:37 +0200, Ville Syrjälä wrote: > On Thu, Mar 05, 2020 at 08:28:30AM +, Lisovskiy, Stanislav wrote: > > On Wed, 2020-03-04 at 20:30 +0200, Ville Syrjälä wrote: > > > On Wed, Mar 04, 2020 at 05:23:05PM +, Lisovskiy, Stanislav > > > wrote: > > > > > > > > > - /*

[Intel-gfx] [PATCH] drm/i915/gem: Limit struct_mutex to eb_reserve

2020-03-05 Thread Chris Wilson
We only need to serialise the multiple pinning during the eb_reserve phase. Ideally this would be using the vm->mutex as an outer lock, or using a composite global mutex (ww_mutex), but at the moment we are using struct_mutex for the group. Fixes: 003d8b9143a6 ("drm/i915/gem: Only call eb_lookup_v

Re: [Intel-gfx] [PATCH] drm/i915: Return early for await_start on same timeline

2020-03-05 Thread Tvrtko Ursulin
On 05/03/2020 13:48, Chris Wilson wrote: Requests within a timeline are ordered by that timeline, so awaiting for the start of a request within the timeline is a no-op. This used to work by falling out of the mutex_trylock() as the signaler and waiter had the same timeline and not returning an

Re: [Intel-gfx] [PATCH v2 06/20] drm/i915: Polish some dbuf debugs

2020-03-05 Thread Lisovskiy, Stanislav
On Thu, 2020-03-05 at 15:46 +0200, Ville Syrjälä wrote: > On Thu, Mar 05, 2020 at 09:53:34AM +, Lisovskiy, Stanislav wrote: > > On Wed, 2020-03-04 at 20:26 +0200, Ville Syrjälä wrote: > > > On Wed, Mar 04, 2020 at 04:29:47PM +, Lisovskiy, Stanislav > > > wrote: > > > > On Tue, 2020-02-25 at

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Show the "switch priority hint" in dumps

2020-03-05 Thread Mika Kuoppala
Chris Wilson writes: > Show the timeslicing priority hint in engine dumps to aide debugging. > > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff -

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix documentation for intel_dpll_get_freq()

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915: Fix documentation for intel_dpll_get_freq() URL : https://patchwork.freedesktop.org/series/74272/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8066_full -> Patchwork_16820_full Summar

Re: [Intel-gfx] [PATCH] drm/i915/gem: Limit struct_mutex to eb_reserve

2020-03-05 Thread Mika Kuoppala
Chris Wilson writes: > We only need to serialise the multiple pinning during the eb_reserve > phase. Ideally this would be using the vm->mutex as an outer lock, or > using a composite global mutex (ww_mutex), but at the moment we are > using struct_mutex for the group. > > Fixes: 003d8b9143a6 ("d

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/edp: Ignore short pulse when panel powered off

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915/edp: Ignore short pulse when panel powered off URL : https://patchwork.freedesktop.org/series/74265/ State : success == Summary == CI Bug Log - changes from CI_DRM_8066_full -> Patchwork_16817_full Summ

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: WaDisableGPGPUMidThreadPreemption

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915/tgl: WaDisableGPGPUMidThreadPreemption URL : https://patchwork.freedesktop.org/series/74274/ State : success == Summary == CI Bug Log - changes from CI_DRM_8066_full -> Patchwork_16821_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Cancel banned contexts after GT reset

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915/gt: Cancel banned contexts after GT reset URL : https://patchwork.freedesktop.org/series/74276/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8066_full -> Patchwork_16822_full Summary -

[Intel-gfx] [PATCH] drm/i915: Fix crtc nv12 etc. plane bitmasks for DPMS off

2020-03-05 Thread Ville Syrjala
From: Ville Syrjälä We only consider crtc_state->enable when initially calculating plane visibility. Later on we try to override the plane's state to invisible if the crtc is in DPMS off state (crtc_state->active==false). Unfortunately the code doing that only updates the plane_state.visible flag

[Intel-gfx] [PATCH i-g-t] tests/gem_exec_gttfill: MMAP_OFFSET related refresh

2020-03-05 Thread Janusz Krzysztofik
The test already tried to use a working mapping by first trying legacy WC, then GTT. Use gem_mmap__device_coherent() helper instead of approaching its implementation locally. Signed-off-by: Janusz Krzysztofik --- tests/i915/gem_exec_gttfill.c | 13 - 1 file changed, 4 insertions(+),

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Adding YUV444 packed format support for skl+ (rev4)

2020-03-05 Thread Bob Paauwe
On Sat, 29 Feb 2020 09:11:20 + Patchwork wrote: > == Series Details == > > Series: Adding YUV444 packed format support for skl+ (rev4) > URL : https://patchwork.freedesktop.org/series/73020/ > State : failure I'm a bit confused by this. The build changes listed at the bottom indicate tha

Re: [Intel-gfx] [PATCH 5/6] drm/i915/uc: Move uC debugfs to its own folder under GT

2020-03-05 Thread Andi Shyti
Hi Daniele, > > On Thu, Feb 27, 2020 at 06:28:42PM -0800, Daniele Ceraolo Spurio wrote: > > > uC is a component of the GT, so it makes sense for the uC debugfs files > > > to be in the GT folder. A subfolder has been used to keep the same > > > structure we have for the code. > > > > Can we pleas

[Intel-gfx] [PATCH] drm/i915/tgl: Make wa_1606700617 permanent

2020-03-05 Thread Swathi Dhanavanthri
This workaround is to disable FF DOP Clock gating. The fix in B0 was backed out due to timing reasons and decided to be made permanent. Bspec: 52890 Signed-off-by: Swathi Dhanavanthri --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev URL : https://patchwork.freedesktop.org/series/74298/ State : warning == Summary == $ dim checkpatch origin/drm-tip c20368a27477 intel_acpi: Rename drm_dev local variable to dev f4a4471

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev URL : https://patchwork.freedesktop.org/series/74298/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: war

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev URL : https://patchwork.freedesktop.org/series/74298/ State : success == Summary == CI Bug Log - changes from CI_DRM_8070 -> Patchwork_16831

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev URL : https://patchwork.freedesktop.org/series/74299/ State : warning == Summary == $ dim checkpatch origin/drm-tip e83f0d80506c intel_acpi: Rename drm_dev local variable to dev 0dfdbf2

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/1] Revert "drm/i915/tgl: Add extra hdc flush workaround"

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [1/1] Revert "drm/i915/tgl: Add extra hdc flush workaround" URL : https://patchwork.freedesktop.org/series/74277/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8066_full -> Patchwork_16823_full

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev URL : https://patchwork.freedesktop.org/series/74299/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: war

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev

2020-03-05 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] intel_acpi: Rename drm_dev local variable to dev URL : https://patchwork.freedesktop.org/series/74299/ State : success == Summary == CI Bug Log - changes from CI_DRM_8070 -> Patchwork_16832

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/execlists: Enable timeslice on partial virtual engine dequeue

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Enable timeslice on partial virtual engine dequeue URL : https://patchwork.freedesktop.org/series/74304/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Fun

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (rev2)

2020-03-05 Thread Patchwork
== Series Details == Series: drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (rev2) URL : https://patchwork.freedesktop.org/series/74100/ State : failure == Summary == Applying: drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 (v2) Using index info to reconstruct a bas

[Intel-gfx] [PATCH v5 02/16] drm/i915: Clear the repeater bit on HDCP disable

2020-03-05 Thread Sean Paul
From: Sean Paul On HDCP disable, clear the repeater bit. This ensures if we connect a non-repeater sink after a repeater, the bit is in the state we expect. Fixes: ee5e5e7a5e0f (drm/i915: Add HDCP framework + base implementation) Cc: Chris Wilson Cc: Ramalingam C Cc: Daniel Vetter Cc: Sean Pa

[Intel-gfx] [PATCH v5 01/16] drm/i915: Fix sha_text population code

2020-03-05 Thread Sean Paul
From: Sean Paul This patch fixes a few bugs: 1- We weren't taking into account sha_leftovers when adding multiple ksvs to sha_text. As such, we were or'ing the end of ksv[j - 1] with the beginning of ksv[j] 2- In the sha_leftovers == 2 and sha_leftovers == 3 case, bstatus was being pla

[Intel-gfx] [PATCH v5 04/16] drm/i915: Intercept Aksv writes in the aux hooks

2020-03-05 Thread Sean Paul
From: Sean Paul Instead of hand rolling the transfer ourselves in the hdcp hook, inspect aux messages and add the aksv flag in the aux transfer hook. IIRC, this was the original implementation and folks wanted this hack to be isolated to the hdcp code, which makes sense. However in testing an L

[Intel-gfx] [PATCH v5 15/16] drm/i915: Print HDCP version info for all connectors

2020-03-05 Thread Sean Paul
From: Sean Paul De-duplicate the HDCP version code for each connector and print it for all connectors. Cc: Juston Li Cc: Ramalingam C Reviewed-by: Juston Li Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20200227185714.171466-1-s...@

[Intel-gfx] [PATCH v5 07/16] drm/i915: Protect workers against disappearing connectors

2020-03-05 Thread Sean Paul
From: Sean Paul This patch adds some protection against connectors being destroyed before the HDCP workers are finished. For check_work, we do a synchronous cancel after the connector is unregistered which will ensure that it is finished before destruction. In the case of prop_work, we can't do

[Intel-gfx] [PATCH v5 11/16] drm/i915: Factor out HDCP shim functions from dp for use by dp_mst

2020-03-05 Thread Sean Paul
From: Sean Paul These functions are all the same for dp and dp_mst, so move them into a dedicated file for both sst and mst to use. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-11-s...@poorly.run #v1 Link: https://patchwork.freedesktop.org

[Intel-gfx] [PATCH v5 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors

2020-03-05 Thread Sean Paul
From: Sean Paul Hello friends, Another version of HDCP over MST rebased on -tip (pls stop refactoring stuff!). I've also added a couple of fixes to fix bugs found when I did some testing I on a non-CrOS laptop. PTAL, Sean Sean Paul (16): drm/i915: Fix sha_text population code drm/i915: C

[Intel-gfx] [PATCH v5 03/16] drm/i915: WARN if HDCP signalling is enabled upon disable

2020-03-05 Thread Sean Paul
From: Sean Paul HDCP signalling should not be left on, WARN if it is Cc: Ville Syrjälä Cc: Daniel Vetter Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191212190230.188505-4-s...@poorly.run #v2 Link: https://patchwork.freedesktop.o

[Intel-gfx] [PATCH v5 06/16] drm/i915: Factor out hdcp->value assignments

2020-03-05 Thread Sean Paul
From: Sean Paul This is a bit of housecleaning for a future patch. Instead of sprinkling hdcp->value assignments and prop_work scheduling everywhere, introduce a function to do it for us. Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20

[Intel-gfx] [PATCH v5 13/16] drm/i915: Add connector to hdcp_shim->check_link()

2020-03-05 Thread Sean Paul
From: Sean Paul Currently we derive the connector from digital port in check_link(). For MST, this isn't sufficient since the digital port passed into the function can have multiple connectors downstream. This patch adds connector to the check_link() arguments so we have it when we need it. Sign

[Intel-gfx] [PATCH v5 05/16] drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling

2020-03-05 Thread Sean Paul
From: Sean Paul Instead of using intel_dig_port's encoder pipe to determine which transcoder to toggle signalling on, use the cpu_transcoder field already stored in intel_hdmi. This is particularly important for MST. Suggested-by: Ville Syrjälä Reviewed-by: Ramalingam C Signed-off-by: Sean Pa

[Intel-gfx] [PATCH v5 08/16] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it

2020-03-05 Thread Sean Paul
From: Sean Paul This patch is required for HDCP over MST. If a port is being used for multiple HDCP streams, we don't want to fully disable HDCP on a port if one of them is disabled. Instead, we just disable the HDCP signalling on that particular pipe and exit early. The last pipe to disable HDCP

[Intel-gfx] [PATCH v5 09/16] drm/i915: Support DP MST in enc_to_dig_port() function

2020-03-05 Thread Sean Paul
From: Sean Paul Although DP_MST fake encoders are not subclassed from digital ports, they are associated with them. Support these encoders. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-9-s...@poorly.run #v1 Link: https://patchwork.freedesk

[Intel-gfx] [PATCH v5 10/16] drm/i915: Use ddi_update_pipe in intel_dp_mst

2020-03-05 Thread Sean Paul
From: Sean Paul In order to act upon content_protection property changes, we'll need to implement the .update_pipe() hook. We can re-use intel_ddi_update_pipe for this Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191203173638.94919-10-s...@poorly.run #v1 Link

  1   2   >