Re: [Intel-gfx] [PATCH v9 0/6] drm/i915/dp: Support for DP YCbCr4:2:0 outputs

2019-05-23 Thread Jani Nikula
On Tue, 21 May 2019, Gwan-gyeong Mun wrote: > On Gen 11 platform, to enable resolutions like 5K@120 (or higher) we need > to use DSC (DP 1.4) or YCbCr4:2:0 (DP 1.3 or 1.4) on DP. > In order to support YCbCr4:2:0 on DP we need to program YCBCR 4:2:0 > to MSA and VSC SDP. > And Link M/N values are c

Re: [Intel-gfx] [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-23 Thread Jani Nikula
On Wed, 22 May 2019, Ville Syrjälä wrote: > Pushed the core/etc. bits to drm-misc-next so that other drivers > can base their work on that. We'll need a backmerge to get the > i915 stuff in via dinq. To avoid any confusion, drm-misc-next needs to get merged to drm-next, which then needs to be bac

[Intel-gfx] [PATCH i-g-t] i915: Improve static engine map for legacy

2019-05-23 Thread Chris Wilson
We need to keep igt working on linus and dif, or Joonas gets very upset. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Andi Shyti Cc: Joonas Lahtinen --- lib/i915/gem_context.c | 2 +- lib/i915/gem_engine_topology.c | 15 +++--- lib/igt_gt.c | 54 --

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-23 Thread Maxime Ripard
Hi Stephen, On Tue, May 21, 2019 at 10:51:51AM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm-misc tree got a conflict in: > > Documentation/devicetree/bindings/vendor-prefixes.txt > > between commit: > > 8122de54602e ("dt-bindings: Convert vendor prefixes to

[Intel-gfx] [PATCH 03/10] drm/i915/dmc: add support for package_header with version 2

2019-05-23 Thread Lucas De Marchi
The only meaninful change is that it supports up to 32 fw_info entries rather than the previous max=20. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_csr.c | 35 ++-- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 01/10] drm/i915/dmc: use kernel types

2019-05-23 Thread Lucas De Marchi
Change all fields in intel_package_header and intel_dmc_header whose meaning are 1-byte numbers to use u8. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_csr.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers

[Intel-gfx] [PATCH 05/10] drm/i915/dmc: extract function to parse package_header

2019-05-23 Thread Lucas De Marchi
Like parse_csr_fw_css() this parses the package_header from firmware and saves the relevant fields in the csr struct. In this function we also lookup the fw_info we are interested in. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_csr.c | 94 +++- 1 fil

[Intel-gfx] [PATCH 08/10] drm/i915/dmc: remove redundant return in parse_csr_fw()

2019-05-23 Thread Lucas De Marchi
parse_csr_fw() is responsible to set up several fields in struct intel_csr, including the payload. We don't need to assign it again. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_csr.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/

[Intel-gfx] [PATCH 09/10] drm/i915/dmc: protect against reading random memory

2019-05-23 Thread Lucas De Marchi
While loading the DMC firmware we were double checking the headers made sense, but in no place we checked that we were actually reading memory we were supposed to. This could be wrong in case the firmware file is truncated. Before parsing any part of the firmware, validate the input first. Signed

[Intel-gfx] [PATCH 04/10] drm/i915/dmc: extract function to parse css header

2019-05-23 Thread Lucas De Marchi
Let's start splitting the parse function, making all of them return the number of bytes parsed - different versions of the firmware header may require different sizes for the structures. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_csr.c | 49 +++- 1

[Intel-gfx] [PATCH 06/10] drm/i915/dmc: extract function to parse dmc_header

2019-05-23 Thread Lucas De Marchi
Complete the extraction of functions to parse specific parts of the firmware. The return of the function parse_csr_fw() is now redundant since it already sets the dmc_payload field. Changing it is left for later to avoid noise in the commit. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH 02/10] drm/i915/dmc: extract fw_info and table walk from intel_package_header

2019-05-23 Thread Lucas De Marchi
Move fw_info out of struct intel_package_header to allow it to grow more easily in future. To make a cleaner move, let's also extract a function to search the header for the dmc_offset. While reviewing this code I wondered why we continued the search even after finding a suitable firmware. Add a c

[Intel-gfx] [PATCH 10/10] drm/i915/dmc: protect against loading wrong firmware

2019-05-23 Thread Lucas De Marchi
In intel_package_header version 2 there's a new field in the fw_info table that must be 0, otherwise it's not the correct DMC firmware. Add a check for version 2 or later. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_csr.c | 14 +++--- 1 file changed, 11 insertions(+), 3

[Intel-gfx] [PATCH 07/10] drm/i915/dmc: add support to load dmc_header version 3

2019-05-23 Thread Lucas De Marchi
Main difference is that now there are up to 20 MMIOs that can be set and a lot of noise due to the struct changing the fields in the middle. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_drv.h | 4 +- drivers/gpu/drm/i915/intel_csr.c | 107 +++ 2 fil

Re: [Intel-gfx] [PATCH i-g-t] i915: Improve static engine map for legacy

2019-05-23 Thread Andi Shyti
Hi Chris, On Thu, May 23, 2019 at 09:06:49AM +0100, Chris Wilson wrote: > We need to keep igt working on linus and dif, or Joonas gets very upset. > > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Cc: Andi Shyti > Cc: Joonas Lahtinen looks good. Reviewed-by: Andi Shyti Thanks, Andi _

[Intel-gfx] [PATCH i-g-t] lib/i915: Fix test enumeration on legacy kernels

2019-05-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Where engine discovery and context engine map are not supported we must not call the asserting gem_class_instance_to_eb_flags from the engine list initalizer. (Since not all engines can be addressed using the legacy execbuf API.) Instead extract the code into lower level __g

Re: [Intel-gfx] [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-23 Thread Daniel Vetter
On Thu, May 23, 2019 at 11:09:41AM +0300, Jani Nikula wrote: > On Wed, 22 May 2019, Ville Syrjälä wrote: > > Pushed the core/etc. bits to drm-misc-next so that other drivers > > can base their work on that. We'll need a backmerge to get the > > i915 stuff in via dinq. > > To avoid any confusion,

Re: [Intel-gfx] [PATCH i-g-t] i915: Improve static engine map for legacy

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 09:06, Chris Wilson wrote: We need to keep igt working on linus and dif, or Joonas gets very upset. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Andi Shyti Cc: Joonas Lahtinen --- lib/i915/gem_context.c | 2 +- lib/i915/gem_engine_topology.c | 15 +++---

Re: [Intel-gfx] [PATCH i-g-t] lib/i915: Fix test enumeration on legacy kernels

2019-05-23 Thread Andi Shyti
Hi Tvrtko, On Thu, May 23, 2019 at 09:39:29AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Where engine discovery and context engine map are not supported we must > not call the asserting gem_class_instance_to_eb_flags from the engine > list initalizer. (Since not all engines can be a

Re: [Intel-gfx] [PATCH i-g-t] lib/dummyload: Cleanup access to spin obj array

2019-05-23 Thread Mika Kuoppala
Chris Wilson writes: > > Reviewed-by: Chris Wilson Pushed, thanks for review. -Mika ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] i915: Improve static engine map for legacy

2019-05-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-23 09:46:08) > > On 23/05/2019 09:06, Chris Wilson wrote: > > const struct intel_execution_engine2 intel_execution_engines2[] = { > > - { "rcs0", I915_ENGINE_CLASS_RENDER, 0 }, > > - { "bcs0", I915_ENGINE_CLASS_COPY, 0 }, > > - { "vcs0", I915_ENGINE_CL

Re: [Intel-gfx] Getting "rcs0: reset request timeout" on 4.19.16

2019-05-23 Thread Marcin Owsiany
Thank you for the quick response, Chris! I still don't understand why an X server restart is not enough to make it work again? What does "intel_do_flush_locked failed: Input/output error" mean? Is it just a fact of life these days that userspace can mess up the GPU to a state where only a reboot h

Re: [Intel-gfx] [PATCH i-g-t] i915: Improve static engine map for legacy

2019-05-23 Thread Chris Wilson
Quoting Chris Wilson (2019-05-23 10:09:48) > Quoting Tvrtko Ursulin (2019-05-23 09:46:08) > > > > On 23/05/2019 09:06, Chris Wilson wrote: > > > const struct intel_execution_engine2 intel_execution_engines2[] = { > > > - { "rcs0", I915_ENGINE_CLASS_RENDER, 0 }, > > > - { "bcs0", I915_ENG

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Engine discovery query (rev11)

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: Engine discovery query (rev11) URL : https://patchwork.freedesktop.org/series/39958/ State : success == Summary == CI Bug Log - changes from CI_DRM_6120_full -> Patchwork_13068_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 07:49, Chris Wilson wrote: We rearranged the vm_destroy_ioctl to avoid taking struct_mutex, little realising that buried underneath the gen6 ppgtt release path was a struct_mutex requirement (to remove its GGTT vma). Until that struct_mutex is vanquished, take a detour in gen6_ppgt

Re: [Intel-gfx] [PATCH i-g-t] i915: Improve static engine map for legacy

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 10:09, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-23 09:46:08) On 23/05/2019 09:06, Chris Wilson wrote: const struct intel_execution_engine2 intel_execution_engines2[] = { - { "rcs0", I915_ENGINE_CLASS_RENDER, 0 }, - { "bcs0", I915_ENGINE_CLASS_COPY, 0 }, -

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-23 Thread Stephen Rothwell
Hi Maxime, On Thu, 23 May 2019 10:10:22 +0200 Maxime Ripard wrote: > > Hi Stephen, > > On Tue, May 21, 2019 at 10:51:51AM +1000, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the drm-misc tree got a conflict in: > > > > Documentation/devicetree/bindings/vendor-prefix

Re: [Intel-gfx] [PATCH i-g-t] i915: Improve static engine map for legacy

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 10:14, Chris Wilson wrote: Quoting Chris Wilson (2019-05-23 10:09:48) Quoting Tvrtko Ursulin (2019-05-23 09:46:08) On 23/05/2019 09:06, Chris Wilson wrote: const struct intel_execution_engine2 intel_execution_engines2[] = { - { "rcs0", I915_ENGINE_CLASS_RENDER, 0 }, -

[Intel-gfx] [PULL] drm-intel-fixes

2019-05-23 Thread Joonas Lahtinen
Hi Dave & Daniel, Two scheduling fixes for to oversaturated (media transcoding scenarios) and their dependencies. On GVT side a reset robustness fix and context state restoring fix + error path fix caught by static checker. Regards, Joonas PS. As you are aware, -rc1 caused an explosion on the C

Re: [Intel-gfx] [PATCH i-g-t] i915: Improve static engine map for legacy

2019-05-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-23 10:35:01) > > On 23/05/2019 10:14, Chris Wilson wrote: > > Quoting Chris Wilson (2019-05-23 10:09:48) > >> Quoting Tvrtko Ursulin (2019-05-23 09:46:08) > >>> > >>> On 23/05/2019 09:06, Chris Wilson wrote: > const struct intel_execution_engine2 intel_execu

Re: [Intel-gfx] [PATCH i-g-t] i915: Improve static engine map for legacy

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 09:06, Chris Wilson wrote: We need to keep igt working on linus and dif, or Joonas gets very upset. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Andi Shyti Cc: Joonas Lahtinen --- lib/i915/gem_context.c | 2 +- lib/i915/gem_engine_topology.c | 15 +++---

[Intel-gfx] [PATCH i-g-t] igt/gem_fence_thrash, gem_mmap_gtt: Don't let the device sleep

2019-05-23 Thread Chris Wilson
These tests are not intended to exercise runtime pm, but the device going to sleep in the middle of these tests can significantly slow them down as the GTT mmapping is torn down and must be rebuilt. This can be a major nuisance if the device autosuspends many times a second. These tests differ fro

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 10:21, Tvrtko Ursulin wrote: On 23/05/2019 07:49, Chris Wilson wrote: We rearranged the vm_destroy_ioctl to avoid taking struct_mutex, little realising that buried underneath the gen6 ppgtt release path was a struct_mutex requirement (to remove its GGTT vma). Until that struct_mu

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup

2019-05-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-23 11:01:09) > > On 23/05/2019 10:21, Tvrtko Ursulin wrote: > > > > On 23/05/2019 07:49, Chris Wilson wrote: > >> We rearranged the vm_destroy_ioctl to avoid taking struct_mutex, little > >> realising that buried underneath the gen6 ppgtt release path was a > >> st

Re: [Intel-gfx] [PATCH i-g-t] igt/gem_fence_thrash, gem_mmap_gtt: Don't let the device sleep

2019-05-23 Thread Mika Kuoppala
Chris Wilson writes: > These tests are not intended to exercise runtime pm, but the device > going to sleep in the middle of these tests can significantly slow them > down as the GTT mmapping is torn down and must be rebuilt. This can be a > major nuisance if the device autosuspends many times a

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup

2019-05-23 Thread Chris Wilson
Quoting Chris Wilson (2019-05-23 11:07:50) > Quoting Tvrtko Ursulin (2019-05-23 11:01:09) > > > > On 23/05/2019 10:21, Tvrtko Ursulin wrote: > > > > > > On 23/05/2019 07:49, Chris Wilson wrote: > > >> We rearranged the vm_destroy_ioctl to avoid taking struct_mutex, little > > >> realising that bu

Re: [Intel-gfx] [PATCH i-g-t] igt/gem_fence_thrash, gem_mmap_gtt: Don't let the device sleep

2019-05-23 Thread Chris Wilson
Quoting Mika Kuoppala (2019-05-23 11:08:43) > Chris Wilson writes: > > > These tests are not intended to exercise runtime pm, but the device > > going to sleep in the middle of these tests can significantly slow them > > down as the GTT mmapping is torn down and must be rebuilt. This can be a > >

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 11:14, Chris Wilson wrote: Quoting Chris Wilson (2019-05-23 11:07:50) Quoting Tvrtko Ursulin (2019-05-23 11:01:09) On 23/05/2019 10:21, Tvrtko Ursulin wrote: On 23/05/2019 07:49, Chris Wilson wrote: We rearranged the vm_destroy_ioctl to avoid taking struct_mutex, little reali

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 11:19, Tvrtko Ursulin wrote: On 23/05/2019 11:14, Chris Wilson wrote: Quoting Chris Wilson (2019-05-23 11:07:50) Quoting Tvrtko Ursulin (2019-05-23 11:01:09) On 23/05/2019 10:21, Tvrtko Ursulin wrote: On 23/05/2019 07:49, Chris Wilson wrote: We rearranged the vm_destroy_ioct

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup

2019-05-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-23 11:19:30) > > On 23/05/2019 11:14, Chris Wilson wrote: > > Quoting Chris Wilson (2019-05-23 11:07:50) > >> Quoting Tvrtko Ursulin (2019-05-23 11:01:09) > >>> > >>> On 23/05/2019 10:21, Tvrtko Ursulin wrote: > > On 23/05/2019 07:49, Chris Wilson wrote: >

Re: [Intel-gfx] [PATCH 5/5] drm/i915: add support for perf configuration queries

2019-05-23 Thread Dan Carpenter
Hi Lionel, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-Vulkan-performance-query-support/20190522-083115 base: git://anongit.freedesktop.org/drm-intel for-linux-next If you fix the issue, kindly add followin

Re: [Intel-gfx] [PATCH i-g-t] i915: Improve static engine map for legacy

2019-05-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-23 10:48:27) > > On 23/05/2019 09:06, Chris Wilson wrote: > > We need to keep igt working on linus and dif, or Joonas gets very upset. > > > > Signed-off-by: Chris Wilson > > Cc: Tvrtko Ursulin > > Cc: Andi Shyti > > Cc: Joonas Lahtinen > > --- > > lib/i915/g

Re: [Intel-gfx] [PATCH 5/5] drm/i915: add support for perf configuration queries

2019-05-23 Thread Lionel Landwerlin
Hi Dan, Not quite sure if you read responses to what seems like an automated message. I have a question below. Thanks, -Lionel On 23/05/2019 11:32, Dan Carpenter wrote: Hi Lionel, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Lion

Re: [Intel-gfx] [PATCH 5/5] drm/i915: add support for perf configuration queries

2019-05-23 Thread Dan Carpenter
On Thu, May 23, 2019 at 12:25:44PM +0100, Lionel Landwerlin wrote: > Hi Dan, > > Not quite sure if you read responses to what seems like an automated > message. > I have a question below. > > Thanks, > > -Lionel > > On 23/05/2019 11:32, Dan Carpenter wrote: > > Hi Lionel, > > > > Thank you for

Re: [Intel-gfx] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage

2019-05-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-23 07:37:01) > From: Tvrtko Ursulin > > Engine enumerated test names have changed so fast-feedback.testlist needs > to be updated. However listing all engines there won't scale. So instead > add new tests cases which iterate all engines internally. > > v2: > * Fi

[Intel-gfx] [PATCH 0/2] drm/i915: timeline semaphore support

2019-05-23 Thread Lionel Landwerlin
Hi all, This series implement required changes to support Vulkan timeline semaphores. Mesa's Anv driver will make use of this, unfortunately we can't disclose the userspace changes yet. Hoping we can bend the rules a bit (like for the drm-syncobj changes landed already), so that we can be complia

[Intel-gfx] [PATCH 2/2] drm/i915: add syncobj timeline support

2019-05-23 Thread Lionel Landwerlin
Introduces a new parameters to execbuf so that we can specify syncobj handles as well as timeline points. This is needed for the submission side of the Vulkan timeline semaphore (VK_KHR_timeline_semaphore extension). Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [PATCH 1/2] drm/syncobj: add an output syncobj parameter to find_fence

2019-05-23 Thread Lionel Landwerlin
We would like to get both the fence & the syncobj in i915 rather than doing 2 calls to drm_syncobj_find() & drm_syncobj_find_fence(). Signed-off-by: Lionel Landwerlin Cc: Christian Koenig Cc: David(ChunMing) Zhou Cc: Eric Anholt CC: DRI-Devel --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 +

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: remove duplicate typedef for intel_wakeref_t

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: remove duplicate typedef for intel_wakeref_t URL : https://patchwork.freedesktop.org/series/60955/ State : success == Summary == CI Bug Log - changes from CI_DRM_6121_full -> Patchwork_13069_full Summa

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add syncobj timeline support

2019-05-23 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-05-23 12:46:20) > - syncobj = drm_syncobj_find(file, fence.handle); > - if (!syncobj) { > - DRM_DEBUG("Invalid syncobj handle provided\n"); > - err = -ENOENT; > - goto err;

Re: [Intel-gfx] [PATCH 2/3] drm/i915/huc: Check HuC firmware status only once

2019-05-23 Thread Ye, Tony
> 在 2019年5月23日,上午4:14,Chris Wilson 写道: > > Quoting Michal Wajdeczko (2019-05-22 20:00:56) >> During driver load we checked that HuC firmware was verified, and once >> verified it stays verified, so there is no need to check that again. >> >> Signed-off-by: Michal Wajdeczko >> Cc: Chris Wilson

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage

2019-05-23 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Tvrtko Ursulin (2019-05-23 07:43:12) >> >> On 23/05/2019 07:37, Tvrtko Ursulin wrote: >> > From: Tvrtko Ursulin >> > >> > Engine enumerated test names have changed so fast-feedback.testlist needs >> > to be updated. However listing all engines there won't scale.

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage

2019-05-23 Thread Chris Wilson
Quoting Mika Kuoppala (2019-05-23 13:02:30) > Chris Wilson writes: > > > Quoting Tvrtko Ursulin (2019-05-23 07:43:12) > >> > >> On 23/05/2019 07:37, Tvrtko Ursulin wrote: > >> > From: Tvrtko Ursulin > >> > > >> > Engine enumerated test names have changed so fast-feedback.testlist needs > >> >

Re: [Intel-gfx] [PATCH 1/2] drm/syncobj: add an output syncobj parameter to find_fence

2019-05-23 Thread Zhou, David(ChunMing)
can you make the parameter optional? Otherwise looks good to me. -David Original Message Subject: [PATCH 1/2] drm/syncobj: add an output syncobj parameter to find_fence From: Lionel Landwerlin To: intel-gfx@lists.freedesktop.org CC: Lionel Landwerlin ,"Koenig, Christian" ,"Zhou,

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: move and rename register read ioctl function declaration

2019-05-23 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: move and rename register read ioctl function declaration URL : https://patchwork.freedesktop.org/series/60981/ State : success == Summary == CI Bug Log - changes from CI_DRM_6121_full -> Patchwork_13071_full ===

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-23 Thread Maxime Ripard
On Tue, May 21, 2019 at 10:51:51AM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm-misc tree got a conflict in: > > Documentation/devicetree/bindings/vendor-prefixes.txt > > between commit: > > 8122de54602e ("dt-bindings: Convert vendor prefixes to json-schema")

Re: [Intel-gfx] [PATCH] drm/i915: remove duplicate typedef for intel_wakeref_t

2019-05-23 Thread Jani Nikula
On Wed, 22 May 2019, Nathan Chancellor wrote: > On Wed, May 22, 2019 at 01:35:05PM +0300, Jani Nikula wrote: >> Fix the duplicate typedef for intel_wakeref_t leading to Clang build >> issues. While at it, actually make the intel_runtime_pm.h header >> self-contained, which was claimed in the commi

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-23 Thread Stephen Rothwell
Hi Maxime, On Thu, 23 May 2019 13:53:55 +0200 Maxime Ripard wrote: > > On Tue, May 21, 2019 at 10:51:51AM +1000, Stephen Rothwell wrote: > > > > Today's linux-next merge of the drm-misc tree got a conflict in: > > > > Documentation/devicetree/bindings/vendor-prefixes.txt > > > > between commit

[Intel-gfx] [PATCH] drm/i915: Tune down link train error messages due to IO failure

2019-05-23 Thread Imre Deak
An IO failure happens if the sink is unplugged. This scenario shouldn't be logged with error level, since it is not a user visible problem. Converting the corresponding error messages to be debug messages also ensures that we don't fail some CI test incorrectly that tests the unplugging while a mod

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-23 Thread Daniel Vetter
On Thu, May 23, 2019 at 3:04 PM Stephen Rothwell wrote: > > Hi Maxime, > > On Thu, 23 May 2019 13:53:55 +0200 Maxime Ripard > wrote: > > > > On Tue, May 21, 2019 at 10:51:51AM +1000, Stephen Rothwell wrote: > > > > > > Today's linux-next merge of the drm-misc tree got a conflict in: > > > > > >

Re: [Intel-gfx] [PATCH i-g-t 01/15] gem_wsim: Engine map support

2019-05-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-22 16:57:06) > From: Tvrtko Ursulin > > Support new i915 uAPI for configuring contexts with engine maps. > > Please refer to the README file for more detailed explanation. > > v2: > * Allow defining engine maps by class. > > Signed-off-by: Tvrtko Ursulin Keep

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 04/15] gem_wsim: Engine map load balance command

2019-05-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-22 16:57:09) > From: Tvrtko Ursulin > > A new workload command for enabling a load balanced context map (aka > Virtual Engine). Example usage: > > B.1 > > This turns on load balancing for context one, assuming it has already been > configured with an engine map

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 11/15] gem_wsim: Consolidate engine assignments into helpers

2019-05-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-22 16:57:16) > From: Tvrtko Ursulin > > This will allow applying the discovered engine configuration from a single > place. > > v2: > * Consolidate enum to ci conversion. > > Signed-off-by: Tvrtko Ursulin > --- Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] [PATCH 1/2] drm/syncobj: add an output syncobj parameter to find_fence

2019-05-23 Thread Lionel Landwerlin
Sure -Lionel On 23/05/2019 13:11, Zhou, David(ChunMing) wrote: can you make the parameter optional? Otherwise looks good to me. -David Original Message Subject: [PATCH 1/2] drm/syncobj: add an output syncobj parameter to find_fence From: Lionel Landwerlin To: intel-gfx@lis

Re: [Intel-gfx] [PATCH 1/2] drm/syncobj: add an output syncobj parameter to find_fence

2019-05-23 Thread Lionel Landwerlin
I should mentioned that this is going to make the find_fence() function a fair bit more complex :) On 23/05/2019 14:35, Lionel Landwerlin wrote: Sure -Lionel On 23/05/2019 13:11, Zhou, David(ChunMing) wrote: can you make the parameter optional? Otherwise looks good to me. -David O

Re: [Intel-gfx] [PATCH i-g-t 05/12] i915: Exercise creating context with shared GTT

2019-05-23 Thread Tvrtko Ursulin
On 22/05/2019 12:37, Chris Wilson wrote: v2: Test each shared context is its own timeline and allows request reordering between shared contexts. v3: Use the modern interface to use physical engines for testing single-timeline along each real engine. Signed-off-by: Chris Wilson Cc: Joonas Lahti

Re: [Intel-gfx] [PATCH i-g-t 03/12] i915/gem_ctx_create: Basic checks for constructor properties

2019-05-23 Thread Tvrtko Ursulin
On 22/05/2019 12:37, Chris Wilson wrote: Check that the extended create interface accepts setparam. Signed-off-by: Chris Wilson --- tests/i915/gem_ctx_create.c | 225 ++-- 1 file changed, 213 insertions(+), 12 deletions(-) diff --git a/tests/i915/gem_ctx_cre

[Intel-gfx] [PATCH v6 0/8] drm/fb-helper: Move modesetting code to drm_client

2019-05-23 Thread Noralf Trønnes
This moves the modesetting code from drm_fb_helper to drm_client so it can be shared by all internal clients. Changes this time: - Improve commit messages All patches have been reviewed now, thanks alot for reviewing! Noralf. Noralf Trønnes (8): drm/atomic: Move __drm_atomic_helper_disable_pl

[Intel-gfx] [PATCH v6 4/8] drm/fb-helper: Move out commit code

2019-05-23 Thread Noralf Trønnes
Move the modeset commit code to drm_client_modeset. No changes except exporting API. v2: Move to drm_client_modeset.c instead of drm_client.c Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_client_modeset.c | 287 +++ drivers/gpu/drm/drm_

[Intel-gfx] [PATCH v6 1/8] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-05-23 Thread Noralf Trønnes
Prepare for moving drm_fb_helper modesetting code to drm_client. drm_client will be linked to drm.ko, so move __drm_atomic_helper_disable_plane() and __drm_atomic_helper_set_config() out of drm_kms_helper.ko. While at it, fix two checkpatch complaints: - WARNING: Block comments use a trailing */ o

[Intel-gfx] [PATCH v6 5/8] drm/fb-helper: Remove drm_fb_helper_connector

2019-05-23 Thread Noralf Trønnes
All drivers add all their connectors so there's no need to keep around an array of available connectors. Instead we just put the useable (not writeback) connectors in a temporary array using drm_client_for_each_connector_iter() everytime we probe the outputs. Other places where it's necessary to lo

[Intel-gfx] [PATCH v6 3/8] drm/fb-helper: Prepare to move out commit code

2019-05-23 Thread Noralf Trønnes
This makes the necessary changes so the commit code can be moved out to drm_client as-is in the next patch. It's split up to ease review. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_fb_helper.c | 122 +--- 1 file changed, 81 insert

[Intel-gfx] [PATCH v6 6/8] drm/fb-helper: Prepare to move out modeset config code

2019-05-23 Thread Noralf Trønnes
This prepares the modeset code so it can be moved out as-is in the next patch. v3: Remove stray newline Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_fb_helper.c | 62 +++-- include/drm/drm_fb_helper.h

[Intel-gfx] [PATCH v6 2/8] drm/fb-helper: Remove drm_fb_helper_crtc

2019-05-23 Thread Noralf Trønnes
struct drm_fb_helper_crtc is now just a wrapper around drm_mode_set so use that directly instead and attach it as a modeset array onto drm_client_dev. drm_fb_helper will use this array to store its modesets which means it will always initialize a drm_client, but it will not register the client (cal

[Intel-gfx] [PATCH v6 8/8] drm/client: Hack: Add bootsplash example

2019-05-23 Thread Noralf Trønnes
An example to showcase the client API. TODO: - A bootsplash client needs a way to tell drm_fb_helper to stay away, otherwise it will chime in on setup and hotplug. Most DRM drivers register fbdev before calling drm_dev_register() (the generic emulation is an exception). This have to be rever

[Intel-gfx] [PATCH v6 7/8] drm/fb-helper: Move out modeset config code

2019-05-23 Thread Noralf Trønnes
No functional changes, just moving code as-is and fixing includes. Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_client_modeset.c | 707 ++- drivers/gpu/drm/drm_fb_helper.c | 692 -

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add syncobj timeline support

2019-05-23 Thread Lionel Landwerlin
On 23/05/2019 12:52, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-23 12:46:20) - syncobj = drm_syncobj_find(file, fence.handle); - if (!syncobj) { - DRM_DEBUG("Invalid syncobj handle provided\n"); - err = -ENOENT;

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 04/15] gem_wsim: Engine map load balance command

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 14:25, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-22 16:57:09) From: Tvrtko Ursulin A new workload command for enabling a load balanced context map (aka Virtual Engine). Example usage: B.1 This turns on load balancing for context one, assuming it has already been c

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add syncobj timeline support

2019-05-23 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-05-23 14:46:42) > On 23/05/2019 12:52, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-05-23 12:46:20) > >> - syncobj = drm_syncobj_find(file, fence.handle); > >> - if (!syncobj) { > >> - DRM_DEBUG("Invalid sy

Re: [Intel-gfx] [PATCH i-g-t 07/15] gem_wsim: Infinite batch support

2019-05-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-22 16:57:12) > -static void > +static unsigned int > terminate_bb(struct w_step *w, unsigned int flags) > { > const uint32_t bbe = 0xa << 23; > unsigned long mmap_start, mmap_len; > unsigned long batch_start = w->bb_sz; > + unsigned in

Re: [Intel-gfx] [PATCH i-g-t 07/15] gem_wsim: Infinite batch support

2019-05-23 Thread Chris Wilson
Quoting Chris Wilson (2019-05-23 15:05:05) > Quoting Tvrtko Ursulin (2019-05-22 16:57:12) > > -static void > > +static unsigned int > > terminate_bb(struct w_step *w, unsigned int flags) > > { > > const uint32_t bbe = 0xa << 23; > > unsigned long mmap_start, mmap_len; > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add syncobj timeline support

2019-05-23 Thread Lionel Landwerlin
On 23/05/2019 14:59, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-23 14:46:42) On 23/05/2019 12:52, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-05-23 12:46:20) - syncobj = drm_syncobj_find(file, fence.handle); - if (!syncobj) { -

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-23 Thread Stephen Rothwell
Hi Daniel, On Thu, 23 May 2019 15:11:15 +0200 Daniel Vetter wrote: > > That commit is on top of drm-misc, and somehow the .txt version has > been resurrect in drm-misc-next (so needs to be re-deleted too). My mistake, the conflict went away (due to the back merge) so my scripts assumed the file

Re: [Intel-gfx] [PATCH i-g-t 07/15] gem_wsim: Infinite batch support

2019-05-23 Thread Tvrtko Ursulin
On 23/05/2019 15:09, Chris Wilson wrote: Quoting Chris Wilson (2019-05-23 15:05:05) Quoting Tvrtko Ursulin (2019-05-22 16:57:12) -static void +static unsigned int terminate_bb(struct w_step *w, unsigned int flags) { const uint32_t bbe = 0xa << 23; unsigned long mmap_start

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup URL : https://patchwork.freedesktop.org/series/61012/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6c62c85d4558 drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup -:13:

[Intel-gfx] [PATCH] drm/i915: Keep user GGTT alive for a minimum of 250ms

2019-05-23 Thread Chris Wilson
Do not allow runtime pm autosuspend to remove userspace GGTT mmaps too quickly. For example, igt sets the autosuspend delay to 0, and so we immediately attempt to perform runtime suspend upon releasing the wakeref. Unfortunately, that involves tearing down GGTT mmaps as they require an active devic

[Intel-gfx] [PATCH] drm/i915: Keep user GGTT alive for a minimum of 250ms

2019-05-23 Thread Chris Wilson
Do not allow runtime pm autosuspend to remove userspace GGTT mmaps too quickly. For example, igt sets the autosuspend delay to 0, and so we immediately attempt to perform runtime suspend upon releasing the wakeref. Unfortunately, that involves tearing down GGTT mmaps as they require an active devic

Re: [Intel-gfx] [PATCH] drm/i915: Keep user GGTT alive for a minimum of 250ms

2019-05-23 Thread Chris Wilson
Quoting Chris Wilson (2019-05-23 15:33:54) > +static void __userfault_timeout(struct timer_list *t) > +{ > + struct drm_i915_private *i915 = > + from_timer(i915, t, mm.userfault_timer); > + > + intel_runtime_pm_put(i915, xchg(&i915->mm.userfault_wakeref, 0)); > +} > + > +s

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for GuC fixes (rev2)

2019-05-23 Thread Michal Wajdeczko
On Wed, 22 May 2019 22:53:11 +0200, Patchwork wrote: == Series Details == Series: GuC fixes (rev2) URL : https://patchwork.freedesktop.org/series/60795/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6123 -> Patchwork_13075

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup URL : https://patchwork.freedesktop.org/series/61012/ State : success == Summary == CI Bug Log - changes from CI_DRM_6132 -> Patchwork_13076 Summa

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header

2019-05-23 Thread Patchwork
== Series Details == Series: series starting with [CI,01/15] drm/i915: Split GEM object type definition to its own header URL : https://patchwork.freedesktop.org/series/60990/ State : success == Summary == CI Bug Log - changes from CI_DRM_6121_full -> Patchwork_13072_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: timeline semaphore support

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: timeline semaphore support URL : https://patchwork.freedesktop.org/series/61032/ State : warning == Summary == $ dim checkpatch origin/drm-tip 72fcbc639236 drm/syncobj: add an output syncobj parameter to find_fence a888c5f147aa drm/i915: add syncobj timel

[Intel-gfx] [PULL] drm-misc-next

2019-05-23 Thread Maarten Lankhorst
Hi Daniel and Dave, We keep adding support for panels at a high rate, is it still worth listing them individually under cross subsystem changes? First pull req for v5.3 here, enjoy! As I was writing this mail, I missed a fix in mtk_hdmi_hw_send_info_frame for the unhandled HDR case in switch, h

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915: remove unused IO_TLB_SEGPAGES which should be defined by swiotlb

2019-05-23 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915: remove unused IO_TLB_SEGPAGES which should be defined by swiotlb URL : https://patchwork.freedesktop.org/series/60998/ State : success == Summary == CI Bug Log - changes from CI_DRM_6122_full -> Patchwork_13073_full ===

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-23 Thread Michal Wajdeczko
On Wed, 22 May 2019 22:06:53 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2019-05-22 20:32:02) Knowing that GuC will be reset soon, we may stop all communication immediately without doing graceful cleanup as it is not needed. The difference between stop and disable is that it avoid

Re: [Intel-gfx] [PULL] drm-misc-next

2019-05-23 Thread Sean Paul
On Thu, May 23, 2019 at 05:47:04PM +0200, Maarten Lankhorst wrote: > Hi Daniel and Dave, > > We keep adding support for panels at a high rate, is it still worth listing > them individually under cross subsystem changes? > > First pull req for v5.3 here, enjoy! > As I was writing this mail, I mis

Re: [Intel-gfx] [PULL] drm-misc-next

2019-05-23 Thread Daniel Vetter
On Thu, May 23, 2019 at 5:53 PM Sean Paul wrote: > > On Thu, May 23, 2019 at 05:47:04PM +0200, Maarten Lankhorst wrote: > > Hi Daniel and Dave, > > > > We keep adding support for panels at a high rate, is it still worth listing > > them individually under cross subsystem changes? > > > > First pu

Re: [Intel-gfx] [PULL] drm-misc-next

2019-05-23 Thread Daniel Vetter
On Thu, May 23, 2019 at 5:55 PM Daniel Vetter wrote: > > On Thu, May 23, 2019 at 5:53 PM Sean Paul wrote: > > > > On Thu, May 23, 2019 at 05:47:04PM +0200, Maarten Lankhorst wrote: > > > Hi Daniel and Dave, > > > > > > We keep adding support for panels at a high rate, is it still worth > > > lis

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: HuC updates

2019-05-23 Thread Patchwork
== Series Details == Series: drm/i915: HuC updates URL : https://patchwork.freedesktop.org/series/61001/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6122_full -> Patchwork_13074_full Summary --- **FAILURE** Seri

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-23 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-05-23 16:53:27) > On Wed, 22 May 2019 22:06:53 +0200, Chris Wilson > wrote: > > > Quoting Michal Wajdeczko (2019-05-22 20:32:02) > >> Knowing that GuC will be reset soon, we may stop all communication > >> immediately without doing graceful cleanup as it is not ne

  1   2   >