== Series Details ==
Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev4)
URL : https://patchwork.freedesktop.org/series/56606/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
08011e2e164e drm/i915: Add P010, P012, P016 plane control definitions
f9b305df8580 drm/
== Series Details ==
Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev4)
URL : https://patchwork.freedesktop.org/series/56606/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Add P010, P012, P016 plane control definitions
Oka
== Series Details ==
Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev4)
URL : https://patchwork.freedesktop.org/series/56606/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5693 -> Patchwork_12355
Summary
On 01/03/2019 18:57, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-03-01 15:39:13)
On 01/03/2019 14:03, Chris Wilson wrote:
+int i915_user_extensions(struct i915_user_extension __user *ext,
+ const i915_user_extension_fn *tbl,
+ unsigned long count
On 01/03/2019 19:03, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-03-01 16:12:33)
On 01/03/2019 14:03, Chris Wilson wrote:
+ counter = 0;
+ err = context_barrier_task(ctx, 0, mock_barrier_task, &counter);
+ if (err) {
+ pr_err("Failed at line %d, err=%d\n", __LINE_
On 01/03/2019 19:10, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-03-01 16:36:45)
On 01/03/2019 14:03, Chris Wilson wrote:
It can be useful to have a single ioctl to create a context with all
the initial parameters instead of a series of create + setparam + setparam
ioctls. This extension
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/selftests/test-drm_mm.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/d
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
drivers/gpu/drm/i915/i915_gem_fence_reg.c | 3 +--
drivers/gpu/d
Quoting Tvrtko Ursulin (2019-03-04 08:54:10)
>
> On 01/03/2019 18:57, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2019-03-01 15:39:13)
> >>
> >> On 01/03/2019 14:03, Chris Wilson wrote:
> >>> +int i915_user_extensions(struct i915_user_extension __user *ext,
> >>> + const i
== Series Details ==
Series: series starting with [v1,1/2] drm/selftests/mm: Switch to
bitmap_zalloc()
URL : https://patchwork.freedesktop.org/series/57506/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M] driver
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
drivers/gpu/drm/i915/i915_gem_fence_reg.c | 3 +--
drivers/gpu/d
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/selftests/test-drm_mm.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/d
== Series Details ==
Series: series starting with [v2,1/2] drm/selftests/mm: Switch to
bitmap_zalloc()
URL : https://patchwork.freedesktop.org/series/57507/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/selftests/mm: Switch to bitmap_zalloc()
-./
On 04/03/2019 09:04, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-03-04 08:54:10)
On 01/03/2019 18:57, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-03-01 15:39:13)
On 01/03/2019 14:03, Chris Wilson wrote:
+int i915_user_extensions(struct i915_user_extension __user *ext,
+
Quoting Andy Shevchenko (2019-03-04 09:29:08)
> Switch to bitmap_zalloc() to show clearly what we are allocating.
> Besides that it returns pointer of bitmap type instead of opaque void *.
Which is confusing; since we explicitly want unsigned longs, not some
amorphous bitmap type.
> Signed-off-by
Quoting Andy Shevchenko (2019-03-04 09:29:07)
> Switch to bitmap_zalloc() to show clearly what we are allocating.
> Besides that it returns pointer of bitmap type instead of opaque void *.
>
> Signed-off-by: Andy Shevchenko
Reviewed-by: Chris Wilson
-Chris
___
On 04/03/2019 09:35, Tvrtko Ursulin wrote:
On 04/03/2019 09:04, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-03-04 08:54:10)
On 01/03/2019 18:57, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-03-01 15:39:13)
On 01/03/2019 14:03, Chris Wilson wrote:
+int i915_user_extensions(struct
On Mon, Mar 04, 2019 at 09:41:34AM +, Chris Wilson wrote:
> Quoting Andy Shevchenko (2019-03-04 09:29:08)
> > Switch to bitmap_zalloc() to show clearly what we are allocating.
> > Besides that it returns pointer of bitmap type instead of opaque void *.
>
> Which is confusing; since we explicit
Quoting Andy Shevchenko (2019-03-04 09:54:46)
> On Mon, Mar 04, 2019 at 09:41:34AM +, Chris Wilson wrote:
> > Quoting Andy Shevchenko (2019-03-04 09:29:08)
> > > Switch to bitmap_zalloc() to show clearly what we are allocating.
> > > Besides that it returns pointer of bitmap type instead of opa
== Series Details ==
Series: series starting with [v2,1/2] drm/selftests/mm: Switch to
bitmap_zalloc()
URL : https://patchwork.freedesktop.org/series/57507/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5693 -> Patchwork_12357
=
On Fri, 01 Mar 2019, José Roberto de Souza wrote:
> i915_load_modeset_init() sounds horrible also lets rename it so
> the future cleanup function of it can be easially recognized.
We load the driver, but init modeset. The name implies modeset init at
driver load.
The modeset load/unload sounds a
/commits/Andy-Shevchenko/drm-selftests-mm-Switch-to-bitmap_zalloc/20190304-183335
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: nds32-allyesconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 6.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp
/commits/Andy-Shevchenko/drm-selftests-mm-Switch-to-bitmap_zalloc/20190304-183335
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp
We may race the interrupt signaling with retirement, in which case the
order in which we acquire the reference inside the interrupt is vital to
provide the correct barrier against the request being freed in
retirement, i.e. we need to acquire our reference before marking the
breadcrumb as cancelled
Op 01-03-2019 om 11:01 schreef Gwan-gyeong Mun:
> The hotplug detection routine of drm_helper_hpd_irq_event() can detect
> changing of status of connector, but it can not detect changing of edid.
>
> Following scenario requires detection of changing of edid.
>
> 1) plug display device to a connect
== Series Details ==
Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev4)
URL : https://patchwork.freedesktop.org/series/56606/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5693_full -> Patchwork_12355_full
This patch series is for enabling P0xx, Y2xx and Y4xx pixel formats for
intel's i915 driver.
In this patch series, Juha Pekka's patch series Gen10+ P0xx formats
https://patchwork.freedesktop.org/series/56053/ is combined with Swati's
https://patchwork.freedesktop.org/series/55035/ for Gen11+ pixel
From: Juha-Pekka Heikkila
Add needed plane control flag definitions for P010, P012 and
P016 formats.
Signed-off-by: Juha-Pekka Heikkila
Signed-off-by: Swati Sharma
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/driver
Added needed plane control flag definitions for Y2xx and Y4xx (10, 12 and
16 bits)
Signed-off-by: Swati Sharma
Signed-off-by: Vidya Srinivas
Reviewed-by: Juha-Pekka Heikkila
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/i915_reg.h | 6 ++
1 file changed, 6 insertions(+)
diff --
From: Juha-Pekka Heikkila
Preparations for enabling P010, P012 and P016 formats. These
formats will extend NV12 for larger bit depths.
Signed-off-by: Juha-Pekka Heikkila
Signed-off-by: Swati Sharma
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_atomic_plane.c | 2 +-
drivers/
The following pixel formats are packed format that follows 4:2:2
chroma sampling. For memory represenation each component is
allocated 16 bits each. Thus each pixel occupies 32bit.
Y210: For each component, valid data occupies MSB 10 bits.
LSB 6 bits are filled with zeroes.
Y212: For e
Signed-off-by: Swati Sharma
Signed-off-by: Vidya Srinivas
Reviewed-by: Juha-Pekka Heikkila
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 30 ++
drivers/gpu/drm/i915/intel_sprite.c | 60 +++-
2 files changed, 89 insert
From: Juha-Pekka Heikkila
Enabling of P010, P012 and P016 formats. These formats will
extend NV12 for larger bit depths.
Signed-off-by: Juha-Pekka Heikkila
Signed-off-by: Swati Sharma
Reviewed-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_sprite.c | 28 ++--
1
== Series Details ==
Series: drm/i915: Acquire breadcrumb ref before cancelling
URL : https://patchwork.freedesktop.org/series/57512/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
87cc082b1759 drm/i915: Acquire breadcrumb ref before cancelling
-:14: WARNING:COMMIT_LOG_LONG_LINE
== Series Details ==
Series: drm/i915: Acquire breadcrumb ref before cancelling
URL : https://patchwork.freedesktop.org/series/57512/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5693 -> Patchwork_12358
Summary
---
== Series Details ==
Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev5)
URL : https://patchwork.freedesktop.org/series/56606/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
dc7b63022f48 drm/i915: Add P010, P012, P016 plane control definitions
f3c20c560ac9 drm/
== Series Details ==
Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev5)
URL : https://patchwork.freedesktop.org/series/56606/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Add P010, P012, P016 plane control definitions
Oka
Looks ok.
On Fri, 2019-02-22 at 15:02 -0800, Lucas De Marchi wrote:
> Instead of keeping track of the number of transcoders, loop through
> all
> the interesting ones and check if there is a correspondent offset.
>
> Cc: Rodrigo Vivi
Reviewed-by: Mika Kahola
> Signed-off-by: Lucas De Marchi
On Fri, 2019-03-01 at 15:56 -0800, Lucas De Marchi wrote:
> On Mon, Feb 25, 2019 at 06:17:13AM -0800, Mika Kahola wrote:
> > Looks allright.
> >
> > On Fri, 2019-02-22 at 15:02 -0800, Lucas De Marchi wrote:
> > > Define a HAS_TRANSCODER_EDP() macro that checks if we have
> > > defined an
> > > off
== Series Details ==
Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev5)
URL : https://patchwork.freedesktop.org/series/56606/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5693 -> Patchwork_12359
Summary
On Fri, Mar 01, 2019 at 01:56:24PM +0100, Maarten Lankhorst wrote:
> Convert tegra to using __drm_atomic_helper_crtc_reset(), instead of
> writing its own version. Instead of open coding destroy_state(),
> call it directly for freeing the old state.
>
> Signed-off-by: Maarten Lankhorst
> Cc: Thie
From: Ville Syrjälä
The plane used to scan out NV12 luma on ICL is logically
off but actually on. Fix the state checker to account for this.
Cc: Imre Deak
Cc: Maarten Lankhorst
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109457
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915
== Series Details ==
Series: series starting with [v2,1/2] drm/selftests/mm: Switch to
bitmap_zalloc()
URL : https://patchwork.freedesktop.org/series/57507/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5693_full -> Patchwork_12357_full
===
From: Ville Syrjälä
Let's just always enable the DVO 2x clock on i830. This way we don't
have to track if DVO is being used or not. The spec does suggest we
should disable the clock when it isn't needed, but this does appear
to work just fine.
This removes another crtc->config usage.
Signed-off
Op 01-03-2019 om 23:47 schreef Eric Anholt:
> Maarten Lankhorst writes:
>
>> Convert vc4 to using __drm_atomic_helper_crtc_reset(), instead of
>> writing its own version. Instead of open coding destroy_state(),
>> call it directly for freeing the old state.
>>
>> Signed-off-by: Maarten Lankhorst
== Series Details ==
Series: drm/i915: Fix the state checker for ICL Y planes
URL : https://patchwork.freedesktop.org/series/57518/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5694 -> Patchwork_12360
Summary
---
**
From: Tvrtko Ursulin
Fishing for fails...
/*
mmap(2) mandates size is page aligned so check this in our wrappers.
*/
Signed-off-by: Tvrtko Ursulin
---
lib/i915/gem_mman.c | 4
lib/igt_fb.c| 14 --
tests/kms_ccs.c | 14 --
tests/kms_psr.c | 8
== Series Details ==
Series: drm/i915: Acquire breadcrumb ref before cancelling
URL : https://patchwork.freedesktop.org/series/57512/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5693_full -> Patchwork_12358_full
Summary
-
== Series Details ==
Series: drm/i915: Simplify i830 DVO 2x clock handling
URL : https://patchwork.freedesktop.org/series/57520/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5694 -> Patchwork_12361
Summary
---
**SUC
Den 25.02.2019 15.42, skrev Noralf Trønnes:
> This patchset is part of the effort to remove tinydrm.ko. It removes
> struct tinydrm_device and tinydrm.h.
>
> Only one change in this version and that is expanding the driver
> example.
>
> The drm_dev_unplug() dependency series has been applied t
Quoting Tvrtko Ursulin (2019-03-04 14:11:31)
> From: Tvrtko Ursulin
>
> Fishing for fails...
>
> /*
> mmap(2) mandates size is page aligned so check this in our wrappers.
> */
>
> Signed-off-by: Tvrtko Ursulin
> ---
> lib/i915/gem_mman.c | 4
> lib/igt_fb.c| 14 --
>
On Mon, Mar 04, 2019 at 03:12:17PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The plane used to scan out NV12 luma on ICL is logically
> off but actually on. Fix the state checker to account for this.
>
> Cc: Imre Deak
> Cc: Maarten Lankhorst
> Bugzilla: https://bugs.freedesktop.org
Op 04-03-2019 om 15:45 schreef Imre Deak:
> On Mon, Mar 04, 2019 at 03:12:17PM +0200, Ville Syrjala wrote:
>> From: Ville Syrjälä
>>
>> The plane used to scan out NV12 luma on ICL is logically
>> off but actually on. Fix the state checker to account for this.
>>
>> Cc: Imre Deak
>> Cc: Maarten La
On Mon, Mar 04, 2019 at 04:45:28PM +0200, Imre Deak wrote:
> On Mon, Mar 04, 2019 at 03:12:17PM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > The plane used to scan out NV12 luma on ICL is logically
> > off but actually on. Fix the state checker to account for this.
> >
> > Cc: Imr
Hi Hans,
On Thu, Feb 28, 2019 at 05:54:21PM +0100, Hans de Goede wrote:
> Hi Heikki,
>
> On 28-02-19 15:47, Heikki Krogerus wrote:
> > Hi Hans,
> >
> > On Thu, Feb 28, 2019 at 12:24:25PM +0100, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 28-02-19 10:15, Heikki Krogerus wrote:
>
>
>
> > > >
The last few weeks, I have been dive into the page flip and vblank with
the goal to learn how the user space interact with DRM; because of this,
I am studying the kms_flip code. As a result, I noticed a bunch of
cleanups that could be useful for improving the overall quality of
kms_flip. This patch
This commit removes the code related to TEST_RPM test because the
kms_flip never sets this flags, i.e., TEST_RPM is not used. Take a look
at commit 07a3fccf to see why this flag is never set.
Signed-off-by: Rodrigo Siqueira
---
tests/kms_flip.c | 15 ---
1 file changed, 15 deletions(
This commit removes the code related to TEST_TS_CONT test because the
kms_flip never sets this flags, i.e., TEST_TS_CONT is not used. Take a
look at commit 07a3fccf to see why this flag is never set.
Signed-off-by: Rodrigo Siqueira
---
tests/kms_flip.c | 16
1 file changed, 16 d
In the kms_flip tests has an igt_fixture that allocates memory for i915
driver with “drm_intel_bufmgr_gem_init()”, which produces the following
warning:
IGT-Version: 1.23-g8d81c2c2 (x86_64) (Linux: 5.0.0-rc7-VKMS-RULES+ x86_64)
Using monotonic timestamps
DRM_IOCTL_I915_GEM_APERTURE failed: Inva
In the function wait_for_events() has a double check in the select()
function return as described below:
igt_assert_f(ret >= 0,
"select error (errno %i)\n", errno);
igt_assert_f(ret > 0,
"select timed out or error (ret %d)\n", ret);
Note that the second assert condition will n
The function run_test_on_crtc_set() expects a parameter named crtc_count
which slight changes the behavior of the test. If this crtc_count is
‘1’, the test will run in a single CRTC; otherwise, it will run in two
different CRTC. However, this function uses hardcoded literal 1 and 2
for each case. T
This patch removes the duplicate code inside the function set_mode().
Signed-off-by: Rodrigo Siqueira
---
tests/kms_flip.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 42ae3ebc..de3ab600 100755
--- a/te
The function fb_is_bound() mix integer value with booleans for handling
the return value. This commit standardizes the return value of
fb_is_bound() for using only booleans.
Signed-off-by: Rodrigo Siqueira
---
tests/kms_flip.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --gi
== Series Details ==
Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev5)
URL : https://patchwork.freedesktop.org/series/56606/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5693_full -> Patchwork_12359_full
Quoting Ville Syrjala (2019-03-04 13:41:13)
> From: Ville Syrjälä
>
> Let's just always enable the DVO 2x clock on i830. This way we don't
> have to track if DVO is being used or not. The spec does suggest we
> should disable the clock when it isn't needed, but this does appear
> to work just fin
On Mon, Mar 04, 2019 at 01:00:40PM +0200, Jani Nikula wrote:
On Fri, 01 Mar 2019, José Roberto de Souza wrote:
i915_load_modeset_init() sounds horrible also lets rename it so
the future cleanup function of it can be easially recognized.
We load the driver, but init modeset. The name implies m
On Mon, 25 Feb 2019, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Life will be easier later if we have the ranks stored
> as a bare number.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/i915_drv.c | 92 +++--
> drivers/gpu/drm/i915/i915_drv.h | 11 +
On Mon, Mar 04, 2019 at 03:52:30PM +, Chris Wilson wrote:
> Quoting Ville Syrjala (2019-03-04 13:41:13)
> > From: Ville Syrjälä
> >
> > Let's just always enable the DVO 2x clock on i830. This way we don't
> > have to track if DVO is being used or not. The spec does suggest we
> > should disab
On 04/03/2019 11:41, Chris Wilson wrote:
We may race the interrupt signaling with retirement, in which case the
order in which we acquire the reference inside the interrupt is vital to
provide the correct barrier against the request being freed in
retirement, i.e. we need to acquire our referenc
On Mon, 25 Feb 2019, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Make the code less repetitive by extracting a few small helpers.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/i915_drv.c | 68 +
> 1 file changed, 43 insertions(+), 25 deletions(
Quoting Tvrtko Ursulin (2019-03-04 16:26:56)
>
> On 04/03/2019 11:41, Chris Wilson wrote:
> > We may race the interrupt signaling with retirement, in which case the
> > order in which we acquire the reference inside the interrupt is vital to
> > provide the correct barrier against the request bein
On Mon, Mar 04, 2019 at 06:17:50PM +0200, Jani Nikula wrote:
> On Mon, 25 Feb 2019, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Life will be easier later if we have the ranks stored
> > as a bare number.
> >
> > Signed-off-by: Ville Syrjälä
> > ---
> > drivers/gpu/drm/i915/i915_drv.c |
On Fri, Mar 01, 2019 at 04:33:49PM -0800, José Roberto de Souza wrote:
> With fastboot enabled in gen9+ it broke the HDMI reset as just
> setting mode_changed to true causes a fastset and here we want a full
> modeset that will disable and then enable the encoder of this HDMI
> link actually, so se
On Mon, Mar 04, 2019 at 06:32:25PM +0200, Jani Nikula wrote:
> On Mon, 25 Feb 2019, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Make the code less repetitive by extracting a few small helpers.
> >
> > Signed-off-by: Ville Syrjälä
> > ---
> > drivers/gpu/drm/i915/i915_drv.c | 68 +++
On Fri, Mar 01, 2019 at 04:49:31PM -0800, José Roberto de Souza wrote:
> Moving VLV/CHV/BYT czclk to intel_pm as it is a core clock used as
> base by several other GPU blocks including GT.
>
> BSpec: 14370
>
> Cc: Lucas De Marchi
> Cc: Jani Nikula
> Signed-off-by: José Roberto de Souza
> ---
>
On Mon, Mar 04, 2019 at 06:57:15PM +0200, Ville Syrjälä wrote:
> On Fri, Mar 01, 2019 at 04:49:31PM -0800, José Roberto de Souza wrote:
> > Moving VLV/CHV/BYT czclk to intel_pm as it is a core clock used as
> > base by several other GPU blocks including GT.
> >
> > BSpec: 14370
> >
> > Cc: Lucas
On Fri, Mar 01, 2019 at 04:49:34PM -0800, José Roberto de Souza wrote:
> The initialization of those componentes is required by the GEM/GT not
> only display so lets move then to a more the appropriate place.
>
> Cc: Lucas De Marchi
> Cc: Jani Nikula
> Signed-off-by: José Roberto de Souza
> ---
== Series Details ==
Series: drm/i915: Fix the state checker for ICL Y planes
URL : https://patchwork.freedesktop.org/series/57518/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5694_full -> Patchwork_12360_full
Summary
---
On Tue, 26 Feb 2019, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Pass the dimm struct to skl_is_16gb_dimm() rather than passing each
> value separately. And let's replace the hardcoded set of values with
> some simple arithmetic.
>
> Also fix the byte vs. bit inconsistency in the debug message
On Tue, 26 Feb 2019, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Polish the bxt DIMM parsing by extracting a few small helpers.
>
> v2: Use struct dram_dimm_info
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_drv.c | 93 ++--
== Series Details ==
Series: drm/i915: Simplify i830 DVO 2x clock handling
URL : https://patchwork.freedesktop.org/series/57520/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5694_full -> Patchwork_12361_full
Summary
--
On Fri, Mar 01, 2019 at 05:34:51PM -0800, José Roberto de Souza wrote:
> If has_psr is set it means that CRTC has a EDP panel attached so it
> can be dropped, also has_psr is better than check for EDP output
> alone as it will avoid set mode_changed when PSR is not supported in
> panel or with curr
On Fri, 2019-03-01 at 17:34 -0800, José Roberto de Souza wrote:
> Increase the idle frames to activate PSR1 to avoid CRC timeouts, as
> soon as pipe CRC is enabled it will avoid PSR1 to activate but if
> PSR1 is activate before that, hardware goes to lower power states
> that inhibits CRC calculati
On Fri, Mar 01, 2019 at 05:34:52PM -0800, José Roberto de Souza wrote:
> Other features like PSR2 also needs to be disabled while getting CRC
> so lets rename ips_force_disable to crc_enabled, drop all this checks
> for pipe A and HSW and BDW and make it generic and
> hsw_compute_ips_config() will
On Fri, Mar 01, 2019 at 05:34:53PM -0800, José Roberto de Souza wrote:
> When PSR2 is active aka after the number of frames programmed in
> PSR2_CTL 'Frames Before SU Entry' hardware stops to generate CRC
> interruptions causing IGT tests to fail due timeout.
>
> This same behavior don't happen wi
On Mon, 2019-03-04 at 10:31 -0800, Dhinakaran Pandiyan wrote:
> On Fri, 2019-03-01 at 17:34 -0800, José Roberto de Souza wrote:
> > Increase the idle frames to activate PSR1 to avoid CRC timeouts, as
> > soon as pipe CRC is enabled it will avoid PSR1 to activate but if
> > PSR1 is activate before t
On Fri, Mar 01, 2019 at 05:34:54PM -0800, José Roberto de Souza wrote:
> All of this checks are redudant and can be removed as the if bellow
> already takes care when there is no changes in the state.
is it just redundant or does it really change the behaviour for PSR2
as needed?
code seems right
On Fri, Mar 01, 2019 at 05:34:56PM -0800, José Roberto de Souza wrote:
> The support for PSR2 was polished, IGT tests for PSR2 was added and
> it was tested performing regular user workloads like browsing,
> editing documents and compiling Linux, so it is time to enable it by
> default and enjoy ev
On Mon, 2019-03-04 at 10:42 -0800, Rodrigo Vivi wrote:
> On Fri, Mar 01, 2019 at 05:34:54PM -0800, José Roberto de Souza
> wrote:
> > All of this checks are redudant and can be removed as the if bellow
> > already takes care when there is no changes in the state.
>
> is it just redundant or does i
On Tue, 26 Feb 2019, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The BXT DUNIT register tells us the size of each DRAM device
> in Gb. We want to report the size of the whole DIMM in GB, so
> that it matches how we report it for non-LP platforms.
>
> v2: Deobfuscate the math (Chris)
>
> Signed
On Mon, 2019-03-04 at 10:40 -0800, Souza, Jose wrote:
> On Mon, 2019-03-04 at 10:31 -0800, Dhinakaran Pandiyan wrote:
> > On Fri, 2019-03-01 at 17:34 -0800, José Roberto de Souza wrote:
> > > Increase the idle frames to activate PSR1 to avoid CRC timeouts,
> > > as
> > > soon as pipe CRC is enabled
On Mon, 25 Feb 2019, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Reduce the code duplication a bit by sharing the same
> code for parsing both DIMMs on a channel.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/i915_drv.c | 44 ++---
> 1 file changed
On Fri, Mar 01, 2019 at 01:56:20PM +0100, Maarten Lankhorst wrote:
> Convert msm to using __drm_atomic_helper_crtc_reset(), instead of
> writing its own version. Instead of open coding
> destroy_state(), call it directly for freeing the old state.
>
> Signed-off-by: Maarten Lankhorst
> Cc: Rob Cl
On Fri, Mar 01, 2019 at 05:14:04PM -0800, Lucas De Marchi wrote:
> According to the spec PP_SEQUENCE_STATE_ON_S1_1 is the correct name, so
> just rename it.
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> 1 file changed, 1 insert
On Fri, Mar 01, 2019 at 05:14:05PM -0800, Lucas De Marchi wrote:
> This register was placed in the middle of the PP_STATUS definition. Move
> it down together with PP_CONTROL and fix the aligment of the bit
> definition (as per documentation it should be 2 spaces instead of 1).
>
> Signed-off-by:
On Mon, 25 Feb 2019, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Decouple intel_is_dram_symmetric() from the raw register values
> by comparing just the dram_channel_info structs.
The idea is sound.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/i915_drv.c | 28 -
On Mon, 25 Feb 2019, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Rename the dimm info structs for clarity.
Reviewed-by: Jani Nikula
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/i915_drv.c | 18 +-
> drivers/gpu/drm/i915/i915_drv.h | 2 +-
> 2 files chang
On Mon, 25 Feb 2019, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Remove the pointless zero initialization of bunch of things
> (the thing is kzalloc()ed).
>
> Also throw out the mostly useless on-stack string. I think
> it'll be clear enough from the logs that 0 means unknown.
Yeah. Alternati
On Mon, 2019-03-04 at 10:54 -0800, Dhinakaran Pandiyan wrote:
> On Mon, 2019-03-04 at 10:42 -0800, Rodrigo Vivi wrote:
> > On Fri, Mar 01, 2019 at 05:34:54PM -0800, José Roberto de Souza
> > wrote:
> > > All of this checks are redudant and can be removed as the if
> > > bellow
> > > already takes c
On Mon, 2019-03-04 at 11:00 -0800, Dhinakaran Pandiyan wrote:
> On Mon, 2019-03-04 at 10:40 -0800, Souza, Jose wrote:
> > On Mon, 2019-03-04 at 10:31 -0800, Dhinakaran Pandiyan wrote:
> > > On Fri, 2019-03-01 at 17:34 -0800, José Roberto de Souza wrote:
> > > > Increase the idle frames to activate
1 - 100 of 128 matches
Mail list logo
