[Intel-gfx] [PATCH v7 17/39] drm/i915: Implement the HDCP2.2 support for DP

2018-09-27 Thread Ramalingam C
Implements the DP adaptation specific HDCP2.2 functions. These functions perform the DPCD read and write for communicating the HDCP2.2 auth message back and forth. v2: wait for cp_irq is merged with this patch. Rebased. v3: wait_queue is used for wait for cp_irq [Chris Wilson] v4: Style fix

[Intel-gfx] [PATCH v7 15/39] drm/i915: hdcp_check_link only on CP_IRQ

2018-09-27 Thread Ramalingam C
HDCP check link is invoked only on CP_IRQ detection, instead of all short pulses. v3: No Changes. v4: Added sean in cc and collected the reviewed-by received. v5: No Change. v6: No Change. v7: No Change. Signed-off-by: Ramalingam C cc: Sean Paul Reviewed-by: Uma Shankar Reviewed-by:

[Intel-gfx] [PATCH v7 18/39] drm/i915: Implement the HDCP2.2 support for HDMI

2018-09-27 Thread Ramalingam C
Implements the HDMI adaptation specific HDCP2.2 operations. Basically these are DDC read and write for authenticating through HDCP2.2 messages. v2: Rebased. v3: No Changes. v4: No more special handling of Gmbus burst read for AKE_SEND_CERT. Style fixed with few naming. [Uma] %s/PARING/P

[Intel-gfx] [PATCH v7 16/39] drm/i915: Check HDCP 1.4 and 2.2 link on CP_IRQ

2018-09-27 Thread Ramalingam C
On DP HDCP1.4 and 2.2, when CP_IRQ is received, start the link integrity check for the HDCP version that is enabled. v2: Rebased. Function name is changed. v3: No Changes. v4: No Changes. v5: No Changes. v6: %s/_in_force/_in_use [Sean Paul] v7: Rebased. Signed-off-by: Ramalingam C cc

[Intel-gfx] [RFC 07/10] drm/i915/gvt: GVTg read_shared_page implementation

2018-09-27 Thread Xiaolin Zhang
GVTg implemented the read_shared_page functionality based on hypervisor_read_gpa(). the shared_page_gpa was passed from guest driver through PVINFO shared_page_gpa register. Signed-off-by: Xiaolin Zhang --- drivers/gpu/drm/i915/gvt/gvt.h | 4 +++- drivers/gpu/drm/i915/gvt/handlers.c | 5

[Intel-gfx] [RFC 05/10] drm/i915/gvt: ppgtt update pvmmio optimization

2018-09-27 Thread Xiaolin Zhang
This patch extends g2v notification to notify host GVT-g of ppgtt update from guest, including alloc_4lvl, clear_4lv4 and insert_4lvl. It uses shared page to pass the additional params. This patch also add one new pvmmio level to control ppgtt update. Use PVMMIO_PPGTT_UPDATE to control this level

[Intel-gfx] [PATCH v7 19/39] drm/i915: Add HDCP2.2 support for DP connectors

2018-09-27 Thread Ramalingam C
On DP connector init, intel_hdcp_init is passed with a flag for hdcp2.2 support based on the platform capability. v2: Rebased. v3: No Changes. v4: Collected the reviewed-by received. v5: No change. v6: No change. v7: No change. Signed-off-by: Ramalingam C Reviewed-by: Uma Shankar --

[Intel-gfx] [RFC 04/10] drm/i915/gvt: master irq pvmmio optimization

2018-09-27 Thread Xiaolin Zhang
Master irq register is accessed twice every irq handling, then trapped to SOS very frequently. Optimize it by moving master irq register to share page, writing don't need be trapped. When need enable irq to let SOS inject irq timely, use another pvmmio register to achieve this purpose. So avoid on

[Intel-gfx] [RFC 03/10] drm/i915/gvt: context submission pvmmio optimization

2018-09-27 Thread Xiaolin Zhang
It is performance optimization to reduce mmio trap numbers from 4 to 1 durning ELSP porting writing (context submission). When context subission, to cache elsp_data[4] values in the shared page, the last elsp_data[0] port writing will be trapped to gvt for real context submission. Use PVMMIO_ELSP

[Intel-gfx] [RFC 06/10] drm/i915/gvt: GVTg handle enable_pvmmio PVINFO register

2018-09-27 Thread Xiaolin Zhang
implement enable_pvmmio PVINFO register handler in GVTg to control different level pvmmio optimization within guest. Signed-off-by: Xiaolin Zhang --- drivers/gpu/drm/i915/gvt/handlers.c | 10 ++ drivers/gpu/drm/i915/gvt/vgpu.c | 6 ++ 2 files changed, 16 insertions(+) diff --gi

[Intel-gfx] [PATCH v7 21/39] mei: bus: whitelist hdcp client

2018-09-27 Thread Ramalingam C
From: Tomas Winkler Whitelist HDCP client for in kernel drm use v2: Rebased. v3: No changes. v4: No changes. v5: No changes. v6: No changes v7: No changes Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 16 1 file changed, 16 insertions(+) diff --

[Intel-gfx] [PATCH v7 25/39] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2018-09-27 Thread Ramalingam C
Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends to ME FW. On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2 AKE_Init message. v2: Rebased. v3: cldev is add as a se

[Intel-gfx] [PATCH v7 24/39] misc/mei/hdcp: Define ME FW interface for HDCP2.2

2018-09-27 Thread Ramalingam C
Defines the HDCP specific ME FW interfaces such as Request CMDs, payload structure for CMDs and their response status codes. This patch defines payload size(Excluding the Header)for each WIRED HDCP2.2 CMDs. v2: Rebased. v3: Extra comments are removed. v4: %s/\/\*\*/\/\* v5: Extra lines ar

[Intel-gfx] [PATCH v7 23/39] misc/mei/hdcp: Client driver for HDCP application

2018-09-27 Thread Ramalingam C
ME FW is contributes a vital role in HDCP2.2 authentication. HDCP2.2 driver needs to communicate to ME FW for each step of the HDCP2.2 authentication. ME FW prepare and HDCP2.2 authentication parameters and encrypt them as per spec. With such parameter Driver prepares HDCP2.2 auth messages and co

[Intel-gfx] [PATCH v7 26/39] misc/mei/hdcp: Verify Receiver Cert and prepare km

2018-09-27 Thread Ramalingam C
Requests for verification for receiver certification and also the preparation for next AKE auth message with km. On Success ME FW validate the HDCP2.2 receivers certificate and do the revocation check on the receiver ID. AKE_Stored_Km will be prepared if the receiver is already paired, else AKE_No

[Intel-gfx] [PATCH v7 22/39] mei: bus: export to_mei_cl_device for mei client device drivers

2018-09-27 Thread Ramalingam C
From: Tomas Winkler Export to_mei_cl_device macro, it is needed also in mei client drivers. Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 1 - include/linux/mei_cl_bus.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/

[Intel-gfx] [PATCH v7 20/39] drm/i915: Add HDCP2.2 support for HDMI connectors

2018-09-27 Thread Ramalingam C
On HDMI connector init, intel_hdcp_init is passed with a flag for hdcp2.2 support based on the platform capability. v2: Rebased. v3: No Changes. v4: Collected the reviewed-by received. v5: No change. v6: No change. v7: No change. Signed-off-by: Ramalingam C Reviewed-by: Uma Shankar

[Intel-gfx] [PATCH v7 27/39] misc/mei/hdcp: Verify H_prime

2018-09-27 Thread Ramalingam C
Requests for the verification of AKE_Send_H_prime. ME will calculate the H and comparing it with received H_Prime. The result will be returned as status. Here AKE_Send_H_prime is a HDCP2.2 Authentication msg. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments an

[Intel-gfx] [PATCH v7 30/39] misc/mei/hdcp: Verify L_prime

2018-09-27 Thread Ramalingam C
Request to ME to verify the LPrime received from HDCP sink. On Success, ME FW will verify the received Lprime by calculating and comparing with L. This represents the completion of Locality Check. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and cast are r

[Intel-gfx] [RFC 10/10] drm/i915/gvt: GVTg support ppgtt pvmmio optimization

2018-09-27 Thread Xiaolin Zhang
This patch handles ppgtt update from g2v notification. It read out ppgtt pte entries from guest pte tables page and convert them to host pfns. It creates local ppgtt tables and insert the content pages into the local ppgtt tables directly, which does not track the usage of guest page table and re

[Intel-gfx] [RFC 08/10] drm/i915/gvt: GVTg support context submission pvmmio optimization

2018-09-27 Thread Xiaolin Zhang
implemented context submission pvmmio optimizaiton with GVTg. GVTg to read context submission data (elsp_data) from the shared_page directly without trap cost to improve guest GPU peformrnace. Signed-off-by: Xiaolin Zhang --- drivers/gpu/drm/i915/gvt/handlers.c | 12 1 file changed

[Intel-gfx] [RFC 09/10] drm/i915/gvt: GVTg support master irq pvmmio optimization

2018-09-27 Thread Xiaolin Zhang
GVTg to check master irq status in the shared_page instead of register. Signed-off-by: Xiaolin Zhang --- drivers/gpu/drm/i915/gvt/handlers.c | 4 drivers/gpu/drm/i915/gvt/interrupt.c | 17 + 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v7 32/39] misc/mei/hdcp: Repeater topology verification and ack

2018-09-27 Thread Ramalingam C
Request ME to verify the downstream topology information received. ME FW will validate the Repeaters receiver id list and downstream topology. On Success ME FW will provide the Least Significant 128bits of VPrime, which forms the repeater ack. v2: Rebased. v3: cldev is passed as first parame

[Intel-gfx] [PATCH v7 34/39] misc/mei/hdcp: Enabling the HDCP authentication

2018-09-27 Thread Ramalingam C
Request to ME to configure a port as authenticated. On Success, ME FW will mark the port as authenticated and provides HDCP cipher with the encryption keys. Enabling the Authentication can be requested once all stages of HDCP2.2 authentication is completed by interacting with ME FW. Only after t

[Intel-gfx] [PATCH v7 29/39] misc/mei/hdcp: Initiate Locality check

2018-09-27 Thread Ramalingam C
Requests ME to start the second stage of HDCP2.2 authentication, called Locality Check. On Success, ME FW will provide LC_Init message to send to hdcp sink. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas] v4: %zd used for ssize_t

[Intel-gfx] [PATCH v7 31/39] misc/mei/hdcp: Prepare Session Key

2018-09-27 Thread Ramalingam C
Request to ME to prepare the encrypted session key. On Success, ME provides Encrypted session key. Function populates the HDCP2.2 authentication msg SKE_Send_Eks. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas] v4: %zd for ssize_

[Intel-gfx] [PATCH v7 28/39] misc/mei/hdcp: Store the HDCP Pairing info

2018-09-27 Thread Ramalingam C
Provides Pairing info to ME to store. Pairing is a process to fast track the subsequent authentication with the same HDCP sink. On Success, received HDCP pairing info is stored in non-volatile memory of ME. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and

[Intel-gfx] [PATCH v7 35/39] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session

2018-09-27 Thread Ramalingam C
Request the ME to terminate the HDCP2.2 session for a port. On Success, ME FW will mark the intel port as Deauthenticated and terminate the wired HDCP2.2 Tx session started due to the cmd WIRED_INITIATE_HDCP2_SESSION. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant com

[Intel-gfx] [PATCH v7 33/39] misc/mei/hdcp: Verify M_prime

2018-09-27 Thread Ramalingam C
Request to ME to verify the M_Prime received from the HDCP sink. ME FW will calculate the M and compare with M_prime received as part of RepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg. On successful completion of this stage, downstream propagation of the stream management info is comple

[Intel-gfx] [PATCH v7 38/39] drm/i915: Fix KBL HDCP2.2 encrypt status signalling

2018-09-27 Thread Ramalingam C
Implement the required WA sequence for KBL to fix the incorrect positioning of the window of oppurtunity and enc_en signalling. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_hdcp.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/i91

[Intel-gfx] [PATCH v7 37/39] drm/i915: Commit CP without modeset

2018-09-27 Thread Ramalingam C
Commits the content protection change of a connector, without crtc modeset. This improves the user experience. Originally proposed by Sean Paul at v3 of HDCP1.4 framework https://patchwork.freedesktop.org/patch/191759/. For some reason this was dropped, but needed for the proper functionality of H

[Intel-gfx] [PATCH v7 36/39] misc/mei/hdcp: Component framework for I915 Interface

2018-09-27 Thread Ramalingam C
Mei hdcp driver is designed as component slave for the I915 component master. v2: Rebased. v3: Notifier chain is adopted for cldev state update [Tomas] v4: Made static dummy functions as inline in mei_hdcp.h API for polling client device status IS_ENABLED used in header, for config statu

[Intel-gfx] [PATCH v7 39/39] FOR_TEST: misc/Kconfig: Enabling mei_hdcp by default

2018-09-27 Thread Ramalingam C
FOR TESTING PURPOSE ONLY. Enabled the mei support for HDCP2.2. This patch is created to test the interface between I915 and MEI_HDCP. Signed-off-by: Ramalingam C --- drivers/misc/mei/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig

Re: [Intel-gfx] [RFC 01/10] drm/i915/gvt: add module parameter enable_pvmmio

2018-09-27 Thread Chris Wilson
Quoting Xiaolin Zhang (2018-09-27 17:37:46) > This int type module parameter is used to control the different > level pvmmio feature for MMIO emulation in GVT. > > This parameter is default zero, no pvmmio feature enabled. > > Its permission type is 0400 which means user could only change its > v

[Intel-gfx] [PATCH 1/2] drm/i915: Add new AML_ULX support list

2018-09-27 Thread Lee, Shawn C
According to patch "drm/i915/aml: Introducing Amber Lake platform" (e364672477a1). Add a new marco for AML ULX GT2 devices. Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Jose Roberto de Souza Signed-off-by: Lee, Shawn C --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ 1 file changed, 2 insertions(+) diff

[Intel-gfx] [PATCH 2/2] drm/i915: Apply correct ddi translation table for AML device

2018-09-27 Thread Lee, Shawn C
Amber Lake used the same gen graphics as Kaby Lake. Kernel driver should configure KBL's DDI buffer setting for AML ULX as well. So far, driver would load DDI translation table that used for KBL H/S platform and apply it on AML devices. But AML is belong to ULX series. This change will lead driver

Re: [Intel-gfx] [RFC 02/10] drm/i915/gvt: get ready of memory for pvmmio

2018-09-27 Thread Chris Wilson
Quoting Xiaolin Zhang (2018-09-27 17:37:47) > To enable pvmmio feature, we need to prepare one 4K shared page > which will be accessed by both guest and backend i915 driver. > > guest i915 allocate one page memory and then the guest physical address is > passed to backend i915 driver through PVINF

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915 pvmmio to improve GVTg performance

2018-09-27 Thread Patchwork
== Series Details == Series: i915 pvmmio to improve GVTg performance URL : https://patchwork.freedesktop.org/series/50257/ State : warning == Summary == $ dim checkpatch origin/drm-tip b7754818ea52 drm/i915/gvt: add module parameter enable_pvmmio -:25: CHECK:MACRO_ARG_PRECEDENCE: Macro argumen

Re: [Intel-gfx] [RFC 03/10] drm/i915/gvt: context submission pvmmio optimization

2018-09-27 Thread Chris Wilson
Quoting Xiaolin Zhang (2018-09-27 17:37:48) > It is performance optimization to reduce mmio trap numbers from 4 to > 1 durning ELSP porting writing (context submission). > > When context subission, to cache elsp_data[4] values in > the shared page, the last elsp_data[0] port writing will be trappe

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915 pvmmio to improve GVTg performance

2018-09-27 Thread Patchwork
== Series Details == Series: i915 pvmmio to improve GVTg performance URL : https://patchwork.freedesktop.org/series/50257/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/gvt: add module parameter enable_pvmmio Okay! Commit: drm/i915/gvt: get ready of memory for pvm

[Intel-gfx] ✓ Fi.CI.BAT: success for i915 pvmmio to improve GVTg performance

2018-09-27 Thread Patchwork
== Series Details == Series: i915 pvmmio to improve GVTg performance URL : https://patchwork.freedesktop.org/series/50257/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4890 -> Patchwork_10291 = == Summary - SUCCESS == No regressions found. External URL: https://patc

[Intel-gfx] [PATCH] drm/i915/csr: restructure CSR firmware definition macros

2018-09-27 Thread Jani Nikula
Use uniform prefixes for firmware path, version and size. Unify alignments. Order macro groups as in the if ladder using them. Add platform specific max firmware size macros for all platforms for clarity in the if ladder. Place the max firmware size macros in the platform specific macro groups. No

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Implement HDCP2.2 (rev9)

2018-09-27 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev9) URL : https://patchwork.freedesktop.org/series/38254/ State : warning == Summary == $ dim checkpatch origin/drm-tip 77a2e81767f0 drm: hdcp2.2 authentication msg definitions 27a36da1e882 drm: HDMI and DP specific HDCP2.2 defines c3

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Implement HDCP2.2 (rev9)

2018-09-27 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev9) URL : https://patchwork.freedesktop.org/series/38254/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm: hdcp2.2 authentication msg definitions Okay! Commit: drm: HDMI and DP specific HDCP2.2 defines Okay! Co

Re: [Intel-gfx] [PATCH v5] drm/i915: Remove i915.enable_ppgtt override

2018-09-27 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-26 23:12:22) > Now that we are confident in providing full-ppgtt where supported, > remove the ability to override the context isolation. > > v2: Remove faked aliasing-ppgtt for testing as it no longer is accepted. > v3: s/USES/HAS/ to match usage and reject attempts

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Implement HDCP2.2 (rev9)

2018-09-27 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev9) URL : https://patchwork.freedesktop.org/series/38254/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4891 -> Patchwork_10292 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_10292 absol

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Add new AML_ULX support list

2018-09-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add new AML_ULX support list URL : https://patchwork.freedesktop.org/series/50258/ State : warning == Summary == $ dim checkpatch origin/drm-tip 774790f183ba drm/i915: Add new AML_ULX support list -:22: CHECK:MACRO_ARG_REUSE: Ma

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Add new AML_ULX support list

2018-09-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add new AML_ULX support list URL : https://patchwork.freedesktop.org/series/50258/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Add new AML_ULX support list -drivers/gpu/drm/i915/selftests/../i915_

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: Split preemption smoke test into threads

2018-09-27 Thread Chris Wilson
When submitting chains to each engine, we can do so (mostly) in parallel, so delegate submission to threads on a per-engine basis. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_lrc.c | 71 ++ 1 file changed, 59 insertions(+), 12 deletions(-) diff --git

[Intel-gfx] [PATCH 2/2] drm/i915/selftests: Include arbitration points in preemption smoketest

2018-09-27 Thread Chris Wilson
Include a batch full of a page of arbitration points in order to provide a window for inject_preempt_context() in the preemption smoketests. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_lrc.c | 104 + 1 file changed, 85 insertions(+), 19 deletions(-)

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Add new AML_ULX support list

2018-09-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add new AML_ULX support list URL : https://patchwork.freedesktop.org/series/50258/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4891 -> Patchwork_10293 = == Summary - SUCCESS == No regressions found. E

Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: Split preemption smoke test into threads

2018-09-27 Thread Chris Wilson
Quoting Chris Wilson (2018-09-27 09:49:39) > When submitting chains to each engine, we can do so (mostly) in > parallel, so delegate submission to threads on a per-engine basis. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/selftests/intel_lrc.c | 71 ++ > 1 fi

Re: [Intel-gfx] [PATCH] drm/i915/csr: restructure CSR firmware definition macros

2018-09-27 Thread Chris Wilson
Quoting Jani Nikula (2018-09-27 08:53:11) > Use uniform prefixes for firmware path, version and size. Unify > alignments. Order macro groups as in the if ladder using them. Add > platform specific max firmware size macros for all platforms for clarity > in the if ladder. Place the max firmware size

Re: [Intel-gfx] [PATCH v5] drm/i915: Remove i915.enable_ppgtt override

2018-09-27 Thread Chris Wilson
Quoting Joonas Lahtinen (2018-09-27 09:20:06) > Quoting Chris Wilson (2018-09-26 23:12:22) > > Now that we are confident in providing full-ppgtt where supported, > > remove the ability to override the context isolation. > > > > v2: Remove faked aliasing-ppgtt for testing as it no longer is accepte

[Intel-gfx] [PULL] drm-misc-next

2018-09-27 Thread Sean Paul
Hi Dave, Thanks for the backmerge, we now have sun4i R40 support in again. Also noteworthy for this week are 3 new additions to -misc. This is very likely the last -misc-next pull for 4.20, but I'll see how things go in the next ~week. drm-misc-next-2018-09-27: drm-misc-next for 4.20: UAPI Ch

[Intel-gfx] [RFC 0/4] drm/i915/registers: use standard bits.h and bitfield.h macros

2018-09-27 Thread Jani Nikula
This is an RFC to get input on how people feel about moving towards using and macros for register field definitions and manipulation: * BIT() * GENMASK() * FIELD_GET() * FIELD_PREP() I'm not necessarily proposing pushing the patches in this series; they're more of a piece-by-piece transformatio

[Intel-gfx] [RFC 1/4] drm/i915/registers: prefer GENMASK() over hand rolled masks

2018-09-27 Thread Jani Nikula
GENMASK() is much easier to get right and review against the specs than hand rolled masks. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm

[Intel-gfx] [RFC 4/4] drm/i915/registers: define field values using FIELD_PREP()

2018-09-27 Thread Jani Nikula
Slightly verbose, but does away with hand rolled shifts and provides static checking that the values fit the mask. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [RFC 2/4] drm/i915/registers: prefer BIT() for single bits

2018-09-27 Thread Jani Nikula
BIT() is the preferred way of defining bits in the kernel. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 15 +++ drivers/gpu/drm/i915/intel_dp.c | 2 +- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/dr

[Intel-gfx] [RFC 3/4] drm/i915/registers: deprecate _SHIFT in favor of FIELD_GET() and _MASK

2018-09-27 Thread Jani Nikula
bitfield.h defines FIELD_GET() and FIELD_PREP() macros to access bitfields using the mask alone, with no need for separate shift. Indeed, the shift is redundant. For the most part, FIELD_GET() is shorter than masking followed by shift, and arguably has more clarity. FIELD_PREP() can get more verb

Re: [Intel-gfx] [RFC 0/4] drm/i915/registers: use standard bits.h and bitfield.h macros

2018-09-27 Thread Jani Nikula
On Thu, 27 Sep 2018, Jani Nikula wrote: > I'm not necessarily proposing pushing the patches in this series; > they're more of a piece-by-piece transformation of the power sequencer > macros and code to use the above macros, to give an idea what the end > result would look like. And if it isn't cl

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/csr: restructure CSR firmware definition macros

2018-09-27 Thread Patchwork
== Series Details == Series: drm/i915/csr: restructure CSR firmware definition macros URL : https://patchwork.freedesktop.org/series/50262/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4892 -> Patchwork_10294 = == Summary - SUCCESS == No regressions found. External U

[Intel-gfx] [PULL] drm-intel-next

2018-09-27 Thread Joonas Lahtinen
Hi Dave, Here's the second and final set of changes for v4.20, tagged last Friday before -rc5. We run it through the testing with the CI farm machines and found no regressions. Most user noticeable things are MythTV video stuttering regression fix for older hardware, black screen fix on resume wh

[Intel-gfx] [PULL] drm-misc-fixes

2018-09-27 Thread Maarten Lankhorst
drm-misc-fixes-2018-09-27: Single fix on top of v4.19-rc5. drm-misc-fixes for v4.19-rc6: - Don't leak fences in drm/syncobj The following changes since commit 6bf4ca7fbc85d80446ac01c0d1d77db4d91a6d84: Linux 4.19-rc5 (2018-09-23 19:15:18 +0200) are available in the Git repository at: git://a

Re: [Intel-gfx] [PATCH] drm/i915/dp: optimize eDP 1.4+ link config fast and narrow

2018-09-27 Thread Manasi Navare
On Wed, Sep 05, 2018 at 12:53:21PM +0300, Jani Nikula wrote: > We've opted to use the maximum link rate and lane count for eDP panels, > because typically the maximum supported configuration reported by the > panel has matched the native resolution requirements of the panel, and > optimizing the li

[Intel-gfx] ✓ Fi.CI.IGT: success for i915 pvmmio to improve GVTg performance

2018-09-27 Thread Patchwork
== Series Details == Series: i915 pvmmio to improve GVTg performance URL : https://patchwork.freedesktop.org/series/50257/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4890_full -> Patchwork_10291_full = == Summary - SUCCESS == No regressions found. == Known issues

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Log HWS seqno consistently (rev2)

2018-09-27 Thread Tvrtko Ursulin
On 26/09/2018 16:49, Patchwork wrote: == Series Details == Series: drm/i915: Log HWS seqno consistently (rev2) URL : https://patchwork.freedesktop.org/series/50193/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4883 -> Patchwork_10286 = == Summary - WARNING == Minor

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Trim partial view sg lists

2018-09-27 Thread Tvrtko Ursulin
On 26/09/2018 10:11, Patchwork wrote: == Series Details == Series: drm/i915: Trim partial view sg lists URL : https://patchwork.freedesktop.org/series/50177/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4878 -> Patchwork_10281 = == Summary - WARNING == Minor unknown

Re: [Intel-gfx] [RFC 4/4] drm/i915/registers: define field values using FIELD_PREP()

2018-09-27 Thread Chris Wilson
Quoting Jani Nikula (2018-09-27 10:40:23) > Slightly verbose, but does away with hand rolled shifts and provides > static checking that the values fit the mask. > > Signed-off-by: Jani Nikula > --- > @@ -4650,11 +4650,11 @@ enum { > #define _PP_ON_DELAYS 0x61208 > #define PP_ON

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Add new AML_ULX support list

2018-09-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add new AML_ULX support list URL : https://patchwork.freedesktop.org/series/50258/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4891_full -> Patchwork_10293_full = == Summary - SUCCESS == No regressions f

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen9: WaRsClearFWBitsAtFLR is for all gen9

2018-09-27 Thread Chris Wilson
Quoting Mika Kuoppala (2018-09-24 12:48:18) > Requirement to clear forcewake bits is for all gen9. Update > the wa comment to reflect that. I trust the change in wa name is accurate. > Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson -Chris ___

Re: [Intel-gfx] [PATCH v5] drm/i915: Remove i915.enable_ppgtt override

2018-09-27 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-27 11:55:03) > Quoting Joonas Lahtinen (2018-09-27 09:20:06) > > Quoting Chris Wilson (2018-09-26 23:12:22) > > > Now that we are confident in providing full-ppgtt where supported, > > > remove the ability to override the context isolation. > > > > > > v2: Remove fake

Re: [Intel-gfx] [RFC 01/10] drm/i915/gvt: add module parameter enable_pvmmio

2018-09-27 Thread Joonas Lahtinen
Quoting Xiaolin Zhang (2018-09-27 19:37:46) > This int type module parameter is used to control the different > level pvmmio feature for MMIO emulation in GVT. > > This parameter is default zero, no pvmmio feature enabled. > > Its permission type is 0400 which means user could only change its > v

Re: [Intel-gfx] [PATCH v5] drm/i915: Remove i915.enable_ppgtt override

2018-09-27 Thread Chris Wilson
Quoting Joonas Lahtinen (2018-09-27 11:57:53) > Quoting Chris Wilson (2018-09-27 11:55:03) > > Quoting Joonas Lahtinen (2018-09-27 09:20:06) > > > Quoting Chris Wilson (2018-09-26 23:12:22) > > > > Now that we are confident in providing full-ppgtt where supported, > > > > remove the ability to over

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: Split preemption smoke test into threads

2018-09-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Split preemption smoke test into threads URL : https://patchwork.freedesktop.org/series/50264/ State : warning == Summary == $ dim checkpatch origin/drm-tip 295fda403839 drm/i915/selftests: Split preemption smoke test

Re: [Intel-gfx] [RFC 00/10] i915 pvmmio to improve GVTg performance

2018-09-27 Thread Joonas Lahtinen
Quoting Xiaolin Zhang (2018-09-27 19:37:45) > To improve GVTg performance, it could reduce the mmio access trap > numbers within guest driver in some certain scenarios since mmio > access trap will introuduce vm exit/vm enter cost. > > the solution in this patch set is to setup a shared memory reg

Re: [Intel-gfx] [RFC 03/10] drm/i915/gvt: context submission pvmmio optimization

2018-09-27 Thread Joonas Lahtinen
Quoting Xiaolin Zhang (2018-09-27 19:37:48) > It is performance optimization to reduce mmio trap numbers from 4 to > 1 durning ELSP porting writing (context submission). > > When context subission, to cache elsp_data[4] values in > the shared page, the last elsp_data[0] port writing will be trappe

Re: [Intel-gfx] [RFC 0/4] drm/i915/registers: use standard bits.h and bitfield.h macros

2018-09-27 Thread Michal Wajdeczko
On Thu, 27 Sep 2018 11:40:19 +0200, Jani Nikula wrote: This is an RFC to get input on how people feel about moving towards using and macros for register field definitions and manipulation: * BIT() * GENMASK() BIT/GENMASK macros assumes 'unsigned long' type (64b) while our registers (and

Re: [Intel-gfx] [PATCH] drm/i915/dp: optimize eDP 1.4+ link config fast and narrow

2018-09-27 Thread Jani Nikula
On Thu, 27 Sep 2018, Manasi Navare wrote: > On Wed, Sep 05, 2018 at 12:53:21PM +0300, Jani Nikula wrote: >> We've opted to use the maximum link rate and lane count for eDP panels, >> because typically the maximum supported configuration reported by the >> panel has matched the native resolution re

Re: [Intel-gfx] [RFC 0/4] drm/i915/registers: use standard bits.h and bitfield.h macros

2018-09-27 Thread Jani Nikula
On Thu, 27 Sep 2018, Michal Wajdeczko wrote: > On Thu, 27 Sep 2018 11:40:19 +0200, Jani Nikula > wrote: > >> This is an RFC to get input on how people feel about moving towards >> using and macros for register field >> definitions and manipulation: >> >> * BIT() >> * GENMASK() > > BIT/GENMASK

Re: [Intel-gfx] [PATCH 37/40] drm/i915: Allow a context to define its set of engines

2018-09-27 Thread Tvrtko Ursulin
On 19/09/2018 20:55, Chris Wilson wrote: Over the last few years, we have debated how to extend the user API to support an increase in the number of engines, that may be sparse and even be heterogeneous within a class (not all video decoders created equal). We settled on using (class, instance)

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: Split preemption smoke test into threads

2018-09-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Split preemption smoke test into threads URL : https://patchwork.freedesktop.org/series/50264/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4894 -> Patchwork_10295 = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH 39/40] drm/i915/execlists: Refactor out can_merge_rq()

2018-09-27 Thread Tvrtko Ursulin
On 19/09/2018 20:55, Chris Wilson wrote: In the next patch, we add another user that wants to check whether requests can be merge into a single HW execution, and in the future we want to add more conditions under which requests from the same context cannot be merge. In preparation, extract out c

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen9: WaRsClearFWBitsAtFLR is for all gen9

2018-09-27 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-09-24 12:48:18) >> Requirement to clear forcewake bits is for all gen9. Update >> the wa comment to reflect that. > > I trust the change in wa name is accurate. It is consistent now and matches the databse, and it has been changed all the way ba

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/csr: restructure CSR firmware definition macros

2018-09-27 Thread Patchwork
== Series Details == Series: drm/i915/csr: restructure CSR firmware definition macros URL : https://patchwork.freedesktop.org/series/50262/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4892_full -> Patchwork_10294_full = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [RFC 0/4] drm/i915/registers: use standard bits.h and bitfield.h macros

2018-09-27 Thread Jani Nikula
On Thu, 27 Sep 2018, Jani Nikula wrote: > On Thu, 27 Sep 2018, Michal Wajdeczko wrote: >> On Thu, 27 Sep 2018 11:40:19 +0200, Jani Nikula >> wrote: >> >>> This is an RFC to get input on how people feel about moving towards >>> using and macros for register field >>> definitions and manipulat

Re: [Intel-gfx] [RFC 4/4] drm/i915/registers: define field values using FIELD_PREP()

2018-09-27 Thread Jani Nikula
On Thu, 27 Sep 2018, Chris Wilson wrote: > Quoting Jani Nikula (2018-09-27 10:40:23) >> Slightly verbose, but does away with hand rolled shifts and provides >> static checking that the values fit the mask. >> >> Signed-off-by: Jani Nikula >> --- >> @@ -4650,11 +4650,11 @@ enum { >> #define _PP_

Re: [Intel-gfx] [RFC 4/4] drm/i915/registers: define field values using FIELD_PREP()

2018-09-27 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-27 13:35:47) > Quoting Jani Nikula (2018-09-27 10:40:23) > > Slightly verbose, but does away with hand rolled shifts and provides > > static checking that the values fit the mask. > > > > Signed-off-by: Jani Nikula > > --- > > @@ -4650,11 +4650,11 @@ enum { > > #def

Re: [Intel-gfx] [PATCH v3 1/8] drm/i915: Make sure fb gtt offsets stay within 32bits

2018-09-27 Thread Ville Syrjälä
On Wed, Sep 26, 2018 at 09:09:31PM +0100, Chris Wilson wrote: > Quoting Ville Syrjälä (2018-09-26 10:27:40) > > On Tue, Sep 25, 2018 at 09:29:44PM +0100, Chris Wilson wrote: > > > Quoting Ville Syrjala (2018-09-25 20:37:07) > > > > From: Ville Syrjälä > > > > + /* Catch potential overflows e

Re: [Intel-gfx] [RFC 4/4] drm/i915/registers: define field values using FIELD_PREP()

2018-09-27 Thread Jani Nikula
On Thu, 27 Sep 2018, Jani Nikula wrote: > On Thu, 27 Sep 2018, Chris Wilson wrote: >> Quoting Jani Nikula (2018-09-27 10:40:23) >>> Slightly verbose, but does away with hand rolled shifts and provides >>> static checking that the values fit the mask. >>> >>> Signed-off-by: Jani Nikula >>> --- >

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Combine multiple internal plists into the same i915_priolist bucket

2018-09-27 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-09-25 10:48:44) > > On 25/09/2018 09:32, Chris Wilson wrote: > > As we are about to allow ourselves to slightly bump the user priority > > into a few different sublevels, packthose internal priority lists > > into the same i915_priolist to keep the rbtree compact and a

Re: [Intel-gfx] [PATCH 4/7] drm/i915/gen11: Program the scalers correctly for planar formats.

2018-09-27 Thread Ville Syrjälä
On Wed, Sep 26, 2018 at 05:16:40PM -0700, Matt Roper wrote: > On Fri, Sep 21, 2018 at 07:39:42PM +0200, Maarten Lankhorst wrote: > > The first 3 planes (primary, sprite 0 and 1) have a dedicated chroma > > upsampler to upscale YUV420 to YUV444 and the scaler should only be > > used for upscaling. B

Re: [Intel-gfx] [PATCH 2/7] drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v3.

2018-09-27 Thread Ville Syrjälä
On Tue, Sep 25, 2018 at 01:18:43PM -0700, Matt Roper wrote: > On Tue, Sep 25, 2018 at 09:34:29PM +0300, Ville Syrjälä wrote: > > On Tue, Sep 25, 2018 at 11:01:32AM -0700, Matt Roper wrote: > > > On Mon, Sep 24, 2018 at 04:18:10PM +0300, Ville Syrjälä wrote: > > > > It pretty much has to. The desig

Re: [Intel-gfx] [PATCH] drm/i915/dp: optimize eDP 1.4+ link config fast and narrow

2018-09-27 Thread Manasi Navare
On Thu, Sep 27, 2018 at 02:15:26PM +0300, Jani Nikula wrote: > On Thu, 27 Sep 2018, Manasi Navare wrote: > > On Wed, Sep 05, 2018 at 12:53:21PM +0300, Jani Nikula wrote: > >> We've opted to use the maximum link rate and lane count for eDP panels, > >> because typically the maximum supported config

Re: [Intel-gfx] [RFC 1/3] drm: Add colorspace property

2018-09-27 Thread Ville Syrjälä
On Thu, Sep 27, 2018 at 04:29:52AM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > >Sent: Wednesday, September 26, 2018 3:12 PM > >To: Maarten Lankhorst > >Cc: Shankar, Uma ; Adam Jackson > >; intel-gfx@lists.freedeskto

Re: [Intel-gfx] [PATCH 0/4][RFC] Dynamic EU configuration of Slice/Subslice/EU.

2018-09-27 Thread Joonas Lahtinen
+ Tvrtko for adding the right media contacts Quoting kedar.j.kara...@intel.com (2018-09-21 12:13:46) > From: "Kedar J. Karanje" > > drm/i915: Context aware user agnostic EU/Slice/Sub-slice control within kernel > > Current GPU configuration code for i915 does not allow us to change > EU/Slice/S

Re: [Intel-gfx] [PATCH 1/3] drm/i915: DRM_FORMAT_C8 is not possible with Yf tiling

2018-09-27 Thread Ville Syrjälä
On Tue, Sep 25, 2018 at 03:02:21PM -0700, Paulo Zanoni wrote: > Em Ter, 2018-09-25 às 15:02 +0300, Ville Syrjälä escreveu: > > On Mon, Sep 24, 2018 at 05:19:11PM -0700, Paulo Zanoni wrote: > > > Function intel_framebuffer_init() checks for the possibilities > > > during > > > framebuffer creation (

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/registers: use standard bits.h and bitfield.h macros

2018-09-27 Thread Patchwork
== Series Details == Series: drm/i915/registers: use standard bits.h and bitfield.h macros URL : https://patchwork.freedesktop.org/series/50267/ State : failure == Summary == CALLscripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i91

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/selftests: Split preemption smoke test into threads

2018-09-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Split preemption smoke test into threads URL : https://patchwork.freedesktop.org/series/50264/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4894_full -> Patchwork_10295_full = == Summary - SUCCESS

[Intel-gfx] [PULL] drm-misc-fixes

2018-09-27 Thread Sean Paul
Hi Dave, Linus posted the device_link revert after Maarten's PR earlier today, and I figured it was worthwhile enough to warrant a second pull. So here is Maarten's pull along with Linus' revert. Apologies for the extra mail :/ drm-misc-fixes-2018-09-27-1: - Revert adding device-link to panels

  1   2   >