[Intel-gfx] [PATCH] drm/i915/audio: Fix audio detection issue on GLK

2018-04-17 Thread Gaurav K Singh
On Geminilake, sometimes audio card is not getting detected after reboot. This is a spurious issue happening on Geminilake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for GLK. Extending this fix to GLK as well. T

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Maarten Lankhorst
Op 17-04-18 om 08:03 schreef Saarinen, Jani: > Lets move this to intel-gfx to get more eyes on it. > >> -Original Message- >> From: Srinivas, Vidya >> Sent: tiistai 17. huhtikuuta 2018 5.47 >> To: Maarten Lankhorst ; intel-gfx- >> try...@lists.freedesktop.org >> Cc: Kamath, Sunil ; Saarine

Re: [Intel-gfx] [PATCH v10 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-17 Thread Daniel Vetter
On Tue, Apr 17, 2018 at 10:45:07AM +0530, Nautiyal, Ankit K wrote: > > On 4/6/2018 11:14 PM, Ville Syrjälä wrote: > > On Fri, Apr 06, 2018 at 10:55:14PM +0530, Nautiyal, Ankit K wrote: > > > This patch is causing failure of IGT test kms_3d. The kms_3d test > > > expects the no. of 3d modes to be 1

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Srinivas, Vidya
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Tuesday, April 17, 2018 12:55 PM > To: Saarinen, Jani ; Srinivas, Vidya > ; intel-gfx-try...@lists.freedesktop.org; intel- > g...@lists.freedesktop.org > Cc: Kamath, Sunil > Subject: Re: [PA

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Maarten Lankhorst
Op 17-04-18 om 09:38 schreef Srinivas, Vidya: > >> -Original Message- >> From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] >> Sent: Tuesday, April 17, 2018 12:55 PM >> To: Saarinen, Jani ; Srinivas, Vidya >> ; intel-gfx-try...@lists.freedesktop.org; intel- >> g...@lists.fre

Re: [Intel-gfx] [PATCH] drm/i915/audio: Fix audio detection issue on GLK

2018-04-17 Thread Jani Nikula
On Tue, 17 Apr 2018, Gaurav K Singh wrote: > On Geminilake, sometimes audio card is not getting > detected after reboot. This is a spurious issue happening on > Geminilake. HW codec and HD audio controller link was going > out of sync for which there was a fix in i915 driver but > was not getting

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/audio: Fix audio detection issue on GLK (rev2)

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915/audio: Fix audio detection issue on GLK (rev2) URL : https://patchwork.freedesktop.org/series/41334/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4058 -> Patchwork_8701 = == Summary - FAILURE == Serious unknown changes coming with P

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Srinivas, Vidya
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Tuesday, April 17, 2018 1:21 PM > To: Srinivas, Vidya ; Saarinen, Jani > ; intel-gfx@lists.freedesktop.org > Cc: Kamath, Sunil > Subject: Re: [PATCH v2 6/6] drm/i915: Do not do fb src adjust

Re: [Intel-gfx] [Freedreno] [PATCH 01/10] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-04-17 Thread Daniel Vetter
On Mon, Apr 16, 2018 at 10:52:59AM -0700, Eric Anholt wrote: > Chris Wilson writes: > > > Quoting Jordan Crouse (2018-04-05 23:06:53) > >> On Thu, Apr 05, 2018 at 04:00:47PM -0600, Jordan Crouse wrote: > >> > The i915 DRM driver very cleverly used ascii85 encoding for their > >> > GPU state file.

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/audio: Fix audio detection issue on GLK (rev2)

2018-04-17 Thread Martin Peres
On 17/04/18 11:00, Patchwork wrote: > == Series Details == > > Series: drm/i915/audio: Fix audio detection issue on GLK (rev2) > URL : https://patchwork.freedesktop.org/series/41334/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4058 -> Patchwork_8701 = > > == S

Re: [Intel-gfx] [RFC v4 19/25] drm/client: Finish the in-kernel client API

2018-04-17 Thread Daniel Vetter
On Mon, Apr 16, 2018 at 05:58:23PM +0200, Noralf Trønnes wrote: > > Den 16.04.2018 10.27, skrev Daniel Vetter: > > On Sat, Apr 14, 2018 at 01:53:12PM +0200, Noralf Trønnes wrote: > > > The modesetting code is already present, this adds the rest of the API. > > Mentioning the TODO in the commit mes

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Srinivas, Vidya
> -Original Message- > From: Srinivas, Vidya > Sent: Tuesday, April 17, 2018 1:32 PM > To: 'Maarten Lankhorst' ; Saarinen, > Jani ; intel-gfx@lists.freedesktop.org > Cc: Kamath, Sunil > Subject: RE: [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for > NV12 > > > > > -Origin

Re: [Intel-gfx] [RFC v4 00/25] drm: Add generic fbdev emulation

2018-04-17 Thread Daniel Vetter
On Mon, Apr 16, 2018 at 08:49:23PM +0200, Noralf Trønnes wrote: > > Den 16.04.2018 10.21, skrev Daniel Vetter: > > On Sat, Apr 14, 2018 at 01:52:53PM +0200, Noralf Trønnes wrote: > > > This patchset explores the possibility of having generic fbdev emulation > > > in DRM for drivers that supports d

Re: [Intel-gfx] [RFC v4 21/25] drm/fb-helper: Add drm_fb_helper_fb_open/release()

2018-04-17 Thread Daniel Vetter
On Mon, Apr 16, 2018 at 06:10:07PM +0200, Noralf Trønnes wrote: > > Den 16.04.2018 10.46, skrev Daniel Vetter: > > On Sat, Apr 14, 2018 at 01:53:14PM +0200, Noralf Trønnes wrote: > > > These helpers keep track of fbdev users and drm_driver.last_close will > > > only restore fbdev when actually in

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gvt: Deliver guest cursor hotspot info (rev2)

2018-04-17 Thread Martin Peres
On 16/04/18 14:45, Patchwork wrote: > == Series Details == > > Series: drm/i915/gvt: Deliver guest cursor hotspot info (rev2) > URL : https://patchwork.freedesktop.org/series/41727/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4054_full -> Patchwork_8694_full = >

[Intel-gfx] [CI i-g-t 1/2] tests/gem_exec_latency: New subtests for checking submission from RT tasks

2018-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We want to make sure RT tasks which use a lot of CPU times can submit batch buffers with roughly the same latency (and certainly not worse) compared to normal tasks. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson --- tests/gem_exec_latency.c | 176

[Intel-gfx] [CI i-g-t 2/2] HACK enable new test

2018-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- tests/intel-ci/blacklist.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt index d65d8ff35217..bdba838a50ac 100644 --- a/tests/intel-ci/blacklist.txt +++ b/te

Re: [Intel-gfx] [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

2018-04-17 Thread Jani Nikula
On Mon, 16 Apr 2018, "Srivatsa, Anusha" wrote: >>-Original Message- >>From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >>Sent: Wednesday, April 11, 2018 5:27 AM >>To: Ian W MORRISON >>Cc: Vivi, Rodrigo ; Srivatsa, Anusha >>; Wajdeczko, Michal >>; Greg KH ; >>airl...@linux.ie; joonas

[Intel-gfx] [PATCH v3 0/2] GMBUS changes

2018-04-17 Thread Ramalingam C
I am not aware if there is a reason for restricting the Bytes per GMBUS WR/RD to 256 at present. But HW has 9Bits for Total Byte count for a single read or Write cycle. Means we can extend a cycle of RD/WR to 511Bytes. At present nothing much as ROI, as most of the usecases are for less than 256By

[Intel-gfx] [PATCH v3 2/2] drm/i915/gmbus: Enable burst read

2018-04-17 Thread Ramalingam C
Support for Burst read in HW is added for HDCP2.2 compliance requirement. This patch enables the burst read for all the gmbus read of more than 511Bytes, on capable platforms. v2: Extra line is removed. v3: Macro is added for detecting the BURST_READ Support [Jani] Runtime detection of the

[Intel-gfx] [PATCH v3 1/2] drm/i915/gmbus: Increase the Bytes per Rd/Wr Op

2018-04-17 Thread Ramalingam C
From Gen9 onwards Bspec says HW supports Max Bytes per single RD/WR op is 511Bytes instead of previous 256Bytes used in SW. This change allows the max bytes per op upto 511Bytes from Gen9 onwards. v2: No Change. v3: Inline function for max_xfer_size and renaming of the macro.[Jani] Cc: Jani

Re: [Intel-gfx] [PATCH v2] drm/i915: Pack params to engine->schedule() into a struct

2018-04-17 Thread Tvrtko Ursulin
On 12/04/2018 00:00, Chris Wilson wrote: Today we only want to pass along the priority to engine->schedule(), but in the future we want to have much more control over the various aspects of the GPU during a context's execution, for example controlling the frequency allowed. As we need an ever gr

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Mika Kahola
On Fri, 2018-04-13 at 17:44 +0530, Vidya Srinivas wrote: > We skip src trunction/adjustments for > NV12 case and handle the sizes directly. > Without this, pipe fifo underruns are seen on APL/KBL. > > v2: For NV12, making the src coordinates multiplier of 4 > > Credits-to: Maarten Lankhorst > Si

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/audio: Fix audio detection issue on GLK (rev2)

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915/audio: Fix audio detection issue on GLK (rev2) URL : https://patchwork.freedesktop.org/series/41334/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4058 -> Patchwork_8702 = == Summary - WARNING == Minor unknown changes coming with Pat

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Srinivas, Vidya
> -Original Message- > From: Kahola, Mika > Sent: Tuesday, April 17, 2018 2:49 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src > adjustments for NV12 > > On Fri, 2018-04-13 at 17:44 +0530, Vidya Srinivas

Re: [Intel-gfx] [PATCH v1 2/2] i915: content-type property for HDMI connector

2018-04-17 Thread Lisovskiy, Stanislav
Hi Sean, Thank you for comments! Could you please clarify a bit more here, as I've just started recently working on drm side, so I took an aspect ratio property as an example. > @@ -491,6 +491,8 @@ static void intel_hdmi_set_avi_infoframe(struct > drm_encoder *encoder, >

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Maarten Lankhorst
Op 17-04-18 om 10:09 schreef Srinivas, Vidya: > >> -Original Message- >> From: Srinivas, Vidya >> Sent: Tuesday, April 17, 2018 1:32 PM >> To: 'Maarten Lankhorst' ; Saarinen, >> Jani ; intel-gfx@lists.freedesktop.org >> Cc: Kamath, Sunil >> Subject: RE: [PATCH v2 6/6] drm/i915: Do not do f

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Srinivas, Vidya
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Tuesday, April 17, 2018 3:04 PM > To: Srinivas, Vidya ; Saarinen, Jani > ; intel-gfx@lists.freedesktop.org > Cc: Kamath, Sunil > Subject: Re: [PATCH v2 6/6] drm/i915: Do not do fb src adjust

Re: [Intel-gfx] [PATCH v2] drm/i915: Pack params to engine->schedule() into a struct

2018-04-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-17 10:12:05) > > On 12/04/2018 00:00, Chris Wilson wrote: > > Today we only want to pass along the priority to engine->schedule(), but > > in the future we want to have much more control over the various aspects > > of the GPU during a context's execution, for examp

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Maarten Lankhorst
Op 17-04-18 om 11:42 schreef Srinivas, Vidya: > >> -Original Message- >> From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] >> Sent: Tuesday, April 17, 2018 3:04 PM >> To: Srinivas, Vidya ; Saarinen, Jani >> ; intel-gfx@lists.freedesktop.org >> Cc: Kamath, Sunil >> Subject:

[Intel-gfx] [PATCH] drm/i915: Remove skl dc6 enable/disable functions

2018-04-17 Thread Daniel Vetter
One is outright unused, other can be made static. Drive-by cleanup while accidentally reading dc code. Cc: Imre Deak Acked-by: Imre Deak Cc: Rodrigo Vivi Cc. Dhinakaran Pandiyan Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_drv.h| 2 -- drivers/gpu/drm/i915/intel_runt

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/audio: Fix audio detection issue on GLK (rev2)

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915/audio: Fix audio detection issue on GLK (rev2) URL : https://patchwork.freedesktop.org/series/41334/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4058_full -> Patchwork_8702_full = == Summary - FAILURE == Serious unknown changes com

Re: [Intel-gfx] [CI i-g-t 1/2] tests/gem_exec_latency: New subtests for checking submission from RT tasks

2018-04-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-17 09:41:11) > From: Tvrtko Ursulin > > We want to make sure RT tasks which use a lot of CPU times can submit > batch buffers with roughly the same latency (and certainly not worse) > compared to normal tasks. > > Signed-off-by: Tvrtko Ursulin > Cc: Chris Wilson

Re: [Intel-gfx] [RFC v4 23/25] drm: Add DRM device registered notifier

2018-04-17 Thread Daniel Vetter
On Sat, Apr 14, 2018 at 01:53:16PM +0200, Noralf Trønnes wrote: > Add a notifier that fires when a new DRM device is registered. > This can be used by the bootsplash client to connect to all devices. > > Signed-off-by: Noralf Trønnes So I freaked out temporarily about your usage of notifiers her

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Srinivas, Vidya
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Tuesday, April 17, 2018 3:32 PM > To: Srinivas, Vidya ; Saarinen, Jani > ; intel-gfx@lists.freedesktop.org > Cc: Kamath, Sunil > Subject: Re: [PATCH v2 6/6] drm/i915: Do not do fb src adjust

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Handle a potential failure of intel_ring_begin

2018-04-17 Thread Chris Wilson
Quoting Oscar Mateo (2018-04-16 22:57:01) > Silence smatch over: > > drivers/gpu/drm/i915/selftests/intel_workarounds.c:58 read_nonprivs() error: > 'cs' dereferencing possible ERR_PTR() > > by handling a potential (but unlikely) failure of intel_ring_begin. > > Fixes: f4ecfbfc32ed ("drm/i915: C

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Handle a potential failure of intel_ring_begin

2018-04-17 Thread Chris Wilson
Quoting Patchwork (2018-04-17 00:47:27) > == Series Details == > > Series: drm/i915/selftests: Handle a potential failure of intel_ring_begin > URL : https://patchwork.freedesktop.org/series/41773/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4058_full -> Patchwor

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Srinivas, Vidya
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Tuesday, April 17, 2018 3:32 PM > To: Srinivas, Vidya ; Saarinen, Jani > ; intel-gfx@lists.freedesktop.org > Cc: Kamath, Sunil > Subject: Re: [PATCH v2 6/6] drm/i915: Do not do fb src adjust

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-17 Thread Saarinen, Jani
HI, > -Original Message- > From: Srinivas, Vidya > Sent: tiistai 17. huhtikuuta 2018 13.49 > To: Maarten Lankhorst ; Saarinen, Jani > ; intel-gfx@lists.freedesktop.org > Cc: Kamath, Sunil > Subject: RE: [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12 > > > > > -Origi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GMBUS changes (rev3)

2018-04-17 Thread Patchwork
== Series Details == Series: GMBUS changes (rev3) URL : https://patchwork.freedesktop.org/series/41632/ State : warning == Summary == $ dim checkpatch origin/drm-tip 16f60217eb21 drm/i915/gmbus: Increase the Bytes per Rd/Wr Op bcedea2a9483 drm/i915/gmbus: Enable burst read -:28: CHECK:MACRO_AR

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for GMBUS changes (rev3)

2018-04-17 Thread Patchwork
== Series Details == Series: GMBUS changes (rev3) URL : https://patchwork.freedesktop.org/series/41632/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/gmbus: Increase the Bytes per Rd/Wr Op -O:drivers/gpu/drm/i915/intel_i2c.c:403:23: warning: expression using sizeo

[Intel-gfx] [PATCH] drm/i915: Add documentation to gen9_set_dc_state()

2018-04-17 Thread Imre Deak
Add documentation to gen9_set_dc_state() on what enabling a given DC state means and at what point HW/DMC actually enters/exits these states. Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_runtime_pm.c | 23 +++ 1 file changed, 23

[Intel-gfx] ✓ Fi.CI.BAT: success for GMBUS changes (rev3)

2018-04-17 Thread Patchwork
== Series Details == Series: GMBUS changes (rev3) URL : https://patchwork.freedesktop.org/series/41632/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059 -> Patchwork_8703 = == Summary - WARNING == Minor unknown changes coming with Patchwork_8703 need to be verified m

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove skl dc6 enable/disable functions

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove skl dc6 enable/disable functions URL : https://patchwork.freedesktop.org/series/41803/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059 -> Patchwork_8704 = == Summary - SUCCESS == No regressions found. External URL: htt

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add documentation to gen9_set_dc_state()

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Add documentation to gen9_set_dc_state() URL : https://patchwork.freedesktop.org/series/41811/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059 -> Patchwork_8705 = == Summary - SUCCESS == No regressions found. External URL: ht

[Intel-gfx] [RFC 7/7] drm/i915: Allow clients to query own per-engine busyness

2018-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some customers want to know how much of the GPU time are their clients using in order to make dynamic load balancing decisions. With the accounting infrastructure in place in the previous patch, we add a new context param (I915_CONTEXT_GET_ENGINES_BUSY) which points to struc

[Intel-gfx] [RFC 4/7] drm/i915: Update client name on context create

2018-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some clients have the DRM fd passed to them over a socket by the X server. Grab the real client and pid when they create their first context and update the exposed data for more useful enumeration. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [RFC 6/7] drm/i915: Add sysfs toggle to enable per-client engine stats

2018-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin By default we are not collecting any per-engine and per-context statistcs. Add a new sysfs toggle to enable this facility: $ echo 1 >/sys/class/drm/card0/clients/enable_stats v2: Rebase. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 4 +++ drive

[Intel-gfx] [RFC 3/7] drm/i915: Expose list of clients in sysfs

2018-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Expose a list of clients with open file handles in sysfs. This will be a basis for a top-like utility showing per-client and per- engine GPU load. Currently we only expose each client's pid and name under opaque numbered directories in /sys/class/drm/card0/clients/. For in

[Intel-gfx] [RFC 5/7] drm/i915: Expose per-engine client busyness

2018-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Expose per-client and per-engine busyness under the previously added sysfs client root. The new files are one per-engine instance and located under the 'busy' directory. Each contains a monotonically increasing nano-second resolution times each client's jobs were executing

[Intel-gfx] [RFC v4 0/7] Per-context and per-client engine busyness

2018-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Another re-post of my earlier, now slightly updated work, to expose a DRM client hierarchy in sysfs in order to enable a top like tool: intel-gpu-top - load avg 40.80, 27.11, 1.50; 882/ 950 MHz;0% RC6; 13.26 Watts; 261903 irqs/s IMC reads: 5543 MiB/s

[Intel-gfx] [RFC 2/7] drm/i915: Track per-context engine busyness

2018-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some customers want to know how much of the GPU time are their clients using in order to make dynamic load balancing decisions. With the hooks already in place which track the overall engine busyness, we can extend that slightly to split that time between contexts. v2: Fix

[Intel-gfx] [PATCH 1/7] drm/i915: Use seqlock in engine stats

2018-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We can convert engine stats from a spinlock to seqlock to ensure interrupt processing is never even a tiny bit delayed by parallel readers. There is a smidgen bit more cost on the write lock side, and an extremely unlikely chance that readers will have to retry a few times i

Re: [Intel-gfx] [RFC v4 0/7] Per-context and per-client engine busyness

2018-04-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-17 13:27:29) > From: Tvrtko Ursulin > > Another re-post of my earlier, now slightly updated work, to expose a DRM > client > hierarchy in sysfs in order to enable a top like tool: > > intel-gpu-top - load avg 40.80, 27.11, 1.50; 882/ 950 MHz;0% RC6; > 13.

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GMBUS changes (rev3)

2018-04-17 Thread Jani Nikula
On Tue, 17 Apr 2018, Patchwork wrote: > == Series Details == > > Series: GMBUS changes (rev3) > URL : https://patchwork.freedesktop.org/series/41632/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > 16f60217eb21 drm/i915/gmbus: Increase the Bytes per Rd/Wr Op > bcedea2a9

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Use seqlock in engine stats

2018-04-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-17 13:27:30) > From: Tvrtko Ursulin > > We can convert engine stats from a spinlock to seqlock to ensure interrupt > processing is never even a tiny bit delayed by parallel readers. > > There is a smidgen bit more cost on the write lock side, and an extremely > un

Re: [Intel-gfx] [igt-dev] [RFC 2/7] drm/i915: Track per-context engine busyness

2018-04-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-17 13:27:31) > From: Tvrtko Ursulin > > Some customers want to know how much of the GPU time are their clients > using in order to make dynamic load balancing decisions. > > With the hooks already in place which track the overall engine busyness, > we can extend t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per-context and per-client engine busyness (rev5)

2018-04-17 Thread Patchwork
== Series Details == Series: Per-context and per-client engine busyness (rev5) URL : https://patchwork.freedesktop.org/series/32645/ State : warning == Summary == $ dim checkpatch origin/drm-tip a367a6c9fd96 drm/i915: Use seqlock in engine stats 557e1f39ef83 drm/i915: Track per-context engine

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Per-context and per-client engine busyness (rev5)

2018-04-17 Thread Patchwork
== Series Details == Series: Per-context and per-client engine busyness (rev5) URL : https://patchwork.freedesktop.org/series/32645/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Use seqlock in engine stats Okay! Commit: drm/i915: Track per-context engine busynes

[Intel-gfx] ✓ Fi.CI.IGT: success for GMBUS changes (rev3)

2018-04-17 Thread Patchwork
== Series Details == Series: GMBUS changes (rev3) URL : https://patchwork.freedesktop.org/series/41632/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059_full -> Patchwork_8703_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_8703_full need to

[Intel-gfx] ✗ Fi.CI.BAT: failure for Per-context and per-client engine busyness (rev5)

2018-04-17 Thread Patchwork
== Series Details == Series: Per-context and per-client engine busyness (rev5) URL : https://patchwork.freedesktop.org/series/32645/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4059 -> Patchwork_8706 = == Summary - FAILURE == Serious unknown changes coming with Patchwo

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove skl dc6 enable/disable functions

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove skl dc6 enable/disable functions URL : https://patchwork.freedesktop.org/series/41803/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059_full -> Patchwork_8704_full = == Summary - WARNING == Minor unknown changes coming with

Re: [Intel-gfx] [RFC 6/7] drm/i915: Add sysfs toggle to enable per-client engine stats

2018-04-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-17 13:27:35) > From: Tvrtko Ursulin > > By default we are not collecting any per-engine and per-context > statistcs. > > Add a new sysfs toggle to enable this facility: > > $ echo 1 >/sys/class/drm/card0/clients/enable_stats I have to ask, what would be the inte

[Intel-gfx] [RFC/CI PATCH] drm/i915/crc: make locking and source check more robust

2018-04-17 Thread Jani Nikula
It seems to me intel_pipe_crc source and skipped should be checked and modified atomically. Skipped could concievably be changed when source has already been disabled. Alas I can't think of a real world scenario where this could impact CRCs in IGT. Signed-off-by: Jani Nikula --- drivers/gpu/drm/

Re: [Intel-gfx] [PATCH] drm/i915: Call i915_perf_fini() on init_hw error unwind

2018-04-17 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-04-14 16:59:13) > On Sat, 14 Apr 2018 11:12:33 +0200, Chris Wilson > wrote: > > > We have to cleanup after i915_perf_init(), even on the error path, as it > > passes a pointer into the module to the sysfs core. If we fail to > > unregister the sysctl table, we lea

Re: [Intel-gfx] [PATCH 0/9] GPU-bound energy efficiency improvements for the intel_pstate driver.

2018-04-17 Thread Chris Wilson
I have to ask, if this is all just to work around iowait triggering high frequencies for GPU bound applications, does it all just boil down to i915 incorrectly using iowait. Does this patch set perform better than diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_reques

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add documentation to gen9_set_dc_state()

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Add documentation to gen9_set_dc_state() URL : https://patchwork.freedesktop.org/series/41811/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059_full -> Patchwork_8705_full = == Summary - SUCCESS == No regressions found. Externa

Re: [Intel-gfx] [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

2018-04-17 Thread Joonas Lahtinen
Quoting Jani Nikula (2018-04-17 12:02:52) > On Mon, 16 Apr 2018, "Srivatsa, Anusha" wrote: > >>-Original Message- > >>From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > >>Sent: Wednesday, April 11, 2018 5:27 AM > >>To: Ian W MORRISON > >>Cc: Vivi, Rodrigo ; Srivatsa, Anusha > >>; Wa

[Intel-gfx] [PATCH v2 1/3] drm/i915: Move the priotree struct to its own headers

2018-04-17 Thread Chris Wilson
Over time the priotree has grown from a sorted list to a more complicated structure for propagating constraints along the dependency chain to try and resolve priority inversion. Start to segregate this information from the rest of the request/fence tracking. Signed-off-by: Chris Wilson --- drive

[Intel-gfx] [PATCH v2 2/3] drm/i915: Rename priotree to sched

2018-04-17 Thread Chris Wilson
Having moved the priotree struct into i915_scheduler.h, identify it as the scheduling element and rebrand into i915_sched. This becomes more useful as we start attaching more information we require to propagate through the scheduler. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gpu_

[Intel-gfx] [PATCH] drm/i915/selftests: Don't use -ETIMEDOUT from inside a test

2018-04-17 Thread Chris Wilson
-ETIMEDOUT is reserved in the selftests for use by igt_timeout, and the errno is magically handled by the test runner to break from inside the test loop without propagating back to userspace as a failure. So convert the -ETIMEDOUT from wait_var_event_timeout() into another errno. Signed-off-by: Ch

[Intel-gfx] [PATCH v2 3/3] drm/i915: Pack params to engine->schedule() into a struct

2018-04-17 Thread Chris Wilson
Today we only want to pass along the priority to engine->schedule(), but in the future we want to have much more control over the various aspects of the GPU during a context's execution, for example controlling the frequency allowed. As we need an ever growing number of parameters for scheduling, m

Re: [Intel-gfx] [Freedreno] [PATCH 01/10] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-04-17 Thread Jordan Crouse
On Mon, Apr 16, 2018 at 10:52:59AM -0700, Eric Anholt wrote: > Chris Wilson writes: > > > Quoting Jordan Crouse (2018-04-05 23:06:53) > >> On Thu, Apr 05, 2018 at 04:00:47PM -0600, Jordan Crouse wrote: > >> > The i915 DRM driver very cleverly used ascii85 encoding for their > >> > GPU state file.

Re: [Intel-gfx] [PATCH] gpu: drm: i915: Change return type to vm_fault_t

2018-04-17 Thread Jani Nikula
On Tue, 17 Apr 2018, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. > > Reference id -> 1c

Re: [Intel-gfx] [PATCH 0/9] GPU-bound energy efficiency improvements for the intel_pstate driver.

2018-04-17 Thread Srinivas Pandruvada
On Tue, 2018-04-17 at 15:03 +0100, Chris Wilson wrote: > I have to ask, if this is all just to work around iowait triggering > high > frequencies for GPU bound applications, does it all just boil down to > i915 incorrectly using iowait. Does this patch set perform better > than > > diff --git a/dr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/crc: make locking and source check more robust

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915/crc: make locking and source check more robust URL : https://patchwork.freedesktop.org/series/41821/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059 -> Patchwork_8707 = == Summary - WARNING == Minor unknown changes coming with Pat

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: Move the priotree struct to its own headers

2018-04-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Move the priotree struct to its own headers URL : https://patchwork.freedesktop.org/series/41827/ State : warning == Summary == $ dim checkpatch origin/drm-tip 22ae52c5d491 drm/i915: Move the priotree struct to its own heade

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/3] drm/i915: Move the priotree struct to its own headers

2018-04-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Move the priotree struct to its own headers URL : https://patchwork.freedesktop.org/series/41827/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Move the priotree struct to its own headers Okay!

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: Move the priotree struct to its own headers

2018-04-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Move the priotree struct to its own headers URL : https://patchwork.freedesktop.org/series/41827/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059 -> Patchwork_8708 = == Summary - WARNING == Minor un

Re: [Intel-gfx] [PATCH v7 1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads

2018-04-17 Thread Zhang, Yunwei
On 4/16/2018 3:09 PM, Oscar Mateo wrote: On 04/16/2018 02:22 PM, Yunwei Zhang wrote: WaProgramMgsrForCorrectSliceSpecificMmioReads dictate that before any MMIO read into Slice/Subslice specific registers, MCR packet control register(0xFDC) needs to be programmed to point to any enabled slic

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Don't use -ETIMEDOUT from inside a test

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Don't use -ETIMEDOUT from inside a test URL : https://patchwork.freedesktop.org/series/41828/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059 -> Patchwork_8709 = == Summary - WARNING == Minor unknown changes coming with

Re: [Intel-gfx] [PATCH] gpu: drm: i915: Change return type to vm_fault_t

2018-04-17 Thread Matthew Wilcox
On Tue, Apr 17, 2018 at 09:14:32PM +0530, Souptick Joarder wrote: > Not exactly. The plan for these patches is to introduce new vm_fault_t type > in vm_operations_struct fault handlers. It's now available in 4.17-rc1. We > will > push all the required drivers/filesystem changes through different m

Re: [Intel-gfx] [PATCH] gpu: drm: i915: Change return type to vm_fault_t

2018-04-17 Thread Daniel Vetter
On Tue, Apr 17, 2018 at 5:29 PM, Jani Nikula wrote: > On Tue, 17 Apr 2018, Souptick Joarder wrote: >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather than an errno. Once all instances >> are converted, vm_

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/crc: make locking and source check more robust

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915/crc: make locking and source check more robust URL : https://patchwork.freedesktop.org/series/41821/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059_full -> Patchwork_8707_full = == Summary - WARNING == Minor unknown changes comin

[Intel-gfx] [PATCH] drm/i915/selftests: Fix error checking for wait_var_timeout

2018-04-17 Thread Chris Wilson
The old wait_on_atomic_t used a custom callback to perform the schedule(), which used my return semantics of reporting an error code on timeout. wait_var_event_timeout() uses the schedule() return semantics of reporting the remaining jiffies (1 if it timed out with 0 jiffies remaining!) and 0 on fa

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/3] drm/i915: Move the priotree struct to its own headers

2018-04-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Move the priotree struct to its own headers URL : https://patchwork.freedesktop.org/series/41827/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059_full -> Patchwork_8708_full = == Summary - WARNING ==

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Don't use -ETIMEDOUT from inside a test

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Don't use -ETIMEDOUT from inside a test URL : https://patchwork.freedesktop.org/series/41828/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059_full -> Patchwork_8709_full = == Summary - WARNING == Minor unknown changes c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Fix error checking for wait_var_timeout

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix error checking for wait_var_timeout URL : https://patchwork.freedesktop.org/series/41835/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059 -> Patchwork_8710 = == Summary - WARNING == Minor unknown changes coming with

Re: [Intel-gfx] [PATCH v4] drm/i915: Enable edp psr error interrupts on hsw

2018-04-17 Thread Ville Syrjälä
On Mon, Apr 16, 2018 at 05:43:54PM -0700, Paulo Zanoni wrote: > Em Qui, 2018-04-05 às 15:00 -0700, Dhinakaran Pandiyan escreveu: > > From: Daniel Vetter > > > > The definitions for the error register should be valid on bdw/skl > > too, > > but there we haven't even enabled DE_MISC handling yet. >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Fix error checking for wait_var_timeout

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix error checking for wait_var_timeout URL : https://patchwork.freedesktop.org/series/41835/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059_full -> Patchwork_8710_full = == Summary - WARNING == Minor unknown changes c

Re: [Intel-gfx] [PATCH v10 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-17 Thread Ville Syrjälä
On Tue, Apr 17, 2018 at 10:45:07AM +0530, Nautiyal, Ankit K wrote: > > On 4/6/2018 11:14 PM, Ville Syrjälä wrote: > > On Fri, Apr 06, 2018 at 10:55:14PM +0530, Nautiyal, Ankit K wrote: > >> This patch is causing failure of IGT test kms_3d. The kms_3d test > >> expects the no. of 3d modes to be 13.

Re: [Intel-gfx] [PATCH] drm/i915: Fix LSPCON TMDS output buffer enabling from low-power state

2018-04-17 Thread Ville Syrjälä
On Mon, Apr 16, 2018 at 06:53:09PM +0300, Imre Deak wrote: > LSPCON adapters in low-power state may ignore the first I2C write during > TMDS output buffer enabling, resulting in a blank screen even with an > otherwise enabled pipe. Fix this by reading back and validating the > written value a few t

Re: [Intel-gfx] [PATCH] drm/i915/audio: Fix audio detection issue on GLK

2018-04-17 Thread Kumar, Abhay
On 4/17/2018 12:18 AM, Gaurav K Singh wrote: On Geminilake, sometimes audio card is not getting detected after reboot. This is a spurious issue happening on Geminilake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invok

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gmbus: Increase the Bytes per Rd/Wr Op

2018-04-17 Thread Ville Syrjälä
On Tue, Apr 17, 2018 at 02:25:32PM +0530, Ramalingam C wrote: > >From Gen9 onwards Bspec says HW supports Max Bytes per single RD/WR op is > 511Bytes instead of previous 256Bytes used in SW. > > This change allows the max bytes per op upto 511Bytes from Gen9 onwards. > > v2: > No Change. > v3:

[Intel-gfx] [PATCH] drm/i915/audio: Fix audio detection issue on GLK

2018-04-17 Thread Gaurav K Singh
On Geminilake, sometimes audio card is not getting detected after reboot. This is a spurious issue happening on Geminilake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for GLK. Extending this fix to GLK as well. T

Re: [Intel-gfx] [PATCH] drm/i915/audio: Fix audio detection issue on GLK

2018-04-17 Thread Du,Wenkai
On 4/17/2018 11:22 AM, Gaurav K Singh wrote: On Geminilake, sometimes audio card is not getting detected after reboot. This is a spurious issue happening on Geminilake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoke

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/audio: Fix audio detection issue on GLK (rev3)

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915/audio: Fix audio detection issue on GLK (rev3) URL : https://patchwork.freedesktop.org/series/41334/ State : warning == Summary == $ dim checkpatch origin/drm-tip 31e1d7550f3b drm/i915/audio: Fix audio detection issue on GLK -:16: WARNING:COMMIT_LOG_LONG_L

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/gmbus: Enable burst read

2018-04-17 Thread Ville Syrjälä
On Tue, Apr 17, 2018 at 02:25:33PM +0530, Ramalingam C wrote: > Support for Burst read in HW is added for HDCP2.2 compliance > requirement. > > This patch enables the burst read for all the gmbus read of more than > 511Bytes, on capable platforms. > > v2: > Extra line is removed. > v3: > Macr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/audio: Fix audio detection issue on GLK (rev3)

2018-04-17 Thread Patchwork
== Series Details == Series: drm/i915/audio: Fix audio detection issue on GLK (rev3) URL : https://patchwork.freedesktop.org/series/41334/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4059 -> Patchwork_8711 = == Summary - WARNING == Minor unknown changes coming with Pat

[Intel-gfx] [PATCH v3] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-17 Thread Abhay Kumar
In glk when device boots with only 1366x768 panel, HDA codec doesn't comeup. This result in no audio forever as cdclk is < 96Mhz. This change will ensure CD clock to be twice of BCLK. v2: - Address comment (Jani) - New design approach v3: - Typo fix on top of v1 Bugzilla: https://bugs.fr

  1   2   >