Re: [Intel-gfx] [PATCH 4/5] drm/vblank: Restoring vblank counts after device PM events.

2018-01-19 Thread Rodrigo Vivi
On Fri, Jan 12, 2018 at 09:57:06PM +, Dhinakaran Pandiyan wrote: > The HW frame counter can get reset if device enters a low power state after > vblank interrupts were disabled. This messes up any following vblank count > update as a negative diff (huge unsigned diff) is calculated from the HW

Re: [Intel-gfx] [PATCH 1/5] drm/vblank: Fix return type for drm_vblank_count()

2018-01-19 Thread Rodrigo Vivi
On Fri, Jan 19, 2018 at 04:53:34AM +, Pandiyan, Dhinakaran wrote: > ping for review. sorry for not getting back sooner here. But yey \o/ I finally have dmc and psr working well on my own laptop! so far so good! :) > > Let me know if there's anything that needs to be done, thanks! > > > On

Re: [Intel-gfx] [PATCH] drm/i915: vbt defs typo fixes

2018-01-19 Thread Jani Nikula
On Thu, 18 Jan 2018, Adam Jackson wrote: > On Thu, 2018-01-18 at 17:06 +0200, Jani Nikula wrote: >> No more sing-a-ling. >> >> Reported-by: Adam Jackson > > Why'd you omit the typos I reported in tools/intel_vbt_decode.c ? This one's for the kernel. I'll apply your original patch to igt. (Sorry

Re: [Intel-gfx] [PATCH v2 10/11] drm/i915: Move sandybride pcode access to intel_sideband.c

2018-01-19 Thread Mika Kuoppala
Chris Wilson writes: > sandybride_pcode is another sideband, so move it to their new home. > Up to this patch, omitting the waitboosting. Uptime 41min till system hang on j1900. With waitboosting patch it did survive without system hangs for 24h+ but the frequency seemed to remain constant. -M

Re: [Intel-gfx] [PATCH v2 10/11] drm/i915: Move sandybride pcode access to intel_sideband.c

2018-01-19 Thread Chris Wilson
Quoting Mika Kuoppala (2018-01-19 08:21:31) > Chris Wilson writes: > > > sandybride_pcode is another sideband, so move it to their new home. > > > > Up to this patch, omitting the waitboosting. Uptime 41min till > system hang on j1900. Still weird, my system is still surviving with its spiky fr

Re: [Intel-gfx] [PATCH] drm/i915: vbt defs typo fixes

2018-01-19 Thread Jani Nikula
On Thu, 18 Jan 2018, David Weinehall wrote: > On Thu, Jan 18, 2018 at 05:06:13PM +0200, Jani Nikula wrote: >> No more sing-a-ling. > > LOL, well spotted. > >> Reported-by: Adam Jackson >> Signed-off-by: Jani Nikula > > Reviewed-by: David Weinehall Thanks for the reviews, pushed. BR, Jani. >

Re: [Intel-gfx] [PATCH i-g-t] intel_vbt_decode: Typo fixes

2018-01-19 Thread Jani Nikula
On Fri, 15 Dec 2017, Adam Jackson wrote: > Signed-off-by: Adam Jackson Finally pushed, thanks for the patch. BR, Jani. > --- > tools/intel_vbt_decode.c | 4 ++-- > tools/intel_vbt_defs.h | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/intel_vbt_decode.c

[Intel-gfx] [PATCH i-g-t] tools/intel_bios_decode: update vbt defs from kernel

2018-01-19 Thread Jani Nikula
Sync up with the following intel_vbt_defs.h changes in kernel: c4fb60b9aba9 ("drm/i915/bios: add DP max link rate to VBT child device struct") d6038611aa3d ("drm/i915: Parse max HDMI TMDS clock from VBT") 6e8fbf8d19e4 ("drm/i915/vbt: Fix HDMI level shifter and max data rate bitfield sizes") 9c3

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove redundant ELD connector type update

2018-01-19 Thread Jani Nikula
On Tue, 02 Jan 2018, Patchwork wrote: > == Series Details == > > Series: drm/i915: remove redundant ELD connector type update > URL : https://patchwork.freedesktop.org/series/35853/ > State : success Pushed to dinq. BR, Jani. > > == Summary == > > Series 35853v1 drm/i915: remove redundant EL

[Intel-gfx] [PATCH 2/3] drm/i915: Per-engine scratch VMA is mandatory

2018-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We fail engine initialization if the scratch VMA cannot be created so there is no point in error handle it later. If the initialization ordering gets messed up, we can explode during development just as well. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_lrc

[Intel-gfx] [PATCH 1/3] drm/i915: Downgrade incorrect engine constructor usage warnings to development

2018-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Render engine constructor helpers must only be called from the render engine constructors, but there is no need to burden the production binaries with warnings which can only be triggered during development. Signed-off-by: Tvrtko Ursulin Cc: Michel Thierry --- drivers/gpu

[Intel-gfx] [PATCH 3/3] drm/i915: Stop ignoring failure to set up workaround batch buffers

2018-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Setting up the workaround batch buffers can fail either due programming errors which will be caught in development, or by the inability to allocate a 4k object and pin it in GGTT at runtime. Since this is highly unlikely, and it is not deterministic to allow driver operation

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Per-engine scratch VMA is mandatory

2018-01-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-01-19 10:00:04) > From: Tvrtko Ursulin > > We fail engine initialization if the scratch VMA cannot be created so > there is no point in error handle it later. If the initialization ordering > gets messed up, we can explode during development just as well. > > Signed-

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Stop ignoring failure to set up workaround batch buffers

2018-01-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-01-19 10:00:05) > From: Tvrtko Ursulin > > Setting up the workaround batch buffers can fail either due programming > errors which will be caught in development, or by the inability to > allocate a 4k object and pin it in GGTT at runtime. > > Since this is highly unli

[Intel-gfx] [PATCH v2] drm/i915: add support for specifying DMC firmware override by module param

2018-01-19 Thread Jani Nikula
Use i915.dmc_firmware_path to override default firmware for the platform and bypassing version checks. v2: add missing param struct member declaration (David) Tested-by: David Weinehall Reviewed-by: David Weinehall Cc: Anusha Srivatsa Cc: David Weinehall Signed-off-by: Jani Nikula --- drive

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Stop ignoring failure to set up workaround batch buffers

2018-01-19 Thread Tvrtko Ursulin
On 19/01/2018 10:09, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-01-19 10:00:05) From: Tvrtko Ursulin Setting up the workaround batch buffers can fail either due programming errors which will be caught in development, or by the inability to allocate a 4k object and pin it in GGTT at runt

Re: [Intel-gfx] [PATCH v2] drm/i915: Ignore TMDS clock limit for DP++ when EDID override is set

2018-01-19 Thread Jani Nikula
On Fri, 15 Dec 2017, Abdiel Janulgue wrote: > 4K modes testing by using dummy EDID data has never been working > properly on boxes with DP++ (dual-mode) adaptors. The reason for > this is that those modes got pruned during hdmi mode validation. > intel_hdmi_mode_valid returns CLOCK_HIGH because th

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Stop ignoring failure to set up workaround batch buffers

2018-01-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-01-19 10:29:12) > > On 19/01/2018 10:09, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-01-19 10:00:05) > >> From: Tvrtko Ursulin > >> > >> Setting up the workaround batch buffers can fail either due programming > >> errors which will be caught in development, o

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Downgrade incorrect engine constructor usage warnings to development

2018-01-19 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Downgrade incorrect engine constructor usage warnings to development URL : https://patchwork.freedesktop.org/series/36771/ State : success == Summary == Series 36771v1 series starting with [1/3] drm/i915: Downgrade incorrect en

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add support for specifying DMC firmware override by module param (rev2)

2018-01-19 Thread Patchwork
== Series Details == Series: drm/i915: add support for specifying DMC firmware override by module param (rev2) URL : https://patchwork.freedesktop.org/series/34157/ State : success == Summary == Series 34157v2 drm/i915: add support for specifying DMC firmware override by module param https:/

Re: [Intel-gfx] [PATCH 01/27] drm/i915/icl: Add initial Icelake definitions.

2018-01-19 Thread Joonas Lahtinen
On Wed, 2018-01-10 at 17:17 -0200, Paulo Zanoni wrote: > From: Rodrigo Vivi > > Icelake is an Intel® Processor containing an Intel® Graphics > Controller. > > This is just an initial Icelake definition. PCI IDs, Icelake support > and new features coming in following patches. > > v2: Add .ddb_si

Re: [Intel-gfx] [PATCH 00/27] ICL basic enabling + GEM

2018-01-19 Thread Joonas Lahtinen
+ Jani On Wed, 2018-01-10 at 17:32 -0800, Rodrigo Vivi wrote: > On Tue, Jan 09, 2018 at 11:23:09PM +, Paulo Zanoni wrote: > > Hello > > > > This is the first series of patches for the Icelake platform. Unlike the > > other > > series that introduced new platforms, this one is very small and

Re: [Intel-gfx] [RFC 6/6] drm/i915/pmu: Add running counter

2018-01-19 Thread Tvrtko Ursulin
On 18/01/2018 11:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-01-18 10:41:36) From: Tvrtko Ursulin We add a PMU counter to expose the number of requests currently executing on the GPU. This is useful to analyze the overall load of the system. Signed-off-by: Tvrtko Ursulin Ok, the

Re: [Intel-gfx] [PATCH 00/27] ICL basic enabling + GEM

2018-01-19 Thread Tvrtko Ursulin
On 19/01/2018 11:45, Joonas Lahtinen wrote: + Jani On Wed, 2018-01-10 at 17:32 -0800, Rodrigo Vivi wrote: On Tue, Jan 09, 2018 at 11:23:09PM +, Paulo Zanoni wrote: Hello This is the first series of patches for the Icelake platform. Unlike the other series that introduced new platforms, t

Re: [Intel-gfx] [PATCH i-g-t] tools/intel_bios_decode: update vbt defs from kernel

2018-01-19 Thread Petri Latvala
On Fri, Jan 19, 2018 at 10:56:33AM +0200, Jani Nikula wrote: > Sync up with the following intel_vbt_defs.h changes in kernel: > > c4fb60b9aba9 ("drm/i915/bios: add DP max link rate to VBT child device > struct") > > d6038611aa3d ("drm/i915: Parse max HDMI TMDS clock from VBT") > > 6e8fbf8d19e4 (

Re: [Intel-gfx] [PATCH i-g-t] tools/intel_bios_decode: update vbt defs from kernel

2018-01-19 Thread Jani Nikula
On Fri, 19 Jan 2018, Petri Latvala wrote: > On Fri, Jan 19, 2018 at 10:56:33AM +0200, Jani Nikula wrote: >> Sync up with the following intel_vbt_defs.h changes in kernel: >> >> c4fb60b9aba9 ("drm/i915/bios: add DP max link rate to VBT child device >> struct") >> >> d6038611aa3d ("drm/i915: Parse

Re: [Intel-gfx] [PATCH 00/27] ICL basic enabling + GEM

2018-01-19 Thread Jani Nikula
On Fri, 19 Jan 2018, Joonas Lahtinen wrote: > + Jani > > On Wed, 2018-01-10 at 17:32 -0800, Rodrigo Vivi wrote: >> On Tue, Jan 09, 2018 at 11:23:09PM +, Paulo Zanoni wrote: >> > Hello >> > >> > This is the first series of patches for the Icelake platform. Unlike the >> > other >> > series th

[Intel-gfx] [PATCH v10 3/6] drm/i915/debugfs: add rcs topology entry

2018-01-19 Thread Lionel Landwerlin
While the end goal is to make this information available to userspace through a new ioctl, there is no reason we can't display it in a human readable fashion through debugfs. slice0: 3 subslice(s) (0x7): subslice0: 8 EUs (0xff) subslice1: 8 EUs (0xff) subslice2: 8 EUs (0xff

Re: [Intel-gfx] [RFC] drm/i915/guc: Keep GuC log disabled by default

2018-01-19 Thread Michał Winiarski
On Fri, Jan 19, 2018 at 12:49:26PM +, Michal Wajdeczko wrote: > It looks that GuC log functionality is not fully functional yet and > causes issues when enabled by auto(-1) modparam on debug builds. > > [ 30.062893] == > [ 30.062894] WARN

Re: [Intel-gfx] [RFC] drm/i915/guc: Keep GuC log disabled by default

2018-01-19 Thread Lofstedt, Marta
+ Daniel > -Original Message- > From: Wajdeczko, Michal > Sent: Friday, January 19, 2018 2:49 PM > To: intel-gfx@lists.freedesktop.org > Cc: Wajdeczko, Michal ; Chris Wilson > ; Saarinen, Jani ; > Sarvela, Tomi P ; Lofstedt, Marta > ; Winiarski, Michal > Subject: [RFC] drm/i915/guc: Keep

[Intel-gfx] [PATCH 5/6] drm/i915: Expose per-engine client busyness

2018-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Expose per-client and per-engine busyness under the previously added sysfs client root. The new file is named 'busy' and contains a list of, one line for each engine, monotonically increasing nano-second resolution times each client's jobs were executing on the GPU. $ cat /

[Intel-gfx] [PATCH v10 1/6] drm/i915: store all subslice masks

2018-01-19 Thread Lionel Landwerlin
Up to now, subslice mask was assumed to be uniform across slices. But starting with Cannonlake, slices can be asymmetric (for example slice0 has different number of subslices as slice1+). This change stores all subslices masks for all slices rather than having a single mask that applies to all slic

Re: [Intel-gfx] [RFC 6/6] drm/i915/pmu: Add running counter

2018-01-19 Thread Tvrtko Ursulin
On 19/01/2018 13:40, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-01-19 11:45:24) On 18/01/2018 11:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-01-18 10:41:36) From: Tvrtko Ursulin We add a PMU counter to expose the number of requests currently executing on the GPU. This is us

Re: [Intel-gfx] [PATCH v2] drm/i915/bios: add DP max link rate to VBT child device struct

2018-01-19 Thread Jani Nikula
On Fri, 19 Jan 2018, Ville Syrjälä wrote: > On Thu, Jan 18, 2018 at 05:33:10PM +0200, Jani Nikula wrote: >> Update VBT defs to reflect revision 216. While at it, default the >> expected child device struct size to sizeof the size rather than a >> hardcoded value. >> >> v2: Fix bit order (David) >

[Intel-gfx] [PATCH v10 4/6] drm/i915: add rcs topology to error state

2018-01-19 Thread Lionel Landwerlin
This might be useful information for developers looking at an error state. v2: Place topology towards the end of the error state (Chris) v3: Reuse common printing code (Michal) v4: Make this a one-liner (Chris) Signed-off-by: Lionel Landwerlin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/

Re: [Intel-gfx] [PATCH v2] drm/i915/bios: add DP max link rate to VBT child device struct

2018-01-19 Thread Ville Syrjälä
On Thu, Jan 18, 2018 at 05:33:10PM +0200, Jani Nikula wrote: > Update VBT defs to reflect revision 216. While at it, default the > expected child device struct size to sizeof the size rather than a > hardcoded value. > > v2: Fix bit order (David) > > Cc: Rodrigo Vivi > Signed-off-by: Jani Nikula

[Intel-gfx] [RFC] drm/i915/guc: Keep GuC log disabled by default

2018-01-19 Thread Michal Wajdeczko
It looks that GuC log functionality is not fully functional yet and causes issues when enabled by auto(-1) modparam on debug builds. [ 30.062893] == [ 30.062894] WARNING: possible circular locking dependency detected [ 30.062895] 4.15.0-rc8

[Intel-gfx] [PATCH v10 6/6] drm/i915: expose rcs topology through query uAPI

2018-01-19 Thread Lionel Landwerlin
With the introduction of asymmetric slices in CNL, we cannot rely on the previous SUBSLICE_MASK getparam to tell userspace what subslices are available. Here we introduce a more detailed way of querying the Gen's GPU topology that doesn't aggregate numbers. This is essential for monitoring parts o

[Intel-gfx] [PATCH v10 0/6] drm/i915: expose RCS topology to userspace

2018-01-19 Thread Lionel Landwerlin
Hi all, This is hopefully the last iteration with a last tweak on comments for coding style. Cheers, Lionel Landwerlin (6): drm/i915: store all subslice masks drm/i915/debugfs: reuse max slice/subslices already stored in sseu drm/i915/debugfs: add rcs topology entry drm/i915: add rcs top

[Intel-gfx] [PATCH v10 5/6] drm/i915: add query uAPI

2018-01-19 Thread Lionel Landwerlin
There are a number of information that are readable from hardware registers and that we would like to make accessible to userspace. One particular example is the topology of the execution units (how are execution units grouped in subslices and slices and also which ones have been fused off for die

[Intel-gfx] [PATCH v2 0/6] Per-context and per-client engine busyness

2018-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I have sent this as part of a larger series back in October '17. First part of it is implementing a customer requirement to be able to query engine utilization on their own contexts. This is done in patch 2, which falls under the standard open source userspace requirements e

[Intel-gfx] [PATCH 1/6] drm/i915: Track per-context engine busyness

2018-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some customers want to know how much of the GPU time are their clients using in order to make dynamic load balancing decisions. With the hooks already in place which track the overall engine busyness, we can extend that slightly to split that time between contexts. v2: Fix

Re: [Intel-gfx] [PATCH 00/27] ICL basic enabling + GEM

2018-01-19 Thread Mika Kuoppala
Tvrtko Ursulin writes: > On 19/01/2018 11:45, Joonas Lahtinen wrote: >> + Jani >> >> On Wed, 2018-01-10 at 17:32 -0800, Rodrigo Vivi wrote: >>> On Tue, Jan 09, 2018 at 11:23:09PM +, Paulo Zanoni wrote: Hello This is the first series of patches for the Icelake platform. Unlike

[Intel-gfx] [PATCH 3/6] drm/i915: Expose list of clients in sysfs

2018-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Expose a list of clients with open file handles in sysfs. This will be a basis for a top-like utility showing per-client and per- engine GPU load. Currently we only expose each client's pid and name under opaque numbered directories in /sys/class/drm/card0/clients/. For in

[Intel-gfx] [PATCH v10 2/6] drm/i915/debugfs: reuse max slice/subslices already stored in sseu

2018-01-19 Thread Lionel Landwerlin
Now that we have that information in topology fields, let's just reused it. v2: Style tweaks (Tvrtko) Signed-off-by: Lionel Landwerlin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff -

[Intel-gfx] [PATCH 6/6] drm/i915: Add sysfs toggle to enable per-client engine stats

2018-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin By default we are not collecting any per-engine and per-context statistcs. Add a new sysfs toggle to enable this facility: $ echo 1 >/sys/class/drm/card0/clients/enable_stats v2: Rebase. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ driver

[Intel-gfx] [PATCH 4/6] drm/i915: Update client name on context create

2018-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some clients have the DRM fd passed to them over a socket by the X server. Grab the real client and pid when they create their first context and update the exposed data for more useful enumeration. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [RFC 6/6] drm/i915/pmu: Add running counter

2018-01-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-01-19 11:45:24) > > On 18/01/2018 11:57, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-01-18 10:41:36) > >> From: Tvrtko Ursulin > >> > >> We add a PMU counter to expose the number of requests currently executing > >> on the GPU. > >> > >> This is useful to ana

[Intel-gfx] [PATCH 2/6] drm/i915: Allow clients to query own per-engine busyness

2018-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some customers want to know how much of the GPU time are their clients using in order to make dynamic load balancing decisions. With the accounting infrastructure in place in the previous patch, we add a new context param (I915_CONTEXT_GET_ENGINE_BUSY) which takes a class an

Re: [Intel-gfx] [PATCH v5] drm/i915/icl: Enhanced execution list support

2018-01-19 Thread Mika Kuoppala
Daniele Ceraolo Spurio writes: > From: Thomas Daniel > > Enhanced Execlists is an upgraded version of execlists which supports > up to 8 ports. The lrcs to be submitted are written to a submit queue, > which is then loaded on the HW. When writing to the ELSP register, the > lrcs are written cycl

Re: [Intel-gfx] [PATCH] drm/i915: Avoid leaking lpe audio platdev.data

2018-01-19 Thread Jani Nikula
On Sat, 09 Dec 2017, Chris Wilson wrote: > The struct platform_device memdups the provided data pointer requiring > us to free the template we construct during lpe_audio_platdev_create(): > > unreferenced object 0x88026eafe400 (size 512): > comm "insmod", pid 6850, jiffies 4295060179 (age 22

Re: [Intel-gfx] [RFC] drm/i915/guc: Keep GuC log disabled by default

2018-01-19 Thread Jani Nikula
On Fri, 19 Jan 2018, Michał Winiarski wrote: > On Fri, Jan 19, 2018 at 12:49:26PM +, Michal Wajdeczko wrote: >> It looks that GuC log functionality is not fully functional yet and >> causes issues when enabled by auto(-1) modparam on debug builds. This could use a better explanation. Now it s

Re: [Intel-gfx] [PATCH v2] drm/i915: Check for fused or unused pipes

2018-01-19 Thread Jani Nikula
On Mon, 18 Dec 2017, Mika Kahola wrote: > We may have fused or unused pipes in our system. Let's check that the pipe > in question is within limits of accessible pipes. In case, that we are not > able to access the pipe, we return early with a warning. > > v2: Rephrasing of the commit message (Jan

Re: [Intel-gfx] [PATCH v10 6/6] drm/i915: expose rcs topology through query uAPI

2018-01-19 Thread Tvrtko Ursulin
On 19/01/2018 13:22, Lionel Landwerlin wrote: With the introduction of asymmetric slices in CNL, we cannot rely on the previous SUBSLICE_MASK getparam to tell userspace what subslices are available. Here we introduce a more detailed way of querying the Gen's GPU topology that doesn't aggregate n

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid leaking lpe audio platdev.data

2018-01-19 Thread Patchwork
== Series Details == Series: drm/i915: Avoid leaking lpe audio platdev.data URL : https://patchwork.freedesktop.org/series/35151/ State : success == Summary == Series 35151v1 drm/i915: Avoid leaking lpe audio platdev.data https://patchwork.freedesktop.org/api/1.0/series/35151/revisions/1/mbox/

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: Downgrade incorrect engine constructor usage warnings to development

2018-01-19 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Downgrade incorrect engine constructor usage warnings to development URL : https://patchwork.freedesktop.org/series/36771/ State : failure == Summary == Test perf: Subgroup oa-exponents: fail -> PA

[Intel-gfx] [PATCH v2 1/8] drm/i915: Add a comment exlaining CCS hsub/vsub

2018-01-19 Thread Ville Syrjala
From: Ville Syrjälä Let's document why we claim hsub==8,vsub==16 for CCS. v2: Replace my explanation with Jason's Cc: Daniel Vetter Cc: Ben Widawsky Cc: Jason Ekstrand Cc: Daniel Stone Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 14 ++ 1 file change

[Intel-gfx] [CI] drm/i915: Shrink the request kmem_cache on allocation error

2018-01-19 Thread Chris Wilson
If we fail to allocate a new request, make sure we recover the pages that are in the process of being freed by inserting an RCU barrier. v2: Comment before the shrink and barrier in the error path. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/

Re: [Intel-gfx] [PATCH v10 6/6] drm/i915: expose rcs topology through query uAPI

2018-01-19 Thread Lionel Landwerlin
On 19/01/18 14:24, Tvrtko Ursulin wrote: On 19/01/2018 13:22, Lionel Landwerlin wrote: With the introduction of asymmetric slices in CNL, we cannot rely on the previous SUBSLICE_MASK getparam to tell userspace what subslices are available. Here we introduce a more detailed way of querying the G

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Keep GuC log disabled by default

2018-01-19 Thread Patchwork
== Series Details == Series: drm/i915/guc: Keep GuC log disabled by default URL : https://patchwork.freedesktop.org/series/36796/ State : success == Summary == Series 36796v1 drm/i915/guc: Keep GuC log disabled by default https://patchwork.freedesktop.org/api/1.0/series/36796/revisions/1/mbox/

[Intel-gfx] [PATCH 1/2] drm/i915: Track the number of times we have woken the GPU up

2018-01-19 Thread Chris Wilson
By counting the number of times we have woken up, we have a very simple means of defining an epoch, which will come in handy if we want to perform deferred tasks at the end of an epoch (i.e. while we are going to sleep) without imposing on the next activity cycle. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 2/2] drm/i915: Shrink the GEM kmem_caches upon idling

2018-01-19 Thread Chris Wilson
When we finally decide the gpu is idle, that is a good time to shrink our kmem_caches. v3: Defer until an rcu grace period after we idle. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c | 65 + 1 file changed, 65 insert

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: expose RCS topology to userspace

2018-01-19 Thread Patchwork
== Series Details == Series: drm/i915: expose RCS topology to userspace URL : https://patchwork.freedesktop.org/series/36793/ State : success == Summary == Series 36793v1 drm/i915: expose RCS topology to userspace https://patchwork.freedesktop.org/api/1.0/series/36793/revisions/1/mbox/ Test d

[Intel-gfx] ✗ Fi.CI.BAT: failure for Per-context and per-client engine busyness (rev2)

2018-01-19 Thread Patchwork
== Series Details == Series: Per-context and per-client engine busyness (rev2) URL : https://patchwork.freedesktop.org/series/32645/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix up the CCS code (rev3)

2018-01-19 Thread Patchwork
== Series Details == Series: drm/i915: Fix up the CCS code (rev3) URL : https://patchwork.freedesktop.org/series/29308/ State : failure == Summary == Applying: drm/i915: Add a comment exlaining CCS hsub/vsub Applying: drm/i915: Nuke a pointless unreachable() Using index info to reconstruct a b

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: add support for specifying DMC firmware override by module param (rev2)

2018-01-19 Thread Patchwork
== Series Details == Series: drm/i915: add support for specifying DMC firmware override by module param (rev2) URL : https://patchwork.freedesktop.org/series/34157/ State : failure == Summary == Test gem_eio: Subgroup in-flight-suspend: pass -> FAIL (shard-

Re: [Intel-gfx] [PATCH v2] drm/i915/edp: Do not do link training fallback or prune modes on EDP

2018-01-19 Thread Imre Deak
On Thu, Oct 12, 2017 at 12:13:38PM -0700, Manasi Navare wrote: > In case of eDP because the panel has a fixed mode, the link rate > and lane count at which it is trained corresponds to the link BW > required to support the native resolution of the panel. In case of > panles with lower resolutions w

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Shrink the request kmem_cache on allocation error

2018-01-19 Thread Patchwork
== Series Details == Series: drm/i915: Shrink the request kmem_cache on allocation error URL : https://patchwork.freedesktop.org/series/36800/ State : success == Summary == Series 36800v1 drm/i915: Shrink the request kmem_cache on allocation error https://patchwork.freedesktop.org/api/1.0/seri

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Track the number of times we have woken the GPU up

2018-01-19 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Track the number of times we have woken the GPU up URL : https://patchwork.freedesktop.org/series/36802/ State : success == Summary == Series 36802v1 series starting with [1/2] drm/i915: Track the number of times we have woken

Re: [Intel-gfx] [PATCH v5] drm/i915/icl: Enhanced execution list support

2018-01-19 Thread Daniele Ceraolo Spurio
On 19/01/18 05:05, Mika Kuoppala wrote: Daniele Ceraolo Spurio writes: From: Thomas Daniel Enhanced Execlists is an upgraded version of execlists which supports up to 8 ports. The lrcs to be submitted are written to a submit queue, which is then loaded on the HW. When writing to the ELSP r

[Intel-gfx] [PATCH v5 1/6] drm/i915: Track per-context engine busyness

2018-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some customers want to know how much of the GPU time are their clients using in order to make dynamic load balancing decisions. With the hooks already in place which track the overall engine busyness, we can extend that slightly to split that time between contexts. v2: Fix

Re: [Intel-gfx] [PATCH 6/8] drm/i915/icp: Add backlight Support for ICP

2018-01-19 Thread Paulo Zanoni
Em Qui, 2018-01-11 às 15:57 -0800, Rodrigo Vivi escreveu: > On Thu, Jan 11, 2018 at 09:48:57PM +, James Ausmus wrote: > > On Thu, Jan 11, 2018 at 04:00:08PM -0200, Paulo Zanoni wrote: > > > From: Anusha Srivatsa > > > > > > ICP has two backlight controllers - similar to previous platforms > >

Re: [Intel-gfx] [RFC] perf: Allow fine-grained PMU access control

2018-01-19 Thread Peter Zijlstra
On Thu, Jan 18, 2018 at 06:40:07PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > For situations where sysadmins might want to allow different level of > of access control for different PMUs, we start creating per-PMU > perf_event_paranoid controls in sysfs. You've completely and utterl

[Intel-gfx] ✗ Fi.CI.BAT: failure for Per-context and per-client engine busyness (rev3)

2018-01-19 Thread Patchwork
== Series Details == Series: Per-context and per-client engine busyness (rev3) URL : https://patchwork.freedesktop.org/series/32645/ State : failure == Summary == Series 32645v3 Per-context and per-client engine busyness https://patchwork.freedesktop.org/api/1.0/series/32645/revisions/3/mbox/

Re: [Intel-gfx] [RFC] perf: Allow fine-grained PMU access control

2018-01-19 Thread Tvrtko Ursulin
Hi, On 19/01/2018 16:45, Peter Zijlstra wrote: On Thu, Jan 18, 2018 at 06:40:07PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin For situations where sysadmins might want to allow different level of of access control for different PMUs, we start creating per-PMU perf_event_paranoid contro

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Downgrade incorrect engine constructor usage warnings to development

2018-01-19 Thread Michel Thierry
On 1/19/2018 2:00 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Render engine constructor helpers must only be called from the render engine constructors, but there is no need to burden the production binaries with warnings which can only be triggered during development. Signed-off-by: Tvrtko

Re: [Intel-gfx] [PATCH 6/8] drm/i915/icp: Add backlight Support for ICP

2018-01-19 Thread Anusha Srivatsa
On Fri, Jan 19, 2018 at 02:40:41PM -0200, Paulo Zanoni wrote: > Em Qui, 2018-01-11 às 15:57 -0800, Rodrigo Vivi escreveu: > > On Thu, Jan 11, 2018 at 09:48:57PM +, James Ausmus wrote: > > > On Thu, Jan 11, 2018 at 04:00:08PM -0200, Paulo Zanoni wrote: > > > > From: Anusha Srivatsa > > > > > >

Re: [Intel-gfx] [PATCH 07/27] drm/i915/icl: Interrupt handling

2018-01-19 Thread Tvrtko Ursulin
On 10/01/2018 10:16, Joonas Lahtinen wrote: On Tue, 2018-01-09 at 21:23 -0200, Paulo Zanoni wrote: From: Tvrtko Ursulin v2: Rebase. v3: * Remove DPF, it has been removed from SKL+. * Fix -internal rebase wrt. execlists interrupt handling. v4: Rebase. v5: * Updated for POR changes.

Re: [Intel-gfx] [PATCH 6/8] drm/i915/icp: Add backlight Support for ICP

2018-01-19 Thread Rodrigo Vivi
On Fri, Jan 19, 2018 at 05:26:02PM +, Anusha Srivatsa wrote: > On Fri, Jan 19, 2018 at 02:40:41PM -0200, Paulo Zanoni wrote: > > Em Qui, 2018-01-11 às 15:57 -0800, Rodrigo Vivi escreveu: > > > On Thu, Jan 11, 2018 at 09:48:57PM +, James Ausmus wrote: > > > > On Thu, Jan 11, 2018 at 04:00:08

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Avoid leaking lpe audio platdev.data

2018-01-19 Thread Patchwork
== Series Details == Series: drm/i915: Avoid leaking lpe audio platdev.data URL : https://patchwork.freedesktop.org/series/35151/ State : failure == Summary == Test perf: Subgroup buffer-fill: pass -> FAIL (shard-apl) fdo#103755 Subgroup enable-disab

Re: [Intel-gfx] [PATCH 07/27] drm/i915/icl: Interrupt handling

2018-01-19 Thread Paulo Zanoni
Em Sex, 2018-01-19 às 17:30 +, Tvrtko Ursulin escreveu: > On 10/01/2018 10:16, Joonas Lahtinen wrote: > > On Tue, 2018-01-09 at 21:23 -0200, Paulo Zanoni wrote: > > > From: Tvrtko Ursulin > > > > > > v2: Rebase. > > > > > > v3: > > >* Remove DPF, it has been removed from SKL+. > > >*

Re: [Intel-gfx] [PATCH 6/8] drm/i915/icp: Add backlight Support for ICP

2018-01-19 Thread James Ausmus
On Fri, Jan 19, 2018 at 09:26:02AM -0800, Anusha Srivatsa wrote: > On Fri, Jan 19, 2018 at 02:40:41PM -0200, Paulo Zanoni wrote: > > Em Qui, 2018-01-11 às 15:57 -0800, Rodrigo Vivi escreveu: > > > On Thu, Jan 11, 2018 at 09:48:57PM +, James Ausmus wrote: > > > > On Thu, Jan 11, 2018 at 04:00:08

Re: [Intel-gfx] [PATCH 6/8] drm/i915/icp: Add backlight Support for ICP

2018-01-19 Thread Paulo Zanoni
Em Sex, 2018-01-19 às 09:56 -0800, Rodrigo Vivi escreveu: > On Fri, Jan 19, 2018 at 05:26:02PM +, Anusha Srivatsa wrote: > > On Fri, Jan 19, 2018 at 02:40:41PM -0200, Paulo Zanoni wrote: > > > Em Qui, 2018-01-11 às 15:57 -0800, Rodrigo Vivi escreveu: > > > > On Thu, Jan 11, 2018 at 09:48:57PM +

Re: [Intel-gfx] [PATCH 6/8] drm/i915/icp: Add backlight Support for ICP

2018-01-19 Thread Srivatsa, Anusha
>-Original Message- >From: Zanoni, Paulo R >Sent: Friday, January 19, 2018 10:25 AM >To: Vivi, Rodrigo ; Srivatsa, Anusha > >Cc: Ausmus, James ; Nikula, Jani >; intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH 6/8] drm/i915/icp: Add backlight Support for >ICP > >Em Sex, 2

[Intel-gfx] [PATCH] drm/i915: Implement display w/a #1143

2018-01-19 Thread Ville Syrjala
From: Ville Syrjälä Apparently SKL/KBL need some manual help to get the programmed HDMI vswing to stick. Implement the relevant workaround (display w/a #1143). Note that the relevant chicken bits live in a transcoder register even though the bits affect a specific DDI port rather than a specific

[Intel-gfx] [PATCH 6/8] drm/i915/icp: Add backlight Support for ICP

2018-01-19 Thread Paulo Zanoni
From: Anusha Srivatsa ICP has two backlight controllers - similar to previous platforms like BXT -, but we only use one controller for now, so we can just reuse the CNP code. v2: Remove the usage of ICP_SECOND_PPS_BACKLIGHT register.(Jani) Reuse CNP code since it is very similar.(Ville) v3 (from

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Implement display w/a #1143

2018-01-19 Thread Patchwork
== Series Details == Series: drm/i915: Implement display w/a #1143 URL : https://patchwork.freedesktop.org/series/36813/ State : success == Summary == Series 36813v1 drm/i915: Implement display w/a #1143 https://patchwork.freedesktop.org/api/1.0/series/36813/revisions/1/mbox/ Test debugfs_tes

[Intel-gfx] [PATCH v3] drm/i915/icl: Set graphics mode register for gen11

2018-01-19 Thread Kelvin Gardiner
This patch clears a single bit. The bit is 0 by default but expected not to be set. Explicitly clearing the bit in this patch is intended to indicate some thinking has occurred, and that we want this bit cleared and we are not just excepting the default value. v2 (from Paulo): fix indentation. v3:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Keep GuC log disabled by default

2018-01-19 Thread Patchwork
== Series Details == Series: drm/i915/guc: Keep GuC log disabled by default URL : https://patchwork.freedesktop.org/series/36796/ State : failure == Summary == Warning: bzip CI_DRM_3658/shard-glkb6/results22.json.bz2 wasn't in correct JSON format Test pm_rps: Subgroup reset:

Re: [Intel-gfx] [PATCH 6/8] drm/i915/icp: Add backlight Support for ICP

2018-01-19 Thread Ausmus, James
On Fri, Jan 19, 2018 at 10:48 AM, Paulo Zanoni wrote: > > From: Anusha Srivatsa > > ICP has two backlight controllers - similar to previous platforms like > BXT -, but we only use one controller for now, so we can just reuse > the CNP code. > > v2: Remove the usage of ICP_SECOND_PPS_BACKLIGHT reg

[Intel-gfx] ✓ Fi.CI.BAT: success for ICP initial support (rev2)

2018-01-19 Thread Patchwork
== Series Details == Series: ICP initial support (rev2) URL : https://patchwork.freedesktop.org/series/36350/ State : success == Summary == Series 36350v2 ICP initial support https://patchwork.freedesktop.org/api/1.0/series/36350/revisions/2/mbox/ Test debugfs_test: Subgroup read_all_

Re: [Intel-gfx] [PATCH 6/8] drm/i915/icp: Add backlight Support for ICP

2018-01-19 Thread Rodrigo Vivi
On Fri, Jan 19, 2018 at 06:48:12PM +, Paulo Zanoni wrote: > From: Anusha Srivatsa > > ICP has two backlight controllers - similar to previous platforms like > BXT -, but we only use one controller for now, so we can just reuse > the CNP code. > > v2: Remove the usage of ICP_SECOND_PPS_BACKLI

Re: [Intel-gfx] [PATCH] drm/i915: Implement display w/a #1143

2018-01-19 Thread Rodrigo Vivi
On Fri, Jan 19, 2018 at 06:45:49PM +, Ville Syrjala wrote: > From: Ville Syrjälä > > Apparently SKL/KBL need some manual help to get the > programmed HDMI vswing to stick. Implement the relevant > workaround (display w/a #1143). > > Note that the relevant chicken bits live in a transcoder re

Re: [Intel-gfx] [PATCH 0/8] ICP initial support

2018-01-19 Thread Paulo Zanoni
Em Qui, 2018-01-11 às 16:00 -0200, Paulo Zanoni escreveu: > Hi > > This series adds the initial support for ICP. No conflicts with the > other > series. Patches 1 and 2 are parts of other series that we've already > been > discussing on this mailing list, but I put them here so CI can do the > rig

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: expose RCS topology to userspace

2018-01-19 Thread Patchwork
== Series Details == Series: drm/i915: expose RCS topology to userspace URL : https://patchwork.freedesktop.org/series/36793/ State : success == Summary == Warning: bzip CI_DRM_3658/shard-glkb6/results22.json.bz2 wasn't in correct JSON format Test perf: Subgroup oa-exponents:

Re: [Intel-gfx] [PATCH 07/27] drm/i915/icl: Interrupt handling

2018-01-19 Thread Chris Wilson
Quoting Paulo Zanoni (2018-01-19 18:10:51) > Em Sex, 2018-01-19 às 17:30 +, Tvrtko Ursulin escreveu: > > On 10/01/2018 10:16, Joonas Lahtinen wrote: > > > If these are in a later patch, should be squashed here. > > > > It might be possible in some cases, or it might be quite challenging > > in

Re: [Intel-gfx] [PATCH] drm/i915: Implement display w/a #1143

2018-01-19 Thread Runyan, Arthur J
Yes, this applies to CFL also. CFL follows on from KBL and doesn't have any display changes, so for the workarounds you can translate KBL:All to CFL:All. There is a note about that. -Original Message- From: Vivi, Rodrigo Sent: Friday, 19 January, 2018 12:08 PM To: Ville Syrjala Cc: i

Re: [Intel-gfx] [RFC] drm/i915/guc: Keep GuC log disabled by default

2018-01-19 Thread Chris Wilson
Quoting Michał Winiarski (2018-01-19 13:36:27) > On Fri, Jan 19, 2018 at 12:49:26PM +, Michal Wajdeczko wrote: > > It looks that GuC log functionality is not fully functional yet and > > causes issues when enabled by auto(-1) modparam on debug builds. > > > > [ 30.062893] ===

Re: [Intel-gfx] [PATCH] drm/i915: vbt defs typo fixes

2018-01-19 Thread Adam Jackson
On Fri, 2018-01-19 at 10:17 +0200, Jani Nikula wrote: > On Thu, 18 Jan 2018, Adam Jackson wrote: > > On Thu, 2018-01-18 at 17:06 +0200, Jani Nikula wrote: > > > No more sing-a-ling. > > > > > > Reported-by: Adam Jackson > > > > Why'd you omit the typos I reported in tools/intel_vbt_decode.c ? >

Re: [Intel-gfx] [PATCH v5 1/6] drm/i915: Track per-context engine busyness

2018-01-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-01-19 16:26:16) > From: Tvrtko Ursulin > > Some customers want to know how much of the GPU time are their clients > using in order to make dynamic load balancing decisions. > > With the hooks already in place which track the overall engine busyness, > we can extend t

  1   2   >