Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio

2017-12-11 Thread Anand, Jerome
> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Saturday, December 9, 2017 4:22 AM > To: Ville Syrjälä > Cc: Chen, Augustine ; intel- > g...@lists.freedesktop.org; alsa-de...@alsa-project.org; Anand, Jerome > ; Bossart, Pierre-louis louis.boss...@intel.c

[Intel-gfx] [PATCH igt] igt/kms_vblank: To set a mode requires DRM_MASTER

2017-12-11 Thread Chris Wilson
Fixes: ba86514759c6 ("kms_vblank: Switch from using crtc0 statically to explicitly setting mode.") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104208 Signed-off-by: Chris Wilson --- tests/kms_vblank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_vblank

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove debugfs/i915_seqno_info

2017-12-11 Thread Joonas Lahtinen
On Sat, 2017-12-09 at 10:44 +, Chris Wilson wrote: > The per-engine seqno info is now available from > debugfs/i915_engine_info obsoleting debugfs/i915_seqno_info, so remove it. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Tec

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Stop showing seqno info from debugfs/i915_interrupt_info

2017-12-11 Thread Joonas Lahtinen
On Sat, 2017-12-09 at 10:44 +, Chris Wilson wrote: > Since the seqno information shown from i915_interrupt_info is just a > small subset of i915_engine_info, remove it. > > Signed-off-by: Chris Wilson One comment below. Reviewed-by: Joonas Lahtinen > +++ b/drivers/gpu/drm/i915/intel_engin

Re: [Intel-gfx] [PATCH igt] igt/drv_module_reload: Keep injecting load

2017-12-11 Thread Joonas Lahtinen
On Fri, 2017-12-08 at 22:50 +, Chris Wilson wrote: > Keep reloading the module with the next load failure until we run out of > injection sites and the module loads successfully. Or it goes boom. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtin

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-11 Thread Daniel Vetter
On Fri, Dec 08, 2017 at 11:54:19AM +0100, Peter Zijlstra wrote: > On Thu, Dec 07, 2017 at 11:08:49AM +0100, Daniel Vetter wrote: > > Since -rc1 we're hitting a bunch of lockdep splats using the new > > cross-release stuff around the 2 kthread completions. In all cases > > they are because totally i

Re: [Intel-gfx] [PATCH] drm/i915/gvt/fb_decoder: Fix out-of-bounds read

2017-12-11 Thread Zhenyu Wang
On 2017.12.09 00:37:59 -0600, Gustavo A. R. Silva wrote: > In case function skl_format_to_drm returns -EINVAL, fmt turns into a huge > number as fmt is of type u32, hence there is an out-of-bounds read when > using fmt as an index for array skl_pixel_formats at line 225: > plane->bpp = skl_pixel_fo

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915/guc: Move GuC WOPCM related code into separate files

2017-12-11 Thread Joonas Lahtinen
On Fri, 2017-12-08 at 13:41 -0800, Jackie Li wrote: > intel_guc_reg.h should only include definition for GuC registers > and related register bits. GuC WOPCM related values should not > be defined in intel_guc_reg.h > > This patch creates a better file structure by moving GuC WOPCM > related defin

Re: [Intel-gfx] [PATCH] drm/i915: Use copy_from_user() in fence copying

2017-12-11 Thread Joonas Lahtinen
On Wed, 2017-12-06 at 12:28 -0800, Kees Cook wrote: > There's no good reason to separate the access_ok() from the copy, > especially since the access_ok() size is hard-coded instead of using > sizeof(). Instead, just use copy_from_user() directly. > > Fixes: cf6e7bac6357 ("drm/i915: Add support fo

Re: [Intel-gfx] [PATCH igt] tests: Use igt_device_set_master

2017-12-11 Thread Joonas Lahtinen
On Fri, 2017-12-08 at 18:11 +, Chris Wilson wrote: > A few tests only require DRM_MASTER privileges for a subset of gen or > tests, and so open the device as normal and conditionally call > drmSetMaster. Translate these over to using igt_device_set_master(), > which includes a bit more debuggin

Re: [Intel-gfx] [PATCH] drm/i915: Use copy_from_user() in fence copying

2017-12-11 Thread David Laight
From: Kees Cook > Sent: 08 December 2017 21:10 > >> There's no good reason to separate the access_ok() from the copy, > >> especially since the access_ok() size is hard-coded instead of using > >> sizeof(). Instead, just use copy_from_user() directly. > > > > Looks like an optimisation to save doin

Re: [Intel-gfx] [GIT pull] x86 APIC updates for 4.15

2017-12-11 Thread Daniel Vetter
On Wed, Dec 06, 2017 at 12:13:27PM +0100, Maarten Lankhorst wrote: > Hey, > > Op 30-11-17 om 23:47 schreef Thomas Gleixner: > > On Thu, 30 Nov 2017, Maarten Lankhorst wrote: > >> Op 30-11-17 om 10:18 schreef Thomas Gleixner: > >> # cat /sys/kernel/debug/irq/irqs/28 > >> handler: handle_edge_irq

Re: [Intel-gfx] [PATCH] x86/gpu: add CFL to early quirks

2017-12-11 Thread Joonas Lahtinen
On Fri, 2017-12-08 at 10:47 -0800, Lucas De Marchi wrote: > CFL was missing from intel_early_ids[]. > > Cc: Ingo Molnar > Cc: H. Peter Anvin > Cc: Thomas Gleixner > Cc: x...@kernel.org > Cc: Rodrigo Vivi > Signed-off-by: Lucas De Marchi This should come with a Fixes: line to be picked up to

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel-fixes tree

2017-12-11 Thread Joonas Lahtinen
+ GVT folks. On Fri, 2017-12-08 at 09:15 +1100, Stephen Rothwell wrote: > Hi all, > > Commit > > 365ad5df9caa ("drm/i915/gvt: Export > intel_gvt_render_mmio_to_ring_id()") > > is missing a Signed-off-by from its committer. > -- Joonas Lahtinen Open Source Technology Center Intel Corporation

[Intel-gfx] [PATCH] drm: Give the DRM device's anon_inode a unique lockclass for its mmap_rswem

2017-12-11 Thread Chris Wilson
Teach lockdep to track the device's internal mmapping separately from the generic lockclass over all other inodes. Since this is device private we wish to allow a different locking hierarchy than is typified by the requirement for the mmap_rwsem being the outermost lock for handling pagefaults. By

[Intel-gfx] [PATCH i-g-t 2/2] [CI] h4x: Run new kms_rotation_crc tests on BAT machines

2017-12-11 Thread Petri Latvala
--- tests/intel-ci/fast-feedback.testlist | 315 +++--- 1 file changed, 21 insertions(+), 294 deletions(-) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index f71a16bc..c3037aa3 100644 --- a/tests/intel-ci/fast-feedback.tes

[Intel-gfx] [PATCH i-g-t 1/2] [CI] igt/kms_rotation_crc: Add horizontal flip subtest.

2017-12-11 Thread Petri Latvala
From: Joseph Garvey Test that horizontal flip works with supported rotations. Includes a fix for the unrotated fb which was not being positioned correctly with portrait and landscape rectangles. v2:(from Anusha) - Change 180 degree rotation to follow the rest, use igt_swap(), make flip variable

Re: [Intel-gfx] [PATCH v6 0/5] drm/i915: Expose more GPU properties through sysfs

2017-12-11 Thread Joonas Lahtinen
+ Daniel, Chris On Thu, 2017-12-07 at 09:21 +, Tvrtko Ursulin wrote: > On 04/12/2017 15:02, Lionel Landwerlin wrote: > > Hi, > > > > After discussion with Chris, Joonas & Tvrtko, this series adds an > > additional commit to link the render node back to the card through a > > symlink. Making i

Re: [Intel-gfx] [PATCH] agp/intel: Flush all chipset writes after updating the GGTT

2017-12-11 Thread Joonas Lahtinen
On Fri, 2017-12-08 at 21:46 +, Chris Wilson wrote: > Before accessing the GGTT we must flush the PTE writes and make them > visible to the chipset, or else the indirect access may end up in the > wrong page. In commit 3497971a71d8 ("agp/intel: Flush chipset writes > after updating a single PTE"

Re: [Intel-gfx] [PATCH 0/3] mmio save restore refine in vgpu switch

2017-12-11 Thread Joonas Lahtinen
Seems like you intended to send to gvt mailing list? Regards, Joonas On Thu, 2017-12-07 at 12:34 +0800, Weinan Li wrote: > Merge switch_mmio_to_vgpu and switch_mmio_to_host, use delta update for > mocs save restore, deal host mocs value as fixed, it won't be changed after > initialization. These

Re: [Intel-gfx] [PATCH v2 2/2] kms_content_protection: Add Content Protection test

2017-12-11 Thread Ramalingam C
On Thursday 07 December 2017 05:47 AM, Sean Paul wrote: Pretty simple test: - initializes the output - clears the content protection property - verifies that it clears - sets the content protection property to desired - verifies that it transitions to enabled Does this for both legacy and atom

Re: [Intel-gfx] [GIT pull] x86 APIC updates for 4.15

2017-12-11 Thread Thomas Gleixner
On Mon, 11 Dec 2017, Daniel Vetter wrote: > Anything else we can do to move this? I just had to resolve a small > conflict when moving forward to -rc3. Carrying a revert for the entire > apic pull (too many deps to just revert the bisected patch) is a bit > annoying. https://lkml.kernel.org/r/al

Re: [Intel-gfx] [PATCH] agp/intel: Flush all chipset writes after updating the GGTT

2017-12-11 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-12-11 10:55:40) > On Fri, 2017-12-08 at 21:46 +, Chris Wilson wrote: > > Before accessing the GGTT we must flush the PTE writes and make them > > visible to the chipset, or else the indirect access may end up in the > > wrong page. In commit 3497971a71d8 ("agp/inte

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for agp/intel: Flush all chipset writes after updating the GGTT

2017-12-11 Thread Chris Wilson
Quoting Patchwork (2017-12-09 00:25:53) > == Series Details == > > Series: agp/intel: Flush all chipset writes after updating the GGTT > URL : https://patchwork.freedesktop.org/series/35119/ > State : warning > > == Summary == > > Test kms_draw_crc: > Subgroup draw-method-rgb565-mmap-w

Re: [Intel-gfx] [PATCH igt 2/2] igt/debugfs_tests: Record which file is being opened in kmsg

2017-12-11 Thread Joonas Lahtinen
On Wed, 2017-12-06 at 17:02 +, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2017-12-06 16:51:24) > > > > If I may suggest an alternative - timestamp igt messages and write a log > > interleaver to be used with kernel log and igt log as inputs? > > How do you get igt_log over netconsole? Wi

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Stop showing seqno info from debugfs/i915_interrupt_info

2017-12-11 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-12-11 09:08:53) > On Sat, 2017-12-09 at 10:44 +, Chris Wilson wrote: > > Since the seqno information shown from i915_interrupt_info is just a > > small subset of i915_engine_info, remove it. > > > > Signed-off-by: Chris Wilson > > One comment below. > > Reviewe

Re: [Intel-gfx] [PATCH igt 2/2] igt/debugfs_tests: Record which file is being opened in kmsg

2017-12-11 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-12-11 11:02:27) > On Wed, 2017-12-06 at 17:02 +, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-12-06 16:51:24) > > > > > > If I may suggest an alternative - timestamp igt messages and write a log > > > interleaver to be used with kernel log and igt log as

Re: [Intel-gfx] [GIT pull] x86 APIC updates for 4.15

2017-12-11 Thread Thomas Gleixner
On Mon, 11 Dec 2017, Thomas Gleixner wrote: > On Mon, 11 Dec 2017, Daniel Vetter wrote: > > Anything else we can do to move this? I just had to resolve a small > > conflict when moving forward to -rc3. Carrying a revert for the entire > > apic pull (too many deps to just revert the bisected patch)

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Add CCS capability for sprites

2017-12-11 Thread Mika Kahola
On Thu, 2017-08-24 at 22:10 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Allow sprites to scan out compressed framebuffers. > > Since different platforms have a different set of planes that > support CCS let's add a small helper to determine whether a > specific plane su

[Intel-gfx] [PATCH v3] drm/i915: Unwind i915_gem_init() failure

2017-12-11 Thread Chris Wilson
Since Michal introduced new errors other than -EIO during i915_gem_init(), we need to actually unwind on the error path as we have to abort the module load (and we expect to do so cleanly!). As we now teardown key state and then mark the driver as wedged (on EIO), we have to be careful to not allo

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Free mock_i915->drm.mode_config

2017-12-11 Thread Matthew Auld
On 9 December 2017 at 21:08, Chris Wilson wrote: > Even for the mock i915 device, we need to initialise the > drm.mode_config, as we may ultimately query whether there are any KMS > users deep in the bowels of some paths (e.g. eviction). As we initialise > drm.mode_config we must cleanup after our

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Free mock_i915->drm.mode_config

2017-12-11 Thread Chris Wilson
Quoting Matthew Auld (2017-12-11 11:20:24) > On 9 December 2017 at 21:08, Chris Wilson wrote: > > Even for the mock i915 device, we need to initialise the > > drm.mode_config, as we may ultimately query whether there are any KMS > > users deep in the bowels of some paths (e.g. eviction). As we ini

[Intel-gfx] [PATCH igt] lib: Ask the kernel to quiesce the GPU

2017-12-11 Thread Chris Wilson
Since the introduction of debugfs/i915_drop_caches, we have offered the ability to wait upon all outstanding batches. This is more efficient and less error prone (one example is the use of context priorities, we have to idle at the lowest in order not to jump over any low priority tasks we want to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Give the DRM device's anon_inode a unique lockclass for its mmap_rswem

2017-12-11 Thread Patchwork
== Series Details == Series: drm: Give the DRM device's anon_inode a unique lockclass for its mmap_rswem URL : https://patchwork.freedesktop.org/series/35171/ State : success == Summary == Series 35171v1 drm: Give the DRM device's anon_inode a unique lockclass for its mmap_rswem https://patc

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Add CCS capability for sprites

2017-12-11 Thread Daniel Stone
Hi Mika, On 11 December 2017 at 11:11, Mika Kahola wrote: > On Thu, 2017-08-24 at 22:10 +0300, ville.syrj...@linux.intel.com wrote: >> Allow sprites to scan out compressed framebuffers. >> >> Since different platforms have a different set of planes that >> support CCS let's add a small helper to

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Add CCS capability for sprites

2017-12-11 Thread Mika Kahola
On Mon, 2017-12-11 at 12:00 +, Daniel Stone wrote: > Hi Mika, > > On 11 December 2017 at 11:11, Mika Kahola > wrote: > > > > On Thu, 2017-08-24 at 22:10 +0300, ville.syrj...@linux.intel.com > > wrote: > > > > > > Allow sprites to scan out compressed framebuffers. > > > > > > Since differen

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for igt_fb: Add support for drawing to non-32bit Y/Yf tiled FBs

2017-12-11 Thread Imre Deak
On Fri, Dec 08, 2017 at 05:43:31PM +, Patchwork wrote: > == Series Details == > > Series: igt_fb: Add support for drawing to non-32bit Y/Yf tiled FBs > URL : https://patchwork.freedesktop.org/series/35093/ > State : warning Thanks for the review, pushed to igt. > > == Summary == > > Test

[Intel-gfx] [PATCH 0/8] make stolen resource centric

2017-12-11 Thread Matthew Auld
Continuation of Paulo' stolen series[1], addressing the feedback from Joonas and Chris. [1] https://patchwork.freedesktop.org/series/30923/ Joonas Lahtinen (1): x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit Matthew Auld (7): x86/early-quirks: replace the magica

[Intel-gfx] [PATCH 3/8] drm/i915: nuke the duplicated stolen discovery

2017-12-11 Thread Matthew Auld
We duplicate the stolen discovery code in early-quirks and in i915, however now that the stolen region is exported as a resource from early-quirks we can nuke the duplication. v2: check overflows_type Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni Reviewed-b

[Intel-gfx] [PATCH 1/8] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-12-11 Thread Matthew Auld
From: Joonas Lahtinen To give upcoming SKU BIOSes more flexibility in placing the Intel graphics stolen memory, make all variables storing the placement or size compatible with full 64 bit range. Also by exporting the stolen region as a resource, we can then nuke the duplicated stolen discovery i

[Intel-gfx] [PATCH 2/8] x86/early-quirks: replace the magical increment start values

2017-12-11 Thread Matthew Auld
Replace the magical +2, +9 etc. with +MB, which is far easier to read. Suggested-by: Ville Syrjälä Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris Wilson Cc: Paulo Zanoni Cc: Thomas Gleixner Cc: Ingo Molnar Cc: H. Peter Anvin Cc: x...@kernel.org Cc: linux-ker..

[Intel-gfx] [PATCH 4/8] drm/i915: make dsm struct resource centric

2017-12-11 Thread Matthew Auld
Now that we are using struct resource to track the stolen region, it is more convenient if we track dsm in a resource as well. v2: check range_overflow when writing to 32b registers (Chris) pepper in some comments (Chris) v3: refit i915_stolen_to_dma() v4: kill ggtt->stolen_size v5: some more

[Intel-gfx] [PATCH 7/8] drm/i915: give stolen_usable_size a more suitable home

2017-12-11 Thread Matthew Auld
Kick it out of i915_ggtt and keep it grouped with dsm and dsm_reserved, where it makes the most sense. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h| 13 - drivers/gpu/drm/i9

[Intel-gfx] [PATCH 5/8] drm/i915: make reserved struct resource centric

2017-12-11 Thread Matthew Auld
Now that we are using struct resource to track the stolen region, it is more convenient if we track the reserved portion of that region in a resource as well. v2: s/<= end + 1/< end/ (Chris) v3: prefer DEFINE_RES_MEM Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Za

[Intel-gfx] [PATCH 8/8] drm/i915: prefer resource_size_t for everything stolen

2017-12-11 Thread Matthew Auld
Keeps things consistent now that we make use of struct resource. This should keep us covered in case we ever get huge amounts of stolen memory. v2: bunch of missing conversions (Chris) Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni Reviewed-by: Chris Wilson

[Intel-gfx] [PATCH 6/8] drm/i915: make mappable struct resource centric

2017-12-11 Thread Matthew Auld
Now that we are using struct resource to track the stolen region, it is more convenient if we track the mappable region in a resource as well. v2: prefer iomap and gmadr naming scheme prefer DEFINE_RES_MEM Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni R

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/kms_vblank: To set a mode requires DRM_MASTER

2017-12-11 Thread Patchwork
== Series Details == Series: igt/kms_vblank: To set a mode requires DRM_MASTER URL : https://patchwork.freedesktop.org/series/35165/ State : success == Summary == IGT patchset tested on top of latest successful build 0f3be861eb7456a87706b72216daa3ee7e4dde5b tests: Use igt_device_set_master wi

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Add CCS capability for sprites

2017-12-11 Thread Daniel Stone
Hi, On 11 December 2017 at 12:08, Mika Kahola wrote: > On Mon, 2017-12-11 at 12:00 +, Daniel Stone wrote: >> Did you manage to test this? When I tried, the DDB/watermark >> allocation was too conservative for sprites, and never allowed enough >> blocks to be able to use anything but linear or

[Intel-gfx] [PATCH igt] igt/pm_rps: Always allocate spin[0]

2017-12-11 Thread Chris Wilson
Avoid having to test for spin[0] existing by starting the load-loop with it allocated. References: https://bugs.freedesktop.org/show_bug.cgi?id=104060 Signed-off-by: Chris Wilson --- tests/pm_rps.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tes

Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro

2017-12-11 Thread Arnd Bergmann
On Tue, Mar 21, 2017 at 12:23 PM, Jani Nikula wrote: > On Tue, 21 Mar 2017, Daniel Vetter wrote: >> On Tue, Mar 21, 2017 at 09:44:07AM +0100, Arnd Bergmann wrote: >>> On Tue, Mar 21, 2017 at 9:26 AM, Jani Nikula >>> wrote: >>> > On Mon, 20 Mar 2017, Arnd Bergmann wrote: >>> >> The varargs macro

[Intel-gfx] [PATCH] [v2] drm/i915: use static const array for PICK macro

2017-12-11 Thread Arnd Bergmann
The varargs macro trick in _PIPE3/_PHY3/_PORT3 was meant as an optimization to shrink the i915 kernel module by around 1000 bytes. However, the downside is a size regression with CONFIG_KASAN, as I found from stack size warnings with gcc-7.0.1: before: drivers/gpu/drm/i915/intel_dpll_mgr.c: In fun

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Unwind i915_gem_init() failure (rev3)

2017-12-11 Thread Patchwork
== Series Details == Series: drm/i915: Unwind i915_gem_init() failure (rev3) URL : https://patchwork.freedesktop.org/series/35060/ State : success == Summary == Series 35060v3 drm/i915: Unwind i915_gem_init() failure https://patchwork.freedesktop.org/api/1.0/series/35060/revisions/3/mbox/ Tes

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Give the DRM device's anon_inode a unique lockclass for its mmap_rswem

2017-12-11 Thread Patchwork
== Series Details == Series: drm: Give the DRM device's anon_inode a unique lockclass for its mmap_rswem URL : https://patchwork.freedesktop.org/series/35171/ State : success == Summary == Test kms_cursor_crc: Subgroup cursor-128x128-onscreen: skip -> PASS

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Unwind i915_gem_init() failure (rev3)

2017-12-11 Thread Chris Wilson
Quoting Patchwork (2017-12-11 13:04:37) > == Series Details == > > Series: drm/i915: Unwind i915_gem_init() failure (rev3) > URL : https://patchwork.freedesktop.org/series/35060/ > State : success > > == Summary == > > Series 35060v3 drm/i915: Unwind i915_gem_init() failure > https://patchwork

[Intel-gfx] ✓ Fi.CI.IGT: success for igt/kms_vblank: To set a mode requires DRM_MASTER

2017-12-11 Thread Patchwork
== Series Details == Series: igt/kms_vblank: To set a mode requires DRM_MASTER URL : https://patchwork.freedesktop.org/series/35165/ State : success == Summary == Test kms_chv_cursor_fail: Subgroup pipe-a-256x256-top-edge: skip -> PASS (shard-snb) Test kms_p

[Intel-gfx] [PATCH i-g-t v9] tests/kms_frontbuffer_tracking: Including DRRS test coverage

2017-12-11 Thread Lohith BS
Dynamic Refresh Rate Switch(DRRS) is used to switch the panel's refresh rate to the lowest vrefresh supported by panel, when frame is not flipped for more than a Sec. In kernel, DRRS uses the front buffer tracking infrastructure. Hence DRRS test coverage is added along with other frontbuffer track

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio

2017-12-11 Thread Ville Syrjälä
On Mon, Dec 11, 2017 at 08:33:33AM +, Anand, Jerome wrote: > > > > -Original Message- > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > Sent: Saturday, December 9, 2017 4:22 AM > > To: Ville Syrjälä > > Cc: Chen, Augustine ; intel- > > g...@lists.freedesktop.org; alsa-de...@a

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio

2017-12-11 Thread Takashi Iwai
On Mon, 11 Dec 2017 14:20:23 +0100, Ville Syrjälä wrote: > > On Mon, Dec 11, 2017 at 08:33:33AM +, Anand, Jerome wrote: > > > > > > > -Original Message- > > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > > Sent: Saturday, December 9, 2017 4:22 AM > > > To: Ville Syrjälä > >

Re: [Intel-gfx] [PATCH 1/8] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-12-11 Thread Chris Wilson
Quoting Matthew Auld (2017-12-11 12:14:20) > From: Joonas Lahtinen > > To give upcoming SKU BIOSes more flexibility in placing the Intel > graphics stolen memory, make all variables storing the placement or size > compatible with full 64 bit range. Also by exporting the stolen region > as a resou

Re: [Intel-gfx] [PATCH v6 0/5] drm/i915: Expose more GPU properties through sysfs

2017-12-11 Thread Lionel Landwerlin
On 11/12/17 10:50, Joonas Lahtinen wrote: + Daniel, Chris On Thu, 2017-12-07 at 09:21 +, Tvrtko Ursulin wrote: On 04/12/2017 15:02, Lionel Landwerlin wrote: Hi, After discussion with Chris, Joonas & Tvrtko, this series adds an additional commit to link the render node back to the card thr

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Add CCS capability for sprites

2017-12-11 Thread Ville Syrjälä
On Mon, Dec 11, 2017 at 12:33:47PM +, Daniel Stone wrote: > Hi, > > On 11 December 2017 at 12:08, Mika Kahola wrote: > > On Mon, 2017-12-11 at 12:00 +, Daniel Stone wrote: > >> Did you manage to test this? When I tried, the DDB/watermark > >> allocation was too conservative for sprites, a

[Intel-gfx] ✓ Fi.CI.BAT: success for make stolen resource centric (rev7)

2017-12-11 Thread Patchwork
== Series Details == Series: make stolen resource centric (rev7) URL : https://patchwork.freedesktop.org/series/34256/ State : success == Summary == Series 34256v7 make stolen resource centric https://patchwork.freedesktop.org/api/1.0/series/34256/revisions/7/mbox/ Test debugfs_test:

Re: [Intel-gfx] [PATCH v2] drm/i915: Stop listening to request resubmission from the signaler kthread

2017-12-11 Thread Tvrtko Ursulin
On 08/12/2017 12:10, Chris Wilson wrote: The intent here was that we would be listening to i915_gem_request_unsubmit in order to cancel the signaler quickly and release the reference on the request. Cancelling the signaler is done directly via intel_engine_cancel_signaling (called from unsubmit)

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2,CI] igt/kms_rotation_crc: Add horizontal flip subtest.

2017-12-11 Thread Patchwork
== Series Details == Series: series starting with [1/2,CI] igt/kms_rotation_crc: Add horizontal flip subtest. URL : https://patchwork.freedesktop.org/series/35172/ State : success == Summary == IGT patchset tested on top of latest successful build 4d40a6776f08dd87b7e007da691b73d45a9bf1fa igt_

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Unwind i915_gem_init() failure (rev3)

2017-12-11 Thread Patchwork
== Series Details == Series: drm/i915: Unwind i915_gem_init() failure (rev3) URL : https://patchwork.freedesktop.org/series/35060/ State : failure == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-indfb-draw-pwrite: pass -> SKIP (shar

Re: [Intel-gfx] [PATCH v2] drm/i915: Stop listening to request resubmission from the signaler kthread

2017-12-11 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-11 14:19:47) > > On 08/12/2017 12:10, Chris Wilson wrote: > > The intent here was that we would be listening to > > i915_gem_request_unsubmit in order to cancel the signaler quickly and > > release the reference on the request. Cancelling the signaler is done > > di

Re: [Intel-gfx] [PATCH 1/8] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-12-11 Thread Joonas Lahtinen
Hi Ingo & Thomas, Now would be a great moment to slap the final Acked-bys (first two patches of this series) as the comments have been addressed and Reviewed-by was refreshed by Chris. I consider the series ready to be merged in this state. Once acked, I will then proceed to merge these through t

[Intel-gfx] [PATCH v3] drm/i915: Stop listening to request resubmission from the signaler kthread

2017-12-11 Thread Chris Wilson
The intent here was that we would be listening to i915_gem_request_unsubmit in order to cancel the signaler quickly and release the reference on the request. Cancelling the signaler is done directly via intel_engine_cancel_signaling (called from unsubmit), but that does not directly wake up the sig

[Intel-gfx] ✓ Fi.CI.BAT: success for lib: Ask the kernel to quiesce the GPU (rev5)

2017-12-11 Thread Patchwork
== Series Details == Series: lib: Ask the kernel to quiesce the GPU (rev5) URL : https://patchwork.freedesktop.org/series/31850/ State : success == Summary == IGT patchset tested on top of latest successful build 4d40a6776f08dd87b7e007da691b73d45a9bf1fa igt_fb: Add support for drawing to non-

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: use static const array for PICK macro (rev3)

2017-12-11 Thread Patchwork
== Series Details == Series: drm/i915: use static const array for PICK macro (rev3) URL : https://patchwork.freedesktop.org/series/21561/ State : success == Summary == Series 21561v3 drm/i915: use static const array for PICK macro https://patchwork.freedesktop.org/api/1.0/series/21561/revision

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/pm_rps: Always allocate spin[0]

2017-12-11 Thread Patchwork
== Series Details == Series: igt/pm_rps: Always allocate spin[0] URL : https://patchwork.freedesktop.org/series/35176/ State : success == Summary == IGT patchset tested on top of latest successful build 4d40a6776f08dd87b7e007da691b73d45a9bf1fa igt_fb: Add support for drawing to non-32bit Y/Yf

Re: [Intel-gfx] [PATCH 1/8] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-12-11 Thread Ingo Molnar
* Matthew Auld wrote: > From: Joonas Lahtinen > > To give upcoming SKU BIOSes more flexibility in placing the Intel > graphics stolen memory, make all variables storing the placement or size > compatible with full 64 bit range. Also by exporting the stolen region > as a resource, we can then n

Re: [Intel-gfx] [PATCH v6 0/5] drm/i915: Expose more GPU properties through sysfs

2017-12-11 Thread Tvrtko Ursulin
On 11/12/2017 10:50, Joonas Lahtinen wrote: + Daniel, Chris On Thu, 2017-12-07 at 09:21 +, Tvrtko Ursulin wrote: On 04/12/2017 15:02, Lionel Landwerlin wrote: Hi, After discussion with Chris, Joonas & Tvrtko, this series adds an additional commit to link the render node back to the card

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for lib: Ask the kernel to quiesce the GPU (rev5)

2017-12-11 Thread Chris Wilson
Quoting Patchwork (2017-12-11 14:36:03) > == Series Details == > > Series: lib: Ask the kernel to quiesce the GPU (rev5) > URL : https://patchwork.freedesktop.org/series/31850/ > State : success > > == Summary == > > IGT patchset tested on top of latest successful build > 4d40a6776f08dd87b7e00

Re: [Intel-gfx] [PATCH 2/8] x86/early-quirks: replace the magical increment start values

2017-12-11 Thread Ingo Molnar
* Matthew Auld wrote: > Replace the magical +2, +9 etc. with +MB, which is far easier to read. > > Suggested-by: Ville Syrjälä > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Ville Syrjälä > Cc: Chris Wilson > Cc: Paulo Zanoni > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: H. P

[Intel-gfx] ✗ Fi.CI.BAT: failure for lib: Ask the kernel to quiesce the GPU (rev5)

2017-12-11 Thread Patchwork
== Series Details == Series: lib: Ask the kernel to quiesce the GPU (rev5) URL : https://patchwork.freedesktop.org/series/31850/ State : failure == Summary == IGT patchset tested on top of latest successful build 4d40a6776f08dd87b7e007da691b73d45a9bf1fa igt_fb: Add support for drawing to non-

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Stop listening to request resubmission from the signaler kthread (rev3)

2017-12-11 Thread Patchwork
== Series Details == Series: drm/i915: Stop listening to request resubmission from the signaler kthread (rev3) URL : https://patchwork.freedesktop.org/series/35084/ State : success == Summary == Series 35084v3 drm/i915: Stop listening to request resubmission from the signaler kthread https:/

Re: [Intel-gfx] [PATCH v6 0/5] drm/i915: Expose more GPU properties through sysfs

2017-12-11 Thread Lionel Landwerlin
On 11/12/17 14:38, Tvrtko Ursulin wrote: On 11/12/2017 10:50, Joonas Lahtinen wrote: + Daniel, Chris On Thu, 2017-12-07 at 09:21 +, Tvrtko Ursulin wrote: On 04/12/2017 15:02, Lionel Landwerlin wrote: Hi, After discussion with Chris, Joonas & Tvrtko, this series adds an additional commit

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for lib: Ask the kernel to quiesce the GPU (rev5)

2017-12-11 Thread Chris Wilson
Quoting Chris Wilson (2017-12-11 14:39:09) > Quoting Patchwork (2017-12-11 14:36:03) > > == Series Details == > > > > Series: lib: Ask the kernel to quiesce the GPU (rev5) > > URL : https://patchwork.freedesktop.org/series/31850/ > > State : success > > > > == Summary == > > > > IGT patchset t

[Intel-gfx] [PATCH 2/4] drm/i915/guc: Move GuC workqueue allocations outside of the mutex

2017-12-11 Thread Michał Winiarski
This gets rid of the following lockdep splat: == WARNING: possible circular locking dependency detected 4.15.0-rc2-CI-Patchwork_7428+ #1 Not tainted -- debugfs_test/1351 is trying to acquire loc

[Intel-gfx] [PATCH 1/4] drm/i915/guc: Move shared data allocation away from submission path

2017-12-11 Thread Michał Winiarski
We need shared data for actions (e.g. guc suspend/resume), and we're using those with GuC submission disabled. Let's introduce intel_guc_init and move shared data alloc there. This fixes GPF during module unload with HuC, but without GuC submission: BUG: unable to handle kernel NULL pointer deref

[Intel-gfx] [PATCH 3/4] drm/i915/guc: Extract guc_init from guc_init_hw

2017-12-11 Thread Michał Winiarski
After GPU reset, GuC HW needs to be reinitialized (with FW reload). Unfortunately, we're doing some extra work there (mostly allocating stuff), work that can be moved to guc_init and called once at driver load time. As a side effect we're no longer hitting an assert in i915_ggtt_enable_guc on susp

[Intel-gfx] [PATCH 4/4] HAX Enable GuC Submission for CI

2017-12-11 Thread Michał Winiarski
--- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 792ce26d7449..9725c5ad8ac6 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++ b/drivers/gpu/drm/i915/i915_param

Re: [Intel-gfx] [PATCH 1/4] drm/i915/guc: Move shared data allocation away from submission path

2017-12-11 Thread Chris Wilson
Quoting Michał Winiarski (2017-12-11 15:12:53) > +int intel_guc_init(struct intel_guc *guc) > +{ > + struct drm_i915_private *dev_priv = guc_to_i915(guc); > + int ret; > + > + ret = guc_shared_data_create(guc); > + if (ret) > + return ret; > + GEM_BUG_ON(

[Intel-gfx] [PATCH v8 1/9] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-12-11 Thread Matthew Auld
From: Joonas Lahtinen To give upcoming SKU BIOSes more flexibility in placing the Intel graphics stolen memory, make all variables storing the placement or size compatible with full 64 bit range. Signed-off-by: Joonas Lahtinen Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä

[Intel-gfx] [PATCH v8 2/9] x86/early-quirks: export the stolen region as a resource

2017-12-11 Thread Matthew Auld
We duplicate the stolen discovery code in early-quirks and in i915, however if we just export the region as a resource from early-quirks we can nuke the duplication. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris Wilson Cc: Paulo Zanoni Cc: Thomas Gleixner Cc: In

[Intel-gfx] [PATCH v8 7/9] drm/i915: make mappable struct resource centric

2017-12-11 Thread Matthew Auld
Now that we are using struct resource to track the stolen region, it is more convenient if we track the mappable region in a resource as well. v2: prefer iomap and gmadr naming scheme prefer DEFINE_RES_MEM Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni R

[Intel-gfx] [PATCH v8 3/9] x86/early-quirks: replace the magical increment start values

2017-12-11 Thread Matthew Auld
Replace the magical +2, +9 etc. with +MB, which is far easier to read. Suggested-by: Ville Syrjälä Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris Wilson Cc: Paulo Zanoni Cc: Thomas Gleixner Cc: Ingo Molnar Cc: H. Peter Anvin Cc: x...@kernel.org Cc: linux-ker..

[Intel-gfx] [PATCH v8 5/9] drm/i915: make dsm struct resource centric

2017-12-11 Thread Matthew Auld
Now that we are using struct resource to track the stolen region, it is more convenient if we track dsm in a resource as well. v2: check range_overflow when writing to 32b registers (Chris) pepper in some comments (Chris) v3: refit i915_stolen_to_dma() v4: kill ggtt->stolen_size v5: some more

[Intel-gfx] [PATCH v8 0/9] make stolen resource centric

2017-12-11 Thread Matthew Auld
Continuation of Paulo' stolen series[1], addressing the feedback from Joonas and Chris. [1] https://patchwork.freedesktop.org/series/30923/ Joonas Lahtinen (1): x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit Matthew Auld (8): x86/early-quirks: export the stolen

[Intel-gfx] [PATCH v8 6/9] drm/i915: make reserved struct resource centric

2017-12-11 Thread Matthew Auld
Now that we are using struct resource to track the stolen region, it is more convenient if we track the reserved portion of that region in a resource as well. v2: s/<= end + 1/< end/ (Chris) v3: prefer DEFINE_RES_MEM Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Za

[Intel-gfx] [PATCH v8 4/9] drm/i915: nuke the duplicated stolen discovery

2017-12-11 Thread Matthew Auld
We duplicate the stolen discovery code in early-quirks and in i915, however now that the stolen region is exported as a resource from early-quirks we can nuke the duplication. v2: check overflows_type Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni Reviewed-b

[Intel-gfx] [PATCH v8 9/9] drm/i915: prefer resource_size_t for everything stolen

2017-12-11 Thread Matthew Auld
Keeps things consistent now that we make use of struct resource. This should keep us covered in case we ever get huge amounts of stolen memory. v2: bunch of missing conversions (Chris) Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni Reviewed-by: Chris Wilson

[Intel-gfx] [PATCH v8 8/9] drm/i915: give stolen_usable_size a more suitable home

2017-12-11 Thread Matthew Auld
Kick it out of i915_ggtt and keep it grouped with dsm and dsm_reserved, where it makes the most sense. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h| 13 - drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 1/4] drm/i915/guc: Move shared data allocation away from submission path

2017-12-11 Thread Chris Wilson
Quoting Michał Winiarski (2017-12-11 15:12:53) > +int intel_guc_init(struct intel_guc *guc) > +{ > + struct drm_i915_private *dev_priv = guc_to_i915(guc); > + int ret; > + > + ret = guc_shared_data_create(guc); > + if (ret) > + return ret; > + GEM_BUG_ON(

[Intel-gfx] ✓ Fi.CI.IGT: success for make stolen resource centric (rev7)

2017-12-11 Thread Patchwork
== Series Details == Series: make stolen resource centric (rev7) URL : https://patchwork.freedesktop.org/series/34256/ State : success == Summary == Test kms_flip: Subgroup blt-wf_vblank-vs-dpms: pass -> DMESG-WARN (shard-hsw) fdo#102614 Subgroup vblank-vs

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/pm_rps: Always allocate spin[0]

2017-12-11 Thread Patchwork
== Series Details == Series: igt/pm_rps: Always allocate spin[0] URL : https://patchwork.freedesktop.org/series/35176/ State : success == Summary == IGT patchset tested on top of latest successful build 4d40a6776f08dd87b7e007da691b73d45a9bf1fa igt_fb: Add support for drawing to non-32bit Y/Yf

Re: [Intel-gfx] [PATCH v2] drm/i915: Stop listening to request resubmission from the signaler kthread

2017-12-11 Thread Tvrtko Ursulin
On 11/12/2017 14:26, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-12-11 14:19:47) On 08/12/2017 12:10, Chris Wilson wrote: The intent here was that we would be listening to i915_gem_request_unsubmit in order to cancel the signaler quickly and release the reference on the request. Cancelli

Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: Move GuC workqueue allocations outside of the mutex

2017-12-11 Thread Chris Wilson
Quoting Michał Winiarski (2017-12-11 15:12:54) > @@ -1256,20 +1214,20 @@ int intel_guc_submission_init(struct intel_guc *guc) > if (ret < 0) > goto err_stage_desc_pool; > > - ret = guc_preempt_work_create(guc); > - if (ret) > - goto err_log; > -

Re: [Intel-gfx] [PATCH v2] drm/i915: Stop listening to request resubmission from the signaler kthread

2017-12-11 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-11 15:24:06) > > On 11/12/2017 14:26, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-12-11 14:19:47) > >> > >> On 08/12/2017 12:10, Chris Wilson wrote: > >>> The intent here was that we would be listening to > >>> i915_gem_request_unsubmit in order to cancel t

  1   2   >