Re: [Intel-gfx] [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A

2017-11-29 Thread Joonas Lahtinen
On Mon, 2017-11-27 at 13:36 +, Rantala, Valtteri wrote: > > -Original Message- > > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] > > Sent: Monday, November 27, 2017 11:13 AM > > To: Intel graphics driver community testing & development > g...@lists.freedesktop.org> > >

Re: [Intel-gfx] [PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

2017-11-29 Thread Daniel Vetter
On Tue, Nov 28, 2017 at 05:22:00PM +, Chris Wilson wrote: > Quoting Daniel Vetter (2017-11-28 17:07:07) > > cross-release ftl > > Fwiw, this isn't cross-release but us reloading the module many times, > creating a whole host of new lockclasses. Even more fun is when the > module gets a slightl

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] lockdep: finer-grained completion key for kthread

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] lockdep: finer-grained completion key for kthread URL : https://patchwork.freedesktop.org/series/34556/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2661 pass:1532 dwarn:2 dfail:0 fail:11 skip:1116 time:8

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Fix doc reference to intel_guc_fw.c

2017-11-29 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix doc reference to intel_guc_fw.c URL : https://patchwork.freedesktop.org/series/34557/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2560 pass:1471 dwarn:8 dfail:0 fail:9 skip:1071 time:8745s shard-snbtotal:

Re: [Intel-gfx] [PATCH v4 3/4] drm/i915: Consolidate checks for engine stats availability

2017-11-29 Thread Sagar Arun Kamble
On 11/28/2017 6:34 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Sagar noticed the check can be consolidated between the engine stats implementation and the PMU. My first choice was a static inline helper but that got into include ordering mess quickly fast so I went with a macro instead. A

[Intel-gfx] ✓ Fi.CI.IGT: success for Simplify hunting for drm card sysfs root

2017-11-29 Thread Patchwork
== Series Details == Series: Simplify hunting for drm card sysfs root URL : https://patchwork.freedesktop.org/series/34559/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2661 pass:1524 dwarn:11 dfail:0 fail:10 skip:1116 time:9265s shard-kbltotal:2325 pass

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: follow single notation for workaround number

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: follow single notation for workaround number URL : https://patchwork.freedesktop.org/series/34563/ State : success == Summary == Blacklisted hosts: shard-apltotal:2436 pass:1501 dwarn:22 dfail:16 fail:13 skip:877 ti

[Intel-gfx] [PATCH v2 1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags

2017-11-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Will be adding a new per-engine flags shortly so it makes sense to consolidate. v2: Keep the original code flow in intel_engine_cleanup_cmd_parser. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Suggested-by: Chris Wilson Reviewed-by: Chris Wilson Reviewed-by: Sagar

[Intel-gfx] [PATCH v5 2/2] drm/i915: Consolidate checks for engine stats availability

2017-11-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Sagar noticed the check can be consolidated between the engine stats implementation and the PMU. My first choice was a static inline helper but that got into include ordering mess quickly fast so I went with a macro instead. At some point we should perhaps looking into takin

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cnl: apply Display WA #1178 to fix type C dongles

2017-11-29 Thread Patchwork
== Series Details == Series: drm/i915/cnl: apply Display WA #1178 to fix type C dongles URL : https://patchwork.freedesktop.org/series/34566/ State : success == Summary == Blacklisted hosts: shard-apltotal:2458 pass:1522 dwarn:23 dfail:16 fail:13 skip:877 time:11304s shard-hsw

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Consolidate checks for engine stats availability

2017-11-29 Thread Joonas Lahtinen
On Wed, 2017-11-29 at 08:24 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Sagar noticed the check can be consolidated between the engine stats > implementation and the PMU. > > My first choice was a static inline helper but that got into include > ordering mess quickly fast so I went w

Re: [Intel-gfx] [PATCH 3/4] drm/i915: expose engine availability through sysfs

2017-11-29 Thread Tvrtko Ursulin
On 28/11/2017 21:39, Chris Wilson wrote: Quoting Chris Wilson (2017-11-28 20:56:23) Quoting Tvrtko Ursulin (2017-11-28 18:17:54) On 20/11/2017 12:23, Lionel Landwerlin wrote: This enables userspace to discover the engines available on the GPU. Here is the layout on a Skylake GT4: /sys/devic

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib/igt_sysfs: igt_sysfs_path only works for master nodes

2017-11-29 Thread Tvrtko Ursulin
On 28/11/2017 20:52, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-28 18:09:56) From: Tvrtko Ursulin DRM code defines the minor range for master nodes as 0-63, so express that explicitly near the top of the function. We do use rendernodes, so we had better support them correctly. I th

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Update default GuC FW for SKL/BXT/KBL

2017-11-29 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update default GuC FW for SKL/BXT/KBL URL : https://patchwork.freedesktop.org/series/34590/ State : success == Summary == Blacklisted hosts: shard-apltotal:2436 pass:1501 dwarn:22 dfail:16 fail:13 skip:877 time:10965s shard-hswtota

Re: [Intel-gfx] [QUERY] How many CI mails is too many?

2017-11-29 Thread Ewelina Musial
On Tue, Nov 28, 2017 at 01:16:50PM +0200, Arkadiusz Hiler wrote: > On Mon, Nov 27, 2017 at 09:10:37PM +0530, Sagar Arun Kamble wrote: > > I feel we generally tend to ignore the results mails for series that > > we are not actively involved on (although we might be interested in > > series itself).

[Intel-gfx] [PATCH v6 2/2] drm/i915: Consolidate checks for engine stats availability

2017-11-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Sagar noticed the check can be consolidated between the engine stats implementation and the PMU. My first choice was a static inline helper but that got into include ordering mess quickly fast so I went with a macro instead. At some point we should perhaps looking into takin

Re: [Intel-gfx] [PATCH v6 2/2] drm/i915: Consolidate checks for engine stats availability

2017-11-29 Thread Sagar Arun Kamble
On 11/29/2017 2:57 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Sagar noticed the check can be consolidated between the engine stats implementation and the PMU. My first choice was a static inline helper but that got into include ordering mess quickly fast so I went with a macro instead. A

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "Merge branch 'x86-apic-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip"

2017-11-29 Thread Patchwork
== Series Details == Series: Revert "Merge branch 'x86-apic-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip" URL : https://patchwork.freedesktop.org/series/34592/ State : success == Summary == Series 34592v1 Revert "Merge branch 'x86-apic-for-linus' of git://git.kernel.or

[Intel-gfx] [PATCH 1/2] lockdep: finer-grained completion key for kthread

2017-11-29 Thread Daniel Vetter
Ideally we'd create the key through a macro at the real callers and pass it all the way down. This would give us better coverage for cases where a bunch of kthreads are created for the same thing. But this gets the job done meanwhile and unblocks our CI. Refining later on is always possible. v2: -

[Intel-gfx] [PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

2017-11-29 Thread Daniel Vetter
cross-release ftl From Chris: "Fwiw, this isn't cross-release but us reloading the module many times, creating a whole host of new lockclasses. Even more fun is when the module gets a slightly different address and the new lock address hashes into an old lock... "I did think about a module-hook

Re: [Intel-gfx] [QUERY] How many CI mails is too many?

2017-11-29 Thread Chris Wilson
Quoting Chris Wilson (2017-11-28 10:16:17) > Quoting Daniel Vetter (2017-11-28 10:08:56) > > On Tue, Nov 28, 2017 at 11:06 AM, Chris Wilson > > wrote: > > > Quoting Joonas Lahtinen (2017-11-28 08:15:13) > > >> On Mon, 2017-11-27 at 16:54 +0200, Arkadiusz Hiler wrote: > > >> > Hey all, > > >> > >

Re: [Intel-gfx] [PATCH i-g-t] igt/kms_rotation_crc: Add horizontal flip subtest.

2017-11-29 Thread Petri Latvala
On Wed, Nov 22, 2017 at 03:05:55PM -0800, Anusha Srivatsa wrote: > From: Joseph Garvey > > Test that horizontal flip works with supported rotations. Includes > a fix for the unrotated fb which was not being positioned correctly > with portrait and landscape rectangles. > > v2:(from Anusha) > - C

Re: [Intel-gfx] [PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

2017-11-29 Thread Chris Wilson
Quoting Daniel Vetter (2017-11-29 09:46:36) > cross-release ftl > > From Chris: > > "Fwiw, this isn't cross-release but us reloading the module many times, > creating a whole host of new lockclasses. Even more fun is when the > module gets a slightly different address and the new lock address has

Re: [Intel-gfx] [PATCH v6 0/7] drm/fbdev: Panel orientation connector property support

2017-11-29 Thread Daniel Vetter
On Tue, Nov 28, 2017 at 02:36:09PM +0100, Hans de Goede wrote: > Hi, > > On 28-11-17 11:27, Daniel Vetter wrote: > > On Sat, Nov 25, 2017 at 06:33:34PM +0100, Hans de Goede wrote: > > > Hi All, > > > > > > Here is v6 of my series to add a "panel orientation" property to > > > the drm-connector fo

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags (rev4)

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags (rev4) URL : https://patchwork.freedesktop.org/series/34354/ State : success == Summary == Series 34354v4 series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser

Re: [Intel-gfx] [PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

2017-11-29 Thread Chris Wilson
Quoting Chris Wilson (2017-11-29 09:57:14) > Quoting Daniel Vetter (2017-11-29 09:46:36) > > cross-release ftl > > > > From Chris: > > > > "Fwiw, this isn't cross-release but us reloading the module many times, > > creating a whole host of new lockclasses. Even more fun is when the > > module get

Re: [Intel-gfx] [PATCH] drm/i915: Unifying debugfs return codes for unsupported features

2017-11-29 Thread Sagar Arun Kamble
On 11/28/2017 9:12 PM, Michal Wajdeczko wrote: Instead of trying different seq_puts messages, lets use common -ENODEV error code to indicate missing/unsupported feature. Suggested-by: Chris Wilson Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Sagar Arun Kamble C

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] lockdep: finer-grained completion key for kthread

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] lockdep: finer-grained completion key for kthread URL : https://patchwork.freedesktop.org/series/34603/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK incl

Re: [Intel-gfx] [PATCH v6 2/2] drm/i915: Consolidate checks for engine stats availability

2017-11-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-29 09:27:56) > From: Tvrtko Ursulin > > Sagar noticed the check can be consolidated between the engine stats > implementation and the PMU. > > My first choice was a static inline helper but that got into include > ordering mess quickly fast so I went with a macro

Re: [Intel-gfx] [PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

2017-11-29 Thread Daniel Vetter
On Wed, Nov 29, 2017 at 10:01:09AM +, Chris Wilson wrote: > Quoting Chris Wilson (2017-11-29 09:57:14) > > Quoting Daniel Vetter (2017-11-29 09:46:36) > > > cross-release ftl > > > > > > From Chris: > > > > > > "Fwiw, this isn't cross-release but us reloading the module many times, > > > crea

[Intel-gfx] [PATCH v7 2/2] drm/i915: Consolidate checks for engine stats availability

2017-11-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Sagar noticed the check can be consolidated between the engine stats implementation and the PMU. My first choice was a static inline helper but that got into include ordering mess quickly fast so I went with a macro instead. At some point we should perhaps looking into takin

Re: [Intel-gfx] [PATCH i-g-t] i-g-t: kms_plane_scaling: Enhanced scaling tests

2017-11-29 Thread Daniel Vetter
On Mon, Nov 27, 2017 at 09:20:33AM +, Srinivas, Vidya wrote: > > > > -Original Message- > > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > > Daniel Vetter > > Sent: Monday, November 27, 2017 2:47 PM > > To: Srinivas, Vidya > > Cc: intel-gfx > > Subject:

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Impletments dynamic WOPCM partitioning.

2017-11-29 Thread Sagar Arun Kamble
On 11/29/2017 6:31 AM, Yaodong Li wrote: On 11/16/2017 08:00 PM, Sagar Arun Kamble wrote: On 11/17/2017 3:17 AM, Michal Wajdeczko wrote: On Thu, 16 Nov 2017 08:34:01 +0100, Sagar Arun Kamble wrote: Typo in the subject. GLK showing failure to load GuC with this approach on CI. On 11/15/

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags (rev5)

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags (rev5) URL : https://patchwork.freedesktop.org/series/34354/ State : success == Summary == Series 34354v5 series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser

[Intel-gfx] [PATCH] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It seems that the DMC likes to transition between the DC states a lot when there are no connected displays (no active power domains) during command submission. This activity on DC states has a negative impact on the performance of the chip with huge latencies observed in the

Re: [Intel-gfx] [PATCH i-g-t 2/2] Revert "lib/igt_aux: Make procps optional"

2017-11-29 Thread Daniel Vetter
On Fri, Nov 24, 2017 at 05:17:48PM +0200, Arkadiusz Hiler wrote: > This reverts commit d7d3f4e87b827152f00bdf89a67871736672b492 > and gets rid of the config option from the meson.build. > > It was needed only for the Android support. > > Signed-off-by: Arkadiusz Hiler Acked-by: Daniel Vetter

Re: [Intel-gfx] [PATCH] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-29 10:59:27) > From: Tvrtko Ursulin > > It seems that the DMC likes to transition between the DC states a lot when > there are no connected displays (no active power domains) during command > submission. > > This activity on DC states has a negative impact on the

Re: [Intel-gfx] [PATCH] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Daniel Vetter
On Wed, Nov 29, 2017 at 10:59:27AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > It seems that the DMC likes to transition between the DC states a lot when > there are no connected displays (no active power domains) during command > submission. > > This activity on DC states has a nega

[Intel-gfx] [PATCH i-g-t 1/2] lib: avoid < in gtkdoc comments

2017-11-29 Thread Daniel Vetter
For reasons entirely not clear to me meson gtkdoc runs in strict xml parsing mode, whereas automake gtkdoc doesn't. And gtkdoc itself is to dense to correctly escape this stuff. Paper around this. Signed-off-by: Daniel Vetter --- lib/igt_aux.c | 4 ++-- lib/igt_core.c| 4 ++-- l

[Intel-gfx] [PATCH i-g-t 2/2] meson: gtkdoc support

2017-11-29 Thread Daniel Vetter
Bunch of neat improvements: - xml generates correctly depend upon the test binaries - no need to re-run autogen.sh when new chapters/functions get added, all handed by meson Still one issue: - the gtkdoc target doesn't depend upon the custom_target yet, hacked around using build_by_default:

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Restore GT performance in headless mode with DMC loaded (rev3)

2017-11-29 Thread Patchwork
== Series Details == Series: drm/i915: Restore GT performance in headless mode with DMC loaded (rev3) URL : https://patchwork.freedesktop.org/series/24017/ State : warning == Summary == Series 24017v3 drm/i915: Restore GT performance in headless mode with DMC loaded https://patchwork.freedeskt

[Intel-gfx] [PATCH] lockdep: finer-grained completion key for kthread

2017-11-29 Thread Daniel Vetter
Ideally we'd create the key through a macro at the real callers and pass it all the way down. This would give us better coverage for cases where a bunch of kthreads are created for the same thing. But this gets the job done meanwhile and unblocks our CI. Refining later on is always possible. v2: -

Re: [Intel-gfx] [PATCH] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Tvrtko Ursulin
On 29/11/2017 11:12, Daniel Vetter wrote: On Wed, Nov 29, 2017 at 10:59:27AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It seems that the DMC likes to transition between the DC states a lot when there are no connected displays (no active power domains) during command submission. This

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] lib: avoid < in gtkdoc comments

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] lib: avoid < in gtkdoc comments URL : https://patchwork.freedesktop.org/series/34609/ State : success == Summary == IGT patchset tested on top of latest successful build 380cc811486ba3fefbe3ebe4761afa7e169dcd3e tests/perf_pmu: Sync invali

Re: [Intel-gfx] [PATCH] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-29 11:34:27) > > On 29/11/2017 11:12, Daniel Vetter wrote: > > I think given that DMC is strongly recommended there shouldn't be a real > > cost with making this unconditional. > > I don't know, not liking it on the first go. But then again I have no > idea how mu

Re: [Intel-gfx] [PATCH] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Tvrtko Ursulin
On 29/11/2017 11:40, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-29 11:34:27) On 29/11/2017 11:12, Daniel Vetter wrote: I think given that DMC is strongly recommended there shouldn't be a real cost with making this unconditional. I don't know, not liking it on the first go. But then

Re: [Intel-gfx] [PATCH] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-29 11:53:41) > > On 29/11/2017 11:40, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-11-29 11:34:27) > >> > >> On 29/11/2017 11:12, Daniel Vetter wrote: > >>> I think given that DMC is strongly recommended there shouldn't be a real > >>> cost with making this

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with lockdep: finer-grained completion key for kthread (rev2)

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with lockdep: finer-grained completion key for kthread (rev2) URL : https://patchwork.freedesktop.org/series/34603/ State : success == Summary == Series 34603v2 series starting with lockdep: finer-grained completion key for kthread https://patchwo

[Intel-gfx] [PATCH i-g-t v2 2/3] tests/gem_pin: Drop gem_pin.c

2017-11-29 Thread Abdiel Janulgue
gem_pin ABI is going away (Chris). Signed-off-by: Abdiel Janulgue Reviewed-by: Joonas Lahtinen --- tests/Makefile.sources | 1 - tests/gem_pin.c| 248 - tests/meson.build | 1 - 3 files changed, 250 deletions(-) delete mode 10064

[Intel-gfx] [PATCH i-g-t v2 3/3] tests/gem_seqno_wrap: Drop gem_seqno_wrap.c

2017-11-29 Thread Abdiel Janulgue
gem_seqno_wrap is defunct as the debug API withered away. The handling of wraparound under many different workloads is tested by gem_exec_whisper (Chris). Signed-off-by: Abdiel Janulgue Reviewed-by: Joonas Lahtinen --- tests/Makefile.sources | 1 - tests/gem_seqno_wrap.c | 483 ---

[Intel-gfx] [PATCH i-g-t v2 1/3] tests/gem_hangcheck_forcewake: Drop gem_hangcheck_forcewake.c

2017-11-29 Thread Abdiel Janulgue
gem_hangcheck_forcewake has been superseded by drv_hangman, and a lot of other very extensive hangchecking that is not run by CI (Chris). v2: Split into multiple patches (Antonio Argenziano) Signed-off-by: Abdiel Janulgue Reviewed-by: Joonas Lahtinen --- tests/Makefile.sources | 1 -

Re: [Intel-gfx] [PATCH v10 1/2] drm/i915/guc : Removing enable_guc_loading and enable_guc_submission module parameters

2017-11-29 Thread Michal Wajdeczko
On Tue, 28 Nov 2017 11:41:57 +0100, Sagar Arun Kamble wrote: On 11/28/2017 1:24 AM, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need submission=1, we also need loading=1.We also need loa

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "Merge branch 'x86-apic-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip"

2017-11-29 Thread Patchwork
== Series Details == Series: Revert "Merge branch 'x86-apic-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip" URL : https://patchwork.freedesktop.org/series/34592/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2661 pass:1527 dwarn:7 dfail:2 fai

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags (rev4)

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags (rev4) URL : https://patchwork.freedesktop.org/series/34354/ State : success == Summary == Blacklisted hosts: shard-apltotal:2412 pass:1516 dwarn:14 dfail:10 fail:12

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags (rev5)

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags (rev5) URL : https://patchwork.freedesktop.org/series/34354/ State : success == Summary == Blacklisted hosts: shard-apltotal:2431 pass:1516 dwarn:13 dfail:11 fail:13

Re: [Intel-gfx] [PATCH] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Imre Deak
On Wed, Nov 29, 2017 at 11:10:58AM +, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2017-11-29 10:59:27) > > From: Tvrtko Ursulin > > > > It seems that the DMC likes to transition between the DC states a lot when > > there are no connected displays (no active power domains) during command > >

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags (rev5)

2017-11-29 Thread Tvrtko Ursulin
On 29/11/2017 10:58, Patchwork wrote: == Series Details == Series: series starting with [v2,1/2] drm/i915: Move engine->needs_cmd_parser to engine->flags (rev5) URL : https://patchwork.freedesktop.org/series/34354/ State : success == Summary == Series 34354v5 series starting with [v2,1/2]

[Intel-gfx] [PATCH igt] lib: Check and report if a subtest triggers a new kernel taint

2017-11-29 Thread Chris Wilson
Checking for a tainted kernel is a convenient way to see if the test generated a critical error such as a oops, or machine check. Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: Radoslaw Szwichtenberg --- lib/Makefile.sources | 2 ++ lib/igt_core.c | 19 +- lib/igt_kernel_

[Intel-gfx] [PATCH 2/2] drm/i915: HACK enable GuC for testing

2017-11-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_params.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 8321bd86cba5..69ee2484c6bb 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH 1/2] drm/i915: Add GuC support for engine busy stats

2017-11-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Wire up the engine busy stats accounting to the GuC submission backend. Since there is not context out interrupt we need to place the accounting callbacks per-request in order to correctly pair with user interrupts. v2: Rebase. v3: Commit update. Signed-off-by: Tvrtko Ursu

Re: [Intel-gfx] [PATCH igt] lib: Check and report if a subtest triggers a new kernel taint

2017-11-29 Thread Chris Wilson
Quoting Chris Wilson (2017-11-29 12:30:23) > Checking for a tainted kernel is a convenient way to see if the test > generated a critical error such as a oops, or machine check. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: Radoslaw Szwichtenberg > --- > diff --git a/lib/igt_kernel_t

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] tests/gem_hangcheck_forcewake: Drop gem_hangcheck_forcewake.c

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] tests/gem_hangcheck_forcewake: Drop gem_hangcheck_forcewake.c URL : https://patchwork.freedesktop.org/series/34614/ State : success == Summary == IGT patchset tested on top of latest successful build 380cc811486ba3fefbe3ebe4761afa7e16

Re: [Intel-gfx] [PATCH] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Daniel Vetter
On Wed, Nov 29, 2017 at 11:34:27AM +, Tvrtko Ursulin wrote: > > On 29/11/2017 11:12, Daniel Vetter wrote: > > On Wed, Nov 29, 2017 at 10:59:27AM +, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > It seems that the DMC likes to transition between the DC states a lot when > >

Re: [Intel-gfx] [PATCH] drm/i915: Fix deadlock in i830_disable_pipe()

2017-11-29 Thread Ville Syrjälä
On Tue, Nov 28, 2017 at 09:05:00PM +, Chris Wilson wrote: > Quoting Ville Syrjala (2017-11-28 15:48:53) > > From: Ville Syrjälä > > > > i830_disable_pipe() gets called from the power well code, and thus > > we're already holding the power domain mutex. That means we can't > > call plane->get_

[Intel-gfx] [PATCH v2] drm/i915: Fix deadlock in i830_disable_pipe()

2017-11-29 Thread Ville Syrjala
From: Ville Syrjälä i830_disable_pipe() gets called from the power well code, and thus we're already holding the power domain mutex. That means we can't call plane->get_hw_state() as it will also try to grab the same mutex and will thus deadlock. Replace the assert_plane() calls (which calls ->g

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] lib: avoid < in gtkdoc comments

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] lib: avoid < in gtkdoc comments URL : https://patchwork.freedesktop.org/series/34609/ State : success == Summary == Blacklisted hosts: shard-apltotal:2452 pass:1519 dwarn:28 dfail:15 fail:9 skip:877 time:12292s shard-hsw

[Intel-gfx] [PATCH i-g-t] meson: build a full dependency for lib_igt_perf

2017-11-29 Thread Daniel Vetter
meson prefers packages dependencies over passing arount static libraries, because those also include linker flags, include dirs and everything else. While at it pull the special cases out from the common build stanzas like we do with other special cases. Just a bit of ocd to keep everything polis

Re: [Intel-gfx] [PATCH igt] lib: Check and report if a subtest triggers a new kernel taint

2017-11-29 Thread Szwichtenberg, Radoslaw
On Wed, 2017-11-29 at 12:40 +, Chris Wilson wrote: > Quoting Chris Wilson (2017-11-29 12:30:23) > > Checking for a tainted kernel is a convenient way to see if the test > > generated a critical error such as a oops, or machine check. > > > > Signed-off-by: Chris Wilson > > Cc: Daniel Vetter

Re: [Intel-gfx] [PATCH igt] lib: Check and report if a subtest triggers a new kernel taint

2017-11-29 Thread Chris Wilson
Quoting Szwichtenberg, Radoslaw (2017-11-29 13:14:52) > On Wed, 2017-11-29 at 12:40 +, Chris Wilson wrote: > > Quoting Chris Wilson (2017-11-29 12:30:23) > > > Checking for a tainted kernel is a convenient way to see if the test > > > generated a critical error such as a oops, or machine check.

Re: [Intel-gfx] [PATCH i-g-t 2/2] Revert "lib/igt_aux: Make procps optional"

2017-11-29 Thread Arkadiusz Hiler
On Wed, Nov 29, 2017 at 12:07:06PM +0100, Daniel Vetter wrote: > On Fri, Nov 24, 2017 at 05:17:48PM +0200, Arkadiusz Hiler wrote: > > This reverts commit d7d3f4e87b827152f00bdf89a67871736672b492 > > and gets rid of the config option from the meson.build. > > > > It was needed only for the Android

Re: [Intel-gfx] [PATCH i-g-t 1/2] igt: Remove Android support

2017-11-29 Thread Szwichtenberg, Radoslaw
On Fri, 2017-11-24 at 17:17 +0200, Arkadiusz Hiler wrote: > This patch gets rid of the Android support, deleting all the hacks and > moving code around to the places it belongs. > > Android build is not really maintained properly and rots rather fast. > With recent push for Meson here and Android

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with lockdep: finer-grained completion key for kthread (rev2)

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with lockdep: finer-grained completion key for kthread (rev2) URL : https://patchwork.freedesktop.org/series/34603/ State : success == Summary == Blacklisted hosts: shard-apltotal:2476 pass:1560 dwarn:10 dfail:8 fail:14 skip:879 time:1

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Add GuC support for engine busy stats

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add GuC support for engine busy stats URL : https://patchwork.freedesktop.org/series/34617/ State : failure == Summary == Series 34617v1 series starting with [1/2] drm/i915: Add GuC support for engine busy stats https://patchw

Re: [Intel-gfx] [PATCH v10 1/2] drm/i915/guc : Removing enable_guc_loading and enable_guc_submission module parameters

2017-11-29 Thread Sagar Arun Kamble
On 11/29/2017 5:44 PM, Michal Wajdeczko wrote: On Tue, 28 Nov 2017 11:41:57 +0100, Sagar Arun Kamble wrote: On 11/28/2017 1:24 AM, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need subm

Re: [Intel-gfx] [PATCH igt] lib: Check and report if a subtest triggers a new kernel taint

2017-11-29 Thread Chris Wilson
Quoting Chris Wilson (2017-11-29 12:30:23) > +static const struct kernel_taint { > + const char *msg; > + unsigned int flags; > +} taints[] = { > + { "Non-GPL module loaded" }, > + { "Forced module load" }, > + { "Unsafe SMP processor" }, > + { "Forced module unl

Re: [Intel-gfx] [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9

2017-11-29 Thread Juha-Pekka Heikkila
On 28.11.2017 13:53, Maarten Lankhorst wrote: Hey, Op 21-11-17 om 15:02 schreef Juha-Pekka Heikkila: Gen10 onwards 90 and 270 degree rotations are supported for RGB565 format. v2 (Ville Syrjälä): As a side effect to keep bad-pixel-format test valid on all supported platforms it need to use DRM

[Intel-gfx] [PATCH] drm/i915: Taint (TAINT_DIE) the kernel if the GPU reset fails

2017-11-29 Thread Chris Wilson
History tells us that if we cannot reset the GPU now, we never will. This then impacts everything that is run subsequently. On failing the reset, we mark the driver as wedged, trying to prevent further execution on the GPU, forcing userspace to fallback to using the CPU to update its framebuffers a

[Intel-gfx] [PATCH v2] drm/i915: Taint (TAINT_DIE) the kernel if the GPU reset fails

2017-11-29 Thread Chris Wilson
History tells us that if we cannot reset the GPU now, we never will. This then impacts everything that is run subsequently. On failing the reset, we mark the driver as wedged, trying to prevent further execution on the GPU, forcing userspace to fallback to using the CPU to update its framebuffers a

Re: [Intel-gfx] [PATCH v10 1/2] drm/i915/guc : Removing enable_guc_loading and enable_guc_submission module parameters

2017-11-29 Thread Michal Wajdeczko
On Wed, 29 Nov 2017 14:40:05 +0100, Sagar Arun Kamble wrote: On 11/29/2017 5:44 PM, Michal Wajdeczko wrote: On Tue, 28 Nov 2017 11:41:57 +0100, Sagar Arun Kamble wrote: On 11/28/2017 1:24 AM, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "ena

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Add GuC support for engine busy stats

2017-11-29 Thread Tvrtko Ursulin
On 29/11/2017 13:30, Patchwork wrote: == Series Details == Series: series starting with [1/2] drm/i915: Add GuC support for engine busy stats URL : https://patchwork.freedesktop.org/series/34617/ State : failure == Summary == Series 34617v1 series starting with [1/2] drm/i915: Add GuC supp

Re: [Intel-gfx] [PATCH] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Imre Deak
On Wed, Nov 29, 2017 at 11:59:04AM +, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2017-11-29 11:53:41) > > > > On 29/11/2017 11:40, Chris Wilson wrote: > > > Quoting Tvrtko Ursulin (2017-11-29 11:34:27) > > >> > > >> On 29/11/2017 11:12, Daniel Vetter wrote: > > >>> I think given that DMC is

Re: [Intel-gfx] [PATCH] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Imre Deak
On Wed, Nov 29, 2017 at 10:59:27AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > It seems that the DMC likes to transition between the DC states a lot when > there are no connected displays (no active power domains) during command > submission. > > This activity on DC states has a nega

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/3] tests/gem_hangcheck_forcewake: Drop gem_hangcheck_forcewake.c

2017-11-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] tests/gem_hangcheck_forcewake: Drop gem_hangcheck_forcewake.c URL : https://patchwork.freedesktop.org/series/34614/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2631 pass:1511 dwarn:2 dfail:0 fail:11 sk

[Intel-gfx] [PATCH v4] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It seems that the DMC likes to transition between the DC states a lot when there are no connected displays (no active power domains) during command submission. This activity on DC states has a negative impact on the performance of the chip with huge latencies observed in the

Re: [Intel-gfx] [PATCH i-g-t 5/5] tools/intel_watermark: Right justify register names

2017-11-29 Thread Ville Syrjälä
On Wed, Nov 22, 2017 at 11:44:32PM +, Pandiyan, Dhinakaran wrote: > Reviewed-by: Dhinakaran Pandiyan for the > series. Series pushed. Thanks for the review. > > > On Tue, 2017-11-21 at 20:49 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > I think the dump is a more legible wh

Re: [Intel-gfx] [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-29 Thread Maarten Lankhorst
Op 28-11-17 om 16:13 schreef Thomas Voegtle: > On Tue, 28 Nov 2017, Daniel Vetter wrote: > >> On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: >>> Some drivers like i915 start with crtc's enabled, but with deferred >>> fbcon setup they were no longer disabled as part of fbdev setu

[Intel-gfx] ✓ Fi.CI.BAT: success for lib: Check and report if a subtest triggers a new kernel taint

2017-11-29 Thread Patchwork
== Series Details == Series: lib: Check and report if a subtest triggers a new kernel taint URL : https://patchwork.freedesktop.org/series/34616/ State : success == Summary == IGT patchset tested on top of latest successful build 643dc097156fa9a0ab9286c7c159459cfbe3079e Revert "lib/igt_aux: Ma

Re: [Intel-gfx] [PATCH v4] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Imre Deak
On Wed, Nov 29, 2017 at 02:30:30PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > It seems that the DMC likes to transition between the DC states a lot when > there are no connected displays (no active power domains) during command > submission. > > This activity on DC states has a nega

Re: [Intel-gfx] [PATCH i-g-t 0/2] kms_plane: Enumerate outputs before planes

2017-11-29 Thread Daniel Vetter
On Tue, Nov 21, 2017 at 09:52:52PM +0200, Imre Deak wrote: > Enumerate outputs before planes means we can avoid doing an extra > modeset when calculating the reference CRC during the test of each > plane. In addition when testing multiple outputs we can avoid a full > modeset we currently do whenev

[Intel-gfx] ✗ Fi.CI.BAT: failure for meson: build a full dependency for lib_igt_perf

2017-11-29 Thread Patchwork
== Series Details == Series: meson: build a full dependency for lib_igt_perf URL : https://patchwork.freedesktop.org/series/34618/ State : failure == Summary == Series 34618 revision 1 was fully merged or fully failed: no git log ___ Intel-gfx maili

Re: [Intel-gfx] [PATCH v4] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-11-29 Thread Tvrtko Ursulin
On 29/11/2017 15:06, Imre Deak wrote: On Wed, Nov 29, 2017 at 02:30:30PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It seems that the DMC likes to transition between the DC states a lot when there are no connected displays (no active power domains) during command submission. This acti

[Intel-gfx] [PATCH v2 1/3] drm/i915: Fix vblank timestamp/frame counter jumps on gen2

2017-11-29 Thread Ville Syrjala
From: Ville Syrjälä Previously I was under the impression that the scanline counter reads 0 when the pipe is off. Turns out that's not correct, and instead the scanline counter simply stops when the pipe stops, and it retains it's last value until the pipe starts up again, at which point the scan

[Intel-gfx] [PATCH v2 2/3] drm/i915: Wait for pipe to start on i830 as well

2017-11-29 Thread Ville Syrjala
From: Ville Syrjälä We should make sure the pipe has fully started when we enable it from the i830 "power well". Otherwise theoretically i830 could also hit problems with vblank timestamps jumping around (since we skip the wait during modeset on i830). Additionally moving planes between the pipes

[Intel-gfx] [PATCH 3/3] drm/i915: Pass crtc state to intel_pipe_{enable, disable}()

2017-11-29 Thread Ville Syrjala
From: Ville Syrjälä Get rid of the crtc->config usages from within intel_pipe_{enable,disable}() by passing in the appropriate crtc state. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 76 +++- 1 file changed, 23 insertions(+), 53 delet

[Intel-gfx] [PATCH 0/2] lockdep cross-release fallout from -rc1

2017-11-29 Thread Daniel Vetter
Hi all, -rc1 set our CI on fire with a pile of issues that cross-release highlights. The two patches in this series get things back into working order on our side, so we pulled them into our local branches to unblock CI and drm/i915. But they're ofc far from polished, so pls look at this more as

[Intel-gfx] [PATCH 1/2] lockdep: finer-grained completion key for kthread

2017-11-29 Thread Daniel Vetter
Ideally we'd create the key through a macro at the real callers and pass it all the way down. This would give us better coverage for cases where a bunch of kthreads are created for the same thing. But this gets the job done meanwhile and unblocks our CI. Refining later on is always possible. v2: -

[Intel-gfx] [PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

2017-11-29 Thread Daniel Vetter
cross-release ftl From Chris: "Fwiw, this isn't cross-release but us reloading the module many times, creating a whole host of new lockclasses. Even more fun is when the module gets a slightly different address and the new lock address hashes into an old lock... "I did think about a module-hook

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Fix vblank timestamp/frame counter jumps on gen2

2017-11-29 Thread Chris Wilson
Quoting Ville Syrjala (2017-11-29 15:37:30) > From: Ville Syrjälä > > Previously I was under the impression that the scanline counter > reads 0 when the pipe is off. Turns out that's not correct, and > instead the scanline counter simply stops when the pipe stops, and > it retains it's last value

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Wait for pipe to start on i830 as well

2017-11-29 Thread Chris Wilson
Quoting Ville Syrjala (2017-11-29 15:37:31) > From: Ville Syrjälä > > We should make sure the pipe has fully started when we enable it from > the i830 "power well". Otherwise theoretically i830 could also hit > problems with vblank timestamps jumping around (since we skip the > wait during modese

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Pass crtc state to intel_pipe_{enable, disable}()

2017-11-29 Thread Chris Wilson
Quoting Ville Syrjala (2017-11-29 15:37:32) > From: Ville Syrjälä > > Get rid of the crtc->config usages from within > intel_pipe_{enable,disable}() by passing in the appropriate > crtc state. > > Signed-off-by: Ville Syrjälä Looks mechanical, so I hope I didn't miss anything important, Review

  1   2   >