[Intel-gfx] ✗ Fi.CI.BAT: warning for GEM/GuC Suspend/Resume/Reset fixes and restructuring (rev5)

2017-09-28 Thread Patchwork
== Series Details == Series: GEM/GuC Suspend/Resume/Reset fixes and restructuring (rev5) URL : https://patchwork.freedesktop.org/series/30802/ State : warning == Summary == Series 30802v5 GEM/GuC Suspend/Resume/Reset fixes and restructuring https://patchwork.freedesktop.org/api/1.0/series/3080

Re: [Intel-gfx] [PATCH v2] drm/i915: Allow optimized platform checks

2017-09-28 Thread Jani Nikula
On Wed, 27 Sep 2017, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > If we store the platform as a bitmask, and convert the > IS_PLATFORM macro to use it, we allow the compiler to > merge the IS_PLATFORM(a) || IS_PLATFORM(b) || ... checks > into a single conditional. > > As a secondary benefit t

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for GEM/GuC Suspend/Resume/Reset fixes and restructuring (rev5)

2017-09-28 Thread Sagar Arun Kamble
On 9/28/2017 12:41 PM, Patchwork wrote: == Series Details == Series: GEM/GuC Suspend/Resume/Reset fixes and restructuring (rev5) URL : https://patchwork.freedesktop.org/series/30802/ State : warning == Summary == Series 30802v5 GEM/GuC Suspend/Resume/Reset fixes and restructuring https://p

Re: [Intel-gfx] [PATCH] drm/i915: Also discard second CRC on gen8+ platforms.

2017-09-28 Thread Mika Kahola
This fixes my issue with GLK+MIPI/DSI when running IGT test kms_frontbuffer_tracking --r basic Tested-by: Mika Kahola On Wed, 2017-09-27 at 17:20 -0700, Rodrigo Vivi wrote: > One of the differences I spotted for GEN8+ platforms when > compared to older platforms is that spec for BDW+ includes >

[Intel-gfx] [PATCH 1/8] drm/i915/bios: parse DDI ports also for CHV for HDMI DDC pin and DP AUX channel

2017-09-28 Thread Jani Nikula
While technically CHV isn't DDI, we do look at the VBT based DDI port info for HDMI DDC pin and DP AUX channel. (We call these "alternate", but they're really just something that aren't platform defaults.) In commit e4ab73a13291 ("drm/i915: Respect alternate_ddc_pin for all DDI ports") Ville write

[Intel-gfx] [PATCH 2/8] drm/i915/bios: refactor parse general definitions

2017-09-28 Thread Jani Nikula
Early return on failures. Rename the variable for later merging with parse_device_mappings(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.

[Intel-gfx] [PATCH 0/8] drm/i915/bios: VBT parsing fixes and cleanups

2017-09-28 Thread Jani Nikula
More VBT parsing fixes and refactoring. BR, Jani. Jani Nikula (8): drm/i915/bios: parse DDI ports also for CHV for HDMI DDC pin and DP AUX channel drm/i915/bios: refactor parse general definitions drm/i915/bios: don't initialize fields based on vbt version drm/i915/bios: remove an un

[Intel-gfx] [PATCH 3/8] drm/i915/bios: don't initialize fields based on vbt version

2017-09-28 Thread Jani Nikula
In theory, these might clobber information for older VBT versions. We might have to store the BDB version for later parsing, but currently all code accessing these fields will only use them on newer platforms with new enough BDB versions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/inte

[Intel-gfx] [PATCH 4/8] drm/i915/bios: remove an unnecessary temp variable

2017-09-28 Thread Jani Nikula
Prepare for merging parse_device_mapping() into parse_general_definitions(). No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 8/8] drm/i915/bios: don't pass bdb to parsers that don't parse VBT directly

2017-09-28 Thread Jani Nikula
Hint that you're not supposed to look at VBT in these functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index

[Intel-gfx] [PATCH 7/8] drm/i915/bios: parse SDVO device mapping from pre-parsed child devices

2017-09-28 Thread Jani Nikula
We parse and store the child devices in parse_general_definitions(). There is no need to parse the VBT block again for SDVO device mapping. Do the same as we do in parse_ddi_ports(). We no longer have access to child device size at this stage, but we also don't need to worry about reading past the

[Intel-gfx] [PATCH 6/8] drm/i915/bios: merge parse_device_mapping() into parse_general_definitions()

2017-09-28 Thread Jani Nikula
They're both parsing the same block, and there's no need for them to be split. The former also benefits from the range checks in the latter. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 48 +-- 1 file changed, 16 insertions(+), 32 deletio

[Intel-gfx] [PATCH 5/8] drm/i915/bios: cleanup comments and useless return

2017-09-28 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index d0fedac0322f..9cfe89eed501 100644 --- a/drivers/gpu/drm/i915/intel_bios.c +++

Re: [Intel-gfx] [PATCH i-g-t v4 2/6] lib/igt_kms: Fix off-by-one bug on skip of missing pipe

2017-09-28 Thread Petri Latvala
On Wed, Sep 27, 2017 at 03:34:15PM -0300, Gabriel Krisman Bertazi wrote: > display->n_pipes is zero-indexed, so N returned in > igt_display_get_n_pipes is already not a valid pipe. This patch > prevents kms_ccs from going nuts when testing the first unxesting pipe.

Re: [Intel-gfx] [PATCH i-g-t 1/3] Fix rlim_cur compiler warnings when building on ARM.

2017-09-28 Thread Petri Latvala
On Wed, Sep 27, 2017 at 11:37:33AM -0700, Eric Anholt wrote: > Signed-off-by: Eric Anholt For the series: Reviewed-by: Petri Latvala > --- > benchmarks/prime_lookup.c | 2 +- > tests/gem_exec_reuse.c| 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/benchmarks

Re: [Intel-gfx] [PATCH i-g-t] Fix compilation on some distros

2017-09-28 Thread Petri Latvala
On Wed, Sep 27, 2017 at 04:08:27PM -0700, James Ausmus wrote: > Some distros (such as Gentoo) are removing the include of > sys/sysmacros.h from sys/types.h. Explicitly include sysmacros.h in > files where we use the minor() and major() functions. > > Signed-off-by: James Ausmus Reviewed-by: Pet

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: VBT parsing fixes and cleanups

2017-09-28 Thread Patchwork
== Series Details == Series: drm/i915/bios: VBT parsing fixes and cleanups URL : https://patchwork.freedesktop.org/series/31051/ State : success == Summary == Series 31051v1 drm/i915/bios: VBT parsing fixes and cleanups https://patchwork.freedesktop.org/api/1.0/series/31051/revisions/1/mbox/

Re: [Intel-gfx] [PATCH igt 1/3] benchmark/gem_busy: Compare polling with syncobj_wait

2017-09-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-09-28 07:53:56) > > On 25/09/2017 21:26, Chris Wilson wrote: > > Signed-off-by: Chris Wilson > > --- > > benchmarks/gem_busy.c | 73 > > ++- > > 1 file changed, 72 insertions(+), 1 deletion(-) > > > > diff --git a/b

Re: [Intel-gfx] [PATCH 01/31] drm/i915/debugfs: Create generic string tokenize function and update CRC control parsing

2017-09-28 Thread Sagar Arun Kamble
Thanks for the review Michal. Will update as suggested. On 9/21/2017 8:42 PM, Michal Wajdeczko wrote: On Tue, 19 Sep 2017 19:41:37 +0200, Sagar Arun Kamble wrote: Input string parsing used in CRC control parameter parsing is generic and can be reused for other debugfs interfaces. Hence name

Re: [Intel-gfx] [PATCH 08/31] drm/i915: Rename intel_enable_rc6 to intel_rc6_enabled

2017-09-28 Thread Sagar Arun Kamble
Thank you Radek, Ewelina for the reviews. On 9/26/2017 1:11 PM, Ewelina Musial wrote: On Tue, Sep 19, 2017 at 11:11:44PM +0530, Sagar Arun Kamble wrote: This function gives the status of RC6, whether disabled or if enabled then which state. intel_enable_rc6 will be used for enabling RC6 in the

Re: [Intel-gfx] [PATCH v2 08/11] drm/i915/execlists: Keep request->priority for its lifetime

2017-09-28 Thread Michał Winiarski
On Wed, Sep 27, 2017 at 04:44:37PM +, Chris Wilson wrote: > With preemption, we will want to "unsubmit" a request, taking it back > from the hw and returning it to the priority sorted execution list. In > order to know where to insert it into that list, we need to remember > its adjust priority

Re: [Intel-gfx] [PATCH igt 1/3] benchmark/gem_busy: Compare polling with syncobj_wait

2017-09-28 Thread Tvrtko Ursulin
On 28/09/2017 10:07, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-09-28 07:53:56) On 25/09/2017 21:26, Chris Wilson wrote: Signed-off-by: Chris Wilson --- benchmarks/gem_busy.c | 73 ++- 1 file changed, 72 insertions(+), 1 deletion(-)

Re: [Intel-gfx] [PATCH 15/31] drm/i915/slpc: Sanitize GuC version

2017-09-28 Thread Sagar Arun Kamble
On 9/21/2017 6:22 PM, Michal Wajdeczko wrote: On Tue, 19 Sep 2017 19:41:51 +0200, Sagar Arun Kamble wrote: From: Tom O'Rourke The SLPC interface is dependent on GuC version. Only GuC versions known to be compatible are supported here. SLPC with GuC firmware v9 is supported with this seri

Re: [Intel-gfx] [PATCH igt] lib: Capture the error state on an unexpected hang

2017-09-28 Thread Chris Wilson
Quoting Chris Wilson (2017-09-12 21:10:25) > Dump debugfs/i915_error_state to the debug channel if we detect an ERROR > uevent. This poses a few problems, not least that it is the auxiliary > process doing the dumping (so the output may be interleaved with the > test, but considering a hang occurre

Re: [Intel-gfx] [PATCH 16/31] drm/i915/slpc: Lay out SLPC init/enable/disable/cleanup helpers

2017-09-28 Thread Sagar Arun Kamble
On 9/21/2017 6:30 PM, Michal Wajdeczko wrote: On Tue, 19 Sep 2017 19:41:52 +0200, Sagar Arun Kamble wrote: SLPC operates based on parameters setup in shared data between i915 and GuC SLPC. This is to be created/initialized in intel_slpc_init. From there onwards i915 can control the SLPC ope

Re: [Intel-gfx] [PATCH v2 08/11] drm/i915/execlists: Keep request->priority for its lifetime

2017-09-28 Thread Chris Wilson
Quoting Michał Winiarski (2017-09-28 10:14:47) > On Wed, Sep 27, 2017 at 04:44:37PM +, Chris Wilson wrote: > > With preemption, we will want to "unsubmit" a request, taking it back > > from the hw and returning it to the priority sorted execution list. In > > order to know where to insert it in

Re: [Intel-gfx] [PATCH v2 08/11] drm/i915/execlists: Keep request->priority for its lifetime

2017-09-28 Thread Chris Wilson
Quoting Chris Wilson (2017-09-28 10:31:00) > Quoting Michał Winiarski (2017-09-28 10:14:47) > > Please, add the same behavior to GuC submission path. > > Why? To expand on this, there is a large negative cost in removing the dfs optimisation. What benefit does it bring to the execution when there

Re: [Intel-gfx] [PATCH] drm/i915/cnl: WaForceContextSaveRestoreNonCoherent

2017-09-28 Thread Chris Wilson
Stealing the thread for another gem_workarounds conundrum. After a reset, we lose the RING_FORCE_TO_NONPRIV registers. If they where in the context image as we presumed, the values would be retained and they can be read back from before reset, so it's not the case of write-only register! So are t

Re: [Intel-gfx] [PATCH 18/31] drm/i915/slpc: Add SLPC communication interfaces

2017-09-28 Thread Sagar Arun Kamble
On 9/21/2017 6:44 PM, Michal Wajdeczko wrote: On Tue, 19 Sep 2017 19:41:54 +0200, Sagar Arun Kamble wrote: Communication with SLPC is via Host to GuC interrupt through shared data and parameters. This patch defines the structure of shared data, parameters, data structure to be passed as inp

Re: [Intel-gfx] [PATCH igt 1/3] benchmark/gem_busy: Compare polling with syncobj_wait

2017-09-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-09-28 10:16:58) > > On 28/09/2017 10:07, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-09-28 07:53:56) > >> > >> On 25/09/2017 21:26, Chris Wilson wrote: > >>> Signed-off-by: Chris Wilson > >>> --- > >>>benchmarks/gem_busy.c | 73 > >>>

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bios: VBT parsing fixes and cleanups

2017-09-28 Thread Patchwork
== Series Details == Series: drm/i915/bios: VBT parsing fixes and cleanups URL : https://patchwork.freedesktop.org/series/31051/ State : success == Summary == Test perf: Subgroup blocking: pass -> FAIL (shard-hsw) fdo#102252 Test kms_cursor_legacy: S

Re: [Intel-gfx] [PATCH 20/31] drm/i915/slpc: Add parameter set/unset/get, task control/status functions

2017-09-28 Thread Sagar Arun Kamble
On 9/21/2017 7:17 PM, Michal Wajdeczko wrote: On Tue, 19 Sep 2017 19:41:56 +0200, Sagar Arun Kamble wrote: SLPC behavior can be changed through set of parameters. These parameters can be updated and queried from i915 though Host to GuC SLPC events. This patch adds parameter update events fo

[Intel-gfx] [PATCH] drm/i915/gen8+: Init/reset display interrupts only if i915 IRQs are enabled

2017-09-28 Thread Imre Deak
Only init / reset the display interrupts during power well enabling / disabling if the i915 interrupts are enabled. So far we did the init / reset during driver loading / resuming too, where initialization / enabling of the i915 interrupts happens only at a later point. This didn't cause a problem

Re: [Intel-gfx] [PATCH 21/31] drm/i915/slpc: Send RESET event to enable SLPC during Load/TDR

2017-09-28 Thread Sagar Arun Kamble
On 9/21/2017 7:36 PM, Michal Wajdeczko wrote: On Tue, 19 Sep 2017 19:41:57 +0200, Sagar Arun Kamble wrote: Send host2guc SLPC reset event to GuC post GuC load. Post this, i915 can ascertain if SLPC has started running successfully through shared data. This check is done during intel_init_gt

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Include fence-hint for timeout warning

2017-09-28 Thread Joonas Lahtinen
On Mon, 2017-09-11 at 09:41 +0100, Chris Wilson wrote: > If an asynchronous wait on a foriegn fence, we print a warning "foreign" Reviewed-by: Joonas Lahtinen Regards, Joonas > indicating which fence was not signaled. As i915_sw_fences become more > common, include the debug hint (the symbol-

Re: [Intel-gfx] [PATCH igt] lib: Capture the error state on an unexpected hang

2017-09-28 Thread Petri Latvala
On Tue, Sep 12, 2017 at 09:10:25PM +0100, Chris Wilson wrote: > Dump debugfs/i915_error_state to the debug channel if we detect an ERROR > uevent. This poses a few problems, not least that it is the auxiliary > process doing the dumping (so the output may be interleaved with the > test, but conside

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Try harder to finish the idle-worker

2017-09-28 Thread Joonas Lahtinen
On Mon, 2017-09-11 at 09:41 +0100, Chris Wilson wrote: > If a worker requeues itself, it may switch to a different kworker pool, > which flush_work() considers as complete. To be strict, we then need to > keep flushing the work until it is no longer pending. > > References: https://bugs.freedeskto

Re: [Intel-gfx] [PATCH] drm/i915/gen8+: Init/reset display interrupts only if i915 IRQs are enabled

2017-09-28 Thread Chris Wilson
Quoting Imre Deak (2017-09-28 11:06:24) > Only init / reset the display interrupts during power well enabling / > disabling if the i915 interrupts are enabled. So far we did the > init / reset during driver loading / resuming too, where > initialization / enabling of the i915 interrupts happens onl

Re: [Intel-gfx] [PATCH 24/31] drm/i915/slpc: Add debugfs support to read/write/revert the parameters

2017-09-28 Thread Sagar Arun Kamble
On 9/21/2017 8:37 PM, Michal Wajdeczko wrote: On Tue, 19 Sep 2017 19:42:00 +0200, Sagar Arun Kamble wrote: This patch adds two debugfs interfaces: 1. i915_slpc_paramlist: List of all parameters that Host can configure.    Currently listing id and description of each. 2. i915_slpc_param_ctl:

Re: [Intel-gfx] [PATCH 26/31] drm/i915/slpc: Add i915_slpc_info to debugfs

2017-09-28 Thread Sagar Arun Kamble
On 9/21/2017 8:43 PM, Michal Wajdeczko wrote: On Tue, 19 Sep 2017 19:42:02 +0200, Sagar Arun Kamble wrote: From: Tom O'Rourke i915_slpc_info shows the contents of SLPC shared data parsed into text format. v1: Reformat slpc info (Radek)     squashed query task state info     in slpc info,

Re: [Intel-gfx] [PATCH 06/11] drm/i915: Pin fence for iomap

2017-09-28 Thread Joonas Lahtinen
On Mon, 2017-09-11 at 09:41 +0100, Chris Wilson wrote: > Acquire the fence register for the iomap in i915_vma_pin_iomap() on > behalf of the caller. > > We probably want for the caller to specify whether the fence should be > pinned for their usage, but at the moment all callers do want the > asso

[Intel-gfx] [PATCH i-g-t v2 5/8] lib/igt_kms: Rework plane properties to be more atomic, v3.

2017-09-28 Thread Maarten Lankhorst
In the future I want to allow tests to commit more properties, but for this to work I have to fix all properties to work better with atomic commit. Instead of special casing each property make a bitmask for all property changed flags, and try to commit all properties. Changes since v1: - Remove sp

[Intel-gfx] [PATCH i-g-t v2 6/8] lib/igt_kms: Rework pipe properties to be more atomic, v3.

2017-09-28 Thread Maarten Lankhorst
In the future I want to allow tests to commit more properties, but for this to work I have to fix all properties to work better with atomic commit. Instead of special casing each property make a bitmask for all property changed flags, and try to commit all properties. This has been the most involv

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/gen8+: Init/reset display interrupts only if i915 IRQs are enabled

2017-09-28 Thread Patchwork
== Series Details == Series: drm/i915/gen8+: Init/reset display interrupts only if i915 IRQs are enabled URL : https://patchwork.freedesktop.org/series/31058/ State : warning == Summary == Series 31058v1 drm/i915/gen8+: Init/reset display interrupts only if i915 IRQs are enabled https://patc

[Intel-gfx] [PULL] drm-misc-fixes

2017-09-28 Thread Sean Paul
Hi Dave, Here's the latest from -misc-fixes. It's been a while since the last one due to plumbers and XDC. I'll be out of office next week, but will do my best to send -fixes amongst moving boxes and chaos. drm-misc-fixes-2017-09-28-1: Driver Changes: - qxl: fix primary surface and fb unpinning (G

Re: [Intel-gfx] [PATCH 10/11] drm/i915: Check PIN_NONFAULT overlaps in evict_for_node

2017-09-28 Thread Joonas Lahtinen
On Mon, 2017-09-25 at 09:40 +0100, Chris Wilson wrote: > Quoting Chris Wilson (2017-09-19 13:43:41) > > Quoting Chris Wilson (2017-09-11 09:41:34) > > > If the caller says that he doesn't want to evict any other faulting > > > vma, honour that flag. The logic was used in evict_something, but not >

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/igt_kms: Convert properties to be more atomic-like. (rev4)

2017-09-28 Thread Patchwork
== Series Details == Series: lib/igt_kms: Convert properties to be more atomic-like. (rev4) URL : https://patchwork.freedesktop.org/series/30903/ State : success == Summary == IGT patchset tested on top of latest successful build 2885b10f99b4beeb046e75af8b8488c229f629d3 igt/gem_exec_schedule:

Re: [Intel-gfx] [PATCH] drm/i915: Add has_psr-flag to gen9lp

2017-09-28 Thread David Weinehall
On Thu, Sep 28, 2017 at 04:20:29AM +, Rodrigo Vivi wrote: > On Wed, Sep 27, 2017 at 5:14 AM David Weinehall < > david.weineh...@linux.intel.com> wrote: > > > On Tue, Aug 08, 2017 at 12:50:51PM -0700, Rodrigo Vivi wrote: > > > a long time ago I had agreed with Daniel that we would only add new

[Intel-gfx] [PATCH i-g-t v2 5/8] lib/igt_kms: Rework plane properties to be more atomic, v4.

2017-09-28 Thread Maarten Lankhorst
In the future I want to allow tests to commit more properties, but for this to work I have to fix all properties to work better with atomic commit. Instead of special casing each property make a bitmask for all property changed flags, and try to commit all properties. Changes since v1: - Remove sp

Re: [Intel-gfx] [PATCH v2 08/11] drm/i915/execlists: Keep request->priority for its lifetime

2017-09-28 Thread Chris Wilson
Quoting Chris Wilson (2017-09-27 17:44:37) > With preemption, we will want to "unsubmit" a request, taking it back > from the hw and returning it to the priority sorted execution list. In > order to know where to insert it into that list, we need to remember > its adjust priority (which may change

[Intel-gfx] [PATCH igt] igt/gem_exec_schedule: Detect too slow setup in deep-*

2017-09-28 Thread Chris Wilson
Using vgem as our cork for building the request queue limits us to 10s of setup (or else the fence autoexpires and we start executing too early). Add timeouts to the setup loops and SKIP if we cannot establish the workload within 10s, the machine and driver is too slow to evaluate the expected resu

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/igt_kms: Convert properties to be more atomic-like. (rev5)

2017-09-28 Thread Patchwork
== Series Details == Series: lib/igt_kms: Convert properties to be more atomic-like. (rev5) URL : https://patchwork.freedesktop.org/series/30903/ State : success == Summary == IGT patchset tested on top of latest successful build 2885b10f99b4beeb046e75af8b8488c229f629d3 igt/gem_exec_schedule:

Re: [Intel-gfx] [PATCH] drm/i915: Also discard second CRC on gen8+ platforms.

2017-09-28 Thread Mika Kahola
On Wed, 2017-09-27 at 17:20 -0700, Rodrigo Vivi wrote: > One of the differences I spotted for GEN8+ platforms when > compared to older platforms is that spec for BDW+ includes > this sentence: > > "The first CRC done indication after CRC is first enabled is > from only a partial frame, so it will

Re: [Intel-gfx] [PATCH v10 1/9] drm/i915: Create GEM runtime resume helper and handle GEM suspend/resume errors

2017-09-28 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-09-27 10:30:31) > These changes are preparation to handle GuC suspend/resume. Prepared > helper i915_gem_runtime_resume to reinitialize suspended gem setup. > Returning status from i915_gem_runtime_suspend and i915_gem_resume. > This will be placeholder for handling

Re: [Intel-gfx] [PATCH v10 2/9] drm/i915: Update GEM suspend/resume flows considering GuC and GEM fences

2017-09-28 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-09-27 10:30:32) > @@ -4607,13 +4611,14 @@ int i915_gem_resume(struct drm_i915_private *dev_priv) > > mutex_lock(&dev->struct_mutex); > i915_gem_restore_gtt_mappings(dev_priv); > + i915_gem_restore_fences(dev_priv); Seconded Michal's suggestio

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/gen8+: Init/reset display interrupts only if i915 IRQs are enabled

2017-09-28 Thread Patchwork
== Series Details == Series: drm/i915/gen8+: Init/reset display interrupts only if i915 IRQs are enabled URL : https://patchwork.freedesktop.org/series/31058/ State : warning == Summary == Series 31058v1 drm/i915/gen8+: Init/reset display interrupts only if i915 IRQs are enabled https://patc

Re: [Intel-gfx] [PATCH v10 3/9] drm/i915: Create uC runtime and system suspend/resume helpers

2017-09-28 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-09-27 10:30:33) > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 174a7c5..f79646b 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -1698,6 +1698,16 @@ static int i915_drm_resume(struct

Re: [Intel-gfx] [PATCH v10 6/9] drm/i915/guc: Check execbuf client to disable submission and don't depend on enable_guc_submission

2017-09-28 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-09-27 10:30:36) > We should check dependent state setup by enable path to run disable path > and not depend on the user parameters. i915_guc_submission_disable now > checks if execbuf client is setup and then goes ahead with disabling. > > Suggested-by: Chris Wilson

[Intel-gfx] ✗ Fi.CI.IGT: failure for lib/igt_kms: Convert properties to be more atomic-like. (rev4)

2017-09-28 Thread Patchwork
== Series Details == Series: lib/igt_kms: Convert properties to be more atomic-like. (rev4) URL : https://patchwork.freedesktop.org/series/30903/ State : failure == Summary == Test gem_close_race: Subgroup basic-process: skip -> PASS (shard-hsw) Test kms_fro

Re: [Intel-gfx] [PATCH v2 01/11] drm/i915/execlists: Move request unwinding to a separate function

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > In the future, we will want to unwind requests following a preemption > point. This requires the same steps as for unwinding upon a reset, so > extract the existing code to a separate function for later use. > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Allow optimized platform checks

2017-09-28 Thread Tvrtko Ursulin
On 27/09/2017 18:07, Patchwork wrote: == Series Details == Series: drm/i915: Allow optimized platform checks URL : https://patchwork.freedesktop.org/series/30982/ State : success == Summary == Series 30982v1 drm/i915: Allow optimized platform checks https://patchwork.freedesktop.org/api/1.0

Re: [Intel-gfx] [PATCH v10 9/9] drm/i915/guc: Fix GuC cleanup in unload path

2017-09-28 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-09-27 10:30:39) > -void intel_uc_fini_hw(struct drm_i915_private *dev_priv) > +void intel_uc_cleanup(struct drm_i915_private *dev_priv) > { > guc_free_load_err_log(&dev_priv->guc); > > if (!i915_modparams.enable_guc_loading) > retur

Re: [Intel-gfx] [PATCH v10 3/9] drm/i915: Create uC runtime and system suspend/resume helpers

2017-09-28 Thread Sagar Arun Kamble
On 9/28/2017 5:15 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-09-27 10:30:33) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 174a7c5..f79646b 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -1698,6 +1698,16

Re: [Intel-gfx] [PATCH v2 02/11] drm/i915/execlists: Cache the last priolist lookup

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > From: Michał Winiarski > > Avoid the repeated rbtree lookup for each request as we unwind them by > tracking the last priolist. > > v2: Fix up my unhelpful suggestion of using default_priolist. > > Signed-off-by: Michał Winiarski > Signe

Re: [Intel-gfx] [PATCH] drm/i915/gen8+: Init/reset display interrupts only if i915 IRQs are enabled

2017-09-28 Thread Imre Deak
On Thu, Sep 28, 2017 at 11:18:27AM +0100, Chris Wilson wrote: > Quoting Imre Deak (2017-09-28 11:06:24) > > Only init / reset the display interrupts during power well enabling / > > disabling if the i915 interrupts are enabled. So far we did the > > init / reset during driver loading / resuming too

Re: [Intel-gfx] [PATCH] drm/i915/gen8+: Init/reset display interrupts only if i915 IRQs are enabled

2017-09-28 Thread Chris Wilson
Quoting Imre Deak (2017-09-28 12:59:16) > On Thu, Sep 28, 2017 at 11:18:27AM +0100, Chris Wilson wrote: > > Quoting Imre Deak (2017-09-28 11:06:24) > > > Only init / reset the display interrupts during power well enabling / > > > disabling if the i915 interrupts are enabled. So far we did the > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/gem_exec_schedule: Detect too slow setup in deep-*

2017-09-28 Thread Patchwork
== Series Details == Series: igt/gem_exec_schedule: Detect too slow setup in deep-* URL : https://patchwork.freedesktop.org/series/31061/ State : success == Summary == IGT patchset tested on top of latest successful build 2885b10f99b4beeb046e75af8b8488c229f629d3 igt/gem_exec_schedule: Ignore

Re: [Intel-gfx] [PATCH v2 02/11] drm/i915/execlists: Cache the last priolist lookup

2017-09-28 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-09-28 12:59:01) > On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > > From: Michał Winiarski > > > > Avoid the repeated rbtree lookup for each request as we unwind them by > > tracking the last priolist. > > > > v2: Fix up my unhelpful suggestion of using def

Re: [Intel-gfx] [PATCH v2 03/11] drm/i915/preempt: Fix WaEnablePreemptionGranularityControlByUMD

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > From: Jeff McGee > > The WA applies to all production Gen9 and requires both enabling and > whitelisting of the per-context preemption control register. > > Signed-off-by: Jeff McGee > Signed-off-by: Michał Winiarski > Signed-off-by: Chr

Re: [Intel-gfx] [PATCH] drm/i915/gen8+: Init/reset display interrupts only if i915 IRQs are enabled

2017-09-28 Thread Imre Deak
On Thu, Sep 28, 2017 at 01:01:34PM +0100, Chris Wilson wrote: > Quoting Imre Deak (2017-09-28 12:59:16) > > On Thu, Sep 28, 2017 at 11:18:27AM +0100, Chris Wilson wrote: > > > Quoting Imre Deak (2017-09-28 11:06:24) > > > > Only init / reset the display interrupts during power well enabling / > > >

Re: [Intel-gfx] [PATCH v2 04/11] drm/i915/preempt: Default to disabled mid-command preemption levels

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > From: Michał Winiarski > > Supporting fine-granularity preemption levels may require changes in > userspace batch buffer programming. Therefore, we need to fallback to > safe default values, rather that use hardware defaults. Userspace is >

Re: [Intel-gfx] [PATCH v2 05/11] drm/i915/execlists: Distinguish the incomplete context notifies

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > Let the listener know that the context we just scheduled out was not > complete, and will be scheduled back in at a later point. > > v2: Handle CONTEXT_STATUS_PREEMPTED in gvt by aliasing it to > CONTEXT_STATUS_OUT for the moment, gvt can ex

Re: [Intel-gfx] [PATCH v2 06/11] drm/i915: Introduce a preempt context

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > Add another perma-pinned context for using for preemption at any time. > We cannot just reuse the existing kernel context, as first and foremost > we need to ensure that we can preempt the kernel context itself, so > require a distinct contex

[Intel-gfx] ✗ Fi.CI.IGT: failure for lib/igt_kms: Convert properties to be more atomic-like. (rev5)

2017-09-28 Thread Patchwork
== Series Details == Series: lib/igt_kms: Convert properties to be more atomic-like. (rev5) URL : https://patchwork.freedesktop.org/series/30903/ State : failure == Summary == Test gem_exec_schedule: Subgroup pi-ringfull-blt: pass -> SKIP (shard-hsw)

Re: [Intel-gfx] [PATCH v2 06/11] drm/i915: Introduce a preempt context

2017-09-28 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-09-28 13:32:09) > On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > > Add another perma-pinned context for using for preemption at any time. > > We cannot just reuse the existing kernel context, as first and foremost > > we need to ensure that we can preempt the

Re: [Intel-gfx] [PATCH v2 07/11] drm/i915/execlists: Move bdw GPGPU w/a to emit_bb

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > Move the re-enabling of MI arbitration from a per-bb w/a buffer to the > emission of the batch buffer itself. > > Signed-off-by: Chris Wilson There's something about 64b addressing mode requiring disabling ARB during the BB_START on pre-BD

Re: [Intel-gfx] [PATCH v2 08/11] drm/i915/execlists: Keep request->priority for its lifetime

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > With preemption, we will want to "unsubmit" a request, taking it back > from the hw and returning it to the priority sorted execution list. In > order to know where to insert it into that list, we need to remember > its adjust priority (which

[Intel-gfx] ✗ Fi.CI.IGT: failure for lib/igt_kms: Convert properties to be more atomic-like. (rev4)

2017-09-28 Thread Patchwork
== Series Details == Series: lib/igt_kms: Convert properties to be more atomic-like. (rev4) URL : https://patchwork.freedesktop.org/series/30903/ State : failure == Summary == Test kms_cursor_legacy: Subgroup cursorA-vs-flipA-atomic-transitions: fail -> PASS

[Intel-gfx] ✗ Fi.CI.IGT: failure for lib/igt_kms: Convert properties to be more atomic-like. (rev5)

2017-09-28 Thread Patchwork
== Series Details == Series: lib/igt_kms: Convert properties to be more atomic-like. (rev5) URL : https://patchwork.freedesktop.org/series/30903/ State : failure == Summary == Test gem_eio: Subgroup in-flight-contexts: dmesg-warn -> PASS (shard-hsw) fdo#102886 +1

Re: [Intel-gfx] [PATCH v2 09/11] drm/i915: Expand I915_PARAM_HAS_SCHEDULER into a capability bitmask

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > In the next few patches, we wish to enable different features for the > scheduler, some which may subtlety change ABI (e.g. allow requests to be > reordered under different circumstances). So we need to make sure > userspace is cognizant of t

Re: [Intel-gfx] [PATCH v2 09/11] drm/i915: Expand I915_PARAM_HAS_SCHEDULER into a capability bitmask

2017-09-28 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-09-28 14:07:35) > On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > > In the next few patches, we wish to enable different features for the > > scheduler, some which may subtlety change ABI (e.g. allow requests to be > > reordered under different circumstances).

Re: [Intel-gfx] [PATCH v10 9/9] drm/i915/guc: Fix GuC cleanup in unload path

2017-09-28 Thread Sagar Arun Kamble
On 9/28/2017 5:25 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-09-27 10:30:39) -void intel_uc_fini_hw(struct drm_i915_private *dev_priv) +void intel_uc_cleanup(struct drm_i915_private *dev_priv) { guc_free_load_err_log(&dev_priv->guc); if (!i915_modparams.enab

Re: [Intel-gfx] [PATCH v10 6/9] drm/i915/guc: Check execbuf client to disable submission and don't depend on enable_guc_submission

2017-09-28 Thread Sagar Arun Kamble
On 9/28/2017 5:17 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-09-27 10:30:36) We should check dependent state setup by enable path to run disable path and not depend on the user parameters. i915_guc_submission_disable now checks if execbuf client is setup and then goes ahead with d

Re: [Intel-gfx] [PATCH v10 2/9] drm/i915: Update GEM suspend/resume flows considering GuC and GEM fences

2017-09-28 Thread Sagar Arun Kamble
On 9/28/2017 5:10 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-09-27 10:30:32) @@ -4607,13 +4611,14 @@ int i915_gem_resume(struct drm_i915_private *dev_priv) mutex_lock(&dev->struct_mutex); i915_gem_restore_gtt_mappings(dev_priv); + i915_gem_restore_fence

[Intel-gfx] ✓ Fi.CI.IGT: success for igt/gem_exec_schedule: Detect too slow setup in deep-*

2017-09-28 Thread Patchwork
== Series Details == Series: igt/gem_exec_schedule: Detect too slow setup in deep-* URL : https://patchwork.freedesktop.org/series/31061/ State : success == Summary == Test gem_eio: Subgroup in-flight: pass -> DMESG-WARN (shard-hsw) fdo#102886 +2 Test gem_exec_rel

Re: [Intel-gfx] [PATCH v2 08/11] drm/i915/execlists: Keep request->priority for its lifetime

2017-09-28 Thread Michał Winiarski
On Thu, Sep 28, 2017 at 11:09:14AM +, Chris Wilson wrote: > Quoting Chris Wilson (2017-09-27 17:44:37) > > With preemption, we will want to "unsubmit" a request, taking it back > > from the hw and returning it to the priority sorted execution list. In > > order to know where to insert it into t

Re: [Intel-gfx] [PATCH v10 1/9] drm/i915: Create GEM runtime resume helper and handle GEM suspend/resume errors

2017-09-28 Thread Sagar Arun Kamble
On 9/28/2017 5:07 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-09-27 10:30:31) These changes are preparation to handle GuC suspend/resume. Prepared helper i915_gem_runtime_resume to reinitialize suspended gem setup. Returning status from i915_gem_runtime_suspend and i915_gem_resume.

[Intel-gfx] [PATCH igt] tests/gem_workarounds: Skip write only registers

2017-09-28 Thread Mika Kuoppala
We have no means to check write only registers as this would need access through context image. For now we know that cnl has a one such register, 0xe5f0 which is used to set WaForceContextSaveRestoreNonCoherent:cnl. By inspecting the context image without and with workaround applied: 0xa840: 0

Re: [Intel-gfx] [PATCH igt] tests/gem_workarounds: Skip write only registers

2017-09-28 Thread Chris Wilson
Quoting Mika Kuoppala (2017-09-28 14:45:06) > We have no means to check write only registers as > this would need access through context image. For now we > know that cnl has a one such register, 0xe5f0 which is used > to set WaForceContextSaveRestoreNonCoherent:cnl. By inspecting > the context ima

Re: [Intel-gfx] [PATCH v2 10/11] drm/i915/execlists: Preemption!

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > When we write to ELSP, it triggers a context preemption at the earliest > arbitration point (3DPRIMITIVE, some PIPECONTROLs, a few other > operations and the explicit MI_ARB_CHECK). If this is to the same > context, it triggers a LITE_RESTORE

Re: [Intel-gfx] [PATCH igt] tests/gem_workarounds: Skip write only registers

2017-09-28 Thread Petri Latvala
On Thu, Sep 28, 2017 at 04:45:06PM +0300, Mika Kuoppala wrote: > We have no means to check write only registers as > this would need access through context image. For now we > know that cnl has a one such register, 0xe5f0 which is used > to set WaForceContextSaveRestoreNonCoherent:cnl. By inspectin

Re: [Intel-gfx] [PATCH v2 11/11] drm/i915/scheduler: Support user-defined priorities

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 17:44 +0100, Chris Wilson wrote: > Use a priority stored in the context as the initial value when > submitting a request. This allows us to change the default priority on a > per-context basis, allowing different contexts to be favoured with GPU > time at the expense of lower

Re: [Intel-gfx] [PATCH v1] drm/i915: Enhanced for initialize partially filled pagetables

2017-09-28 Thread Joonas Lahtinen
On Thu, 2017-09-28 at 10:09 +0800, Xiaolin Zhang wrote: > if vgpu active, the page table entry should be initialized after > allocation and then the hypersivor can ping pages succesuffly, > otherwise hypervisor will ping pages failed and the host will print > a lot of annoying errors such as “ERROR

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/gem_workarounds: Skip write only registers

2017-09-28 Thread Patchwork
== Series Details == Series: tests/gem_workarounds: Skip write only registers URL : https://patchwork.freedesktop.org/series/31073/ State : success == Summary == IGT patchset tested on top of latest successful build 2885b10f99b4beeb046e75af8b8488c229f629d3 igt/gem_exec_schedule: Ignore set-pr

Re: [Intel-gfx] [PATCH igt v3] igt/gem_exec_scheduler: HAS_SCHEDULER no longer means HAS_PREEMPTION

2017-09-28 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 19:47 +0100, Chris Wilson wrote: > Michal wants to limit machines that can do preemption, which means that > we no longer can assume that if we have a scheduler for execbuf, that > implies we have preemption. > > v2: Try a capability mask instead > v3: Pretty print the caps.

[Intel-gfx] [PATCH] drm/i915: Inherit Kabylake platform features from Skylake

2017-09-28 Thread Chris Wilson
I recently tried to update the gen9 feature matrix and to my unpleasant surprise found that Kabylake still acted like Broadwell and didn't enable the feature. This is because kbl/cfl are inheriting their defaults from Broadwell and not Skylake. Signed-off-by: Chris Wilson Cc: Rodrigo Vivi Cc: Pa

[Intel-gfx] [PATCH igt] tests/gem_workarounds: Skip write only registers

2017-09-28 Thread Mika Kuoppala
We have no means to check write only registers as this would need access through context image. For now we know that cnl has a one such register, 0xe5f0 which is used to set WaForceContextSaveRestoreNonCoherent:cnl. By inspecting the context image without and with workaround applied: 0xa840: 0

Re: [Intel-gfx] [PATCH igt] tests/gem_workarounds: Skip write only registers

2017-09-28 Thread Petri Latvala
On Thu, Sep 28, 2017 at 06:00:03PM +0300, Mika Kuoppala wrote: > We have no means to check write only registers as > this would need access through context image. For now we > know that cnl has a one such register, 0xe5f0 which is used > to set WaForceContextSaveRestoreNonCoherent:cnl. By inspectin

[Intel-gfx] [PATCH i-g-t 2/2] meson: Also build kms_atomic_interruptible

2017-09-28 Thread Petri Latvala
Signed-off-by: Petri Latvala --- tests/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/meson.build b/tests/meson.build index 1c619179..53d02d13 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -152,6 +152,7 @@ test_progs = [ 'kms_3d', 'kms_addfb_basi

Re: [Intel-gfx] [PATCH i-g-t 2/2] meson: Also build kms_atomic_interruptible

2017-09-28 Thread Daniel Vetter
On Thu, Sep 28, 2017 at 06:10:48PM +0300, Petri Latvala wrote: > Signed-off-by: Petri Latvala > --- > tests/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/meson.build b/tests/meson.build > index 1c619179..53d02d13 100644 > --- a/tests/meson.build > +++ b/tests/meson.b

  1   2   >