Re: [Intel-gfx] [PATCH v4 1/5] drm/i915: setup bridge for HDMI LPE audio driver

2017-01-24 Thread Anand, Jerome
> -Original Message- > From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > Sent: Monday, January 23, 2017 4:24 PM > To: Anand, Jerome ; intel- > g...@lists.freedesktop.org; alsa-de...@alsa-project.org > Cc: ti...@suse.de; broo...@kernel.org; Ughreja, Rakesh A > > Subject: Re: [Intel

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Introduce IS_GEN9_BC for Skylake and Kabylake.

2017-01-24 Thread Ander Conselvan De Oliveira
On Mon, 2017-01-23 at 10:32 -0800, Rodrigo Vivi wrote: > Along with GLK it was introduced the .is_lp and IS_GEN9_LP. > So, following the same simplification standard we can > put Skylake and Kabylake under the same bucket for most > of the things. > > So let's add the IS_GEN9_BC for "Big Core" (no

Re: [Intel-gfx] [PATCH] drm/i915: Move atomic state free from out of fence release

2017-01-24 Thread Joonas Lahtinen
On ma, 2017-01-23 at 21:29 +, Chris Wilson wrote: > Fences are required to support being released from under an atomic context. > The drm_atomic_state struct may take a mutex when being released and so > we cannot drop a reference to the drm_atomic_state from the fence release > path directly,

Re: [Intel-gfx] [PATCH v4 2/5] drm/i915: Add support for audio driver notifications

2017-01-24 Thread Anand, Jerome
> -Original Message- > From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > Sent: Tuesday, January 24, 2017 12:31 PM > To: Pierre-Louis Bossart ; Anand, > Jerome ; intel-gfx@lists.freedesktop.org; alsa- > de...@alsa-project.org > Cc: ti...@suse.de; broo...@kernel.org; Ughreja, Rakesh

Re: [Intel-gfx] [PATCH i-g-t v1 04/32] lib/igt_kms: Implement dynamic plane count support

2017-01-24 Thread Petri Latvala
On Mon, Jan 23, 2017 at 10:47:02AM -0500, Robert Foss wrote: > In the subsequent patches I clear up all of the IGT_PLANE_* being missing > issues (which does mean that trunk does not build between the > enum being removed and that the individual test being fixed). > > I could fix this by moving th

Re: [Intel-gfx] [PATCH] drm/i915: Move atomic state free from out of fence release

2017-01-24 Thread Chris Wilson
On Tue, Jan 24, 2017 at 10:39:44AM +0200, Joonas Lahtinen wrote: > On ma, 2017-01-23 at 21:29 +, Chris Wilson wrote: > > Fences are required to support being released from under an atomic context. > > The drm_atomic_state struct may take a mutex when being released and so > > we cannot drop a r

Re: [Intel-gfx] [PATCH] igt/gem_exec_schedule: Use igt_spin_batch

2017-01-24 Thread Chris Wilson
On Tue, Jan 24, 2017 at 08:33:13AM +0200, Abdiel Janulgue wrote: It is not equivalent. gem_exec_schedule needs to emit multiple recursive batches to ensure that the ELSP ports are filled (a bit of inside driver knowledge leaking through as we can only reorder unsubmitted batches at the moment). Th

Re: [Intel-gfx] [PATCH igt] intel-ci: Add multiple ringfill for execlists

2017-01-24 Thread Chris Wilson
On Wed, Jan 18, 2017 at 08:54:10PM +, Chris Wilson wrote: > Execlists introduces a new wrinkle to filling rings, in that each > context has an independent set of rings. Add the subtest that exercises > filling multiple execlist rings (for the same engine) to BAT. > > Signed-off-by: Chris Wilso

Re: [Intel-gfx] [PATCH i-g-t v4] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

2017-01-24 Thread Petri Latvala
Just one more nitpick (in two parts) below. With that, you can consider this now to be Reviewed-by: Petri Latvala This patch can be pushed when the kernel changes that contain "must be kept in sync" numbers in intel_dp_compliance.c have landed (and have been double-checked to match). -- Petri

Re: [Intel-gfx] [PATCH v2 06/13] i2c: designware-baytrail: Disallow the CPU to enter C6 or C7 while holding the punit semaphore

2017-01-24 Thread Andy Shevchenko
On Mon, 2017-01-23 at 22:09 +0100, Hans de Goede wrote: > On my cherrytrail tablet with axp288 pmic, just doing a bunch of > repeated > reads from the pmic, e.g. "i2cdump -y 14 0x34" would lookup the tablet > in > 1 - 3 runs guaranteed. > > This seems to be causes by the cpu trying to enter C6 or

Re: [Intel-gfx] [PATCH] igt/gem_exec_schedule: Use igt_spin_batch

2017-01-24 Thread Abdiel Janulgue
On 24.01.2017 11:26, Chris Wilson wrote: > On Tue, Jan 24, 2017 at 08:33:13AM +0200, Abdiel Janulgue wrote: > > It is not equivalent. gem_exec_schedule needs to emit multiple recursive > batches to ensure that the ELSP ports are filled (a bit of inside driver > knowledge leaking through as we ca

[Intel-gfx] [PATCH v5 2/5] drm/i915: Add support for audio driver notifications

2017-01-24 Thread Jerome Anand
Notifiations like mode change, hot plug and edid to the audio driver are added. This is inturn used by the audio driver for its functionality. A new interface file capturing the notifications needed by the audio driver is added Signed-off-by: Pierre-Louis Bossart Signed-off-by: Jerome Anand ---

[Intel-gfx] [PATCH v5 5/5] ALSA: x86: hdmi: continue playback even when display resolution changes

2017-01-24 Thread Jerome Anand
When the display resolution changes, the drm disables the display pipes due to which audio rendering stops. At this time, we need to ensure the existing audio pointers and buffers are cleared out so that the playback can restarted once the display pipe is enabled with a different N/CTS values Sign

[Intel-gfx] [PATCH v5 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT

2017-01-24 Thread Jerome Anand
Hdmi audio driver based on the child platform device created by gfx driver is implemented. This audio driver is derived from legacy intel hdmi audio driver. The interfaces for interaction between gfx and audio are updated and the driver implementation updated to derive interrupts in its own addres

[Intel-gfx] [PATCH v5 0/5] Add support for Legacy HDMI audio drivers

2017-01-24 Thread Jerome Anand
Legacy (CherryTrail/ Baytrail) HDMI audio drivers added Legacy hdmi audio-Gfx interaction/ interfacing is updated to use irq chip framework This patch series has only been tested on hardware with a single HDMI connector/pipe and additional work may be needed for newer machines with 2 connectors

[Intel-gfx] [PATCH v5 3/5] ALSA: add Intel HDMI LPE audio driver for BYT/CHT-T

2017-01-24 Thread Jerome Anand
On Baytrail and Cherrytrail, HDaudio may be fused out or disabled by the BIOS. This driver enables an alternate path to the i915 display registers and DMA. Although there is no hardware path between i915 display and LPE/SST audio clusters, this HDMI capability is referred to in the documentation a

[Intel-gfx] [PATCH v5 1/5] drm/i915: setup bridge for HDMI LPE audio driver

2017-01-24 Thread Jerome Anand
Enable support for HDMI LPE audio mode on Baytrail and Cherrytrail when HDaudio controller is not detected Setup minimum required resources during i915_driver_load: 1. Create a platform device to share MMIO/IRQ resources 2. Make the platform device child of i915 device for runtime PM. 3. Create IR

[Intel-gfx] [PATCH v3 4/8] drm/i915: Only run execlist context-switch handler after an interrupt

2017-01-24 Thread Chris Wilson
Mark when we run the execlist tasklet following the interrupt, so we don't probe a potentially uninitialised register when submitting the contexts multiple times before the hardware responds. v2: Use a shared engine->irq_posted Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Tvrtko Ursulin ir

[Intel-gfx] [PATCH v3 8/8] drm/i915: Emit dma-fence (and execlists submit) first from signaler

2017-01-24 Thread Chris Wilson
When introduced, I thought that reducing client latency from the signaler was the priority. Since its inception the signaler has become responsible for keeping the execlists full, via the dma-fence. As this is very important to minimise overall execution time, signal the dma-fence first and then si

[Intel-gfx] [PATCH v3 5/8] drm/i915: Skip the execlists CSB scan and rewrite if the ring is untouched

2017-01-24 Thread Chris Wilson
If the CSB head/tail pointers are unchanged, we can skip the update of the CSB register afterwards. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_lrc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH v3 7/8] drm/i915: Dequeue execlists on a new request if any port is available

2017-01-24 Thread Chris Wilson
If the second ELSP port is available, schedule the execlists tasklet to see if the new request can occupy it. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_lrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[Intel-gfx] [PATCH v3 6/8] drm/i915: Only attempt to pass the first request to execlists

2017-01-24 Thread Chris Wilson
Only the first request added to the execlist queue, can be submitted. If this request is not the first request on the queue, it means that there are already higher priority requests waiting upon the tasklet and kicking it will make no difference. This is more relevant for a later patch, where we m

[Intel-gfx] [PATCH v3 3/8] drm/i915: Move breadcrumbs irq_posted up a level to engine

2017-01-24 Thread Chris Wilson
In the next patch, we will use the irq_posted technique for another engine interrupt, rather than use two members for the atomic updates, we can use two bits of one instead. First, we need to update the breadcrumbs to use the new common engine->irq_posted. Signed-off-by: Chris Wilson Cc: Mika Kuo

[Intel-gfx] [PATCH v3 1/8] drm/i915: Assert that we don't submit to execlists whilst a preempt is pending

2017-01-24 Thread Chris Wilson
To complement the check in execlists_elsp_ready(), also assert that we don't submit the same context while it has a lite restore still pending. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_lrc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[Intel-gfx] [PATCH v3 2/8] drm/i915: Only disable execlist preemption for the duration of the request

2017-01-24 Thread Chris Wilson
We need to prevent resubmission of the context immediately following an initial resubmit (which does a lite-restore preemption). Currently we do this by disabling all submission whilst the context is still active, but we can improve this by limiting the restriction to only until we receive notifica

[Intel-gfx] [CI 2/2] drm/i915: Reset the gpu on takeover

2017-01-24 Thread Chris Wilson
The GPU may be in an unknown state following resume and module load. The previous occupant may have left contexts loaded, or other dangerous state, which can cause an immediate GPU hang for us. The only save course of action is to reset the GPU prior to using it - similarly to how we reset the GPU

[Intel-gfx] [CI 1/2] drm/i915: Split intel_engine allocation and initialisation

2017-01-24 Thread Chris Wilson
In order to reset the GPU early on in the module load sequence, we need to allocate the basic engine structs (to populate the mmio offsets etc). Currently, the engine initialisation allocates both the base struct and also allocate auxiliary objects, which depend upon state setup quite late in the l

Re: [Intel-gfx] [PATCH igt] intel-ci: Add multiple ringfill for execlists

2017-01-24 Thread Petri Latvala
On Tue, Jan 24, 2017 at 09:31:39AM +, Chris Wilson wrote: > On Wed, Jan 18, 2017 at 08:54:10PM +, Chris Wilson wrote: > > Execlists introduces a new wrinkle to filling rings, in that each > > context has an independent set of rings. Add the subtest that exercises > > filling multiple execli

[Intel-gfx] [PATCH 1/1] drm/i915: Copy user requested buffers into the error state

2017-01-24 Thread Mika Kuoppala
From: Chris Wilson Introduce a new execobject.flag (EXEC_OBJECT_CAPTURE) that userspace may use to indicate that it wants the contents of this buffer preserved in the error state (/sys/class/drm/cardN/error) following a GPU hang involving this batch. Use this at your discretion, the contents of

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add support for Legacy HDMI audio drivers (rev6)

2017-01-24 Thread Patchwork
== Series Details == Series: Add support for Legacy HDMI audio drivers (rev6) URL : https://patchwork.freedesktop.org/series/16254/ State : failure == Summary == Series 16254v6 Add support for Legacy HDMI audio drivers https://patchwork.freedesktop.org/api/1.0/series/16254/revisions/6/mbox/ T

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/8] drm/i915: Assert that we don't submit to execlists whilst a preempt is pending

2017-01-24 Thread Patchwork
== Series Details == Series: series starting with [v3,1/8] drm/i915: Assert that we don't submit to execlists whilst a preempt is pending URL : https://patchwork.freedesktop.org/series/18474/ State : success == Summary == Series 18474v1 Series without cover letter https://patchwork.freedeskto

[Intel-gfx] [PATCH] dma/fence: Export enable-signaling tracepoint for emission by drivers

2017-01-24 Thread Chris Wilson
Currently this tracepoint is solely used by dma_fence_enable_sw_signaling, however I have a need to manually perform the hw enabling of the signaling and would like to emit this tracepoint for completeness. Signed-off-by: Chris Wilson Cc: Sumit Semwal Cc: Daniel Vetter --- drivers/dma-buf/dma-

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Split intel_engine allocation and initialisation

2017-01-24 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Split intel_engine allocation and initialisation URL : https://patchwork.freedesktop.org/series/18475/ State : success == Summary == Series 18475v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder

2017-01-24 Thread David Weinehall
On Fri, Jan 20, 2017 at 08:21:55PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Let's clean up the mess we have in the if ladder that assigns the > .get_cdclk() hooks. The grouping of the platforms by the function > results in a thing that's not really legible, so let's d

Re: [Intel-gfx] [PATCH v2 01/14] drm/i915: Store the pipe pixel rate in the crtc state

2017-01-24 Thread David Weinehall
On Fri, Jan 20, 2017 at 08:21:52PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Rather than recomptuing the pipe pixel rate on demand everwhere, let's recomputing, everywhere > just stick the precomputed value into the crtc state. > > v2: Rebase due to min_pixclk[] cod

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Split intel_engine allocation and initialisation

2017-01-24 Thread Chris Wilson
On Tue, Jan 24, 2017 at 12:24:10PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/2] drm/i915: Split intel_engine allocation > and initialisation > URL : https://patchwork.freedesktop.org/series/18475/ > State : success > > == Summary == > > Series 18475

Re: [Intel-gfx] [PATCH 3/3] drm/i915/glk: Turn on workarounds that apply to Geminilake too

2017-01-24 Thread David Weinehall
On Thu, Jan 12, 2017 at 01:47:37PM +0200, Ander Conselvan de Oliveira wrote: > Apply workarounds to Geminilake, and annoatate those that are applied annotate > uncondionally when they apply to GLK based on the workaround database. unconditionally > > Signed-off-by: Ander Conselvan de Oliveira

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915: Copy user requested buffers into the error state

2017-01-24 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915: Copy user requested buffers into the error state URL : https://patchwork.freedesktop.org/series/18476/ State : success == Summary == Series 18476v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/18

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: setup bridge for HDMI LPE audio driver

2017-01-24 Thread Jani Nikula
On Wed, 25 Jan 2017, Jerome Anand wrote: > Enable support for HDMI LPE audio mode on Baytrail and > Cherrytrail when HDaudio controller is not detected > > Setup minimum required resources during i915_driver_load: > 1. Create a platform device to share MMIO/IRQ resources > 2. Make the platform dev

Re: [Intel-gfx] [PATCH v5 2/5] drm/i915: Add support for audio driver notifications

2017-01-24 Thread Jani Nikula
On Wed, 25 Jan 2017, Jerome Anand wrote: > Notifiations like mode change, hot plug and edid to > the audio driver are added. This is inturn used by the > audio driver for its functionality. > > A new interface file capturing the notifications needed by the > audio driver is added > > Signed-off-by

Re: [Intel-gfx] [PATCH] drm/i915: Fix not finding the VBT when it overlaps with OPREGION_ASLE_EXT

2017-01-24 Thread Jani Nikula
On Mon, 23 Jan 2017, Hans de Goede wrote: > Hi, > > On 23-01-17 11:36, Jani Nikula wrote: >> On Fri, 20 Jan 2017, Hans de Goede wrote: >>> Hi, >>> >>> On 31-12-16 17:00, Hans de Goede wrote: Hi, On 27-12-16 11:58, Jani Nikula wrote: > On Sun, 25 Dec 2016, Hans de Goede wrote:

[Intel-gfx] [PATCH 1/4] drm/i915: Disable plane gamma in SKL+ sprite planes

2017-01-24 Thread Ander Conselvan de Oliveira
The plane gamma tables are never programmed, so just disable it, like it is done for the primary plane. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_sprite.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 3/4] drm/i915/glk: Program pipe gamma and degamma tables

2017-01-24 Thread Ander Conselvan de Oliveira
The gamma tables in Geminilake were changed. There is no split-gamma mode. Instead, there is a dedicated degamma table that is enabled whenever pipe CSC is enabled. The dedicated gamma table has 16 bit precision but doesn't support separate channels. Since that doesn't match the per-channel format

[Intel-gfx] [PATCH 4/4] drm/i915/glk: Enable pipe CSC

2017-01-24 Thread Ander Conselvan de Oliveira
Now that the pre-csc degamma table is set up correctly in Geminilake, pipe CSC can be enabled without causing a black screen. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_sprite.c | 1 + 2 files changed, 2 insertions(+)

[Intel-gfx] [PATCH 2/4] drm/i915/glk: Plane color correction register changes

2017-01-24 Thread Ander Conselvan de Oliveira
From: Ander Conselvan De Oliveira In Geminilake, the bits for enabling pipe csc, pipe gamma and plane gamma moved to a new register. So update the plane update functions to set the right bits. Pipe CSC is kept disabled though, since enabling that also enables the dedicated degamma table, and tha

[Intel-gfx] [igt PATCH 3/6] intel_bios_reader: add hex dumping of headers

2017-01-24 Thread Jani Nikula
Signed-off-by: Jani Nikula --- tools/intel_bios_reader.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/intel_bios_reader.c b/tools/intel_bios_reader.c index 83fc819b6cdc..9f75d850d3fb 100644 --- a/tools/intel_bios_reader.c +++ b/tools/intel_bios_reader.c @@ -1654,6 +1654,8 @@ stat

[Intel-gfx] [igt PATCH 1/6] intel_bios_reader: add more structured printout of headers

2017-01-24 Thread Jani Nikula
Make the different parts of the VBT stand out better in the output. Signed-off-by: Jani Nikula --- tools/intel_bios_reader.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tools/intel_bios_reader.c b/tools/intel_bios_reader.c index 3455296bc008..c7572bde8c7e

[Intel-gfx] [igt PATCH 5/6] intel_bios_reader: print more VBT and BDB header info

2017-01-24 Thread Jani Nikula
Add more info and realign accordingly. Signed-off-by: Jani Nikula --- tools/intel_bios_reader.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tools/intel_bios_reader.c b/tools/intel_bios_reader.c index 6581abf51472..301cd1ccdcf0 100644 --- a/tools/intel_

[Intel-gfx] [igt PATCH 6/6] tools: rename intel_bios_reader to intel_vbt_decode

2017-01-24 Thread Jani Nikula
After all these years intel_bios_reader and intel_bios_dumper still manage to confuse me. Read or dump, which one decodes. Rename intel_bios_reader to intel_vbt_decode to be in line with the naming of all the other tools (particularly the closely related intel_opregion_decode tool) that decode prev

[Intel-gfx] [igt PATCH 4/6] intel_bios_reader: be more informative about unknown blocks

2017-01-24 Thread Jani Nikula
We don't know how to decode all blocks, make it clear this is not an error. Signed-off-by: Jani Nikula --- tools/intel_bios_reader.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/intel_bios_reader.c b/tools/intel_bios_reader.c index 9f75d850d3fb..6581abf51472 100644

[Intel-gfx] [igt PATCH 2/6] intel_bios_reader: abstract a more generic hex dumper

2017-01-24 Thread Jani Nikula
Let us reuse the dumper for headers. Signed-off-by: Jani Nikula --- tools/intel_bios_reader.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tools/intel_bios_reader.c b/tools/intel_bios_reader.c index c7572bde8c7e..83fc819b6cdc 100644 --- a/tools/intel_bios_

Re: [Intel-gfx] [PATCH v2] tools: rename intel_bios_reader to intel_vbt_decode

2017-01-24 Thread Jani Nikula
On Tue, 24 Jan 2017, Jani Nikula wrote: > After all these years intel_bios_reader and intel_bios_dumper still > manage to confuse me. Read or dump, which one decodes. Rename > intel_bios_reader to intel_vbt_decode to be in line with the naming of > all the other tools (particularly the closely rel

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: do not proceed with autotests if we don't ACK them

2017-01-24 Thread Jani Nikula
On Tue, 24 Jan 2017, Manasi Navare wrote: > Thanks for this patch. I have tested this on DPR 120 compliance test device > and verified that it works as expected. > > Manasi > > On Fri, Jan 20, 2017 at 07:04:06PM +0200, Jani Nikula wrote: >> There is no point in setting intel_dp->compliance.test_ty

[Intel-gfx] ✓ Fi.CI.BAT: success for dma/fence: Export enable-signaling tracepoint for emission by drivers

2017-01-24 Thread Patchwork
== Series Details == Series: dma/fence: Export enable-signaling tracepoint for emission by drivers URL : https://patchwork.freedesktop.org/series/18481/ State : success == Summary == Series 18481v1 dma/fence: Export enable-signaling tracepoint for emission by drivers https://patchwork.freedes

[Intel-gfx] [PATCH] tools: rename intel_bios_reader to intel_vbt_decode

2017-01-24 Thread Jani Nikula
After all these years intel_bios_reader and intel_bios_dumper still manage to confuse me. Read or dump, which one decodes. Rename intel_bios_reader to intel_vbt_decode to be in line with the naming of all the other tools (particularly the closely related intel_opregion_decode tool) that decode prev

[Intel-gfx] [PATCH v2] tools: rename intel_bios_reader to intel_vbt_decode

2017-01-24 Thread Jani Nikula
After all these years intel_bios_reader and intel_bios_dumper still manage to confuse me. Read or dump, which one decodes. Rename intel_bios_reader to intel_vbt_decode to be in line with the naming of all the other tools (particularly the closely related intel_opregion_decode tool) that decode prev

[Intel-gfx] [PATCH v4] drm/i915: Move breadcrumbs irq_posted up a level to engine

2017-01-24 Thread Chris Wilson
In the next patch, we will use the irq_posted technique for another engine interrupt, rather than use two members for the atomic updates, we can use two bits of one instead. First, we need to update the breadcrumbs to use the new common engine->irq_posted. v2: Use set_bit() rather than __set_bit()

[Intel-gfx] [PATCH v4] drm/i915: Only run execlist context-switch handler after an interrupt

2017-01-24 Thread Chris Wilson
Mark when we run the execlist tasklet following the interrupt, so we don't probe a potentially uninitialised register when submitting the contexts multiple times before the hardware responds. v2: Use a shared engine->irq_posted v3: Always use locked bitops to be sure of atomicity wrt to other bits

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Disable plane gamma in SKL+ sprite planes

2017-01-24 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Disable plane gamma in SKL+ sprite planes URL : https://patchwork.freedesktop.org/series/18487/ State : failure == Summary == Series 18487v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/18487/rev

[Intel-gfx] [PATCH i-g-t] lib/drmtest: make DRIVER_ANY match any driver

2017-01-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Not tested or anything, I just happened to notice this code and it looked wrong, but maybe I misunderstood what it was meant to do. An alternative would be to just set the bits the the drivers that are defined already, but that would require an update everytime a

Re: [Intel-gfx] [PATCH v5 3/5] ALSA: add Intel HDMI LPE audio driver for BYT/CHT-T

2017-01-24 Thread kbuild test robot
Hi Jerome, [auto build test WARNING on ] url: https://github.com/0day-ci/linux/commits/Jerome-Anand/Add-support-for-Legacy-HDMI-audio-drivers/20170124-213547 base: coccinelle warnings: (new ones prefixed by >>) >> sound/x86/intel_hdmi_lpe_audio.c:498:24-27: ER

[Intel-gfx] [PATCH] ALSA: fix resource_size.cocci warnings

2017-01-24 Thread kbuild test robot
sound/x86/intel_hdmi_lpe_audio.c:498:24-27: ERROR: Missing resource_size with res_mmio Use resource_size function on resource object instead of explicit computation. Generated by: scripts/coccinelle/api/resource_size.cocci CC: Jerome Anand Signed-off-by: Fengguang Wu --- intel_hdmi_lpe_a

Re: [Intel-gfx] [PATCH v4] drm/i915: Move breadcrumbs irq_posted up a level to engine

2017-01-24 Thread Mika Kuoppala
Chris Wilson writes: > In the next patch, we will use the irq_posted technique for another > engine interrupt, rather than use two members for the atomic updates, we > can use two bits of one instead. First, we need to update the > breadcrumbs to use the new common engine->irq_posted. > > v2: Use

Re: [Intel-gfx] [PATCH v4] drm/i915: Only run execlist context-switch handler after an interrupt

2017-01-24 Thread Mika Kuoppala
Chris Wilson writes: > Mark when we run the execlist tasklet following the interrupt, so we > don't probe a potentially uninitialised register when submitting the > contexts multiple times before the hardware responds. > > v2: Use a shared engine->irq_posted > v3: Always use locked bitops to be s

Re: [Intel-gfx] [PATCH v3 6/8] drm/i915: Only attempt to pass the first request to execlists

2017-01-24 Thread Mika Kuoppala
Chris Wilson writes: > Only the first request added to the execlist queue, can be submitted. If > this request is not the first request on the queue, it means that there > are already higher priority requests waiting upon the tasklet and > kicking it will make no difference. > > This is more rele

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/8] drm/i915: Assert that we don't submit to execlists whilst a preempt is pending (rev3)

2017-01-24 Thread Patchwork
== Series Details == Series: series starting with [v3,1/8] drm/i915: Assert that we don't submit to execlists whilst a preempt is pending (rev3) URL : https://patchwork.freedesktop.org/series/18474/ State : success == Summary == Series 18474v3 Series without cover letter https://patchwork.fre

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Disable plane gamma in SKL+ sprite planes

2017-01-24 Thread Ville Syrjälä
On Tue, Jan 24, 2017 at 03:35:52PM +0200, Ander Conselvan de Oliveira wrote: > The plane gamma tables are never programmed, so just disable it, like it > is done for the primary plane. > > Signed-off-by: Ander Conselvan de Oliveira > > --- > drivers/gpu/drm/i915/intel_sprite.c | 1 + > 1 file c

Re: [Intel-gfx] [PATCH 3/4] drm: Add definitions for DP compliance Video pattern tests

2017-01-24 Thread Jani Nikula
On Sat, 21 Jan 2017, Manasi Navare wrote: > v4: > * Remove redundant single bit defs (Jani Nikula) > v3: > * Fix the conventions in bit definitions (Jani Nikula) > v2: > * Add all the other DP Complianec TEST register defs (Jani Nikula) > Cc: dri-de...@lists.freedesktop.org > Cc: Jani Nikula > Cc

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/8] drm/i915: Assert that we don't submit to execlists whilst a preempt is pending (rev3)

2017-01-24 Thread Chris Wilson
On Tue, Jan 24, 2017 at 03:54:19PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [v3,1/8] drm/i915: Assert that we don't submit > to execlists whilst a preempt is pending (rev3) > URL : https://patchwork.freedesktop.org/series/18474/ > State : success > > == S

[Intel-gfx] [PATCH] ALSA: x86: hdmi: fix returnvar.cocci warnings

2017-01-24 Thread Julia Lawall
ommits/Jerome-Anand/Add-support-for-Legacy -HDMI-audio-drivers/20170124-213547 This is probably not the right patch. It si just what the rule generates. Instead, I guess that retval should be updated in some way? intel_hdmi_audio_if.c | 21 + 1 file changed, 9 insertions(

Re: [Intel-gfx] [PATCH 2/4] drm/i915/glk: Plane color correction register changes

2017-01-24 Thread Ville Syrjälä
On Tue, Jan 24, 2017 at 03:35:53PM +0200, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan De Oliveira > > In Geminilake, the bits for enabling pipe csc, pipe gamma and plane > gamma moved to a new register. So update the plane update functions > to set the right bits. > > Pipe CSC is

[Intel-gfx] [PATCH v5 1/4] drm/i915: Add support for DP link training compliance

2017-01-24 Thread Manasi Navare
This patch adds support to handle automated DP compliance link training test requests. This patch has been tested with Unigraf DPR-120 DP Compliance device for testing Link Training Compliance. After we get a short pulse Compliance test request, test request values are read and hotplug uevent is se

[Intel-gfx] [PATCH v4 4/4] drm/i915: Add support for DP Video pattern compliance tests

2017-01-24 Thread Manasi Navare
The intel_dp_autotest_video_pattern() function gets invoked through the compliance test handler on a HPD short pulse if the test type is set to DP_TEST_VIDEO_PATTERN. This performs the DPCD registers reads to read the requested test pattern, video pattern resolution, frame rate and bits per color v

Re: [Intel-gfx] [PATCH 0/4] Add automation support for DP Compliance (Rev 6)

2017-01-24 Thread Jani Nikula
On Mon, 23 Jan 2017, Manasi Navare wrote: > As far as I know, I have addressed the review comments from previous > round and answered the questions/concerns that you had either in the > M-L or in IRC. May be answering them on IRC created some confusion > and you thought that it was unanswered. I

Re: [Intel-gfx] [PATCH v2 06/13] i2c: designware-baytrail: Disallow the CPU to enter C6 or C7 while holding the punit semaphore

2017-01-24 Thread Hans de Goede
Hi, On 01/24/2017 10:51 AM, Andy Shevchenko wrote: On Mon, 2017-01-23 at 22:09 +0100, Hans de Goede wrote: On my cherrytrail tablet with axp288 pmic, just doing a bunch of repeated reads from the pmic, e.g. "i2cdump -y 14 0x34" would lookup the tablet in 1 - 3 runs guaranteed. This seems to be

Re: [Intel-gfx] [PATCH 0/4] Add automation support for DP Compliance (Rev 6)

2017-01-24 Thread Manasi Navare
On Tue, Jan 24, 2017 at 06:40:51PM +0200, Jani Nikula wrote: > On Mon, 23 Jan 2017, Manasi Navare wrote: > > As far as I know, I have addressed the review comments from previous > > round and answered the questions/concerns that you had either in the > > M-L or in IRC. May be answering them on IR

[Intel-gfx] ✗ Fi.CI.BAT: warning for Add automation support for DP Compliance (Rev 6) (rev3)

2017-01-24 Thread Patchwork
== Series Details == Series: Add automation support for DP Compliance (Rev 6) (rev3) URL : https://patchwork.freedesktop.org/series/18329/ State : warning == Summary == Series 18329v3 Add automation support for DP Compliance (Rev 6) https://patchwork.freedesktop.org/api/1.0/series/18329/revisi

Re: [Intel-gfx] [PATCH] drm/i915: Move atomic state free from out of fence release

2017-01-24 Thread Chris Wilson
On Tue, Jan 24, 2017 at 10:39:44AM +0200, Joonas Lahtinen wrote: > On ma, 2017-01-23 at 21:29 +, Chris Wilson wrote: > > @@ -17329,6 +17350,9 @@ void intel_modeset_cleanup(struct drm_device *dev) > >  { > >   struct drm_i915_private *dev_priv = to_i915(dev); > >   > > + flush_work(&dev_priv

Re: [Intel-gfx] [PATCH i-g-t v4] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

2017-01-24 Thread Manasi Navare
On Tue, Jan 24, 2017 at 11:49:48AM +0200, Petri Latvala wrote: > > Just one more nitpick (in two parts) below. With that, you can > consider this now to be > > Reviewed-by: Petri Latvala > > This patch can be pushed when the kernel changes that contain "must be > kept in sync" numbers in intel_

Re: [Intel-gfx] [PATCH 3/4] drm/i915/glk: Program pipe gamma and degamma tables

2017-01-24 Thread Ville Syrjälä
On Tue, Jan 24, 2017 at 03:35:54PM +0200, Ander Conselvan de Oliveira wrote: > The gamma tables in Geminilake were changed. There is no split-gamma > mode. Instead, there is a dedicated degamma table that is enabled > whenever pipe CSC is enabled. > > The dedicated gamma table has 16 bit precision

[Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL

2017-01-24 Thread Paulo Zanoni
So don't forget to reserve its stolen memory bits. Cc: Ingo Molnar Cc: H. Peter Anvin Cc: Ander Conselvan de Oliveira Cc: x...@kernel.org Reviewed-by: Ander Conselvan de Oliveira Signed-off-by: Paulo Zanoni --- arch/x86/kernel/early-quirks.c | 1 + 1 file changed, 1 insertion(+) Found by co

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Copy user requested buffers into the error state

2017-01-24 Thread Ben Widawsky
On 17-01-24 13:16:56, Mika Kuoppala wrote: From: Chris Wilson Introduce a new execobject.flag (EXEC_OBJECT_CAPTURE) that userspace may use to indicate that it wants the contents of this buffer preserved in the error state (/sys/class/drm/cardN/error) following a GPU hang involving this batch.

[Intel-gfx] [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance

2017-01-24 Thread Alex Williamson
Per the ABI specification[1], each mdev_supported_types entry should have an available_instances, with an "s", not available_instance. [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev Signed-off-by: Alex Williamson --- This should really be fixed before initial release in v4.10 drivers/gpu/d

[Intel-gfx] ✓ Fi.CI.BAT: success for x86/gpu: GLK uses the same GMS values as SKL

2017-01-24 Thread Patchwork
== Series Details == Series: x86/gpu: GLK uses the same GMS values as SKL URL : https://patchwork.freedesktop.org/series/18505/ State : success == Summary == Series 18505v1 x86/gpu: GLK uses the same GMS values as SKL https://patchwork.freedesktop.org/api/1.0/series/18505/revisions/1/mbox/ f

[Intel-gfx] [PATCH] drm/i915/gvt: Fix kmem_cache_create() name

2017-01-24 Thread Alex Williamson
According to kmem_cache_sanity_check(), spaces are not allowed in the name of a cache and results in a kernel oops with CONFIG_DEBUG_VM. Convert to underscores. Signed-off-by: Alex Williamson --- drivers/gpu/drm/i915/gvt/execlist.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Copy user requested buffers into the error state

2017-01-24 Thread Chris Wilson
On Tue, Jan 24, 2017 at 11:44:26AM -0800, Ben Widawsky wrote: > On 17-01-24 13:16:56, Mika Kuoppala wrote: > >+for (j = 0; j < ee->user_bo_count; j++) > >+print_error_obj(m, dev_priv->engine[i], > >+"user", ee->user_bo[j]); > >+ >

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Copy user requested buffers into the error state

2017-01-24 Thread Chris Wilson
On Tue, Jan 24, 2017 at 11:44:26AM -0800, Ben Widawsky wrote: > >+for (j = 0; j < ee->user_bo_count; j++) > >+print_error_obj(m, dev_priv->engine[i], > >+"user", ee->user_bo[j]); > >+ > > We'll need a way to be able to figure out

Re: [Intel-gfx] [PATCH 4/4] drm: Resurrect atomic rmfb code, v2

2017-01-24 Thread Matt Roper
On Wed, Jan 11, 2017 at 05:15:47PM +0100, Daniel Vetter wrote: > On Thu, Dec 15, 2016 at 03:29:45PM +0100, Maarten Lankhorst wrote: > > From: Daniel Vetter > > > > This was somehow lost between v3 and the merged version in Maarten's > > patch merged as: > > > > commit f2d580b9a8149735cbc4b59c4a8

[Intel-gfx] DP Aux interfaces inquiry

2017-01-24 Thread Mario.Limonciello
Hi, Recently Synaptics collaborated with Dell on a plugin [1] for fwupd that allows flashing Synaptics MST hubs using the DP aux interface to manipulate the DPCD [2]. Currently the plugin hardcodes the max number of DP aux devices to look for to 3 (as that's what we've seen so far on HW), but w

[Intel-gfx] [PATCH i-g-t v2 03/33] lib/igt_kms: Rename kmstest properties nplanes and plane

2017-01-24 Thread Robert Foss
Rename these properties to have them use the same naming convention as the igt_*_t structs. Signed-off-by: Robert Foss --- lib/igt_kms.c| 16 +--- lib/igt_kms.h| 4 ++-- tests/kms_plane_lowres.c | 10 +- 3 files changed, 16 insertions(+), 14 deletions

[Intel-gfx] [PATCH i-g-t v2 11/33] tests/kms_fbc_crc: Add support for dynamic number of planes

2017-01-24 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_fbc_crc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c index a696e124..d2c76fb1 100644 --- a/tests/kms_

[Intel-gfx] [PATCH i-g-t v2 08/33] tests/kms_crtc_background_color: Add support for dynamic number of planes

2017-01-24 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_crtc_background_color.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_crtc_background_color.c b/tests/kms_crtc_background_color.c index 537d4ce6

[Intel-gfx] [PATCH i-g-t v2 10/33] tests/kms_cursor_legacy: Add support for dynamic number of planes

2017-01-24 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_cursor_legacy.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c inde

[Intel-gfx] [PATCH i-g-t v2 14/33] tests/kms_legacy_colorkey: Add support for dynamic number of planes

2017-01-24 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_legacy_colorkey.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kms_legacy_colorkey.c b/tests/kms_legacy_colorkey.c index 25f98aad..150520ce 10064

[Intel-gfx] [PATCH i-g-t v2 26/33] tests/kms_rotation_crc: Add support for dynamic number of planes

2017-01-24 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_rotation_crc.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotati

[Intel-gfx] [PATCH i-g-t v2 25/33] tests/kms_rmfb: Add support for dynamic number of planes

2017-01-24 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_rmfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c index 17a3065a..5753d74c 100644 --- a/tests/kms_rmfb.c +++ b/tests

[Intel-gfx] [PATCH i-g-t v2 16/33] tests/kms_mmio_vs_cs_flip: Add support for dynamic number of planes

2017-01-24 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_mmio_vs_cs_flip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/kms_mmio_vs_cs_flip.c b/tests/kms_mmio_vs_cs_flip.c index 2f64f633..09217b31 10

[Intel-gfx] [PATCH i-g-t v2 31/33] tests/kms_ccs: Add support for dynamic number of planes

2017-01-24 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_ccs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c index 047a3e87..11acda89 100644 --- a/tests/kms_ccs.c +++ b/tests

[Intel-gfx] [PATCH i-g-t v2 30/33] tests/prime_mmap_kms: Add support for dynamic number of planes

2017-01-24 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/prime_mmap_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/prime_mmap_kms.c b/tests/prime_mmap_kms.c index a2f85fa7..e7cca54c 100644 --- a/tests/prim

[Intel-gfx] [PATCH i-g-t v2 21/33] tests/kms_plane_scaling: Add support for dynamic number of planes

2017-01-24 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_plane_scaling.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c index 368da09f..18ba86c9

  1   2   >