Re: [Intel-gfx] [PATCH 2/5] drm/edid: Introduce drm_default_rgb_quant_range()

2017-01-12 Thread Daniel Vetter
On Wed, Jan 11, 2017 at 06:31:52PM +0200, Ville Syrjälä wrote: > On Wed, Jan 11, 2017 at 05:16:54PM +0100, Daniel Vetter wrote: > > On Wed, Jan 11, 2017 at 02:57:22PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Make the code selecting the RGB quantizatio

[Intel-gfx] [PATCH v5 0/3] support DP MST audio

2017-01-12 Thread libin . yang
From: Libin Yang This patchset starts to support DP MST audio. change log: v4: refine some comments in 0001 and 0002 patches. refine the 0003 patch for the new ALSA-Configuration document v5: add Takashi's Reviewed-by Libin Yang (3): ALSA: hda - add DP mst verb support ALSA: hda - add D

[Intel-gfx] [PATCH v5 3/3] ALSA: Documentation about HDA DP MST pin init and connection

2017-01-12 Thread libin . yang
From: Libin Yang Add the documentation about HD-audio DP MST: 1. pin initialization 2. device entry connection list Reviewed-by: Takashi Iwai Signed-off-by: Libin Yang --- Documentation/sound/hd-audio/dp-mst.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/Documentat

[Intel-gfx] [PATCH v5 1/3] ALSA: hda - add DP mst verb support

2017-01-12 Thread libin . yang
From: Libin Yang Add snd_hda_get_dev_select() and snd_hda_set_dev_select() functions for DP MST audio support. Reviewed-by: Takashi Iwai Signed-off-by: Libin Yang --- sound/pci/hda/hda_codec.c | 72 --- sound/pci/hda/hda_codec.h | 3 ++ 2 files cha

[Intel-gfx] [PATCH v5 2/3] ALSA: hda - add DP MST audio support

2017-01-12 Thread libin . yang
From: Libin Yang This patch adds the DP MST audio support on i915 platform and it will enable dyn_pcm_assign feature. DP MST supports several device entry on the same port and each device entry can map to one pcm stream. For example, on i915, there are 3 pins, and each pin has 3 device entries.

Re: [Intel-gfx] [PATCH 2/5] drm/edid: Introduce drm_default_rgb_quant_range()

2017-01-12 Thread Michel Dänzer
On 12/01/17 05:00 PM, Daniel Vetter wrote: > On Wed, Jan 11, 2017 at 06:31:52PM +0200, Ville Syrjälä wrote: >> On Wed, Jan 11, 2017 at 05:16:54PM +0100, Daniel Vetter wrote: >>> On Wed, Jan 11, 2017 at 02:57:22PM +0200, ville.syrj...@linux.intel.com >>> wrote: From: Ville Syrjälä M

Re: [Intel-gfx] [PATCH v4] lib/scatterlist: Avoid potential scatterlist entry overflow

2017-01-12 Thread Andy Shevchenko
On Wed, Jan 11, 2017 at 1:58 PM, Tvrtko Ursulin wrote: > Since the scatterlist length field is an unsigned int, make > sure that sg_alloc_table_from_pages does not overflow it while > coallescing pages to a single entry. > /* > + * Since the above length field is an unsigned int, below we defin

Re: [Intel-gfx] [PATCH v5 0/3] support DP MST audio

2017-01-12 Thread Jani Nikula
On Thu, 12 Jan 2017, libin.y...@intel.com wrote: > From: Libin Yang > > This patchset starts to support DP MST audio. Given that this is only sent to intel-gfx, I *presume* this is now intended to be merged via drm-intel. Is that right? Please don't assume your poor maintainers remember everythi

Re: [Intel-gfx] [PATCH v5 0/3] support DP MST audio

2017-01-12 Thread Yang, Libin
>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Thursday, January 12, 2017 4:19 PM >To: Yang, Libin ; intel-gfx@lists.freedesktop.org; >ville.syrj...@linux.intel.com; Vetter, Daniel ; >Pandiyan, Dhinakaran ; ti...@suse.de >Cc: Yang, Libin >Subject: Re: [

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: check ppgtt validity when init reg state (rev2)

2017-01-12 Thread Tvrtko Ursulin
On 09/01/2017 13:53, Patchwork wrote: == Series Details == Series: drm/i915: check ppgtt validity when init reg state (rev2) URL : https://patchwork.freedesktop.org/series/17691/ State : warning == Summary == Series 17691v2 drm/i915: check ppgtt validity when init reg state https://patchwor

Re: [Intel-gfx] [PATCH v5 0/3] support DP MST audio

2017-01-12 Thread Jani Nikula
On Thu, 12 Jan 2017, "Yang, Libin" wrote: >>-Original Message- >>From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >>Sent: Thursday, January 12, 2017 4:19 PM >>To: Yang, Libin ; intel-gfx@lists.freedesktop.org; >>ville.syrj...@linux.intel.com; Vetter, Daniel ; >>Pandiyan, Dhinakaran ;

Re: [Intel-gfx] [PATCH v5 0/3] support DP MST audio

2017-01-12 Thread Takashi Iwai
On Thu, 12 Jan 2017 09:53:35 +0100, Jani Nikula wrote: > > On Thu, 12 Jan 2017, "Yang, Libin" wrote: > >>-Original Message- > >>From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > >>Sent: Thursday, January 12, 2017 4:19 PM > >>To: Yang, Libin ; intel-gfx@lists.freedesktop.org; > >>vi

Re: [Intel-gfx] [PATCH v5 0/3] support DP MST audio

2017-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2017 at 10:53:35AM +0200, Jani Nikula wrote: > On Thu, 12 Jan 2017, "Yang, Libin" wrote: > >>-Original Message- > >>From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > >>Sent: Thursday, January 12, 2017 4:19 PM > >>To: Yang, Libin ; intel-gfx@lists.freedesktop.org; > >

Re: [Intel-gfx] [PATCH v5 0/3] support DP MST audio

2017-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2017 at 10:06:10AM +0100, Daniel Vetter wrote: > On Thu, Jan 12, 2017 at 10:53:35AM +0200, Jani Nikula wrote: > > On Thu, 12 Jan 2017, "Yang, Libin" wrote: > > >>-Original Message- > > >>From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > > >>Sent: Thursday, January 12

Re: [Intel-gfx] [PATCH i-g-t rfc 01/29] lib/igt_debugfs: Prevent buffer overflow

2017-01-12 Thread Lankhorst, Maarten
Robert Foss schreef op wo 11-01-2017 om 15:41 [-0500]: > buf array may overflow with when writing '\0' if > MAX_LINE_LEN bytes are read during read(). How? char buf[MAX_LINE_LEN + 1]; > Signed-off-by: Robert Foss > --- >  lib/igt_debugfs.c | 8 +--- >  1 file changed, 5 insertions(+), 3 delet

Re: [Intel-gfx] GPU hang with kernel 4.10rc3

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 07:03:25AM +0100, Juergen Gross wrote: > On 11/01/17 18:08, Chris Wilson wrote: > > On Wed, Jan 11, 2017 at 05:33:34PM +0100, Juergen Gross wrote: > >> With kernel 4.10rc3 running as Xen dm0 I get at each boot: > >> > >> [ 49.213697] [drm] GPU HANG: ecode 7:0:0x3d1d3d3d, i

Re: [Intel-gfx] [PATCH 1/5] drm/edid: Have drm_edid.h include hdmi.h

2017-01-12 Thread Jani Nikula
On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > drm_edid.h depends on hdmi.h on account of enum hdmi_picture_aspect, > so let's just include hdmi.h and drop some useless struct declarations. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

[Intel-gfx] [PATCH v2.1 6/7] drm/atomic: Convert get_existing_state callers to get_old/new_state, v2.

2017-01-12 Thread Maarten Lankhorst
This is a straightforward conversion that converts all the users of get_existing_state in atomic core to use get_old_state or get_new_state Changes since v1: - Fix using the wrong state in drm_atomic_helper_update_legacy_modeset_state. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_at

Re: [Intel-gfx] [PATCH v2 2/5] drm/edid: Introduce drm_default_rgb_quant_range()

2017-01-12 Thread Jani Nikula
On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Make the code selecting the RGB quantization range a little less magicy > by wrapping it up in a small helper. > > v2: s/adjusted_mode/mode in vc4 to make it actually compile > > Signed-off-by: Ville Syrjälä > ---

Re: [Intel-gfx] [PATCH 3/5] drm/edid: Introduce drm_hdmi_avi_infoframe_quant_range()

2017-01-12 Thread Jani Nikula
On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Pull the logic to populate the quantization range information > in the AVI infoframe into a small helper. We'll be adding a bit > more logic to it, and having it in a central place seems like a > good idea since it

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Ville Syrjälä
On Wed, Jan 11, 2017 at 08:43:16PM -0500, Rob Clark wrote: > On Wed, Jan 11, 2017 at 7:51 PM, Ben Widawsky wrote: > > > > +struct drm_format_modifier { > > + /* Bitmask of formats in get_plane format list this info > > +* applies to. */ > > + uint64_t formats; > > re: the uabi

[Intel-gfx] [PATCH] drm/i915: Remove useless casts to intel_plane_state

2017-01-12 Thread Maarten Lankhorst
The visible member used to be in intel_plane_state->visible, but has been moved to drm_plane_state->visible. In the conversion some casts were left in that are now useless. to_intel_plane_state(x)->base.visible is the same as x->visible, so use the latter to clear up the code a little. Signed-off

Re: [Intel-gfx] [PATCH 4/5] drm/edid: Set AVI infoframe Q even when QS=0

2017-01-12 Thread Jani Nikula
On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > HDMI 2.0 recommends that we set the Q bits in the AVI infoframe > even when the sink does not support quantization range selection (QS=0). > According to CEA-861 we can do that as long as the Q we send matches > th

Re: [Intel-gfx] [PATCH] drm/i915: Remove useless casts to intel_plane_state

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 10:43:45AM +0100, Maarten Lankhorst wrote: > The visible member used to be in intel_plane_state->visible, > but has been moved to drm_plane_state->visible. In the conversion > some casts were left in that are now useless. > > to_intel_plane_state(x)->base.visible is the sam

Re: [Intel-gfx] [PATCH] drm/i915: Remove useless casts to intel_plane_state

2017-01-12 Thread Ville Syrjälä
On Thu, Jan 12, 2017 at 10:43:45AM +0100, Maarten Lankhorst wrote: > The visible member used to be in intel_plane_state->visible, > but has been moved to drm_plane_state->visible. In the conversion > some casts were left in that are now useless. > > to_intel_plane_state(x)->base.visible is the sam

Re: [Intel-gfx] [PATCH i-g-t v4] tests/kms_plane_lowres: Plane visibility after atomic modesets

2017-01-12 Thread Maarten Lankhorst
Op 30-12-16 om 13:47 schreef Mika Kahola: > Testcase for plane visibility after atomic modesets. The idea of the test > is the following: > > - draw a blue screen with high resolution > - enable a yellow plane, visible, in lower-left corner > - set a new lower resolution mode (1024x768) that mak

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 07:14:55AM +, Tvrtko Ursulin wrote: > > On 12/01/2017 07:08, Tvrtko Ursulin wrote: > > > >On 11/01/2017 21:51, Chris Wilson wrote: > >>In preparation for the next patch to convert to using an anonymous union > >>and leaving the excess bytes in the union uninitialised, w

Re: [Intel-gfx] [PATCH i-g-t v4] tests/kms_plane_lowres: Plane visibility after atomic modesets

2017-01-12 Thread Mika Kahola
On Thu, 2017-01-12 at 11:00 +0100, Maarten Lankhorst wrote: > Op 30-12-16 om 13:47 schreef Mika Kahola: > > > > Testcase for plane visibility after atomic modesets. The idea of > > the test > > is the following: > > > >  - draw a blue screen with high resolution > >  - enable a yellow plane, visi

Re: [Intel-gfx] [PATCH i-g-t 5/5] tests/kms_test_only: Validate TEST_ONLY correctness against full atomic commit

2017-01-12 Thread Maarten Lankhorst
Op 30-12-16 om 13:00 schreef Mika Kahola: > This test case adds TEST_ONLY flag to the following test cases to test > atomic commit correctness. > > - kms_plane_multiple > - kms_atomic_transitions > - kms_plane_scaling > - kms_rotation_crc > > The test randomly selects one of the above test case

Re: [Intel-gfx] [PATCH 5/5] drm/edid: Set YQ bits in the AVI infoframe according to CEA-861-F

2017-01-12 Thread Jani Nikula
On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > CEA-861-F tells us: > "When transmitting any RGB colorimetry, the Source should set the > YQ-field to match the RGB Quantization Range being transmitted > (e.g., when Limited Range RGB, set YQ=0 or when Full Rang

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Ville Syrjälä
On Wed, Jan 11, 2017 at 04:51:16PM -0800, Ben Widawsky wrote: > Originally based off of a patch by Kristian. > > This new ioctl extends DRM_IOCTL_MODE_GETPLANE, by returning information > about the modifiers that will work with each format. > > It's modified from Kristian's patch in that the modi

Re: [Intel-gfx] DP compliance failure due to dithering for 18bpp video pattern

2017-01-12 Thread Jani Nikula
On Wed, 11 Jan 2017, Ville Syrjälä wrote: > On Wed, Jan 11, 2017 at 05:09:16PM +0200, Jani Nikula wrote: >> On Tue, 10 Jan 2017, Manasi Navare wrote: >> > Hi All, >> > >> > We are seeing CRC check failures in some of the 18bpp video pattern >> > DP Compliance tests causing the tests to fail. On f

Re: [Intel-gfx] [PATCH] drm/i915/guc: Make sure vma containing firmware is GuC mappable

2017-01-12 Thread Chris Wilson
On Wed, Jan 11, 2017 at 04:17:39PM +0100, Michał Winiarski wrote: > Since commit 4741da925fa3 ("drm/i915/guc: Assert that all GGTT offsets used > by the GuC are mappable"), we're asserting that GuC firmware is in the > GuC mappable range. > Except we're not pinning the object with bias, which means

[Intel-gfx] [PATCH] drm/i915: Expand ggtt_view paramters for debugfs

2017-01-12 Thread Chris Wilson
When dumping the VMA, include the parameters of the different GGTT views so that we can distinguish them. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [Intel-gfx] [PATCH 5/5] drm/edid: Set YQ bits in the AVI infoframe according to CEA-861-F

2017-01-12 Thread Ville Syrjälä
On Thu, Jan 12, 2017 at 12:13:47PM +0200, Jani Nikula wrote: > On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > CEA-861-F tells us: > > "When transmitting any RGB colorimetry, the Source should set the > > YQ-field to match the RGB Quantization Range being

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-12 Thread Tvrtko Ursulin
On 12/01/2017 10:05, Chris Wilson wrote: On Thu, Jan 12, 2017 at 07:14:55AM +, Tvrtko Ursulin wrote: On 12/01/2017 07:08, Tvrtko Ursulin wrote: On 11/01/2017 21:51, Chris Wilson wrote: In preparation for the next patch to convert to using an anonymous union and leaving the excess bytes i

[Intel-gfx] [PATCH] drm/i915: Remove WaDisableLSQCROPERFforOCL KBL workaround.

2017-01-12 Thread Mika Kuoppala
From: Francisco Jerez The WaDisableLSQCROPERFforOCL workaround has the side effect of disabling an L3SQ optimization that has huge performance implications and is unlikely to be necessary for the correct functioning of usual graphic workloads. Userspace is free to re-enable the workaround on dem

Re: [Intel-gfx] [PATCH] drm/i915/guc: Make sure vma containing firmware is GuC mappable

2017-01-12 Thread Tomi Sarvela
On Thursday, 12 January 2017 10:33:47 EET Chris Wilson wrote: > On Wed, Jan 11, 2017 at 04:17:39PM +0100, Michał Winiarski wrote: > > Since commit 4741da925fa3 ("drm/i915/guc: Assert that all GGTT > > offsets used by the GuC are mappable"), we're asserting that GuC > > firmware is in the GuC mappab

Re: [Intel-gfx] [PATCH] drm/i915: Expand ggtt_view paramters for debugfs

2017-01-12 Thread Tvrtko Ursulin
On 12/01/2017 10:35, Chris Wilson wrote: When dumping the VMA, include the parameters of the different GGTT views so that we can distinguish them. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 25 +++-- 1 file changed, 23 inserti

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Add format modifiers for Intel

2017-01-12 Thread Ville Syrjälä
On Wed, Jan 11, 2017 at 04:51:17PM -0800, Ben Widawsky wrote: > This was based on a patch originally by Kristian. It has been modified > pretty heavily to use the new callbacks from the previous patch. > > Cc: Kristian H. Kristensen > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/int

Re: [Intel-gfx] [PATCH] drm/i915/guc: Make sure vma containing firmware is GuC mappable

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 12:44:52PM +0200, Tomi Sarvela wrote: > On Thursday, 12 January 2017 10:33:47 EET Chris Wilson wrote: > > On Wed, Jan 11, 2017 at 04:17:39PM +0100, Michał Winiarski wrote: > > > Since commit 4741da925fa3 ("drm/i915/guc: Assert that all GGTT > > > offsets used by the GuC are

Re: [Intel-gfx] [PATCH 03/37] drm/i915: Add some selftests for sg_table manipulation

2017-01-12 Thread Tvrtko Ursulin
On 11/01/2017 21:09, Chris Wilson wrote: Start exercising the scattergather lists, especially looking at iteration after coalescing. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c| 11 +- .../gpu/drm/i915/selftests/i915_mock_selftests.

Re: [Intel-gfx] [PATCH 10/37] drm/i915: Create a fake object for testing huge allocations

2017-01-12 Thread Matthew Auld
On 11 January 2017 at 21:09, Chris Wilson wrote: > We would like to be able to exercise huge allocations even on memory > constrained devices. To do this we create an object that allocates only > a few pages and remaps them across its whole range - each page is reused > multiple times. We can ther

Re: [Intel-gfx] [PATCH] drm/i915: Remove WaDisableLSQCROPERFforOCL KBL workaround.

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 12:44:54PM +0200, Mika Kuoppala wrote: > From: Francisco Jerez > > The WaDisableLSQCROPERFforOCL workaround has the side effect of > disabling an L3SQ optimization that has huge performance implications > and is unlikely to be necessary for the correct functioning of usual

[Intel-gfx] [CI 1/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2017-01-12 Thread Chris Wilson
Move the GuC invalidation of its ggtt TLB to where we perform the ggtt modification rather than proliferate it into all the callers of the insert (which may or may not in fact have to do the insertion). v2: Just do the guc invalidate unconditionally, (afaict) it has no impact without the guc loade

[Intel-gfx] [CI 2/2] HAX enable guc submission for CI

2017-01-12 Thread Chris Wilson
--- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 0e280fbd52f1..1d3766cfc837 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_p

[Intel-gfx] [PATCH v2] drm/i915: Expand ggtt_view paramters for debugfs

2017-01-12 Thread Chris Wilson
When dumping the VMA, include the parameters of the different GGTT views so that we can distinguish them. v2: Contract output and add MISSING_CASE for any unknown types. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 28 ++-- 1

Re: [Intel-gfx] [PATCH 06/37] drm/i915: Add unit tests for the breadcrumb rbtree, wakeups

2017-01-12 Thread Tvrtko Ursulin
On 11/01/2017 21:09, Chris Wilson wrote: Third retroactive test, make sure that the seqno waiters are woken. There are some open questions from the previous round (early December), not least of which is that I think we really need good comments in tests. Especially ones like this one which i

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number of iterations

2017-01-12 Thread Mika Kahola
In CI system, the default 64 iterations of this test may cause CRC overflow warnings in dmesg when debugfs is enabled in kernel config. To keep dmesg warning noise in minimum, let's run this test only once by default. Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 2 +- 1 file chang

Re: [Intel-gfx] [PATCH 5/5] drm/edid: Set YQ bits in the AVI infoframe according to CEA-861-F

2017-01-12 Thread Jani Nikula
On Thu, 12 Jan 2017, Ville Syrjälä wrote: > On Thu, Jan 12, 2017 at 12:13:47PM +0200, Jani Nikula wrote: >> On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: >> > From: Ville Syrjälä >> > >> > CEA-861-F tells us: >> > "When transmitting any RGB colorimetry, the Source should set the >> >

Re: [Intel-gfx] [PATCH 03/37] drm/i915: Add some selftests for sg_table manipulation

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 10:56:42AM +, Tvrtko Ursulin wrote: > > On 11/01/2017 21:09, Chris Wilson wrote: > >+static bool alloc_table(struct pfn_table *pt, > >+unsigned long count, > >+unsigned long max) > >+{ > >+struct scatterlist *sg; > >+unsig

Re: [Intel-gfx] [PATCH v2] drm/i915: Expand ggtt_view paramters for debugfs

2017-01-12 Thread Tvrtko Ursulin
On 12/01/2017 11:06, Chris Wilson wrote: When dumping the VMA, include the parameters of the different GGTT views so that we can distinguish them. v2: Contract output and add MISSING_CASE for any unknown types. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_deb

Re: [Intel-gfx] [PATCH 16/37] drm/i915: Add a live seftest for GEM objects

2017-01-12 Thread Matthew Auld
On 11 January 2017 at 21:09, Chris Wilson wrote: > Starting with a placeholder test just to reassure that we can create a > test object, > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.or

Re: [Intel-gfx] [PATCH v2] drm/i915: Expand ggtt_view paramters for debugfs

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 11:14:55AM +, Tvrtko Ursulin wrote: > > On 12/01/2017 11:06, Chris Wilson wrote: > >When dumping the VMA, include the parameters of the different GGTT views > >so that we can distinguish them. > > > >v2: Contract output and add MISSING_CASE for any unknown types. > > >

Re: [Intel-gfx] [PATCH 11/37] drm/i915: Add selftests for i915_gem_request

2017-01-12 Thread Tvrtko Ursulin
On 11/01/2017 21:09, Chris Wilson wrote: Simple starting point for adding seltests for i915_gem_request, first mock a device (with engines and contexts) that allows us to construct and execute a request, along with waiting for the request to complete. Signed-off-by: Chris Wilson AFAICT I r-b

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number of iterations

2017-01-12 Thread Jani Nikula
On Thu, 12 Jan 2017, Mika Kahola wrote: > In CI system, the default 64 iterations of this test may cause CRC overflow > warnings in dmesg when debugfs is enabled in kernel config. To keep dmesg > warning noise in minimum, let's run this test only once by default. Please give an example of the war

[Intel-gfx] [PATCH v3] drm/i915: Expand ggtt_view paramters for debugfs

2017-01-12 Thread Chris Wilson
When dumping the VMA, include the parameters of the different GGTT views so that we can distinguish them. v2: Contract output and add MISSING_CASE for any unknown types. v3: Show both stride and offset for rotated planes. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviwed-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 12/37] drm/i915: Add a simple request selftest for waiting

2017-01-12 Thread Tvrtko Ursulin
On 11/01/2017 21:09, Chris Wilson wrote: A trivial kselftest to submit a request and wait upon it. Hm this should have been a v2! Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_gem_request.c | 44 +++ 1 file changed, 44 insertions(+) diff --git a/d

Re: [Intel-gfx] [PATCH 11/37] drm/i915: Add selftests for i915_gem_request

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 11:20:43AM +, Tvrtko Ursulin wrote: > > On 11/01/2017 21:09, Chris Wilson wrote: > >Simple starting point for adding seltests for i915_gem_request, first > >mock a device (with engines and contexts) that allows us to construct > >and execute a request, along with waitin

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-12 Thread Chris Wilson
On Wed, Jan 11, 2017 at 09:51:03PM +, Chris Wilson wrote: > In preparation for the next patch to convert to using an anonymous union > and leaving the excess bytes in the union uninitialised, we first need > to make sure we do not compare using those uninitialised bytes. We also > want to prese

Re: [Intel-gfx] [PATCH i-g-t 5/5] tests/kms_test_only: Validate TEST_ONLY correctness against full atomic commit

2017-01-12 Thread Maarten Lankhorst
Hey, Op 12-01-17 om 11:28 schreef Mika Kahola: > On Thu, 2017-01-12 at 11:11 +0100, Maarten Lankhorst wrote: >> Op 30-12-16 om 13:00 schreef Mika Kahola: >>> This test case adds TEST_ONLY flag to the following test cases to >>> test >>> atomic commit correctness. >>> >>> - kms_plane_multiple >>>

Re: [Intel-gfx] [PATCH 10/14] drm/i915: Add MIPI_IO WA

2017-01-12 Thread Mika Kahola
This is definitely needed to pass igt test on bxt 'gem_exec_suspend --run-subtest basic-S3' Tested-by: Mika Kahola On Mon, 2017-01-09 at 14:46 +0530, Vidya Srinivas wrote: > From: Uma Shankar > > Enable MIPI IO WA for BXT DSI as per bspec. > > Signed-off-by: Uma Shankar > --- >  drivers/gpu

[Intel-gfx] [PATCH 1/3] drm/i915: Add name for WaDisablePWMClockGating workaround

2017-01-12 Thread Ander Conselvan de Oliveira
The workaround added in commit d965e7ac7a19 ("drm/i915/bxt: backlight clock gating workaround") is listed in the workaround database with the name WaDisablePWMClockGating, pointing to the same hsd as the nameless entry in the display workarounds bspec page. Cc: Imre Deak Signed-off-by: Ander Cons

[Intel-gfx] [PATCH 2/3] drm/i915: Apply WaSetHdcUnitClockGatingDisableInUcgctl6 only until B0

2017-01-12 Thread Ander Conselvan de Oliveira
The workaround WaSetHdcUnitClockGatingDisableInUcgctl6 applies only until BXT B0 according to bspec. Cc: Imre Deak Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_pm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 3/3] drm/i915/glk: Turn on workarounds that apply to Geminilake too

2017-01-12 Thread Ander Conselvan de Oliveira
Apply workarounds to Geminilake, and annoatate those that are applied uncondionally when they apply to GLK based on the workaround database. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++-- drivers/gpu/drm/i915/intel_lrc.c| 6 +++--- dri

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number of iterations

2017-01-12 Thread Maarten Lankhorst
Op 12-01-17 om 12:12 schreef Mika Kahola: > In CI system, the default 64 iterations of this test may cause CRC overflow > warnings in dmesg when debugfs is enabled in kernel config. To keep dmesg > warning noise in minimum, let's run this test only once by default. > > Signed-off-by: Mika Kahola >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number of iterations

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 12:53:30PM +0100, Maarten Lankhorst wrote: > Op 12-01-17 om 12:12 schreef Mika Kahola: > > In CI system, the default 64 iterations of this test may cause CRC overflow > > warnings in dmesg when debugfs is enabled in kernel config. To keep dmesg > > warning noise in minimum,

Re: [Intel-gfx] [PATCH 14/37] drm/i915: Simple selftest to exercise live requests

2017-01-12 Thread Tvrtko Ursulin
On 11/01/2017 21:09, Chris Wilson wrote: Just create several batches of requests and expect it to not fall over! Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_gem_request.c | 78 ++ .../gpu/drm/i915/selftests/i915_live_selftests.h | 1 + 2 files c

Re: [Intel-gfx] [PATCH 14/37] drm/i915: Simple selftest to exercise live requests

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 12:10:08PM +, Tvrtko Ursulin wrote: > > On 11/01/2017 21:09, Chris Wilson wrote: > >Just create several batches of requests and expect it to not fall over! > > > >Signed-off-by: Chris Wilson > >--- > > drivers/gpu/drm/i915/selftests/i915_gem_request.c | 78 > > ++

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number of iterations

2017-01-12 Thread Kahola, Mika
> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Thursday, January 12, 2017 2:00 PM > To: Maarten Lankhorst > Cc: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number > of iteratio

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Update i915.reset to handle engine resets

2017-01-12 Thread Joonas Lahtinen
On ke, 2017-01-11 at 20:18 -0800, Michel Thierry wrote: > From: Arun Siluvery > > In preparation for engine reset work update this parameter to handle more > than one type of reset. Default at the moment is still full gpu reset. > > Cc: Chris Wilson > Cc: Mika Kuoppala > Signed-off-by: Arun Si

Re: [Intel-gfx] [PATCH 25/37] drm/i915: Move i915_ppgtt_close() into i915_gem_gtt.c

2017-01-12 Thread Joonas Lahtinen
On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote: > Move it alongside its ppgtt counterparts, in order to make it available > for the ppgtt selftests. > > Signed-off-by: Chris Wilson Positive side-effects. Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Techno

Re: [Intel-gfx] [PATCH 26/37] drm/i915: Assert that we have allocated the drm_mm_node upon pinning

2017-01-12 Thread Joonas Lahtinen
On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote: > We currently check after the slow path that the vma is bound correctly, > but we don't currently check after the fast path. This is important in > case we accidentally take the fast path and leave the vma misplaced. > > Signed-off-by: Chris W

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove useless casts to intel_plane_state

2017-01-12 Thread Patchwork
== Series Details == Series: drm/i915: Remove useless casts to intel_plane_state URL : https://patchwork.freedesktop.org/series/17894/ State : success == Summary == Series 17894v1 drm/i915: Remove useless casts to intel_plane_state https://patchwork.freedesktop.org/api/1.0/series/17894/revisio

[Intel-gfx] [PATCH] drm/i915: Declare i915_gem_object_create_internal() as taking phys_addr_t size

2017-01-12 Thread Chris Wilson
The internal object is a collection of struct pages and so is intrinsically linked to the available physical memory on the machine, and not an arbitrary type from the uabi. Use phys_addr_t so the link between size and memory consumption is clear, and then double check that we don't overflow the max

[Intel-gfx] [PATCH v2] drm/i915: Declare i915_gem_object_create_internal() as taking phys_addr_t size

2017-01-12 Thread Chris Wilson
The internal object is a collection of struct pages and so is intrinsically linked to the available physical memory on the machine, and not an arbitrary type from the uabi. Use phys_addr_t so the link between size and memory consumption is clear, and then double check that we don't overflow the max

Re: [Intel-gfx] [PATCH 03/10] drm/i915: Update i915.reset to handle engine resets

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 02:22:21PM +0200, Joonas Lahtinen wrote: > On ke, 2017-01-11 at 20:18 -0800, Michel Thierry wrote: > > From: Arun Siluvery > > > > In preparation for engine reset work update this parameter to handle more > > than one type of reset. Default at the moment is still full gpu

Re: [Intel-gfx] [PATCH 09/37] drm/i915: Mock infrastructure for request emission

2017-01-12 Thread Tvrtko Ursulin
On 11/01/2017 21:09, Chris Wilson wrote: Create a fake engine that runs requests using a timer to simulate hw. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_context.c| 4 + drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c | 11 +- drivers/gpu/drm/i915/selftest

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove WaDisableLSQCROPERFforOCL KBL workaround. (rev2)

2017-01-12 Thread Patchwork
== Series Details == Series: drm/i915: Remove WaDisableLSQCROPERFforOCL KBL workaround. (rev2) URL : https://patchwork.freedesktop.org/series/17659/ State : success == Summary == Series 17659v2 drm/i915: Remove WaDisableLSQCROPERFforOCL KBL workaround. https://patchwork.freedesktop.org/api/1.0

Re: [Intel-gfx] [PATCH 09/37] drm/i915: Mock infrastructure for request emission

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 01:11:50PM +, Tvrtko Ursulin wrote: > > On 11/01/2017 21:09, Chris Wilson wrote: > >+struct i915_gem_context * > >+mock_context(struct drm_i915_private *i915, > >+ const char *name) > >+{ > >+struct i915_gem_context *ctx; > >+int ret; > >+ > >+ctx =

Re: [Intel-gfx] [PATCH 27/37] drm/i915: Exercising filling the top/bottom portions of the ppgtt

2017-01-12 Thread Joonas Lahtinen
On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote: > Allocate objects with varying number of pages (which should hopefully > consist of a mixture of contiguous page chunks and so coalesced sg > lists) and check that the sg walkers in insert_pages cope. > > Signed-off-by: Chris Wilson >  str

Re: [Intel-gfx] [PATCH v2] drm/i915: Declare i915_gem_object_create_internal() as taking phys_addr_t size

2017-01-12 Thread Joonas Lahtinen
On to, 2017-01-12 at 13:04 +, Chris Wilson wrote: > The internal object is a collection of struct pages and so is > intrinsically linked to the available physical memory on the machine, > and not an arbitrary type from the uabi. Use phys_addr_t so the link > between size and memory consumption

Re: [Intel-gfx] [PATCH i-g-t 1/5] tests/kms_plane_multiple: Add TEST_ONLY flag

2017-01-12 Thread Maarten Lankhorst
Op 30-12-16 om 13:00 schreef Mika Kahola: > Add TEST_ONLY flag to test atomic modesetting commits without > actual real-life commit. > > Signed-off-by: Mika Kahola > --- > tests/kms_plane_multiple.c | 79 > -- > 1 file changed, 49 insertions(+), 30 del

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2017-01-12 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB upon insertion URL : https://patchwork.freedesktop.org/series/17898/ State : failure == Summary == Series 17898v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/17898

Re: [Intel-gfx] [PATCHv2] drm/i915: Remove WaDisableLSQCROPERFforOCL KBL workaround.

2017-01-12 Thread Mika Kuoppala
Francisco Jerez writes: > Daniel Vetter writes: > >> On Wed, Jan 11, 2017 at 12:24:59PM +, Chris Wilson wrote: >>> On Wed, Jan 11, 2017 at 02:07:37PM +0200, Mika Kuoppala wrote: >>> > Daniel Vetter writes: >>> > >>> > > On Mon, Jan 09, 2017 at 01:07:56PM -0800, Francisco Jerez wrote: >>> >

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 01:53:40PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/2] drm/i915: Invalidate the guc ggtt TLB > upon insertion > URL : https://patchwork.freedesktop.org/series/17898/ > State : failure > > == Summary == > > Series 17898v1 Ser

Re: [Intel-gfx] [PATCH 28/37] drm/i915: Exercising filling the top/bottom portions of the global GTT

2017-01-12 Thread Joonas Lahtinen
On ke, 2017-01-11 at 21:09 +, Chris Wilson wrote: > Same test as previously for the per-process GTT instead applied to the > global GTT. > > Signed-off-by: Chris Wilson > @@ -218,28 +209,94 @@ static int igt_ppgtt_fill(void *arg) >   >   list_for_each_entry_safe(obj, on, &objec

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Pack the partial view size and offset into a single u64

2017-01-12 Thread Chris Wilson
On Wed, Jan 11, 2017 at 09:51:02PM +, Chris Wilson wrote: > Since the partial offset must be page aligned, we can use those low 12 > bits to encode the size of the partial view (which then cannot be larger > than 8MiB in pages). A requirement for avoiding unused bits inside the > struct is impo

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Update i915_reset parameter for kerneldoc

2017-01-12 Thread Mika Kuoppala
Michel Thierry writes: > Since commit c033666a94b57 ("drm/i915: Store a i915 backpointer from > engine, and use it") i915_reset receives dev_priv, but the kerneldoc > was not updated. > > Signed-off-by: Michel Thierry Pushed patches 01/10 and 02/10. Thanks for patches and review. -Mika > --- >

[Intel-gfx] [PULL] drm-intel-fixes

2017-01-12 Thread Jani Nikula
Hi Dave - Mostly GVT-g fixes, with a couple of other fixes from Chris. BR, Jani. The following changes since commit a121103c922847ba5010819a3f250f1f7fc84ab8: Linux 4.10-rc3 (2017-01-08 14:18:17 -0800) are available in the git repository at: git://anongit.freedesktop.org/git/drm-intel tag

Re: [Intel-gfx] [PATCH v2 2/5] drm/edid: Introduce drm_default_rgb_quant_range()

2017-01-12 Thread Ville Syrjälä
On Thu, Jan 12, 2017 at 11:29:18AM +0200, Jani Nikula wrote: > On Wed, 11 Jan 2017, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Make the code selecting the RGB quantization range a little less magicy > > by wrapping it up in a small helper. > > > > v2: s/adjusted_mode/mode

Re: [Intel-gfx] [PATCH 06/37] drm/i915: Add unit tests for the breadcrumb rbtree, wakeups

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 11:11:20AM +, Tvrtko Ursulin wrote: > > On 11/01/2017 21:09, Chris Wilson wrote: > >Third retroactive test, make sure that the seqno waiters are woken. > > There are some open questions from the previous round (early > December), not least of which is that I think we r

Re: [Intel-gfx] [PATCH] drm/i915: Remove useless casts to intel_plane_state

2017-01-12 Thread Maarten Lankhorst
Op 12-01-17 om 10:58 schreef Ville Syrjälä: > On Thu, Jan 12, 2017 at 10:43:45AM +0100, Maarten Lankhorst wrote: >> The visible member used to be in intel_plane_state->visible, >> but has been moved to drm_plane_state->visible. In the conversion >> some casts were left in that are now useless. >> >

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Rob Clark
On Thu, Jan 12, 2017 at 4:38 AM, Ville Syrjälä wrote: > On Wed, Jan 11, 2017 at 08:43:16PM -0500, Rob Clark wrote: >> On Wed, Jan 11, 2017 at 7:51 PM, Ben Widawsky wrote: >> > >> > +struct drm_format_modifier { >> > + /* Bitmask of formats in get_plane format list this info >> > +*

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-12 Thread Tvrtko Ursulin
On 12/01/2017 11:33, Chris Wilson wrote: On Wed, Jan 11, 2017 at 09:51:03PM +, Chris Wilson wrote: In preparation for the next patch to convert to using an anonymous union and leaving the excess bytes in the union uninitialised, we first need to make sure we do not compare using those unini

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare()

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 03:00:20PM +, Tvrtko Ursulin wrote: > > On 12/01/2017 11:33, Chris Wilson wrote: > >On Wed, Jan 11, 2017 at 09:51:03PM +, Chris Wilson wrote: > >>In preparation for the next patch to convert to using an anonymous union > >>and leaving the excess bytes in the union u

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Expand ggtt_view paramters for debugfs (rev3)

2017-01-12 Thread Patchwork
== Series Details == Series: drm/i915: Expand ggtt_view paramters for debugfs (rev3) URL : https://patchwork.freedesktop.org/series/17896/ State : success == Summary == Series 17896v3 drm/i915: Expand ggtt_view paramters for debugfs https://patchwork.freedesktop.org/api/1.0/series/17896/revisi

Re: [Intel-gfx] [PATCH] drm/i915/huc: Add HuC fw loading support

2017-01-12 Thread Srivatsa, Anusha
>-Original Message- >From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] >Sent: Wednesday, January 11, 2017 6:24 AM >To: Wajdeczko, Michal >Cc: Srivatsa, Anusha ; intel- >g...@lists.freedesktop.org; Alex Dai ; Peter Antoine > >Subject: Re: [Intel-gfx] [PATCH] drm/i915/huc: Add HuC fw lo

Re: [Intel-gfx] [RFC PATCH 2/3] drm/i915: IOMMU based SVM implementation v16

2017-01-12 Thread Mika Kuoppala
Chris Wilson writes: > On Mon, Jan 09, 2017 at 06:52:53PM +0200, Mika Kuoppala wrote: >> +static int i915_gem_context_enable_svm(struct i915_gem_context *ctx) >> +{ >> +int ret; >> + >> +if (!HAS_SVM(ctx->i915)) >> +return -ENODEV; > > How does legacy execbuf work with an svm

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Add name for WaDisablePWMClockGating workaround

2017-01-12 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Add name for WaDisablePWMClockGating workaround URL : https://patchwork.freedesktop.org/series/17904/ State : success == Summary == Series 17904v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/179

  1   2   >